@atlaspack/runtime-js 2.12.1-canary.3567 → 2.12.1-canary.3568

package/lib/JSRuntime.js

@@ -406,9 +406,12 @@ function getLoaderRuntime({
     let conditionalDependencies = externalBundles.flatMap(to => getDependencies(to).conditionalDependencies);
     for (const cond of bundleGraph.getConditionsForDependencies(conditionalDependencies, bundle)) {
       // This bundle has a conditional dependency, we need to load the bundle group
-
-      // Load conditional bundles with helper (and a dev mode with additional hints)
-      loaderModules.push(`require('./helpers/conditional-loader${options.mode === 'development' ? '-dev' : ''}')('${cond.key}', function (){return Promise.all([${cond.ifTrueBundles.map(targetBundle => getLoaderForBundle(bundle, targetBundle)).join(',')}]);}, function (){return Promise.all([${cond.ifFalseBundles.map(targetBundle => getLoaderForBundle(bundle, targetBundle)).join(',')}]);})`);
+      const ifTrueLoaders = cond.ifTrueBundles.map(targetBundle => getLoaderForBundle(bundle, targetBundle));
+      const ifFalseLoaders = cond.ifFalseBundles.map(targetBundle => getLoaderForBundle(bundle, targetBundle));
+      if (ifTrueLoaders.length > 0 || ifFalseLoaders.length > 0) {
+        // Load conditional bundles with helper (and a dev mode with additional hints)
+        loaderModules.push(`require('./helpers/conditional-loader${options.mode === 'development' ? '-dev' : ''}')('${cond.key}', function (){return Promise.all([${ifTrueLoaders.join(',')}]);}, function (){return Promise.all([${ifFalseLoaders.join(',')}]);})`);
+      }
     }
   }
   for (let to of externalBundles) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@atlaspack/runtime-js",
-  "version": "2.12.1-canary.3567+e0effea53",
+  "version": "2.12.1-canary.3568+2bb7fb28f",
   "license": "(MIT OR Apache-2.0)",
   "publishConfig": {
     "access": "public"
@@ -12,15 +12,15 @@
   "main": "lib/JSRuntime.js",
   "source": "src/JSRuntime.js",
   "engines": {
-    "atlaspack": "2.12.1-canary.3567+e0effea53",
+    "atlaspack": "2.12.1-canary.3568+2bb7fb28f",
     "node": ">= 16.0.0"
   },
   "dependencies": {
-    "@atlaspack/diagnostic": "2.12.1-canary.3567+e0effea53",
-    "@atlaspack/feature-flags": "2.12.1-canary.3567+e0effea53",
-    "@atlaspack/plugin": "2.12.1-canary.3567+e0effea53",
-    "@atlaspack/utils": "2.12.1-canary.3567+e0effea53",
+    "@atlaspack/diagnostic": "2.12.1-canary.3568+2bb7fb28f",
+    "@atlaspack/feature-flags": "2.12.1-canary.3568+2bb7fb28f",
+    "@atlaspack/plugin": "2.12.1-canary.3568+2bb7fb28f",
+    "@atlaspack/utils": "2.12.1-canary.3568+2bb7fb28f",
     "nullthrows": "^1.1.1"
   },
-  "gitHead": "e0effea53c21b3c3e3bc9d368468c562e5f80531"
+  "gitHead": "2bb7fb28f58d6d8e17c7917c4d0be72df125c328"
 }

package/src/JSRuntime.js

@@ -483,17 +483,27 @@ function getLoaderRuntime({
       bundle,
     )) {
       // This bundle has a conditional dependency, we need to load the bundle group
-
-      // Load conditional bundles with helper (and a dev mode with additional hints)
-      loaderModules.push(
-        `require('./helpers/conditional-loader${
-          options.mode === 'development' ? '-dev' : ''
-        }')('${cond.key}', function (){return Promise.all([${cond.ifTrueBundles
-          .map((targetBundle) => getLoaderForBundle(bundle, targetBundle))
-          .join(',')}]);}, function (){return Promise.all([${cond.ifFalseBundles
-          .map((targetBundle) => getLoaderForBundle(bundle, targetBundle))
-          .join(',')}]);})`,
+      const ifTrueLoaders = cond.ifTrueBundles.map((targetBundle) =>
+        getLoaderForBundle(bundle, targetBundle),
+      );
+      const ifFalseLoaders = cond.ifFalseBundles.map((targetBundle) =>
+        getLoaderForBundle(bundle, targetBundle),
       );
+
+      if (ifTrueLoaders.length > 0 || ifFalseLoaders.length > 0) {
+        // Load conditional bundles with helper (and a dev mode with additional hints)
+        loaderModules.push(
+          `require('./helpers/conditional-loader${
+            options.mode === 'development' ? '-dev' : ''
+          }')('${
+            cond.key
+          }', function (){return Promise.all([${ifTrueLoaders.join(
+            ',',
+          )}]);}, function (){return Promise.all([${ifFalseLoaders.join(
+            ',',
+          )}]);})`,
+        );
+      }
     }
   }