@atlaspack/reporter-conditional-manifest 2.14.5-canary.16 → 2.14.5-canary.161

package/CHANGELOG.md

@@ -1,5 +1,163 @@
 # @atlaspack/reporter-conditional-manifest
 
+## 2.15.7
+
+### Patch Changes
+
+- Updated dependencies [[`f6b3f22`](https://github.com/atlassian-labs/atlaspack/commit/f6b3f2276c7e417580b49c4879563aab51f156b1)]:
+  - @atlaspack/feature-flags@2.23.0
+  - @atlaspack/plugin@2.14.25
+
+## 2.15.6
+
+### Patch Changes
+
+- Updated dependencies [[`73dd7ba`](https://github.com/atlassian-labs/atlaspack/commit/73dd7baab69456ef2f6e4a0cc7dbb04f407eb148)]:
+  - @atlaspack/feature-flags@2.22.0
+  - @atlaspack/plugin@2.14.24
+
+## 2.15.5
+
+### Patch Changes
+
+- Updated dependencies [[`23d561e`](https://github.com/atlassian-labs/atlaspack/commit/23d561e51e68b0c38fd1ff4e4fb173e5e7b01cf2)]:
+  - @atlaspack/feature-flags@2.21.0
+  - @atlaspack/plugin@2.14.23
+
+## 2.15.4
+
+### Patch Changes
+
+- [#720](https://github.com/atlassian-labs/atlaspack/pull/720) [`d2fd849`](https://github.com/atlassian-labs/atlaspack/commit/d2fd849770fe6305e9c694bd97b1bd905abd9d94) Thanks [@alshdavid](https://github.com/alshdavid)! - Migrate to TypeScript
+
+- Updated dependencies [[`d2fd849`](https://github.com/atlassian-labs/atlaspack/commit/d2fd849770fe6305e9c694bd97b1bd905abd9d94), [`12bee0e`](https://github.com/atlassian-labs/atlaspack/commit/12bee0e23f0464d7f6bd3e24fbe0d19c126d587d)]:
+  - @atlaspack/feature-flags@2.20.1
+  - @atlaspack/plugin@2.14.22
+
+## 2.15.3
+
+### Patch Changes
+
+- Updated dependencies [[`069de47`](https://github.com/atlassian-labs/atlaspack/commit/069de478e64fb5889f6f2ce023eb510782767fbd)]:
+  - @atlaspack/feature-flags@2.20.0
+  - @atlaspack/plugin@2.14.21
+
+## 2.15.2
+
+### Patch Changes
+
+- Updated dependencies [[`daaa768`](https://github.com/atlassian-labs/atlaspack/commit/daaa7688786772d7e3713b71c5bba6b89ec704aa), [`1c7865a`](https://github.com/atlassian-labs/atlaspack/commit/1c7865a64451116d94015e248302435839d347c0), [`a0b959f`](https://github.com/atlassian-labs/atlaspack/commit/a0b959fbf61fc3f820ff03c7e8988945fe40a91a)]:
+  - @atlaspack/plugin@2.14.20
+  - @atlaspack/feature-flags@2.19.2
+
+## 2.15.1
+
+### Patch Changes
+
+- Updated dependencies [[`13aef17`](https://github.com/atlassian-labs/atlaspack/commit/13aef177eea289a6e40d2113b5ec1ac9be18a33d)]:
+  - @atlaspack/feature-flags@2.19.1
+  - @atlaspack/plugin@2.14.19
+
+## 2.15.0
+
+### Minor Changes
+
+- [#640](https://github.com/atlassian-labs/atlaspack/pull/640) [`dbb4072`](https://github.com/atlassian-labs/atlaspack/commit/dbb40721ebeb45990a14ba04e6b44e7f836fb32d) Thanks [@JakeLane](https://github.com/JakeLane)! - Clean up conditional bundling feature flags
+
+### Patch Changes
+
+- Updated dependencies [[`dbb4072`](https://github.com/atlassian-labs/atlaspack/commit/dbb40721ebeb45990a14ba04e6b44e7f836fb32d), [`becf977`](https://github.com/atlassian-labs/atlaspack/commit/becf977f625d5ee46dae3d4c679f173bf5f40cc0), [`c4415a4`](https://github.com/atlassian-labs/atlaspack/commit/c4415a455543d984ca28452c2cb87a794d22497c), [`f0f7c71`](https://github.com/atlassian-labs/atlaspack/commit/f0f7c7168a1d3d18c6f30d2daed611275692b7c5), [`18a57cf`](https://github.com/atlassian-labs/atlaspack/commit/18a57cf8a4789b2de5ad8e2676f317a26cc91417)]:
+  - @atlaspack/feature-flags@2.19.0
+  - @atlaspack/plugin@2.14.18
+
+## 2.14.17
+
+### Patch Changes
+
+- Updated dependencies []:
+  - @atlaspack/plugin@2.14.17
+
+## 2.14.16
+
+### Patch Changes
+
+- Updated dependencies [[`e8a60ff`](https://github.com/atlassian-labs/atlaspack/commit/e8a60ffbea41caef265786bbf73349771760081c)]:
+  - @atlaspack/feature-flags@2.18.4
+  - @atlaspack/plugin@2.14.16
+
+## 2.14.15
+
+### Patch Changes
+
+- Updated dependencies [[`5ded263`](https://github.com/atlassian-labs/atlaspack/commit/5ded263c7f11b866e8885b81c73e20dd060b25be)]:
+  - @atlaspack/feature-flags@2.18.3
+  - @atlaspack/plugin@2.14.15
+
+## 2.14.14
+
+### Patch Changes
+
+- Updated dependencies [[`644b157`](https://github.com/atlassian-labs/atlaspack/commit/644b157dee72a871acc2d0facf0b87b8eea51956)]:
+  - @atlaspack/feature-flags@2.18.2
+  - @atlaspack/plugin@2.14.14
+
+## 2.14.13
+
+### Patch Changes
+
+- Updated dependencies [[`26aa9c5`](https://github.com/atlassian-labs/atlaspack/commit/26aa9c599d2be45ce1438a74c5fa22f39b9b554b), [`0501255`](https://github.com/atlassian-labs/atlaspack/commit/05012550da35b05ce7d356a8cc29311e7f9afdca)]:
+  - @atlaspack/feature-flags@2.18.1
+  - @atlaspack/plugin@2.14.13
+
+## 2.14.12
+
+### Patch Changes
+
+- Updated dependencies [[`10fbcfb`](https://github.com/atlassian-labs/atlaspack/commit/10fbcfbfa49c7a83da5d7c40983e36e87f524a75), [`85c52d3`](https://github.com/atlassian-labs/atlaspack/commit/85c52d3f7717b3c84a118d18ab98cfbfd71dcbd2)]:
+  - @atlaspack/feature-flags@2.18.0
+  - @atlaspack/plugin@2.14.12
+
+## 2.14.11
+
+### Patch Changes
+
+- Updated dependencies [[`73ea3c4`](https://github.com/atlassian-labs/atlaspack/commit/73ea3c4d85d4401fdd15abcbf988237e890e7ad3), [`b1b3693`](https://github.com/atlassian-labs/atlaspack/commit/b1b369317c66f8a431c170df2ebba4fa5b2e38ef)]:
+  - @atlaspack/feature-flags@2.17.0
+  - @atlaspack/plugin@2.14.11
+
+## 2.14.10
+
+### Patch Changes
+
+- Updated dependencies []:
+  - @atlaspack/plugin@2.14.10
+
+## 2.14.9
+
+### Patch Changes
+
+- [#503](https://github.com/atlassian-labs/atlaspack/pull/503) [`209692f`](https://github.com/atlassian-labs/atlaspack/commit/209692ffb11eae103a0d65c5e1118a5aa1625818) Thanks [@JakeLane](https://github.com/JakeLane)! - Fix conditional bundling reporter when condition is reused
+
+- Updated dependencies [[`209692f`](https://github.com/atlassian-labs/atlaspack/commit/209692ffb11eae103a0d65c5e1118a5aa1625818), [`f4da1e1`](https://github.com/atlassian-labs/atlaspack/commit/f4da1e120e73eeb5e8b8927f05e88f04d6148c7b)]:
+  - @atlaspack/feature-flags@2.16.0
+  - @atlaspack/plugin@2.14.9
+
+## 2.14.8
+
+### Patch Changes
+
+- Updated dependencies [[`30f6017`](https://github.com/atlassian-labs/atlaspack/commit/30f60175ba4d272c5fc193973c63bc298584775b)]:
+  - @atlaspack/feature-flags@2.15.1
+  - @atlaspack/plugin@2.14.8
+
+## 2.14.7
+
+### Patch Changes
+
+- Updated dependencies [[`a1773d2`](https://github.com/atlassian-labs/atlaspack/commit/a1773d2a62d0ef7805ac7524621dcabcc1afe929)]:
+  - @atlaspack/feature-flags@2.15.0
+  - @atlaspack/plugin@2.14.7
+
 ## 2.14.6
 
 ### Patch Changes

package/lib/ConditionalManifestReporter.js

@@ -28,13 +28,6 @@ function _plugin() {
   return data;
 }
 var _Config = require("./Config");
-function _featureFlags() {
-  const data = require("@atlaspack/feature-flags");
-  _featureFlags = function () {
-    return data;
-  };
-  return data;
-}
 function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }
 const manifestHashes = exports.manifestHashes = new Map();
 const updateManifest = async (outputFS, logger, conditionalManifestFilename, conditionalManifest) => {
@@ -60,19 +53,21 @@ async function report({
     const bundles = event.bundleGraph.getConditionalBundleMapping();
 
     // Replace bundles with file paths
+    // @ts-expect-error TS2304
     const mapBundles = bundles => bundles.map(bundle => (0, _path().relative)(bundle.target.distDir, bundle.filePath));
     const manifest = {};
     for (const conditions of bundles.values()) {
-      const bundleInfo = {};
       for (const [key, cond] of conditions) {
+        var _manifest$bundle$targ, _bundleInfo$key, _bundleInfo$key2;
         const bundle = cond.bundle;
+        const relativeBundlePath = (0, _path().relative)(bundle.target.distDir, bundle.filePath);
+        const bundleInfo = ((_manifest$bundle$targ = manifest[bundle.target.name]) === null || _manifest$bundle$targ === void 0 ? void 0 : _manifest$bundle$targ[relativeBundlePath]) ?? {};
         bundleInfo[key] = {
-          // Reverse bundles so we load children bundles first
-          ifTrueBundles: mapBundles(cond.ifTrueBundles).reverse(),
-          ifFalseBundles: mapBundles(cond.ifFalseBundles).reverse()
+          ifTrueBundles: mapBundles(cond.ifTrueBundles).concat(((_bundleInfo$key = bundleInfo[key]) === null || _bundleInfo$key === void 0 ? void 0 : _bundleInfo$key.ifTrueBundles) ?? []).sort(),
+          ifFalseBundles: mapBundles(cond.ifFalseBundles).concat(((_bundleInfo$key2 = bundleInfo[key]) === null || _bundleInfo$key2 === void 0 ? void 0 : _bundleInfo$key2.ifFalseBundles) ?? []).sort()
         };
         manifest[bundle.target.name] ??= {};
-        manifest[bundle.target.name][(0, _path().relative)(bundle.target.distDir, bundle.filePath)] = bundleInfo;
+        manifest[bundle.target.name][relativeBundlePath] = bundleInfo;
       }
     }
     const targets = new Set(event.bundleGraph.getBundles().map(bundle => bundle.target));
@@ -84,20 +79,12 @@ async function report({
       const conditionalManifest = JSON.stringify(
       // If there's no content, send an empty manifest so we can still map from it safely
       manifest[target.name] ?? {}, null, 2);
-      if ((0, _featureFlags().getFeatureFlag)('conditionalBundlingReporterDuplicateFix')) {
-        await updateManifest(options.outputFS, logger, conditionalManifestFilename, conditionalManifest);
-      } else {
-        await options.outputFS.mkdirp((0, _path().dirname)(conditionalManifestFilename));
-        await options.outputFS.writeFile(conditionalManifestFilename, conditionalManifest, {
-          mode: 0o666
-        });
-        logger.info({
-          message: 'Wrote conditional manifest to ' + conditionalManifestFilename
-        });
-      }
+      await updateManifest(options.outputFS, logger, conditionalManifestFilename, conditionalManifest);
     }
   }
 }
+
+// @ts-expect-error TS2322
 var _default = exports.default = new (_plugin().Reporter)({
   report
 });

package/lib/types/ConditionalManifestReporter.d.ts

@@ -0,0 +1,12 @@
+import { Reporter } from '@atlaspack/plugin';
+import type { Async, PluginLogger, PluginOptions, PluginTracer, ReporterEvent, FileSystem, FilePath } from '@atlaspack/types-internal';
+export declare const manifestHashes: Map<FilePath, string>;
+export declare const updateManifest: (outputFS: FileSystem, logger: PluginLogger, conditionalManifestFilename: FilePath, conditionalManifest: string) => Promise<void>;
+export declare function report({ event, options, logger, }: {
+    event: ReporterEvent;
+    options: PluginOptions;
+    logger: PluginLogger;
+    tracer: PluginTracer;
+}): Promise<Async<void>>;
+declare const _default: Reporter;
+export default _default;

package/lib/types/Config.d.ts

@@ -0,0 +1,6 @@
+import type { PluginOptions } from '@atlaspack/types-internal';
+type Config = {
+    filename: string;
+};
+export declare function getConfig({ env, inputFS, projectRoot, }: PluginOptions): Promise<Config>;
+export {};

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@atlaspack/reporter-conditional-manifest",
-  "version": "2.14.5-canary.16+4b2b575b9",
+  "version": "2.14.5-canary.161+ee040bb64",
   "license": "MIT",
   "publishConfig": {
     "access": "public"
@@ -9,16 +9,21 @@
     "type": "git",
     "url": "https://github.com/atlassian-labs/atlaspack.git"
   },
-  "main": "lib/ConditionalManifestReporter.js",
-  "source": "src/ConditionalManifestReporter.js",
+  "main": "./lib/ConditionalManifestReporter.js",
+  "source": "./src/ConditionalManifestReporter.ts",
+  "types": "./lib/types/ConditionalManifestReporter.d.ts",
   "engines": {
     "node": ">= 16.0.0"
   },
   "dependencies": {
-    "@atlaspack/feature-flags": "2.14.1-canary.84+4b2b575b9",
-    "@atlaspack/plugin": "2.14.5-canary.16+4b2b575b9",
+    "@atlaspack/feature-flags": "2.14.1-canary.229+ee040bb64",
+    "@atlaspack/plugin": "2.14.5-canary.161+ee040bb64",
     "nullthrows": "^1.1.1"
   },
   "type": "commonjs",
-  "gitHead": "4b2b575b98951f2dcf0c45ed8e94359b23b43815"
+  "scripts": {
+    "check-ts": "tsc --emitDeclarationOnly --rootDir src",
+    "build:lib": "gulp build --gulpfile ../../../gulpfile.js --cwd ."
+  },
+  "gitHead": "ee040bb6428f29b57d892ddd8107e29077d08ffd"
 }

package/src/{ConditionalManifestReporter.js → ConditionalManifestReporter.ts}

@@ -1,4 +1,3 @@
-// @flow strict-local
 import {relative, join, dirname} from 'path';
 import crypto from 'crypto';
 import {Reporter} from '@atlaspack/plugin';
@@ -12,7 +11,6 @@ import type {
   FilePath,
 } from '@atlaspack/types-internal';
 import {getConfig} from './Config';
-import {getFeatureFlag} from '@atlaspack/feature-flags';
 
 export const manifestHashes: Map<FilePath, string> = new Map();
 
@@ -45,33 +43,43 @@ export async function report({
   event,
   options,
   logger,
-}: {|
-  event: ReporterEvent,
-  options: PluginOptions,
-  logger: PluginLogger,
-  tracer: PluginTracer,
-|}): Async<void> {
+}: {
+  event: ReporterEvent;
+  options: PluginOptions;
+  logger: PluginLogger;
+  tracer: PluginTracer;
+}): Promise<Async<void>> {
   if (event.type === 'buildSuccess') {
     const bundles = event.bundleGraph.getConditionalBundleMapping();
 
     // Replace bundles with file paths
-    const mapBundles = (bundles) =>
+    // @ts-expect-error TS2304
+    const mapBundles = (bundles: Array<PackagedBundle>) =>
       bundles.map((bundle) => relative(bundle.target.distDir, bundle.filePath));
 
-    const manifest = {};
+    const manifest: Record<string, any> = {};
     for (const conditions of bundles.values()) {
-      const bundleInfo = {};
       for (const [key, cond] of conditions) {
         const bundle = cond.bundle;
+        const relativeBundlePath = relative(
+          bundle.target.distDir,
+          bundle.filePath,
+        );
+
+        const bundleInfo =
+          manifest[bundle.target.name]?.[relativeBundlePath] ?? {};
+
         bundleInfo[key] = {
-          // Reverse bundles so we load children bundles first
-          ifTrueBundles: mapBundles(cond.ifTrueBundles).reverse(),
-          ifFalseBundles: mapBundles(cond.ifFalseBundles).reverse(),
+          ifTrueBundles: mapBundles(cond.ifTrueBundles)
+            .concat(bundleInfo[key]?.ifTrueBundles ?? [])
+            .sort(),
+          ifFalseBundles: mapBundles(cond.ifFalseBundles)
+            .concat(bundleInfo[key]?.ifFalseBundles ?? [])
+            .sort(),
         };
+
         manifest[bundle.target.name] ??= {};
-        manifest[bundle.target.name][
-          relative(bundle.target.distDir, bundle.filePath)
-        ] = bundleInfo;
+        manifest[bundle.target.name][relativeBundlePath] = bundleInfo;
       }
     }
 
@@ -90,28 +98,15 @@ export async function report({
         2,
       );
 
-      if (getFeatureFlag('conditionalBundlingReporterDuplicateFix')) {
-        await updateManifest(
-          options.outputFS,
-          logger,
-          conditionalManifestFilename,
-          conditionalManifest,
-        );
-      } else {
-        await options.outputFS.mkdirp(dirname(conditionalManifestFilename));
-        await options.outputFS.writeFile(
-          conditionalManifestFilename,
-          conditionalManifest,
-          {mode: 0o666},
-        );
-
-        logger.info({
-          message:
-            'Wrote conditional manifest to ' + conditionalManifestFilename,
-        });
-      }
+      await updateManifest(
+        options.outputFS,
+        logger,
+        conditionalManifestFilename,
+        conditionalManifest,
+      );
     }
   }
 }
 
-export default (new Reporter({report}): Reporter);
+// @ts-expect-error TS2322
+export default new Reporter({report}) as Reporter;

package/src/{Config.js → Config.ts}

@@ -1,10 +1,9 @@
-// @flow strict-local
 import {join} from 'path';
 import type {PluginOptions} from '@atlaspack/types-internal';
 
-type Config = {|
-  filename: string,
-|};
+type Config = {
+  filename: string;
+};
 
 export async function getConfig({
   env,

package/test/{ConditionalManifestReporter.test.js → ConditionalManifestReporter.test.ts}

@@ -1,4 +1,3 @@
-// @flow strict-local
 import {
   manifestHashes,
   updateManifest,

package/test/{Config.test.js → Config.test.ts}

@@ -1,4 +1,3 @@
-// @flow strict-local
 import type {PluginOptions, EnvMap} from '@atlaspack/types-internal';
 
 import {NodePackageManager} from '@atlaspack/package-manager';
@@ -7,7 +6,7 @@ import {overlayFS, fsFixture} from '@atlaspack/test-utils';
 import assert from 'assert';
 import {DEFAULT_FEATURE_FLAGS} from '@atlaspack/feature-flags';
 
-function getPluginOptions({env}: {env?: EnvMap, ...}): PluginOptions {
+function getPluginOptions({env}: {env?: EnvMap}): PluginOptions {
   return {
     mode: 'development',
     parcelVersion: 'version',

package/tsconfig.json

@@ -0,0 +1,4 @@
+{
+  "extends": "../../../tsconfig.json",
+  "include": ["src"]
+}