@atlaspack/packager-js 2.24.9-dev-swc44-53cdb819f.0 → 2.24.9

package/CHANGELOG.md

@@ -1,5 +1,21 @@
 # @atlaspack/packager-js
 
+## 2.24.9
+
+### Patch Changes
+
+- [#953](https://github.com/atlassian-labs/atlaspack/pull/953) [`c31090c`](https://github.com/atlassian-labs/atlaspack/commit/c31090c9025f35d3fa8561b42dca170853a32e6f) Thanks [@marcins](https://github.com/marcins)! - Cleanup feature flag precomputeReferencedAssets
+
+- [#950](https://github.com/atlassian-labs/atlaspack/pull/950) [`cd7e2c2`](https://github.com/atlassian-labs/atlaspack/commit/cd7e2c2bbaad08f3f045a86691bfd4f9879b0b44) Thanks [@marcins](https://github.com/marcins)! - Improve error message when asset is not found in packaging.
+
+- Updated dependencies [[`47aa84e`](https://github.com/atlassian-labs/atlaspack/commit/47aa84e44c61066072a5bf3d57678565b9d2c5a3), [`564fb4f`](https://github.com/atlassian-labs/atlaspack/commit/564fb4fecc2a20bdeb951863a8fac29b618d91b7), [`9df722c`](https://github.com/atlassian-labs/atlaspack/commit/9df722c38b225054883693ba9731344f701767a7), [`c31090c`](https://github.com/atlassian-labs/atlaspack/commit/c31090c9025f35d3fa8561b42dca170853a32e6f), [`565bab3`](https://github.com/atlassian-labs/atlaspack/commit/565bab3771cc334659d873cabff4cdfac0860cc7), [`34b01ec`](https://github.com/atlassian-labs/atlaspack/commit/34b01ec03e2264bd617be000465821e1ed11eae5), [`6e5fec1`](https://github.com/atlassian-labs/atlaspack/commit/6e5fec1406c53257be7e7fbe06c028beda70fcf1), [`e4e5522`](https://github.com/atlassian-labs/atlaspack/commit/e4e55222422d8c73653d3ea09f1a0d13946345b9)]:
+  - @atlaspack/utils@3.3.0
+  - @atlaspack/rust@3.18.0
+  - @atlaspack/feature-flags@2.27.6
+  - @atlaspack/source-map@3.2.3
+  - @atlaspack/types@2.15.38
+  - @atlaspack/plugin@2.14.48
+
 ## 2.24.8
 
 ### Patch Changes

package/dist/ScopeHoistingPackager.js

@@ -304,13 +304,11 @@ class ScopeHoistingPackager {
     // Helper to check if an asset is referenced, with cache-first + fast-check hybrid approach
     isAssetReferencedInBundle(bundle, asset) {
         // STEP 1: Check expensive computation cache first (fastest when it hits)
-        if ((0, feature_flags_1.getFeatureFlag)('precomputeReferencedAssets')) {
-            let bundleId = bundle.id;
-            let referencedAssets = this.referencedAssetsCache.get(bundleId);
-            if (referencedAssets) {
-                // Cache hit - fastest path (~0.001ms)
-                return referencedAssets.has(asset);
-            }
+        let bundleId = bundle.id;
+        let referencedAssets = this.referencedAssetsCache.get(bundleId);
+        if (referencedAssets) {
+            // Cache hit - fastest path (~0.001ms)
+            return referencedAssets.has(asset);
         }
         // STEP 2: Cache miss - try fast checks (~0.01ms)
         let fastCheckResult = this.bundleGraph.isAssetReferencedFastCheck(bundle, asset);
@@ -319,17 +317,10 @@ class ScopeHoistingPackager {
             return true;
         }
         // STEP 3: Need expensive computation (~20-2000ms)
-        if ((0, feature_flags_1.getFeatureFlag)('precomputeReferencedAssets')) {
-            // Compute and cache expensive results for this bundle
-            let bundleId = bundle.id;
-            let referencedAssets = this.bundleGraph.getReferencedAssets(bundle);
-            this.referencedAssetsCache.set(bundleId, referencedAssets);
-            return referencedAssets.has(asset);
-        }
-        else {
-            // No caching - fall back to original expensive method
-            return this.bundleGraph.isAssetReferenced(bundle, asset);
-        }
+        // Compute and cache expensive results for this bundle
+        referencedAssets = this.bundleGraph.getReferencedAssets(bundle);
+        this.referencedAssetsCache.set(bundleId, referencedAssets);
+        return referencedAssets.has(asset);
     }
     async loadAssets() {
         let queue = new utils_1.PromiseQueue({
@@ -1056,7 +1047,7 @@ ${code}
                 '<unknown>';
             let resolvedPath = path_1.default.relative(this.options.projectRoot, resolvedAsset.filePath) ||
                 '<unknown>';
-            (0, assert_1.default)(false, `Asset was skipped or not found.\nSearching for exported symbol "${imported}" (resolved as "${exportSymbol}") in asset with id "${resolvedAsset.meta.id}" (public id: "${publicId}", path: "${resolvedPath}") from parent asset "${parentAsset.meta.id}" (path: "${parentPath}").`);
+            (0, assert_1.default)(false, `Asset was skipped or not found when packaging ${this.bundle.name}.\nSearching for exported symbol "${imported}" (resolved as "${exportSymbol}") in asset with id "${resolvedAsset.meta.id}" (public id: "${publicId}", path: "${resolvedPath}") from parent asset "${parentAsset.meta.id}" (path: "${parentPath}").`);
         }
         else {
             return replacements?.get(symbol) || symbol;

package/lib/ScopeHoistingPackager.js

@@ -304,13 +304,12 @@ class ScopeHoistingPackager {
   // Helper to check if an asset is referenced, with cache-first + fast-check hybrid approach
   isAssetReferencedInBundle(bundle, asset) {
     // STEP 1: Check expensive computation cache first (fastest when it hits)
-    if ((0, _featureFlags().getFeatureFlag)('precomputeReferencedAssets')) {
-      let bundleId = bundle.id;
-      let referencedAssets = this.referencedAssetsCache.get(bundleId);
-      if (referencedAssets) {
-        // Cache hit - fastest path (~0.001ms)
-        return referencedAssets.has(asset);
-      }
+
+    let bundleId = bundle.id;
+    let referencedAssets = this.referencedAssetsCache.get(bundleId);
+    if (referencedAssets) {
+      // Cache hit - fastest path (~0.001ms)
+      return referencedAssets.has(asset);
     }
 
     // STEP 2: Cache miss - try fast checks (~0.01ms)
@@ -321,16 +320,11 @@ class ScopeHoistingPackager {
     }
 
     // STEP 3: Need expensive computation (~20-2000ms)
-    if ((0, _featureFlags().getFeatureFlag)('precomputeReferencedAssets')) {
-      // Compute and cache expensive results for this bundle
-      let bundleId = bundle.id;
-      let referencedAssets = this.bundleGraph.getReferencedAssets(bundle);
-      this.referencedAssetsCache.set(bundleId, referencedAssets);
-      return referencedAssets.has(asset);
-    } else {
-      // No caching - fall back to original expensive method
-      return this.bundleGraph.isAssetReferenced(bundle, asset);
-    }
+
+    // Compute and cache expensive results for this bundle
+    referencedAssets = this.bundleGraph.getReferencedAssets(bundle);
+    this.referencedAssetsCache.set(bundleId, referencedAssets);
+    return referencedAssets.has(asset);
   }
   async loadAssets() {
     let queue = new (_utils().PromiseQueue)({
@@ -1003,7 +997,7 @@ ${code}
     } else if (!symbol) {
       let parentPath = _path().default.relative(this.options.projectRoot, parentAsset.filePath) || '<unknown>';
       let resolvedPath = _path().default.relative(this.options.projectRoot, resolvedAsset.filePath) || '<unknown>';
-      (0, _assert().default)(false, `Asset was skipped or not found.\nSearching for exported symbol "${imported}" (resolved as "${exportSymbol}") in asset with id "${resolvedAsset.meta.id}" (public id: "${publicId}", path: "${resolvedPath}") from parent asset "${parentAsset.meta.id}" (path: "${parentPath}").`);
+      (0, _assert().default)(false, `Asset was skipped or not found when packaging ${this.bundle.name}.\nSearching for exported symbol "${imported}" (resolved as "${exportSymbol}") in asset with id "${resolvedAsset.meta.id}" (public id: "${publicId}", path: "${resolvedPath}") from parent asset "${parentAsset.meta.id}" (path: "${parentPath}").`);
     } else {
       return (replacements === null || replacements === void 0 ? void 0 : replacements.get(symbol)) || symbol;
     }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@atlaspack/packager-js",
-  "version": "2.24.9-dev-swc44-53cdb819f.0",
+  "version": "2.24.9",
   "license": "(MIT OR Apache-2.0)",
   "publishConfig": {
     "access": "public"
@@ -16,13 +16,13 @@
     "node": ">= 16.0.0"
   },
   "dependencies": {
-    "@atlaspack/diagnostic": "2.14.5-dev-swc44-53cdb819f.0",
-    "@atlaspack/feature-flags": "2.27.6-dev-swc44-53cdb819f.0",
-    "@atlaspack/plugin": "2.14.48-dev-swc44-53cdb819f.0",
-    "@atlaspack/rust": "3.17.1-dev-swc44-53cdb819f.0",
-    "@atlaspack/source-map": "3.2.3-dev-swc44-53cdb819f.0",
-    "@atlaspack/types": "2.15.38-dev-swc44-53cdb819f.0",
-    "@atlaspack/utils": "3.2.9-dev-swc44-53cdb819f.0",
+    "@atlaspack/diagnostic": "2.14.4",
+    "@atlaspack/feature-flags": "2.27.6",
+    "@atlaspack/plugin": "2.14.48",
+    "@atlaspack/rust": "3.18.0",
+    "@atlaspack/source-map": "3.2.3",
+    "@atlaspack/types": "2.15.38",
+    "@atlaspack/utils": "3.3.0",
     "globals": "^13.2.0",
     "nullthrows": "^1.1.1",
     "outdent": "^0.8.0"
@@ -30,6 +30,5 @@
   "type": "commonjs",
   "scripts": {
     "build:lib": "gulp build --gulpfile ../../../gulpfile.js --cwd ."
-  },
-  "gitHead": "53cdb819f1739c63fb7dc9769cdd64352c097f9a"
+  }
 }

package/src/ScopeHoistingPackager.ts

@@ -415,14 +415,13 @@ export class ScopeHoistingPackager {
   // Helper to check if an asset is referenced, with cache-first + fast-check hybrid approach
   isAssetReferencedInBundle(bundle: NamedBundle, asset: Asset): boolean {
     // STEP 1: Check expensive computation cache first (fastest when it hits)
-    if (getFeatureFlag('precomputeReferencedAssets')) {
-      let bundleId = bundle.id;
-      let referencedAssets = this.referencedAssetsCache.get(bundleId);
 
-      if (referencedAssets) {
-        // Cache hit - fastest path (~0.001ms)
-        return referencedAssets.has(asset);
-      }
+    let bundleId = bundle.id;
+    let referencedAssets = this.referencedAssetsCache.get(bundleId);
+
+    if (referencedAssets) {
+      // Cache hit - fastest path (~0.001ms)
+      return referencedAssets.has(asset);
     }
 
     // STEP 2: Cache miss - try fast checks (~0.01ms)
@@ -437,17 +436,12 @@ export class ScopeHoistingPackager {
     }
 
     // STEP 3: Need expensive computation (~20-2000ms)
-    if (getFeatureFlag('precomputeReferencedAssets')) {
-      // Compute and cache expensive results for this bundle
-      let bundleId = bundle.id;
-      let referencedAssets = this.bundleGraph.getReferencedAssets(bundle);
-      this.referencedAssetsCache.set(bundleId, referencedAssets);
 
-      return referencedAssets.has(asset);
-    } else {
-      // No caching - fall back to original expensive method
-      return this.bundleGraph.isAssetReferenced(bundle, asset);
-    }
+    // Compute and cache expensive results for this bundle
+    referencedAssets = this.bundleGraph.getReferencedAssets(bundle);
+    this.referencedAssetsCache.set(bundleId, referencedAssets);
+
+    return referencedAssets.has(asset);
   }
 
   async loadAssets() {
@@ -1395,7 +1389,7 @@ ${code}
         '<unknown>';
       invariant(
         false,
-        `Asset was skipped or not found.\nSearching for exported symbol "${imported}" (resolved as "${exportSymbol}") in asset with id "${resolvedAsset.meta.id}" (public id: "${publicId}", path: "${resolvedPath}") from parent asset "${parentAsset.meta.id}" (path: "${parentPath}").`,
+        `Asset was skipped or not found when packaging ${this.bundle.name}.\nSearching for exported symbol "${imported}" (resolved as "${exportSymbol}") in asset with id "${resolvedAsset.meta.id}" (public id: "${publicId}", path: "${resolvedPath}") from parent asset "${parentAsset.meta.id}" (path: "${parentPath}").`,
       );
     } else {
       return replacements?.get(symbol) || symbol;