@atlaspack/packager-js 2.22.3-dev-export-func-opt-67f87c28a.0 → 2.23.0

package/CHANGELOG.md

@@ -1,5 +1,22 @@
 # @atlaspack/packager-js
 
+## 2.23.0
+
+### Minor Changes
+
+- [#774](https://github.com/atlassian-labs/atlaspack/pull/774) [`602f8ed`](https://github.com/atlassian-labs/atlaspack/commit/602f8ed9d8381301df8b2cc82c1d5cf6f2f94fec) Thanks [@JakeLane](https://github.com/JakeLane)! - Add feature flag exportsRebindingOptimisation which detects cases where we don't need the rebinding helper for esm exports
+
+### Patch Changes
+
+- [#780](https://github.com/atlassian-labs/atlaspack/pull/780) [`eedcbc4`](https://github.com/atlassian-labs/atlaspack/commit/eedcbc408fc1e86a2a8e25f1a41c57146d8529e1) Thanks [@JakeLane](https://github.com/JakeLane)! - Fix isStaticBindingSafe in v3
+
+- Updated dependencies [[`7a52bab`](https://github.com/atlassian-labs/atlaspack/commit/7a52bab6281e8edbfa66af248eb6f872c6b4b7bd), [`eedcbc4`](https://github.com/atlassian-labs/atlaspack/commit/eedcbc408fc1e86a2a8e25f1a41c57146d8529e1), [`5a0363f`](https://github.com/atlassian-labs/atlaspack/commit/5a0363f1086e81068959b87e92064bed5a11a9b4), [`038e87a`](https://github.com/atlassian-labs/atlaspack/commit/038e87a7858d39556d59d3a2d17db534d45f62c6), [`f6532d7`](https://github.com/atlassian-labs/atlaspack/commit/f6532d7a4f7f007bd4e5e36af04dd466f0b9f572), [`0684997`](https://github.com/atlassian-labs/atlaspack/commit/0684997c127a6204af1376b36e556fddd1ba5557), [`602f8ed`](https://github.com/atlassian-labs/atlaspack/commit/602f8ed9d8381301df8b2cc82c1d5cf6f2f94fec)]:
+  - @atlaspack/feature-flags@2.25.0
+  - @atlaspack/rust@3.8.0
+  - @atlaspack/utils@2.19.2
+  - @atlaspack/plugin@2.14.30
+  - @atlaspack/types@2.15.20
+
 ## 2.22.2
 
 ### Patch Changes

package/lib/ScopeHoistingPackager.js

@@ -220,14 +220,9 @@ class ScopeHoistingPackager {
       if (this.wrappedAssets.has(entry.id) && !this.isScriptEntry(entry)) {
         var _entry$symbols$get;
         let parcelRequire = `parcelRequire(${JSON.stringify(this.bundleGraph.getAssetPublicId(entry))});\n`;
-
-        // @ts-expect-error TS2345
         let entryExports = (_entry$symbols$get = entry.symbols.get('*')) === null || _entry$symbols$get === void 0 ? void 0 : _entry$symbols$get.local;
-        if (entryExports && entry === mainEntry &&
-        // @ts-expect-error TS2345
-        this.exportedSymbols.has(entryExports)) {
+        if (entryExports && entry === mainEntry && this.exportedSymbols.has(entryExports)) {
           (0, _assert().default)(!needsBundleQueue, 'Entry exports are not yet compaitble with async bundles');
-          // @ts-expect-error TS2731
           res += `\nvar ${entryExports} = ${parcelRequire}`;
         } else {
           if (needsBundleQueue) {
@@ -415,7 +410,6 @@ class ScopeHoistingPackager {
     // TODO: handle ESM exports of wrapped entry assets...
     let entry = this.bundle.getMainEntry();
     if (entry && !this.wrappedAssets.has(entry.id)) {
-      // @ts-expect-error TS2345
       let hasNamespace = entry.symbols.hasExportSymbol('*');
       for (let {
         asset,
@@ -431,14 +425,11 @@ class ScopeHoistingPackager {
           if (hasNamespace && this.isAsyncBundle && exportAs !== '*') {
             continue;
           }
-          let symbols = (_this$exportedSymbols = this.exportedSymbols.get(
-          // @ts-expect-error TS2345
-          symbol === '*' ? (0, _nullthrows().default)((_entry$symbols$get2 = entry.symbols.get('*')) === null || _entry$symbols$get2 === void 0 ? void 0 : _entry$symbols$get2.local) : symbol)) === null || _this$exportedSymbols === void 0 ? void 0 : _this$exportedSymbols.exportAs;
+          let symbols = (_this$exportedSymbols = this.exportedSymbols.get(symbol === '*' ? (0, _nullthrows().default)((_entry$symbols$get2 = entry.symbols.get('*')) === null || _entry$symbols$get2 === void 0 ? void 0 : _entry$symbols$get2.local) : symbol)) === null || _this$exportedSymbols === void 0 ? void 0 : _this$exportedSymbols.exportAs;
           if (!symbols) {
             symbols = [];
             this.exportedSymbols.set(symbol, {
               asset,
-              // @ts-expect-error TS2322
               exportSymbol,
               local: symbol,
               exportAs: symbols
@@ -447,8 +438,6 @@ class ScopeHoistingPackager {
           if (exportAs === '*') {
             exportAs = 'default';
           }
-
-          // @ts-expect-error TS2345
           symbols.push(exportAs);
         } else if (symbol === null) {
           // TODO `meta.exportsIdentifier[exportSymbol]` should be exported
@@ -736,12 +725,9 @@ ${code}
       for (let [imported, {
         local
       }] of dep.symbols) {
-        // @ts-expect-error TS2367
         if (local === '*') {
           continue;
         }
-
-        // @ts-expect-error TS2345
         let symbol = this.getSymbolResolution(asset, resolved, imported, dep);
         replacements.set(local,
         // If this was an internalized async asset, wrap in a Promise.resolve.
@@ -763,7 +749,6 @@ ${code}
     // which will be provided to us by the wrapper.
     if (this.wrappedAssets.has(asset.id) || this.bundle.env.outputFormat === 'commonjs' && asset === this.bundle.getMainEntry()) {
       var _asset$symbols$get;
-      // @ts-expect-error TS2345
       let exportsName = ((_asset$symbols$get = asset.symbols.get('*')) === null || _asset$symbols$get === void 0 ? void 0 : _asset$symbols$get.local) || `$${assetId}$exports`;
       replacements.set(exportsName, 'module.exports');
     }
@@ -796,11 +781,9 @@ ${code}
       local
     }] of dep.symbols) {
       // If already imported, just add the already renamed variable to the mapping.
-      // @ts-expect-error TS2345
+
       let renamed = external.get(imported);
-      // @ts-expect-error TS2367
       if (renamed && local !== '*' && replacements) {
-        // @ts-expect-error TS2345
         replacements.set(local, renamed);
         continue;
       }
@@ -813,25 +796,16 @@ ${code}
           if (referencedBundle) {
             var _entry$symbols$get3;
             let entry = (0, _nullthrows().default)(referencedBundle.getMainEntry());
-            // @ts-expect-error TS2322
-            renamed =
-            // @ts-expect-error TS2345
-            ((_entry$symbols$get3 = entry.symbols.get('*')) === null || _entry$symbols$get3 === void 0 ? void 0 : _entry$symbols$get3.local) ?? `$${String(entry.meta.id)}$exports`;
+            renamed = ((_entry$symbols$get3 = entry.symbols.get('*')) === null || _entry$symbols$get3 === void 0 ? void 0 : _entry$symbols$get3.local) ?? `$${String(entry.meta.id)}$exports`;
           } else {
             renamed = this.getTopLevelName(`$${this.bundle.publicId}$${specifier}`);
           }
-
-          // @ts-expect-error TS2345
           external.set('*', renamed);
         }
-
-        // @ts-expect-error TS2367
         if (local !== '*' && replacements) {
           let replacement;
-          // @ts-expect-error TS2367
           if (imported === '*') {
             replacement = renamed;
-            // @ts-expect-error TS2367
           } else if (imported === 'default') {
             let needsDefaultInterop = true;
             if (referencedBundle) {
@@ -845,40 +819,33 @@ ${code}
               replacement = `${renamed}.default`;
             }
           } else {
-            // @ts-expect-error TS2345
             replacement = this.getPropertyAccess(renamed, imported);
           }
-
-          // @ts-expect-error TS2345
           replacements.set(local, replacement);
         }
       } else {
         let property;
         if (referencedBundle) {
           let entry = (0, _nullthrows().default)(referencedBundle.getMainEntry());
-          // @ts-expect-error TS2345
           if (entry.symbols.hasExportSymbol('*')) {
             // If importing * and the referenced module has a * export (e.g. CJS), use default instead.
             // This mirrors the logic in buildExportedSymbols.
             property = imported;
-            // @ts-expect-error TS2322
             imported = (referencedBundle === null || referencedBundle === void 0 ? void 0 : referencedBundle.env.outputFormat) === 'esmodule' ? 'default' : '*';
           } else {
-            // @ts-expect-error TS2367
             if (imported === '*') {
               let exportedSymbols = this.bundleGraph.getExportedSymbols(entry);
-              // @ts-expect-error TS2367
               if (local === '*') {
                 // Re-export all symbols.
                 for (let exported of exportedSymbols) {
                   if (exported.symbol) {
-                    // @ts-expect-error TS2345
                     external.set(exported.exportSymbol, exported.symbol);
                   }
                 }
                 continue;
               }
             }
+
             // @ts-expect-error TS2322
             renamed = this.bundleGraph.getSymbolResolution(entry, imported, this.bundle).symbol;
           }
@@ -888,37 +855,25 @@ ${code}
         // are deduplicated. We have to prefix the imported name with the bundle id so that
         // local variables do not shadow it.
         if (!renamed) {
-          // @ts-expect-error TS2345
           if (this.exportedSymbols.has(local)) {
-            // @ts-expect-error TS2322
             renamed = local;
-            // @ts-expect-error TS2367
           } else if (imported === 'default' || imported === '*') {
             renamed = this.getTopLevelName(`$${this.bundle.publicId}$${specifier}`);
           } else {
-            renamed = this.getTopLevelName(
-            // @ts-expect-error TS2731
-            `$${this.bundle.publicId}$${imported}`);
+            renamed = this.getTopLevelName(`$${this.bundle.publicId}$${imported}`);
           }
         }
-
-        // @ts-expect-error TS2345
         external.set(imported, renamed);
-        // @ts-expect-error TS2367
         if (local !== '*' && replacements) {
           let replacement = renamed;
-          // @ts-expect-error TS2367
           if (property === '*') {
             replacement = renamed;
-            // @ts-expect-error TS2367
           } else if (property === 'default') {
             replacement = `($parcel$interopDefault(${renamed}))`;
             this.usedHelpers.add('$parcel$interopDefault');
           } else if (property) {
-            // @ts-expect-error TS2345
             replacement = this.getPropertyAccess(renamed, property);
           }
-          // @ts-expect-error TS2345
           replacements.set(local, replacement);
         }
       }
@@ -940,7 +895,6 @@ ${code}
       asset: resolvedAsset,
       exportSymbol,
       symbol
-      // @ts-expect-error TS2345
     } = this.bundleGraph.getSymbolResolution(resolved, imported, this.bundle);
     if (resolvedAsset.type !== 'js' || dep && this.bundleGraph.isDependencySkipped(dep)) {
       // Graceful fallback for non-js imports or when trying to resolve a symbol
@@ -974,13 +928,7 @@ ${code}
 
     // If this is an ESM default import of a CJS module with a `default` symbol,
     // and no __esModule flag, we need to resolve to the namespace instead.
-    let isDefaultInterop = exportSymbol === 'default' && staticExports && !isWrapped && ((dep === null || dep === void 0 ? void 0 : dep.meta.kind) === 'Import' || (dep === null || dep === void 0 ? void 0 : dep.meta.kind) === 'Export') &&
-    // @ts-expect-error TS2345
-    resolvedAsset.symbols.hasExportSymbol('*') &&
-    // @ts-expect-error TS2345
-    resolvedAsset.symbols.hasExportSymbol('default') &&
-    // @ts-expect-error TS2345
-    !resolvedAsset.symbols.hasExportSymbol('__esModule');
+    let isDefaultInterop = exportSymbol === 'default' && staticExports && !isWrapped && ((dep === null || dep === void 0 ? void 0 : dep.meta.kind) === 'Import' || (dep === null || dep === void 0 ? void 0 : dep.meta.kind) === 'Export') && resolvedAsset.symbols.hasExportSymbol('*') && resolvedAsset.symbols.hasExportSymbol('default') && !resolvedAsset.symbols.hasExportSymbol('__esModule');
 
     // Find the namespace object for the resolved module. If wrapped and this
     // is an inline require (not top-level), use a parcelRequire call, otherwise
@@ -996,9 +944,7 @@ ${code}
       obj = `$${publicId}`;
     } else {
       var _resolvedAsset$symbol;
-      // @ts-expect-error TS2345
       obj = ((_resolvedAsset$symbol = resolvedAsset.symbols.get('*')) === null || _resolvedAsset$symbol === void 0 ? void 0 : _resolvedAsset$symbol.local) || `$${assetId}$exports`;
-      // @ts-expect-error TS2345
       obj = (replacements === null || replacements === void 0 ? void 0 : replacements.get(obj)) || obj;
     }
     if (imported === '*' || exportSymbol === '*' || isDefaultInterop) {
@@ -1007,7 +953,6 @@ ${code}
         // Directly use module.exports for wrapped assets importing themselves.
         return 'module.exports';
       } else {
-        // @ts-expect-error TS2322
         return obj;
       }
     } else if ((!staticExports || isWrapped || !symbol || isExternalCommonJS) && resolvedAsset !== parentAsset) {
@@ -1016,20 +961,15 @@ ${code}
       // than a direct reference. If importing default from a CJS module,
       // use a helper to check the __esModule flag at runtime.
       let kind = dep === null || dep === void 0 ? void 0 : dep.meta.kind;
-      if ((!dep || kind === 'Import' || kind === 'Export') && exportSymbol === 'default' &&
-      // @ts-expect-error TS2345
-      resolvedAsset.symbols.hasExportSymbol('*') && this.needsDefaultInterop(resolvedAsset)) {
+      if ((!dep || kind === 'Import' || kind === 'Export') && exportSymbol === 'default' && resolvedAsset.symbols.hasExportSymbol('*') && this.needsDefaultInterop(resolvedAsset)) {
         this.usedHelpers.add('$parcel$interopDefault');
-        // @ts-expect-error TS2731
         return `(/*@__PURE__*/$parcel$interopDefault(${obj}))`;
       } else {
-        // @ts-expect-error TS2345
         return this.getPropertyAccess(obj, exportSymbol);
       }
     } else if (!symbol) {
       (0, _assert().default)(false, 'Asset was skipped or not found.');
     } else {
-      // @ts-expect-error TS2322
       return (replacements === null || replacements === void 0 ? void 0 : replacements.get(symbol)) || symbol;
     }
   }
@@ -1078,32 +1018,22 @@ ${code}
     // If the asset has a namespace export symbol, it is CommonJS.
     // If there's no __esModule flag, and default is a used symbol, we need
     // to insert an interop helper.
-    let defaultInterop =
-    // @ts-expect-error TS2345
-    asset.symbols.hasExportSymbol('*') &&
-    // @ts-expect-error TS2345
-    usedSymbols.has('default') &&
-    // @ts-expect-error TS2345
-    !asset.symbols.hasExportSymbol('__esModule');
+    let defaultInterop = asset.symbols.hasExportSymbol('*') && usedSymbols.has('default') && !asset.symbols.hasExportSymbol('__esModule');
     let usedNamespace;
     if ((0, _featureFlags().getFeatureFlag)('inlineConstOptimisationFix') && asset.meta.isConstantModule) {
       // Only set usedNamespace if there is an incoming dependency in the current bundle that uses '*'
-      usedNamespace = this.bundleGraph.getIncomingDependencies(asset).some(dep => this.bundle.hasDependency(dep) &&
-      // @ts-expect-error TS2345
-      (0, _nullthrows().default)(this.bundleGraph.getUsedSymbols(dep)).has('*'));
+      usedNamespace = this.bundleGraph.getIncomingDependencies(asset).some(dep => this.bundle.hasDependency(dep) && (0, _nullthrows().default)(this.bundleGraph.getUsedSymbols(dep)).has('*'));
     } else {
       usedNamespace =
       // If the asset has * in its used symbols, we might need the exports namespace.
       // The one case where this isn't true is in ESM library entries, where the only
       // dependency on * is the entry dependency. In this case, we will use ESM exports
       // instead of the namespace object.
-      // @ts-expect-error TS2345
-      usedSymbols.has('*') && (this.bundle.env.outputFormat !== 'esmodule' || !this.bundle.env.isLibrary || asset !== this.bundle.getMainEntry() || this.bundleGraph.getIncomingDependencies(asset).some(dep => !dep.isEntry && this.bundle.hasDependency(dep) &&
-      // @ts-expect-error TS2345
-      (0, _nullthrows().default)(this.bundleGraph.getUsedSymbols(dep)).has('*'))) ||
+
+      usedSymbols.has('*') && (this.bundle.env.outputFormat !== 'esmodule' || !this.bundle.env.isLibrary || asset !== this.bundle.getMainEntry() || this.bundleGraph.getIncomingDependencies(asset).some(dep => !dep.isEntry && this.bundle.hasDependency(dep) && (0, _nullthrows().default)(this.bundleGraph.getUsedSymbols(dep)).has('*'))) ||
       // If a symbol is imported (used) from a CJS asset but isn't listed in the symbols,
       // we fallback on the namespace object.
-      // @ts-expect-error TS2345
+
       asset.symbols.hasExportSymbol('*') && [...usedSymbols].some(s => !asset.symbols.hasExportSymbol(s)) ||
       // If the exports has this asset's namespace (e.g. ESM output from CJS input),
       // include the namespace object for the default export.
@@ -1128,7 +1058,7 @@ ${code}
       // Insert the __esModule interop flag for this module if it has a `default` export
       // and the namespace symbol is used.
       // TODO: only if required by CJS?
-      // @ts-expect-error TS2345
+
       if (asset.symbols.hasExportSymbol('default') && usedSymbols.has('*')) {
         prepend += `\n$parcel$defineInteropFlag($${assetId}$exports);\n`;
         prependLineCount += 2;
@@ -1147,7 +1077,6 @@ ${code}
         for (let [imported, {
           local
         }] of dep.symbols) {
-          // @ts-expect-error TS2367
           if (imported === '*' && local === '*') {
             if (!resolved) {
               // Re-exporting an external module. This should have already been handled in buildReplacements.
@@ -1160,29 +1089,20 @@ ${code}
             // If the resolved asset has an exports object, use the $parcel$exportWildcard helper
             // to re-export all symbols. Otherwise, if there's no namespace object available, add
             // $parcel$export calls for each used symbol of the dependency.
-            if (isWrapped || resolved.meta.staticExports === false ||
-            // @ts-expect-error TS2345
-            (0, _nullthrows().default)(this.bundleGraph.getUsedSymbols(resolved)).has('*') ||
+            if (isWrapped || resolved.meta.staticExports === false || (0, _nullthrows().default)(this.bundleGraph.getUsedSymbols(resolved)).has('*') ||
             // an empty asset
-            !resolved.meta.hasCJSExports &&
-            // @ts-expect-error TS2345
-            resolved.symbols.hasExportSymbol('*')) {
+            !resolved.meta.hasCJSExports && resolved.symbols.hasExportSymbol('*')) {
               let obj = this.getSymbolResolution(asset, resolved, '*', dep, replacements);
               append += `$parcel$exportWildcard($${assetId}$exports, ${obj});\n`;
               this.usedHelpers.add('$parcel$exportWildcard');
             } else {
               for (let symbol of (0, _nullthrows().default)(this.bundleGraph.getUsedSymbols(dep))) {
-                if (
-                // @ts-expect-error TS2367
-                symbol === 'default' ||
+                if (symbol === 'default' ||
                 // `export * as ...` does not include the default export
-                // @ts-expect-error TS2367
                 symbol === '__esModule') {
                   continue;
                 }
-                let resolvedSymbol = this.getSymbolResolution(asset, resolved,
-                // @ts-expect-error TS2345
-                symbol, undefined, replacements);
+                let resolvedSymbol = this.getSymbolResolution(asset, resolved, symbol, undefined, replacements);
                 let get = this.buildFunctionExpression([], resolvedSymbol);
                 let set = asset.meta.hasCJSExports ? ', ' + this.buildFunctionExpression(['v'], `${resolvedSymbol} = v`) : '';
                 prepend += `$parcel$export($${assetId}$exports, ${JSON.stringify(symbol)}, ${get}${set});\n`;
@@ -1199,7 +1119,6 @@ ${code}
       // re-exported symbols rather than only symbols declared in this asset.
       let incomingDeps = this.bundleGraph.getIncomingDependencies(asset);
       let usedExports = [...asset.symbols.exportSymbols()].filter(symbol => {
-        // @ts-expect-error TS2367
         if (symbol === '*') {
           return false;
         }
@@ -1214,8 +1133,6 @@ ${code}
 
           // No used symbols available for the asset, make sure we keep all of them
           if (!symbols) return false;
-
-          // @ts-expect-error TS2345
           return !symbols.has(symbol) && !symbols.has('*');
         });
         return !unused;
@@ -1227,9 +1144,7 @@ ${code}
         // additional assignments after each mutation of the original binding.
         for (let exp of usedExports) {
           var _asset$symbols$get2;
-          let resolved = this.getSymbolResolution(asset, asset,
-          // @ts-expect-error TS2345
-          exp, undefined, replacements);
+          let resolved = this.getSymbolResolution(asset, asset, exp, undefined, replacements);
           const meta = (_asset$symbols$get2 = asset.symbols.get(exp)) === null || _asset$symbols$get2 === void 0 ? void 0 : _asset$symbols$get2.meta;
           if ((0, _featureFlags().getFeatureFlag)('exportsRebindingOptimisation') && meta !== null && meta !== void 0 && meta.isStaticBindingSafe) {
             append += `$${assetId}$exports[${JSON.stringify(exp)}] = ${resolved};\n`;
@@ -1332,11 +1247,7 @@ ${code}
     return [res, lines];
   }
   needsDefaultInterop(asset) {
-    if (
-    // @ts-expect-error TS2345
-    asset.symbols.hasExportSymbol('*') &&
-    // @ts-expect-error TS2345
-    !asset.symbols.hasExportSymbol('default')) {
+    if (asset.symbols.hasExportSymbol('*') && !asset.symbols.hasExportSymbol('default')) {
       return true;
     }
     return false;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@atlaspack/packager-js",
-  "version": "2.22.3-dev-export-func-opt-67f87c28a.0",
+  "version": "2.23.0",
   "license": "(MIT OR Apache-2.0)",
   "publishConfig": {
     "access": "public"
@@ -16,13 +16,13 @@
     "node": ">= 16.0.0"
   },
   "dependencies": {
-    "@atlaspack/diagnostic": "2.14.4-dev-export-func-opt-67f87c28a.0",
-    "@atlaspack/feature-flags": "2.24.2-dev-export-func-opt-67f87c28a.0",
-    "@atlaspack/plugin": "2.14.30-dev-export-func-opt-67f87c28a.0",
-    "@atlaspack/rust": "3.7.1-dev-export-func-opt-67f87c28a.0",
-    "@atlaspack/types": "2.15.20-dev-export-func-opt-67f87c28a.0",
-    "@atlaspack/utils": "2.19.2-dev-export-func-opt-67f87c28a.0",
+    "@atlaspack/diagnostic": "2.14.3",
+    "@atlaspack/feature-flags": "2.25.0",
+    "@atlaspack/plugin": "2.14.30",
+    "@atlaspack/rust": "3.8.0",
     "@parcel/source-map": "^2.1.1",
+    "@atlaspack/types": "2.15.20",
+    "@atlaspack/utils": "2.19.2",
     "globals": "^13.2.0",
     "nullthrows": "^1.1.1",
     "outdent": "^0.8.0"
@@ -31,6 +31,5 @@
   "scripts": {
     "check-ts": "tsc --emitDeclarationOnly --rootDir src",
     "build:lib": "gulp build --gulpfile ../../../gulpfile.js --cwd ."
-  },
-  "gitHead": "67f87c28a23fcf285d88a1c969de4e35956cb500"
+  }
 }

package/src/ScopeHoistingPackager.ts

@@ -260,20 +260,17 @@ export class ScopeHoistingPackager {
           this.bundleGraph.getAssetPublicId(entry),
         )});\n`;
 
-        // @ts-expect-error TS2345
         let entryExports = entry.symbols.get('*')?.local;
 
         if (
           entryExports &&
           entry === mainEntry &&
-          // @ts-expect-error TS2345
           this.exportedSymbols.has(entryExports)
         ) {
           invariant(
             !needsBundleQueue,
             'Entry exports are not yet compaitble with async bundles',
           );
-          // @ts-expect-error TS2731
           res += `\nvar ${entryExports} = ${parcelRequire}`;
         } else {
           if (needsBundleQueue) {
@@ -559,7 +556,6 @@ export class ScopeHoistingPackager {
     // TODO: handle ESM exports of wrapped entry assets...
     let entry = this.bundle.getMainEntry();
     if (entry && !this.wrappedAssets.has(entry.id)) {
-      // @ts-expect-error TS2345
       let hasNamespace = entry.symbols.hasExportSymbol('*');
 
       for (let {
@@ -577,7 +573,6 @@ export class ScopeHoistingPackager {
           }
 
           let symbols = this.exportedSymbols.get(
-            // @ts-expect-error TS2345
             symbol === '*' ? nullthrows(entry.symbols.get('*')?.local) : symbol,
           )?.exportAs;
 
@@ -585,7 +580,7 @@ export class ScopeHoistingPackager {
             symbols = [];
             this.exportedSymbols.set(symbol, {
               asset,
-              // @ts-expect-error TS2322
+
               exportSymbol,
               local: symbol,
               exportAs: symbols,
@@ -596,7 +591,6 @@ export class ScopeHoistingPackager {
             exportAs = 'default';
           }
 
-          // @ts-expect-error TS2345
           symbols.push(exportAs);
         } else if (symbol === null) {
           // TODO `meta.exportsIdentifier[exportSymbol]` should be exported
@@ -990,12 +984,10 @@ ${code}
       }
 
       for (let [imported, {local}] of dep.symbols) {
-        // @ts-expect-error TS2367
         if (local === '*') {
           continue;
         }
 
-        // @ts-expect-error TS2345
         let symbol = this.getSymbolResolution(asset, resolved, imported, dep);
         replacements.set(
           local,
@@ -1032,7 +1024,6 @@ ${code}
       (this.bundle.env.outputFormat === 'commonjs' &&
         asset === this.bundle.getMainEntry())
     ) {
-      // @ts-expect-error TS2345
       let exportsName = asset.symbols.get('*')?.local || `$${assetId}$exports`;
       replacements.set(exportsName, 'module.exports');
     }
@@ -1076,11 +1067,10 @@ ${code}
 
     for (let [imported, {local}] of dep.symbols) {
       // If already imported, just add the already renamed variable to the mapping.
-      // @ts-expect-error TS2345
+
       let renamed = external.get(imported);
-      // @ts-expect-error TS2367
+
       if (renamed && local !== '*' && replacements) {
-        // @ts-expect-error TS2345
         replacements.set(local, renamed);
         continue;
       }
@@ -1092,9 +1082,8 @@ ${code}
         if (!renamed) {
           if (referencedBundle) {
             let entry = nullthrows(referencedBundle.getMainEntry());
-            // @ts-expect-error TS2322
+
             renamed =
-              // @ts-expect-error TS2345
               entry.symbols.get('*')?.local ??
               `$${String(entry.meta.id)}$exports`;
           } else {
@@ -1103,17 +1092,14 @@ ${code}
             );
           }
 
-          // @ts-expect-error TS2345
           external.set('*', renamed);
         }
 
-        // @ts-expect-error TS2367
         if (local !== '*' && replacements) {
           let replacement;
-          // @ts-expect-error TS2367
+
           if (imported === '*') {
             replacement = renamed;
-            // @ts-expect-error TS2367
           } else if (imported === 'default') {
             let needsDefaultInterop = true;
             if (referencedBundle) {
@@ -1127,43 +1113,40 @@ ${code}
               replacement = `${renamed}.default`;
             }
           } else {
-            // @ts-expect-error TS2345
             replacement = this.getPropertyAccess(renamed, imported);
           }
 
-          // @ts-expect-error TS2345
           replacements.set(local, replacement);
         }
       } else {
         let property;
         if (referencedBundle) {
           let entry = nullthrows(referencedBundle.getMainEntry());
-          // @ts-expect-error TS2345
+
           if (entry.symbols.hasExportSymbol('*')) {
             // If importing * and the referenced module has a * export (e.g. CJS), use default instead.
             // This mirrors the logic in buildExportedSymbols.
             property = imported;
-            // @ts-expect-error TS2322
+
             imported =
               referencedBundle?.env.outputFormat === 'esmodule'
                 ? 'default'
                 : '*';
           } else {
-            // @ts-expect-error TS2367
             if (imported === '*') {
               let exportedSymbols = this.bundleGraph.getExportedSymbols(entry);
-              // @ts-expect-error TS2367
+
               if (local === '*') {
                 // Re-export all symbols.
                 for (let exported of exportedSymbols) {
                   if (exported.symbol) {
-                    // @ts-expect-error TS2345
                     external.set(exported.exportSymbol, exported.symbol);
                   }
                 }
                 continue;
               }
             }
+
             // @ts-expect-error TS2322
             renamed = this.bundleGraph.getSymbolResolution(
               entry,
@@ -1177,40 +1160,33 @@ ${code}
         // are deduplicated. We have to prefix the imported name with the bundle id so that
         // local variables do not shadow it.
         if (!renamed) {
-          // @ts-expect-error TS2345
           if (this.exportedSymbols.has(local)) {
-            // @ts-expect-error TS2322
             renamed = local;
-            // @ts-expect-error TS2367
           } else if (imported === 'default' || imported === '*') {
             renamed = this.getTopLevelName(
               `$${this.bundle.publicId}$${specifier}`,
             );
           } else {
             renamed = this.getTopLevelName(
-              // @ts-expect-error TS2731
               `$${this.bundle.publicId}$${imported}`,
             );
           }
         }
 
-        // @ts-expect-error TS2345
         external.set(imported, renamed);
-        // @ts-expect-error TS2367
+
         if (local !== '*' && replacements) {
           let replacement = renamed;
-          // @ts-expect-error TS2367
+
           if (property === '*') {
             replacement = renamed;
-            // @ts-expect-error TS2367
           } else if (property === 'default') {
             replacement = `($parcel$interopDefault(${renamed}))`;
             this.usedHelpers.add('$parcel$interopDefault');
           } else if (property) {
-            // @ts-expect-error TS2345
             replacement = this.getPropertyAccess(renamed, property);
           }
-          // @ts-expect-error TS2345
+
           replacements.set(local, replacement);
         }
       }
@@ -1249,7 +1225,6 @@ ${code}
       asset: resolvedAsset,
       exportSymbol,
       symbol,
-      // @ts-expect-error TS2345
     } = this.bundleGraph.getSymbolResolution(resolved, imported, this.bundle);
 
     if (
@@ -1308,11 +1283,8 @@ ${code}
       staticExports &&
       !isWrapped &&
       (dep?.meta.kind === 'Import' || dep?.meta.kind === 'Export') &&
-      // @ts-expect-error TS2345
       resolvedAsset.symbols.hasExportSymbol('*') &&
-      // @ts-expect-error TS2345
       resolvedAsset.symbols.hasExportSymbol('default') &&
-      // @ts-expect-error TS2345
       !resolvedAsset.symbols.hasExportSymbol('__esModule');
 
     // Find the namespace object for the resolved module. If wrapped and this
@@ -1328,9 +1300,8 @@ ${code}
     } else if (isWrapped && dep) {
       obj = `$${publicId}`;
     } else {
-      // @ts-expect-error TS2345
       obj = resolvedAsset.symbols.get('*')?.local || `$${assetId}$exports`;
-      // @ts-expect-error TS2345
+
       obj = replacements?.get(obj) || obj;
     }
 
@@ -1343,7 +1314,6 @@ ${code}
         // Directly use module.exports for wrapped assets importing themselves.
         return 'module.exports';
       } else {
-        // @ts-expect-error TS2322
         return obj;
       }
     } else if (
@@ -1358,21 +1328,17 @@ ${code}
       if (
         (!dep || kind === 'Import' || kind === 'Export') &&
         exportSymbol === 'default' &&
-        // @ts-expect-error TS2345
         resolvedAsset.symbols.hasExportSymbol('*') &&
         this.needsDefaultInterop(resolvedAsset)
       ) {
         this.usedHelpers.add('$parcel$interopDefault');
-        // @ts-expect-error TS2731
         return `(/*@__PURE__*/$parcel$interopDefault(${obj}))`;
       } else {
-        // @ts-expect-error TS2345
         return this.getPropertyAccess(obj, exportSymbol);
       }
     } else if (!symbol) {
       invariant(false, 'Asset was skipped or not found.');
     } else {
-      // @ts-expect-error TS2322
       return replacements?.get(symbol) || symbol;
     }
   }
@@ -1449,11 +1415,8 @@ ${code}
     // If there's no __esModule flag, and default is a used symbol, we need
     // to insert an interop helper.
     let defaultInterop =
-      // @ts-expect-error TS2345
       asset.symbols.hasExportSymbol('*') &&
-      // @ts-expect-error TS2345
       usedSymbols.has('default') &&
-      // @ts-expect-error TS2345
       !asset.symbols.hasExportSymbol('__esModule');
 
     let usedNamespace;
@@ -1462,33 +1425,35 @@ ${code}
       asset.meta.isConstantModule
     ) {
       // Only set usedNamespace if there is an incoming dependency in the current bundle that uses '*'
-      usedNamespace = this.bundleGraph.getIncomingDependencies(asset).some(
-        (dep) =>
-          this.bundle.hasDependency(dep) &&
-          // @ts-expect-error TS2345
-          nullthrows(this.bundleGraph.getUsedSymbols(dep)).has('*'),
-      );
+      usedNamespace = this.bundleGraph
+        .getIncomingDependencies(asset)
+        .some(
+          (dep) =>
+            this.bundle.hasDependency(dep) &&
+            nullthrows(this.bundleGraph.getUsedSymbols(dep)).has('*'),
+        );
     } else {
       usedNamespace =
         // If the asset has * in its used symbols, we might need the exports namespace.
         // The one case where this isn't true is in ESM library entries, where the only
         // dependency on * is the entry dependency. In this case, we will use ESM exports
         // instead of the namespace object.
-        // @ts-expect-error TS2345
+
         (usedSymbols.has('*') &&
           (this.bundle.env.outputFormat !== 'esmodule' ||
             !this.bundle.env.isLibrary ||
             asset !== this.bundle.getMainEntry() ||
-            this.bundleGraph.getIncomingDependencies(asset).some(
-              (dep) =>
-                !dep.isEntry &&
-                this.bundle.hasDependency(dep) &&
-                // @ts-expect-error TS2345
-                nullthrows(this.bundleGraph.getUsedSymbols(dep)).has('*'),
-            ))) ||
+            this.bundleGraph
+              .getIncomingDependencies(asset)
+              .some(
+                (dep) =>
+                  !dep.isEntry &&
+                  this.bundle.hasDependency(dep) &&
+                  nullthrows(this.bundleGraph.getUsedSymbols(dep)).has('*'),
+              ))) ||
         // If a symbol is imported (used) from a CJS asset but isn't listed in the symbols,
         // we fallback on the namespace object.
-        // @ts-expect-error TS2345
+
         (asset.symbols.hasExportSymbol('*') &&
           [...usedSymbols].some((s) => !asset.symbols.hasExportSymbol(s))) ||
         // If the exports has this asset's namespace (e.g. ESM output from CJS input),
@@ -1525,7 +1490,7 @@ ${code}
       // Insert the __esModule interop flag for this module if it has a `default` export
       // and the namespace symbol is used.
       // TODO: only if required by CJS?
-      // @ts-expect-error TS2345
+
       if (asset.symbols.hasExportSymbol('default') && usedSymbols.has('*')) {
         prepend += `\n$parcel$defineInteropFlag($${assetId}$exports);\n`;
         prependLineCount += 2;
@@ -1544,7 +1509,6 @@ ${code}
         let isWrapped = resolved && resolved.meta.shouldWrap;
 
         for (let [imported, {local}] of dep.symbols) {
-          // @ts-expect-error TS2367
           if (imported === '*' && local === '*') {
             if (!resolved) {
               // Re-exporting an external module. This should have already been handled in buildReplacements.
@@ -1562,11 +1526,9 @@ ${code}
             if (
               isWrapped ||
               resolved.meta.staticExports === false ||
-              // @ts-expect-error TS2345
               nullthrows(this.bundleGraph.getUsedSymbols(resolved)).has('*') ||
               // an empty asset
               (!resolved.meta.hasCJSExports &&
-                // @ts-expect-error TS2345
                 resolved.symbols.hasExportSymbol('*'))
             ) {
               let obj = this.getSymbolResolution(
@@ -1583,9 +1545,7 @@ ${code}
                 this.bundleGraph.getUsedSymbols(dep),
               )) {
                 if (
-                  // @ts-expect-error TS2367
                   symbol === 'default' || // `export * as ...` does not include the default export
-                  // @ts-expect-error TS2367
                   symbol === '__esModule'
                 ) {
                   continue;
@@ -1594,7 +1554,7 @@ ${code}
                 let resolvedSymbol = this.getSymbolResolution(
                   asset,
                   resolved,
-                  // @ts-expect-error TS2345
+
                   symbol,
                   undefined,
                   replacements,
@@ -1620,7 +1580,6 @@ ${code}
       // re-exported symbols rather than only symbols declared in this asset.
       let incomingDeps = this.bundleGraph.getIncomingDependencies(asset);
       let usedExports = [...asset.symbols.exportSymbols()].filter((symbol) => {
-        // @ts-expect-error TS2367
         if (symbol === '*') {
           return false;
         }
@@ -1637,7 +1596,6 @@ ${code}
           // No used symbols available for the asset, make sure we keep all of them
           if (!symbols) return false;
 
-          // @ts-expect-error TS2345
           return !symbols.has(symbol) && !symbols.has('*');
         });
         return !unused;
@@ -1652,7 +1610,6 @@ ${code}
           let resolved = this.getSymbolResolution(
             asset,
             asset,
-            // @ts-expect-error TS2345
             exp,
             undefined,
             replacements,
@@ -1800,9 +1757,7 @@ ${code}
 
   needsDefaultInterop(asset: Asset): boolean {
     if (
-      // @ts-expect-error TS2345
       asset.symbols.hasExportSymbol('*') &&
-      // @ts-expect-error TS2345
       !asset.symbols.hasExportSymbol('default')
     ) {
       return true;

package/LICENSE

@@ -1,201 +0,0 @@
-                                 Apache License
-                           Version 2.0, January 2004
-                        http://www.apache.org/licenses/
-
-   TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION
-
-   1. Definitions.
-
-      "License" shall mean the terms and conditions for use, reproduction,
-      and distribution as defined by Sections 1 through 9 of this document.
-
-      "Licensor" shall mean the copyright owner or entity authorized by
-      the copyright owner that is granting the License.
-
-      "Legal Entity" shall mean the union of the acting entity and all
-      other entities that control, are controlled by, or are under common
-      control with that entity. For the purposes of this definition,
-      "control" means (i) the power, direct or indirect, to cause the
-      direction or management of such entity, whether by contract or
-      otherwise, or (ii) ownership of fifty percent (50%) or more of the
-      outstanding shares, or (iii) beneficial ownership of such entity.
-
-      "You" (or "Your") shall mean an individual or Legal Entity
-      exercising permissions granted by this License.
-
-      "Source" form shall mean the preferred form for making modifications,
-      including but not limited to software source code, documentation
-      source, and configuration files.
-
-      "Object" form shall mean any form resulting from mechanical
-      transformation or translation of a Source form, including but
-      not limited to compiled object code, generated documentation,
-      and conversions to other media types.
-
-      "Work" shall mean the work of authorship, whether in Source or
-      Object form, made available under the License, as indicated by a
-      copyright notice that is included in or attached to the work
-      (an example is provided in the Appendix below).
-
-      "Derivative Works" shall mean any work, whether in Source or Object
-      form, that is based on (or derived from) the Work and for which the
-      editorial revisions, annotations, elaborations, or other modifications
-      represent, as a whole, an original work of authorship. For the purposes
-      of this License, Derivative Works shall not include works that remain
-      separable from, or merely link (or bind by name) to the interfaces of,
-      the Work and Derivative Works thereof.
-
-      "Contribution" shall mean any work of authorship, including
-      the original version of the Work and any modifications or additions
-      to that Work or Derivative Works thereof, that is intentionally
-      submitted to Licensor for inclusion in the Work by the copyright owner
-      or by an individual or Legal Entity authorized to submit on behalf of
-      the copyright owner. For the purposes of this definition, "submitted"
-      means any form of electronic, verbal, or written communication sent
-      to the Licensor or its representatives, including but not limited to
-      communication on electronic mailing lists, source code control systems,
-      and issue tracking systems that are managed by, or on behalf of, the
-      Licensor for the purpose of discussing and improving the Work, but
-      excluding communication that is conspicuously marked or otherwise
-      designated in writing by the copyright owner as "Not a Contribution."
-
-      "Contributor" shall mean Licensor and any individual or Legal Entity
-      on behalf of whom a Contribution has been received by Licensor and
-      subsequently incorporated within the Work.
-
-   2. Grant of Copyright License. Subject to the terms and conditions of
-      this License, each Contributor hereby grants to You a perpetual,
-      worldwide, non-exclusive, no-charge, royalty-free, irrevocable
-      copyright license to reproduce, prepare Derivative Works of,
-      publicly display, publicly perform, sublicense, and distribute the
-      Work and such Derivative Works in Source or Object form.
-
-   3. Grant of Patent License. Subject to the terms and conditions of
-      this License, each Contributor hereby grants to You a perpetual,
-      worldwide, non-exclusive, no-charge, royalty-free, irrevocable
-      (except as stated in this section) patent license to make, have made,
-      use, offer to sell, sell, import, and otherwise transfer the Work,
-      where such license applies only to those patent claims licensable
-      by such Contributor that are necessarily infringed by their
-      Contribution(s) alone or by combination of their Contribution(s)
-      with the Work to which such Contribution(s) was submitted. If You
-      institute patent litigation against any entity (including a
-      cross-claim or counterclaim in a lawsuit) alleging that the Work
-      or a Contribution incorporated within the Work constitutes direct
-      or contributory patent infringement, then any patent licenses
-      granted to You under this License for that Work shall terminate
-      as of the date such litigation is filed.
-
-   4. Redistribution. You may reproduce and distribute copies of the
-      Work or Derivative Works thereof in any medium, with or without
-      modifications, and in Source or Object form, provided that You
-      meet the following conditions:
-
-      (a) You must give any other recipients of the Work or
-          Derivative Works a copy of this License; and
-
-      (b) You must cause any modified files to carry prominent notices
-          stating that You changed the files; and
-
-      (c) You must retain, in the Source form of any Derivative Works
-          that You distribute, all copyright, patent, trademark, and
-          attribution notices from the Source form of the Work,
-          excluding those notices that do not pertain to any part of
-          the Derivative Works; and
-
-      (d) If the Work includes a "NOTICE" text file as part of its
-          distribution, then any Derivative Works that You distribute must
-          include a readable copy of the attribution notices contained
-          within such NOTICE file, excluding those notices that do not
-          pertain to any part of the Derivative Works, in at least one
-          of the following places: within a NOTICE text file distributed
-          as part of the Derivative Works; within the Source form or
-          documentation, if provided along with the Derivative Works; or,
-          within a display generated by the Derivative Works, if and
-          wherever such third-party notices normally appear. The contents
-          of the NOTICE file are for informational purposes only and
-          do not modify the License. You may add Your own attribution
-          notices within Derivative Works that You distribute, alongside
-          or as an addendum to the NOTICE text from the Work, provided
-          that such additional attribution notices cannot be construed
-          as modifying the License.
-
-      You may add Your own copyright statement to Your modifications and
-      may provide additional or different license terms and conditions
-      for use, reproduction, or distribution of Your modifications, or
-      for any such Derivative Works as a whole, provided Your use,
-      reproduction, and distribution of the Work otherwise complies with
-      the conditions stated in this License.
-
-   5. Submission of Contributions. Unless You explicitly state otherwise,
-      any Contribution intentionally submitted for inclusion in the Work
-      by You to the Licensor shall be under the terms and conditions of
-      this License, without any additional terms or conditions.
-      Notwithstanding the above, nothing herein shall supersede or modify
-      the terms of any separate license agreement you may have executed
-      with Licensor regarding such Contributions.
-
-   6. Trademarks. This License does not grant permission to use the trade
-      names, trademarks, service marks, or product names of the Licensor,
-      except as required for reasonable and customary use in describing the
-      origin of the Work and reproducing the content of the NOTICE file.
-
-   7. Disclaimer of Warranty. Unless required by applicable law or
-      agreed to in writing, Licensor provides the Work (and each
-      Contributor provides its Contributions) on an "AS IS" BASIS,
-      WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
-      implied, including, without limitation, any warranties or conditions
-      of TITLE, NON-INFRINGEMENT, MERCHANTABILITY, or FITNESS FOR A
-      PARTICULAR PURPOSE. You are solely responsible for determining the
-      appropriateness of using or redistributing the Work and assume any
-      risks associated with Your exercise of permissions under this License.
-
-   8. Limitation of Liability. In no event and under no legal theory,
-      whether in tort (including negligence), contract, or otherwise,
-      unless required by applicable law (such as deliberate and grossly
-      negligent acts) or agreed to in writing, shall any Contributor be
-      liable to You for damages, including any direct, indirect, special,
-      incidental, or consequential damages of any character arising as a
-      result of this License or out of the use or inability to use the
-      Work (including but not limited to damages for loss of goodwill,
-      work stoppage, computer failure or malfunction, or any and all
-      other commercial damages or losses), even if such Contributor
-      has been advised of the possibility of such damages.
-
-   9. Accepting Warranty or Additional Liability. While redistributing
-      the Work or Derivative Works thereof, You may choose to offer,
-      and charge a fee for, acceptance of support, warranty, indemnity,
-      or other liability obligations and/or rights consistent with this
-      License. However, in accepting such obligations, You may act only
-      on Your own behalf and on Your sole responsibility, not on behalf
-      of any other Contributor, and only if You agree to indemnify,
-      defend, and hold each Contributor harmless for any liability
-      incurred by, or claims asserted against, such Contributor by reason
-      of your accepting any such warranty or additional liability.
-
-   END OF TERMS AND CONDITIONS
-
-   APPENDIX: How to apply the Apache License to your work.
-
-      To apply the Apache License to your work, attach the following
-      boilerplate notice, with the fields enclosed by brackets "[]"
-      replaced with your own identifying information. (Don't include
-      the brackets!)  The text should be enclosed in the appropriate
-      comment syntax for the file format. We also recommend that a
-      file or class name and description of purpose be included on the
-      same "printed page" as the copyright notice for easier
-      identification within third-party archives.
-
-   Copyright (c) 2024 Atlassian US., Inc.
-
-   Licensed under the Apache License, Version 2.0 (the "License");
-   you may not use this file except in compliance with the License.
-   You may obtain a copy of the License at
-
-       http://www.apache.org/licenses/LICENSE-2.0
-
-   Unless required by applicable law or agreed to in writing, software
-   distributed under the License is distributed on an "AS IS" BASIS,
-   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-   See the License for the specific language governing permissions and
-   limitations under the License.