@atlaspack/packager-js 2.21.2-dev-inline-requires-reuse-bdc9ca9c3.0 → 2.21.3-inline-requires-take-2-2a0c642df.0

package/CHANGELOG.md

@@ -1,5 +1,21 @@
 # @atlaspack/packager-js
 
+## 2.21.2
+
+### Patch Changes
+
+- [#742](https://github.com/atlassian-labs/atlaspack/pull/742) [`ee040bb`](https://github.com/atlassian-labs/atlaspack/commit/ee040bb6428f29b57d892ddd8107e29077d08ffd) Thanks [@yamadapc](https://github.com/yamadapc)! - Internal changes and bug fixes to environmentDeduplication flag
+
+- [#755](https://github.com/atlassian-labs/atlaspack/pull/755) [`b6e72b6`](https://github.com/atlassian-labs/atlaspack/commit/b6e72b6dd2b517cbb0e700fa69e63332d3eacb1e) Thanks [@benjervis](https://github.com/benjervis)! - Allow runtime assets to be marked as requiring execution on load
+
+- Updated dependencies [[`ee040bb`](https://github.com/atlassian-labs/atlaspack/commit/ee040bb6428f29b57d892ddd8107e29077d08ffd), [`889c65c`](https://github.com/atlassian-labs/atlaspack/commit/889c65cd25b811045e26a117e7404f694dde77a2)]:
+  - @atlaspack/feature-flags@2.23.1
+  - @atlaspack/diagnostic@2.14.3
+  - @atlaspack/plugin@2.14.26
+  - @atlaspack/types@2.15.16
+  - @atlaspack/utils@2.18.3
+  - @atlaspack/rust@3.6.1
+
 ## 2.21.1
 
 ### Patch Changes

package/lib/ScopeHoistingPackager.js

@@ -190,10 +190,17 @@ class ScopeHoistingPackager {
     let entries = this.bundle.getEntryAssets();
     let mainEntry = this.bundle.getMainEntry();
     if (this.isAsyncBundle) {
-      // In async bundles we don't want the main entry to execute until we require it
-      // as there might be dependencies in a sibling bundle that hasn't loaded yet.
-      if ((0, _featureFlags().getFeatureFlag)('supportWebpackChunkName')) {
-        entries = [];
+      if ((0, _featureFlags().getFeatureFlag)('applyScopeHoistingImprovement') || (0, _featureFlags().getFeatureFlag)('supportWebpackChunkName')) {
+        // Generally speaking, async bundles should not be executed on load, as
+        // they're just collections of assets that other assets require.
+        // However, there are some special cases where a runtime asset needs to be
+        // injected, but no other asset will require it (mostly the bundle
+        // manifest).
+        // In this case, those assets need to be required on load.
+        entries = entries.filter(a => {
+          var _a$meta;
+          return (_a$meta = a.meta) === null || _a$meta === void 0 ? void 0 : _a$meta.runtimeAssetRequiringExecutionOnLoad;
+        });
       } else {
         entries = entries.filter(a => {
           var _mainEntry;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@atlaspack/packager-js",
-  "version": "2.21.2-dev-inline-requires-reuse-bdc9ca9c3.0",
+  "version": "2.21.3-inline-requires-take-2-2a0c642df.0",
   "license": "(MIT OR Apache-2.0)",
   "publishConfig": {
     "access": "public"
@@ -16,12 +16,12 @@
     "node": ">= 16.0.0"
   },
   "dependencies": {
-    "@atlaspack/diagnostic": "2.14.3-dev-inline-requires-reuse-bdc9ca9c3.0",
-    "@atlaspack/feature-flags": "2.23.1-dev-inline-requires-reuse-bdc9ca9c3.0",
-    "@atlaspack/plugin": "2.14.26-dev-inline-requires-reuse-bdc9ca9c3.0",
-    "@atlaspack/rust": "3.6.1-dev-inline-requires-reuse-bdc9ca9c3.0",
-    "@atlaspack/types": "2.15.16-dev-inline-requires-reuse-bdc9ca9c3.0",
-    "@atlaspack/utils": "2.18.3-dev-inline-requires-reuse-bdc9ca9c3.0",
+    "@atlaspack/diagnostic": "2.14.4-inline-requires-take-2-2a0c642df.0",
+    "@atlaspack/feature-flags": "2.23.2-inline-requires-take-2-2a0c642df.0",
+    "@atlaspack/plugin": "2.14.27-inline-requires-take-2-2a0c642df.0",
+    "@atlaspack/rust": "3.6.2-inline-requires-take-2-2a0c642df.0",
+    "@atlaspack/types": "2.15.17-inline-requires-take-2-2a0c642df.0",
+    "@atlaspack/utils": "2.18.4-inline-requires-take-2-2a0c642df.0",
     "@parcel/source-map": "^2.1.1",
     "globals": "^13.2.0",
     "nullthrows": "^1.1.1",
@@ -32,5 +32,5 @@
     "check-ts": "tsc --emitDeclarationOnly --rootDir src",
     "build:lib": "gulp build --gulpfile ../../../gulpfile.js --cwd ."
   },
-  "gitHead": "bdc9ca9c38f45155a6d6f280e343a29e3f030a83"
+  "gitHead": "2a0c642dfe354e30a8cbd23be0b1a283eab54040"
 }

package/src/ScopeHoistingPackager.ts

@@ -220,10 +220,19 @@ export class ScopeHoistingPackager {
     let entries = this.bundle.getEntryAssets();
     let mainEntry = this.bundle.getMainEntry();
     if (this.isAsyncBundle) {
-      // In async bundles we don't want the main entry to execute until we require it
-      // as there might be dependencies in a sibling bundle that hasn't loaded yet.
-      if (getFeatureFlag('supportWebpackChunkName')) {
-        entries = [];
+      if (
+        getFeatureFlag('applyScopeHoistingImprovement') ||
+        getFeatureFlag('supportWebpackChunkName')
+      ) {
+        // Generally speaking, async bundles should not be executed on load, as
+        // they're just collections of assets that other assets require.
+        // However, there are some special cases where a runtime asset needs to be
+        // injected, but no other asset will require it (mostly the bundle
+        // manifest).
+        // In this case, those assets need to be required on load.
+        entries = entries.filter(
+          (a) => a.meta?.runtimeAssetRequiringExecutionOnLoad,
+        );
       } else {
         entries = entries.filter((a) => a.id !== mainEntry?.id);
       }