@atlaspack/graph 3.2.1-dev.3567 → 3.3.1-canary.3630

package/CHANGELOG.md

@@ -0,0 +1,12 @@
+# @atlaspack/graph
+
+## 3.3.0
+
+### Minor Changes
+
+- [#335](https://github.com/atlassian-labs/atlaspack/pull/335) [`b4dbd4d`](https://github.com/atlassian-labs/atlaspack/commit/b4dbd4d5b23d1b7aa3fcdf59cc7bc8bedd3a59cf) Thanks [@yamadapc](https://github.com/yamadapc)! - Initial changeset release
+
+### Patch Changes
+
+- Updated dependencies [[`b4dbd4d`](https://github.com/atlassian-labs/atlaspack/commit/b4dbd4d5b23d1b7aa3fcdf59cc7bc8bedd3a59cf)]:
+  - @atlaspack/feature-flags@2.13.0

package/lib/AdjacencyList.js

@@ -268,7 +268,7 @@ class AdjacencyList {
    * Returns `true` if the edge was added,
    * or `false` if the edge already exists.
    */
-  addEdge(from, to, type = 1) {
+  addEdge(from, to, type = _Graph.NULL_EDGE_TYPE) {
     (0, _assert().default)(from < this.#nodes.nextId, `Node ${from} does not exist.`);
     (0, _assert().default)(to < this.#nodes.nextId, `Node ${to} does not exist.`);
     (0, _assert().default)(type > 0, `Unsupported edge type ${type}`);
@@ -316,7 +316,7 @@ class AdjacencyList {
   /**
    * Check if the graph has an edge connecting the `from` and `to` nodes.
    */
-  hasEdge(from, to, type = 1) {
+  hasEdge(from, to, type = _Graph.NULL_EDGE_TYPE) {
     let hasEdge = type => {
       let hash = this.#edges.hash(from, to, type);
       return this.#edges.addressOf(hash, from, to, type) !== null;
@@ -335,7 +335,7 @@ class AdjacencyList {
    *
    * This method will increment the edge delete count.
    */
-  removeEdge(from, to, type = 1) {
+  removeEdge(from, to, type = _Graph.NULL_EDGE_TYPE) {
     let hash = this.#edges.hash(from, to, type);
     let edge = this.#edges.addressOf(hash, from, to, type);
 
@@ -429,7 +429,7 @@ class AdjacencyList {
    * If `type` is an array, return nodes connected by edges of any of those types.
    * If `type` is `AllEdgeTypes` (`-1`), return nodes connected by edges of any type.
    */
-  getNodeIdsConnectedFrom(from, type = 1) {
+  getNodeIdsConnectedFrom(from, type = _Graph.NULL_EDGE_TYPE) {
     let matches = node => type === _Graph.ALL_EDGE_TYPES || (Array.isArray(type) ? type.includes(this.#nodes.typeOf(node)) : type === this.#nodes.typeOf(node));
     let nodes = [];
     let seen = new Set();
@@ -467,7 +467,7 @@ class AdjacencyList {
       node = this.#nodes.next(node);
     }
   }
-  forEachNodeIdConnectedTo(to, fn, type = 1) {
+  forEachNodeIdConnectedTo(to, fn, type = _Graph.NULL_EDGE_TYPE) {
     const matches = node => type === _Graph.ALL_EDGE_TYPES || type === this.#nodes.typeOf(node);
     let node = this.#nodes.head(to);
     while (node !== null) {
@@ -492,7 +492,7 @@ class AdjacencyList {
    * If `type` is an array, return nodes connected by edges of any of those types.
    * If `type` is `AllEdgeTypes` (`-1`), return nodes connected by edges of any type.
    */
-  getNodeIdsConnectedTo(to, type = 1) {
+  getNodeIdsConnectedTo(to, type = _Graph.NULL_EDGE_TYPE) {
     let matches = node => type === _Graph.ALL_EDGE_TYPES || (Array.isArray(type) ? type.includes(this.#nodes.typeOf(node)) : type === this.#nodes.typeOf(node));
     let nodes = [];
     let seen = new Set();

package/lib/ContentGraph.js

@@ -63,6 +63,9 @@ class ContentGraph extends _Graph.default {
       return super.getNode(nodeId);
     }
   }
+  getContentKeyByNodeId(nodeId) {
+    return (0, _nullthrows().default)(this._nodeIdToContentKey.get(nodeId), `Expected node id ${nodeId} to exist`);
+  }
   getNodeIdByContentKey(contentKey) {
     return (0, _nullthrows().default)(this._contentKeyToNodeId.get(contentKey), `Expected content key ${contentKey} to exist`);
   }

package/lib/Graph.js

@@ -3,7 +3,7 @@
 Object.defineProperty(exports, "__esModule", {
   value: true
 });
-exports.default = exports.ALL_EDGE_TYPES = void 0;
+exports.default = exports.NULL_EDGE_TYPE = exports.ALL_EDGE_TYPES = void 0;
 exports.mapVisitor = mapVisitor;
 var _types = require("./types");
 var _AdjacencyList = _interopRequireDefault(require("./AdjacencyList"));
@@ -16,6 +16,7 @@ function _nullthrows() {
   return data;
 }
 function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }
+const NULL_EDGE_TYPE = exports.NULL_EDGE_TYPE = 1;
 const ALL_EDGE_TYPES = exports.ALL_EDGE_TYPES = -1;
 
 /**
@@ -70,7 +71,7 @@ class Graph {
   getNode(id) {
     return this.nodes[id];
   }
-  addEdge(from, to, type = 1) {
+  addEdge(from, to, type = NULL_EDGE_TYPE) {
     if (Number(type) === 0) {
       throw new Error(`Edge type "${type}" not allowed`);
     }
@@ -82,25 +83,25 @@ class Graph {
     }
     return this.adjacencyList.addEdge(from, to, type);
   }
-  hasEdge(from, to, type = 1) {
+  hasEdge(from, to, type = NULL_EDGE_TYPE) {
     return this.adjacencyList.hasEdge(from, to, type);
   }
-  forEachNodeIdConnectedTo(to, fn, type = 1) {
+  forEachNodeIdConnectedTo(to, fn, type = NULL_EDGE_TYPE) {
     this._assertHasNodeId(to);
     this.adjacencyList.forEachNodeIdConnectedTo(to, fn, type);
   }
-  forEachNodeIdConnectedFrom(from, fn, type = 1) {
+  forEachNodeIdConnectedFrom(from, fn, type = NULL_EDGE_TYPE) {
     this._assertHasNodeId(from);
     this.adjacencyList.forEachNodeIdConnectedFromReverse(from, id => {
       fn(id);
       return false;
     }, type);
   }
-  getNodeIdsConnectedTo(nodeId, type = 1) {
+  getNodeIdsConnectedTo(nodeId, type = NULL_EDGE_TYPE) {
     this._assertHasNodeId(nodeId);
     return this.adjacencyList.getNodeIdsConnectedTo(nodeId, type);
   }
-  getNodeIdsConnectedFrom(nodeId, type = 1) {
+  getNodeIdsConnectedFrom(nodeId, type = NULL_EDGE_TYPE) {
     this._assertHasNodeId(nodeId);
     return this.adjacencyList.getNodeIdsConnectedFrom(nodeId, type);
   }
@@ -127,7 +128,7 @@ class Graph {
     }
     this.nodes[nodeId] = null;
   }
-  removeEdges(nodeId, type = 1) {
+  removeEdges(nodeId, type = NULL_EDGE_TYPE) {
     if (!this.hasNode(nodeId)) {
       return;
     }
@@ -135,7 +136,7 @@ class Graph {
       this._removeEdge(nodeId, to, type);
     }
   }
-  removeEdge(from, to, type = 1, removeOrphans = true) {
+  removeEdge(from, to, type = NULL_EDGE_TYPE, removeOrphans = true) {
     if (!this.adjacencyList.hasEdge(from, to, type)) {
       throw new Error(`Edge from ${(0, _types.fromNodeId)(from)} to ${(0, _types.fromNodeId)(to)} not found!`);
     }
@@ -143,7 +144,7 @@ class Graph {
   }
 
   // Removes edge and node the edge is to if the node is orphaned
-  _removeEdge(from, to, type = 1, removeOrphans = true) {
+  _removeEdge(from, to, type = NULL_EDGE_TYPE, removeOrphans = true) {
     if (!this.adjacencyList.hasEdge(from, to, type)) {
       return;
     }
@@ -183,7 +184,7 @@ class Graph {
   }
 
   // Update a node's downstream nodes making sure to prune any orphaned branches
-  replaceNodeIdsConnectedTo(fromNodeId, toNodeIds, replaceFilter, type = 1) {
+  replaceNodeIdsConnectedTo(fromNodeId, toNodeIds, replaceFilter, type = NULL_EDGE_TYPE, removeOrphans = true) {
     this._assertHasNodeId(fromNodeId);
     let outboundEdges = this.getNodeIdsConnectedFrom(fromNodeId, type);
     let childrenToRemove = new Set(replaceFilter ? outboundEdges.filter(toNodeId => replaceFilter(toNodeId)) : outboundEdges);
@@ -194,10 +195,10 @@ class Graph {
       }
     }
     for (let child of childrenToRemove) {
-      this._removeEdge(fromNodeId, child, type);
+      this._removeEdge(fromNodeId, child, type, removeOrphans);
     }
   }
-  traverse(visit, startNodeId, type = 1) {
+  traverse(visit, startNodeId, type = NULL_EDGE_TYPE) {
     let enter = typeof visit === 'function' ? visit : visit.enter;
     if (type === ALL_EDGE_TYPES && enter && (typeof visit === 'function' || !visit.exit)) {
       return this.dfsFast(enter, startNodeId);
@@ -212,7 +213,7 @@ class Graph {
   filteredTraverse(filter, visit, startNodeId, type) {
     return this.traverse(mapVisitor(filter, visit), startNodeId, type);
   }
-  traverseAncestors(startNodeId, visit, type = 1) {
+  traverseAncestors(startNodeId, visit, type = NULL_EDGE_TYPE) {
     return this.dfs({
       visit,
       startNodeId,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@atlaspack/graph",
-  "version": "3.2.1-dev.3567+c06f4487e",
+  "version": "3.3.1-canary.3630+10a6f37ef",
   "description": "Blazing fast, zero configuration web application bundler",
   "license": "(MIT OR Apache-2.0)",
   "publishConfig": {
@@ -16,8 +16,8 @@
     "node": ">= 16.0.0"
   },
   "dependencies": {
-    "@atlaspack/feature-flags": "2.12.1-dev.3567+c06f4487e",
+    "@atlaspack/feature-flags": "2.13.1-canary.3630+10a6f37ef",
     "nullthrows": "^1.1.1"
   },
-  "gitHead": "c06f4487ebddc632957147c8b585a97e149062a1"
+  "gitHead": "10a6f37ef063d0227ebb26310383e899dbd9b1e6"
 }

package/src/AdjacencyList.js

@@ -3,7 +3,12 @@ import assert from 'assert';
 import nullthrows from 'nullthrows';
 import {SharedBuffer} from './shared-buffer';
 import {fromNodeId, toNodeId} from './types';
-import {ALL_EDGE_TYPES, type NullEdgeType, type AllEdgeTypes} from './Graph';
+import {
+  ALL_EDGE_TYPES,
+  NULL_EDGE_TYPE,
+  type NullEdgeType,
+  type AllEdgeTypes,
+} from './Graph';
 import type {NodeId} from './types';
 
 /** The address of the node in the nodes map. */
@@ -116,7 +121,7 @@ const MAX_LINK_TRIES: 3 = 3;
  * `getInboundEdgesByType` methods.
  *
  */
-export default class AdjacencyList<TEdgeType: number = 1> {
+export default class AdjacencyList<TEdgeType: number = NullEdgeType> {
   #nodes: NodeTypeMap<TEdgeType | NullEdgeType>;
   #edges: EdgeTypeMap<TEdgeType | NullEdgeType>;
 
@@ -363,7 +368,7 @@ export default class AdjacencyList<TEdgeType: number = 1> {
   addEdge(
     from: NodeId,
     to: NodeId,
-    type: TEdgeType | NullEdgeType = 1,
+    type: TEdgeType | NullEdgeType = NULL_EDGE_TYPE,
   ): boolean {
     assert(from < this.#nodes.nextId, `Node ${from} does not exist.`);
     assert(to < this.#nodes.nextId, `Node ${to} does not exist.`);
@@ -433,7 +438,10 @@ export default class AdjacencyList<TEdgeType: number = 1> {
   hasEdge(
     from: NodeId,
     to: NodeId,
-    type: TEdgeType | NullEdgeType | Array<TEdgeType | NullEdgeType> = 1,
+    type:
+      | TEdgeType
+      | NullEdgeType
+      | Array<TEdgeType | NullEdgeType> = NULL_EDGE_TYPE,
   ): boolean {
     let hasEdge = (type: TEdgeType | NullEdgeType) => {
       let hash = this.#edges.hash(from, to, type);
@@ -458,7 +466,7 @@ export default class AdjacencyList<TEdgeType: number = 1> {
   removeEdge(
     from: NodeId,
     to: NodeId,
-    type: TEdgeType | NullEdgeType = 1,
+    type: TEdgeType | NullEdgeType = NULL_EDGE_TYPE,
   ): void {
     let hash = this.#edges.hash(from, to, type);
     let edge = this.#edges.addressOf(hash, from, to, type);
@@ -568,7 +576,7 @@ export default class AdjacencyList<TEdgeType: number = 1> {
       | AllEdgeTypes
       | TEdgeType
       | NullEdgeType
-      | Array<TEdgeType | NullEdgeType> = 1,
+      | Array<TEdgeType | NullEdgeType> = NULL_EDGE_TYPE,
   ): NodeId[] {
     let matches = (node) =>
       type === ALL_EDGE_TYPES ||
@@ -622,7 +630,7 @@ export default class AdjacencyList<TEdgeType: number = 1> {
   forEachNodeIdConnectedTo(
     to: NodeId,
     fn: (nodeId: NodeId) => boolean | void,
-    type: AllEdgeTypes | TEdgeType | NullEdgeType = 1,
+    type: AllEdgeTypes | TEdgeType | NullEdgeType = NULL_EDGE_TYPE,
   ) {
     const matches = (node) =>
       type === ALL_EDGE_TYPES || type === this.#nodes.typeOf(node);
@@ -656,7 +664,7 @@ export default class AdjacencyList<TEdgeType: number = 1> {
       | AllEdgeTypes
       | TEdgeType
       | NullEdgeType
-      | Array<TEdgeType | NullEdgeType> = 1,
+      | Array<TEdgeType | NullEdgeType> = NULL_EDGE_TYPE,
   ): NodeId[] {
     let matches = (node) =>
       type === ALL_EDGE_TYPES ||

package/src/ContentGraph.js

@@ -75,6 +75,13 @@ export default class ContentGraph<TNode, TEdgeType: number = 1> extends Graph<
     }
   }
 
+  getContentKeyByNodeId(nodeId: NodeId): ContentKey {
+    return nullthrows(
+      this._nodeIdToContentKey.get(nodeId),
+      `Expected node id ${nodeId} to exist`,
+    );
+  }
+
   getNodeIdByContentKey(contentKey: ContentKey): NodeId {
     return nullthrows(
       this._contentKeyToNodeId.get(contentKey),

package/src/Graph.js

@@ -13,14 +13,15 @@ import {BitSet} from './BitSet';
 import nullthrows from 'nullthrows';
 
 export type NullEdgeType = 1;
-export type GraphOpts<TNode, TEdgeType: number = 1> = {|
+export const NULL_EDGE_TYPE: NullEdgeType = 1;
+export type GraphOpts<TNode, TEdgeType: number = NullEdgeType> = {|
   nodes?: Array<TNode | null>,
   adjacencyList?: SerializedAdjacencyList<TEdgeType>,
   rootNodeId?: ?NodeId,
   initialCapacity?: number,
 |};
 
-export type SerializedGraph<TNode, TEdgeType: number = 1> = {|
+export type SerializedGraph<TNode, TEdgeType: number = NullEdgeType> = {|
   nodes: Array<TNode | null>,
   adjacencyList: SerializedAdjacencyList<TEdgeType>,
   rootNodeId: ?NodeId,
@@ -74,7 +75,7 @@ export type DFSParams<TContext> = {|
   startNodeId?: ?NodeId,
 |};
 
-export default class Graph<TNode, TEdgeType: number = 1> {
+export default class Graph<TNode, TEdgeType: number = NullEdgeType> {
   nodes: Array<TNode | null>;
   adjacencyList: AdjacencyList<TEdgeType>;
   rootNodeId: ?NodeId;
@@ -138,7 +139,7 @@ export default class Graph<TNode, TEdgeType: number = 1> {
   addEdge(
     from: NodeId,
     to: NodeId,
-    type: TEdgeType | NullEdgeType = 1,
+    type: TEdgeType | NullEdgeType = NULL_EDGE_TYPE,
   ): boolean {
     if (Number(type) === 0) {
       throw new Error(`Edge type "${type}" not allowed`);
@@ -158,7 +159,10 @@ export default class Graph<TNode, TEdgeType: number = 1> {
   hasEdge(
     from: NodeId,
     to: NodeId,
-    type?: TEdgeType | NullEdgeType | Array<TEdgeType | NullEdgeType> = 1,
+    type?:
+      | TEdgeType
+      | NullEdgeType
+      | Array<TEdgeType | NullEdgeType> = NULL_EDGE_TYPE,
   ): boolean {
     return this.adjacencyList.hasEdge(from, to, type);
   }
@@ -166,7 +170,7 @@ export default class Graph<TNode, TEdgeType: number = 1> {
   forEachNodeIdConnectedTo(
     to: NodeId,
     fn: (nodeId: NodeId) => boolean | void,
-    type: AllEdgeTypes | TEdgeType | NullEdgeType = 1,
+    type: AllEdgeTypes | TEdgeType | NullEdgeType = NULL_EDGE_TYPE,
   ) {
     this._assertHasNodeId(to);
 
@@ -176,7 +180,7 @@ export default class Graph<TNode, TEdgeType: number = 1> {
   forEachNodeIdConnectedFrom(
     from: NodeId,
     fn: (nodeId: NodeId) => void,
-    type: AllEdgeTypes | TEdgeType | NullEdgeType = 1,
+    type: AllEdgeTypes | TEdgeType | NullEdgeType = NULL_EDGE_TYPE,
   ) {
     this._assertHasNodeId(from);
 
@@ -196,7 +200,7 @@ export default class Graph<TNode, TEdgeType: number = 1> {
       | TEdgeType
       | NullEdgeType
       | Array<TEdgeType | NullEdgeType>
-      | AllEdgeTypes = 1,
+      | AllEdgeTypes = NULL_EDGE_TYPE,
   ): Array<NodeId> {
     this._assertHasNodeId(nodeId);
 
@@ -209,7 +213,7 @@ export default class Graph<TNode, TEdgeType: number = 1> {
       | TEdgeType
       | NullEdgeType
       | Array<TEdgeType | NullEdgeType>
-      | AllEdgeTypes = 1,
+      | AllEdgeTypes = NULL_EDGE_TYPE,
   ): Array<NodeId> {
     this._assertHasNodeId(nodeId);
 
@@ -240,7 +244,7 @@ export default class Graph<TNode, TEdgeType: number = 1> {
     this.nodes[nodeId] = null;
   }
 
-  removeEdges(nodeId: NodeId, type: TEdgeType | NullEdgeType = 1) {
+  removeEdges(nodeId: NodeId, type: TEdgeType | NullEdgeType = NULL_EDGE_TYPE) {
     if (!this.hasNode(nodeId)) {
       return;
     }
@@ -253,7 +257,7 @@ export default class Graph<TNode, TEdgeType: number = 1> {
   removeEdge(
     from: NodeId,
     to: NodeId,
-    type: TEdgeType | NullEdgeType = 1,
+    type: TEdgeType | NullEdgeType = NULL_EDGE_TYPE,
     removeOrphans: boolean = true,
   ) {
     if (!this.adjacencyList.hasEdge(from, to, type)) {
@@ -269,7 +273,7 @@ export default class Graph<TNode, TEdgeType: number = 1> {
   _removeEdge(
     from: NodeId,
     to: NodeId,
-    type: TEdgeType | NullEdgeType = 1,
+    type: TEdgeType | NullEdgeType = NULL_EDGE_TYPE,
     removeOrphans: boolean = true,
   ) {
     if (!this.adjacencyList.hasEdge(from, to, type)) {
@@ -325,7 +329,8 @@ export default class Graph<TNode, TEdgeType: number = 1> {
     fromNodeId: NodeId,
     toNodeIds: $ReadOnlyArray<NodeId>,
     replaceFilter?: null | ((NodeId) => boolean),
-    type?: TEdgeType | NullEdgeType = 1,
+    type?: TEdgeType | NullEdgeType = NULL_EDGE_TYPE,
+    removeOrphans: boolean = true,
   ): void {
     this._assertHasNodeId(fromNodeId);
 
@@ -344,7 +349,7 @@ export default class Graph<TNode, TEdgeType: number = 1> {
     }
 
     for (let child of childrenToRemove) {
-      this._removeEdge(fromNodeId, child, type);
+      this._removeEdge(fromNodeId, child, type, removeOrphans);
     }
   }
 
@@ -355,7 +360,7 @@ export default class Graph<TNode, TEdgeType: number = 1> {
       | TEdgeType
       | NullEdgeType
       | Array<TEdgeType | NullEdgeType>
-      | AllEdgeTypes = 1,
+      | AllEdgeTypes = NULL_EDGE_TYPE,
   ): ?TContext {
     let enter = typeof visit === 'function' ? visit : visit.enter;
     if (
@@ -389,7 +394,7 @@ export default class Graph<TNode, TEdgeType: number = 1> {
       | TEdgeType
       | NullEdgeType
       | Array<TEdgeType | NullEdgeType>
-      | AllEdgeTypes = 1,
+      | AllEdgeTypes = NULL_EDGE_TYPE,
   ): ?TContext {
     return this.dfs({
       visit,

package/test/ContentGraph.test.js

@@ -39,4 +39,22 @@ describe('ContentGraph', () => {
 
     assert(!graph.hasContentKey('contentKey'));
   });
+
+  describe('getContentKeyByNodeId', () => {
+    it('returns the content key for a node', () => {
+      const graph = new ContentGraph();
+
+      const node1 = graph.addNodeByContentKey('node1', {});
+      assert.equal(graph.getContentKeyByNodeId(node1), 'node1');
+      const node2 = graph.addNodeByContentKey('node2', {});
+      assert.equal(graph.getContentKeyByNodeId(node2), 'node2');
+    });
+
+    it('throws if the node does not have a content key', () => {
+      const graph = new ContentGraph();
+
+      const node1 = graph.addNode({});
+      assert.throws(() => graph.getContentKeyByNodeId(node1));
+    });
+  });
 });

package/test/Graph.test.js

@@ -37,13 +37,6 @@ describe('Graph', () => {
     }, /Does not have node/);
   });
 
-  it("errors if replaceNodeIdsConnectedTo is called with a node that doesn't belong", () => {
-    let graph = new Graph();
-    assert.throws(() => {
-      graph.replaceNodeIdsConnectedTo(toNodeId(-1), []);
-    }, /Does not have node/);
-  });
-
   it("errors when adding an edge to a node that doesn't exist", () => {
     let graph = new Graph();
     let node = graph.addNode({});
@@ -274,26 +267,63 @@ describe('Graph', () => {
     }
   });
 
-  it("replaceNodeIdsConnectedTo should update a node's downstream nodes", () => {
-    let graph = new Graph();
-    let nodeA = graph.addNode('a');
-    graph.setRootNodeId(nodeA);
-    let nodeB = graph.addNode('b');
-    let nodeC = graph.addNode('c');
-    graph.addEdge(nodeA, nodeB);
-    graph.addEdge(nodeA, nodeC);
+  describe('replaceNodeIdsConnectedTo', () => {
+    it("errors if replaceNodeIdsConnectedTo is called with a node that doesn't belong", () => {
+      let graph = new Graph();
+      assert.throws(() => {
+        graph.replaceNodeIdsConnectedTo(toNodeId(-1), []);
+      }, /Does not have node/);
+    });
 
-    let nodeD = graph.addNode('d');
-    graph.replaceNodeIdsConnectedTo(nodeA, [nodeB, nodeD]);
+    it("replaceNodeIdsConnectedTo should update a node's downstream nodes", () => {
+      let graph = new Graph();
+      let nodeA = graph.addNode('a');
+      graph.setRootNodeId(nodeA);
+      let nodeB = graph.addNode('b');
+      let nodeC = graph.addNode('c');
+      graph.addEdge(nodeA, nodeB);
+      graph.addEdge(nodeA, nodeC);
+
+      let nodeD = graph.addNode('d');
+      graph.replaceNodeIdsConnectedTo(nodeA, [nodeB, nodeD]);
+
+      assert(graph.hasNode(nodeA));
+      assert(graph.hasNode(nodeB));
+      assert(!graph.hasNode(nodeC)); // orphan removed
+      assert(graph.hasNode(nodeD));
+      assert.deepEqual(Array.from(graph.getAllEdges()), [
+        {from: nodeA, to: nodeB, type: 1},
+        {from: nodeA, to: nodeD, type: 1},
+      ]);
+    });
 
-    assert(graph.hasNode(nodeA));
-    assert(graph.hasNode(nodeB));
-    assert(!graph.hasNode(nodeC));
-    assert(graph.hasNode(nodeD));
-    assert.deepEqual(Array.from(graph.getAllEdges()), [
-      {from: nodeA, to: nodeB, type: 1},
-      {from: nodeA, to: nodeD, type: 1},
-    ]);
+    it('replaceNodeIdsConnectedTo does not remove orphan nodes if flag is false', () => {
+      let graph = new Graph();
+      let nodeA = graph.addNode('a');
+      graph.setRootNodeId(nodeA);
+      let nodeB = graph.addNode('b');
+      let nodeC = graph.addNode('c');
+      graph.addEdge(nodeA, nodeB);
+      graph.addEdge(nodeA, nodeC);
+
+      let nodeD = graph.addNode('d');
+      graph.replaceNodeIdsConnectedTo(
+        nodeA,
+        [nodeB, nodeD],
+        () => true,
+        1,
+        false,
+      );
+
+      assert(graph.hasNode(nodeA));
+      assert(graph.hasNode(nodeB));
+      assert(graph.hasNode(nodeC)); // orphan kept
+      assert(graph.hasNode(nodeD));
+      assert.deepEqual(Array.from(graph.getAllEdges()), [
+        {from: nodeA, to: nodeB, type: 1},
+        {from: nodeA, to: nodeD, type: 1},
+      ]);
+    });
   });
 
   it('traverses along edge types if a filter is given', () => {