@atlaspack/feature-flags 2.19.2 → 2.19.3-typescript-80839fbd5.0

package/CHANGELOG.md

@@ -68,7 +68,6 @@
 ### Patch Changes
 
 - [#632](https://github.com/atlassian-labs/atlaspack/pull/632) [`10fbcfb`](https://github.com/atlassian-labs/atlaspack/commit/10fbcfbfa49c7a83da5d7c40983e36e87f524a75) Thanks [@marcins](https://github.com/marcins)! - Added a new feature flag `inlineConstOptimisationFix` which when enabled changes the behaviour for output of constant modules. This fixes two issues with constant modules:
-
   - Previously constant modules, if they needed a namespace anywhere, would have a namespace everywhere, with this change they only have a namespace in the bundles where needed.
   - Previously in the case of wrapped assets, a constant module dependnecy of that wrapped asset would be rendered after the module - which meant the minifier would not be able to inline the constants safely. With this flag all constant modules are rendered at the top of the bundle.
 

package/LICENSE

@@ -0,0 +1,201 @@
+                                 Apache License
+                           Version 2.0, January 2004
+                        http://www.apache.org/licenses/
+
+   TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION
+
+   1. Definitions.
+
+      "License" shall mean the terms and conditions for use, reproduction,
+      and distribution as defined by Sections 1 through 9 of this document.
+
+      "Licensor" shall mean the copyright owner or entity authorized by
+      the copyright owner that is granting the License.
+
+      "Legal Entity" shall mean the union of the acting entity and all
+      other entities that control, are controlled by, or are under common
+      control with that entity. For the purposes of this definition,
+      "control" means (i) the power, direct or indirect, to cause the
+      direction or management of such entity, whether by contract or
+      otherwise, or (ii) ownership of fifty percent (50%) or more of the
+      outstanding shares, or (iii) beneficial ownership of such entity.
+
+      "You" (or "Your") shall mean an individual or Legal Entity
+      exercising permissions granted by this License.
+
+      "Source" form shall mean the preferred form for making modifications,
+      including but not limited to software source code, documentation
+      source, and configuration files.
+
+      "Object" form shall mean any form resulting from mechanical
+      transformation or translation of a Source form, including but
+      not limited to compiled object code, generated documentation,
+      and conversions to other media types.
+
+      "Work" shall mean the work of authorship, whether in Source or
+      Object form, made available under the License, as indicated by a
+      copyright notice that is included in or attached to the work
+      (an example is provided in the Appendix below).
+
+      "Derivative Works" shall mean any work, whether in Source or Object
+      form, that is based on (or derived from) the Work and for which the
+      editorial revisions, annotations, elaborations, or other modifications
+      represent, as a whole, an original work of authorship. For the purposes
+      of this License, Derivative Works shall not include works that remain
+      separable from, or merely link (or bind by name) to the interfaces of,
+      the Work and Derivative Works thereof.
+
+      "Contribution" shall mean any work of authorship, including
+      the original version of the Work and any modifications or additions
+      to that Work or Derivative Works thereof, that is intentionally
+      submitted to Licensor for inclusion in the Work by the copyright owner
+      or by an individual or Legal Entity authorized to submit on behalf of
+      the copyright owner. For the purposes of this definition, "submitted"
+      means any form of electronic, verbal, or written communication sent
+      to the Licensor or its representatives, including but not limited to
+      communication on electronic mailing lists, source code control systems,
+      and issue tracking systems that are managed by, or on behalf of, the
+      Licensor for the purpose of discussing and improving the Work, but
+      excluding communication that is conspicuously marked or otherwise
+      designated in writing by the copyright owner as "Not a Contribution."
+
+      "Contributor" shall mean Licensor and any individual or Legal Entity
+      on behalf of whom a Contribution has been received by Licensor and
+      subsequently incorporated within the Work.
+
+   2. Grant of Copyright License. Subject to the terms and conditions of
+      this License, each Contributor hereby grants to You a perpetual,
+      worldwide, non-exclusive, no-charge, royalty-free, irrevocable
+      copyright license to reproduce, prepare Derivative Works of,
+      publicly display, publicly perform, sublicense, and distribute the
+      Work and such Derivative Works in Source or Object form.
+
+   3. Grant of Patent License. Subject to the terms and conditions of
+      this License, each Contributor hereby grants to You a perpetual,
+      worldwide, non-exclusive, no-charge, royalty-free, irrevocable
+      (except as stated in this section) patent license to make, have made,
+      use, offer to sell, sell, import, and otherwise transfer the Work,
+      where such license applies only to those patent claims licensable
+      by such Contributor that are necessarily infringed by their
+      Contribution(s) alone or by combination of their Contribution(s)
+      with the Work to which such Contribution(s) was submitted. If You
+      institute patent litigation against any entity (including a
+      cross-claim or counterclaim in a lawsuit) alleging that the Work
+      or a Contribution incorporated within the Work constitutes direct
+      or contributory patent infringement, then any patent licenses
+      granted to You under this License for that Work shall terminate
+      as of the date such litigation is filed.
+
+   4. Redistribution. You may reproduce and distribute copies of the
+      Work or Derivative Works thereof in any medium, with or without
+      modifications, and in Source or Object form, provided that You
+      meet the following conditions:
+
+      (a) You must give any other recipients of the Work or
+          Derivative Works a copy of this License; and
+
+      (b) You must cause any modified files to carry prominent notices
+          stating that You changed the files; and
+
+      (c) You must retain, in the Source form of any Derivative Works
+          that You distribute, all copyright, patent, trademark, and
+          attribution notices from the Source form of the Work,
+          excluding those notices that do not pertain to any part of
+          the Derivative Works; and
+
+      (d) If the Work includes a "NOTICE" text file as part of its
+          distribution, then any Derivative Works that You distribute must
+          include a readable copy of the attribution notices contained
+          within such NOTICE file, excluding those notices that do not
+          pertain to any part of the Derivative Works, in at least one
+          of the following places: within a NOTICE text file distributed
+          as part of the Derivative Works; within the Source form or
+          documentation, if provided along with the Derivative Works; or,
+          within a display generated by the Derivative Works, if and
+          wherever such third-party notices normally appear. The contents
+          of the NOTICE file are for informational purposes only and
+          do not modify the License. You may add Your own attribution
+          notices within Derivative Works that You distribute, alongside
+          or as an addendum to the NOTICE text from the Work, provided
+          that such additional attribution notices cannot be construed
+          as modifying the License.
+
+      You may add Your own copyright statement to Your modifications and
+      may provide additional or different license terms and conditions
+      for use, reproduction, or distribution of Your modifications, or
+      for any such Derivative Works as a whole, provided Your use,
+      reproduction, and distribution of the Work otherwise complies with
+      the conditions stated in this License.
+
+   5. Submission of Contributions. Unless You explicitly state otherwise,
+      any Contribution intentionally submitted for inclusion in the Work
+      by You to the Licensor shall be under the terms and conditions of
+      this License, without any additional terms or conditions.
+      Notwithstanding the above, nothing herein shall supersede or modify
+      the terms of any separate license agreement you may have executed
+      with Licensor regarding such Contributions.
+
+   6. Trademarks. This License does not grant permission to use the trade
+      names, trademarks, service marks, or product names of the Licensor,
+      except as required for reasonable and customary use in describing the
+      origin of the Work and reproducing the content of the NOTICE file.
+
+   7. Disclaimer of Warranty. Unless required by applicable law or
+      agreed to in writing, Licensor provides the Work (and each
+      Contributor provides its Contributions) on an "AS IS" BASIS,
+      WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
+      implied, including, without limitation, any warranties or conditions
+      of TITLE, NON-INFRINGEMENT, MERCHANTABILITY, or FITNESS FOR A
+      PARTICULAR PURPOSE. You are solely responsible for determining the
+      appropriateness of using or redistributing the Work and assume any
+      risks associated with Your exercise of permissions under this License.
+
+   8. Limitation of Liability. In no event and under no legal theory,
+      whether in tort (including negligence), contract, or otherwise,
+      unless required by applicable law (such as deliberate and grossly
+      negligent acts) or agreed to in writing, shall any Contributor be
+      liable to You for damages, including any direct, indirect, special,
+      incidental, or consequential damages of any character arising as a
+      result of this License or out of the use or inability to use the
+      Work (including but not limited to damages for loss of goodwill,
+      work stoppage, computer failure or malfunction, or any and all
+      other commercial damages or losses), even if such Contributor
+      has been advised of the possibility of such damages.
+
+   9. Accepting Warranty or Additional Liability. While redistributing
+      the Work or Derivative Works thereof, You may choose to offer,
+      and charge a fee for, acceptance of support, warranty, indemnity,
+      or other liability obligations and/or rights consistent with this
+      License. However, in accepting such obligations, You may act only
+      on Your own behalf and on Your sole responsibility, not on behalf
+      of any other Contributor, and only if You agree to indemnify,
+      defend, and hold each Contributor harmless for any liability
+      incurred by, or claims asserted against, such Contributor by reason
+      of your accepting any such warranty or additional liability.
+
+   END OF TERMS AND CONDITIONS
+
+   APPENDIX: How to apply the Apache License to your work.
+
+      To apply the Apache License to your work, attach the following
+      boilerplate notice, with the fields enclosed by brackets "[]"
+      replaced with your own identifying information. (Don't include
+      the brackets!)  The text should be enclosed in the appropriate
+      comment syntax for the file format. We also recommend that a
+      file or class name and description of purpose be included on the
+      same "printed page" as the copyright notice for easier
+      identification within third-party archives.
+
+   Copyright (c) 2024 Atlassian US., Inc.
+
+   Licensed under the Apache License, Version 2.0 (the "License");
+   you may not use this file except in compliance with the License.
+   You may obtain a copy of the License at
+
+       http://www.apache.org/licenses/LICENSE-2.0
+
+   Unless required by applicable law or agreed to in writing, software
+   distributed under the License is distributed on an "AS IS" BASIS,
+   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+   See the License for the specific language governing permissions and
+   limitations under the License.

package/lib/index.js

@@ -8,8 +8,8 @@ exports.getFeatureFlag = getFeatureFlag;
 exports.getFeatureFlagValue = getFeatureFlagValue;
 exports.runWithConsistencyCheck = runWithConsistencyCheck;
 exports.setFeatureFlags = setFeatureFlags;
-// We need to do these gymnastics as we don't want flow-to-ts to touch DEFAULT_FEATURE_FLAGS,
-// but we want to export FeatureFlags for Flow
+// Converted from Flow to TypeScript
+
 const CONSISTENCY_CHECK_VALUES = exports.CONSISTENCY_CHECK_VALUES = Object.freeze(['NEW', 'OLD', 'NEW_AND_CHECK', 'OLD_AND_CHECK']);
 const DEFAULT_FEATURE_FLAGS = exports.DEFAULT_FEATURE_FLAGS = {
   exampleConsistencyCheckFeature: 'OLD',
@@ -59,6 +59,7 @@ function getFeatureFlagValue(flagName) {
  */
 function runWithConsistencyCheck(flag, oldFn, newFn, diffFn, report) {
   const value = featureFlagValues[flag];
+  // @ts-expect-error - TypeScript doesn't understand the union type comparison
   if (!value || value === false || value === 'OLD') {
     return oldFn();
   }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@atlaspack/feature-flags",
-  "version": "2.19.2",
+  "version": "2.19.3-typescript-80839fbd5.0",
   "description": "Provides internal feature-flags for the atlaspack codebase.",
   "license": "(MIT OR Apache-2.0)",
   "publishConfig": {
@@ -11,14 +11,14 @@
     "url": "https://github.com/atlassian-labs/atlaspack.git"
   },
   "main": "lib/index.js",
-  "source": "src/index.js",
-  "types": "lib/types.d.ts",
+  "source": "src/index.ts",
+  "types": "src/index.ts",
   "scripts": {
-    "build-ts": "mkdir -p lib && flow-to-ts src/types.js > lib/types.d.ts",
-    "check-ts": "tsc --noEmit lib/types.d.ts"
+    "check-ts": "tsc --noEmit"
   },
   "engines": {
     "node": ">= 16.0.0"
   },
-  "type": "commonjs"
+  "type": "commonjs",
+  "gitHead": "80839fbd5c6d6668c2622849856a4b25601354a8"
 }

package/{lib/types.d.ts → src/index.ts}

@@ -1,36 +1,33 @@
-import { $ElementType } from "utility-types";
+// Converted from Flow to TypeScript
+
 export type FeatureFlags = {
-  // This feature flag mostly exists to test the feature flag system, and doesn't have any build/runtime effect
+  /**
+   * This feature flag mostly exists to test the feature flag system, and doesn't have any build/runtime effect
+   */
   readonly exampleFeature: boolean;
   readonly exampleConsistencyCheckFeature: ConsistencyCheckFeatureFlagValue;
-
   /**
    * Rust backed requests
    */
   readonly atlaspackV3: boolean;
-
   /**
    * Use node.js implementation of @parcel/watcher watchman backend
    */
   readonly useWatchmanWatcher: boolean;
-
   /**
    * Configure runtime to enable retriable dynamic imports
    */
   importRetry: boolean;
-
   /**
    * Fixes quadratic cache invalidation issue
    */
   fixQuadraticCacheInvalidation: ConsistencyCheckFeatureFlagValue;
-
   /**
    * Enables an experimental "conditional bundling" API - this allows the use of `importCond` syntax
    * in order to have (consumer) feature flag driven bundling. This feature is very experimental,
    * and requires server-side support.
    */
   conditionalBundlingApi: boolean;
-
   /**
    * Enable VCS mode. Expected values are:
    * - OLD - default value, return watchman result
@@ -38,7 +35,6 @@ export type FeatureFlags = {
    * - NEW: Return VCS result, but don't call watchman
    */
   vcsMode: ConsistencyCheckFeatureFlagValue;
-
   /**
    * Refactor cache to:
    * - Split writes into multiple entries
@@ -46,90 +42,74 @@ export type FeatureFlags = {
    * - Reduce size of the caches by deduplicating data
    */
   cachePerformanceImprovements: boolean;
-
   /**
    * Deduplicates environments across cache / memory entities
    */
   environmentDeduplication: boolean;
-
   /**
    * Enable scanning for the presence of loadable to determine side effects
    */
   loadableSideEffects: boolean;
-
   /**
    * Enable performance optimization for the resolver specifier to_string
    * conversions
    */
   reduceResolverStringCreation: boolean;
-
   /**
    * Add verbose metrics for request tracker invalidation
    */
   verboseRequestInvalidationStats: boolean;
-
   /**
    * Fixes source maps for inline bundles
    */
   inlineBundlesSourceMapFixes: boolean;
-
   /** Enable patch project paths. This will patch the project paths to be relative to the project root.
    * This feature is experimental and should not be used in production. It will used to test downloadble cache artefacts.
    */
   patchProjectPaths: boolean;
-
   /**
    * Enables optimized inline string replacement perf for the packager.
    * Used heavily for inline bundles.
    */
   inlineStringReplacementPerf: boolean;
-
   /**
    * Enable resolution of bundler config starting from the CWD
    */
   resolveBundlerConfigFromCwd: boolean;
-
   /**
    * Enable a setting that allows for more assets to be scope hoisted, if
    * they're safe to do so.
    */
   applyScopeHoistingImprovement: boolean;
-
   /**
    * Enable a change where a constant module only have the namespacing object added in bundles where it is required
    */
   inlineConstOptimisationFix: boolean;
-
   /**
    * Improves/fixes HMR behaviour by:
    * - Fixing HMR behaviour with lazy bundle edges
    * - Moving the functionality of the react-refresh runtime into the react-refresh-wrap transformer
    */
   hmrImprovements: boolean;
-
   /**
    * Adds an end() method to AtlaspckV3 to cleanly shutdown the NAPI worker pool
    */
   atlaspackV3CleanShutdown: boolean;
-
   /**
    * Fixes a bug where imported objects that are accessed with non-static
    * properties (e.g. `CONSTANTS['api_' + endpoint`]) would not be recognised as
    * being used, and thus not included in the bundle.
    */
   unusedComputedPropertyFix: boolean;
-
   /**
    * Fixes an issue where star re-exports of empty files (usually occurring in compiled typescript libraries)
    * could cause exports to undefined at runtime.
    */
   emptyFileStarRexportFix: boolean;
-
   /**
    * Enables the new packaging progress CLI experience
    */
   cliProgressReportingImprovements: boolean;
-
   /**
    * Enable a change to the conditional bundling loader to use a fallback bundle loading if the expected scripts aren't found
    *
@@ -137,13 +117,133 @@ export type FeatureFlags = {
    */
   condbDevFallbackDev: boolean;
   condbDevFallbackProd: boolean;
-
   /**
    * Enable the new incremental bundling versioning logic which determines whether
    * a full bundling pass is required based on the AssetGraph's bundlingVersion.
    */
   incrementalBundlingVersioning: boolean;
 };
-export declare var CONSISTENCY_CHECK_VALUES: ReadonlyArray<string>;
-export type ConsistencyCheckFeatureFlagValue = $ElementType<typeof CONSISTENCY_CHECK_VALUES, number>;
-export declare var DEFAULT_FEATURE_FLAGS: FeatureFlags;
+
+export type ConsistencyCheckFeatureFlagValue =
+  (typeof CONSISTENCY_CHECK_VALUES)[number];
+
+export const CONSISTENCY_CHECK_VALUES: ReadonlyArray<string> = Object.freeze([
+  'NEW',
+  'OLD',
+  'NEW_AND_CHECK',
+  'OLD_AND_CHECK',
+]);
+
+export const DEFAULT_FEATURE_FLAGS: FeatureFlags = {
+  exampleConsistencyCheckFeature: 'OLD',
+  exampleFeature: false,
+  atlaspackV3: false,
+  useWatchmanWatcher: false,
+  importRetry: false,
+  fixQuadraticCacheInvalidation: 'OLD',
+  conditionalBundlingApi: false,
+  vcsMode: 'OLD',
+  loadableSideEffects: false,
+  reduceResolverStringCreation: false,
+  inlineBundlesSourceMapFixes: false,
+  patchProjectPaths: false,
+  cachePerformanceImprovements: process.env.NODE_ENV === 'test',
+  environmentDeduplication: false,
+  inlineStringReplacementPerf: false,
+  // Default to true as it's a monitoring change. Can be turned off if necessary.
+  verboseRequestInvalidationStats: true,
+  resolveBundlerConfigFromCwd: false,
+  applyScopeHoistingImprovement: false,
+  inlineConstOptimisationFix: false,
+  hmrImprovements: false,
+  atlaspackV3CleanShutdown: false,
+  unusedComputedPropertyFix: process.env.NODE_ENV === 'test',
+  emptyFileStarRexportFix: process.env.NODE_ENV === 'test',
+  cliProgressReportingImprovements: false,
+  condbDevFallbackDev: false,
+  condbDevFallbackProd: false,
+  incrementalBundlingVersioning: process.env.NODE_ENV === 'test',
+};
+
+let featureFlagValues: FeatureFlags = {...DEFAULT_FEATURE_FLAGS};
+
+export function setFeatureFlags(flags: FeatureFlags) {
+  featureFlagValues = flags;
+}
+
+export function getFeatureFlag(flagName: keyof FeatureFlags): boolean {
+  const value = featureFlagValues[flagName];
+  return value === true || value === 'NEW';
+}
+
+export function getFeatureFlagValue(
+  flagName: keyof FeatureFlags,
+): boolean | string | number {
+  return featureFlagValues[flagName];
+}
+
+export type DiffResult<CustomDiagnostic> = {
+  isDifferent: boolean;
+  custom: CustomDiagnostic;
+};
+
+export type Diagnostic<CustomDiagnostic> = {
+  isDifferent: boolean;
+  oldExecutionTimeMs: number;
+  newExecutionTimeMs: number;
+  custom: CustomDiagnostic;
+};
+
+/**
+ * Run a function with a consistency check.
+ */
+export function runWithConsistencyCheck<Result, CustomDiagnostic>(
+  flag: keyof FeatureFlags,
+  oldFn: () => Result,
+  newFn: () => Result,
+  diffFn: (
+    oldResult: Result,
+    newResult: Result,
+  ) => DiffResult<CustomDiagnostic>,
+  report: (
+    diagnostic: Diagnostic<CustomDiagnostic>,
+    oldResult: Result,
+    newResult: Result,
+  ) => void,
+): Result {
+  const value = featureFlagValues[flag];
+  // @ts-expect-error - TypeScript doesn't understand the union type comparison
+  if (!value || value === false || value === 'OLD') {
+    return oldFn();
+  }
+  if (value === true || value === 'NEW') {
+    return newFn();
+  }
+
+  const oldStartTime = performance.now();
+  const oldResult = oldFn();
+  const oldExecutionTimeMs = performance.now() - oldStartTime;
+
+  const newStartTime = performance.now();
+  const newResult = newFn();
+  const newExecutionTimeMs = performance.now() - newStartTime;
+
+  const diff = diffFn(oldResult, newResult);
+
+  report(
+    {
+      isDifferent: diff.isDifferent,
+      oldExecutionTimeMs,
+      newExecutionTimeMs,
+      custom: diff.custom,
+    },
+    oldResult,
+    newResult,
+  );
+
+  if (value === 'NEW_AND_CHECK') {
+    return newResult;
+  }
+
+  return oldResult;
+}

package/test/{feature-flags.test.js → feature-flags.test.ts}

@@ -1,4 +1,3 @@
-// @flow strict
 import assert from 'assert';
 import {
   getFeatureFlag,

package/tsconfig.json

@@ -0,0 +1,4 @@
+{
+  "extends": "../../../tsconfig.json",
+  "include": ["src"]
+}

package/lib/types.js

@@ -1 +0,0 @@
-"use strict";

package/src/index.js

@@ -1,126 +0,0 @@
-// @flow strict
-
-import type {FeatureFlags as _FeatureFlags} from './types';
-// We need to do these gymnastics as we don't want flow-to-ts to touch DEFAULT_FEATURE_FLAGS,
-// but we want to export FeatureFlags for Flow
-export type FeatureFlags = _FeatureFlags;
-
-export const CONSISTENCY_CHECK_VALUES: $ReadOnlyArray<string> = Object.freeze([
-  'NEW',
-  'OLD',
-  'NEW_AND_CHECK',
-  'OLD_AND_CHECK',
-]);
-
-export const DEFAULT_FEATURE_FLAGS: FeatureFlags = {
-  exampleConsistencyCheckFeature: 'OLD',
-  exampleFeature: false,
-  atlaspackV3: false,
-  useWatchmanWatcher: false,
-  importRetry: false,
-  fixQuadraticCacheInvalidation: 'OLD',
-  conditionalBundlingApi: false,
-  vcsMode: 'OLD',
-  loadableSideEffects: false,
-  reduceResolverStringCreation: false,
-  inlineBundlesSourceMapFixes: false,
-  patchProjectPaths: false,
-  cachePerformanceImprovements: process.env.NODE_ENV === 'test',
-  environmentDeduplication: false,
-  inlineStringReplacementPerf: false,
-  // Default to true as it's a monitoring change. Can be turned off if necessary.
-  verboseRequestInvalidationStats: true,
-  resolveBundlerConfigFromCwd: false,
-  applyScopeHoistingImprovement: false,
-  inlineConstOptimisationFix: false,
-  hmrImprovements: false,
-  atlaspackV3CleanShutdown: false,
-  unusedComputedPropertyFix: process.env.NODE_ENV === 'test',
-  emptyFileStarRexportFix: process.env.NODE_ENV === 'test',
-  cliProgressReportingImprovements: false,
-  condbDevFallbackDev: false,
-  condbDevFallbackProd: false,
-  incrementalBundlingVersioning: process.env.NODE_ENV === 'test',
-};
-
-let featureFlagValues: FeatureFlags = {...DEFAULT_FEATURE_FLAGS};
-
-export function setFeatureFlags(flags: FeatureFlags) {
-  featureFlagValues = flags;
-}
-
-export function getFeatureFlag(flagName: $Keys<FeatureFlags>): boolean {
-  const value = featureFlagValues[flagName];
-  return value === true || value === 'NEW';
-}
-
-export function getFeatureFlagValue(
-  flagName: $Keys<FeatureFlags>,
-): boolean | string | number {
-  return featureFlagValues[flagName];
-}
-
-export type DiffResult<CustomDiagnostic> = {|
-  isDifferent: boolean,
-  custom: CustomDiagnostic,
-|};
-
-export type Diagnostic<CustomDiagnostic> = {|
-  isDifferent: boolean,
-  oldExecutionTimeMs: number,
-  newExecutionTimeMs: number,
-  custom: CustomDiagnostic,
-|};
-
-/**
- * Run a function with a consistency check.
- */
-export function runWithConsistencyCheck<Result, CustomDiagnostic>(
-  flag: string,
-  oldFn: () => Result,
-  newFn: () => Result,
-  diffFn: (
-    oldResult: Result,
-    newResult: Result,
-  ) => DiffResult<CustomDiagnostic>,
-  report: (
-    diagnostic: Diagnostic<CustomDiagnostic>,
-    oldResult: Result,
-    newResult: Result,
-  ) => void,
-): Result {
-  const value = featureFlagValues[flag];
-  if (!value || value === false || value === 'OLD') {
-    return oldFn();
-  }
-  if (value === true || value === 'NEW') {
-    return newFn();
-  }
-
-  const oldStartTime = performance.now();
-  const oldResult = oldFn();
-  const oldExecutionTimeMs = performance.now() - oldStartTime;
-
-  const newStartTime = performance.now();
-  const newResult = newFn();
-  const newExecutionTimeMs = performance.now() - newStartTime;
-
-  const diff = diffFn(oldResult, newResult);
-
-  report(
-    {
-      isDifferent: diff.isDifferent,
-      oldExecutionTimeMs,
-      newExecutionTimeMs,
-      custom: diff.custom,
-    },
-    oldResult,
-    newResult,
-  );
-
-  if (value === 'NEW_AND_CHECK') {
-    return newResult;
-  }
-
-  return oldResult;
-}

package/src/types.js

@@ -1,133 +0,0 @@
-// @flow strict
-
-export type FeatureFlags = {|
-  // This feature flag mostly exists to test the feature flag system, and doesn't have any build/runtime effect
-  +exampleFeature: boolean,
-  +exampleConsistencyCheckFeature: ConsistencyCheckFeatureFlagValue,
-  /**
-   * Rust backed requests
-   */
-  +atlaspackV3: boolean,
-  /**
-   * Use node.js implementation of @parcel/watcher watchman backend
-   */
-  +useWatchmanWatcher: boolean,
-  /**
-   * Configure runtime to enable retriable dynamic imports
-   */
-  importRetry: boolean,
-  /**
-   * Fixes quadratic cache invalidation issue
-   */
-  fixQuadraticCacheInvalidation: ConsistencyCheckFeatureFlagValue,
-  /**
-   * Enables an experimental "conditional bundling" API - this allows the use of `importCond` syntax
-   * in order to have (consumer) feature flag driven bundling. This feature is very experimental,
-   * and requires server-side support.
-   */
-  conditionalBundlingApi: boolean,
-  /**
-   * Enable VCS mode. Expected values are:
-   * - OLD - default value, return watchman result
-   * - NEW_AND_CHECK - Return VCS result but still call watchman
-   * - NEW: Return VCS result, but don't call watchman
-   */
-  vcsMode: ConsistencyCheckFeatureFlagValue,
-  /**
-   * Refactor cache to:
-   * - Split writes into multiple entries
-   * - Remove "large file blob" writes
-   * - Reduce size of the caches by deduplicating data
-   */
-  cachePerformanceImprovements: boolean,
-  /**
-   * Deduplicates environments across cache / memory entities
-   */
-  environmentDeduplication: boolean,
-  /**
-   * Enable scanning for the presence of loadable to determine side effects
-   */
-  loadableSideEffects: boolean,
-  /**
-   * Enable performance optimization for the resolver specifier to_string
-   * conversions
-   */
-  reduceResolverStringCreation: boolean,
-  /**
-   * Add verbose metrics for request tracker invalidation
-   */
-  verboseRequestInvalidationStats: boolean,
-  /**
-   * Fixes source maps for inline bundles
-   */
-  inlineBundlesSourceMapFixes: boolean,
-  /** Enable patch project paths. This will patch the project paths to be relative to the project root.
-   * This feature is experimental and should not be used in production. It will used to test downloadble cache artefacts.
-   */
-  patchProjectPaths: boolean,
-  /**
-   * Enables optimized inline string replacement perf for the packager.
-   * Used heavily for inline bundles.
-   */
-  inlineStringReplacementPerf: boolean,
-  /**
-   * Enable resolution of bundler config starting from the CWD
-   */
-  resolveBundlerConfigFromCwd: boolean,
-  /**
-   * Enable a setting that allows for more assets to be scope hoisted, if
-   * they're safe to do so.
-   */
-  applyScopeHoistingImprovement: boolean,
-  /**
-   * Enable a change where a constant module only have the namespacing object added in bundles where it is required
-   */
-  inlineConstOptimisationFix: boolean,
-  /**
-   * Improves/fixes HMR behaviour by:
-   * - Fixing HMR behaviour with lazy bundle edges
-   * - Moving the functionality of the react-refresh runtime into the react-refresh-wrap transformer
-   */
-  hmrImprovements: boolean,
-  /**
-   * Adds an end() method to AtlaspckV3 to cleanly shutdown the NAPI worker pool
-   */
-  atlaspackV3CleanShutdown: boolean,
-  /**
-   * Fixes a bug where imported objects that are accessed with non-static
-   * properties (e.g. `CONSTANTS['api_' + endpoint`]) would not be recognised as
-   * being used, and thus not included in the bundle.
-   */
-  unusedComputedPropertyFix: boolean,
-
-  /**
-   * Fixes an issue where star re-exports of empty files (usually occurring in compiled typescript libraries)
-   * could cause exports to undefined at runtime.
-   */
-  emptyFileStarRexportFix: boolean,
-
-  /**
-   * Enables the new packaging progress CLI experience
-   */
-  cliProgressReportingImprovements: boolean,
-  /**
-   * Enable a change to the conditional bundling loader to use a fallback bundle loading if the expected scripts aren't found
-   *
-   * Split into two flags, to allow usage in the dev or prod packagers separately
-   */
-  condbDevFallbackDev: boolean,
-  condbDevFallbackProd: boolean,
-  /**
-   * Enable the new incremental bundling versioning logic which determines whether
-   * a full bundling pass is required based on the AssetGraph's bundlingVersion.
-   */
-  incrementalBundlingVersioning: boolean,
-|};
-
-declare export var CONSISTENCY_CHECK_VALUES: $ReadOnlyArray<string>;
-export type ConsistencyCheckFeatureFlagValue = $ElementType<
-  typeof CONSISTENCY_CHECK_VALUES,
-  number,
->;
-
-declare export var DEFAULT_FEATURE_FLAGS: FeatureFlags;