@atlaspack/feature-flags 2.16.0 → 2.18.0

package/CHANGELOG.md

@@ -1,5 +1,28 @@
 # @atlaspack/feature-flags
 
+## 2.18.0
+
+### Minor Changes
+
+- [#627](https://github.com/atlassian-labs/atlaspack/pull/627) [`85c52d3`](https://github.com/atlassian-labs/atlaspack/commit/85c52d3f7717b3c84a118d18ab98cfbfd71dcbd2) Thanks [@benjervis](https://github.com/benjervis)! - Adds a feature flag for `applyScopeHoistingImprovement`
+
+### Patch Changes
+
+- [#632](https://github.com/atlassian-labs/atlaspack/pull/632) [`10fbcfb`](https://github.com/atlassian-labs/atlaspack/commit/10fbcfbfa49c7a83da5d7c40983e36e87f524a75) Thanks [@marcins](https://github.com/marcins)! - Added a new feature flag `inlineConstOptimisationFix` which when enabled changes the behaviour for output of constant modules. This fixes two issues with constant modules:
+
+  - Previously constant modules, if they needed a namespace anywhere, would have a namespace everywhere, with this change they only have a namespace in the bundles where needed.
+  - Previously in the case of wrapped assets, a constant module dependnecy of that wrapped asset would be rendered after the module - which meant the minifier would not be able to inline the constants safely. With this flag all constant modules are rendered at the top of the bundle.
+
+## 2.17.0
+
+### Minor Changes
+
+- [#619](https://github.com/atlassian-labs/atlaspack/pull/619) [`73ea3c4`](https://github.com/atlassian-labs/atlaspack/commit/73ea3c4d85d4401fdd15abcbf988237e890e7ad3) Thanks [@matt-koko](https://github.com/matt-koko)! - export `CONSISTENCY_CHECK_VALUES` for consumption in other products
+
+### Patch Changes
+
+- [#623](https://github.com/atlassian-labs/atlaspack/pull/623) [`b1b3693`](https://github.com/atlassian-labs/atlaspack/commit/b1b369317c66f8a431c170df2ebba4fa5b2e38ef) Thanks [@JakeLane](https://github.com/JakeLane)! - Load same conditional bundles as conditional manifest in HTML
+
 ## 2.16.0
 
 ### Minor Changes

package/lib/index.js

@@ -3,13 +3,14 @@
 Object.defineProperty(exports, "__esModule", {
   value: true
 });
-exports.DEFAULT_FEATURE_FLAGS = void 0;
+exports.DEFAULT_FEATURE_FLAGS = exports.CONSISTENCY_CHECK_VALUES = void 0;
 exports.getFeatureFlag = getFeatureFlag;
 exports.getFeatureFlagValue = getFeatureFlagValue;
 exports.runWithConsistencyCheck = runWithConsistencyCheck;
 exports.setFeatureFlags = setFeatureFlags;
 // We need to do these gymnastics as we don't want flow-to-ts to touch DEFAULT_FEATURE_FLAGS,
 // but we want to export FeatureFlags for Flow
+const CONSISTENCY_CHECK_VALUES = exports.CONSISTENCY_CHECK_VALUES = Object.freeze(['NEW', 'OLD', 'NEW_AND_CHECK', 'OLD_AND_CHECK']);
 const DEFAULT_FEATURE_FLAGS = exports.DEFAULT_FEATURE_FLAGS = {
   exampleConsistencyCheckFeature: 'OLD',
   exampleFeature: false,
@@ -26,6 +27,7 @@ const DEFAULT_FEATURE_FLAGS = exports.DEFAULT_FEATURE_FLAGS = {
   conditionalBundlingNestedRuntime: false,
   patchProjectPaths: false,
   cachePerformanceImprovements: process.env.NODE_ENV === 'test',
+  environmentDeduplication: false,
   granularTsConfigInvalidation: false,
   inlineStringReplacementPerf: false,
   conditionalBundlingAsyncRuntime: false,
@@ -33,7 +35,10 @@ const DEFAULT_FEATURE_FLAGS = exports.DEFAULT_FEATURE_FLAGS = {
   verboseRequestInvalidationStats: true,
   conditionalBundlingReporterDuplicateFix: false,
   resolveBundlerConfigFromCwd: false,
-  conditionalBundlingReporterSameConditionFix: false
+  conditionalBundlingReporterSameConditionFix: false,
+  condbHtmlPackagerChange: false,
+  applyScopeHoistingImprovement: false,
+  inlineConstOptimisationFix: false
 };
 let featureFlagValues = {
   ...DEFAULT_FEATURE_FLAGS

package/lib/types.d.ts

@@ -1,3 +1,4 @@
+import { $ElementType } from "utility-types";
 export type FeatureFlags = {
   // This feature flag mostly exists to test the feature flag system, and doesn't have any build/runtime effect
   readonly exampleFeature: boolean;
@@ -56,6 +57,11 @@ export type FeatureFlags = {
    */
   cachePerformanceImprovements: boolean;
 
+  /**
+   * Deduplicates environments across cache / memory entities
+   */
+  environmentDeduplication: boolean;
+
   /**
    * Enable scanning for the presence of loadable to determine side effects
    */
@@ -112,6 +118,23 @@ export type FeatureFlags = {
    * Fix a bug where the conditional manifest reporter would drop bundles that have the same condition
    */
   conditionalBundlingReporterSameConditionFix: boolean;
+
+  /**
+   * Enable a change to the html packager to load more bundles when conditional bundling fallback mode is enabled
+   */
+  condbHtmlPackagerChange: boolean;
+
+  /**
+   * Enable a setting that allows for more assets to be scope hoisted, if
+   * they're safe to do so.
+   */
+  applyScopeHoistingImprovement: boolean;
+
+  /**
+   * Enable a change where a constant module only have the namespacing object added in bundles where it is required
+   */
+  inlineConstOptimisationFix: boolean;
 };
-export type ConsistencyCheckFeatureFlagValue = "NEW" | "OLD" | "NEW_AND_CHECK" | "OLD_AND_CHECK";
+export declare var CONSISTENCY_CHECK_VALUES: ReadonlyArray<string>;
+export type ConsistencyCheckFeatureFlagValue = $ElementType<typeof CONSISTENCY_CHECK_VALUES, number>;
 export declare var DEFAULT_FEATURE_FLAGS: FeatureFlags;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@atlaspack/feature-flags",
-  "version": "2.16.0",
+  "version": "2.18.0",
   "description": "Provides internal feature-flags for the atlaspack codebase.",
   "license": "(MIT OR Apache-2.0)",
   "publishConfig": {

package/src/index.js

@@ -5,6 +5,13 @@ import type {FeatureFlags as _FeatureFlags} from './types';
 // but we want to export FeatureFlags for Flow
 export type FeatureFlags = _FeatureFlags;
 
+export const CONSISTENCY_CHECK_VALUES: $ReadOnlyArray<string> = Object.freeze([
+  'NEW',
+  'OLD',
+  'NEW_AND_CHECK',
+  'OLD_AND_CHECK',
+]);
+
 export const DEFAULT_FEATURE_FLAGS: FeatureFlags = {
   exampleConsistencyCheckFeature: 'OLD',
   exampleFeature: false,
@@ -21,6 +28,7 @@ export const DEFAULT_FEATURE_FLAGS: FeatureFlags = {
   conditionalBundlingNestedRuntime: false,
   patchProjectPaths: false,
   cachePerformanceImprovements: process.env.NODE_ENV === 'test',
+  environmentDeduplication: false,
   granularTsConfigInvalidation: false,
   inlineStringReplacementPerf: false,
   conditionalBundlingAsyncRuntime: false,
@@ -29,6 +37,9 @@ export const DEFAULT_FEATURE_FLAGS: FeatureFlags = {
   conditionalBundlingReporterDuplicateFix: false,
   resolveBundlerConfigFromCwd: false,
   conditionalBundlingReporterSameConditionFix: false,
+  condbHtmlPackagerChange: false,
+  applyScopeHoistingImprovement: false,
+  inlineConstOptimisationFix: false,
 };
 
 let featureFlagValues: FeatureFlags = {...DEFAULT_FEATURE_FLAGS};

package/src/types.js

@@ -48,6 +48,10 @@ export type FeatureFlags = {|
    * - Reduce size of the caches by deduplicating data
    */
   cachePerformanceImprovements: boolean,
+  /**
+   * Deduplicates environments across cache / memory entities
+   */
+  environmentDeduplication: boolean,
   /**
    * Enable scanning for the presence of loadable to determine side effects
    */
@@ -94,12 +98,25 @@ export type FeatureFlags = {|
    * Fix a bug where the conditional manifest reporter would drop bundles that have the same condition
    */
   conditionalBundlingReporterSameConditionFix: boolean,
+  /**
+   * Enable a change to the html packager to load more bundles when conditional bundling fallback mode is enabled
+   */
+  condbHtmlPackagerChange: boolean,
+  /**
+   * Enable a setting that allows for more assets to be scope hoisted, if
+   * they're safe to do so.
+   */
+  applyScopeHoistingImprovement: boolean,
+  /**
+   * Enable a change where a constant module only have the namespacing object added in bundles where it is required
+   */
+  inlineConstOptimisationFix: boolean,
 |};
 
-export type ConsistencyCheckFeatureFlagValue =
-  | 'NEW'
-  | 'OLD'
-  | 'NEW_AND_CHECK'
-  | 'OLD_AND_CHECK';
+declare export var CONSISTENCY_CHECK_VALUES: $ReadOnlyArray<string>;
+export type ConsistencyCheckFeatureFlagValue = $ElementType<
+  typeof CONSISTENCY_CHECK_VALUES,
+  number,
+>;
 
 declare export var DEFAULT_FEATURE_FLAGS: FeatureFlags;