@atlaspack/core 2.38.3 → 2.38.4

package/CHANGELOG.md

@@ -1,5 +1,27 @@
 # @atlaspack/core
 
+## 2.38.4
+
+### Patch Changes
+
+- [#1080](https://github.com/atlassian-labs/atlaspack/pull/1080) [`39b1fdf`](https://github.com/atlassian-labs/atlaspack/commit/39b1fdf59d317a9e862dceba0495dda9f1fda77c) Thanks [@mattcompiles](https://github.com/mattcompiles)! - Fix scope hoisting crash when a module has both `import * as ns from 'x'` and `export * from 'x'` for the same specifier. The wildcard re-export was overwriting the namespace import binding on the shared dependency, causing a ReferenceError in the bundled output. Gated behind `fixExportStarNamespaceOverwrite` feature flag.
+
+- Updated dependencies [[`39b1fdf`](https://github.com/atlassian-labs/atlaspack/commit/39b1fdf59d317a9e862dceba0495dda9f1fda77c)]:
+  - @atlaspack/feature-flags@2.31.2
+  - @atlaspack/rust@3.29.1
+  - @atlaspack/build-cache@2.13.16
+  - @atlaspack/cache@3.2.57
+  - @atlaspack/fs@2.15.57
+  - @atlaspack/graph@3.6.24
+  - @atlaspack/utils@3.4.4
+  - @atlaspack/logger@2.14.54
+  - @atlaspack/source-map@3.3.6
+  - @atlaspack/package-manager@2.14.62
+  - @atlaspack/workers@2.14.62
+  - @atlaspack/plugin@2.14.62
+  - @atlaspack/profiler@2.15.23
+  - @atlaspack/types@2.15.52
+
 ## 2.38.3
 
 ### Patch Changes

package/dist/BundleGraph.js

@@ -199,7 +199,8 @@ class BundleGraph {
                     // Don't retarget because this cannot be resolved without also changing the asset symbols
                     // (and the asset content itself).
                     [...targets].every(([, t]) => new Set([...t.values()]).size === t.size)) {
-                    let isReexportAll = nodeValueSymbols.get('*')?.local === '*';
+                    let isReexportAll = nodeValueSymbols.get('*')?.local === '*' ||
+                        node.value.meta?.hasExportStar;
                     let reexportAllLoc = isReexportAll
                         ? (0, nullthrows_1.default)(nodeValueSymbols.get('*')).loc
                         : undefined;
@@ -1565,7 +1566,7 @@ class BundleGraph {
             // Default exports are excluded from wildcard exports.
             // Wildcard reexports are never listed in the reexporting asset's symbols.
             if (identifier == null &&
-                depSymbols.get('*')?.local === '*' &&
+                (depSymbols.get('*')?.local === '*' || dep.meta?.hasExportStar) &&
                 symbol !== 'default') {
                 let resolved = this.getResolvedAsset(dep, boundary);
                 if (!resolved) {
@@ -1694,7 +1695,7 @@ class BundleGraph {
             let depSymbols = dep.symbols;
             if (!depSymbols)
                 continue;
-            if (depSymbols.get('*')?.local === '*') {
+            if (depSymbols.get('*')?.local === '*' || dep.meta?.hasExportStar) {
                 let resolved = this.getResolvedAsset(dep, boundary);
                 if (!resolved)
                     continue;

package/dist/SymbolPropagation.js

@@ -49,7 +49,8 @@ function propagateSymbols({ options, assetGraph, changedAssetsPropagation, asset
                     set.add(s);
                 }
             }
-            let hasNamespaceOutgoingDeps = outgoingDeps.some((d) => d.value.symbols?.get('*')?.local === '*');
+            let hasNamespaceOutgoingDeps = outgoingDeps.some((d) => d.value.symbols?.get('*')?.local === '*' ||
+                d.value.meta?.hasExportStar);
             // 1) Determine what the incomingDeps requests from the asset
             // ----------------------------------------------------------
             let isEntry = false;
@@ -124,7 +125,8 @@ function propagateSymbols({ options, assetGraph, changedAssetsPropagation, asset
                     let depSymbols = dep.value.symbols;
                     if (!depSymbols)
                         continue;
-                    if (depSymbols.get('*')?.local === '*') {
+                    if (depSymbols.get('*')?.local === '*' ||
+                        dep.value.meta?.hasExportStar) {
                         if (addAll) {
                             depUsedSymbolsDown.add('*');
                         }
@@ -220,7 +222,8 @@ function propagateSymbols({ options, assetGraph, changedAssetsPropagation, asset
                 if (isExcluded) {
                     outgoingDep.usedSymbolsDown.forEach((_, s) => outgoingDep.usedSymbolsUp.set(s, null));
                 }
-                if (outgoingDepSymbols.get('*')?.local === '*') {
+                if (outgoingDepSymbols.get('*')?.local === '*' ||
+                    outgoingDep.value.meta?.hasExportStar) {
                     outgoingDep.usedSymbolsUp.forEach((sResolved, s) => {
                         if (s === 'default') {
                             return;
@@ -289,7 +292,8 @@ function propagateSymbols({ options, assetGraph, changedAssetsPropagation, asset
                 let incomingDepSymbols = incomingDep.value.symbols;
                 if (!incomingDepSymbols)
                     continue;
-                let hasNamespaceReexport = incomingDepSymbols.get('*')?.local === '*';
+                let hasNamespaceReexport = incomingDepSymbols.get('*')?.local === '*' ||
+                    incomingDep.value.meta?.hasExportStar;
                 for (let s of incomingDep.usedSymbolsDown) {
                     if (assetSymbols == null || // Assume everything could be provided if symbols are cleared
                         assetNode.value.bundleBehavior === types_1.BundleBehavior.isolated ||

package/lib/BundleGraph.js

@@ -257,8 +257,8 @@ class BundleGraph {
         // Don't retarget because this cannot be resolved without also changing the asset symbols
         // (and the asset content itself).
         [...targets].every(([, t]) => new Set([...t.values()]).size === t.size)) {
-          var _nodeValueSymbols$get;
-          let isReexportAll = ((_nodeValueSymbols$get = nodeValueSymbols.get('*')) === null || _nodeValueSymbols$get === void 0 ? void 0 : _nodeValueSymbols$get.local) === '*';
+          var _nodeValueSymbols$get, _node$value$meta;
+          let isReexportAll = ((_nodeValueSymbols$get = nodeValueSymbols.get('*')) === null || _nodeValueSymbols$get === void 0 ? void 0 : _nodeValueSymbols$get.local) === '*' || ((_node$value$meta = node.value.meta) === null || _node$value$meta === void 0 ? void 0 : _node$value$meta.hasExportStar);
           let reexportAllLoc = isReexportAll ? (0, _nullthrows().default)(nodeValueSymbols.get('*')).loc : undefined;
 
           // TODO adjust sourceAssetIdNode.value.dependencies ?
@@ -1503,7 +1503,7 @@ class BundleGraph {
     let deps = this.getDependencies(asset).reverse();
     let potentialResults = [];
     for (let dep of deps) {
-      var _depSymbols$get;
+      var _depSymbols$get, _dep$meta2;
       let depSymbols = dep.symbols;
       if (!depSymbols) {
         nonStaticDependency = true;
@@ -1555,7 +1555,7 @@ class BundleGraph {
       // If this module exports wildcards, resolve the original module.
       // Default exports are excluded from wildcard exports.
       // Wildcard reexports are never listed in the reexporting asset's symbols.
-      if (identifier == null && ((_depSymbols$get = depSymbols.get('*')) === null || _depSymbols$get === void 0 ? void 0 : _depSymbols$get.local) === '*' && symbol !== 'default') {
+      if (identifier == null && (((_depSymbols$get = depSymbols.get('*')) === null || _depSymbols$get === void 0 ? void 0 : _depSymbols$get.local) === '*' || (_dep$meta2 = dep.meta) !== null && _dep$meta2 !== void 0 && _dep$meta2.hasExportStar) && symbol !== 'default') {
         let resolved = this.getResolvedAsset(dep, boundary);
         if (!resolved) {
           continue;
@@ -1681,10 +1681,10 @@ class BundleGraph {
     }
     let deps = this.getDependencies(asset);
     for (let dep of deps) {
-      var _depSymbols$get2;
+      var _depSymbols$get2, _dep$meta3;
       let depSymbols = dep.symbols;
       if (!depSymbols) continue;
-      if (((_depSymbols$get2 = depSymbols.get('*')) === null || _depSymbols$get2 === void 0 ? void 0 : _depSymbols$get2.local) === '*') {
+      if (((_depSymbols$get2 = depSymbols.get('*')) === null || _depSymbols$get2 === void 0 ? void 0 : _depSymbols$get2.local) === '*' || (_dep$meta3 = dep.meta) !== null && _dep$meta3 !== void 0 && _dep$meta3.hasExportStar) {
         let resolved = this.getResolvedAsset(dep, boundary);
         if (!resolved) continue;
         let exported = this.getExportedSymbols(resolved, boundary).filter(s => s.exportSymbol !== 'default').map(s => s.exportSymbol !== '*' ? {

package/lib/SymbolPropagation.js

@@ -94,8 +94,8 @@ function propagateSymbols({
         }
       }
       let hasNamespaceOutgoingDeps = outgoingDeps.some(d => {
-        var _d$value$symbols;
-        return ((_d$value$symbols = d.value.symbols) === null || _d$value$symbols === void 0 || (_d$value$symbols = _d$value$symbols.get('*')) === null || _d$value$symbols === void 0 ? void 0 : _d$value$symbols.local) === '*';
+        var _d$value$symbols, _d$value$meta;
+        return ((_d$value$symbols = d.value.symbols) === null || _d$value$symbols === void 0 || (_d$value$symbols = _d$value$symbols.get('*')) === null || _d$value$symbols === void 0 ? void 0 : _d$value$symbols.local) === '*' || ((_d$value$meta = d.value.meta) === null || _d$value$meta === void 0 ? void 0 : _d$value$meta.hasExportStar);
       });
 
       // 1) Determine what the incomingDeps requests from the asset
@@ -168,10 +168,10 @@ function propagateSymbols({
         //    lib/index.js: `export * from "./foo.js"; export * from "./bar.js";`
         //    lib/foo.js:   `import { data } from "./bar.js"; export const foo = data + " esm2";`
         assetNode.usedSymbols.size > 0 || namespaceReexportedSymbols.size > 0) {
-          var _depSymbols$get;
+          var _depSymbols$get, _dep$value$meta;
           let depSymbols = dep.value.symbols;
           if (!depSymbols) continue;
-          if (((_depSymbols$get = depSymbols.get('*')) === null || _depSymbols$get === void 0 ? void 0 : _depSymbols$get.local) === '*') {
+          if (((_depSymbols$get = depSymbols.get('*')) === null || _depSymbols$get === void 0 ? void 0 : _depSymbols$get.local) === '*' || (_dep$value$meta = dep.value.meta) !== null && _dep$value$meta !== void 0 && _dep$value$meta.hasExportStar) {
             if (addAll) {
               depUsedSymbolsDown.add('*');
             } else {
@@ -258,7 +258,7 @@ function propagateSymbols({
       // analyzable exports
       let reexportedSymbolsSource = new Map();
       for (let outgoingDep of outgoingDeps) {
-        var _outgoingDepSymbols$g;
+        var _outgoingDepSymbols$g, _outgoingDep$value$me;
         let outgoingDepSymbols = outgoingDep.value.symbols;
         if (!outgoingDepSymbols) continue;
         let isExcluded = assetGraph.getNodeIdsConnectedFrom(assetGraph.getNodeIdByContentKey(outgoingDep.id)).length === 0;
@@ -266,7 +266,7 @@ function propagateSymbols({
         if (isExcluded) {
           outgoingDep.usedSymbolsDown.forEach((_, s) => outgoingDep.usedSymbolsUp.set(s, null));
         }
-        if (((_outgoingDepSymbols$g = outgoingDepSymbols.get('*')) === null || _outgoingDepSymbols$g === void 0 ? void 0 : _outgoingDepSymbols$g.local) === '*') {
+        if (((_outgoingDepSymbols$g = outgoingDepSymbols.get('*')) === null || _outgoingDepSymbols$g === void 0 ? void 0 : _outgoingDepSymbols$g.local) === '*' || (_outgoingDep$value$me = outgoingDep.value.meta) !== null && _outgoingDep$value$me !== void 0 && _outgoingDep$value$me.hasExportStar) {
           outgoingDep.usedSymbolsUp.forEach((sResolved, s) => {
             if (s === 'default') {
               return;
@@ -334,12 +334,12 @@ function propagateSymbols({
         current.set(s, value);
       }
       for (let incomingDep of incomingDeps) {
-        var _incomingDepSymbols$g;
+        var _incomingDepSymbols$g, _incomingDep$value$me;
         let incomingDepUsedSymbolsUpOld = incomingDep.usedSymbolsUp;
         incomingDep.usedSymbolsUp = new Map();
         let incomingDepSymbols = incomingDep.value.symbols;
         if (!incomingDepSymbols) continue;
-        let hasNamespaceReexport = ((_incomingDepSymbols$g = incomingDepSymbols.get('*')) === null || _incomingDepSymbols$g === void 0 ? void 0 : _incomingDepSymbols$g.local) === '*';
+        let hasNamespaceReexport = ((_incomingDepSymbols$g = incomingDepSymbols.get('*')) === null || _incomingDepSymbols$g === void 0 ? void 0 : _incomingDepSymbols$g.local) === '*' || ((_incomingDep$value$me = incomingDep.value.meta) === null || _incomingDep$value$me === void 0 ? void 0 : _incomingDep$value$me.hasExportStar);
         for (let s of incomingDep.usedSymbolsDown) {
           if (assetSymbols == null ||
           // Assume everything could be provided if symbols are cleared

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@atlaspack/core",
-  "version": "2.38.3",
+  "version": "2.38.4",
   "license": "(MIT OR Apache-2.0)",
   "publishConfig": {
     "access": "public"
@@ -23,22 +23,22 @@
   },
   "dependencies": {
     "@mischnic/json-sourcemap": "^0.1.0",
-    "@atlaspack/build-cache": "2.13.15",
-    "@atlaspack/cache": "3.2.56",
+    "@atlaspack/build-cache": "2.13.16",
+    "@atlaspack/cache": "3.2.57",
     "@atlaspack/diagnostic": "2.14.4",
     "@atlaspack/events": "2.14.4",
-    "@atlaspack/feature-flags": "2.31.1",
-    "@atlaspack/fs": "2.15.56",
-    "@atlaspack/graph": "3.6.23",
-    "@atlaspack/logger": "2.14.53",
-    "@atlaspack/package-manager": "2.14.61",
-    "@atlaspack/plugin": "2.14.61",
-    "@atlaspack/profiler": "2.15.22",
-    "@atlaspack/rust": "3.29.0",
-    "@atlaspack/types": "2.15.51",
-    "@atlaspack/utils": "3.4.3",
-    "@atlaspack/workers": "2.14.61",
-    "@atlaspack/source-map": "3.3.5",
+    "@atlaspack/feature-flags": "2.31.2",
+    "@atlaspack/fs": "2.15.57",
+    "@atlaspack/graph": "3.6.24",
+    "@atlaspack/logger": "2.14.54",
+    "@atlaspack/package-manager": "2.14.62",
+    "@atlaspack/plugin": "2.14.62",
+    "@atlaspack/profiler": "2.15.23",
+    "@atlaspack/rust": "3.29.1",
+    "@atlaspack/types": "2.15.52",
+    "@atlaspack/utils": "3.4.4",
+    "@atlaspack/workers": "2.14.62",
+    "@atlaspack/source-map": "3.3.6",
     "base-x": "^3.0.8",
     "browserslist": "^4.6.6",
     "clone": "^2.1.1",

package/src/BundleGraph.ts

@@ -335,7 +335,9 @@ export default class BundleGraph {
             ([, t]: [any, any]) => new Set([...t.values()]).size === t.size,
           )
         ) {
-          let isReexportAll = nodeValueSymbols.get('*')?.local === '*';
+          let isReexportAll =
+            nodeValueSymbols.get('*')?.local === '*' ||
+            node.value.meta?.hasExportStar;
           let reexportAllLoc = isReexportAll
             ? nullthrows(nodeValueSymbols.get('*')).loc
             : undefined;
@@ -2317,7 +2319,7 @@ export default class BundleGraph {
       // Wildcard reexports are never listed in the reexporting asset's symbols.
       if (
         identifier == null &&
-        depSymbols.get('*')?.local === '*' &&
+        (depSymbols.get('*')?.local === '*' || dep.meta?.hasExportStar) &&
         symbol !== 'default'
       ) {
         let resolved = this.getResolvedAsset(dep, boundary);
@@ -2455,7 +2457,7 @@ export default class BundleGraph {
       let depSymbols = dep.symbols;
       if (!depSymbols) continue;
 
-      if (depSymbols.get('*')?.local === '*') {
+      if (depSymbols.get('*')?.local === '*' || dep.meta?.hasExportStar) {
         let resolved = this.getResolvedAsset(dep, boundary);
         if (!resolved) continue;
         let exported = this.getExportedSymbols(resolved, boundary)

package/src/SymbolPropagation.ts

@@ -1,7 +1,6 @@
 import type {ContentKey, NodeId} from '@atlaspack/graph';
 import type {Meta, Symbol} from '@atlaspack/types';
 import type {Diagnostic} from '@atlaspack/diagnostic';
-import {getFeatureFlag} from '@atlaspack/feature-flags';
 import type {
   AssetNode,
   DependencyNode,
@@ -95,7 +94,9 @@ export function propagateSymbols({
           }
         }
         let hasNamespaceOutgoingDeps = outgoingDeps.some(
-          (d) => d.value.symbols?.get('*')?.local === '*',
+          (d) =>
+            d.value.symbols?.get('*')?.local === '*' ||
+            d.value.meta?.hasExportStar,
         );
 
         // 1) Determine what the incomingDeps requests from the asset
@@ -192,7 +193,10 @@ export function propagateSymbols({
             let depSymbols = dep.value.symbols;
             if (!depSymbols) continue;
 
-            if (depSymbols.get('*')?.local === '*') {
+            if (
+              depSymbols.get('*')?.local === '*' ||
+              dep.value.meta?.hasExportStar
+            ) {
               if (addAll) {
                 depUsedSymbolsDown.add('*');
               } else {
@@ -335,7 +339,10 @@ export function propagateSymbols({
             );
           }
 
-          if (outgoingDepSymbols.get('*')?.local === '*') {
+          if (
+            outgoingDepSymbols.get('*')?.local === '*' ||
+            outgoingDep.value.meta?.hasExportStar
+          ) {
             outgoingDep.usedSymbolsUp.forEach((sResolved, s) => {
               if (s === 'default') {
                 return;
@@ -453,7 +460,9 @@ export function propagateSymbols({
           let incomingDepSymbols = incomingDep.value.symbols;
           if (!incomingDepSymbols) continue;
 
-          let hasNamespaceReexport = incomingDepSymbols.get('*')?.local === '*';
+          let hasNamespaceReexport =
+            incomingDepSymbols.get('*')?.local === '*' ||
+            incomingDep.value.meta?.hasExportStar;
           for (let s of incomingDep.usedSymbolsDown) {
             if (
               assetSymbols == null || // Assume everything could be provided if symbols are cleared