@atlaspack/core 2.38.3-dev-862af7d26.0 → 2.38.4

package/CHANGELOG.md

@@ -1,5 +1,51 @@
 # @atlaspack/core
 
+## 2.38.4
+
+### Patch Changes
+
+- [#1080](https://github.com/atlassian-labs/atlaspack/pull/1080) [`39b1fdf`](https://github.com/atlassian-labs/atlaspack/commit/39b1fdf59d317a9e862dceba0495dda9f1fda77c) Thanks [@mattcompiles](https://github.com/mattcompiles)! - Fix scope hoisting crash when a module has both `import * as ns from 'x'` and `export * from 'x'` for the same specifier. The wildcard re-export was overwriting the namespace import binding on the shared dependency, causing a ReferenceError in the bundled output. Gated behind `fixExportStarNamespaceOverwrite` feature flag.
+
+- Updated dependencies [[`39b1fdf`](https://github.com/atlassian-labs/atlaspack/commit/39b1fdf59d317a9e862dceba0495dda9f1fda77c)]:
+  - @atlaspack/feature-flags@2.31.2
+  - @atlaspack/rust@3.29.1
+  - @atlaspack/build-cache@2.13.16
+  - @atlaspack/cache@3.2.57
+  - @atlaspack/fs@2.15.57
+  - @atlaspack/graph@3.6.24
+  - @atlaspack/utils@3.4.4
+  - @atlaspack/logger@2.14.54
+  - @atlaspack/source-map@3.3.6
+  - @atlaspack/package-manager@2.14.62
+  - @atlaspack/workers@2.14.62
+  - @atlaspack/plugin@2.14.62
+  - @atlaspack/profiler@2.15.23
+  - @atlaspack/types@2.15.52
+
+## 2.38.3
+
+### Patch Changes
+
+- [#1065](https://github.com/atlassian-labs/atlaspack/pull/1065) [`e898fda`](https://github.com/atlassian-labs/atlaspack/commit/e898fda7511d98e5597d847c4a32c028a8a24d6c) Thanks [@at-nathan](https://github.com/at-nathan)! - Update third-party dependencies to align with AFM
+
+- [#1073](https://github.com/atlassian-labs/atlaspack/pull/1073) [`3ff901a`](https://github.com/atlassian-labs/atlaspack/commit/3ff901a222d5e077a3bb96031a89c3b5173ece69) Thanks [@matt-koko](https://github.com/matt-koko)! - Improve Rust/JS asset graph interop for atlaspack v3 by reducing scenarios where Rust/JS can diverge their respective previous asset graphs.
+
+- Updated dependencies [[`07edc83`](https://github.com/atlassian-labs/atlaspack/commit/07edc83079f6a752b09b28a9fe8b45f6523f0f81), [`e898fda`](https://github.com/atlassian-labs/atlaspack/commit/e898fda7511d98e5597d847c4a32c028a8a24d6c), [`3ff901a`](https://github.com/atlassian-labs/atlaspack/commit/3ff901a222d5e077a3bb96031a89c3b5173ece69), [`e8fe5c0`](https://github.com/atlassian-labs/atlaspack/commit/e8fe5c0070f0d92d68f98902edcc96dc82c1e52d), [`ff7e3f0`](https://github.com/atlassian-labs/atlaspack/commit/ff7e3f08c3977b0d9b9edfe739a8e596abbdd729), [`508e15c`](https://github.com/atlassian-labs/atlaspack/commit/508e15c7acd187703bade4d613ca7f5739ae3af7), [`34c7cec`](https://github.com/atlassian-labs/atlaspack/commit/34c7cecebae240f11f36971b4eeaeaaf579531c9), [`5256d37`](https://github.com/atlassian-labs/atlaspack/commit/5256d37a88334554ae78456622389c97f66a2196)]:
+  - @atlaspack/rust@3.29.0
+  - @atlaspack/cache@3.2.56
+  - @atlaspack/utils@3.4.3
+  - @atlaspack/feature-flags@2.31.1
+  - @atlaspack/fs@2.15.56
+  - @atlaspack/logger@2.14.53
+  - @atlaspack/source-map@3.3.5
+  - @atlaspack/package-manager@2.14.61
+  - @atlaspack/profiler@2.15.22
+  - @atlaspack/workers@2.14.61
+  - @atlaspack/build-cache@2.13.15
+  - @atlaspack/graph@3.6.23
+  - @atlaspack/types@2.15.51
+  - @atlaspack/plugin@2.14.61
+
 ## 2.38.2
 
 ### Patch Changes

package/dist/BundleGraph.js

@@ -199,7 +199,8 @@ class BundleGraph {
                     // Don't retarget because this cannot be resolved without also changing the asset symbols
                     // (and the asset content itself).
                     [...targets].every(([, t]) => new Set([...t.values()]).size === t.size)) {
-                    let isReexportAll = nodeValueSymbols.get('*')?.local === '*';
+                    let isReexportAll = nodeValueSymbols.get('*')?.local === '*' ||
+                        node.value.meta?.hasExportStar;
                     let reexportAllLoc = isReexportAll
                         ? (0, nullthrows_1.default)(nodeValueSymbols.get('*')).loc
                         : undefined;
@@ -1565,7 +1566,7 @@ class BundleGraph {
             // Default exports are excluded from wildcard exports.
             // Wildcard reexports are never listed in the reexporting asset's symbols.
             if (identifier == null &&
-                depSymbols.get('*')?.local === '*' &&
+                (depSymbols.get('*')?.local === '*' || dep.meta?.hasExportStar) &&
                 symbol !== 'default') {
                 let resolved = this.getResolvedAsset(dep, boundary);
                 if (!resolved) {
@@ -1694,7 +1695,7 @@ class BundleGraph {
             let depSymbols = dep.symbols;
             if (!depSymbols)
                 continue;
-            if (depSymbols.get('*')?.local === '*') {
+            if (depSymbols.get('*')?.local === '*' || dep.meta?.hasExportStar) {
                 let resolved = this.getResolvedAsset(dep, boundary);
                 if (!resolved)
                     continue;

package/dist/SymbolPropagation.js

@@ -49,7 +49,8 @@ function propagateSymbols({ options, assetGraph, changedAssetsPropagation, asset
                     set.add(s);
                 }
             }
-            let hasNamespaceOutgoingDeps = outgoingDeps.some((d) => d.value.symbols?.get('*')?.local === '*');
+            let hasNamespaceOutgoingDeps = outgoingDeps.some((d) => d.value.symbols?.get('*')?.local === '*' ||
+                d.value.meta?.hasExportStar);
             // 1) Determine what the incomingDeps requests from the asset
             // ----------------------------------------------------------
             let isEntry = false;
@@ -124,7 +125,8 @@ function propagateSymbols({ options, assetGraph, changedAssetsPropagation, asset
                     let depSymbols = dep.value.symbols;
                     if (!depSymbols)
                         continue;
-                    if (depSymbols.get('*')?.local === '*') {
+                    if (depSymbols.get('*')?.local === '*' ||
+                        dep.value.meta?.hasExportStar) {
                         if (addAll) {
                             depUsedSymbolsDown.add('*');
                         }
@@ -220,7 +222,8 @@ function propagateSymbols({ options, assetGraph, changedAssetsPropagation, asset
                 if (isExcluded) {
                     outgoingDep.usedSymbolsDown.forEach((_, s) => outgoingDep.usedSymbolsUp.set(s, null));
                 }
-                if (outgoingDepSymbols.get('*')?.local === '*') {
+                if (outgoingDepSymbols.get('*')?.local === '*' ||
+                    outgoingDep.value.meta?.hasExportStar) {
                     outgoingDep.usedSymbolsUp.forEach((sResolved, s) => {
                         if (s === 'default') {
                             return;
@@ -289,7 +292,8 @@ function propagateSymbols({ options, assetGraph, changedAssetsPropagation, asset
                 let incomingDepSymbols = incomingDep.value.symbols;
                 if (!incomingDepSymbols)
                     continue;
-                let hasNamespaceReexport = incomingDepSymbols.get('*')?.local === '*';
+                let hasNamespaceReexport = incomingDepSymbols.get('*')?.local === '*' ||
+                    incomingDep.value.meta?.hasExportStar;
                 for (let s of incomingDep.usedSymbolsDown) {
                     if (assetSymbols == null || // Assume everything could be provided if symbols are cleared
                         assetNode.value.bundleBehavior === types_1.BundleBehavior.isolated ||

package/dist/requests/AssetGraphRequestRust.js

@@ -74,30 +74,6 @@ function createAssetGraphRequestRust(rustAtlaspack) {
             }
             let { assetGraph, changedAssets } = (0, logger_1.instrument)('atlaspack_v3_getAssetGraph', () => getAssetGraph(serializedAssetGraph, prevResult?.assetGraph));
             let changedAssetsPropagation = new Set(changedAssets.keys());
-            // Skip symbol propagation for runtime assets - they have pre-computed symbol data
-            if (input.skipSymbolProp) {
-                logger_1.default.verbose({
-                    origin: '@atlaspack/core',
-                    message: 'Skipping symbol propagation for runtime asset graph',
-                });
-            }
-            else {
-                let errors = (0, SymbolPropagation_1.propagateSymbols)({
-                    options,
-                    assetGraph,
-                    changedAssetsPropagation,
-                    assetGroupsWithRemovedParents: new Set(),
-                    previousErrors: new Map(), //this.previousSymbolPropagationErrors,
-                });
-                if (errors.size > 0) {
-                    // Just throw the first error. Since errors can bubble (e.g. reexporting a reexported symbol also fails),
-                    // determining which failing export is the root cause is nontrivial (because of circular dependencies).
-                    throw new diagnostic_1.default({
-                        diagnostic: [...errors.values()][0],
-                    });
-                }
-            }
-            await (0, dumpGraphToGraphViz_1.default)(assetGraph, 'AssetGraphV3');
             let result = {
                 assetGraph,
                 assetRequests: [],
@@ -106,16 +82,56 @@ function createAssetGraphRequestRust(rustAtlaspack) {
                 changedAssetsPropagation,
                 previousSymbolPropagationErrors: undefined,
             };
-            let [_commitResult, commitError] = await commitPromise;
-            if (commitError) {
-                throw new diagnostic_1.default({
-                    diagnostic: {
-                        message: 'Error committing asset graph in Rust: ' + commitError.message,
-                    },
-                });
+            // When v3AssetGraphSyncImprovements is enabled, wrap downstream steps
+            // in try/catch and store the result even on error. This prevents Rust/JS
+            // divergence when symbol propagation or commit_assets fails.
+            let storeResultOnError = (0, feature_flags_1.getFeatureFlag)('v3AssetGraphSyncImprovements');
+            try {
+                // Skip symbol propagation for runtime assets - they have pre-computed symbol data
+                if (input.skipSymbolProp) {
+                    logger_1.default.verbose({
+                        origin: '@atlaspack/core',
+                        message: 'Skipping symbol propagation for runtime asset graph',
+                    });
+                }
+                else {
+                    let errors = (0, SymbolPropagation_1.propagateSymbols)({
+                        options,
+                        assetGraph,
+                        changedAssetsPropagation,
+                        assetGroupsWithRemovedParents: new Set(),
+                        previousErrors: new Map(), //this.previousSymbolPropagationErrors,
+                    });
+                    if (errors.size > 0) {
+                        // Just throw the first error. Since errors can bubble (e.g. reexporting a reexported symbol also fails),
+                        // determining which failing export is the root cause is nontrivial (because of circular dependencies).
+                        throw new diagnostic_1.default({
+                            diagnostic: [...errors.values()][0],
+                        });
+                    }
+                }
+                await (0, dumpGraphToGraphViz_1.default)(assetGraph, 'AssetGraphV3');
+                let [_commitResult, commitError] = await commitPromise;
+                if (commitError) {
+                    throw new diagnostic_1.default({
+                        diagnostic: {
+                            message: 'Error committing asset graph in Rust: ' + commitError.message,
+                        },
+                    });
+                }
+                await runInput.api.storeResult(result);
+                runInput.api.invalidateOnBuild();
+            }
+            catch (e) {
+                if (storeResultOnError) {
+                    // Store the graph even on error to prevent Rust/JS divergence.
+                    // The graph from getAssetGraph is structurally correct — only
+                    // downstream processing (symbols, commit) failed.
+                    await runInput.api.storeResult(result);
+                    runInput.api.invalidateOnBuild();
+                }
+                throw e;
             }
-            await runInput.api.storeResult(result);
-            runInput.api.invalidateOnBuild();
             return result;
         },
         input,
@@ -124,27 +140,52 @@ function createAssetGraphRequestRust(rustAtlaspack) {
 function getAssetGraph(serializedGraph, prevAssetGraph) {
     let graph;
     let reuseEdges = false;
+    let clonePrevGraph = (0, feature_flags_1.getFeatureFlag)('v3AssetGraphSyncImprovements');
     if (prevAssetGraph && serializedGraph.safeToSkipBundling) {
-        graph = new AssetGraph_1.default({
-            _contentKeyToNodeId: prevAssetGraph._contentKeyToNodeId,
-            _nodeIdToContentKey: prevAssetGraph._nodeIdToContentKey,
-            nodes: prevAssetGraph.nodes,
-            rootNodeId: prevAssetGraph.rootNodeId,
-            adjacencyList: prevAssetGraph.adjacencyList,
-        });
+        if (clonePrevGraph) {
+            graph = new AssetGraph_1.default({
+                _contentKeyToNodeId: new Map(prevAssetGraph._contentKeyToNodeId),
+                _nodeIdToContentKey: new Map(prevAssetGraph._nodeIdToContentKey),
+                nodes: [...prevAssetGraph.nodes],
+                rootNodeId: prevAssetGraph.rootNodeId,
+                adjacencyList: prevAssetGraph.adjacencyList,
+            });
+        }
+        else {
+            graph = new AssetGraph_1.default({
+                _contentKeyToNodeId: prevAssetGraph._contentKeyToNodeId,
+                _nodeIdToContentKey: prevAssetGraph._nodeIdToContentKey,
+                nodes: prevAssetGraph.nodes,
+                rootNodeId: prevAssetGraph.rootNodeId,
+                adjacencyList: prevAssetGraph.adjacencyList,
+            });
+        }
         reuseEdges = true;
     }
     else if (prevAssetGraph &&
         (serializedGraph.updates.length > 0 || serializedGraph.nodes.length > 0)) {
-        graph = new AssetGraph_1.default({
-            _contentKeyToNodeId: prevAssetGraph._contentKeyToNodeId,
-            _nodeIdToContentKey: prevAssetGraph._nodeIdToContentKey,
-            nodes: prevAssetGraph.nodes,
-            initialCapacity: serializedGraph.edges.length,
-            // Accomodate the root node
-            initialNodeCapacity: prevAssetGraph.nodes.length + 1,
-            rootNodeId: prevAssetGraph.rootNodeId,
-        });
+        if (clonePrevGraph) {
+            graph = new AssetGraph_1.default({
+                _contentKeyToNodeId: new Map(prevAssetGraph._contentKeyToNodeId),
+                _nodeIdToContentKey: new Map(prevAssetGraph._nodeIdToContentKey),
+                nodes: [...prevAssetGraph.nodes],
+                initialCapacity: serializedGraph.edges.length,
+                // Accomodate the root node
+                initialNodeCapacity: prevAssetGraph.nodes.length + 1,
+                rootNodeId: prevAssetGraph.rootNodeId,
+            });
+        }
+        else {
+            graph = new AssetGraph_1.default({
+                _contentKeyToNodeId: prevAssetGraph._contentKeyToNodeId,
+                _nodeIdToContentKey: prevAssetGraph._nodeIdToContentKey,
+                nodes: prevAssetGraph.nodes,
+                initialCapacity: serializedGraph.edges.length,
+                // Accomodate the root node
+                initialNodeCapacity: prevAssetGraph.nodes.length + 1,
+                rootNodeId: prevAssetGraph.rootNodeId,
+            });
+        }
         graph.safeToIncrementallyBundle = false;
     }
     else {
@@ -228,36 +269,92 @@ function getAssetGraph(serializedGraph, prevAssetGraph) {
         }
         return base;
     }
+    function buildDivergenceDiagnostics(divergenceType, newNode, existingNode, index) {
+        return {
+            contentKey: newNode.id,
+            divergenceType,
+            newNode: describeNode(newNode),
+            existingNode: existingNode ? describeNode(existingNode) : null,
+            iterationIndex: index,
+            totalSerializedNodes: nodesCount,
+            newNodesCount: serializedGraph.nodes.length,
+            updatesCount: serializedGraph.updates.length,
+            edgesCount: serializedGraph.edges.length,
+            hadPreviousGraph: !!prevAssetGraph,
+            safeToSkipBundling: serializedGraph.safeToSkipBundling,
+            graphNodeCount: graph._contentKeyToNodeId.size,
+        };
+    }
     function updateNode(newNode, isUpdateNode, index) {
+        let healDivergence = (0, feature_flags_1.getFeatureFlag)('v3AssetGraphSyncImprovements');
         if (isUpdateNode) {
             let existingNode = graph.getNodeByContentKey(newNode.id);
-            (0, assert_2.default)(existingNode && existingNode.type === newNode.type);
-            Object.assign(existingNode, newNode);
+            if (healDivergence) {
+                if (existingNode) {
+                    (0, assert_2.default)(existingNode.type === newNode.type);
+                    Object.assign(existingNode, newNode);
+                }
+                else {
+                    // Rust sent an update for a node JS doesn't have.
+                    // This means JS's graph is stale. Add the node as new instead.
+                    // This handles the "undefined == true" error class.
+                    let diagnostics = buildDivergenceDiagnostics('update_node_not_found', newNode, existingNode, index);
+                    logger_1.default.warn({
+                        origin: '@atlaspack/core',
+                        message: `Rust/JS asset graph divergence healed: update node not found, ` +
+                            `adding as new. contentKey=${newNode.id} type=${newNode.type} iterationIndex=${index}`,
+                        meta: {
+                            trackableEvent: 'asset_graph_divergence_healed',
+                            ...diagnostics,
+                        },
+                    });
+                    graph.addNodeByContentKey(newNode.id, newNode);
+                }
+            }
+            else {
+                (0, assert_2.default)(existingNode && existingNode.type === newNode.type);
+                Object.assign(existingNode, newNode);
+            }
         }
         else {
-            try {
-                graph.addNodeByContentKey(newNode.id, newNode);
-            }
-            catch (e) {
-                if (e instanceof Error &&
-                    e.message.includes('already has content key')) {
+            if (healDivergence) {
+                if (graph.hasContentKey(newNode.id)) {
+                    // Rust sent a "new" node that JS already has.
+                    // This means JS's graph has nodes that Rust considers new.
+                    // Treat as an update instead of throwing.
+                    // This handles the "Graph already has content key" error class.
                     let existingNode = graph.getNodeByContentKey(newNode.id);
-                    let diagnostics = {
-                        contentKey: newNode.id,
-                        newNode: describeNode(newNode),
-                        existingNode: existingNode ? describeNode(existingNode) : null,
-                        iterationIndex: index,
-                        totalSerializedNodes: nodesCount,
-                        newNodesCount: serializedGraph.nodes.length,
-                        updatesCount: serializedGraph.updates.length,
-                        edgesCount: serializedGraph.edges.length,
-                        hadPreviousGraph: !!prevAssetGraph,
-                        safeToSkipBundling: serializedGraph.safeToSkipBundling,
-                        graphNodeCount: graph._contentKeyToNodeId.size,
-                    };
-                    throw new Error(`Graph already has content key '${newNode.id}'. Diagnostics: ${JSON.stringify(diagnostics, null, 2)}`);
+                    let diagnostics = buildDivergenceDiagnostics('new_node_already_exists', newNode, existingNode, index);
+                    logger_1.default.warn({
+                        origin: '@atlaspack/core',
+                        message: `Rust/JS asset graph divergence healed: new node already exists, ` +
+                            `treating as update. contentKey=${newNode.id} type=${newNode.type} iterationIndex=${index}`,
+                        meta: {
+                            trackableEvent: 'asset_graph_divergence_healed',
+                            ...diagnostics,
+                        },
+                    });
+                    if (existingNode) {
+                        Object.assign(existingNode, newNode);
+                    }
+                }
+                else {
+                    graph.addNodeByContentKey(newNode.id, newNode);
+                }
+            }
+            else {
+                try {
+                    graph.addNodeByContentKey(newNode.id, newNode);
+                }
+                catch (e) {
+                    if (e instanceof Error &&
+                        e.message.includes('already has content key')) {
+                        let existingNode = graph.getNodeByContentKey(newNode.id);
+                        let diagnostics = buildDivergenceDiagnostics('new_node_already_exists', newNode, existingNode, index);
+                        throw new Error(`Graph already has content key '${newNode.id}'. Diagnostics: ${JSON.stringify(diagnostics, null, 2)}`);
+                    }
+                    throw e;
                 }
-                throw e;
             }
         }
     }

package/lib/BundleGraph.js

@@ -257,8 +257,8 @@ class BundleGraph {
         // Don't retarget because this cannot be resolved without also changing the asset symbols
         // (and the asset content itself).
         [...targets].every(([, t]) => new Set([...t.values()]).size === t.size)) {
-          var _nodeValueSymbols$get;
-          let isReexportAll = ((_nodeValueSymbols$get = nodeValueSymbols.get('*')) === null || _nodeValueSymbols$get === void 0 ? void 0 : _nodeValueSymbols$get.local) === '*';
+          var _nodeValueSymbols$get, _node$value$meta;
+          let isReexportAll = ((_nodeValueSymbols$get = nodeValueSymbols.get('*')) === null || _nodeValueSymbols$get === void 0 ? void 0 : _nodeValueSymbols$get.local) === '*' || ((_node$value$meta = node.value.meta) === null || _node$value$meta === void 0 ? void 0 : _node$value$meta.hasExportStar);
           let reexportAllLoc = isReexportAll ? (0, _nullthrows().default)(nodeValueSymbols.get('*')).loc : undefined;
 
           // TODO adjust sourceAssetIdNode.value.dependencies ?
@@ -1503,7 +1503,7 @@ class BundleGraph {
     let deps = this.getDependencies(asset).reverse();
     let potentialResults = [];
     for (let dep of deps) {
-      var _depSymbols$get;
+      var _depSymbols$get, _dep$meta2;
       let depSymbols = dep.symbols;
       if (!depSymbols) {
         nonStaticDependency = true;
@@ -1555,7 +1555,7 @@ class BundleGraph {
       // If this module exports wildcards, resolve the original module.
       // Default exports are excluded from wildcard exports.
       // Wildcard reexports are never listed in the reexporting asset's symbols.
-      if (identifier == null && ((_depSymbols$get = depSymbols.get('*')) === null || _depSymbols$get === void 0 ? void 0 : _depSymbols$get.local) === '*' && symbol !== 'default') {
+      if (identifier == null && (((_depSymbols$get = depSymbols.get('*')) === null || _depSymbols$get === void 0 ? void 0 : _depSymbols$get.local) === '*' || (_dep$meta2 = dep.meta) !== null && _dep$meta2 !== void 0 && _dep$meta2.hasExportStar) && symbol !== 'default') {
         let resolved = this.getResolvedAsset(dep, boundary);
         if (!resolved) {
           continue;
@@ -1681,10 +1681,10 @@ class BundleGraph {
     }
     let deps = this.getDependencies(asset);
     for (let dep of deps) {
-      var _depSymbols$get2;
+      var _depSymbols$get2, _dep$meta3;
       let depSymbols = dep.symbols;
       if (!depSymbols) continue;
-      if (((_depSymbols$get2 = depSymbols.get('*')) === null || _depSymbols$get2 === void 0 ? void 0 : _depSymbols$get2.local) === '*') {
+      if (((_depSymbols$get2 = depSymbols.get('*')) === null || _depSymbols$get2 === void 0 ? void 0 : _depSymbols$get2.local) === '*' || (_dep$meta3 = dep.meta) !== null && _dep$meta3 !== void 0 && _dep$meta3.hasExportStar) {
         let resolved = this.getResolvedAsset(dep, boundary);
         if (!resolved) continue;
         let exported = this.getExportedSymbols(resolved, boundary).filter(s => s.exportSymbol !== 'default').map(s => s.exportSymbol !== '*' ? {

package/lib/SymbolPropagation.js

@@ -94,8 +94,8 @@ function propagateSymbols({
         }
       }
       let hasNamespaceOutgoingDeps = outgoingDeps.some(d => {
-        var _d$value$symbols;
-        return ((_d$value$symbols = d.value.symbols) === null || _d$value$symbols === void 0 || (_d$value$symbols = _d$value$symbols.get('*')) === null || _d$value$symbols === void 0 ? void 0 : _d$value$symbols.local) === '*';
+        var _d$value$symbols, _d$value$meta;
+        return ((_d$value$symbols = d.value.symbols) === null || _d$value$symbols === void 0 || (_d$value$symbols = _d$value$symbols.get('*')) === null || _d$value$symbols === void 0 ? void 0 : _d$value$symbols.local) === '*' || ((_d$value$meta = d.value.meta) === null || _d$value$meta === void 0 ? void 0 : _d$value$meta.hasExportStar);
       });
 
       // 1) Determine what the incomingDeps requests from the asset
@@ -168,10 +168,10 @@ function propagateSymbols({
         //    lib/index.js: `export * from "./foo.js"; export * from "./bar.js";`
         //    lib/foo.js:   `import { data } from "./bar.js"; export const foo = data + " esm2";`
         assetNode.usedSymbols.size > 0 || namespaceReexportedSymbols.size > 0) {
-          var _depSymbols$get;
+          var _depSymbols$get, _dep$value$meta;
           let depSymbols = dep.value.symbols;
           if (!depSymbols) continue;
-          if (((_depSymbols$get = depSymbols.get('*')) === null || _depSymbols$get === void 0 ? void 0 : _depSymbols$get.local) === '*') {
+          if (((_depSymbols$get = depSymbols.get('*')) === null || _depSymbols$get === void 0 ? void 0 : _depSymbols$get.local) === '*' || (_dep$value$meta = dep.value.meta) !== null && _dep$value$meta !== void 0 && _dep$value$meta.hasExportStar) {
             if (addAll) {
               depUsedSymbolsDown.add('*');
             } else {
@@ -258,7 +258,7 @@ function propagateSymbols({
       // analyzable exports
       let reexportedSymbolsSource = new Map();
       for (let outgoingDep of outgoingDeps) {
-        var _outgoingDepSymbols$g;
+        var _outgoingDepSymbols$g, _outgoingDep$value$me;
         let outgoingDepSymbols = outgoingDep.value.symbols;
         if (!outgoingDepSymbols) continue;
         let isExcluded = assetGraph.getNodeIdsConnectedFrom(assetGraph.getNodeIdByContentKey(outgoingDep.id)).length === 0;
@@ -266,7 +266,7 @@ function propagateSymbols({
         if (isExcluded) {
           outgoingDep.usedSymbolsDown.forEach((_, s) => outgoingDep.usedSymbolsUp.set(s, null));
         }
-        if (((_outgoingDepSymbols$g = outgoingDepSymbols.get('*')) === null || _outgoingDepSymbols$g === void 0 ? void 0 : _outgoingDepSymbols$g.local) === '*') {
+        if (((_outgoingDepSymbols$g = outgoingDepSymbols.get('*')) === null || _outgoingDepSymbols$g === void 0 ? void 0 : _outgoingDepSymbols$g.local) === '*' || (_outgoingDep$value$me = outgoingDep.value.meta) !== null && _outgoingDep$value$me !== void 0 && _outgoingDep$value$me.hasExportStar) {
           outgoingDep.usedSymbolsUp.forEach((sResolved, s) => {
             if (s === 'default') {
               return;
@@ -334,12 +334,12 @@ function propagateSymbols({
         current.set(s, value);
       }
       for (let incomingDep of incomingDeps) {
-        var _incomingDepSymbols$g;
+        var _incomingDepSymbols$g, _incomingDep$value$me;
         let incomingDepUsedSymbolsUpOld = incomingDep.usedSymbolsUp;
         incomingDep.usedSymbolsUp = new Map();
         let incomingDepSymbols = incomingDep.value.symbols;
         if (!incomingDepSymbols) continue;
-        let hasNamespaceReexport = ((_incomingDepSymbols$g = incomingDepSymbols.get('*')) === null || _incomingDepSymbols$g === void 0 ? void 0 : _incomingDepSymbols$g.local) === '*';
+        let hasNamespaceReexport = ((_incomingDepSymbols$g = incomingDepSymbols.get('*')) === null || _incomingDepSymbols$g === void 0 ? void 0 : _incomingDepSymbols$g.local) === '*' || ((_incomingDep$value$me = incomingDep.value.meta) === null || _incomingDep$value$me === void 0 ? void 0 : _incomingDep$value$me.hasExportStar);
         for (let s of incomingDep.usedSymbolsDown) {
           if (assetSymbols == null ||
           // Assume everything could be provided if symbols are cleared