@atlaspack/core 2.34.0 → 2.35.0

package/test/RequestTracker.test.ts

@@ -538,171 +538,6 @@ describe('RequestTracker', () => {
       });
     });
   });
-
-  describe('incremental bundling', () => {
-    async function runIncrementalBundlingScenario(
-      incrementalBundlingVersioning: boolean,
-    ) {
-      const fs = new OverlayFS(new MemoryFS(farm), new NodeFS());
-      const appRoot = __dirname;
-      await fs.mkdirp(path.join(appRoot, 'app'));
-      await fs.writeFile(path.join(appRoot, 'app', 'package.json'), '{}');
-      await fs.writeFile(path.join(appRoot, 'app', '.git'), '');
-      await fs.writeFile(
-        path.join(appRoot, 'app', '.parcelrc'),
-        '{"extends":"@atlaspack/config-default"}',
-      );
-      await fs.writeFile(
-        path.join(appRoot, 'app', 'target.js'),
-        'console.log("hello")',
-      );
-
-      const atlaspack = new Atlaspack({
-        featureFlags: {
-          incrementalBundlingVersioning,
-        },
-        workerFarm: farm,
-        entries: [path.join(appRoot, 'app', 'target.js')],
-        cache: new LMDBLiteCache(DEFAULT_OPTIONS.cacheDir),
-        inputFS: fs,
-        outputFS: fs,
-      });
-      await atlaspack._init();
-      const options = atlaspack._getResolvedAtlaspackOptions();
-      const tracker = new RequestTracker({farm, options});
-      let {ref: optionsRef} = await farm.createSharedReference(options, false);
-
-      const getAssetRequests = () =>
-        runRequestSpy
-          .getCalls()
-          .map((call: any) => call.args[0])
-          .filter(
-            (request: any) => request.type === requestTypes.asset_request,
-          );
-
-      // Running the build once builds one asset
-      const runRequestSpy = sinon.spy(tracker, 'runRequest');
-      await tracker.runRequest(
-        createAtlaspackBuildRequest({
-          optionsRef,
-          requestedAssetIds: new Set(),
-        }),
-      );
-      assert.equal(getAssetRequests().length, 1);
-      runRequestSpy.resetHistory();
-
-      // Running the build again with no invalidations does not build any assets
-      await tracker.runRequest(
-        createAtlaspackBuildRequest({
-          optionsRef,
-          requestedAssetIds: new Set(),
-        }),
-      );
-      assert.equal(getAssetRequests().length, 0);
-      runRequestSpy.resetHistory();
-
-      // Running the build again with a file change builds the asset again
-      tracker.respondToFSEvents(
-        [
-          {
-            type: 'update',
-            path: path.join(appRoot, 'app', 'target.js'),
-          },
-        ],
-        Number.MAX_VALUE,
-      );
-      await tracker.runRequest(
-        createAtlaspackBuildRequest({
-          optionsRef,
-          requestedAssetIds: new Set(),
-        }),
-      );
-      assert.equal(getAssetRequests().length, 1);
-      runRequestSpy.resetHistory();
-
-      // Run the asset graph request, but not bundling
-      await fs.writeFile(
-        path.join(appRoot, 'app', 'target.js'),
-        'require("./dep.js")',
-      );
-      await fs.writeFile(
-        path.join(appRoot, 'app', 'dep.js'),
-        'console.log("dep")',
-      );
-      tracker.respondToFSEvents(
-        [
-          {
-            type: 'update',
-            path: path.join(appRoot, 'app', 'target.js'),
-          },
-        ],
-        Number.MAX_VALUE,
-      );
-      const assetGraphRequestResult = await tracker.runRequest(
-        createAssetGraphRequest({
-          name: 'Main',
-          entries: [
-            toProjectPath(
-              path.join(appRoot, 'app'),
-              path.join(appRoot, 'app', 'target.js'),
-            ),
-          ],
-          optionsRef,
-          shouldBuildLazily: false,
-          lazyIncludes: [],
-          lazyExcludes: [],
-          requestedAssetIds: new Set(),
-        }),
-      );
-      assert.equal(getAssetRequests().length, 2);
-      assert.equal(
-        assetGraphRequestResult.assetGraph.safeToIncrementallyBundle,
-        false,
-      );
-
-      // Now make another change
-      tracker.respondToFSEvents(
-        [
-          {
-            type: 'update',
-            path: path.join(appRoot, 'app', 'target.js'),
-          },
-          {
-            type: 'update',
-            path: path.join(appRoot, 'app', 'dep.js'),
-          },
-        ],
-        Number.MAX_VALUE,
-      );
-      // And run the build again
-
-      if (!incrementalBundlingVersioning) {
-        await assert.rejects(async () => {
-          await tracker.runRequest(
-            createAtlaspackBuildRequest({
-              optionsRef,
-              requestedAssetIds: new Set(),
-            }),
-          );
-        });
-      } else {
-        await tracker.runRequest(
-          createAtlaspackBuildRequest({
-            optionsRef,
-            requestedAssetIds: new Set(),
-          }),
-        );
-      }
-    }
-
-    it('throws a content key not found exception without bundling versioning', async () => {
-      await runIncrementalBundlingScenario(false);
-    });
-
-    it('works fine with bundling versioning', async () => {
-      await runIncrementalBundlingScenario(true);
-    });
-  });
 });
 
 describe('cleanUpOrphans', () => {

package/test/TargetRequest.test.ts

@@ -122,6 +122,7 @@ describe('TargetResolver', () => {
         {
           name: 'customA',
           publicUrl: '/',
+          inlineRequires: false,
           distDir: normalizeSeparators(path.resolve('customA')),
           env: createEnvironment({
             context: 'browser',
@@ -142,6 +143,7 @@ describe('TargetResolver', () => {
         {
           name: 'customB',
           publicUrl: '/',
+          inlineRequires: false,
           distEntry: 'b.js',
           distDir: normalizeSeparators(path.resolve('customB')),
           env: createEnvironment({
@@ -175,6 +177,7 @@ describe('TargetResolver', () => {
           distDir: 'fixtures/common-targets/dist/main',
           distEntry: 'index.js',
           publicUrl: '/',
+          inlineRequires: false,
           env: createEnvironment({
             context: 'node',
             engines: {
@@ -209,6 +212,7 @@ describe('TargetResolver', () => {
           distDir: 'fixtures/common-targets/dist/module',
           distEntry: 'index.js',
           publicUrl: '/',
+          inlineRequires: false,
           env: createEnvironment({
             context: 'browser',
             engines: {
@@ -245,6 +249,7 @@ describe('TargetResolver', () => {
           distDir: 'fixtures/common-targets/dist/browser',
           distEntry: 'index.js',
           publicUrl: '/assets',
+          inlineRequires: false,
           env: createEnvironment({
             context: 'browser',
             engines: {
@@ -291,6 +296,7 @@ describe('TargetResolver', () => {
           ),
           distEntry: 'index.js',
           publicUrl: '/',
+          inlineRequires: false,
           env: createEnvironment({
             context: 'node',
             engines: {
@@ -334,6 +340,7 @@ describe('TargetResolver', () => {
           distDir: 'fixtures/custom-targets/dist/main',
           distEntry: 'index.js',
           publicUrl: '/',
+          inlineRequires: false,
           env: createEnvironment({
             context: 'node',
             engines: {
@@ -368,6 +375,7 @@ describe('TargetResolver', () => {
           distDir: 'fixtures/custom-targets/dist/browserModern',
           distEntry: 'index.js',
           publicUrl: '/',
+          inlineRequires: false,
           env: createEnvironment({
             context: 'browser',
             engines: {
@@ -405,6 +413,7 @@ describe('TargetResolver', () => {
           distDir: 'fixtures/custom-targets/dist/browserLegacy',
           distEntry: 'index.js',
           publicUrl: '/',
+          inlineRequires: false,
           env: createEnvironment({
             context: 'browser',
             engines: {
@@ -459,6 +468,7 @@ describe('TargetResolver', () => {
           distDir: 'fixtures/custom-targets/dist/main',
           distEntry: 'index.js',
           publicUrl: '/',
+          inlineRequires: false,
           env: createEnvironment({
             context: 'node',
             engines: {
@@ -493,6 +503,7 @@ describe('TargetResolver', () => {
           distDir: 'fixtures/custom-targets/dist/browserModern',
           distEntry: 'index.js',
           publicUrl: '/',
+          inlineRequires: false,
           env: createEnvironment({
             context: 'browser',
             engines: {
@@ -530,6 +541,7 @@ describe('TargetResolver', () => {
           distDir: 'fixtures/custom-targets/dist/browserLegacy',
           distEntry: 'index.js',
           publicUrl: '/',
+          inlineRequires: false,
           env: createEnvironment({
             context: 'browser',
             engines: {
@@ -576,6 +588,7 @@ describe('TargetResolver', () => {
           distDir: 'fixtures/custom-targets-distdir/www',
           distEntry: undefined,
           publicUrl: 'www',
+          inlineRequires: false,
           env: createEnvironment({
             context: 'browser',
             engines: {
@@ -631,6 +644,7 @@ describe('TargetResolver', () => {
           name: 'customB',
           distDir: normalizeSeparators(path.resolve('customB')),
           publicUrl: '/',
+          inlineRequires: false,
           env: createEnvironment({
             context: 'browser',
             engines: {
@@ -673,6 +687,7 @@ describe('TargetResolver', () => {
           name: 'customA',
           distDir: normalizeSeparators(path.resolve('customA')),
           publicUrl: '/',
+          inlineRequires: false,
           env: createEnvironment({
             context: 'browser',
             engines: {
@@ -702,6 +717,7 @@ describe('TargetResolver', () => {
         distDir: 'fixtures/context/dist/main',
         distEntry: 'index.js',
         publicUrl: '/',
+        inlineRequires: false,
         env: createEnvironment({
           context: 'node',
           engines: {
@@ -1073,6 +1089,7 @@ describe('TargetResolver', () => {
         distDir: relative(path.join(fixture, 'dist')),
         distEntry: 'index.mjs',
         publicUrl: '/',
+        inlineRequires: false,
         env: createEnvironment({
           context: 'browser',
           engines: {
@@ -1118,6 +1135,7 @@ describe('TargetResolver', () => {
         distDir: relative(path.join(fixture, 'dist')),
         distEntry: 'index.js',
         publicUrl: '/',
+        inlineRequires: false,
         env: createEnvironment({
           context: 'browser',
           engines: {
@@ -1167,6 +1185,7 @@ describe('TargetResolver', () => {
           distDir: 'fixtures/common-targets/dist/main',
           distEntry: 'index.js',
           publicUrl: '/',
+          inlineRequires: false,
           env: createEnvironment({
             context: 'node',
             engines: {
@@ -1201,6 +1220,7 @@ describe('TargetResolver', () => {
           distDir: 'fixtures/common-targets/dist/browser',
           distEntry: 'index.js',
           publicUrl: '/assets',
+          inlineRequires: false,
           env: createEnvironment({
             context: 'browser',
             engines: {
@@ -1249,6 +1269,7 @@ describe('TargetResolver', () => {
           name: 'default',
           distDir: serveDistDir,
           publicUrl: '/',
+          inlineRequires: false,
           env: createEnvironment({
             context: 'browser',
             engines: {
@@ -1286,6 +1307,7 @@ describe('TargetResolver', () => {
             path.join(DEFAULT_DISTPATH_FIXTURE_PATHS.none, 'dist'),
           ),
           publicUrl: '/',
+          inlineRequires: false,
           env: createEnvironment({
             context: 'browser',
             engines: {
@@ -1319,6 +1341,7 @@ describe('TargetResolver', () => {
           ),
           distEntry: undefined,
           publicUrl: '/',
+          inlineRequires: false,
           env: createEnvironment({
             context: 'browser',
             engines: {
@@ -1369,6 +1392,7 @@ describe('TargetResolver', () => {
           ),
           distEntry: undefined,
           publicUrl: '/',
+          inlineRequires: false,
           env: createEnvironment({
             context: 'browser',
             engines: {
@@ -1409,6 +1433,7 @@ describe('TargetResolver', () => {
           ),
           distEntry: undefined,
           publicUrl: '/',
+          inlineRequires: false,
           env: createEnvironment({
             context: 'browser',
             engines: {