@atlaspack/core 2.29.2 → 2.30.1-dev-40d0e250f.0

package/CHANGELOG.md

@@ -1,5 +1,25 @@
 # @atlaspack/core
 
+## 2.30.0
+
+### Minor Changes
+
+- [#925](https://github.com/atlassian-labs/atlaspack/pull/925) [`00fa643`](https://github.com/atlassian-labs/atlaspack/commit/00fa6433202bfd3311479f6314c9ec878a789f2c) Thanks [@benjervis](https://github.com/benjervis)! - Save propagating symbols for runtimes by requiring symbol and dependency data be returned at the time the assets are injected.
+
+### Patch Changes
+
+- Updated dependencies []:
+  - @atlaspack/fs@2.15.38
+  - @atlaspack/graph@3.6.5
+  - @atlaspack/logger@2.14.35
+  - @atlaspack/plugin@2.14.43
+  - @atlaspack/profiler@2.15.4
+  - @atlaspack/types@2.15.33
+  - @atlaspack/utils@3.2.4
+  - @atlaspack/workers@2.14.43
+  - @atlaspack/cache@3.2.38
+  - @atlaspack/package-manager@2.14.43
+
 ## 2.29.2
 
 ### Patch Changes

package/LICENSE

@@ -0,0 +1,201 @@
+                                 Apache License
+                           Version 2.0, January 2004
+                        http://www.apache.org/licenses/
+
+   TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION
+
+   1. Definitions.
+
+      "License" shall mean the terms and conditions for use, reproduction,
+      and distribution as defined by Sections 1 through 9 of this document.
+
+      "Licensor" shall mean the copyright owner or entity authorized by
+      the copyright owner that is granting the License.
+
+      "Legal Entity" shall mean the union of the acting entity and all
+      other entities that control, are controlled by, or are under common
+      control with that entity. For the purposes of this definition,
+      "control" means (i) the power, direct or indirect, to cause the
+      direction or management of such entity, whether by contract or
+      otherwise, or (ii) ownership of fifty percent (50%) or more of the
+      outstanding shares, or (iii) beneficial ownership of such entity.
+
+      "You" (or "Your") shall mean an individual or Legal Entity
+      exercising permissions granted by this License.
+
+      "Source" form shall mean the preferred form for making modifications,
+      including but not limited to software source code, documentation
+      source, and configuration files.
+
+      "Object" form shall mean any form resulting from mechanical
+      transformation or translation of a Source form, including but
+      not limited to compiled object code, generated documentation,
+      and conversions to other media types.
+
+      "Work" shall mean the work of authorship, whether in Source or
+      Object form, made available under the License, as indicated by a
+      copyright notice that is included in or attached to the work
+      (an example is provided in the Appendix below).
+
+      "Derivative Works" shall mean any work, whether in Source or Object
+      form, that is based on (or derived from) the Work and for which the
+      editorial revisions, annotations, elaborations, or other modifications
+      represent, as a whole, an original work of authorship. For the purposes
+      of this License, Derivative Works shall not include works that remain
+      separable from, or merely link (or bind by name) to the interfaces of,
+      the Work and Derivative Works thereof.
+
+      "Contribution" shall mean any work of authorship, including
+      the original version of the Work and any modifications or additions
+      to that Work or Derivative Works thereof, that is intentionally
+      submitted to Licensor for inclusion in the Work by the copyright owner
+      or by an individual or Legal Entity authorized to submit on behalf of
+      the copyright owner. For the purposes of this definition, "submitted"
+      means any form of electronic, verbal, or written communication sent
+      to the Licensor or its representatives, including but not limited to
+      communication on electronic mailing lists, source code control systems,
+      and issue tracking systems that are managed by, or on behalf of, the
+      Licensor for the purpose of discussing and improving the Work, but
+      excluding communication that is conspicuously marked or otherwise
+      designated in writing by the copyright owner as "Not a Contribution."
+
+      "Contributor" shall mean Licensor and any individual or Legal Entity
+      on behalf of whom a Contribution has been received by Licensor and
+      subsequently incorporated within the Work.
+
+   2. Grant of Copyright License. Subject to the terms and conditions of
+      this License, each Contributor hereby grants to You a perpetual,
+      worldwide, non-exclusive, no-charge, royalty-free, irrevocable
+      copyright license to reproduce, prepare Derivative Works of,
+      publicly display, publicly perform, sublicense, and distribute the
+      Work and such Derivative Works in Source or Object form.
+
+   3. Grant of Patent License. Subject to the terms and conditions of
+      this License, each Contributor hereby grants to You a perpetual,
+      worldwide, non-exclusive, no-charge, royalty-free, irrevocable
+      (except as stated in this section) patent license to make, have made,
+      use, offer to sell, sell, import, and otherwise transfer the Work,
+      where such license applies only to those patent claims licensable
+      by such Contributor that are necessarily infringed by their
+      Contribution(s) alone or by combination of their Contribution(s)
+      with the Work to which such Contribution(s) was submitted. If You
+      institute patent litigation against any entity (including a
+      cross-claim or counterclaim in a lawsuit) alleging that the Work
+      or a Contribution incorporated within the Work constitutes direct
+      or contributory patent infringement, then any patent licenses
+      granted to You under this License for that Work shall terminate
+      as of the date such litigation is filed.
+
+   4. Redistribution. You may reproduce and distribute copies of the
+      Work or Derivative Works thereof in any medium, with or without
+      modifications, and in Source or Object form, provided that You
+      meet the following conditions:
+
+      (a) You must give any other recipients of the Work or
+          Derivative Works a copy of this License; and
+
+      (b) You must cause any modified files to carry prominent notices
+          stating that You changed the files; and
+
+      (c) You must retain, in the Source form of any Derivative Works
+          that You distribute, all copyright, patent, trademark, and
+          attribution notices from the Source form of the Work,
+          excluding those notices that do not pertain to any part of
+          the Derivative Works; and
+
+      (d) If the Work includes a "NOTICE" text file as part of its
+          distribution, then any Derivative Works that You distribute must
+          include a readable copy of the attribution notices contained
+          within such NOTICE file, excluding those notices that do not
+          pertain to any part of the Derivative Works, in at least one
+          of the following places: within a NOTICE text file distributed
+          as part of the Derivative Works; within the Source form or
+          documentation, if provided along with the Derivative Works; or,
+          within a display generated by the Derivative Works, if and
+          wherever such third-party notices normally appear. The contents
+          of the NOTICE file are for informational purposes only and
+          do not modify the License. You may add Your own attribution
+          notices within Derivative Works that You distribute, alongside
+          or as an addendum to the NOTICE text from the Work, provided
+          that such additional attribution notices cannot be construed
+          as modifying the License.
+
+      You may add Your own copyright statement to Your modifications and
+      may provide additional or different license terms and conditions
+      for use, reproduction, or distribution of Your modifications, or
+      for any such Derivative Works as a whole, provided Your use,
+      reproduction, and distribution of the Work otherwise complies with
+      the conditions stated in this License.
+
+   5. Submission of Contributions. Unless You explicitly state otherwise,
+      any Contribution intentionally submitted for inclusion in the Work
+      by You to the Licensor shall be under the terms and conditions of
+      this License, without any additional terms or conditions.
+      Notwithstanding the above, nothing herein shall supersede or modify
+      the terms of any separate license agreement you may have executed
+      with Licensor regarding such Contributions.
+
+   6. Trademarks. This License does not grant permission to use the trade
+      names, trademarks, service marks, or product names of the Licensor,
+      except as required for reasonable and customary use in describing the
+      origin of the Work and reproducing the content of the NOTICE file.
+
+   7. Disclaimer of Warranty. Unless required by applicable law or
+      agreed to in writing, Licensor provides the Work (and each
+      Contributor provides its Contributions) on an "AS IS" BASIS,
+      WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
+      implied, including, without limitation, any warranties or conditions
+      of TITLE, NON-INFRINGEMENT, MERCHANTABILITY, or FITNESS FOR A
+      PARTICULAR PURPOSE. You are solely responsible for determining the
+      appropriateness of using or redistributing the Work and assume any
+      risks associated with Your exercise of permissions under this License.
+
+   8. Limitation of Liability. In no event and under no legal theory,
+      whether in tort (including negligence), contract, or otherwise,
+      unless required by applicable law (such as deliberate and grossly
+      negligent acts) or agreed to in writing, shall any Contributor be
+      liable to You for damages, including any direct, indirect, special,
+      incidental, or consequential damages of any character arising as a
+      result of this License or out of the use or inability to use the
+      Work (including but not limited to damages for loss of goodwill,
+      work stoppage, computer failure or malfunction, or any and all
+      other commercial damages or losses), even if such Contributor
+      has been advised of the possibility of such damages.
+
+   9. Accepting Warranty or Additional Liability. While redistributing
+      the Work or Derivative Works thereof, You may choose to offer,
+      and charge a fee for, acceptance of support, warranty, indemnity,
+      or other liability obligations and/or rights consistent with this
+      License. However, in accepting such obligations, You may act only
+      on Your own behalf and on Your sole responsibility, not on behalf
+      of any other Contributor, and only if You agree to indemnify,
+      defend, and hold each Contributor harmless for any liability
+      incurred by, or claims asserted against, such Contributor by reason
+      of your accepting any such warranty or additional liability.
+
+   END OF TERMS AND CONDITIONS
+
+   APPENDIX: How to apply the Apache License to your work.
+
+      To apply the Apache License to your work, attach the following
+      boilerplate notice, with the fields enclosed by brackets "[]"
+      replaced with your own identifying information. (Don't include
+      the brackets!)  The text should be enclosed in the appropriate
+      comment syntax for the file format. We also recommend that a
+      file or class name and description of purpose be included on the
+      same "printed page" as the copyright notice for easier
+      identification within third-party archives.
+
+   Copyright (c) 2024 Atlassian US., Inc.
+
+   Licensed under the Apache License, Version 2.0 (the "License");
+   you may not use this file except in compliance with the License.
+   You may obtain a copy of the License at
+
+       http://www.apache.org/licenses/LICENSE-2.0
+
+   Unless required by applicable law or agreed to in writing, software
+   distributed under the License is distributed on an "AS IS" BASIS,
+   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+   See the License for the specific language governing permissions and
+   limitations under the License.

package/dist/applyRuntimes.js

@@ -56,6 +56,7 @@ const projectPath_1 = require("./projectPath");
 const profiler_1 = require("@atlaspack/profiler");
 const utils_1 = require("@atlaspack/utils");
 const EnvironmentManager_1 = require("./EnvironmentManager");
+const feature_flags_1 = require("@atlaspack/feature-flags");
 function nameRuntimeBundle(bundle, siblingBundle) {
     // We don't run custom namers on runtime bundles as the runtime assumes that they are
     // located at the same nesting level as their owning bundle. Custom naming could
@@ -121,7 +122,7 @@ async function applyRuntimes({ bundleGraph, config, options, pluginOptions, api,
                 });
                 if (applied) {
                     let runtimeAssets = Array.isArray(applied) ? applied : [applied];
-                    for (let { code, dependency, filePath, isEntry, env, runtimeAssetRequiringExecutionOnLoad, priority, } of runtimeAssets) {
+                    for (let { code, dependency, filePath, isEntry, env, runtimeAssetRequiringExecutionOnLoad, priority, symbolData, } of runtimeAssets) {
                         let sourceName = path_1.default.join(path_1.default.dirname(filePath), `runtime-${(0, rust_1.hashString)(code)}.${bundle.type}`);
                         let assetGroup = {
                             code,
@@ -131,6 +132,7 @@ async function applyRuntimes({ bundleGraph, config, options, pluginOptions, api,
                             // Runtime assets should be considered source, as they should be
                             // e.g. compiled to run in the target environment
                             isSource: true,
+                            symbolData,
                         };
                         let connectionBundle = bundle;
                         /**
@@ -213,6 +215,10 @@ async function applyRuntimes({ bundleGraph, config, options, pluginOptions, api,
     // Create a new AssetGraph from the generated runtime assets which also runs
     // transforms and resolves all dependencies.
     let { assetGraph: runtimesAssetGraph, changedAssets } = await reconcileNewRuntimes(api, connections, optionsRef);
+    if ((0, feature_flags_1.getFeatureFlag)('skipRuntimeSymbolProp')) {
+        // Apply pre-computed symbol data from runtime assets to skip symbol propagation
+        applyRuntimeSymbolData(runtimesAssetGraph, connections);
+    }
     // Convert the runtime AssetGraph into a BundleGraph, this includes assigning
     // the assets their public ids
     let runtimesBundleGraph = BundleGraph_2.default.fromAssetGraph(runtimesAssetGraph, options.mode === 'production', bundleGraph._publicIdByAssetId, bundleGraph._assetPublicIds);
@@ -293,12 +299,84 @@ async function applyRuntimes({ bundleGraph, config, options, pluginOptions, api,
     }
     return changedAssets;
 }
+/**
+ * Apply pre-computed symbol data from runtime assets to the asset graph
+ * to avoid running symbol propagation on runtime code we control.
+ */
+function applyRuntimeSymbolData(assetGraph, connections) {
+    for (let { assetGroup } of connections) {
+        let assetGroupNode = (0, AssetGraph_1.nodeFromAssetGroup)(assetGroup);
+        let assetGroupAssetNodeIds = assetGraph.getNodeIdsConnectedFrom(assetGraph.getNodeIdByContentKey(assetGroupNode.id));
+        if (assetGroupAssetNodeIds.length !== 1) {
+            continue;
+        }
+        let runtimeAssetNodeId = assetGroupAssetNodeIds[0];
+        let runtimeAssetNode = assetGraph.getNode(runtimeAssetNodeId);
+        if (!runtimeAssetNode || runtimeAssetNode.type !== 'asset') {
+            continue;
+        }
+        let symbolData = assetGroup.symbolData;
+        if (!symbolData) {
+            // We completely skip symbol propagation for runtime assets, so symbolData
+            // is required
+            throw new Error('Runtime asset is missing symbol data');
+        }
+        if (symbolData.symbols) {
+            // Convert from SymbolData format to internal Asset.symbols format
+            let internalSymbols = new Map();
+            for (let [symbol, data] of symbolData.symbols) {
+                internalSymbols.set(symbol, {
+                    local: data.local,
+                    loc: data.loc || null,
+                    meta: data.meta,
+                });
+            }
+            runtimeAssetNode.value.symbols = internalSymbols;
+        }
+        if (symbolData.dependencies && symbolData.dependencies.length > 0) {
+            let outgoingDeps = assetGraph
+                .getNodeIdsConnectedFrom(runtimeAssetNodeId)
+                .map((id) => assetGraph.getNode(id))
+                .filter((node) => node?.type === 'dependency')
+                .map((node) => node);
+            for (let depSymbolData of symbolData.dependencies) {
+                let matchingDep = outgoingDeps.find((depNode) => depNode.value.specifier === depSymbolData.specifier);
+                if (matchingDep) {
+                    if (depSymbolData.symbols) {
+                        let internalDepSymbols = new Map();
+                        for (let [symbol, data] of depSymbolData.symbols) {
+                            internalDepSymbols.set(symbol, {
+                                local: data.local,
+                                loc: data.loc || null,
+                                isWeak: data.isWeak,
+                                meta: data.meta,
+                            });
+                        }
+                        matchingDep.value.symbols = internalDepSymbols;
+                    }
+                    if (depSymbolData.usedSymbols) {
+                        matchingDep.usedSymbolsDown = new Set(depSymbolData.usedSymbols);
+                        // For runtime assets, usedSymbolsUp will be the same as usedSymbolsDown
+                        // since we know exactly what we're using
+                        let usedSymbolsUp = new Map();
+                        for (let symbol of depSymbolData.usedSymbols) {
+                            // Mark as resolved to external (null) since runtime deps are typically external
+                            usedSymbolsUp.set(symbol, null);
+                        }
+                        matchingDep.usedSymbolsUp = usedSymbolsUp;
+                    }
+                }
+            }
+        }
+    }
+}
 function reconcileNewRuntimes(api, connections, optionsRef) {
     let assetGroups = connections.map((t) => t.assetGroup);
     let request = (0, AssetGraphRequest_1.default)({
         name: 'Runtimes',
         assetGroups,
         optionsRef,
+        skipSymbolProp: (0, feature_flags_1.getFeatureFlag)('skipRuntimeSymbolProp'),
     });
     // rebuild the graph
     return api.runRequest(request, { force: true });

package/dist/requests/AssetGraphRequest.js

@@ -76,6 +76,7 @@ class AssetGraphBuilder {
         this.shouldBuildLazily = shouldBuildLazily ?? false;
         this.lazyIncludes = lazyIncludes ?? [];
         this.lazyExcludes = lazyExcludes ?? [];
+        this.skipSymbolProp = input.skipSymbolProp ?? false;
         if ((0, feature_flags_1.getFeatureFlag)('cachePerformanceImprovements')) {
             const key = (0, rust_1.hashString)(`${constants_1.ATLASPACK_VERSION}${name}${JSON.stringify(entries) ?? ''}${options.mode}${options.shouldBuildLazily ? 'lazy' : 'eager'}`);
             this.cacheKey = `AssetGraph/${constants_1.ATLASPACK_VERSION}/${options.mode}/${key}`;
@@ -172,34 +173,43 @@ class AssetGraphBuilder {
         }
         if (this.assetGraph.nodes.length > 1) {
             await (0, dumpGraphToGraphViz_1.default)(this.assetGraph, 'AssetGraph_' + this.name + '_before_prop');
-            try {
-                let errors = (0, SymbolPropagation_1.propagateSymbols)({
-                    options: this.options,
-                    assetGraph: this.assetGraph,
-                    changedAssetsPropagation: this.changedAssetsPropagation,
-                    assetGroupsWithRemovedParents: this.assetGroupsWithRemovedParents,
-                    previousErrors: this.previousSymbolPropagationErrors,
+            // Skip symbol propagation for runtime assets - they have pre-computed symbol data
+            if (this.skipSymbolProp) {
+                logger_1.default.verbose({
+                    origin: '@atlaspack/core',
+                    message: 'Skipping symbol propagation for runtime asset graph',
                 });
-                this.changedAssetsPropagation.clear();
-                if (errors.size > 0) {
-                    this.api.storeResult({
+            }
+            else {
+                try {
+                    let errors = (0, SymbolPropagation_1.propagateSymbols)({
+                        options: this.options,
                         assetGraph: this.assetGraph,
-                        changedAssets: this.changedAssets,
                         changedAssetsPropagation: this.changedAssetsPropagation,
                         assetGroupsWithRemovedParents: this.assetGroupsWithRemovedParents,
-                        previousSymbolPropagationErrors: errors,
-                        assetRequests: [],
-                    }, this.cacheKey);
-                    // Just throw the first error. Since errors can bubble (e.g. reexporting a reexported symbol also fails),
-                    // determining which failing export is the root cause is nontrivial (because of circular dependencies).
-                    throw new diagnostic_1.default({
-                        diagnostic: [...errors.values()][0],
+                        previousErrors: this.previousSymbolPropagationErrors,
                     });
+                    this.changedAssetsPropagation.clear();
+                    if (errors.size > 0) {
+                        this.api.storeResult({
+                            assetGraph: this.assetGraph,
+                            changedAssets: this.changedAssets,
+                            changedAssetsPropagation: this.changedAssetsPropagation,
+                            assetGroupsWithRemovedParents: this.assetGroupsWithRemovedParents,
+                            previousSymbolPropagationErrors: errors,
+                            assetRequests: [],
+                        }, this.cacheKey);
+                        // Just throw the first error. Since errors can bubble (e.g. reexporting a reexported symbol also fails),
+                        // determining which failing export is the root cause is nontrivial (because of circular dependencies).
+                        throw new diagnostic_1.default({
+                            diagnostic: [...errors.values()][0],
+                        });
+                    }
+                }
+                catch (e) {
+                    await (0, dumpGraphToGraphViz_1.default)(this.assetGraph, 'AssetGraph_' + this.name + '_failed');
+                    throw e;
                 }
-            }
-            catch (e) {
-                await (0, dumpGraphToGraphViz_1.default)(this.assetGraph, 'AssetGraph_' + this.name + '_failed');
-                throw e;
             }
         }
         await (0, dumpGraphToGraphViz_1.default)(this.assetGraph, 'AssetGraph_' + this.name);

package/dist/requests/BundleGraphRequest.js

@@ -360,7 +360,7 @@ class BundlerRunner {
             // can match them to the correct packager/optimizer plugins.
             let bundles = internalBundleGraph.getBundles({ includeInline: true });
             await Promise.all(bundles.map((bundle) => this.nameBundle(namers, bundle, internalBundleGraph)));
-            changedRuntimes = await (0, applyRuntimes_1.default)({
+            changedRuntimes = await (0, logger_1.instrumentAsync)('applyRuntimes', () => (0, applyRuntimes_1.default)({
                 bundleGraph: internalBundleGraph,
                 api: this.api,
                 config: this.config,
@@ -370,7 +370,7 @@ class BundlerRunner {
                 previousDevDeps: this.previousDevDeps,
                 devDepRequests: this.devDepRequests,
                 configs: this.configs,
-            });
+            }));
             // Add dev deps for namers, AFTER running them to account for lazy require().
             for (let namer of namers) {
                 let devDepRequest = await (0, DevDepRequest_1.createDevDependency)({

package/lib/applyRuntimes.js

@@ -70,6 +70,13 @@ function _utils() {
   return data;
 }
 var _EnvironmentManager = require("./EnvironmentManager");
+function _featureFlags() {
+  const data = require("@atlaspack/feature-flags");
+  _featureFlags = function () {
+    return data;
+  };
+  return data;
+}
 function _getRequireWildcardCache(e) { if ("function" != typeof WeakMap) return null; var r = new WeakMap(), t = new WeakMap(); return (_getRequireWildcardCache = function (e) { return e ? t : r; })(e); }
 function _interopRequireWildcard(e, r) { if (!r && e && e.__esModule) return e; if (null === e || "object" != typeof e && "function" != typeof e) return { default: e }; var t = _getRequireWildcardCache(r); if (t && t.has(e)) return t.get(e); var n = { __proto__: null }, a = Object.defineProperty && Object.getOwnPropertyDescriptor; for (var u in e) if ("default" !== u && Object.prototype.hasOwnProperty.call(e, u)) { var i = a ? Object.getOwnPropertyDescriptor(e, u) : null; i && (i.get || i.set) ? Object.defineProperty(n, u, i) : n[u] = e[u]; } return n.default = e, t && t.set(e, n), n; }
 function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }
@@ -162,7 +169,8 @@ async function applyRuntimes({
             isEntry,
             env,
             runtimeAssetRequiringExecutionOnLoad,
-            priority
+            priority,
+            symbolData
           } of runtimeAssets) {
             let sourceName = _path().default.join(_path().default.dirname(filePath), `runtime-${(0, _rust().hashString)(code)}.${bundle.type}`);
             let assetGroup = {
@@ -172,7 +180,8 @@ async function applyRuntimes({
               env: (0, _Environment.mergeEnvironments)(options.projectRoot, (0, _EnvironmentManager.fromEnvironmentId)(bundle.env), env),
               // Runtime assets should be considered source, as they should be
               // e.g. compiled to run in the target environment
-              isSource: true
+              isSource: true,
+              symbolData
             };
             let connectionBundle = bundle;
 
@@ -262,6 +271,10 @@ async function applyRuntimes({
     assetGraph: runtimesAssetGraph,
     changedAssets
   } = await reconcileNewRuntimes(api, connections, optionsRef);
+  if ((0, _featureFlags().getFeatureFlag)('skipRuntimeSymbolProp')) {
+    // Apply pre-computed symbol data from runtime assets to skip symbol propagation
+    applyRuntimeSymbolData(runtimesAssetGraph, connections);
+  }
 
   // Convert the runtime AssetGraph into a BundleGraph, this includes assigning
   // the assets their public ids
@@ -348,12 +361,83 @@ async function applyRuntimes({
   }
   return changedAssets;
 }
+
+/**
+ * Apply pre-computed symbol data from runtime assets to the asset graph
+ * to avoid running symbol propagation on runtime code we control.
+ */
+function applyRuntimeSymbolData(assetGraph, connections) {
+  for (let {
+    assetGroup
+  } of connections) {
+    let assetGroupNode = (0, _AssetGraph.nodeFromAssetGroup)(assetGroup);
+    let assetGroupAssetNodeIds = assetGraph.getNodeIdsConnectedFrom(assetGraph.getNodeIdByContentKey(assetGroupNode.id));
+    if (assetGroupAssetNodeIds.length !== 1) {
+      continue;
+    }
+    let runtimeAssetNodeId = assetGroupAssetNodeIds[0];
+    let runtimeAssetNode = assetGraph.getNode(runtimeAssetNodeId);
+    if (!runtimeAssetNode || runtimeAssetNode.type !== 'asset') {
+      continue;
+    }
+    let symbolData = assetGroup.symbolData;
+    if (!symbolData) {
+      // We completely skip symbol propagation for runtime assets, so symbolData
+      // is required
+      throw new Error('Runtime asset is missing symbol data');
+    }
+    if (symbolData.symbols) {
+      // Convert from SymbolData format to internal Asset.symbols format
+      let internalSymbols = new Map();
+      for (let [symbol, data] of symbolData.symbols) {
+        internalSymbols.set(symbol, {
+          local: data.local,
+          loc: data.loc || null,
+          meta: data.meta
+        });
+      }
+      runtimeAssetNode.value.symbols = internalSymbols;
+    }
+    if (symbolData.dependencies && symbolData.dependencies.length > 0) {
+      let outgoingDeps = assetGraph.getNodeIdsConnectedFrom(runtimeAssetNodeId).map(id => assetGraph.getNode(id)).filter(node => (node === null || node === void 0 ? void 0 : node.type) === 'dependency').map(node => node);
+      for (let depSymbolData of symbolData.dependencies) {
+        let matchingDep = outgoingDeps.find(depNode => depNode.value.specifier === depSymbolData.specifier);
+        if (matchingDep) {
+          if (depSymbolData.symbols) {
+            let internalDepSymbols = new Map();
+            for (let [symbol, data] of depSymbolData.symbols) {
+              internalDepSymbols.set(symbol, {
+                local: data.local,
+                loc: data.loc || null,
+                isWeak: data.isWeak,
+                meta: data.meta
+              });
+            }
+            matchingDep.value.symbols = internalDepSymbols;
+          }
+          if (depSymbolData.usedSymbols) {
+            matchingDep.usedSymbolsDown = new Set(depSymbolData.usedSymbols);
+            // For runtime assets, usedSymbolsUp will be the same as usedSymbolsDown
+            // since we know exactly what we're using
+            let usedSymbolsUp = new Map();
+            for (let symbol of depSymbolData.usedSymbols) {
+              // Mark as resolved to external (null) since runtime deps are typically external
+              usedSymbolsUp.set(symbol, null);
+            }
+            matchingDep.usedSymbolsUp = usedSymbolsUp;
+          }
+        }
+      }
+    }
+  }
+}
 function reconcileNewRuntimes(api, connections, optionsRef) {
   let assetGroups = connections.map(t => t.assetGroup);
   let request = (0, _AssetGraphRequest.default)({
     name: 'Runtimes',
     assetGroups,
-    optionsRef
+    optionsRef,
+    skipSymbolProp: (0, _featureFlags().getFeatureFlag)('skipRuntimeSymbolProp')
   });
 
   // rebuild the graph

package/lib/requests/AssetGraphRequest.js

@@ -124,6 +124,7 @@ class AssetGraphBuilder {
     this.shouldBuildLazily = shouldBuildLazily ?? false;
     this.lazyIncludes = lazyIncludes ?? [];
     this.lazyExcludes = lazyExcludes ?? [];
+    this.skipSymbolProp = input.skipSymbolProp ?? false;
     if ((0, _featureFlags().getFeatureFlag)('cachePerformanceImprovements')) {
       const key = (0, _rust().hashString)(`${_constants.ATLASPACK_VERSION}${name}${JSON.stringify(entries) ?? ''}${options.mode}${options.shouldBuildLazily ? 'lazy' : 'eager'}`);
       this.cacheKey = `AssetGraph/${_constants.ATLASPACK_VERSION}/${options.mode}/${key}`;
@@ -216,34 +217,43 @@ class AssetGraphBuilder {
     }
     if (this.assetGraph.nodes.length > 1) {
       await (0, _dumpGraphToGraphViz.default)(this.assetGraph, 'AssetGraph_' + this.name + '_before_prop');
-      try {
-        let errors = (0, _SymbolPropagation.propagateSymbols)({
-          options: this.options,
-          assetGraph: this.assetGraph,
-          changedAssetsPropagation: this.changedAssetsPropagation,
-          assetGroupsWithRemovedParents: this.assetGroupsWithRemovedParents,
-          previousErrors: this.previousSymbolPropagationErrors
+
+      // Skip symbol propagation for runtime assets - they have pre-computed symbol data
+      if (this.skipSymbolProp) {
+        _logger().default.verbose({
+          origin: '@atlaspack/core',
+          message: 'Skipping symbol propagation for runtime asset graph'
         });
-        this.changedAssetsPropagation.clear();
-        if (errors.size > 0) {
-          this.api.storeResult({
+      } else {
+        try {
+          let errors = (0, _SymbolPropagation.propagateSymbols)({
+            options: this.options,
             assetGraph: this.assetGraph,
-            changedAssets: this.changedAssets,
             changedAssetsPropagation: this.changedAssetsPropagation,
             assetGroupsWithRemovedParents: this.assetGroupsWithRemovedParents,
-            previousSymbolPropagationErrors: errors,
-            assetRequests: []
-          }, this.cacheKey);
-
-          // Just throw the first error. Since errors can bubble (e.g. reexporting a reexported symbol also fails),
-          // determining which failing export is the root cause is nontrivial (because of circular dependencies).
-          throw new (_diagnostic().default)({
-            diagnostic: [...errors.values()][0]
+            previousErrors: this.previousSymbolPropagationErrors
           });
+          this.changedAssetsPropagation.clear();
+          if (errors.size > 0) {
+            this.api.storeResult({
+              assetGraph: this.assetGraph,
+              changedAssets: this.changedAssets,
+              changedAssetsPropagation: this.changedAssetsPropagation,
+              assetGroupsWithRemovedParents: this.assetGroupsWithRemovedParents,
+              previousSymbolPropagationErrors: errors,
+              assetRequests: []
+            }, this.cacheKey);
+
+            // Just throw the first error. Since errors can bubble (e.g. reexporting a reexported symbol also fails),
+            // determining which failing export is the root cause is nontrivial (because of circular dependencies).
+            throw new (_diagnostic().default)({
+              diagnostic: [...errors.values()][0]
+            });
+          }
+        } catch (e) {
+          await (0, _dumpGraphToGraphViz.default)(this.assetGraph, 'AssetGraph_' + this.name + '_failed');
+          throw e;
         }
-      } catch (e) {
-        await (0, _dumpGraphToGraphViz.default)(this.assetGraph, 'AssetGraph_' + this.name + '_failed');
-        throw e;
       }
     }
     await (0, _dumpGraphToGraphViz.default)(this.assetGraph, 'AssetGraph_' + this.name);

package/lib/requests/BundleGraphRequest.js

@@ -412,7 +412,7 @@ class BundlerRunner {
         includeInline: true
       });
       await Promise.all(bundles.map(bundle => this.nameBundle(namers, bundle, internalBundleGraph)));
-      changedRuntimes = await (0, _applyRuntimes.default)({
+      changedRuntimes = await (0, _logger().instrumentAsync)('applyRuntimes', () => (0, _applyRuntimes.default)({
         bundleGraph: internalBundleGraph,
         api: this.api,
         config: this.config,
@@ -422,7 +422,7 @@ class BundlerRunner {
         previousDevDeps: this.previousDevDeps,
         devDepRequests: this.devDepRequests,
         configs: this.configs
-      });
+      }));
 
       // Add dev deps for namers, AFTER running them to account for lazy require().
       for (let namer of namers) {