@atlaspack/core 2.25.2-dev-native-compiled-test-712d92d32.0 → 2.26.0

package/CHANGELOG.md

@@ -1,5 +1,37 @@
 # @atlaspack/core
 
+## 2.26.0
+
+### Minor Changes
+
+- [#827](https://github.com/atlassian-labs/atlaspack/pull/827) [`ff8ac84`](https://github.com/atlassian-labs/atlaspack/commit/ff8ac84bd0be15caa7c7af21bf5b6e47b6d36438) Thanks [@OscarCookeAbbott](https://github.com/OscarCookeAbbott)! - Fix custom environment properties sometimes being ignored
+
+### Patch Changes
+
+- [#817](https://github.com/atlassian-labs/atlaspack/pull/817) [`3da8e69`](https://github.com/atlassian-labs/atlaspack/commit/3da8e690605472d81c531366b65fa9844f8ca337) Thanks [@mattcompiles](https://github.com/mattcompiles)! - Fix an issue when creating the BundleGraph and some Dependency.sourceAssetId values have diverged from the actual Asset.id values.
+
+  Fix behind flag `sourceAssetIdBundleGraphFix`
+
+- [#810](https://github.com/atlassian-labs/atlaspack/pull/810) [`c372f3f`](https://github.com/atlassian-labs/atlaspack/commit/c372f3fd6fce8200d5cf47f41bc7895c6cbb5558) Thanks [@benjervis](https://github.com/benjervis)! - Add the `scope-hosting-stats` debug tool to report on the percentage of assets that were able to be scope hoisted during the build.
+
+- [#831](https://github.com/atlassian-labs/atlaspack/pull/831) [`27fd73f`](https://github.com/atlassian-labs/atlaspack/commit/27fd73fa07d358653f1be6f2d15d72dc5d8fc2fd) Thanks [@benjervis](https://github.com/benjervis)! - Update some Rust internals to use Arcs instead of passing references. This won't make any difference in the immediate term, but is required setup for the next set of changes
+
+- [#834](https://github.com/atlassian-labs/atlaspack/pull/834) [`3091fa3`](https://github.com/atlassian-labs/atlaspack/commit/3091fa36425ecffe3938e55247a035b08cda37a2) Thanks [@benjervis](https://github.com/benjervis)! - We no longer want to use `meta` fields internally in Atlaspack, so they have been removed from the Rust side of the codebase, and are mapped back to the legacy format on the JS side.
+
+- Updated dependencies [[`79a7e22`](https://github.com/atlassian-labs/atlaspack/commit/79a7e22ef119891a2f4180a9d3cc66b38dd52092), [`3da8e69`](https://github.com/atlassian-labs/atlaspack/commit/3da8e690605472d81c531366b65fa9844f8ca337), [`c372f3f`](https://github.com/atlassian-labs/atlaspack/commit/c372f3fd6fce8200d5cf47f41bc7895c6cbb5558), [`17dfea9`](https://github.com/atlassian-labs/atlaspack/commit/17dfea9e9f3169807808520df9c09ebf70dc8b10), [`f1070ec`](https://github.com/atlassian-labs/atlaspack/commit/f1070ec48e99b4ec111a03179c5ab5b74163fab1), [`27fd73f`](https://github.com/atlassian-labs/atlaspack/commit/27fd73fa07d358653f1be6f2d15d72dc5d8fc2fd), [`3091fa3`](https://github.com/atlassian-labs/atlaspack/commit/3091fa36425ecffe3938e55247a035b08cda37a2)]:
+  - @atlaspack/feature-flags@2.25.5
+  - @atlaspack/rust@3.8.3
+  - @atlaspack/utils@3.0.3
+  - @atlaspack/cache@3.2.30
+  - @atlaspack/fs@2.15.30
+  - @atlaspack/graph@3.5.24
+  - @atlaspack/package-manager@2.14.35
+  - @atlaspack/logger@2.14.27
+  - @atlaspack/plugin@2.14.35
+  - @atlaspack/profiler@2.14.32
+  - @atlaspack/types@2.15.25
+  - @atlaspack/workers@2.14.35
+
 ## 2.25.1
 
 ### Patch Changes

package/dist/CommittedAsset.js

@@ -138,8 +138,5 @@ class CommittedAsset {
     getDependencies() {
         return Array.from(this.value.dependencies.values());
     }
-    getCompiledCssStyles() {
-        return this.value.compiledCssStyles;
-    }
 }
 exports.default = CommittedAsset;

package/dist/UncommittedAsset.js

@@ -311,14 +311,5 @@ class UncommittedAsset {
         // @ts-expect-error TS2345
         this.value.id = (0, assetUtils_1.createAssetIdFromOptions)(this.value);
     }
-    setCompiledCssStyles(styles) {
-        if (styles.length > 0) {
-            console.log('setCompiledCssStyles', styles);
-        }
-        this.value.compiledCssStyles = styles;
-    }
-    getCompiledCssStyles() {
-        return this.value.compiledCssStyles;
-    }
 }
 exports.default = UncommittedAsset;

package/dist/atlaspack-v3/worker/compat/mutable-asset.js

@@ -51,7 +51,6 @@ class MutableAsset {
         this.symbols = new asset_symbols_1.MutableAssetSymbols(asset.symbols);
         this.type = asset.type;
         this.uniqueKey = asset.uniqueKey;
-        this.compiledCssStyles = asset.compiledCssStyles;
         __classPrivateFieldSet(this, _MutableAsset_astDirty, false, "f");
         __classPrivateFieldSet(this, _MutableAsset_contents, contents, "f");
         __classPrivateFieldSet(this, _MutableAsset_inner, asset, "f");
@@ -148,9 +147,6 @@ class MutableAsset {
     invalidateOnBuild() {
         // TODO: Forward invalidations to Rust
     }
-    setCompiledCssStyles(styles) {
-        this.compiledCssStyles = styles;
-    }
 }
 exports.MutableAsset = MutableAsset;
 _MutableAsset_astDirty = new WeakMap(), _MutableAsset_ast = new WeakMap(), _MutableAsset_contents = new WeakMap(), _MutableAsset_inner = new WeakMap(), _MutableAsset_map = new WeakMap(), _MutableAsset_projectRoot = new WeakMap(), _MutableAsset_sourceMap = new WeakMap();

package/dist/public/Asset.js

@@ -133,9 +133,6 @@ class BaseAsset {
     getMapBuffer() {
         return __classPrivateFieldGet(this, _BaseAsset_asset, "f").getMapBuffer();
     }
-    getCompiledCssStyles() {
-        return __classPrivateFieldGet(this, _BaseAsset_asset, "f").getCompiledCssStyles();
-    }
 }
 class Asset extends BaseAsset {
     constructor(asset) {
@@ -277,9 +274,6 @@ class MutableAsset extends BaseAsset {
         });
         __classPrivateFieldGet(this, _MutableAsset_asset, "f").updateId();
     }
-    setCompiledCssStyles(styles) {
-        __classPrivateFieldGet(this, _MutableAsset_asset, "f").setCompiledCssStyles(styles);
-    }
 }
 exports.MutableAsset = MutableAsset;
 _MutableAsset_asset = new WeakMap();

package/dist/requests/AssetGraphRequestRust.js

@@ -180,8 +180,7 @@ function getAssetGraph(serializedGraph) {
             });
         }
         else if (node.type === 'dependency') {
-            let id = node.value.id;
-            let dependency = node.value.dependency;
+            let { dependency, id } = node.value;
             dependency.id = id;
             dependency.env.id = (0, feature_flags_1.getFeatureFlag)('environmentDeduplication')
                 ? // TODO: Rust can do this and avoid copying a significant amount of data over

package/dist/requests/BundleGraphRequest.js

@@ -142,7 +142,11 @@ function createBundleGraphRequest(input) {
             //       force: true,
             //     },
             //   );
-            //   require('./asset-graph-diff.js')(jsAssetGraph, assetGraph);
+            //   require('./asset-graph-diff.ts')(
+            //     jsAssetGraph,
+            //     assetGraph,
+            //     options.projectRoot,
+            //   );
             // }
             measurement && measurement.end();
             (0, utils_2.assertSignalNotAborted)(signal);

package/dist/requests/TargetRequest.js

@@ -887,6 +887,7 @@ class TargetResolver {
                                 : descriptor.optimize !== false),
                         shouldScopeHoist: shouldScopeHoist && descriptor.scopeHoist !== false,
                         sourceMap: normalizeSourceMap(this.options, descriptor.sourceMap),
+                        customEnv: descriptor.env,
                     }),
                     loc: (0, utils_2.toInternalSourceLocation)(this.options.projectRoot, loc),
                 });

package/dist/requests/asset-graph-diff.js

@@ -67,7 +67,7 @@ function compactDeep(obj, ignoredPatterns = [], currentPath = '$') {
         return obj;
     }
 }
-function assetGraphDiff(jsAssetGraph, rustAssetGraph) {
+function assetGraphDiff(jsAssetGraph, rustAssetGraph, projectRoot) {
     const getNodes = (graph) => {
         let nodes = {};
         // @ts-expect-error implicit any
@@ -76,11 +76,13 @@ function assetGraphDiff(jsAssetGraph, rustAssetGraph) {
             if (!node)
                 return;
             if (node.type === 'dependency') {
-                let sourcePath = node.value.sourcePath ?? (0, projectPath_1.toProjectPath)('', 'entry');
-                nodes[`dep:${(0, projectPath_1.fromProjectPathRelative)(sourcePath)}:${node.value.specifier}`] = filterNode(node);
+                let sourcePath = node.value.sourcePath
+                    ? (0, projectPath_1.toProjectPath)(projectRoot, node.value.sourcePath)
+                    : (0, projectPath_1.toProjectPath)(projectRoot, 'entry');
+                nodes[`dep:${sourcePath}:${node.value.specifier}`] = filterNode(node);
             }
             else if (node.type === 'asset') {
-                nodes[`asset:${(0, projectPath_1.fromProjectPathRelative)(node.value.filePath)}`] =
+                nodes[`asset:${(0, projectPath_1.toProjectPath)(projectRoot, node.value.filePath)}`] =
                     filterNode(node);
             }
         });

package/lib/CommittedAsset.js

@@ -157,8 +157,5 @@ class CommittedAsset {
   getDependencies() {
     return Array.from(this.value.dependencies.values());
   }
-  getCompiledCssStyles() {
-    return this.value.compiledCssStyles;
-  }
 }
 exports.default = CommittedAsset;

package/lib/UncommittedAsset.js

@@ -365,14 +365,5 @@ class UncommittedAsset {
     // @ts-expect-error TS2345
     this.value.id = (0, _assetUtils.createAssetIdFromOptions)(this.value);
   }
-  setCompiledCssStyles(styles) {
-    if (styles.length > 0) {
-      console.log('setCompiledCssStyles', styles);
-    }
-    this.value.compiledCssStyles = styles;
-  }
-  getCompiledCssStyles() {
-    return this.value.compiledCssStyles;
-  }
 }
 exports.default = UncommittedAsset;

package/lib/atlaspack-v3/worker/compat/mutable-asset.js

@@ -59,7 +59,6 @@ class MutableAsset {
     this.symbols = new _assetSymbols.MutableAssetSymbols(asset.symbols);
     this.type = asset.type;
     this.uniqueKey = asset.uniqueKey;
-    this.compiledCssStyles = asset.compiledCssStyles;
     this.#astDirty = false;
     this.#contents = contents;
     this.#inner = asset;
@@ -166,8 +165,5 @@ class MutableAsset {
   invalidateOnBuild() {
     // TODO: Forward invalidations to Rust
   }
-  setCompiledCssStyles(styles) {
-    this.compiledCssStyles = styles;
-  }
 }
 exports.MutableAsset = MutableAsset;

package/lib/public/Asset.js

@@ -124,9 +124,6 @@ class BaseAsset {
   getMapBuffer() {
     return this.#asset.getMapBuffer();
   }
-  getCompiledCssStyles() {
-    return this.#asset.getCompiledCssStyles();
-  }
 }
 class Asset extends BaseAsset {
   // @ts-expect-error TS2564
@@ -268,8 +265,5 @@ class MutableAsset extends BaseAsset {
     });
     this.#asset.updateId();
   }
-  setCompiledCssStyles(styles) {
-    this.#asset.setCompiledCssStyles(styles);
-  }
 }
 exports.MutableAsset = MutableAsset;

package/lib/requests/AssetGraphRequestRust.js

@@ -170,8 +170,10 @@ function getAssetGraph(serializedGraph) {
         value: asset
       });
     } else if (node.type === 'dependency') {
-      let id = node.value.id;
-      let dependency = node.value.dependency;
+      let {
+        dependency,
+        id
+      } = node.value;
       dependency.id = id;
       dependency.env.id = (0, _featureFlags().getFeatureFlag)('environmentDeduplication') ?
       // TODO: Rust can do this and avoid copying a significant amount of data over

package/lib/requests/BundleGraphRequest.js

@@ -178,7 +178,11 @@ function createBundleGraphRequest(input) {
       //       force: true,
       //     },
       //   );
-      //   require('./asset-graph-diff.js')(jsAssetGraph, assetGraph);
+      //   require('./asset-graph-diff.ts')(
+      //     jsAssetGraph,
+      //     assetGraph,
+      //     options.projectRoot,
+      //   );
       // }
 
       measurement && measurement.end();

package/lib/requests/TargetRequest.js

@@ -830,7 +830,8 @@ class TargetResolver {
             // Libraries are not optimized by default, users must explicitly configure this.
             isLibrary ? descriptor.optimize === true : descriptor.optimize !== false),
             shouldScopeHoist: shouldScopeHoist && descriptor.scopeHoist !== false,
-            sourceMap: normalizeSourceMap(this.options, descriptor.sourceMap)
+            sourceMap: normalizeSourceMap(this.options, descriptor.sourceMap),
+            customEnv: descriptor.env
           }),
           loc: (0, _utils2.toInternalSourceLocation)(this.options.projectRoot, loc)
         });

package/lib/requests/asset-graph-diff.js

@@ -77,7 +77,7 @@ function compactDeep(obj, ignoredPatterns = [], currentPath = '$') {
     return obj;
   }
 }
-function assetGraphDiff(jsAssetGraph, rustAssetGraph) {
+function assetGraphDiff(jsAssetGraph, rustAssetGraph, projectRoot) {
   const getNodes = graph => {
     let nodes = {};
 
@@ -86,10 +86,10 @@ function assetGraphDiff(jsAssetGraph, rustAssetGraph) {
       let node = graph.getNode(nodeId) ?? null;
       if (!node) return;
       if (node.type === 'dependency') {
-        let sourcePath = node.value.sourcePath ?? (0, _projectPath.toProjectPath)('', 'entry');
-        nodes[`dep:${(0, _projectPath.fromProjectPathRelative)(sourcePath)}:${node.value.specifier}`] = filterNode(node);
+        let sourcePath = node.value.sourcePath ? (0, _projectPath.toProjectPath)(projectRoot, node.value.sourcePath) : (0, _projectPath.toProjectPath)(projectRoot, 'entry');
+        nodes[`dep:${sourcePath}:${node.value.specifier}`] = filterNode(node);
       } else if (node.type === 'asset') {
-        nodes[`asset:${(0, _projectPath.fromProjectPathRelative)(node.value.filePath)}`] = filterNode(node);
+        nodes[`asset:${(0, _projectPath.toProjectPath)(projectRoot, node.value.filePath)}`] = filterNode(node);
       }
     });
     return nodes;

package/lib/types/CommittedAsset.d.ts

@@ -20,5 +20,4 @@ export default class CommittedAsset {
     getMap(): Promise<SourceMap | null | undefined>;
     getAST(): Promise<AST | null | undefined>;
     getDependencies(): Array<Dependency>;
-    getCompiledCssStyles(): ReadonlyArray<string> | undefined;
 }

package/lib/types/UncommittedAsset.d.ts

@@ -57,7 +57,5 @@ export default class UncommittedAsset {
     getDependencies(): Array<Dependency>;
     createChildAsset(result: TransformerResult, plugin: PackageName, configPath: ProjectPath, configKeyPath?: string): UncommittedAsset;
     updateId(): void;
-    setCompiledCssStyles(styles: string[]): void;
-    getCompiledCssStyles(): ReadonlyArray<string> | undefined;
 }
 export {};

package/lib/types/atlaspack-v3/worker/compat/mutable-asset.d.ts

@@ -22,7 +22,6 @@ export declare class MutableAsset implements IMutableAsset {
     symbols: MutableAssetSymbols;
     type: string;
     uniqueKey: string | null | undefined;
-    compiledCssStyles?: string[];
     get astGenerator(): ASTGenerator | null | undefined;
     set astGenerator(value?: ASTGenerator | null);
     constructor(asset: InnerAsset, contents: Buffer, env: Environment, fs: FileSystem, map: string | null | undefined, projectRoot: string);
@@ -47,5 +46,4 @@ export declare class MutableAsset implements IMutableAsset {
     invalidateOnEnvChange(invalidation: string): void;
     invalidateOnStartup(): void;
     invalidateOnBuild(): void;
-    setCompiledCssStyles(styles: string[]): void;
 }

package/lib/types/public/Asset.d.ts

@@ -35,7 +35,6 @@ declare class BaseAsset {
     getMap(): Promise<SourceMap | null | undefined>;
     getAST(): Promise<AST | null | undefined>;
     getMapBuffer(): Promise<Buffer | null | undefined>;
-    getCompiledCssStyles(): ReadonlyArray<string> | undefined;
 }
 export declare class Asset extends BaseAsset implements IAsset {
     #private;
@@ -71,6 +70,5 @@ export declare class MutableAsset extends BaseAsset implements IMutableAsset {
     setAST(ast: AST): void;
     addURLDependency(url: string, opts: Partial<DependencyOptions>): string;
     setEnvironment(env: EnvironmentOptions): void;
-    setCompiledCssStyles(styles: string[]): void;
 }
 export {};

package/lib/types/types.d.ts

@@ -157,7 +157,6 @@ export type Asset = {
     plugin: PackageName | null | undefined;
     configKeyPath?: string;
     isLargeBlob?: boolean;
-    compiledCssStyles?: string[];
 };
 export type InternalGlob = ProjectPath;
 export type InternalFile = {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@atlaspack/core",
-  "version": "2.25.2-dev-native-compiled-test-712d92d32.0",
+  "version": "2.26.0",
   "license": "(MIT OR Apache-2.0)",
   "publishConfig": {
     "access": "public"
@@ -22,22 +22,22 @@
     "build:lib": "gulp build --gulpfile ../../../gulpfile.js --cwd ."
   },
   "dependencies": {
-    "@atlaspack/build-cache": "2.13.7-dev-native-compiled-test-712d92d32.0",
-    "@atlaspack/cache": "3.2.30-dev-native-compiled-test-712d92d32.0",
-    "@atlaspack/diagnostic": "2.14.5-dev-native-compiled-test-712d92d32.0",
-    "@atlaspack/events": "2.14.5-dev-native-compiled-test-712d92d32.0",
-    "@atlaspack/feature-flags": "2.25.5-dev-native-compiled-test-712d92d32.0",
-    "@atlaspack/fs": "2.15.30-dev-native-compiled-test-712d92d32.0",
-    "@atlaspack/graph": "3.5.24-dev-native-compiled-test-712d92d32.0",
-    "@atlaspack/logger": "2.14.27-dev-native-compiled-test-712d92d32.0",
-    "@atlaspack/package-manager": "2.14.35-dev-native-compiled-test-712d92d32.0",
-    "@atlaspack/plugin": "2.14.35-dev-native-compiled-test-712d92d32.0",
-    "@atlaspack/profiler": "2.14.32-dev-native-compiled-test-712d92d32.0",
-    "@atlaspack/rust": "3.8.3-dev-native-compiled-test-712d92d32.0",
-    "@atlaspack/types": "2.15.25-dev-native-compiled-test-712d92d32.0",
-    "@atlaspack/utils": "3.0.3-dev-native-compiled-test-712d92d32.0",
-    "@atlaspack/workers": "2.14.35-dev-native-compiled-test-712d92d32.0",
     "@mischnic/json-sourcemap": "^0.1.0",
+    "@atlaspack/build-cache": "2.13.6",
+    "@atlaspack/cache": "3.2.30",
+    "@atlaspack/diagnostic": "2.14.4",
+    "@atlaspack/events": "2.14.4",
+    "@atlaspack/feature-flags": "2.25.5",
+    "@atlaspack/fs": "2.15.30",
+    "@atlaspack/graph": "3.5.24",
+    "@atlaspack/logger": "2.14.27",
+    "@atlaspack/package-manager": "2.14.35",
+    "@atlaspack/plugin": "2.14.35",
+    "@atlaspack/profiler": "2.14.32",
+    "@atlaspack/rust": "3.8.3",
+    "@atlaspack/types": "2.15.25",
+    "@atlaspack/utils": "3.0.3",
+    "@atlaspack/workers": "2.14.35",
     "@parcel/source-map": "^2.1.1",
     "base-x": "^3.0.8",
     "browserslist": "^4.6.6",
@@ -50,16 +50,15 @@
     "semver": "^7.5.2"
   },
   "devDependencies": {
-    "@atlaspack/babel-register": "2.14.5-dev-native-compiled-test-712d92d32.0",
+    "@atlaspack/babel-register": "2.14.4",
     "@types/node": ">= 18",
-    "graphviz": "^0.0.9",
-    "jest-diff": "*",
     "rfdc": "1",
+    "jest-diff": "*",
+    "graphviz": "^0.0.9",
     "tempy": "^0.2.1"
   },
   "browser": {
     "./src/serializerCore.js": "./src/serializerCore.browser.js"
   },
-  "type": "commonjs",
-  "gitHead": "712d92d323f25ef36c76ecd254b8f227fe518b89"
+  "type": "commonjs"
 }

package/src/CommittedAsset.ts

@@ -162,8 +162,4 @@ export default class CommittedAsset {
   getDependencies(): Array<Dependency> {
     return Array.from(this.value.dependencies.values());
   }
-
-  getCompiledCssStyles(): ReadonlyArray<string> | undefined {
-    return this.value.compiledCssStyles;
-  }
 }

package/src/UncommittedAsset.ts

@@ -444,15 +444,4 @@ export default class UncommittedAsset {
     // @ts-expect-error TS2345
     this.value.id = createAssetIdFromOptions(this.value);
   }
-
-  setCompiledCssStyles(styles: string[]): void {
-    if (styles.length > 0) {
-      console.log('setCompiledCssStyles', styles);
-    }
-    this.value.compiledCssStyles = styles;
-  }
-
-  getCompiledCssStyles(): ReadonlyArray<string> | undefined {
-    return this.value.compiledCssStyles;
-  }
 }

package/src/atlaspack-v3/worker/compat/mutable-asset.ts

@@ -41,7 +41,6 @@ export class MutableAsset implements IMutableAsset {
   symbols: MutableAssetSymbols;
   type: string;
   uniqueKey: string | null | undefined;
-  compiledCssStyles?: string[];
 
   #astDirty: boolean;
   #ast: AST | null | undefined;
@@ -83,7 +82,6 @@ export class MutableAsset implements IMutableAsset {
     this.symbols = new MutableAssetSymbols(asset.symbols);
     this.type = asset.type;
     this.uniqueKey = asset.uniqueKey;
-    this.compiledCssStyles = asset.compiledCssStyles;
 
     this.#astDirty = false;
     this.#contents = contents;
@@ -208,8 +206,4 @@ export class MutableAsset implements IMutableAsset {
   invalidateOnBuild(): void {
     // TODO: Forward invalidations to Rust
   }
-
-  setCompiledCssStyles(styles: string[]): void {
-    this.compiledCssStyles = styles;
-  }
 }

package/src/atlaspack-v3/worker/worker.ts

@@ -278,7 +278,7 @@ export class AtlaspackWorker {
       );
 
       assert(
-        (result[0] as unknown as MutableAsset) === mutableAsset,
+        result[0] === mutableAsset,
         '[V3] Unimplemented: New asset returned from Node transformer',
       );
 

package/src/public/Asset.ts

@@ -190,10 +190,6 @@ class BaseAsset {
   getMapBuffer(): Promise<Buffer | null | undefined> {
     return this.#asset.getMapBuffer();
   }
-
-  getCompiledCssStyles(): ReadonlyArray<string> | undefined {
-    return this.#asset.getCompiledCssStyles();
-  }
 }
 
 export class Asset extends BaseAsset implements IAsset {
@@ -373,8 +369,4 @@ export class MutableAsset extends BaseAsset implements IMutableAsset {
     });
     this.#asset.updateId();
   }
-
-  setCompiledCssStyles(styles: string[]): void {
-    this.#asset.setCompiledCssStyles(styles);
-  }
 }

package/src/requests/AssetGraphRequestRust.ts

@@ -193,8 +193,7 @@ export function getAssetGraph(serializedGraph: any): {
         value: asset,
       });
     } else if (node.type === 'dependency') {
-      let id = node.value.id;
-      let dependency = node.value.dependency;
+      let {dependency, id} = node.value;
 
       dependency.id = id;
       dependency.env.id = getFeatureFlag('environmentDeduplication')

package/src/requests/BundleGraphRequest.ts

@@ -192,7 +192,11 @@ export default function createBundleGraphRequest(
       //       force: true,
       //     },
       //   );
-      //   require('./asset-graph-diff.js')(jsAssetGraph, assetGraph);
+      //   require('./asset-graph-diff.ts')(
+      //     jsAssetGraph,
+      //     assetGraph,
+      //     options.projectRoot,
+      //   );
       // }
 
       measurement && measurement.end();

package/src/requests/TargetRequest.ts

@@ -1151,6 +1151,7 @@ export class TargetResolver {
             shouldScopeHoist:
               shouldScopeHoist && descriptor.scopeHoist !== false,
             sourceMap: normalizeSourceMap(this.options, descriptor.sourceMap),
+            customEnv: descriptor.env,
           }),
           loc: toInternalSourceLocation(this.options.projectRoot, loc),
         });

package/src/requests/asset-graph-diff.ts

@@ -4,7 +4,7 @@ import deepClone from 'rfdc/default';
 import {diff} from 'jest-diff';
 import AssetGraph from '../AssetGraph';
 import type {AssetGraphNode} from '../types';
-import {fromProjectPathRelative, toProjectPath} from '../projectPath';
+import {toProjectPath} from '../projectPath';
 
 function filterNode(node: any) {
   let clone = deepClone(node);
@@ -71,7 +71,11 @@ function compactDeep(
   }
 }
 
-function assetGraphDiff(jsAssetGraph: AssetGraph, rustAssetGraph: AssetGraph) {
+function assetGraphDiff(
+  jsAssetGraph: AssetGraph,
+  rustAssetGraph: AssetGraph,
+  projectRoot: string,
+) {
   const getNodes = (graph: any) => {
     let nodes: Record<string, any> = {};
 
@@ -81,12 +85,12 @@ function assetGraphDiff(jsAssetGraph: AssetGraph, rustAssetGraph: AssetGraph) {
       if (!node) return;
 
       if (node.type === 'dependency') {
-        let sourcePath = node.value.sourcePath ?? toProjectPath('', 'entry');
-        nodes[
-          `dep:${fromProjectPathRelative(sourcePath)}:${node.value.specifier}`
-        ] = filterNode(node);
+        let sourcePath = node.value.sourcePath
+          ? toProjectPath(projectRoot, node.value.sourcePath)
+          : toProjectPath(projectRoot, 'entry');
+        nodes[`dep:${sourcePath}:${node.value.specifier}`] = filterNode(node);
       } else if (node.type === 'asset') {
-        nodes[`asset:${fromProjectPathRelative(node.value.filePath)}`] =
+        nodes[`asset:${toProjectPath(projectRoot, node.value.filePath)}`] =
           filterNode(node);
       }
     });

package/src/types.ts

@@ -226,7 +226,6 @@ export type Asset = {
   plugin: PackageName | null | undefined;
   configKeyPath?: string;
   isLargeBlob?: boolean;
-  compiledCssStyles?: string[];
 };
 
 export type InternalGlob = ProjectPath;

package/test/TargetRequest.test.ts

@@ -382,6 +382,9 @@ describe('TargetResolver', () => {
             loc: undefined,
             sourceType: 'module',
             unstableSingleFileOutput: false,
+            customEnv: {
+              useFlag: 'false',
+            },
           }),
           loc: {
             filePath: relative(
@@ -416,6 +419,9 @@ describe('TargetResolver', () => {
             loc: undefined,
             sourceType: 'module',
             unstableSingleFileOutput: false,
+            customEnv: {
+              useFlag: 'true',
+            },
           }),
           loc: {
             filePath: relative(
@@ -501,6 +507,9 @@ describe('TargetResolver', () => {
             loc: undefined,
             sourceType: 'module',
             unstableSingleFileOutput: false,
+            customEnv: {
+              useFlag: 'false',
+            },
           }),
           loc: {
             filePath: relative(
@@ -535,6 +544,9 @@ describe('TargetResolver', () => {
             loc: undefined,
             sourceType: 'module',
             unstableSingleFileOutput: false,
+            customEnv: {
+              useFlag: 'true',
+            },
           }),
           loc: {
             filePath: relative(

package/test/fixtures/custom-targets/package.json

@@ -9,11 +9,17 @@
     "browserModern": {
       "engines": {
         "browsers": ["last 1 version"]
+      },
+      "env": {
+        "useFlag": "false"
       }
     },
     "browserLegacy": {
       "engines": {
         "browsers": ["ie11"]
+      },
+      "env": {
+        "useFlag": "true"
       }
     }
   }