@atlaspack/core 2.23.6-dev-export-func-opt-b714be46e.0 → 2.24.0

package/CHANGELOG.md

@@ -1,5 +1,35 @@
 # @atlaspack/core
 
+## 2.24.0
+
+### Minor Changes
+
+- [#767](https://github.com/atlassian-labs/atlaspack/pull/767) [`038e87a`](https://github.com/atlassian-labs/atlaspack/commit/038e87a7858d39556d59d3a2d17db534d45f62c6) Thanks [@marcins](https://github.com/marcins)! - Implement a new feature `allowExplicitTargetEntries` where entries provided as entries can be filtered by the source property in targets to allow different targets to be built for different subsets of entries.
+
+- [#769](https://github.com/atlassian-labs/atlaspack/pull/769) [`f6532d7`](https://github.com/atlassian-labs/atlaspack/commit/f6532d7a4f7f007bd4e5e36af04dd466f0b9f572) Thanks [@marcins](https://github.com/marcins)! - Adds a new feature to support adding custom `env` properties in a target, that are available in the Environment during the build. A new feature flag `customEnvInTargets` has been added to gate this feature.
+
+### Patch Changes
+
+- [#780](https://github.com/atlassian-labs/atlaspack/pull/780) [`eedcbc4`](https://github.com/atlassian-labs/atlaspack/commit/eedcbc408fc1e86a2a8e25f1a41c57146d8529e1) Thanks [@JakeLane](https://github.com/JakeLane)! - Fix isStaticBindingSafe in v3
+
+- [#776](https://github.com/atlassian-labs/atlaspack/pull/776) [`5a0363f`](https://github.com/atlassian-labs/atlaspack/commit/5a0363f1086e81068959b87e92064bed5a11a9b4) Thanks [@benjervis](https://github.com/benjervis)! - Guard against empty buffers being returned from JS workers, when using the V3 asset graph build
+
+- [#771](https://github.com/atlassian-labs/atlaspack/pull/771) [`8604d2a`](https://github.com/atlassian-labs/atlaspack/commit/8604d2a49ace5e9194ec4f76e71f06b93610f6b4) Thanks [@benjervis](https://github.com/benjervis)! - Fixes a small error with inline bundle packaging resulting from an incorrect comparison.
+
+- Updated dependencies [[`7a52bab`](https://github.com/atlassian-labs/atlaspack/commit/7a52bab6281e8edbfa66af248eb6f872c6b4b7bd), [`eedcbc4`](https://github.com/atlassian-labs/atlaspack/commit/eedcbc408fc1e86a2a8e25f1a41c57146d8529e1), [`5a0363f`](https://github.com/atlassian-labs/atlaspack/commit/5a0363f1086e81068959b87e92064bed5a11a9b4), [`038e87a`](https://github.com/atlassian-labs/atlaspack/commit/038e87a7858d39556d59d3a2d17db534d45f62c6), [`f6532d7`](https://github.com/atlassian-labs/atlaspack/commit/f6532d7a4f7f007bd4e5e36af04dd466f0b9f572), [`0684997`](https://github.com/atlassian-labs/atlaspack/commit/0684997c127a6204af1376b36e556fddd1ba5557), [`602f8ed`](https://github.com/atlassian-labs/atlaspack/commit/602f8ed9d8381301df8b2cc82c1d5cf6f2f94fec)]:
+  - @atlaspack/feature-flags@2.25.0
+  - @atlaspack/rust@3.8.0
+  - @atlaspack/cache@3.2.25
+  - @atlaspack/fs@2.15.25
+  - @atlaspack/graph@3.5.19
+  - @atlaspack/utils@2.19.2
+  - @atlaspack/logger@2.14.22
+  - @atlaspack/plugin@2.14.30
+  - @atlaspack/profiler@2.14.27
+  - @atlaspack/types@2.15.20
+  - @atlaspack/workers@2.14.30
+  - @atlaspack/package-manager@2.14.30
+
 ## 2.23.5
 
 ### Patch Changes

package/lib/AssetGraph.js

@@ -287,9 +287,7 @@ class AssetGraph extends _graph().ContentGraph {
       }));
       if ((0, _EnvironmentManager.fromEnvironmentId)(node.value.env).isLibrary) {
         // in library mode, all of the entry's symbols are "used"
-        // @ts-expect-error TS2345
         node.usedSymbolsDown.add('*');
-        // @ts-expect-error TS2345
         node.usedSymbolsUp.set('*', undefined);
       }
       return node;
@@ -410,9 +408,7 @@ class AssetGraph extends _graph().ContentGraph {
     }
     let isDeferrable = [...dependencySymbols].every(([, {
       isWeak
-    }]) => isWeak) && sideEffects === false && canDefer &&
-    // @ts-expect-error TS2345
-    !dependencySymbols.has('*');
+    }]) => isWeak) && sideEffects === false && canDefer && !dependencySymbols.has('*');
     if (!isDeferrable) {
       return false;
     }
@@ -438,9 +434,7 @@ class AssetGraph extends _graph().ContentGraph {
       if (this.undeferredDependencies.has(d)) {
         return false;
       }
-      let depIsDeferrable = d.symbols && !((0, _EnvironmentManager.fromEnvironmentId)(d.env).isLibrary && d.isEntry) &&
-      // @ts-expect-error TS2345
-      !d.symbols.has('*') && ![...d.symbols.keys()].some(symbol => {
+      let depIsDeferrable = d.symbols && !((0, _EnvironmentManager.fromEnvironmentId)(d.env).isLibrary && d.isEntry) && !d.symbols.has('*') && ![...d.symbols.keys()].some(symbol => {
         var _resolvedAsset$symbol;
         let assetSymbol = (_resolvedAsset$symbol = resolvedAsset.symbols) === null || _resolvedAsset$symbol === void 0 || (_resolvedAsset$symbol = _resolvedAsset$symbol.get(symbol)) === null || _resolvedAsset$symbol === void 0 ? void 0 : _resolvedAsset$symbol.local;
         return assetSymbol != null && symbols.has(assetSymbol);

package/lib/BundleGraph.js

@@ -237,7 +237,6 @@ class BundleGraph {
         // It doesn't make sense to retarget dependencies where `*` is used, because the
         // retargeting won't enable any benefits in that case (apart from potentially even more
         // code being generated).
-        // @ts-expect-error TS2345
         !node.usedSymbolsUp.has('*') &&
         // TODO We currently can't rename imports in async imports, e.g. from
         //      (parcelRequire("...")).then(({ a }) => a);
@@ -252,11 +251,8 @@ class BundleGraph {
         // (and the asset content itself).
         [...targets].every(([, t]) => new Set([...t.values()]).size === t.size)) {
           var _nodeValueSymbols$get;
-          // @ts-expect-error TS2367
           let isReexportAll = ((_nodeValueSymbols$get = nodeValueSymbols.get('*')) === null || _nodeValueSymbols$get === void 0 ? void 0 : _nodeValueSymbols$get.local) === '*';
-          let reexportAllLoc = isReexportAll ?
-          // @ts-expect-error TS2345
-          (0, _nullthrows().default)(nodeValueSymbols.get('*')).loc : undefined;
+          let reexportAllLoc = isReexportAll ? (0, _nullthrows().default)(nodeValueSymbols.get('*')).loc : undefined;
 
           // TODO adjust sourceAssetIdNode.value.dependencies ?
           let deps = [
@@ -313,7 +309,6 @@ class BundleGraph {
                       (0, _assert().default)(!sourceAssetSymbols.has(as));
                       sourceAssetSymbols.set(as, {
                         loc: reexportAllLoc,
-                        // @ts-expect-error TS2322
                         local: local
                       });
                     }
@@ -1198,7 +1193,6 @@ class BundleGraph {
     var _asset$symbols;
     let assetOutside = boundary && !this.bundleHasAsset(boundary, asset);
     let identifier = (_asset$symbols = asset.symbols) === null || _asset$symbols === void 0 || (_asset$symbols = _asset$symbols.get(symbol)) === null || _asset$symbols === void 0 ? void 0 : _asset$symbols.local;
-    // @ts-expect-error TS2367
     if (symbol === '*') {
       var _asset$symbols2;
       return {
@@ -1230,7 +1224,6 @@ class BundleGraph {
           // External module or self-reference
           return {
             asset,
-            // @ts-expect-error TS2322
             exportSymbol: symbol,
             symbol: identifier,
             loc: (_asset$symbols3 = asset.symbols) === null || _asset$symbols3 === void 0 || (_asset$symbols3 = _asset$symbols3.get(symbol)) === null || _asset$symbols3 === void 0 ? void 0 : _asset$symbols3.loc
@@ -1267,11 +1260,7 @@ class BundleGraph {
       // If this module exports wildcards, resolve the original module.
       // Default exports are excluded from wildcard exports.
       // Wildcard reexports are never listed in the reexporting asset's symbols.
-      if (identifier == null &&
-      // @ts-expect-error TS2367
-      ((_depSymbols$get = depSymbols.get('*')) === null || _depSymbols$get === void 0 ? void 0 : _depSymbols$get.local) === '*' &&
-      // @ts-expect-error TS2367
-      symbol !== 'default') {
+      if (identifier == null && ((_depSymbols$get = depSymbols.get('*')) === null || _depSymbols$get === void 0 ? void 0 : _depSymbols$get.local) === '*' && symbol !== 'default') {
         let resolved = this.getResolvedAsset(dep, boundary);
         if (!resolved) {
           continue;
@@ -1350,7 +1339,6 @@ class BundleGraph {
         } else if (result === undefined) {
           var _asset$symbols5;
           // If not exported explicitly by the asset (= would have to be in * or a reexport-all) ...
-          // @ts-expect-error TS2345
           if (nonStaticDependency || (_asset$symbols5 = asset.symbols) !== null && _asset$symbols5 !== void 0 && _asset$symbols5.has('*')) {
             // ... and if there are non-statically analyzable dependencies or it's a CJS asset,
             // fallback to namespace access.
@@ -1364,7 +1352,6 @@ class BundleGraph {
 
       return {
         asset,
-        // @ts-expect-error TS2322
         exportSymbol: symbol,
         symbol: result,
         loc: (_asset$symbols6 = asset.symbols) === null || _asset$symbols6 === void 0 || (_asset$symbols6 = _asset$symbols6.get(symbol)) === null || _asset$symbols6 === void 0 ? void 0 : _asset$symbols6.loc
@@ -1403,8 +1390,6 @@ class BundleGraph {
       var _depSymbols$get2;
       let depSymbols = dep.symbols;
       if (!depSymbols) continue;
-
-      // @ts-expect-error TS2367
       if (((_depSymbols$get2 = depSymbols.get('*')) === null || _depSymbols$get2 === void 0 ? void 0 : _depSymbols$get2.local) === '*') {
         let resolved = this.getResolvedAsset(dep, boundary);
         if (!resolved) continue;

package/lib/SymbolPropagation.js

@@ -82,7 +82,6 @@ function propagateSymbols({
       if ((0, _featureFlags().getFeatureFlag)('emptyFileStarRexportFix')) {
         if (assetNode.value.meta.emptyFileStarReexport && incomingDeps.every(d => d.value.specifierType === _types.SpecifierType.esm)) {
           var _assetNode$value$symb;
-          // @ts-expect-error TS2345
           (_assetNode$value$symb = assetNode.value.symbols) === null || _assetNode$value$symb === void 0 || _assetNode$value$symb.delete('*');
         }
       }
@@ -104,9 +103,7 @@ function propagateSymbols({
           set.add(s);
         }
       }
-      let hasNamespaceOutgoingDeps = outgoingDeps.some(
-      // @ts-expect-error TS2367
-      d => {
+      let hasNamespaceOutgoingDeps = outgoingDeps.some(d => {
         var _d$value$symbols;
         return ((_d$value$symbols = d.value.symbols) === null || _d$value$symbols === void 0 || (_d$value$symbols = _d$value$symbols.get('*')) === null || _d$value$symbols === void 0 ? void 0 : _d$value$symbols.local) === '*';
       });
@@ -124,9 +121,7 @@ function propagateSymbols({
       let namespaceReexportedSymbols = new Set();
       if (incomingDeps.length === 0) {
         // Root in the runtimes Graph
-        // @ts-expect-error TS2345
         assetNode.usedSymbols.add('*');
-        // @ts-expect-error TS2345
         namespaceReexportedSymbols.add('*');
       } else {
         for (let incomingDep of incomingDeps) {
@@ -141,16 +136,11 @@ function propagateSymbols({
             continue;
           }
           for (let exportSymbol of incomingDep.usedSymbolsDown) {
-            // @ts-expect-error TS2367
             if (exportSymbol === '*') {
-              // @ts-expect-error TS2345
               assetNode.usedSymbols.add('*');
-              // @ts-expect-error TS2345
               namespaceReexportedSymbols.add('*');
             }
-            if (!assetSymbols || assetSymbols.has(exportSymbol) ||
-            // @ts-expect-error TS2345
-            assetSymbols.has('*')) {
+            if (!assetSymbols || assetSymbols.has(exportSymbol) || assetSymbols.has('*')) {
               // An own symbol or a non-namespace reexport
               assetNode.usedSymbols.add(exportSymbol);
             }
@@ -158,7 +148,6 @@ function propagateSymbols({
             // (but only if we actually have namespace-exporting outgoing dependencies,
             // This usually happens with a reexporting asset with many namespace exports which means that
             // we cannot match up the correct asset with the used symbol at this level.)
-            // @ts-expect-error TS2367
             else if (hasNamespaceOutgoingDeps && exportSymbol !== 'default') {
               namespaceReexportedSymbols.add(exportSymbol);
             }
@@ -192,8 +181,6 @@ function propagateSymbols({
           var _depSymbols$get;
           let depSymbols = dep.value.symbols;
           if (!depSymbols) continue;
-
-          // @ts-expect-error TS2367
           if (((_depSymbols$get = depSymbols.get('*')) === null || _depSymbols$get === void 0 ? void 0 : _depSymbols$get.local) === '*') {
             if (addAll) {
               depUsedSymbolsDown.add('*');
@@ -209,7 +196,6 @@ function propagateSymbols({
           }] of depSymbols) {
             var _depSymbols$get2;
             // Was already handled above
-            // @ts-expect-error TS2367
             if (local === '*') continue;
             if (!assetSymbolsInverse || !((_depSymbols$get2 = depSymbols.get(symbol)) !== null && _depSymbols$get2 !== void 0 && _depSymbols$get2.isWeak)) {
               // Bailout or non-weak symbol (= used in the asset itself = not a reexport)
@@ -219,7 +205,6 @@ function propagateSymbols({
               if (reexportedExportSymbols == null) {
                 // not reexported = used in asset itself
                 depUsedSymbolsDown.add(symbol);
-                // @ts-expect-error TS2345
               } else if (assetNode.usedSymbols.has('*')) {
                 // we need everything
                 depUsedSymbolsDown.add(symbol);
@@ -251,9 +236,7 @@ function propagateSymbols({
     const logFallbackNamespaceInsertion = (assetNode, symbol, depNode1, depNode2) => {
       if (options.logLevel === 'verbose') {
         _logger().default.warn({
-          message: `${(0, _projectPath.fromProjectPathRelative)(assetNode.value.filePath
-          // @ts-expect-error TS2731
-          )} reexports "${symbol}", which could be resolved either to the dependency "${depNode1.value.specifier}" or "${depNode2.value.specifier}" at runtime. Adding a namespace object to fall back on.`,
+          message: `${(0, _projectPath.fromProjectPathRelative)(assetNode.value.filePath)} reexports "${symbol}", which could be resolved either to the dependency "${depNode1.value.specifier}" or "${depNode2.value.specifier}" at runtime. Adding a namespace object to fall back on.`,
           origin: '@atlaspack/core'
         });
       }
@@ -293,11 +276,8 @@ function propagateSymbols({
         if (isExcluded) {
           outgoingDep.usedSymbolsDown.forEach((_, s) => outgoingDep.usedSymbolsUp.set(s, null));
         }
-
-        // @ts-expect-error TS2367
         if (((_outgoingDepSymbols$g = outgoingDepSymbols.get('*')) === null || _outgoingDepSymbols$g === void 0 ? void 0 : _outgoingDepSymbols$g.local) === '*') {
           outgoingDep.usedSymbolsUp.forEach((sResolved, s) => {
-            // @ts-expect-error TS2367
             if (s === 'default') {
               return;
             }
@@ -305,11 +285,9 @@ function propagateSymbols({
             // If the symbol could come from multiple assets at runtime, assetNode's
             // namespace will be needed at runtime to perform the lookup on.
             if (reexportedSymbols.has(s)) {
-              // @ts-expect-error TS2345
               if (!assetNode.usedSymbols.has('*')) {
                 logFallbackNamespaceInsertion(assetNode, s, (0, _nullthrows().default)(reexportedSymbolsSource.get(s)), outgoingDep);
               }
-              // @ts-expect-error TS2345
               assetNode.usedSymbols.add('*');
               reexportedSymbols.set(s, {
                 asset: assetNode.id,
@@ -337,11 +315,9 @@ function propagateSymbols({
             reexported.forEach(s => {
               // see same code above
               if (reexportedSymbols.has(s)) {
-                // @ts-expect-error TS2345
                 if (!assetNode.usedSymbols.has('*')) {
                   logFallbackNamespaceInsertion(assetNode, s, (0, _nullthrows().default)(reexportedSymbolsSource.get(s)), outgoingDep);
                 }
-                // @ts-expect-error TS2345
                 assetNode.usedSymbols.add('*');
                 reexportedSymbols.set(s, {
                   asset: assetNode.id,
@@ -373,15 +349,11 @@ function propagateSymbols({
         incomingDep.usedSymbolsUp = new Map();
         let incomingDepSymbols = incomingDep.value.symbols;
         if (!incomingDepSymbols) continue;
-
-        // @ts-expect-error TS2367
         let hasNamespaceReexport = ((_incomingDepSymbols$g = incomingDepSymbols.get('*')) === null || _incomingDepSymbols$g === void 0 ? void 0 : _incomingDepSymbols$g.local) === '*';
         for (let s of incomingDep.usedSymbolsDown) {
           if (assetSymbols == null ||
           // Assume everything could be provided if symbols are cleared
-          assetNode.value.bundleBehavior === _types.BundleBehavior.isolated || assetNode.value.bundleBehavior === _types.BundleBehavior.inline ||
-          // @ts-expect-error TS2367
-          s === '*' || assetNode.usedSymbols.has(s)) {
+          assetNode.value.bundleBehavior === _types.BundleBehavior.isolated || assetNode.value.bundleBehavior === _types.BundleBehavior.inline || s === '*' || assetNode.usedSymbols.has(s)) {
             usedSymbolsUpAmbiguous(incomingDepUsedSymbolsUpOld, incomingDep.usedSymbolsUp, s, {
               asset: assetNode.id,
               symbol: s

package/lib/atlaspack-v3/worker/compat/asset-symbols.js

@@ -4,8 +4,6 @@ Object.defineProperty(exports, "__esModule", {
   value: true
 });
 exports.MutableDependencySymbols = exports.MutableAssetSymbols = exports.AssetSymbols = void 0;
-// @ts-expect-error TS2305
-
 class MutableDependencySymbols {
   #symbols;
   #locals;
@@ -124,10 +122,12 @@ class MutableAssetSymbols {
       loc,
       local,
       isEsmExport,
-      selfReferenced
+      selfReferenced,
+      isStaticBindingSafe
     } of inner || []) {
       this.set(exported, local, loc, {
         isEsm: isEsmExport,
+        isStaticBindingSafe,
         selfReferenced
       });
     }

package/lib/public/Symbols.js

@@ -45,41 +45,28 @@ class AssetSymbols {
     valueToSymbols.set(asset, this);
     return this;
   }
-
-  // @ts-expect-error TS2416
   hasExportSymbol(exportSymbol) {
     var _this$value$symbols;
-    // @ts-expect-error TS2345
     return Boolean((_this$value$symbols = this.#value.symbols) === null || _this$value$symbols === void 0 ? void 0 : _this$value$symbols.has(exportSymbol));
   }
-
-  // @ts-expect-error TS2416
   hasLocalSymbol(local) {
     if (this.#value.symbols == null) {
       return false;
     }
     for (let s of this.#value.symbols.values()) {
-      // @ts-expect-error TS2367
       if (local === s.local) return true;
     }
     return false;
   }
-
-  // @ts-expect-error TS2416
   get(exportSymbol) {
     var _this$value$symbols2;
-    // @ts-expect-error TS2322
-    return fromInternalAssetSymbol(this.#options.projectRoot, // @ts-expect-error TS2345
-    (_this$value$symbols2 = this.#value.symbols) === null || _this$value$symbols2 === void 0 ? void 0 : _this$value$symbols2.get(exportSymbol));
+    return fromInternalAssetSymbol(this.#options.projectRoot, (_this$value$symbols2 = this.#value.symbols) === null || _this$value$symbols2 === void 0 ? void 0 : _this$value$symbols2.get(exportSymbol));
   }
   get isCleared() {
     return this.#value.symbols == null;
   }
-
-  // @ts-expect-error TS2416
   exportSymbols() {
     var _this$value$symbols3;
-    // @ts-expect-error TS2322
     return ((_this$value$symbols3 = this.#value.symbols) === null || _this$value$symbols3 === void 0 ? void 0 : _this$value$symbols3.keys()) ?? [];
   }
   // @ts-expect-error TS2416
@@ -114,37 +101,26 @@ class MutableAssetSymbols {
 
   // immutable
 
-  // @ts-expect-error TS2416
   hasExportSymbol(exportSymbol) {
     var _this$value$symbols4;
-    // @ts-expect-error TS2345
     return Boolean((_this$value$symbols4 = this.#value.symbols) === null || _this$value$symbols4 === void 0 ? void 0 : _this$value$symbols4.has(exportSymbol));
   }
-
-  // @ts-expect-error TS2416
   hasLocalSymbol(local) {
     if (this.#value.symbols == null) {
       return false;
     }
     for (let s of this.#value.symbols.values()) {
-      // @ts-expect-error TS2367
       if (local === s.local) return true;
     }
     return false;
   }
-
-  // @ts-expect-error TS2416
   get(exportSymbol) {
     var _this$value$symbols5;
-    // @ts-expect-error TS2322
-    return fromInternalAssetSymbol(this.#options.projectRoot, // @ts-expect-error TS2345
-    (_this$value$symbols5 = this.#value.symbols) === null || _this$value$symbols5 === void 0 ? void 0 : _this$value$symbols5.get(exportSymbol));
+    return fromInternalAssetSymbol(this.#options.projectRoot, (_this$value$symbols5 = this.#value.symbols) === null || _this$value$symbols5 === void 0 ? void 0 : _this$value$symbols5.get(exportSymbol));
   }
   get isCleared() {
     return this.#value.symbols == null;
   }
-
-  // @ts-expect-error TS2416
   exportSymbols() {
     // @ts-expect-error TS2322
     return this.#value.symbols.keys();
@@ -166,20 +142,14 @@ class MutableAssetSymbols {
       this.#value.symbols = new Map();
     }
   }
-
-  // @ts-expect-error TS2416
   set(exportSymbol, local, loc, meta) {
-    // @ts-expect-error TS2345
     (0, _nullthrows().default)(this.#value.symbols).set(exportSymbol, {
       local,
       loc: (0, _utils.toInternalSourceLocation)(this.#options.projectRoot, loc),
       meta
     });
   }
-
-  // @ts-expect-error TS2416
   delete(exportSymbol) {
-    // @ts-expect-error TS2345
     (0, _nullthrows().default)(this.#value.symbols).delete(exportSymbol);
   }
 }
@@ -205,36 +175,24 @@ class MutableDependencySymbols {
 
   // immutable:
 
-  // @ts-expect-error TS2416
   hasExportSymbol(exportSymbol) {
     var _this$value$symbols6;
-    // @ts-expect-error TS2345
     return Boolean((_this$value$symbols6 = this.#value.symbols) === null || _this$value$symbols6 === void 0 ? void 0 : _this$value$symbols6.has(exportSymbol));
   }
-
-  // @ts-expect-error TS2416
   hasLocalSymbol(local) {
     if (this.#value.symbols) {
       for (let s of this.#value.symbols.values()) {
-        // @ts-expect-error TS2367
         if (local === s.local) return true;
       }
     }
     return false;
   }
-
-  // @ts-expect-error TS2416
   get(exportSymbol) {
-    // @ts-expect-error TS2322
-    return fromInternalDependencySymbol(this.#options.projectRoot,
-    // @ts-expect-error TS2345
-    (0, _nullthrows().default)(this.#value.symbols).get(exportSymbol));
+    return fromInternalDependencySymbol(this.#options.projectRoot, (0, _nullthrows().default)(this.#value.symbols).get(exportSymbol));
   }
   get isCleared() {
     return this.#value.symbols == null;
   }
-
-  // @ts-expect-error TS2416
   exportSymbols() {
     // @ts-expect-error TS2322
     return this.#value.symbols ? this.#value.symbols.keys() : EMPTY_ITERABLE;
@@ -258,23 +216,16 @@ class MutableDependencySymbols {
       this.#value.symbols = new Map();
     }
   }
-
-  // @ts-expect-error TS2416
   set(exportSymbol, local, loc, isWeak) {
     var _symbols$get;
     let symbols = (0, _nullthrows().default)(this.#value.symbols);
-    // @ts-expect-error TS2345
     symbols.set(exportSymbol, {
       local,
       loc: (0, _utils.toInternalSourceLocation)(this.#options.projectRoot, loc),
-      // @ts-expect-error TS2345
       isWeak: (((_symbols$get = symbols.get(exportSymbol)) === null || _symbols$get === void 0 ? void 0 : _symbols$get.isWeak) ?? true) && (isWeak ?? false)
     });
   }
-
-  // @ts-expect-error TS2416
   delete(exportSymbol) {
-    // @ts-expect-error TS2345
     (0, _nullthrows().default)(this.#value.symbols).delete(exportSymbol);
   }
 }

package/lib/types/BundleGraph.d.ts

@@ -1,4 +1,4 @@
-import type { GraphVisitor, FilePath, TraversalActions, BundleBehavior as IBundleBehavior } from '@atlaspack/types';
+import type { GraphVisitor, FilePath, TraversalActions, BundleBehavior as IBundleBehavior, Symbol } from '@atlaspack/types';
 import type { ContentGraphOpts, NodeId, SerializedContentGraph } from '@atlaspack/graph';
 import type { Asset, AssetNode, Bundle, BundleGraphNode, BundleGroup, Dependency, DependencyNode, InternalSourceLocation, Target, Condition } from './types';
 import type AssetGraph from './AssetGraph';
@@ -17,11 +17,11 @@ export type BundleGraphEdgeType = (typeof bundleGraphEdgeTypes)[keyof typeof bun
 type InternalSymbolResolution = {
     asset: Asset;
     exportSymbol: string;
-    symbol: symbol | null | undefined | false;
+    symbol: Symbol | null | undefined | false;
     loc: InternalSourceLocation | null | undefined;
 };
 type InternalExportSymbolResolution = InternalSymbolResolution & {
-    readonly exportAs: symbol | string;
+    readonly exportAs: Symbol | string;
 };
 type BundleGraphOpts = {
     graph: ContentGraphOpts<BundleGraphNode, BundleGraphEdgeType>;
@@ -159,7 +159,7 @@ export default class BundleGraph {
     bundleHasAsset(bundle: Bundle, asset: Asset): boolean;
     bundleHasDependency(bundle: Bundle, dependency: Dependency): boolean;
     filteredTraverse<TValue, TContext>(bundleNodeId: NodeId, filter: (arg1: NodeId, arg2: TraversalActions) => TValue | null | undefined, visit: GraphVisitor<TValue, TContext>): TContext | null | undefined;
-    getSymbolResolution(asset: Asset, symbol: symbol, boundary?: Bundle | null): InternalSymbolResolution;
+    getSymbolResolution(asset: Asset, symbol: Symbol, boundary?: Bundle | null): InternalSymbolResolution;
     getAssetById(contentKey: string): Asset;
     getAssetPublicId(asset: Asset): string;
     getExportedSymbols(asset: Asset, boundary?: Bundle | null): Array<InternalExportSymbolResolution>;
@@ -168,8 +168,8 @@ export default class BundleGraph {
     getHash(bundle: Bundle): string;
     getBundleGraphHash(): string;
     addBundleToBundleGroup(bundle: Bundle, bundleGroup: BundleGroup): void;
-    getUsedSymbolsAsset(asset: Asset): ReadonlySet<symbol> | null | undefined;
-    getUsedSymbolsDependency(dep: Dependency): ReadonlySet<symbol> | null | undefined;
+    getUsedSymbolsAsset(asset: Asset): ReadonlySet<Symbol> | null | undefined;
+    getUsedSymbolsDependency(dep: Dependency): ReadonlySet<Symbol> | null | undefined;
     merge(other: BundleGraph): void;
     isEntryBundleGroup(bundleGroup: BundleGroup): boolean;
     /**

package/lib/types/atlaspack-v3/worker/compat/asset-symbols.d.ts

@@ -1,26 +1,26 @@
 import type { Symbol as NapiSymbol } from '@atlaspack/rust';
-import type { AssetSymbols as IAssetSymbols, MutableAssetSymbols as IMutableAssetSymbols, MutableDependencySymbols as IMutableDependencySymbols, SourceLocation, Meta } from '@atlaspack/types';
+import type { AssetSymbols as IAssetSymbols, MutableAssetSymbols as IMutableAssetSymbols, MutableDependencySymbols as IMutableDependencySymbols, Symbol, SourceLocation, Meta } from '@atlaspack/types';
 export declare class MutableDependencySymbols implements IMutableDependencySymbols {
     #private;
     get isCleared(): boolean;
     constructor(inner: NapiSymbol[] | null | undefined | null);
     ensure(): void;
-    get(exportSymbol: symbol): DependencyAssetSymbol | null | undefined;
-    hasExportSymbol(exportSymbol: symbol): boolean;
-    hasLocalSymbol(local: symbol): boolean;
-    exportSymbols(): Iterable<symbol>;
-    set(exportSymbol: symbol, local: symbol, loc?: SourceLocation | null, isWeak?: boolean | null): void;
-    delete(exportSymbol: symbol): void;
+    get(exportSymbol: Symbol): DependencyAssetSymbol | null | undefined;
+    hasExportSymbol(exportSymbol: Symbol): boolean;
+    hasLocalSymbol(local: Symbol): boolean;
+    exportSymbols(): Iterable<Symbol>;
+    set(exportSymbol: Symbol, local: Symbol, loc?: SourceLocation | null, isWeak?: boolean | null): void;
+    delete(exportSymbol: Symbol): void;
     [Symbol.iterator](): MapIterator<DependencyAssetSymbol>;
 }
 export declare class AssetSymbols implements IAssetSymbols {
     #private;
     get isCleared(): boolean;
     constructor(inner: NapiSymbol[] | null | undefined | null);
-    get(exportSymbol: symbol): AssetSymbol | null | undefined;
-    hasExportSymbol(exportSymbol: symbol): boolean;
-    hasLocalSymbol(local: symbol): boolean;
-    exportSymbols(): Iterable<symbol>;
+    get(exportSymbol: Symbol): AssetSymbol | null | undefined;
+    hasExportSymbol(exportSymbol: Symbol): boolean;
+    hasLocalSymbol(local: Symbol): boolean;
+    exportSymbols(): Iterable<Symbol>;
     intoNapi(): NapiSymbol[];
     [Symbol.iterator](): MapIterator<AssetSymbol>;
 }
@@ -30,21 +30,21 @@ export declare class MutableAssetSymbols implements IMutableAssetSymbols {
     constructor(inner: NapiSymbol[] | null | undefined | null);
     intoNapi(): NapiSymbol[];
     ensure(): void;
-    set(exportSymbol: symbol, local: symbol, loc?: SourceLocation | null, meta?: Meta | null): void;
-    get(exportSymbol: symbol): AssetSymbol | null | undefined;
-    hasExportSymbol(exportSymbol: symbol): boolean;
-    hasLocalSymbol(local: symbol): boolean;
-    exportSymbols(): Iterable<symbol>;
-    delete(exportSymbol: symbol): void;
+    set(exportSymbol: Symbol, local: Symbol, loc?: SourceLocation | null, meta?: Meta | null): void;
+    get(exportSymbol: Symbol): AssetSymbol | null | undefined;
+    hasExportSymbol(exportSymbol: Symbol): boolean;
+    hasLocalSymbol(local: Symbol): boolean;
+    exportSymbols(): Iterable<Symbol>;
+    delete(exportSymbol: Symbol): void;
     [Symbol.iterator](): MapIterator<AssetSymbol>;
 }
 export type AssetSymbol = {
-    local: symbol;
+    local: Symbol;
     loc: SourceLocation | null | undefined;
     meta?: Meta | null | undefined;
 };
 export type DependencyAssetSymbol = {
-    local: symbol;
+    local: Symbol;
     loc: SourceLocation | null | undefined;
     meta?: Meta | null | undefined;
     isWeak: boolean;

package/lib/types/public/BundleGraph.d.ts

@@ -1,4 +1,4 @@
-import type { Asset as IAsset, Bundle as IBundle, BundleGraph as IBundleGraph, BundleGraphTraversable, BundleGroup as IBundleGroup, Dependency as IDependency, ExportSymbolResolution, FilePath, GraphVisitor, NamedBundle, SymbolResolution, Target } from '@atlaspack/types';
+import type { Asset as IAsset, Bundle as IBundle, BundleGraph as IBundleGraph, BundleGraphTraversable, BundleGroup as IBundleGroup, Dependency as IDependency, ExportSymbolResolution, FilePath, GraphVisitor, NamedBundle, SymbolResolution, Symbol, Target } from '@atlaspack/types';
 import type { Bundle as InternalBundle, AtlaspackOptions } from '../types';
 import type InternalBundleGraph from '../BundleGraph';
 import { Asset } from './Asset';
@@ -40,7 +40,7 @@ export default class BundleGraph<TBundle extends IBundle> implements IBundleGrap
     isEntryBundleGroup(bundleGroup: IBundleGroup): boolean;
     getChildBundles(bundle: IBundle): Array<TBundle>;
     getParentBundles(bundle: IBundle): Array<TBundle>;
-    getSymbolResolution(asset: IAsset, symbol: symbol, boundary?: IBundle | null): SymbolResolution;
+    getSymbolResolution(asset: IAsset, symbol: Symbol, boundary?: IBundle | null): SymbolResolution;
     getExportedSymbols(asset: IAsset, boundary?: IBundle | null): Array<ExportSymbolResolution>;
     traverse<TContext>(visit: GraphVisitor<BundleGraphTraversable, TContext>, start?: IAsset | null, opts?: {
         skipUnusedDependencies?: boolean;
@@ -48,7 +48,7 @@ export default class BundleGraph<TBundle extends IBundle> implements IBundleGrap
     traverseBundles<TContext>(visit: GraphVisitor<TBundle, TContext>, startBundle?: IBundle | null): TContext | null | undefined;
     getBundlesWithAsset(asset: IAsset): Array<TBundle>;
     getBundlesWithDependency(dependency: IDependency): Array<TBundle>;
-    getUsedSymbols(v: IAsset | IDependency): ReadonlySet<symbol> | null | undefined;
+    getUsedSymbols(v: IAsset | IDependency): ReadonlySet<Symbol> | null | undefined;
     getEntryRoot(target: Target): FilePath;
     getConditionsForDependencies(deps: Array<IDependency>, bundle: NamedBundle): Set<{
         publicId: string;

package/lib/types/public/Symbols.d.ts

@@ -17,8 +17,8 @@ export declare class AssetSymbols implements IAssetSymbols {
         readonly next: () => {
             done: boolean;
         };
-    } | MapIterator<[symbol, {
-        local: symbol;
+    } | MapIterator<[string, {
+        local: ISymbol;
         loc: import("../types").InternalSourceLocation | null | undefined;
         meta?: Meta | null | undefined;
     }]>;
@@ -40,8 +40,8 @@ export declare class MutableAssetSymbols implements IMutableAssetSymbols {
         readonly next: () => {
             done: boolean;
         };
-    } | MapIterator<[symbol, {
-        local: symbol;
+    } | MapIterator<[string, {
+        local: ISymbol;
         loc: import("../types").InternalSourceLocation | null | undefined;
         meta?: Meta | null | undefined;
     }]>;
@@ -63,8 +63,8 @@ export declare class MutableDependencySymbols implements IMutableDependencySymbo
     } | null | undefined;
     get isCleared(): boolean;
     exportSymbols(): Iterable<ISymbol>;
-    [Symbol.iterator](): MapIterator<[symbol, {
-        local: symbol;
+    [Symbol.iterator](): MapIterator<[string, {
+        local: ISymbol;
         loc: import("../types").InternalSourceLocation | null | undefined;
         isWeak: boolean;
         meta?: Meta | null | undefined;