@atlaspack/core 2.23.1 → 2.23.2

package/CHANGELOG.md

@@ -1,5 +1,30 @@
 # @atlaspack/core
 
+## 2.23.2
+
+### Patch Changes
+
+- [#742](https://github.com/atlassian-labs/atlaspack/pull/742) [`ee040bb`](https://github.com/atlassian-labs/atlaspack/commit/ee040bb6428f29b57d892ddd8107e29077d08ffd) Thanks [@yamadapc](https://github.com/yamadapc)! - Internal changes and bug fixes to environmentDeduplication flag
+
+- [#755](https://github.com/atlassian-labs/atlaspack/pull/755) [`b6e72b6`](https://github.com/atlassian-labs/atlaspack/commit/b6e72b6dd2b517cbb0e700fa69e63332d3eacb1e) Thanks [@benjervis](https://github.com/benjervis)! - Allow runtime assets to be marked as requiring execution on load
+
+- Updated dependencies [[`ee040bb`](https://github.com/atlassian-labs/atlaspack/commit/ee040bb6428f29b57d892ddd8107e29077d08ffd), [`889c65c`](https://github.com/atlassian-labs/atlaspack/commit/889c65cd25b811045e26a117e7404f694dde77a2)]:
+  - @atlaspack/package-manager@2.14.26
+  - @atlaspack/feature-flags@2.23.1
+  - @atlaspack/build-cache@2.13.5
+  - @atlaspack/diagnostic@2.14.3
+  - @atlaspack/profiler@2.14.23
+  - @atlaspack/workers@2.14.26
+  - @atlaspack/events@2.14.3
+  - @atlaspack/logger@2.14.18
+  - @atlaspack/plugin@2.14.26
+  - @atlaspack/cache@3.2.21
+  - @atlaspack/graph@3.5.15
+  - @atlaspack/types@2.15.16
+  - @atlaspack/utils@2.18.3
+  - @atlaspack/rust@3.6.1
+  - @atlaspack/fs@2.15.21
+
 ## 2.23.1
 
 ### Patch Changes

package/lib/Atlaspack.js

@@ -128,7 +128,7 @@ function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { de
 const INTERNAL_TRANSFORM = exports.INTERNAL_TRANSFORM = Symbol('internal_transform');
 const INTERNAL_RESOLVE = exports.INTERNAL_RESOLVE = Symbol('internal_resolve');
 let WORKER_PATH = exports.WORKER_PATH = _path().default.join(__dirname, 'worker.js');
-if (process.env.ATLASPACK_REGISTER_USE_SRC === 'true') {
+if (__filename.endsWith('.ts')) {
   exports.WORKER_PATH = WORKER_PATH = _path().default.join(__dirname, 'worker.ts');
 }
 class Atlaspack {

package/lib/AtlaspackConfig.js

@@ -130,9 +130,7 @@ class AtlaspackConfig {
       if (allowEmpty) {
         return [];
       }
-      throw await this.missingPluginError(this.transformers,
-      // @ts-expect-error TS2345
-      (0, _diagnostic().md)`No transformers found for __${(0, _projectPath.fromProjectPathRelative)(filePath)}__` + (pipeline != null ? ` with pipeline: '${pipeline}'` : '') + '.', '/transformers');
+      throw await this.missingPluginError(this.transformers, (0, _diagnostic().md)`No transformers found for __${(0, _projectPath.fromProjectPathRelative)(filePath)}__` + (pipeline != null ? ` with pipeline: '${pipeline}'` : '') + '.', '/transformers');
     }
     return this.loadPlugins(transformers);
   }
@@ -157,9 +155,7 @@ class AtlaspackConfig {
   async getPackager(filePath) {
     let packager = this.matchGlobMap((0, _projectPath.toProjectPathUnsafe)(filePath), this.packagers);
     if (!packager) {
-      throw await this.missingPluginError(this.packagers,
-      // @ts-expect-error TS2345
-      (0, _diagnostic().md)`No packager found for __${filePath}__.`, '/packagers');
+      throw await this.missingPluginError(this.packagers, (0, _diagnostic().md)`No packager found for __${filePath}__.`, '/packagers');
     }
     return this.loadPlugin(packager);
   }
@@ -188,9 +184,7 @@ class AtlaspackConfig {
   async getCompressors(filePath) {
     let compressors = this.matchGlobMapPipelines((0, _projectPath.toProjectPathUnsafe)(filePath), this.compressors) ?? [];
     if (compressors.length === 0) {
-      throw await this.missingPluginError(this.compressors,
-      // @ts-expect-error TS2345
-      (0, _diagnostic().md)`No compressors found for __${filePath}__.`, '/compressors');
+      throw await this.missingPluginError(this.compressors, (0, _diagnostic().md)`No compressors found for __${filePath}__.`, '/compressors');
     }
     return this.loadPlugins(compressors);
   }

package/lib/SymbolPropagation.js

@@ -402,12 +402,9 @@ function propagateSymbols({
             let resolution = (0, _nullthrows().default)(assetGraph.getNode(resolutionNodeId));
             (0, _assert().default)(resolution && (resolution.type === 'asset_group' || resolution.type === 'asset'));
             errors.push({
-              // @ts-expect-error TS2345
               message: (0, _diagnostic().md)`${(0, _projectPath.fromProjectPathRelative)(
               // @ts-expect-error TS2345
-              resolution.value.filePath
-              // @ts-expect-error TS2731
-              )} does not export '${s}'`,
+              resolution.value.filePath)} does not export '${s}'`,
               origin: '@atlaspack/core',
               codeFrames: loc ? [{
                 filePath: (0, _projectPath.fromProjectPath)(options.projectRoot, loc === null || loc === void 0 ? void 0 : loc.filePath) ?? undefined,

package/lib/Transformation.js

@@ -113,7 +113,6 @@ class Transformation {
       } catch (err) {
         _logger().default.verbose([{
           origin: '@atlaspack/core',
-          // @ts-expect-error TS2345
           message: (0, _diagnostic().md)`Could not load existing source map for ${(0, _projectPath.fromProjectPathRelative)(asset.value.filePath)}`
         }, {
           origin: '@atlaspack/core',

package/lib/applyRuntimes.js

@@ -161,11 +161,13 @@ async function applyRuntimes({
             filePath,
             isEntry,
             env,
+            runtimeAssetRequiringExecutionOnLoad,
             priority
           } of runtimeAssets) {
             let sourceName = _path().default.join(_path().default.dirname(filePath), `runtime-${(0, _rust().hashString)(code)}.${bundle.type}`);
             let assetGroup = {
               code,
+              runtimeAssetRequiringExecutionOnLoad,
               filePath: (0, _projectPath.toProjectPath)(options.projectRoot, sourceName),
               env: (0, _Environment.mergeEnvironments)(options.projectRoot, (0, _EnvironmentManager.fromEnvironmentId)(bundle.env), env),
               // Runtime assets should be considered source, as they should be

package/lib/loadAtlaspackPlugin.js

@@ -47,7 +47,6 @@ async function loadPlugin(pluginName, configPath, keyPath, options) {
     let configContents = await options.inputFS.readFile(configPath, 'utf8');
     throw new (_diagnostic().default)({
       diagnostic: {
-        // @ts-expect-error TS2345
         message: (0, _diagnostic().md)`Local plugins are not supported in Atlaspack config packages. Please publish "${pluginName}" as a separate npm package.`,
         origin: '@atlaspack/core',
         codeFrames: keyPath ? [{
@@ -77,7 +76,6 @@ async function loadPlugin(pluginName, configPath, keyPath, options) {
     let alternatives = await (0, _utils().findAlternativeNodeModules)(options.inputFS, pluginName, _path().default.dirname(resolveFrom));
     throw new (_diagnostic().default)({
       diagnostic: {
-        // @ts-expect-error TS2345
         message: (0, _diagnostic().md)`Cannot find Atlaspack plugin "${pluginName}"`,
         origin: '@atlaspack/core',
         codeFrames: keyPath ? [{
@@ -87,7 +85,6 @@ async function loadPlugin(pluginName, configPath, keyPath, options) {
           codeHighlights: (0, _diagnostic().generateJSONCodeHighlights)(configContents, [{
             key: keyPath,
             type: 'value',
-            // @ts-expect-error TS2345
             message: (0, _diagnostic().md)`Cannot find module "${pluginName}"${alternatives[0] ? `, did you mean "${alternatives[0]}"?` : ''}`
           }])
         }] : undefined

package/lib/requests/AssetGraphRequest.js

@@ -415,6 +415,14 @@ class AssetGraphBuilder {
     });
     if (assets != null) {
       for (let asset of assets) {
+        // Pass the runtimeAssetRequiringExecutionOnLoad flag from the asset
+        // group down to the asset itself, for reading in the packager.
+        if (input.runtimeAssetRequiringExecutionOnLoad) {
+          asset.meta = {
+            ...(asset.meta ?? {}),
+            runtimeAssetRequiringExecutionOnLoad: input.runtimeAssetRequiringExecutionOnLoad
+          };
+        }
         if (this.assetGraph.safeToIncrementallyBundle) {
           let otherAsset = this.assetGraph.getNodeByContentKey(asset.id);
           if (otherAsset != null) {

package/lib/requests/AtlaspackConfigRequest.js

@@ -151,7 +151,6 @@ async function resolveAtlaspackConfig(options) {
   } catch (e) {
     throw new (_diagnostic().default)({
       diagnostic: {
-        // @ts-expect-error TS2345
         message: (0, _diagnostic().md)`Could not find parcel config at ${_path().default.relative(options.projectRoot, configPath)}`,
         origin: '@atlaspack/core'
       }
@@ -359,7 +358,6 @@ async function resolveExtends(ext, configPath, extendsKey, options) {
             codeHighlights: (0, _diagnostic().generateJSONCodeHighlights)(parentContents, [{
               key: extendsKey,
               type: 'value',
-              // @ts-expect-error TS2345
               message: (0, _diagnostic().md)`Cannot find module "${ext}"${alternatives[0] ? `, did you mean "${alternatives[0]}"?` : ''}`
             }])
           }]
@@ -386,7 +384,6 @@ async function processExtendedConfig(configPath, extendsKey, extendsSpecifier, r
           codeHighlights: (0, _diagnostic().generateJSONCodeHighlights)(parentContents, [{
             key: extendsKey,
             type: 'value',
-            // @ts-expect-error TS2345
             message: (0, _diagnostic().md)`"${extendsSpecifier}" does not exist${alternatives[0] ? `, did you mean "${alternatives[0]}"?` : ''}`
           }])
         }]

package/lib/requests/EntryRequest.js

@@ -92,7 +92,6 @@ async function assertFile(fs, entry, relativeSource, pkgFilePath, keyPath, optio
     throw new (_diagnostic().default)({
       diagnostic: {
         origin: '@atlaspack/core',
-        // @ts-expect-error TS2345
         message: (0, _diagnostic().md)`${_path().default.relative(process.cwd(), source)} does not exist.`,
         codeFrames: [{
           filePath: pkgFilePath,
@@ -102,7 +101,6 @@ async function assertFile(fs, entry, relativeSource, pkgFilePath, keyPath, optio
           }])
         }],
         hints: alternatives.map(r => {
-          // @ts-expect-error TS2345
           return (0, _diagnostic().md)`Did you mean '__${r}__'?`;
         })
       }
@@ -113,7 +111,6 @@ async function assertFile(fs, entry, relativeSource, pkgFilePath, keyPath, optio
     throw new (_diagnostic().default)({
       diagnostic: {
         origin: '@atlaspack/core',
-        // @ts-expect-error TS2345
         message: (0, _diagnostic().md)`${_path().default.relative(process.cwd(), source)} is not a file.`,
         codeFrames: [{
           filePath: pkgFilePath,
@@ -138,7 +135,6 @@ class EntryResolver {
       if (!(0, _utils().isGlob)(entry)) {
         throw new (_diagnostic().default)({
           diagnostic: {
-            // @ts-expect-error TS2345
             message: (0, _diagnostic().md)`Entry ${entry} does not exist`
           }
         });
@@ -250,7 +246,6 @@ class EntryResolver {
       }
       throw new (_diagnostic().default)({
         diagnostic: {
-          // @ts-expect-error TS2345
           message: (0, _diagnostic().md)`Could not find entry: ${entry}`
         }
       });
@@ -268,7 +263,6 @@ class EntryResolver {
     }
     throw new (_diagnostic().default)({
       diagnostic: {
-        // @ts-expect-error TS2345
         message: (0, _diagnostic().md)`Unknown entry: ${entry}`
       }
     });
@@ -287,7 +281,6 @@ class EntryResolver {
       // TODO: code frame?
       throw new (_diagnostic().default)({
         diagnostic: {
-          // @ts-expect-error TS2345
           message: (0, _diagnostic().md)`Error parsing ${_path().default.relative(this.options.inputFS.cwd(), pkgFile)}: ${err.message}`
         }
       });

package/lib/requests/PathRequest.js

@@ -302,9 +302,7 @@ class ResolverRunner {
             var _result$query;
             let resultFilePath = result.filePath;
             if (!_path().default.isAbsolute(resultFilePath)) {
-              throw new Error(
-              // @ts-expect-error TS2345
-              (0, _diagnostic().md)`Resolvers must return an absolute path, ${resolver.name} returned: ${resultFilePath}`);
+              throw new Error((0, _diagnostic().md)`Resolvers must return an absolute path, ${resolver.name} returned: ${resultFilePath}`);
             }
             return {
               assetGroup: {
@@ -366,9 +364,7 @@ class ResolverRunner {
     }
     let resolveFrom = dependency.resolveFrom ?? dependency.sourcePath;
     let dir = resolveFrom != null ? (0, _utils().normalizePath)((0, _projectPath.fromProjectPathRelative)(resolveFrom)) : '';
-    let diagnostic = await this.getDiagnostic(dependency,
-    // @ts-expect-error TS2345
-    (0, _diagnostic().md)`Failed to resolve '${dependency.specifier}' ${dir ? `from '${dir}'` : ''}`);
+    let diagnostic = await this.getDiagnostic(dependency, (0, _diagnostic().md)`Failed to resolve '${dependency.specifier}' ${dir ? `from '${dir}'` : ''}`);
     diagnostics.unshift(diagnostic);
     return {
       assetGroup: null,

package/lib/requests/TargetRequest.js

@@ -180,7 +180,6 @@ class TargetResolver {
           if (!packageTargets.has(target)) {
             throw new (_diagnostic().default)({
               diagnostic: {
-                // @ts-expect-error TS2345
                 message: (0, _diagnostic().md)`Could not find target with name "${target}"`,
                 origin: '@atlaspack/core'
               }
@@ -202,7 +201,6 @@ class TargetResolver {
             let optionTargetsString = JSON.stringify(optionTargets, null, '\t');
             throw new (_diagnostic().default)({
               diagnostic: {
-                // @ts-expect-error TS2345
                 message: (0, _diagnostic().md)`Missing distDir for target "${name}"`,
                 origin: '@atlaspack/core',
                 codeFrames: [{
@@ -314,7 +312,6 @@ class TargetResolver {
       if (pkgFile == null) {
         throw new (_diagnostic().default)({
           diagnostic: {
-            // @ts-expect-error TS2345
             message: (0, _diagnostic().md)`Expected package.json file in ${rootDir}`,
             origin: '@atlaspack/core'
           }
@@ -538,7 +535,6 @@ class TargetResolver {
           let ext = _path().default.extname(distEntry);
           throw new (_diagnostic().default)({
             diagnostic: {
-              // @ts-expect-error TS2345
               message: (0, _diagnostic().md)`Unexpected output file type ${ext} in target "${targetName}"`,
               origin: '@atlaspack/core',
               codeFrames: [{
@@ -560,7 +556,6 @@ class TargetResolver {
           let contents = typeof pkgContents === 'string' ? pkgContents : JSON.stringify(pkgContents, null, '\t');
           throw new (_diagnostic().default)({
             diagnostic: {
-              // @ts-expect-error TS2345
               message: (0, _diagnostic().md)`The "global" output format is not supported in the "${targetName}" target.`,
               origin: '@atlaspack/core',
               codeFrames: [{
@@ -587,7 +582,6 @@ class TargetResolver {
           throw new (_diagnostic().default)({
             diagnostic: {
               // prettier-ignore
-              // @ts-expect-error TS2345
               message: (0, _diagnostic().md)`Output format "esmodule" cannot be used in the "main" target without a .mjs extension or "type": "module" field.`,
               origin: '@atlaspack/core',
               codeFrames: [{
@@ -719,7 +713,6 @@ class TargetResolver {
           let contents = typeof pkgContents === 'string' ? pkgContents : JSON.stringify(pkgContents, null, '\t');
           throw new (_diagnostic().default)({
             diagnostic: {
-              // @ts-expect-error TS2345
               message: (0, _diagnostic().md)`Invalid distPath for target "${targetName}"`,
               origin: '@atlaspack/core',
               codeFrames: [{
@@ -911,7 +904,6 @@ class TargetResolver {
       });
       throw new (_diagnostic().default)({
         diagnostic: {
-          // @ts-expect-error TS2345
           message: (0, _diagnostic().md)`Declared output format "${descriptor.outputFormat}" does not match expected output format "${inferredOutputFormat}".`,
           origin: '@atlaspack/core',
           codeFrames: [{
@@ -1009,7 +1001,6 @@ function assertNoDuplicateTargets(options, targets, pkgFilePath, pkgContents) {
   for (let [targetPath, targetNames] of targetsByPath) {
     if (targetNames.length > 1 && pkgContents != null && pkgFilePath != null) {
       diagnostics.push({
-        // @ts-expect-error TS2345
         message: (0, _diagnostic().md)`Multiple targets have the same destination path "${_path().default.relative(_path().default.dirname(pkgFilePath), targetPath)}"`,
         origin: '@atlaspack/core',
         codeFrames: [{
@@ -1150,7 +1141,6 @@ async function debugResolvedTargets(input, targets, targetInfo, options) {
         highlight.type = null;
       }
       if (keyInfo.path) {
-        // @ts-expect-error TS2345
         highlight.defined = (0, _diagnostic().md)`${key} defined here`;
       }
       if (keyInfo.inferred) {
@@ -1193,7 +1183,6 @@ async function debugResolvedTargets(input, targets, targetInfo, options) {
     v.message != null ? _diagnostic().md.italic(v.message) : '';
     _logger().default.verbose({
       origin: '@atlaspack/core',
-      // @ts-expect-error TS2345
       message: (0, _diagnostic().md)`**Target** "${target.name}"
 
                **Entry**: ${_path().default.relative(process.cwd(), (0, _projectPath.fromProjectPath)(options.projectRoot, input.filePath))}

package/lib/types/types.d.ts

@@ -322,6 +322,7 @@ export type AssetRequestInput = {
     isSource?: boolean;
     canDefer?: boolean;
     sideEffects?: boolean;
+    runtimeAssetRequiringExecutionOnLoad?: boolean;
     code?: string;
     pipeline?: string | null | undefined;
     optionsRef: SharedReference;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@atlaspack/core",
-  "version": "2.23.1",
+  "version": "2.23.2",
   "license": "(MIT OR Apache-2.0)",
   "publishConfig": {
     "access": "public"
@@ -24,21 +24,21 @@
   },
   "dependencies": {
     "@mischnic/json-sourcemap": "^0.1.0",
-    "@atlaspack/build-cache": "2.13.4",
-    "@atlaspack/cache": "3.2.20",
-    "@atlaspack/diagnostic": "2.14.2",
-    "@atlaspack/events": "2.14.2",
-    "@atlaspack/feature-flags": "2.23.0",
-    "@atlaspack/fs": "2.15.20",
-    "@atlaspack/graph": "3.5.14",
-    "@atlaspack/logger": "2.14.17",
-    "@atlaspack/package-manager": "2.14.25",
-    "@atlaspack/plugin": "2.14.25",
-    "@atlaspack/profiler": "2.14.22",
-    "@atlaspack/rust": "3.6.0",
-    "@atlaspack/types": "2.15.15",
-    "@atlaspack/utils": "2.18.2",
-    "@atlaspack/workers": "2.14.25",
+    "@atlaspack/build-cache": "2.13.5",
+    "@atlaspack/cache": "3.2.21",
+    "@atlaspack/diagnostic": "2.14.3",
+    "@atlaspack/events": "2.14.3",
+    "@atlaspack/feature-flags": "2.23.1",
+    "@atlaspack/fs": "2.15.21",
+    "@atlaspack/graph": "3.5.15",
+    "@atlaspack/logger": "2.14.18",
+    "@atlaspack/package-manager": "2.14.26",
+    "@atlaspack/plugin": "2.14.26",
+    "@atlaspack/profiler": "2.14.23",
+    "@atlaspack/rust": "3.6.1",
+    "@atlaspack/types": "2.15.16",
+    "@atlaspack/utils": "2.18.3",
+    "@atlaspack/workers": "2.14.26",
     "@parcel/source-map": "^2.1.1",
     "base-x": "^3.0.8",
     "browserslist": "^4.6.6",
@@ -51,7 +51,7 @@
     "semver": "^7.5.2"
   },
   "devDependencies": {
-    "@atlaspack/babel-register": "2.14.2",
+    "@atlaspack/babel-register": "2.14.3",
     "@types/node": ">= 18",
     "rfdc": "1",
     "jest-diff": "*",

package/src/Atlaspack.ts

@@ -70,7 +70,7 @@ registerCoreWithSerializer();
 export const INTERNAL_TRANSFORM: symbol = Symbol('internal_transform');
 export const INTERNAL_RESOLVE: symbol = Symbol('internal_resolve');
 export let WORKER_PATH: string = path.join(__dirname, 'worker.js');
-if (process.env.ATLASPACK_REGISTER_USE_SRC === 'true') {
+if (__filename.endsWith('.ts')) {
   WORKER_PATH = path.join(__dirname, 'worker.ts');
 }
 

package/src/AtlaspackConfig.ts

@@ -208,7 +208,6 @@ export class AtlaspackConfig {
 
       throw await this.missingPluginError(
         this.transformers,
-        // @ts-expect-error TS2345
         md`No transformers found for __${fromProjectPathRelative(filePath)}__` +
           (pipeline != null ? ` with pipeline: '${pipeline}'` : '') +
           '.',
@@ -261,7 +260,6 @@ export class AtlaspackConfig {
     if (!packager) {
       throw await this.missingPluginError(
         this.packagers,
-        // @ts-expect-error TS2345
         md`No packager found for __${filePath}__.`,
         '/packagers',
       );
@@ -325,7 +323,6 @@ export class AtlaspackConfig {
     if (compressors.length === 0) {
       throw await this.missingPluginError(
         this.compressors,
-        // @ts-expect-error TS2345
         md`No compressors found for __${filePath}__.`,
         '/compressors',
       );

package/src/BundleGraph.ts

@@ -1,7 +1,6 @@
 import type {
   GraphVisitor,
   FilePath,
-  Symbol,
   TraversalActions,
   BundleBehavior as IBundleBehavior,
   ConditionMeta,

package/src/SymbolPropagation.ts

@@ -525,11 +525,9 @@ export function propagateSymbols({
               );
 
               errors.push({
-                // @ts-expect-error TS2345
                 message: md`${fromProjectPathRelative(
                   // @ts-expect-error TS2345
                   resolution.value.filePath,
-                  // @ts-expect-error TS2731
                 )} does not export '${s}'`,
                 origin: '@atlaspack/core',
                 codeFrames: loc

package/src/Transformation.ts

@@ -142,7 +142,6 @@ export default class Transformation {
         logger.verbose([
           {
             origin: '@atlaspack/core',
-            // @ts-expect-error TS2345
             message: md`Could not load existing source map for ${fromProjectPathRelative(
               asset.value.filePath,
             )}`,

package/src/applyRuntimes.ts

@@ -150,6 +150,7 @@ export default async function applyRuntimes<TResult extends RequestResult>({
             filePath,
             isEntry,
             env,
+            runtimeAssetRequiringExecutionOnLoad,
             priority,
           } of runtimeAssets) {
             let sourceName = path.join(
@@ -159,6 +160,7 @@ export default async function applyRuntimes<TResult extends RequestResult>({
 
             let assetGroup = {
               code,
+              runtimeAssetRequiringExecutionOnLoad,
               filePath: toProjectPath(options.projectRoot, sourceName),
               env: mergeEnvironments(
                 options.projectRoot,

package/src/loadAtlaspackPlugin.ts

@@ -31,7 +31,6 @@ export default async function loadPlugin<T>(
     let configContents = await options.inputFS.readFile(configPath, 'utf8');
     throw new ThrowableDiagnostic({
       diagnostic: {
-        // @ts-expect-error TS2345
         message: md`Local plugins are not supported in Atlaspack config packages. Please publish "${pluginName}" as a separate npm package.`,
         origin: '@atlaspack/core',
         codeFrames: keyPath
@@ -71,7 +70,6 @@ export default async function loadPlugin<T>(
     );
     throw new ThrowableDiagnostic({
       diagnostic: {
-        // @ts-expect-error TS2345
         message: md`Cannot find Atlaspack plugin "${pluginName}"`,
         origin: '@atlaspack/core',
         codeFrames: keyPath
@@ -84,7 +82,6 @@ export default async function loadPlugin<T>(
                   {
                     key: keyPath,
                     type: 'value',
-                    // @ts-expect-error TS2345
                     message: md`Cannot find module "${pluginName}"${
                       alternatives[0]
                         ? `, did you mean "${alternatives[0]}"?`

package/src/public/BundleGraph.ts

@@ -8,7 +8,6 @@ import type {
   ExportSymbolResolution,
   FilePath,
   GraphVisitor,
-  Symbol,
   NamedBundle,
   SymbolResolution,
   Target,

package/src/requests/AssetGraphRequest.ts

@@ -560,6 +560,16 @@ export class AssetGraphBuilder {
 
     if (assets != null) {
       for (let asset of assets) {
+        // Pass the runtimeAssetRequiringExecutionOnLoad flag from the asset
+        // group down to the asset itself, for reading in the packager.
+        if (input.runtimeAssetRequiringExecutionOnLoad) {
+          asset.meta = {
+            ...(asset.meta ?? {}),
+            runtimeAssetRequiringExecutionOnLoad:
+              input.runtimeAssetRequiringExecutionOnLoad,
+          };
+        }
+
         if (this.assetGraph.safeToIncrementallyBundle) {
           let otherAsset = this.assetGraph.getNodeByContentKey(asset.id);
           if (otherAsset != null) {

package/src/requests/AtlaspackConfigRequest.ts

@@ -184,7 +184,6 @@ export async function resolveAtlaspackConfig(
   } catch (e: any) {
     throw new ThrowableDiagnostic({
       diagnostic: {
-        // @ts-expect-error TS2345
         message: md`Could not find parcel config at ${path.relative(
           options.projectRoot,
           configPath,
@@ -520,7 +519,6 @@ export async function resolveExtends(
                 {
                   key: extendsKey,
                   type: 'value',
-                  // @ts-expect-error TS2345
                   message: md`Cannot find module "${ext}"${
                     alternatives[0]
                       ? `, did you mean "${alternatives[0]}"?`
@@ -570,7 +568,6 @@ async function processExtendedConfig(
               {
                 key: extendsKey,
                 type: 'value',
-                // @ts-expect-error TS2345
                 message: md`"${extendsSpecifier}" does not exist${
                   alternatives[0] ? `, did you mean "${alternatives[0]}"?` : ''
                 }`,

package/src/requests/EntryRequest.ts

@@ -107,7 +107,6 @@ async function assertFile(
     throw new ThrowableDiagnostic({
       diagnostic: {
         origin: '@atlaspack/core',
-        // @ts-expect-error TS2345
         message: md`${path.relative(process.cwd(), source)} does not exist.`,
         codeFrames: [
           {
@@ -121,7 +120,6 @@ async function assertFile(
           },
         ],
         hints: alternatives.map((r) => {
-          // @ts-expect-error TS2345
           return md`Did you mean '__${r}__'?`;
         }),
       },
@@ -133,7 +131,6 @@ async function assertFile(
     throw new ThrowableDiagnostic({
       diagnostic: {
         origin: '@atlaspack/core',
-        // @ts-expect-error TS2345
         message: md`${path.relative(process.cwd(), source)} is not a file.`,
         codeFrames: [
           {
@@ -166,7 +163,6 @@ export class EntryResolver {
       if (!isGlob(entry)) {
         throw new ThrowableDiagnostic({
           diagnostic: {
-            // @ts-expect-error TS2345
             message: md`Entry ${entry} does not exist`,
           },
         });
@@ -319,7 +315,6 @@ export class EntryResolver {
 
       throw new ThrowableDiagnostic({
         diagnostic: {
-          // @ts-expect-error TS2345
           message: md`Could not find entry: ${entry}`,
         },
       });
@@ -346,7 +341,6 @@ export class EntryResolver {
 
     throw new ThrowableDiagnostic({
       diagnostic: {
-        // @ts-expect-error TS2345
         message: md`Unknown entry: ${entry}`,
       },
     });
@@ -379,7 +373,6 @@ export class EntryResolver {
       // TODO: code frame?
       throw new ThrowableDiagnostic({
         diagnostic: {
-          // @ts-expect-error TS2345
           message: md`Error parsing ${path.relative(
             this.options.inputFS.cwd(),
             pkgFile,

package/src/requests/PathRequest.ts

@@ -357,7 +357,6 @@ export class ResolverRunner {
             let resultFilePath = result.filePath;
             if (!path.isAbsolute(resultFilePath)) {
               throw new Error(
-                // @ts-expect-error TS2345
                 md`Resolvers must return an absolute path, ${resolver.name} returned: ${resultFilePath}`,
               );
             }
@@ -449,7 +448,6 @@ export class ResolverRunner {
 
     let diagnostic = await this.getDiagnostic(
       dependency,
-      // @ts-expect-error TS2345
       md`Failed to resolve '${dependency.specifier}' ${
         dir ? `from '${dir}'` : ''
       }`,