@atlaspack/core 2.16.2-canary.27 → 2.16.2-canary.270

package/test/public/Config.test.ts

@@ -0,0 +1,104 @@
+import sinon from 'sinon';
+import {makeConfigProxy} from '../../src/public/Config';
+import assert from 'assert';
+
+describe('makeConfigProxy', () => {
+  it('tracks reads to nested fields', () => {
+    const onRead = sinon.spy();
+    const target = {a: {b: {c: 'd'}}} as const;
+    const config = makeConfigProxy(onRead, target);
+    config.a.b.c;
+    assert.ok(onRead.calledWith(['a', 'b', 'c']));
+    assert.ok(onRead.calledOnce);
+  });
+
+  it('works for reading package.json dependencies', () => {
+    const packageJson = {
+      dependencies: {
+        react: '18.2.0',
+      },
+    } as const;
+
+    const onRead = sinon.spy();
+    const config = makeConfigProxy(onRead, packageJson);
+    assert.equal(config.dependencies.react, '18.2.0');
+    assert.equal(config.dependencies.preact, undefined);
+    assert.ok(onRead.calledWith(['dependencies', 'react']));
+    assert.ok(onRead.calledWith(['dependencies', 'preact']));
+    assert.equal(onRead.callCount, 2);
+  });
+
+  it('will track reads for any missing or null keys', () => {
+    const packageJson = {
+      dependencies: {
+        react: '18.2.0',
+      },
+    } as const;
+
+    const onRead = sinon.spy();
+    const config = makeConfigProxy(onRead, packageJson);
+
+    assert.equal(config.alias?.react, undefined);
+    assert.ok(onRead.calledWith(['alias']));
+    assert.equal(onRead.callCount, 1);
+  });
+
+  it('iterating over keys works normally and will register a read for the key being enumerated', () => {
+    const packageJson = {
+      nested: {
+        dependencies: {
+          react: '18.2.0',
+          'react-dom': '18.2.0',
+          'react-router': '6.14.2',
+        },
+      },
+    } as const;
+
+    const onRead = sinon.spy();
+    const config = makeConfigProxy(onRead, packageJson);
+    assert.equal(Object.keys(config.nested.dependencies).length, 3);
+
+    assert.ok(onRead.calledWith(['nested', 'dependencies']));
+  });
+
+  it('if a key has an array value we will track a read for that key', () => {
+    const packageJson = {
+      scripts: ['build', 'test'],
+    } as const;
+
+    const onRead = sinon.spy();
+    const config = makeConfigProxy(onRead, packageJson);
+    assert.equal(config.scripts[0], 'build');
+    assert.equal(onRead.callCount, 1);
+    assert.ok(onRead.calledWith(['scripts']));
+  });
+
+  it('if a key array value is iterated over we will track a read for that key', () => {
+    const packageJson = {
+      scripts: ['build', 'test'],
+    } as const;
+
+    const onRead = sinon.spy();
+    const config = makeConfigProxy(onRead, packageJson);
+    let scriptCount = 0;
+    // eslint-disable-next-line no-unused-vars
+    for (const _script of config.scripts) {
+      scriptCount += 1;
+    }
+    assert.equal(scriptCount, 2);
+    assert.ok(onRead.calledWith(['scripts']));
+    assert.equal(onRead.callCount, 1);
+  });
+
+  it('if a key array value length is verified we will track a read for that key', () => {
+    const packageJson = {
+      scripts: ['build', 'test'],
+    } as const;
+
+    const onRead = sinon.spy();
+    const config = makeConfigProxy(onRead, packageJson);
+    assert.equal(config.scripts.length, 2);
+    assert.ok(onRead.calledWith(['scripts']));
+    assert.equal(onRead.callCount, 1);
+  });
+});

package/test/requests/{AssetGraphRequestRust.test.js → AssetGraphRequestRust.test.ts}

@@ -1,6 +1,7 @@
-// @flow
 import assert from 'assert';
 import {getAssetGraph} from '../../src/requests/AssetGraphRequestRust';
+import {createEnvironment} from '../../src/Environment';
+import {fromEnvironmentId} from '../../src/EnvironmentManager';
 
 describe('AssetGraphRequestRust -> getAssetGraph', function () {
   it('should create a valid AssetGraph', () => {
@@ -42,25 +43,29 @@ function getSerializedGraph() {
           id: 'b01a088f112fa82f',
           dependency: {
             bundleBehavior: null,
-            env: {
-              context: 'browser',
-              engines: {
-                browsers: [
-                  'last 1 Chrome version',
-                  'last 1 Safari version',
-                  'last 1 Firefox version',
-                  'last 1 Edge version',
-                ],
-              },
-              includeNodeModules: true,
-              isLibrary: false,
-              loc: null,
-              outputFormat: 'global',
-              shouldScopeHoist: true,
-              shouldOptimize: false,
-              sourceMap: {},
-              sourceType: 'module',
-            },
+            env: structuredClone(
+              fromEnvironmentId(
+                createEnvironment({
+                  context: 'browser',
+                  engines: {
+                    browsers: [
+                      'last 1 Chrome version',
+                      'last 1 Safari version',
+                      'last 1 Firefox version',
+                      'last 1 Edge version',
+                    ],
+                  },
+                  includeNodeModules: true,
+                  isLibrary: false,
+                  loc: null,
+                  outputFormat: 'global',
+                  shouldScopeHoist: true,
+                  shouldOptimize: false,
+                  sourceMap: {},
+                  sourceType: 'module',
+                }),
+              ),
+            ),
             loc: null,
             meta: {},
             pipeline: null,
@@ -75,25 +80,29 @@ function getSerializedGraph() {
             target: {
               distDir: '/dist',
               distEntry: null,
-              env: {
-                context: 'browser',
-                engines: {
-                  browsers: [
-                    'last 1 Chrome version',
-                    'last 1 Safari version',
-                    'last 1 Firefox version',
-                    'last 1 Edge version',
-                  ],
-                },
-                includeNodeModules: true,
-                isLibrary: false,
-                loc: null,
-                outputFormat: 'global',
-                shouldScopeHoist: true,
-                shouldOptimize: false,
-                sourceMap: {},
-                sourceType: 'module',
-              },
+              env: structuredClone(
+                fromEnvironmentId(
+                  createEnvironment({
+                    context: 'browser',
+                    engines: {
+                      browsers: [
+                        'last 1 Chrome version',
+                        'last 1 Safari version',
+                        'last 1 Firefox version',
+                        'last 1 Edge version',
+                      ],
+                    },
+                    includeNodeModules: true,
+                    isLibrary: false,
+                    loc: null,
+                    outputFormat: 'global',
+                    shouldScopeHoist: true,
+                    shouldOptimize: false,
+                    sourceMap: {},
+                    sourceType: 'module',
+                  }),
+                ),
+              ),
               loc: null,
               name: 'default',
               publicUrl: '/',
@@ -113,25 +122,29 @@ function getSerializedGraph() {
         value: {
           id: 'e2056518260d7dc7',
           bundleBehavior: 1,
-          env: {
-            context: 'browser',
-            engines: {
-              browsers: [
-                'last 1 Chrome version',
-                'last 1 Safari version',
-                'last 1 Firefox version',
-                'last 1 Edge version',
-              ],
-            },
-            includeNodeModules: true,
-            isLibrary: false,
-            loc: null,
-            outputFormat: 'global',
-            shouldScopeHoist: true,
-            shouldOptimize: false,
-            sourceMap: {},
-            sourceType: 'module',
-          },
+          env: structuredClone(
+            fromEnvironmentId(
+              createEnvironment({
+                context: 'browser',
+                engines: {
+                  browsers: [
+                    'last 1 Chrome version',
+                    'last 1 Safari version',
+                    'last 1 Firefox version',
+                    'last 1 Edge version',
+                  ],
+                },
+                includeNodeModules: true,
+                isLibrary: false,
+                loc: null,
+                outputFormat: 'global',
+                shouldScopeHoist: true,
+                shouldOptimize: false,
+                sourceMap: {},
+                sourceType: 'module',
+              }),
+            ),
+          ),
           filePath: '/index.html',
           type: 'html',
           meta: {},
@@ -161,25 +174,29 @@ function getSerializedGraph() {
           id: 'aece0f57a78d1ef8',
           dependency: {
             bundleBehavior: null,
-            env: {
-              context: 'browser',
-              engines: {
-                browsers: [
-                  'last 1 Chrome version',
-                  'last 1 Safari version',
-                  'last 1 Firefox version',
-                  'last 1 Edge version',
-                ],
-              },
-              includeNodeModules: true,
-              isLibrary: false,
-              loc: null,
-              outputFormat: 'esmodule',
-              shouldScopeHoist: true,
-              shouldOptimize: false,
-              sourceMap: {},
-              sourceType: 'module',
-            },
+            env: structuredClone(
+              fromEnvironmentId(
+                createEnvironment({
+                  context: 'browser',
+                  engines: {
+                    browsers: [
+                      'last 1 Chrome version',
+                      'last 1 Safari version',
+                      'last 1 Firefox version',
+                      'last 1 Edge version',
+                    ],
+                  },
+                  includeNodeModules: true,
+                  isLibrary: false,
+                  loc: null,
+                  outputFormat: 'esmodule',
+                  shouldScopeHoist: true,
+                  shouldOptimize: false,
+                  sourceMap: {},
+                  sourceType: 'module',
+                }),
+              ),
+            ),
             loc: null,
             meta: {},
             pipeline: null,
@@ -208,25 +225,29 @@ function getSerializedGraph() {
         value: {
           id: '79c128d4f549c408',
           bundleBehavior: null,
-          env: {
-            context: 'browser',
-            engines: {
-              browsers: [
-                'last 1 Chrome version',
-                'last 1 Safari version',
-                'last 1 Firefox version',
-                'last 1 Edge version',
-              ],
-            },
-            includeNodeModules: true,
-            isLibrary: false,
-            loc: null,
-            outputFormat: 'esmodule',
-            shouldScopeHoist: true,
-            shouldOptimize: false,
-            sourceMap: {},
-            sourceType: 'module',
-          },
+          env: structuredClone(
+            fromEnvironmentId(
+              createEnvironment({
+                context: 'browser',
+                engines: {
+                  browsers: [
+                    'last 1 Chrome version',
+                    'last 1 Safari version',
+                    'last 1 Firefox version',
+                    'last 1 Edge version',
+                  ],
+                },
+                includeNodeModules: true,
+                isLibrary: false,
+                loc: null,
+                outputFormat: 'esmodule',
+                shouldScopeHoist: true,
+                shouldOptimize: false,
+                sourceMap: {},
+                sourceType: 'module',
+              }),
+            ),
+          ),
           filePath: '/index.ts',
           type: 'js',
           meta: {
@@ -261,25 +282,29 @@ function getSerializedGraph() {
           id: 'cfe74f65a41af1a7',
           dependency: {
             bundleBehavior: null,
-            env: {
-              context: 'browser',
-              engines: {
-                browsers: [
-                  'last 1 Chrome version',
-                  'last 1 Safari version',
-                  'last 1 Firefox version',
-                  'last 1 Edge version',
-                ],
-              },
-              includeNodeModules: true,
-              isLibrary: false,
-              loc: null,
-              outputFormat: 'esmodule',
-              shouldScopeHoist: true,
-              shouldOptimize: false,
-              sourceMap: {},
-              sourceType: 'module',
-            },
+            env: structuredClone(
+              fromEnvironmentId(
+                createEnvironment({
+                  context: 'browser',
+                  engines: {
+                    browsers: [
+                      'last 1 Chrome version',
+                      'last 1 Safari version',
+                      'last 1 Firefox version',
+                      'last 1 Edge version',
+                    ],
+                  },
+                  includeNodeModules: true,
+                  isLibrary: false,
+                  loc: null,
+                  outputFormat: 'esmodule',
+                  shouldScopeHoist: true,
+                  shouldOptimize: false,
+                  sourceMap: {},
+                  sourceType: 'module',
+                }),
+              ),
+            ),
             loc: {
               filePath: '/index.ts',
               start: {
@@ -340,25 +365,29 @@ function getSerializedGraph() {
         value: {
           id: '13fc7969eb974fe3',
           bundleBehavior: null,
-          env: {
-            context: 'browser',
-            engines: {
-              browsers: [
-                'last 1 Chrome version',
-                'last 1 Safari version',
-                'last 1 Firefox version',
-                'last 1 Edge version',
-              ],
-            },
-            includeNodeModules: true,
-            isLibrary: false,
-            loc: null,
-            outputFormat: 'esmodule',
-            shouldScopeHoist: true,
-            shouldOptimize: false,
-            sourceMap: {},
-            sourceType: 'module',
-          },
+          env: structuredClone(
+            fromEnvironmentId(
+              createEnvironment({
+                context: 'browser',
+                engines: {
+                  browsers: [
+                    'last 1 Chrome version',
+                    'last 1 Safari version',
+                    'last 1 Firefox version',
+                    'last 1 Edge version',
+                  ],
+                },
+                includeNodeModules: true,
+                isLibrary: false,
+                loc: null,
+                outputFormat: 'esmodule',
+                shouldScopeHoist: true,
+                shouldOptimize: false,
+                sourceMap: {},
+                sourceType: 'module',
+              }),
+            ),
+          ),
           filePath: '/library.ts',
           type: 'js',
           meta: {
@@ -407,5 +436,6 @@ function getSerializedGraph() {
         },
       },
     ],
+    updates: [],
   };
 }