@atlaspack/core 2.15.1 → 2.16.0

package/CHANGELOG.md

@@ -1,5 +1,24 @@
 # @atlaspack/core
 
+## 2.16.0
+
+### Minor Changes
+
+- [#520](https://github.com/atlassian-labs/atlaspack/pull/520) [`90150df`](https://github.com/atlassian-labs/atlaspack/commit/90150dfb68236e1d1c11813108ecabd92cff9366) Thanks [@pancaspe87](https://github.com/pancaspe87)! - Modify "large blobs" to be written to the LMDB cache
+
+### Patch Changes
+
+- Updated dependencies [[`f27d39e`](https://github.com/atlassian-labs/atlaspack/commit/f27d39e767b06def059944b3bc5fd50797eaea96)]:
+  - @atlaspack/rust@3.1.1
+  - @atlaspack/cache@3.0.1
+  - @atlaspack/fs@2.14.3
+  - @atlaspack/logger@2.14.3
+  - @atlaspack/utils@2.14.3
+  - @atlaspack/package-manager@2.14.3
+  - @atlaspack/workers@2.14.3
+  - @atlaspack/types@2.14.3
+  - @atlaspack/plugin@2.14.3
+
 ## 2.15.1
 
 ### Patch Changes

package/lib/RequestTracker.js

@@ -759,8 +759,10 @@ class RequestTracker {
       return result;
     } else if (node.resultCacheKey != null && ifMatch == null) {
       let key = node.resultCacheKey;
-      (0, _assert().default)(this.options.cache.hasLargeBlob(key));
-      let cachedResult = (0, _buildCache().deserialize)(await this.options.cache.getLargeBlob(key));
+      if (!(0, _featureFlags().getFeatureFlag)('cachePerformanceImprovements')) {
+        (0, _assert().default)(this.options.cache.hasLargeBlob(key));
+      }
+      let cachedResult = (0, _featureFlags().getFeatureFlag)('cachePerformanceImprovements') ? (0, _nullthrows().default)(await this.options.cache.get(key)) : (0, _buildCache().deserialize)(await this.options.cache.getLargeBlob(key));
       node.result = cachedResult;
       return cachedResult;
     }
@@ -937,16 +939,21 @@ class RequestTracker {
       size: this.graph.nodes.length
     });
     let serialisedGraph = this.graph.serialize();
-
-    // Delete an existing request graph cache, to prevent invalid states
-    await this.options.cache.deleteLargeBlob(requestGraphKey);
+    if (!(0, _featureFlags().getFeatureFlag)('cachePerformanceImprovements')) {
+      // Delete an existing request graph cache, to prevent invalid states
+      await this.options.cache.deleteLargeBlob(requestGraphKey);
+    }
     const serialiseAndSet = async (key, contents) => {
       if (signal !== null && signal !== void 0 && signal.aborted) {
         throw new Error('Serialization was aborted');
       }
-      await this.options.cache.setLargeBlob(key, (0, _buildCache().serialize)(contents), signal ? {
-        signal: signal
-      } : undefined);
+      if ((0, _featureFlags().getFeatureFlag)('cachePerformanceImprovements')) {
+        await this.options.cache.set(key, (0, _buildCache().serialize)(contents));
+      } else {
+        await this.options.cache.setLargeBlob(key, (0, _buildCache().serialize)(contents), signal ? {
+          signal: signal
+        } : undefined);
+      }
       total += 1;
       (0, _ReporterRunner.report)({
         type: 'cache',
@@ -1050,6 +1057,13 @@ function getRequestGraphNodeKey(index, cacheKey) {
 }
 async function readAndDeserializeRequestGraph(cache, requestGraphKey, cacheKey) {
   let bufferLength = 0;
+  if ((0, _featureFlags().getFeatureFlag)('cachePerformanceImprovements')) {
+    let data = (0, _nullthrows().default)(await cache.get(requestGraphKey));
+    return {
+      requestGraph: RequestGraph.deserialize(data),
+      bufferLength
+    };
+  }
   const getAndDeserialize = async key => {
     let buffer = await cache.getLargeBlob(key);
     bufferLength += Buffer.byteLength(buffer);
@@ -1087,7 +1101,7 @@ async function loadRequestGraph(options) {
       snapshotKey
     }
   });
-  if (await options.cache.hasLargeBlob(requestGraphKey)) {
+  if (!(0, _featureFlags().getFeatureFlag)('cachePerformanceImprovements') && (await options.cache.hasLargeBlob(requestGraphKey))) {
     try {
       let {
         requestGraph

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@atlaspack/core",
-  "version": "2.15.1",
+  "version": "2.16.0",
   "license": "(MIT OR Apache-2.0)",
   "publishConfig": {
     "access": "public"
@@ -22,20 +22,20 @@
   "dependencies": {
     "@mischnic/json-sourcemap": "^0.1.0",
     "@atlaspack/build-cache": "2.13.3",
-    "@atlaspack/cache": "3.0.0",
+    "@atlaspack/cache": "3.0.1",
     "@atlaspack/diagnostic": "2.14.1",
     "@atlaspack/events": "2.14.1",
     "@atlaspack/feature-flags": "2.14.2",
-    "@atlaspack/fs": "2.14.2",
+    "@atlaspack/fs": "2.14.3",
     "@atlaspack/graph": "3.4.2",
-    "@atlaspack/logger": "2.14.2",
-    "@atlaspack/package-manager": "2.14.2",
-    "@atlaspack/plugin": "2.14.2",
+    "@atlaspack/logger": "2.14.3",
+    "@atlaspack/package-manager": "2.14.3",
+    "@atlaspack/plugin": "2.14.3",
     "@atlaspack/profiler": "2.14.2",
-    "@atlaspack/rust": "3.1.0",
-    "@atlaspack/types": "2.14.2",
-    "@atlaspack/utils": "2.14.2",
-    "@atlaspack/workers": "2.14.2",
+    "@atlaspack/rust": "3.1.1",
+    "@atlaspack/types": "2.14.3",
+    "@atlaspack/utils": "2.14.3",
+    "@atlaspack/workers": "2.14.3",
     "@parcel/source-map": "^2.1.1",
     "base-x": "^3.0.8",
     "browserslist": "^4.6.6",

package/src/RequestTracker.js

@@ -1228,10 +1228,13 @@ export default class RequestTracker {
       return result;
     } else if (node.resultCacheKey != null && ifMatch == null) {
       let key = node.resultCacheKey;
-      invariant(this.options.cache.hasLargeBlob(key));
-      let cachedResult: T = deserialize(
-        await this.options.cache.getLargeBlob(key),
-      );
+      if (!getFeatureFlag('cachePerformanceImprovements')) {
+        invariant(this.options.cache.hasLargeBlob(key));
+      }
+
+      let cachedResult: T = getFeatureFlag('cachePerformanceImprovements')
+        ? nullthrows(await this.options.cache.get<T>(key))
+        : deserialize(await this.options.cache.getLargeBlob(key));
       node.result = cachedResult;
       return cachedResult;
     }
@@ -1472,8 +1475,10 @@ export default class RequestTracker {
 
     let serialisedGraph = this.graph.serialize();
 
-    // Delete an existing request graph cache, to prevent invalid states
-    await this.options.cache.deleteLargeBlob(requestGraphKey);
+    if (!getFeatureFlag('cachePerformanceImprovements')) {
+      // Delete an existing request graph cache, to prevent invalid states
+      await this.options.cache.deleteLargeBlob(requestGraphKey);
+    }
 
     const serialiseAndSet = async (
       key: string,
@@ -1484,15 +1489,19 @@ export default class RequestTracker {
         throw new Error('Serialization was aborted');
       }
 
-      await this.options.cache.setLargeBlob(
-        key,
-        serialize(contents),
-        signal
-          ? {
-              signal: signal,
-            }
-          : undefined,
-      );
+      if (getFeatureFlag('cachePerformanceImprovements')) {
+        await this.options.cache.set(key, serialize(contents));
+      } else {
+        await this.options.cache.setLargeBlob(
+          key,
+          serialize(contents),
+          signal
+            ? {
+                signal: signal,
+              }
+            : undefined,
+        );
+      }
 
       total += 1;
 
@@ -1631,6 +1640,15 @@ export async function readAndDeserializeRequestGraph(
   cacheKey: string,
 ): Async<{|requestGraph: RequestGraph, bufferLength: number|}> {
   let bufferLength = 0;
+
+  if (getFeatureFlag('cachePerformanceImprovements')) {
+    let data = nullthrows(await cache.get(requestGraphKey));
+    return {
+      requestGraph: RequestGraph.deserialize(data),
+      bufferLength,
+    };
+  }
+
   const getAndDeserialize = async (key: string) => {
     let buffer = await cache.getLargeBlob(key);
     bufferLength += Buffer.byteLength(buffer);
@@ -1680,7 +1698,11 @@ async function loadRequestGraph(options): Async<RequestGraph> {
       snapshotKey,
     },
   });
-  if (await options.cache.hasLargeBlob(requestGraphKey)) {
+
+  if (
+    !getFeatureFlag('cachePerformanceImprovements') &&
+    (await options.cache.hasLargeBlob(requestGraphKey))
+  ) {
     try {
       let {requestGraph} = await readAndDeserializeRequestGraph(
         options.cache,