@atlaspack/core 2.12.1-dev.3401 → 2.12.1-dev.3443

package/test/AssetGraph.test.js

@@ -9,13 +9,16 @@ import AssetGraph, {
   nodeFromAsset,
 } from '../src/AssetGraph';
 import {createDependency as _createDependency} from '../src/Dependency';
-import {createAsset as _createAsset} from '../src/assetUtils';
+import {
+  createAsset as _createAsset,
+  type AssetOptions,
+} from '../src/assetUtils';
 import {DEFAULT_ENV, DEFAULT_TARGETS} from './test-utils';
 import {toProjectPath as _toProjectPath} from '../src/projectPath';
 
 const stats = {size: 0, time: 0};
 
-function createAsset(opts) {
+function createAsset(opts: AssetOptions) {
   return _createAsset('/', opts);
 }
 
@@ -134,7 +137,7 @@ describe('AssetGraph', () => {
       graph.hasContentKey(
         createDependency({
           specifier: 'path/to/index1/src/main.js',
-          specifierType: 'esm',
+          specifierType: 'url',
           target: DEFAULT_TARGETS[0],
           env: DEFAULT_ENV,
         }).id,
@@ -144,7 +147,7 @@ describe('AssetGraph', () => {
       graph.hasContentKey(
         createDependency({
           specifier: 'path/to/index2/src/main.js',
-          specifierType: 'esm',
+          specifierType: 'url',
           target: DEFAULT_TARGETS[0],
           env: DEFAULT_ENV,
         }).id,
@@ -191,7 +194,7 @@ describe('AssetGraph', () => {
         to: graph.getNodeIdByContentKey(
           createDependency({
             specifier: 'path/to/index1/src/main.js',
-            specifierType: 'esm',
+            specifierType: 'url',
             target: DEFAULT_TARGETS[0],
             env: DEFAULT_ENV,
           }).id,
@@ -208,7 +211,7 @@ describe('AssetGraph', () => {
         to: graph.getNodeIdByContentKey(
           createDependency({
             specifier: 'path/to/index2/src/main.js',
-            specifierType: 'esm',
+            specifierType: 'url',
             target: DEFAULT_TARGETS[0],
             env: DEFAULT_ENV,
           }).id,
@@ -246,7 +249,7 @@ describe('AssetGraph', () => {
 
     let dep = createDependency({
       specifier: 'path/to/index/src/main.js',
-      specifierType: 'esm',
+      specifierType: 'url',
       target: DEFAULT_TARGETS[0],
       env: DEFAULT_ENV,
     });
@@ -310,7 +313,7 @@ describe('AssetGraph', () => {
 
     let dep = createDependency({
       specifier: 'path/to/index/src/main.js',
-      specifierType: 'esm',
+      specifierType: 'url',
       target: DEFAULT_TARGETS[0],
       env: DEFAULT_ENV,
       sourcePath: '',
@@ -322,6 +325,7 @@ describe('AssetGraph', () => {
     let assets = [
       createAsset({
         id: '1',
+        code: null,
         filePath,
         type: 'js',
         isSource: true,
@@ -341,6 +345,7 @@ describe('AssetGraph', () => {
       }),
       createAsset({
         id: '2',
+        code: null,
         filePath,
         type: 'js',
         isSource: true,
@@ -360,6 +365,7 @@ describe('AssetGraph', () => {
       }),
       createAsset({
         id: '3',
+        code: null,
         filePath,
         type: 'js',
         isSource: true,
@@ -400,6 +406,7 @@ describe('AssetGraph', () => {
     let assets2 = [
       createAsset({
         id: '1',
+        code: null,
         filePath,
         type: 'js',
         isSource: true,
@@ -419,6 +426,7 @@ describe('AssetGraph', () => {
       }),
       createAsset({
         id: '2',
+        code: null,
         filePath,
         type: 'js',
         isSource: true,
@@ -473,7 +481,7 @@ describe('AssetGraph', () => {
 
     let dep = createDependency({
       specifier: 'path/to/index/src/main.js',
-      specifierType: 'esm',
+      specifierType: 'url',
       env: DEFAULT_ENV,
       target: DEFAULT_TARGETS[0],
     });
@@ -496,6 +504,7 @@ describe('AssetGraph', () => {
     let assets = [
       createAsset({
         id: '1',
+        code: null,
         filePath,
         type: 'js',
         isSource: true,
@@ -505,6 +514,7 @@ describe('AssetGraph', () => {
       }),
       createAsset({
         id: '2',
+        code: null,
         uniqueKey: 'dependent-asset-1',
         filePath,
         type: 'js',
@@ -515,6 +525,7 @@ describe('AssetGraph', () => {
       }),
       createAsset({
         id: '3',
+        code: null,
         uniqueKey: 'dependent-asset-2',
         filePath,
         type: 'js',
@@ -572,6 +583,7 @@ describe('AssetGraph', () => {
     });
     let indexAsset = createAsset({
       id: 'assetIndex',
+      code: null,
       filePath: toProjectPath('/index.js'),
       type: 'js',
       isSource: true,
@@ -600,6 +612,7 @@ describe('AssetGraph', () => {
     let fooUtilsDepNode = nodeFromDep(fooUtilsDep);
     let fooAsset = createAsset({
       id: 'assetFoo',
+      code: null,
       filePath: toProjectPath('/foo.js'),
       type: 'js',
       isSource: true,
@@ -642,6 +655,7 @@ describe('AssetGraph', () => {
     });
     let barAsset = createAsset({
       id: 'assetBar',
+      code: null,
       filePath: toProjectPath('/bar.js'),
       type: 'js',
       isSource: true,

package/test/AtlaspackConfigRequest.test.js

@@ -13,107 +13,11 @@ import {
   resolveAtlaspackConfig,
   processConfig,
 } from '../src/requests/AtlaspackConfigRequest';
-import {validatePackageName} from '../src/AtlaspackConfig.schema';
 import {DEFAULT_OPTIONS, relative} from './test-utils';
 import {toProjectPath} from '../src/projectPath';
 
 describe('AtlaspackConfigRequest', () => {
-  describe('validatePackageName', () => {
-    it('should error on an invalid official package', () => {
-      assert.throws(() => {
-        validatePackageName('@atlaspack/foo-bar', 'transform', 'transformers');
-      }, /Official atlaspack transform packages must be named according to "@atlaspack\/transform-{name}"/);
-
-      assert.throws(() => {
-        validatePackageName(
-          '@atlaspack/transformer',
-          'transform',
-          'transformers',
-        );
-      }, /Official atlaspack transform packages must be named according to "@atlaspack\/transform-{name}"/);
-    });
-
-    it('should succeed on a valid official package', () => {
-      validatePackageName(
-        '@atlaspack/transform-bar',
-        'transform',
-        'transformers',
-      );
-    });
-
-    it('should error on an invalid community package', () => {
-      assert.throws(() => {
-        validatePackageName('foo-bar', 'transform', 'transformers');
-      }, /Atlaspack transform packages must be named according to "parcel-transform-{name}"/);
-
-      assert.throws(() => {
-        validatePackageName('parcel-foo-bar', 'transform', 'transformers');
-      }, /Atlaspack transform packages must be named according to "parcel-transform-{name}"/);
-
-      assert.throws(() => {
-        validatePackageName('parcel-transform', 'transform', 'transformers');
-      }, /Atlaspack transform packages must be named according to "parcel-transform-{name}"/);
-    });
-
-    it('should succeed on a valid community package', () => {
-      validatePackageName('parcel-transform-bar', 'transform', 'transformers');
-    });
-
-    // Skipping this while the migration to parcel occurs
-    it.skip('should error on an invalid scoped package', () => {
-      assert.throws(() => {
-        validatePackageName('@test/foo-bar', 'transform', 'transformers');
-      }, /Scoped atlaspack transform packages must be named according to "@test\/parcel-transform\[-{name}\]"/);
-
-      assert.throws(() => {
-        validatePackageName(
-          '@test/atlaspack-foo-bar',
-          'transform',
-          'transformers',
-        );
-      }, /Scoped atlaspack transform packages must be named according to "@test\/parcel-transform\[-{name}\]"/);
-    });
-
-    it('should succeed on a valid scoped package', () => {
-      validatePackageName(
-        '@test/atlaspack-transform-bar',
-        'transform',
-        'transformers',
-      );
-
-      validatePackageName(
-        '@test/atlaspack-transform',
-        'transform',
-        'transformers',
-      );
-    });
-
-    it('should succeed on a local package', () => {
-      validatePackageName(
-        './atlaspack-transform-bar',
-        'transform',
-        'transformers',
-      );
-      validatePackageName('./bar', 'transform', 'transformers');
-    });
-  });
-
   describe('validateConfigFile', () => {
-    it('should throw on invalid config', () => {
-      assert.throws(() => {
-        validateConfigFile(
-          {
-            filePath: '.parcelrc',
-            extends: 'parcel-config-foo',
-            transformers: {
-              '*.js': ['parcel-invalid-plugin'],
-            },
-          },
-          '.parcelrc',
-        );
-      });
-    });
-
     it('should require pipeline to be an array', () => {
       assert.throws(() => {
         validateConfigFile(
@@ -140,18 +44,6 @@ describe('AtlaspackConfigRequest', () => {
       });
     });
 
-    it('should require package names to be valid', () => {
-      assert.throws(() => {
-        validateConfigFile(
-          {
-            filePath: '.parcelrc',
-            resolvers: ['parcel-foo-bar'],
-          },
-          '.parcelrc',
-        );
-      });
-    });
-
     it('should succeed with an array of valid package names', () => {
       validateConfigFile(
         {
@@ -185,21 +77,6 @@ describe('AtlaspackConfigRequest', () => {
       });
     });
 
-    it('should trigger the validator function for each key', () => {
-      assert.throws(() => {
-        validateConfigFile(
-          {
-            filePath: '.parcelrc',
-            transformers: {
-              'types:*.{ts,tsx}': ['@atlaspack/transformer-typescript-types'],
-              'bundle-text:*': ['-inline-string', '...'],
-            },
-          },
-          '.parcelrc',
-        );
-      });
-    });
-
     it('should require extends to be a string or array of strings', () => {
       assert.throws(() => {
         validateConfigFile(
@@ -242,44 +119,6 @@ describe('AtlaspackConfigRequest', () => {
       );
     });
 
-    it('should validate package names', () => {
-      assert.throws(() => {
-        validateConfigFile(
-          {
-            filePath: '.parcelrc',
-            extends: 'foo',
-          },
-          '.parcelrc',
-        );
-      });
-
-      assert.throws(() => {
-        validateConfigFile(
-          {
-            filePath: '.parcelrc',
-            extends: ['foo', 'bar'],
-          },
-          '.parcelrc',
-        );
-      });
-
-      validateConfigFile(
-        {
-          filePath: '.parcelrc',
-          extends: 'parcel-config-foo',
-        },
-        '.parcelrc',
-      );
-
-      validateConfigFile(
-        {
-          filePath: '.parcelrc',
-          extends: ['parcel-config-foo', 'parcel-config-bar'],
-        },
-        '.parcelrc',
-      );
-    });
-
     it('should throw for invalid top level keys', () => {
       assert.throws(
         () => {

package/test/BundleGraph.test.js

@@ -4,11 +4,14 @@ import assert from 'assert';
 import BundleGraph from '../src/BundleGraph';
 import {DEFAULT_ENV, DEFAULT_TARGETS} from './test-utils';
 import AssetGraph, {nodeFromAssetGroup} from '../src/AssetGraph';
-import {createAsset as _createAsset} from '../src/assetUtils';
+import {
+  createAsset as _createAsset,
+  type AssetOptions,
+} from '../src/assetUtils';
 import {createDependency as _createDependency} from '../src/Dependency';
 import {toProjectPath} from '../src/projectPath';
 
-function createAsset(opts) {
+function createAsset(opts: AssetOptions) {
   return _createAsset('/', opts);
 }
 
@@ -79,7 +82,7 @@ function createMockAssetGraph(ids: [string, string]) {
 
   let dep = createDependency({
     specifier: 'path/to/index/src/main.js',
-    specifierType: 'esm',
+    specifierType: 'url',
     env: DEFAULT_ENV,
     target: DEFAULT_TARGETS[0],
   });
@@ -98,6 +101,7 @@ function createMockAssetGraph(ids: [string, string]) {
   let assets = [
     createAsset({
       id: ids[0],
+      code: null,
       filePath,
       type: 'js',
       isSource: true,
@@ -107,6 +111,7 @@ function createMockAssetGraph(ids: [string, string]) {
     }),
     createAsset({
       id: ids[1],
+      code: null,
       filePath,
       type: 'js',
       isSource: true,

package/test/Dependency.test.js

@@ -0,0 +1,21 @@
+import expect from 'expect';
+import {createDependencyId} from '../src/Dependency';
+import {createEnvironment} from '../src/Environment';
+
+describe('Dependency', () => {
+  describe('createDependencyId', () => {
+    it('should create a stable id for a dependency', () => {
+      let id1 = createDependencyId({
+        specifier: 'foo',
+        env: createEnvironment(),
+        specifierType: 'esm',
+      });
+      let id2 = createDependencyId({
+        specifier: 'foo',
+        env: createEnvironment(),
+        specifierType: 'esm',
+      });
+      expect(id1).toEqual(id2);
+    });
+  });
+});

package/test/Environment.test.js

@@ -1,12 +1,15 @@
 // @flow strict-local
 
 import assert from 'assert';
+// $FlowFixMe
+import expect from 'expect';
 import {createEnvironment} from '../src/Environment';
+import {initializeMonitoring} from '../../rust';
 
 describe('Environment', () => {
   it('assigns a default environment with nothing passed', () => {
     assert.deepEqual(createEnvironment(), {
-      id: 'c242f987e3544367',
+      id: 'd821e85f6b50315e',
       context: 'browser',
       engines: {
         browsers: ['> 0.25%'],
@@ -24,7 +27,7 @@ describe('Environment', () => {
 
   it('assigns a node context if a node engine is given', () => {
     assert.deepEqual(createEnvironment({engines: {node: '>= 10.0.0'}}), {
-      id: '69e0ab7220ee8f7a',
+      id: '2320af923a717577',
       context: 'node',
       engines: {
         node: '>= 10.0.0',
@@ -44,7 +47,7 @@ describe('Environment', () => {
     assert.deepEqual(
       createEnvironment({engines: {browsers: ['last 1 version']}}),
       {
-        id: '4b5c9005af8c5b19',
+        id: '75603271034eff15',
         context: 'browser',
         engines: {
           browsers: ['last 1 version'],
@@ -63,7 +66,7 @@ describe('Environment', () => {
 
   it('assigns default engines for node', () => {
     assert.deepEqual(createEnvironment({context: 'node'}), {
-      id: 'f7c9644283a8698f',
+      id: 'e45cc12216f7857d',
       context: 'node',
       engines: {
         node: '>= 8.0.0',
@@ -81,7 +84,7 @@ describe('Environment', () => {
 
   it('assigns default engines for browsers', () => {
     assert.deepEqual(createEnvironment({context: 'browser'}), {
-      id: 'c242f987e3544367',
+      id: 'd821e85f6b50315e',
       context: 'browser',
       engines: {
         browsers: ['> 0.25%'],
@@ -97,3 +100,11 @@ describe('Environment', () => {
     });
   });
 });
+
+describe('createEnvironment', function () {
+  it('returns a stable hash', () => {
+    initializeMonitoring();
+    const environment = createEnvironment({});
+    expect(environment.id).toEqual('d821e85f6b50315e');
+  });
+});

package/test/InternalAsset.test.js

@@ -2,12 +2,15 @@
 
 import assert from 'assert';
 import UncommittedAsset from '../src/UncommittedAsset';
-import {createAsset as _createAsset} from '../src/assetUtils';
+import {
+  createAsset as _createAsset,
+  type AssetOptions,
+} from '../src/assetUtils';
 import {createEnvironment} from '../src/Environment';
 import {DEFAULT_OPTIONS} from './test-utils';
 import {toProjectPath} from '../src/projectPath';
 
-function createAsset(opts) {
+function createAsset(opts: AssetOptions) {
   return _createAsset('/', opts);
 }
 
@@ -18,6 +21,7 @@ describe('InternalAsset', () => {
     let asset = new UncommittedAsset({
       value: createAsset({
         filePath: toProjectPath('/', '/foo/asset.js'),
+        code: null,
         env: createEnvironment(),
         stats,
         type: 'js',
@@ -37,6 +41,7 @@ describe('InternalAsset', () => {
     let asset = new UncommittedAsset({
       value: createAsset({
         filePath: toProjectPath('/', '/foo/asset.js'),
+        code: null,
         env: createEnvironment(),
         stats,
         type: 'js',
@@ -56,6 +61,7 @@ describe('InternalAsset', () => {
     let asset = new UncommittedAsset({
       value: createAsset({
         filePath: toProjectPath('/', '/foo/asset.js'),
+        code: null,
         env: createEnvironment(),
         stats,
         type: 'js',

package/test/PublicAsset.test.js

@@ -3,12 +3,15 @@
 import assert from 'assert';
 import {Asset, MutableAsset} from '../src/public/Asset';
 import UncommittedAsset from '../src/UncommittedAsset';
-import {createAsset as _createAsset} from '../src/assetUtils';
+import {
+  createAsset as _createAsset,
+  type AssetOptions,
+} from '../src/assetUtils';
 import {createEnvironment} from '../src/Environment';
 import {DEFAULT_OPTIONS} from './test-utils';
 import {toProjectPath} from '../src/projectPath';
 
-function createAsset(opts) {
+function createAsset(opts: AssetOptions) {
   return _createAsset('/', opts);
 }
 
@@ -19,6 +22,7 @@ describe('Public Asset', () => {
       options: DEFAULT_OPTIONS,
       value: createAsset({
         filePath: toProjectPath('/', '/does/not/exist'),
+        code: null,
         type: 'js',
         env: createEnvironment({}),
         isSource: true,

package/test/PublicBundle.test.js

@@ -42,6 +42,7 @@ describe('Public Bundle', () => {
       assetPublicIds: new Set(),
       publicIdByAssetId: new Map(),
       bundleContentHashes: new Map(),
+      conditions: new Map(),
     });
   });
 

package/test/PublicMutableBundleGraph.test.js

@@ -8,12 +8,15 @@ import InternalBundleGraph from '../src/BundleGraph';
 import MutableBundleGraph from '../src/public/MutableBundleGraph';
 import {DEFAULT_ENV, DEFAULT_TARGETS, DEFAULT_OPTIONS} from './test-utils';
 import AssetGraph, {nodeFromAssetGroup} from '../src/AssetGraph';
-import {createAsset as _createAsset} from '../src/assetUtils';
+import {
+  createAsset as _createAsset,
+  type AssetOptions,
+} from '../src/assetUtils';
 import {createDependency as _createDependency} from '../src/Dependency';
 import nullthrows from 'nullthrows';
 import {toProjectPath} from '../src/projectPath';
 
-function createAsset(opts) {
+function createAsset(opts: AssetOptions) {
   return _createAsset('/', opts);
 }
 
@@ -139,14 +142,14 @@ function createMockAssetGraph() {
 
   let dep1 = createDependency({
     specifier: 'path/to/index/src/main.js',
-    specifierType: 'esm',
+    specifierType: 'url',
     needsStableName: true,
     env: DEFAULT_ENV,
     target: DEFAULT_TARGETS[0],
   });
   let dep2 = createDependency({
     specifier: 'path/to/index/src/main2.js',
-    specifierType: 'esm',
+    specifierType: 'url',
     needsStableName: true,
     env: DEFAULT_ENV,
     target: DEFAULT_TARGETS[0],
@@ -160,6 +163,7 @@ function createMockAssetGraph() {
     [
       createAsset({
         id: id1,
+        code: null,
         filePath,
         type: 'js',
         isSource: true,
@@ -178,6 +182,7 @@ function createMockAssetGraph() {
     [
       createAsset({
         id: id2,
+        code: null,
         filePath,
         type: 'js',
         isSource: true,