@atlaspack/core 2.12.1-canary.3533 → 2.12.1-canary.3535

package/lib/public/BundleGraph.js

@@ -204,10 +204,10 @@ class BundleGraph {
             // Asset is in the same bundle
             return [asset, []];
           }
-          const resolvedAsync = (0, _nullthrows().default)(this.#graph.resolveAsyncDependency(dep, (0, _Bundle.bundleToInternalBundle)(bundle)));
+          const resolvedAsync = (0, _nullthrows().default)(this.#graph.resolveAsyncDependency(dep, (0, _Bundle.bundleToInternalBundle)(bundle)), `Failed to load depenendency for '${dep.specifier}' specifier from '${String(dep.sourcePath)}'`);
           if ((resolvedAsync === null || resolvedAsync === void 0 ? void 0 : resolvedAsync.type) === 'asset') {
             // Single bundle to load dynamically
-            return [resolvedAsync.value, [this.#createBundle((0, _nullthrows().default)(this.#graph.getReferencedBundle(dep, (0, _Bundle.bundleToInternalBundle)(bundle))), this.#graph, this.#options)]];
+            return [resolvedAsync.value, [this.#createBundle((0, _nullthrows().default)(this.#graph.getReferencedBundle(dep, (0, _Bundle.bundleToInternalBundle)(bundle)), `Failed to load referenced bundle for '${dep.specifier}' specifier from '${String(dep.sourcePath)}'`), this.#graph, this.#options)]];
           } else {
             // Bundle group means we have multiple bundles to load first
             return [this.#graph.getAssetById(resolvedAsync.value.entryAssetId), this.#graph.getBundlesInBundleGroup(resolvedAsync.value).map(b => this.#createBundle(b, this.#graph, this.#options))];

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@atlaspack/core",
-  "version": "2.12.1-canary.3533+6e85f4328",
+  "version": "2.12.1-canary.3535+66c8cd01b",
   "license": "(MIT OR Apache-2.0)",
   "publishConfig": {
     "access": "public"
@@ -20,21 +20,21 @@
     "check-ts": "tsc --noEmit index.d.ts"
   },
   "dependencies": {
-    "@atlaspack/build-cache": "2.12.1-canary.3533+6e85f4328",
-    "@atlaspack/cache": "2.12.1-canary.3533+6e85f4328",
-    "@atlaspack/diagnostic": "2.12.1-canary.3533+6e85f4328",
-    "@atlaspack/events": "2.12.1-canary.3533+6e85f4328",
-    "@atlaspack/feature-flags": "2.12.1-canary.3533+6e85f4328",
-    "@atlaspack/fs": "2.12.1-canary.3533+6e85f4328",
-    "@atlaspack/graph": "3.2.1-canary.3533+6e85f4328",
-    "@atlaspack/logger": "2.12.1-canary.3533+6e85f4328",
-    "@atlaspack/package-manager": "2.12.1-canary.3533+6e85f4328",
-    "@atlaspack/plugin": "2.12.1-canary.3533+6e85f4328",
-    "@atlaspack/profiler": "2.12.1-canary.3533+6e85f4328",
-    "@atlaspack/rust": "2.12.1-canary.3533+6e85f4328",
-    "@atlaspack/types": "2.12.1-canary.3533+6e85f4328",
-    "@atlaspack/utils": "2.12.1-canary.3533+6e85f4328",
-    "@atlaspack/workers": "2.12.1-canary.3533+6e85f4328",
+    "@atlaspack/build-cache": "2.12.1-canary.3535+66c8cd01b",
+    "@atlaspack/cache": "2.12.1-canary.3535+66c8cd01b",
+    "@atlaspack/diagnostic": "2.12.1-canary.3535+66c8cd01b",
+    "@atlaspack/events": "2.12.1-canary.3535+66c8cd01b",
+    "@atlaspack/feature-flags": "2.12.1-canary.3535+66c8cd01b",
+    "@atlaspack/fs": "2.12.1-canary.3535+66c8cd01b",
+    "@atlaspack/graph": "3.2.1-canary.3535+66c8cd01b",
+    "@atlaspack/logger": "2.12.1-canary.3535+66c8cd01b",
+    "@atlaspack/package-manager": "2.12.1-canary.3535+66c8cd01b",
+    "@atlaspack/plugin": "2.12.1-canary.3535+66c8cd01b",
+    "@atlaspack/profiler": "2.12.1-canary.3535+66c8cd01b",
+    "@atlaspack/rust": "2.12.1-canary.3535+66c8cd01b",
+    "@atlaspack/types": "2.12.1-canary.3535+66c8cd01b",
+    "@atlaspack/utils": "2.12.1-canary.3535+66c8cd01b",
+    "@atlaspack/workers": "2.12.1-canary.3535+66c8cd01b",
     "@mischnic/json-sourcemap": "^0.1.0",
     "@parcel/source-map": "^2.1.1",
     "base-x": "^3.0.8",
@@ -66,5 +66,5 @@
   "browser": {
     "./src/serializerCore.js": "./src/serializerCore.browser.js"
   },
-  "gitHead": "6e85f4328ee2bce3b5882dc00a56d61e27a070a9"
+  "gitHead": "66c8cd01ba7f6e6d22b84933083865b826b605cd"
 }

package/src/loadAtlaspackPlugin.js

@@ -173,18 +173,26 @@ export default async function loadPlugin<T>(
   // Remove plugin version compatiblility validation in canary builds as they don't use semver
   if (!process.env.SKIP_PLUGIN_COMPATIBILITY_CHECK) {
     if (!pluginName.startsWith('.')) {
-      // Validate the engines.parcel field in the plugin's package.json
-      let parcelVersionRange = pkg && pkg.engines && pkg.engines.parcel;
-      if (!parcelVersionRange) {
+      // Validate the plugin engines field
+      let key = 'atlaspack';
+      let atlaspackVersionRange;
+      if (pkg?.engines?.atlaspack) {
+        atlaspackVersionRange = pkg.engines.atlaspack;
+      } else if (pkg?.engines?.parcel) {
+        key = 'parcel';
+        atlaspackVersionRange = pkg.engines.parcel;
+      }
+
+      if (!atlaspackVersionRange) {
         logger.warn({
           origin: '@atlaspack/core',
-          message: `The plugin "${pluginName}" needs to specify a \`package.json#engines.parcel\` field with the supported Atlaspack version range.`,
+          message: `The plugin "${pluginName}" needs to specify a \`package.json#engines.atlaspack\` field with the supported Atlaspack version range.`,
         });
       }
 
       if (
-        parcelVersionRange &&
-        !semver.satisfies(ATLASPACK_VERSION, parcelVersionRange)
+        atlaspackVersionRange &&
+        !semver.satisfies(ATLASPACK_VERSION, atlaspackVersionRange)
       ) {
         let pkgFile = nullthrows(
           await resolveConfig(
@@ -197,7 +205,7 @@ export default async function loadPlugin<T>(
         let pkgContents = await options.inputFS.readFile(pkgFile, 'utf8');
         throw new ThrowableDiagnostic({
           diagnostic: {
-            message: md`The plugin "${pluginName}" is not compatible with the current version of Atlaspack. Requires "${parcelVersionRange}" but the current version is "${ATLASPACK_VERSION}".`,
+            message: md`The plugin "${pluginName}" is not compatible with the current version of Atlaspack. Requires "${atlaspackVersionRange}" but the current version is "${ATLASPACK_VERSION}".`,
             origin: '@atlaspack/core',
             codeFrames: [
               {
@@ -206,7 +214,7 @@ export default async function loadPlugin<T>(
                 code: pkgContents,
                 codeHighlights: generateJSONCodeHighlights(pkgContents, [
                   {
-                    key: '/engines/parcel',
+                    key: `/engines/${key}`,
                   },
                 ]),
               },

package/src/public/BundleGraph.js

@@ -378,6 +378,9 @@ export default class BundleGraph<TBundle: IBundle>
               dep,
               bundleToInternalBundle(bundle),
             ),
+            `Failed to load depenendency for '${
+              dep.specifier
+            }' specifier from '${String(dep.sourcePath)}'`,
           );
           if (resolvedAsync?.type === 'asset') {
             // Single bundle to load dynamically
@@ -390,6 +393,9 @@ export default class BundleGraph<TBundle: IBundle>
                       dep,
                       bundleToInternalBundle(bundle),
                     ),
+                    `Failed to load referenced bundle for '${
+                      dep.specifier
+                    }' specifier from '${String(dep.sourcePath)}'`,
                   ),
                   this.#graph,
                   this.#options,

package/test/AtlaspackConfig.test.js

@@ -127,12 +127,13 @@ describe('AtlaspackConfig', () => {
   });
 
   describe('loadPlugin', () => {
-    it('should warn if a plugin needs to specify an engines.parcel field in package.json', async () => {
+    it('should warn if a plugin needs to specify an engines.atlaspack field in package.json', async () => {
       let projectRoot = path.join(__dirname, 'fixtures', 'plugins');
       let configFilePath = toProjectPath(
         projectRoot,
-        path.join(__dirname, 'fixtures', 'plugins', '.parcelrc'),
+        path.join(projectRoot, '.parcelrc'),
       );
+
       let config = new AtlaspackConfig(
         {
           filePath: configFilePath,
@@ -140,7 +141,7 @@ describe('AtlaspackConfig', () => {
           transformers: {
             '*.js': [
               {
-                packageName: 'parcel-transformer-no-engines',
+                packageName: 'atlaspack-transformer-no-engines',
                 resolveFrom: configFilePath,
                 keyPath: '/transformers/*.js/0',
               },
@@ -152,51 +153,103 @@ describe('AtlaspackConfig', () => {
 
       let warnStub = sinon.stub(logger, 'warn');
       let {plugin} = await config.loadPlugin({
-        packageName: 'parcel-transformer-no-engines',
+        packageName: 'atlaspack-transformer-no-engines',
         resolveFrom: configFilePath,
         keyPath: '/transformers/*.js/0',
       });
-      assert(plugin);
-      assert.equal(typeof plugin.transform, 'function');
+
+      assert.equal(typeof plugin?.transform, 'function');
       assert(warnStub.calledOnce);
       assert.deepEqual(warnStub.getCall(0).args[0], {
         origin: '@atlaspack/core',
         message:
-          'The plugin "parcel-transformer-no-engines" needs to specify a `package.json#engines.parcel` field with the supported Atlaspack version range.',
+          'The plugin "atlaspack-transformer-no-engines" needs to specify a `package.json#engines.atlaspack` field with the supported Atlaspack version range.',
       });
       warnStub.restore();
     });
 
+    it('should error if a plugin specifies an invalid engines.atlaspack field in package.json', async () => {
+      let projectRoot = path.join(__dirname, 'fixtures', 'plugins');
+      let configFilePath = toProjectPath(
+        projectRoot,
+        path.join(projectRoot, '.parcelrc'),
+      );
+
+      let config = new AtlaspackConfig(
+        {
+          filePath: configFilePath,
+          bundler: undefined,
+          transformers: {},
+        },
+        {...DEFAULT_OPTIONS, projectRoot},
+      );
+
+      // $FlowFixMe[untyped-import]
+      let atlaspackVersion = require('../package.json').version;
+      let pkgJSON = path.join(
+        projectRoot,
+        'node_modules',
+        'atlaspack-transformer-bad-engines',
+        'package.json',
+      );
+      let code = inputFS.readFileSync(pkgJSON, 'utf8');
+
+      // $FlowFixMe
+      await assert.rejects(
+        () =>
+          config.loadPlugin({
+            packageName: 'atlaspack-transformer-bad-engines',
+            resolveFrom: configFilePath,
+            keyPath: '/transformers/*.js/0',
+          }),
+        {
+          name: 'Error',
+          diagnostics: [
+            {
+              message: `The plugin "atlaspack-transformer-bad-engines" is not compatible with the current version of Atlaspack. Requires "1.x" but the current version is "${atlaspackVersion}".`,
+              origin: '@atlaspack/core',
+              codeFrames: [
+                {
+                  filePath: pkgJSON,
+                  language: 'json5',
+                  code,
+                  codeHighlights: [
+                    {
+                      start: {line: 5, column: 5},
+                      end: {line: 5, column: 22},
+                      message: undefined,
+                    },
+                  ],
+                },
+              ],
+            },
+          ],
+        },
+      );
+    });
+
     it('should error if a plugin specifies an invalid engines.parcel field in package.json', async () => {
       let projectRoot = path.join(__dirname, 'fixtures', 'plugins');
       let configFilePath = toProjectPath(
         projectRoot,
-        path.join(__dirname, 'fixtures', 'plugins', '.parcelrc'),
+        path.join(projectRoot, '.parcelrc'),
       );
+
       let config = new AtlaspackConfig(
         {
           filePath: configFilePath,
           bundler: undefined,
-          transformers: {
-            '*.js': [
-              {
-                packageName: 'parcel-transformer-not-found',
-                resolveFrom: configFilePath,
-                keyPath: '/transformers/*.js/0',
-              },
-            ],
-          },
+          transformers: {},
         },
         {...DEFAULT_OPTIONS, projectRoot},
       );
+
       // $FlowFixMe[untyped-import]
-      let parcelVersion = require('../package.json').version;
+      let atlaspackVersion = require('../package.json').version;
       let pkgJSON = path.join(
-        __dirname,
-        'fixtures',
-        'plugins',
+        projectRoot,
         'node_modules',
-        'parcel-transformer-bad-engines',
+        'atlaspack-transformer-bad-parcel-engines',
         'package.json',
       );
       let code = inputFS.readFileSync(pkgJSON, 'utf8');
@@ -205,7 +258,7 @@ describe('AtlaspackConfig', () => {
       await assert.rejects(
         () =>
           config.loadPlugin({
-            packageName: 'parcel-transformer-bad-engines',
+            packageName: 'atlaspack-transformer-bad-parcel-engines',
             resolveFrom: configFilePath,
             keyPath: '/transformers/*.js/0',
           }),
@@ -213,7 +266,7 @@ describe('AtlaspackConfig', () => {
           name: 'Error',
           diagnostics: [
             {
-              message: `The plugin "parcel-transformer-bad-engines" is not compatible with the current version of Atlaspack. Requires "5.x" but the current version is "${parcelVersion}".`,
+              message: `The plugin "atlaspack-transformer-bad-parcel-engines" is not compatible with the current version of Atlaspack. Requires "1.x" but the current version is "${atlaspackVersion}".`,
               origin: '@atlaspack/core',
               codeFrames: [
                 {

package/test/fixtures/local-plugin-config-pkg/node_modules/parcel-config-local/package.json

@@ -1,7 +1,4 @@
 {
   "name": "parcel-config-local",
-  "version": "1.0.0",
-  "engines": {
-    "parcel": "2.x"
-  }
+  "version": "1.0.0"
 }

package/test/fixtures/plugins/node_modules/atlaspack-transformer-bad-engines/package.json

@@ -0,0 +1,7 @@
+{
+  "name": "atlaspack-transformer-bad-engines",
+  "version": "1.0.0",
+  "engines": {
+    "atlaspack": "1.x"
+  }
+}

package/test/fixtures/plugins/node_modules/atlaspack-transformer-bad-parcel-engines/package.json

@@ -0,0 +1,7 @@
+{
+  "name": "atlaspack-transformer-bad-parcel-engines",
+  "version": "1.0.0",
+  "engines": {
+    "parcel": "1.x"
+  }
+}

package/test/fixtures/plugins/node_modules/atlaspack-transformer-no-engines/index.js

@@ -0,0 +1,7 @@
+const {Transformer} = require('@atlaspack/plugin');
+
+module.exports = new Transformer({
+  transform(asset) {
+    return [asset];
+  }
+});

package/test/fixtures/plugins/node_modules/atlaspack-transformer-no-engines/package.json

@@ -0,0 +1,4 @@
+{
+  "name": "atlaspack-transformer-no-engines",
+  "version": "1.0.0"
+}

package/test/fixtures/plugins/node_modules/parcel-transformer-bad-engines/package.json

@@ -1,7 +0,0 @@
-{
-  "name": "parcel-transformer-bad-engines",
-  "version": "1.0.0",
-  "engines": {
-    "parcel": "5.x"
-  }
-}

package/test/fixtures/plugins/node_modules/parcel-transformer-no-engines/package.json

@@ -1,4 +0,0 @@
-{
-  "name": "parcel-transformer-no-engines",
-  "version": "1.0.0"
-}