@atlaspack/core 2.12.1-canary.3377 → 2.12.1-canary.3379

package/lib/AtlaspackConfig.schema.js

@@ -5,42 +5,16 @@ Object.defineProperty(exports, "__esModule", {
 });
 exports.default = void 0;
 exports.validatePackageName = validatePackageName;
-function _assert() {
-  const data = _interopRequireDefault(require("assert"));
-  _assert = function () {
-    return data;
-  };
-  return data;
-}
-function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }
-// Reasoning behind this validation:
-// https://github.com/parcel-bundler/parcel/issues/3397#issuecomment-521353931
-function validatePackageName(pkg, pluginType, key) {
-  // $FlowFixMe
-  if (!pkg) {
-    return;
-  }
-  (0, _assert().default)(typeof pkg === 'string', `"${key}" must be a string`);
-
-  // Probably all of these need to be removed
-  if (pkg.startsWith('@atlaspack') || pkg.startsWith('@parcel')) {
-    (0, _assert().default)(pkg.replace(/^@(atlaspack|parcel)\//, '').startsWith(`${pluginType}-`), `Official atlaspack ${pluginType} packages must be named according to "@atlaspack/${pluginType}-{name}"`);
-  } else if (pkg.startsWith('@')) {
-    // Disabling this validation to allow for migration to parcel
-    // let [scope, name] = pkg.split('/');
-    // assert(
-    //   name.startsWith(`parcel-${pluginType}-`) ||
-    //     name === `parcel-${pluginType}` ||
-    //     name.startsWith(`parcel-${pluginType}-`) ||
-    //     name === `parcel-${pluginType}`,
-    //   `Scoped parcel ${pluginType} packages must be named according to "${scope}/parcel-${pluginType}[-{name}]"`,
-    // );
-  } else if (!pkg.startsWith('.')) {
-    (0, _assert().default)(pkg.startsWith(`parcel-${pluginType}-`) || pkg.startsWith(`atlaspack-${pluginType}`),
-    // let the error message be wrong for now
-    `Atlaspack ${pluginType} packages must be named according to "parcel-${pluginType}-{name}"`);
-  }
-}
+// Parcel validates plugin package names due to:
+//
+// * https://github.com/parcel-bundler/parcel/issues/3397#issuecomment-521353931
+//
+// Ultimately:
+//
+// * We do not care about package names
+// * Validation makes interop between parcel/atlaspack confusing.
+//
+function validatePackageName() {}
 const validatePluginName = (pluginType, key) => {
   return val => {
     // allow plugin spread...

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@atlaspack/core",
-  "version": "2.12.1-canary.3377+a23acfda3",
+  "version": "2.12.1-canary.3379+e4dbdd5c5",
   "license": "MIT",
   "publishConfig": {
     "access": "public"
@@ -20,20 +20,20 @@
     "check-ts": "tsc --noEmit index.d.ts"
   },
   "dependencies": {
-    "@atlaspack/cache": "2.12.1-canary.3377+a23acfda3",
-    "@atlaspack/diagnostic": "2.12.1-canary.3377+a23acfda3",
-    "@atlaspack/events": "2.12.1-canary.3377+a23acfda3",
-    "@atlaspack/feature-flags": "2.12.1-canary.3377+a23acfda3",
-    "@atlaspack/fs": "2.12.1-canary.3377+a23acfda3",
-    "@atlaspack/graph": "3.2.1-canary.3377+a23acfda3",
-    "@atlaspack/logger": "2.12.1-canary.3377+a23acfda3",
-    "@atlaspack/package-manager": "2.12.1-canary.3377+a23acfda3",
-    "@atlaspack/plugin": "2.12.1-canary.3377+a23acfda3",
-    "@atlaspack/profiler": "2.12.1-canary.3377+a23acfda3",
-    "@atlaspack/rust": "2.12.1-canary.3377+a23acfda3",
-    "@atlaspack/types": "2.12.1-canary.3377+a23acfda3",
-    "@atlaspack/utils": "2.12.1-canary.3377+a23acfda3",
-    "@atlaspack/workers": "2.12.1-canary.3377+a23acfda3",
+    "@atlaspack/cache": "2.12.1-canary.3379+e4dbdd5c5",
+    "@atlaspack/diagnostic": "2.12.1-canary.3379+e4dbdd5c5",
+    "@atlaspack/events": "2.12.1-canary.3379+e4dbdd5c5",
+    "@atlaspack/feature-flags": "2.12.1-canary.3379+e4dbdd5c5",
+    "@atlaspack/fs": "2.12.1-canary.3379+e4dbdd5c5",
+    "@atlaspack/graph": "3.2.1-canary.3379+e4dbdd5c5",
+    "@atlaspack/logger": "2.12.1-canary.3379+e4dbdd5c5",
+    "@atlaspack/package-manager": "2.12.1-canary.3379+e4dbdd5c5",
+    "@atlaspack/plugin": "2.12.1-canary.3379+e4dbdd5c5",
+    "@atlaspack/profiler": "2.12.1-canary.3379+e4dbdd5c5",
+    "@atlaspack/rust": "2.12.1-canary.3379+e4dbdd5c5",
+    "@atlaspack/types": "2.12.1-canary.3379+e4dbdd5c5",
+    "@atlaspack/utils": "2.12.1-canary.3379+e4dbdd5c5",
+    "@atlaspack/workers": "2.12.1-canary.3379+e4dbdd5c5",
     "@mischnic/json-sourcemap": "^0.1.0",
     "@parcel/source-map": "^2.1.1",
     "base-x": "^3.0.8",
@@ -55,5 +55,5 @@
   "browser": {
     "./src/serializerCore.js": "./src/serializerCore.browser.js"
   },
-  "gitHead": "a23acfda3ced342df606caa384bac157119d33b3"
+  "gitHead": "e4dbdd5c542a6dc690329839dc2bec8c797b72ba"
 }

package/src/AtlaspackConfig.schema.js

@@ -1,47 +1,24 @@
 // @flow strict-local
 import type {PackageName} from '@atlaspack/types';
 import type {SchemaEntity} from '@atlaspack/utils';
-import assert from 'assert';
 
-// Reasoning behind this validation:
-// https://github.com/parcel-bundler/parcel/issues/3397#issuecomment-521353931
+// Parcel validates plugin package names due to:
+//
+// * https://github.com/parcel-bundler/parcel/issues/3397#issuecomment-521353931
+//
+// Ultimately:
+//
+// * We do not care about package names
+// * Validation makes interop between parcel/atlaspack confusing.
+//
 export function validatePackageName(
+  // eslint-disable-next-line no-unused-vars
   pkg: ?PackageName,
+  // eslint-disable-next-line no-unused-vars
   pluginType: string,
+  // eslint-disable-next-line no-unused-vars
   key: string,
-) {
-  // $FlowFixMe
-  if (!pkg) {
-    return;
-  }
-
-  assert(typeof pkg === 'string', `"${key}" must be a string`);
-
-  // Probably all of these need to be removed
-  if (pkg.startsWith('@atlaspack') || pkg.startsWith('@parcel')) {
-    assert(
-      pkg.replace(/^@(atlaspack|parcel)\//, '').startsWith(`${pluginType}-`),
-      `Official atlaspack ${pluginType} packages must be named according to "@atlaspack/${pluginType}-{name}"`,
-    );
-  } else if (pkg.startsWith('@')) {
-    // Disabling this validation to allow for migration to parcel
-    // let [scope, name] = pkg.split('/');
-    // assert(
-    //   name.startsWith(`parcel-${pluginType}-`) ||
-    //     name === `parcel-${pluginType}` ||
-    //     name.startsWith(`parcel-${pluginType}-`) ||
-    //     name === `parcel-${pluginType}`,
-    //   `Scoped parcel ${pluginType} packages must be named according to "${scope}/parcel-${pluginType}[-{name}]"`,
-    // );
-  } else if (!pkg.startsWith('.')) {
-    assert(
-      pkg.startsWith(`parcel-${pluginType}-`) ||
-        pkg.startsWith(`atlaspack-${pluginType}`),
-      // let the error message be wrong for now
-      `Atlaspack ${pluginType} packages must be named according to "parcel-${pluginType}-{name}"`,
-    );
-  }
-}
+) {}
 
 const validatePluginName = (pluginType: string, key: string) => {
   return (val: string) => {

package/test/AtlaspackConfigRequest.test.js

@@ -13,107 +13,11 @@ import {
   resolveAtlaspackConfig,
   processConfig,
 } from '../src/requests/AtlaspackConfigRequest';
-import {validatePackageName} from '../src/AtlaspackConfig.schema';
 import {DEFAULT_OPTIONS, relative} from './test-utils';
 import {toProjectPath} from '../src/projectPath';
 
 describe('AtlaspackConfigRequest', () => {
-  describe('validatePackageName', () => {
-    it('should error on an invalid official package', () => {
-      assert.throws(() => {
-        validatePackageName('@atlaspack/foo-bar', 'transform', 'transformers');
-      }, /Official atlaspack transform packages must be named according to "@atlaspack\/transform-{name}"/);
-
-      assert.throws(() => {
-        validatePackageName(
-          '@atlaspack/transformer',
-          'transform',
-          'transformers',
-        );
-      }, /Official atlaspack transform packages must be named according to "@atlaspack\/transform-{name}"/);
-    });
-
-    it('should succeed on a valid official package', () => {
-      validatePackageName(
-        '@atlaspack/transform-bar',
-        'transform',
-        'transformers',
-      );
-    });
-
-    it('should error on an invalid community package', () => {
-      assert.throws(() => {
-        validatePackageName('foo-bar', 'transform', 'transformers');
-      }, /Atlaspack transform packages must be named according to "parcel-transform-{name}"/);
-
-      assert.throws(() => {
-        validatePackageName('parcel-foo-bar', 'transform', 'transformers');
-      }, /Atlaspack transform packages must be named according to "parcel-transform-{name}"/);
-
-      assert.throws(() => {
-        validatePackageName('parcel-transform', 'transform', 'transformers');
-      }, /Atlaspack transform packages must be named according to "parcel-transform-{name}"/);
-    });
-
-    it('should succeed on a valid community package', () => {
-      validatePackageName('parcel-transform-bar', 'transform', 'transformers');
-    });
-
-    // Skipping this while the migration to parcel occurs
-    it.skip('should error on an invalid scoped package', () => {
-      assert.throws(() => {
-        validatePackageName('@test/foo-bar', 'transform', 'transformers');
-      }, /Scoped atlaspack transform packages must be named according to "@test\/parcel-transform\[-{name}\]"/);
-
-      assert.throws(() => {
-        validatePackageName(
-          '@test/atlaspack-foo-bar',
-          'transform',
-          'transformers',
-        );
-      }, /Scoped atlaspack transform packages must be named according to "@test\/parcel-transform\[-{name}\]"/);
-    });
-
-    it('should succeed on a valid scoped package', () => {
-      validatePackageName(
-        '@test/atlaspack-transform-bar',
-        'transform',
-        'transformers',
-      );
-
-      validatePackageName(
-        '@test/atlaspack-transform',
-        'transform',
-        'transformers',
-      );
-    });
-
-    it('should succeed on a local package', () => {
-      validatePackageName(
-        './atlaspack-transform-bar',
-        'transform',
-        'transformers',
-      );
-      validatePackageName('./bar', 'transform', 'transformers');
-    });
-  });
-
   describe('validateConfigFile', () => {
-    it('should throw on invalid config', () => {
-      assert.throws(() => {
-        validateConfigFile(
-          {
-            filePath: '.parcelrc',
-            extends: 'parcel-config-foo',
-            transformers: {
-              '*.js': ['parcel-invalid-plugin'],
-            },
-          },
-          '.parcelrc',
-        );
-      });
-    });
-
     it('should require pipeline to be an array', () => {
       assert.throws(() => {
         validateConfigFile(
@@ -140,18 +44,6 @@ describe('AtlaspackConfigRequest', () => {
       });
     });
 
-    it('should require package names to be valid', () => {
-      assert.throws(() => {
-        validateConfigFile(
-          {
-            filePath: '.parcelrc',
-            resolvers: ['parcel-foo-bar'],
-          },
-          '.parcelrc',
-        );
-      });
-    });
-
     it('should succeed with an array of valid package names', () => {
       validateConfigFile(
         {
@@ -185,21 +77,6 @@ describe('AtlaspackConfigRequest', () => {
       });
     });
 
-    it('should trigger the validator function for each key', () => {
-      assert.throws(() => {
-        validateConfigFile(
-          {
-            filePath: '.parcelrc',
-            transformers: {
-              'types:*.{ts,tsx}': ['@atlaspack/transformer-typescript-types'],
-              'bundle-text:*': ['-inline-string', '...'],
-            },
-          },
-          '.parcelrc',
-        );
-      });
-    });
-
     it('should require extends to be a string or array of strings', () => {
       assert.throws(() => {
         validateConfigFile(
@@ -242,44 +119,6 @@ describe('AtlaspackConfigRequest', () => {
       );
     });
 
-    it('should validate package names', () => {
-      assert.throws(() => {
-        validateConfigFile(
-          {
-            filePath: '.parcelrc',
-            extends: 'foo',
-          },
-          '.parcelrc',
-        );
-      });
-
-      assert.throws(() => {
-        validateConfigFile(
-          {
-            filePath: '.parcelrc',
-            extends: ['foo', 'bar'],
-          },
-          '.parcelrc',
-        );
-      });
-
-      validateConfigFile(
-        {
-          filePath: '.parcelrc',
-          extends: 'parcel-config-foo',
-        },
-        '.parcelrc',
-      );
-
-      validateConfigFile(
-        {
-          filePath: '.parcelrc',
-          extends: ['parcel-config-foo', 'parcel-config-bar'],
-        },
-        '.parcelrc',
-      );
-    });
-
     it('should throw for invalid top level keys', () => {
       assert.throws(
         () => {