@atlaskit/user-picker 8.6.2 → 8.6.3

package/CHANGELOG.md

@@ -1,5 +1,11 @@
 # @atlaskit/user-picker
 
+## 8.6.3
+
+### Patch Changes
+
+- [`6503f21cfc0`](https://bitbucket.org/atlassian/atlassian-frontend/commits/6503f21cfc0) - [ux] Fix defaultValue behavior for user-picker and smart-user-picker. user-picker previously advertised hydrating default values if provided in unhydrated form. This was never the case; it is only hydrated from smart-user-picker. defaultValue would also be ignored if provided as a single OptionValue despite the typing being advertised as supporting it - this is now fixed.
+
 ## 8.6.2
 
 ### Patch Changes

package/dist/cjs/components/BaseUserPicker.js

@@ -553,7 +553,7 @@ var BaseUserPickerWithoutAnalytics = /*#__PURE__*/function (_React$Component) {
 
       if (nextProps.value !== undefined) {
         derivedState.value = (0, _utils.optionToSelectableOptions)(nextProps.value);
-      } else if (nextProps.defaultValue && Array.isArray(nextProps.defaultValue) && nextProps.defaultValue.length > 0 && !prevState.isDefaultSet) {
+      } else if ((0, _utils.isDefaultValuePopulated)(nextProps.defaultValue) && !prevState.isDefaultSet) {
         derivedState.value = (0, _utils.optionToSelectableOptions)(nextProps.defaultValue);
         derivedState.isDefaultSet = true;
       }

package/dist/cjs/components/utils.js

@@ -5,7 +5,7 @@ var _interopRequireDefault = require("@babel/runtime/helpers/interopRequireDefau
 Object.defineProperty(exports, "__esModule", {
   value: true
 });
-exports.userPickerRenderedUfoExperience = exports.optionToSelectableOptions = exports.optionToSelectableOption = exports.isUser = exports.isTeam = exports.isSingleValue = exports.isPopupUserPickerByProps = exports.isPopupUserPickerByComponent = exports.isIterable = exports.isGroup = exports.isExternalUser = exports.isEmail = exports.isChildInput = exports.hasValue = exports.getOptions = exports.getAvatarUrl = exports.getAvatarSize = exports.extractOptionValue = exports.callCallback = void 0;
+exports.userPickerRenderedUfoExperience = exports.optionToSelectableOptions = exports.optionToSelectableOption = exports.isUser = exports.isTeam = exports.isSingleValue = exports.isPopupUserPickerByProps = exports.isPopupUserPickerByComponent = exports.isIterable = exports.isGroup = exports.isExternalUser = exports.isEmail = exports.isDefaultValuePopulated = exports.isChildInput = exports.hasValue = exports.getOptions = exports.getAvatarUrl = exports.getAvatarSize = exports.extractOptionValue = exports.callCallback = void 0;
 
 var _typeof2 = _interopRequireDefault(require("@babel/runtime/helpers/typeof"));
 
@@ -53,6 +53,12 @@ var isEmail = function isEmail(option) {
 
 exports.isEmail = isEmail;
 
+var isDefaultValuePopulated = function isDefaultValuePopulated(value) {
+  return value && !Array.isArray(value) || Array.isArray(value) && value.length > 0;
+};
+
+exports.isDefaultValuePopulated = isDefaultValuePopulated;
+
 var isOptionData = function isOptionData(option) {
   return option.name !== undefined;
 };

package/dist/cjs/version.json

@@ -1,5 +1,5 @@
 {
 	"name": "@atlaskit/user-picker",
-	"version": "8.6.2",
+	"version": "8.6.3",
 	"sideEffects": false
 }

package/dist/es2019/components/BaseUserPicker.js

@@ -7,7 +7,7 @@ import { FormattedMessage } from 'react-intl-next';
 import { cancelEvent, clearEvent, createAndFireEventInElementsChannel, deleteEvent, failedEvent, focusEvent, searchedEvent, selectEvent, startSession } from '../analytics';
 import { batchByKey } from './batch';
 import { messages } from './i18n';
-import { callCallback, extractOptionValue, getOptions, isIterable, isPopupUserPickerByComponent, isSingleValue, optionToSelectableOptions } from './utils';
+import { callCallback, extractOptionValue, getOptions, isIterable, isPopupUserPickerByComponent, isDefaultValuePopulated, isSingleValue, optionToSelectableOptions } from './utils';
 
 const loadingMessage = () => null;
 
@@ -21,7 +21,7 @@ export class BaseUserPickerWithoutAnalytics extends React.Component {
 
     if (nextProps.value !== undefined) {
       derivedState.value = optionToSelectableOptions(nextProps.value);
-    } else if (nextProps.defaultValue && Array.isArray(nextProps.defaultValue) && nextProps.defaultValue.length > 0 && !prevState.isDefaultSet) {
+    } else if (isDefaultValuePopulated(nextProps.defaultValue) && !prevState.isDefaultSet) {
       derivedState.value = optionToSelectableOptions(nextProps.defaultValue);
       derivedState.isDefaultSet = true;
     }

package/dist/es2019/components/utils.js

@@ -7,6 +7,7 @@ export const isUser = option => option.type === undefined || option.type === Use
 export const isTeam = option => option.type === TeamType;
 export const isGroup = option => option.type === GroupType;
 export const isEmail = option => option.type === EmailType;
+export const isDefaultValuePopulated = value => value && !Array.isArray(value) || Array.isArray(value) && value.length > 0;
 
 const isOptionData = option => option.name !== undefined;
 

package/dist/es2019/version.json

@@ -1,5 +1,5 @@
 {
 	"name": "@atlaskit/user-picker",
-	"version": "8.6.2",
+	"version": "8.6.3",
 	"sideEffects": false
 }

package/dist/esm/components/BaseUserPicker.js

@@ -24,7 +24,7 @@ import { FormattedMessage } from 'react-intl-next';
 import { cancelEvent, clearEvent, createAndFireEventInElementsChannel, deleteEvent, failedEvent, focusEvent, searchedEvent, selectEvent, startSession } from '../analytics';
 import { batchByKey } from './batch';
 import { messages } from './i18n';
-import { callCallback, extractOptionValue, getOptions, isIterable, isPopupUserPickerByComponent, isSingleValue, optionToSelectableOptions } from './utils';
+import { callCallback, extractOptionValue, getOptions, isIterable, isPopupUserPickerByComponent, isDefaultValuePopulated, isSingleValue, optionToSelectableOptions } from './utils';
 
 var loadingMessage = function loadingMessage() {
   return null;
@@ -556,7 +556,7 @@ export var BaseUserPickerWithoutAnalytics = /*#__PURE__*/function (_React$Compon
 
       if (nextProps.value !== undefined) {
         derivedState.value = optionToSelectableOptions(nextProps.value);
-      } else if (nextProps.defaultValue && Array.isArray(nextProps.defaultValue) && nextProps.defaultValue.length > 0 && !prevState.isDefaultSet) {
+      } else if (isDefaultValuePopulated(nextProps.defaultValue) && !prevState.isDefaultSet) {
         derivedState.value = optionToSelectableOptions(nextProps.defaultValue);
         derivedState.isDefaultSet = true;
       }

package/dist/esm/components/utils.js

@@ -24,6 +24,9 @@ export var isGroup = function isGroup(option) {
 export var isEmail = function isEmail(option) {
   return option.type === EmailType;
 };
+export var isDefaultValuePopulated = function isDefaultValuePopulated(value) {
+  return value && !Array.isArray(value) || Array.isArray(value) && value.length > 0;
+};
 
 var isOptionData = function isOptionData(option) {
   return option.name !== undefined;

package/dist/esm/version.json

@@ -1,5 +1,5 @@
 {
 	"name": "@atlaskit/user-picker",
-	"version": "8.6.2",
+	"version": "8.6.3",
 	"sideEffects": false
 }

package/dist/types/components/utils.d.ts

@@ -6,6 +6,7 @@ export declare const isUser: (option: OptionData) => option is User;
 export declare const isTeam: (option: OptionData) => option is Team;
 export declare const isGroup: (option: OptionData) => option is Group;
 export declare const isEmail: (option: OptionData) => option is Email;
+export declare const isDefaultValuePopulated: (value?: DefaultValue) => boolean;
 export declare const optionToSelectableOption: (option: OptionData | OptionIdentifier) => Option;
 export declare const extractOptionValue: (value: AtlaskitSelectValue) => OptionData | OptionData[] | undefined;
 export declare const isIterable: (a: any) => a is Iterable<Promisable<OptionData | OptionData[]>>;

package/dist/types/types.d.ts

@@ -83,12 +83,6 @@ export declare type UserPickerProps = WithAnalyticsEventsProps & {
      */
     styles?: StylesConfig;
     /** Default value for the field to be used on initial render.
-     * If the `DefaultValue` contains only an `id` and `type` (it conforms to an `OptionIdentifier`)
-     * then the values will be automatically hydrated from the backend.
-     * If the value has a `name` then it is considered hydrated.
-     * If `defaultValue` is an array then only the first item is checked and the rest
-     * are assumed to conform.
-     * Hydration is only supported for Confluence and Jira.
      * `defaultValue` differs from `value` in that it sets the initial value then leaves the component 'uncontrolled'
      * whereas setting the `value` prop delegates responsibility for maintaining the value to the caller
      * (i.e. listen to `onChange`) */

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@atlaskit/user-picker",
-  "version": "8.6.2",
+  "version": "8.6.3",
   "description": "Fabric component for display a dropdown to select a user from",
   "publishConfig": {
     "registry": "https://registry.npmjs.org/"