@atlaskit/user-picker 10.2.3 → 10.2.4

package/CHANGELOG.md

@@ -1,5 +1,11 @@
 # @atlaskit/user-picker
 
+## 10.2.4
+
+### Patch Changes
+
+- [`17aec239f54`](https://bitbucket.org/atlassian/atlassian-frontend/commits/17aec239f54) - [ux] aria-describedby and aria-labelledby proper association in between input and placeholder
+
 ## 10.2.3
 
 ### Patch Changes

package/dist/cjs/components/Input.js

@@ -41,9 +41,32 @@ var Input = /*#__PURE__*/function (_React$Component) {
     return _this;
   }
   (0, _createClass2.default)(Input, [{
+    key: "ariaLabelledBy",
+    get:
+    /**
+     * Overrides the default behaviour of react-select lib
+     *
+     * The getter is a workaround for original behaviour of the react-select lib.
+     * Placeholder and Input are linked not via label, aria-label or aria-labeledby, but through aria-describedby.
+     * Basically in the getter we reassign Placeholder ID from aria-describedby to aria-labelledby
+     * {@link https://github.com/JedWatson/react-select/issues/5651#issue-1731353197 GitHub}
+     */
+    function get() {
+      var _this$props$ariaDesc;
+      return (_this$props$ariaDesc = this.props['aria-describedby']) !== null && _this$props$ariaDesc !== void 0 ? _this$props$ariaDesc : this.props['aria-labelledby'];
+    }
+  }, {
+    key: "ariaDescribedBy",
+    get: function get() {
+      var _this$props$selectPro2, _this$props$selectPro3;
+      return (_this$props$selectPro2 = (_this$props$selectPro3 = this.props.selectProps) === null || _this$props$selectPro3 === void 0 ? void 0 : _this$props$selectPro3['aria-describedby']) !== null && _this$props$selectPro2 !== void 0 ? _this$props$selectPro2 : this.props['aria-describedby'];
+    }
+  }, {
     key: "render",
     value: function render() {
       return /*#__PURE__*/_react.default.createElement(_select.components.Input, (0, _extends2.default)({}, this.props, {
+        "aria-labelledby": this.ariaLabelledBy,
+        "aria-describedby": this.ariaDescribedBy,
         innerRef: this.props.innerRef,
         onKeyPress: this.handleKeyPress
       }));

package/dist/cjs/i18n/en_ZZ.js

@@ -4,6 +4,7 @@ Object.defineProperty(exports, "__esModule", {
   value: true
 });
 exports.default = void 0;
+/* prettier-ignore */
 /**
  * NOTE:
  *
@@ -15,6 +16,7 @@ var _default = {
   'fabric.elements.user-picker.email.add': '⁣⁢Add user⁠؜؜⁠؜؜⁠⁠‌⁠⁣⁤',
   'fabric.elements.user-picker.email.add.potential': '⁣⁢Enter an email address؜‍‍⁡⁡‍⁡‌⁡‍؜⁣⁤',
   'fabric.elements.user-picker.email.select.to.add': '⁣⁢Select an email address⁡‍⁠⁠⁠⁠⁠⁠⁡‍⁠؜⁠⁠‌‌⁣⁤',
+  'fabric.elements.user-picker.error.message': '⁣⁢Something went wrong؜‍‍⁡⁠⁡⁡‍⁠؜⁣⁤',
   'fabric.elements.user-picker.external.sourced.error': "⁣⁢We can't connect you right now.‍⁡؜؜؜⁠؜⁡⁣⁤",
   'fabric.elements.user-picker.external.sourced.from': '⁣⁢Found in:‌⁡‌⁠؜⁡؜؜‌⁣⁤',
   'fabric.elements.user-picker.github.provider': '⁣⁢GitHub‍‍؜⁠؜؜⁡‍⁡⁣⁤',

package/dist/cjs/version.json

@@ -1,5 +1,5 @@
 {
 	"name": "@atlaskit/user-picker",
-	"version": "10.2.3",
+	"version": "10.2.4",
 	"sideEffects": false
 }

package/dist/es2019/components/Input.js

@@ -17,8 +17,26 @@ export class Input extends React.Component {
       }
     });
   }
+  /**
+   * Overrides the default behaviour of react-select lib
+   *
+   * The getter is a workaround for original behaviour of the react-select lib.
+   * Placeholder and Input are linked not via label, aria-label or aria-labeledby, but through aria-describedby.
+   * Basically in the getter we reassign Placeholder ID from aria-describedby to aria-labelledby
+   * {@link https://github.com/JedWatson/react-select/issues/5651#issue-1731353197 GitHub}
+   */
+  get ariaLabelledBy() {
+    var _this$props$ariaDesc;
+    return (_this$props$ariaDesc = this.props['aria-describedby']) !== null && _this$props$ariaDesc !== void 0 ? _this$props$ariaDesc : this.props['aria-labelledby'];
+  }
+  get ariaDescribedBy() {
+    var _this$props$selectPro2, _this$props$selectPro3;
+    return (_this$props$selectPro2 = (_this$props$selectPro3 = this.props.selectProps) === null || _this$props$selectPro3 === void 0 ? void 0 : _this$props$selectPro3['aria-describedby']) !== null && _this$props$selectPro2 !== void 0 ? _this$props$selectPro2 : this.props['aria-describedby'];
+  }
   render() {
     return /*#__PURE__*/React.createElement(components.Input, _extends({}, this.props, {
+      "aria-labelledby": this.ariaLabelledBy,
+      "aria-describedby": this.ariaDescribedBy,
       innerRef: this.props.innerRef,
       onKeyPress: this.handleKeyPress
     }));

package/dist/es2019/i18n/en_ZZ.js

@@ -1,3 +1,4 @@
+/* prettier-ignore */
 /**
  * NOTE:
  *
@@ -9,6 +10,7 @@ export default {
   'fabric.elements.user-picker.email.add': '⁣⁢Add user⁠؜؜⁠؜؜⁠⁠‌⁠⁣⁤',
   'fabric.elements.user-picker.email.add.potential': '⁣⁢Enter an email address؜‍‍⁡⁡‍⁡‌⁡‍؜⁣⁤',
   'fabric.elements.user-picker.email.select.to.add': '⁣⁢Select an email address⁡‍⁠⁠⁠⁠⁠⁠⁡‍⁠؜⁠⁠‌‌⁣⁤',
+  'fabric.elements.user-picker.error.message': '⁣⁢Something went wrong؜‍‍⁡⁠⁡⁡‍⁠؜⁣⁤',
   'fabric.elements.user-picker.external.sourced.error': "⁣⁢We can't connect you right now.‍⁡؜؜؜⁠؜⁡⁣⁤",
   'fabric.elements.user-picker.external.sourced.from': '⁣⁢Found in:‌⁡‌⁠؜⁡؜؜‌⁣⁤',
   'fabric.elements.user-picker.github.provider': '⁣⁢GitHub‍‍؜⁠؜؜⁡‍⁡⁣⁤',

package/dist/es2019/version.json

@@ -1,5 +1,5 @@
 {
 	"name": "@atlaskit/user-picker",
-	"version": "10.2.3",
+	"version": "10.2.4",
 	"sideEffects": false
 }

package/dist/esm/components/Input.js

@@ -34,9 +34,32 @@ export var Input = /*#__PURE__*/function (_React$Component) {
     return _this;
   }
   _createClass(Input, [{
+    key: "ariaLabelledBy",
+    get:
+    /**
+     * Overrides the default behaviour of react-select lib
+     *
+     * The getter is a workaround for original behaviour of the react-select lib.
+     * Placeholder and Input are linked not via label, aria-label or aria-labeledby, but through aria-describedby.
+     * Basically in the getter we reassign Placeholder ID from aria-describedby to aria-labelledby
+     * {@link https://github.com/JedWatson/react-select/issues/5651#issue-1731353197 GitHub}
+     */
+    function get() {
+      var _this$props$ariaDesc;
+      return (_this$props$ariaDesc = this.props['aria-describedby']) !== null && _this$props$ariaDesc !== void 0 ? _this$props$ariaDesc : this.props['aria-labelledby'];
+    }
+  }, {
+    key: "ariaDescribedBy",
+    get: function get() {
+      var _this$props$selectPro2, _this$props$selectPro3;
+      return (_this$props$selectPro2 = (_this$props$selectPro3 = this.props.selectProps) === null || _this$props$selectPro3 === void 0 ? void 0 : _this$props$selectPro3['aria-describedby']) !== null && _this$props$selectPro2 !== void 0 ? _this$props$selectPro2 : this.props['aria-describedby'];
+    }
+  }, {
     key: "render",
     value: function render() {
       return /*#__PURE__*/React.createElement(components.Input, _extends({}, this.props, {
+        "aria-labelledby": this.ariaLabelledBy,
+        "aria-describedby": this.ariaDescribedBy,
         innerRef: this.props.innerRef,
         onKeyPress: this.handleKeyPress
       }));

package/dist/esm/i18n/en_ZZ.js

@@ -1,3 +1,4 @@
+/* prettier-ignore */
 /**
  * NOTE:
  *
@@ -9,6 +10,7 @@ export default {
   'fabric.elements.user-picker.email.add': '⁣⁢Add user⁠؜؜⁠؜؜⁠⁠‌⁠⁣⁤',
   'fabric.elements.user-picker.email.add.potential': '⁣⁢Enter an email address؜‍‍⁡⁡‍⁡‌⁡‍؜⁣⁤',
   'fabric.elements.user-picker.email.select.to.add': '⁣⁢Select an email address⁡‍⁠⁠⁠⁠⁠⁠⁡‍⁠؜⁠⁠‌‌⁣⁤',
+  'fabric.elements.user-picker.error.message': '⁣⁢Something went wrong؜‍‍⁡⁠⁡⁡‍⁠؜⁣⁤',
   'fabric.elements.user-picker.external.sourced.error': "⁣⁢We can't connect you right now.‍⁡؜؜؜⁠؜⁡⁣⁤",
   'fabric.elements.user-picker.external.sourced.from': '⁣⁢Found in:‌⁡‌⁠؜⁡؜؜‌⁣⁤',
   'fabric.elements.user-picker.github.provider': '⁣⁢GitHub‍‍؜⁠؜؜⁡‍⁡⁣⁤',

package/dist/esm/version.json

@@ -1,5 +1,5 @@
 {
 	"name": "@atlaskit/user-picker",
-	"version": "10.2.3",
+	"version": "10.2.4",
 	"sideEffects": false
 }

package/dist/types/components/Input.d.ts

@@ -1,11 +1,22 @@
-import React from 'react';
+import React, { type AriaAttributes } from 'react';
+import { type OptionType, type SelectProps } from '@atlaskit/select';
+import { AriaAttributesType } from '../types';
 export type Props = {
-    selectProps?: {
-        disableInput?: boolean;
-    };
+    selectProps?: SelectProps<OptionType, boolean>;
     innerRef: (ref: React.Ref<HTMLInputElement>) => void;
+    ariaDescribedBy?: AriaAttributesType;
 };
-export declare class Input extends React.Component<Props> {
+export declare class Input extends React.Component<Props & AriaAttributes> {
     handleKeyPress: (e: KeyboardEvent) => void;
+    /**
+     * Overrides the default behaviour of react-select lib
+     *
+     * The getter is a workaround for original behaviour of the react-select lib.
+     * Placeholder and Input are linked not via label, aria-label or aria-labeledby, but through aria-describedby.
+     * Basically in the getter we reassign Placeholder ID from aria-describedby to aria-labelledby
+     * {@link https://github.com/JedWatson/react-select/issues/5651#issue-1731353197 GitHub}
+     */
+    get ariaLabelledBy(): AriaAttributesType;
+    get ariaDescribedBy(): AriaAttributesType;
     render(): JSX.Element;
 }

package/dist/types/components/PopupInput.d.ts

@@ -1,10 +1,5 @@
 import React from 'react';
-export type Props = {
-    selectProps: {
-        disableInput?: boolean;
-    };
-    innerRef: (ref: React.Ref<HTMLInputElement>) => void;
-};
+import { type Props } from './Input';
 export declare class PopupInput extends React.Component<Props> {
     private ref;
     componentDidMount(): void;

package/dist/types/i18n/en_ZZ.d.ts

@@ -8,6 +8,7 @@ declare const _default: {
     'fabric.elements.user-picker.email.add': string;
     'fabric.elements.user-picker.email.add.potential': string;
     'fabric.elements.user-picker.email.select.to.add': string;
+    'fabric.elements.user-picker.error.message': string;
     'fabric.elements.user-picker.external.sourced.error': string;
     'fabric.elements.user-picker.external.sourced.from': string;
     'fabric.elements.user-picker.github.provider': string;

package/dist/types/types.d.ts

@@ -1,4 +1,4 @@
-import React, { ReactNode } from 'react';
+import React, { type AriaAttributes, ReactNode } from 'react';
 import { WithAnalyticsEventsProps } from '@atlaskit/analytics-next';
 import { Placement } from '@atlaskit/popper';
 import { EmailValidator } from './components/emailValidation';
@@ -176,6 +176,7 @@ export type PopupUserPickerProps = UserPickerProps & {
      */
     shouldFlip?: boolean;
 };
+export type AriaAttributesType = AriaAttributes['aria-labelledby'] | AriaAttributes['aria-describedby'];
 export type BoundariesElement = 'scrollParent' | 'window' | 'viewport' | HTMLElement;
 export type RootBoundary = 'viewport' | 'document';
 export type UserPickerState = {

package/dist/types-ts4.5/components/Input.d.ts

@@ -1,11 +1,22 @@
-import React from 'react';
+import React, { type AriaAttributes } from 'react';
+import { type OptionType, type SelectProps } from '@atlaskit/select';
+import { AriaAttributesType } from '../types';
 export type Props = {
-    selectProps?: {
-        disableInput?: boolean;
-    };
+    selectProps?: SelectProps<OptionType, boolean>;
     innerRef: (ref: React.Ref<HTMLInputElement>) => void;
+    ariaDescribedBy?: AriaAttributesType;
 };
-export declare class Input extends React.Component<Props> {
+export declare class Input extends React.Component<Props & AriaAttributes> {
     handleKeyPress: (e: KeyboardEvent) => void;
+    /**
+     * Overrides the default behaviour of react-select lib
+     *
+     * The getter is a workaround for original behaviour of the react-select lib.
+     * Placeholder and Input are linked not via label, aria-label or aria-labeledby, but through aria-describedby.
+     * Basically in the getter we reassign Placeholder ID from aria-describedby to aria-labelledby
+     * {@link https://github.com/JedWatson/react-select/issues/5651#issue-1731353197 GitHub}
+     */
+    get ariaLabelledBy(): AriaAttributesType;
+    get ariaDescribedBy(): AriaAttributesType;
     render(): JSX.Element;
 }

package/dist/types-ts4.5/components/PopupInput.d.ts

@@ -1,10 +1,5 @@
 import React from 'react';
-export type Props = {
-    selectProps: {
-        disableInput?: boolean;
-    };
-    innerRef: (ref: React.Ref<HTMLInputElement>) => void;
-};
+import { type Props } from './Input';
 export declare class PopupInput extends React.Component<Props> {
     private ref;
     componentDidMount(): void;

package/dist/types-ts4.5/i18n/en_ZZ.d.ts

@@ -8,6 +8,7 @@ declare const _default: {
     'fabric.elements.user-picker.email.add': string;
     'fabric.elements.user-picker.email.add.potential': string;
     'fabric.elements.user-picker.email.select.to.add': string;
+    'fabric.elements.user-picker.error.message': string;
     'fabric.elements.user-picker.external.sourced.error': string;
     'fabric.elements.user-picker.external.sourced.from': string;
     'fabric.elements.user-picker.github.provider': string;

package/dist/types-ts4.5/types.d.ts

@@ -1,4 +1,4 @@
-import React, { ReactNode } from 'react';
+import React, { type AriaAttributes, ReactNode } from 'react';
 import { WithAnalyticsEventsProps } from '@atlaskit/analytics-next';
 import { Placement } from '@atlaskit/popper';
 import { EmailValidator } from './components/emailValidation';
@@ -179,6 +179,7 @@ export type PopupUserPickerProps = UserPickerProps & {
      */
     shouldFlip?: boolean;
 };
+export type AriaAttributesType = AriaAttributes['aria-labelledby'] | AriaAttributes['aria-describedby'];
 export type BoundariesElement = 'scrollParent' | 'window' | 'viewport' | HTMLElement;
 export type RootBoundary = 'viewport' | 'document';
 export type UserPickerState = {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@atlaskit/user-picker",
-  "version": "10.2.3",
+  "version": "10.2.4",
   "description": "Fabric component for display a dropdown to select a user from",
   "publishConfig": {
     "registry": "https://registry.npmjs.org/"
@@ -40,10 +40,10 @@
     "@atlaskit/logo": "^13.14.0",
     "@atlaskit/lozenge": "^11.4.0",
     "@atlaskit/popper": "^5.5.0",
-    "@atlaskit/select": "^16.2.0",
+    "@atlaskit/select": "^16.5.0",
     "@atlaskit/spinner": "^15.5.0",
     "@atlaskit/theme": "^12.5.0",
-    "@atlaskit/tokens": "^1.4.0",
+    "@atlaskit/tokens": "^1.5.0",
     "@atlaskit/tooltip": "^17.8.0",
     "@atlaskit/ufo": "^0.2.0",
     "@babel/runtime": "^7.0.0",
@@ -63,10 +63,10 @@
     "@atlaskit/docs": "*",
     "@atlaskit/elements-test-helpers": "^0.7.0",
     "@atlaskit/modal-dialog": "^12.5.0",
-    "@atlaskit/radio": "^5.5.0",
+    "@atlaskit/radio": "^5.6.0",
     "@atlaskit/range": "^7.1.0",
     "@atlaskit/section-message": "^6.4.0",
-    "@atlaskit/textfield": "^5.4.0",
+    "@atlaskit/textfield": "^5.5.0",
     "@atlaskit/util-data-test": "^17.8.0",
     "@atlaskit/visual-regression": "*",
     "@atlassian/atlassian-frontend-prettier-config-1.0.1": "npm:@atlassian/atlassian-frontend-prettier-config@1.0.1",