@atlaskit/top-layer 3.1.0 → 4.0.0

package/AGENTS.md

@@ -110,4 +110,6 @@ const [state, setState] = useState<TState>({ type: 'idle' });
 
 ## Versioning
 
-This package is still on `0.x` releases. All changes should be a `minor` (`0.x`) release.
+This package is on stable releases. Follow semantic versioning: use `major` for public API removals
+or incompatible behavior changes, `minor` for public API additions, and `patch` for compatible fixes
+and internal implementation changes.

package/CHANGELOG.md

@@ -1,5 +1,31 @@
 # @atlaskit/top-layer
 
+## 4.0.0
+
+### Major Changes
+
+- [`eff4aad608ff2`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/eff4aad608ff2) -
+  Remove the obsolete `@atlaskit/top-layer/animations` entry point and simplify internal helpers.
+  Use the built-in `shouldAnimate` behavior on `Popover` and `Dialog`, with phase-specific xcss
+  overrides when customization is required.
+
+## 3.2.0
+
+### Minor Changes
+
+- [`2857e277050c6`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/2857e277050c6) -
+  Behind the `platform-dst-top-layer` feature gate, `@atlaskit/popper/unsafe-imperative`'s
+  `createPopper` now renders and positions in the browser top layer via `@atlaskit/top-layer`
+  instead of running the Popper.js engine. Positioning and teardown are applied asynchronously, as
+  Popper.js' own first update is. Flag-off behaviour is unchanged.
+
+  `@atlaskit/top-layer`: the JavaScript positioning fallback no longer clears a consumer's own
+  inline positioning and visibility styles.
+
+### Patch Changes
+
+- Updated dependencies
+
 ## 3.1.0
 
 ### Minor Changes

package/README.md

@@ -92,20 +92,6 @@ for entry and
 [`allow-discrete`](https://developer.mozilla.org/en-US/docs/Web/CSS/transition-behavior) on
 `display`/`overlay` for exit — no JavaScript animation coordination required.
 
-Presets are available from `@atlaskit/top-layer/animations`:
-
-```tsx
-import {
-	// Popover presets
-	slideAndFade,
-	fade,
-	scaleAndFade,
-	// Dialog presets
-	dialogSlideUpAndFade,
-	dialogFade,
-} from '@atlaskit/top-layer/animations';
-```
-
 ### Popover animation
 
 Pass `shouldAnimate` to enable the default popover entry and exit animation:

package/dist/cjs/focus/is-in-same-layer.js

@@ -13,11 +13,5 @@ var topLayerSelector = '[popover], dialog, [role="dialog"], [role="alertdialog"]
 function isInSameLayer(_ref) {
   var element = _ref.element,
     container = _ref.container;
-  var elementLayer = element.closest(topLayerSelector);
-  var containerLayer = container.closest(topLayerSelector);
-  // Both elements are in the "document" layer
-  if (!elementLayer && !containerLayer) {
-    return true;
-  }
-  return elementLayer === containerLayer;
+  return element.closest(topLayerSelector) === container.closest(topLayerSelector);
 }

package/dist/cjs/focus/selectors.js

@@ -8,7 +8,7 @@ var selectors = exports.selectors = function () {
   // Common exclusion filter applied to every selector.
   var not = ':not([tabindex="-1"]):not([aria-disabled="true"]):not([aria-hidden="true"])';
   var notDisabled = ":not([disabled])".concat(not);
-  var focusable = ["a[href]".concat(not), "area[href]".concat(not), "input".concat(notDisabled, ":not([type=\"hidden\"])"), "select".concat(notDisabled), "textarea".concat(notDisabled), "button".concat(notDisabled), "iframe".concat(not), "audio[controls]".concat(not), "video[controls]".concat(not), "[contenteditable]:not([contenteditable=\"false\"])".concat(not), "[tabindex]".concat(notDisabled).concat(not)];
+  var focusable = ["a[href]".concat(not), "area[href]".concat(not), "input".concat(notDisabled, ":not([type=\"hidden\"])"), "select".concat(notDisabled), "textarea".concat(notDisabled), "button".concat(notDisabled), "iframe".concat(not), "audio[controls]".concat(not), "video[controls]".concat(not), "[contenteditable]:not([contenteditable=\"false\"])".concat(not), "[tabindex]".concat(notDisabled)];
   return {
     focusable: focusable.join(','),
     // Build the `:focus` selector

package/dist/cjs/internal/get-aria-for-trigger.js

@@ -4,7 +4,6 @@ Object.defineProperty(exports, "__esModule", {
   value: true
 });
 exports.getAriaForTrigger = getAriaForTrigger;
-var _roleToAriaHasPopup = require("./role-to-aria-has-popup");
 /**
  * Roles accepted by `getAriaForTrigger`.
  *
@@ -14,12 +13,34 @@ var _roleToAriaHasPopup = require("./role-to-aria-has-popup");
  * manually for tooltip triggers.
  */
 
+/**
+ * Valid values for the `aria-haspopup` attribute.
+ *
+ * Derived from the HTML spec - maps popover roles to what the trigger
+ * announces. `undefined` means the attribute is omitted entirely (used for
+ * non-popup roles like `tooltip`/`status`/`alert`/`note`/`log` where
+ * `aria-haspopup` would be misleading).
+ *
+ * `true` is intentionally NOT in the union - the runtime only ever produces
+ * the explicit string forms, so widening the type would invite consumers to
+ * pass `true` and get an `aria-haspopup="true"` serialisation that the
+ * runtime no longer emits.
+ */
+
 /**
  * Non-undefined subset of `TAriaHasPopupValue`. Every role accepted by
  * `getAriaForTrigger` maps to a concrete `aria-haspopup` string, so the
  * trigger always receives a defined attribute value.
  */
 
+var roleToAriaHasPopup = {
+  dialog: 'dialog',
+  alertdialog: 'dialog',
+  menu: 'menu',
+  listbox: 'listbox',
+  tree: 'tree',
+  grid: 'grid'
+};
 /**
  * Returns the ARIA attributes to spread onto a click-activated popover trigger.
  *
@@ -71,13 +92,6 @@ function getAriaForTrigger(_ref) {
   var role = _ref.role,
     isOpen = _ref.isOpen,
     popoverId = _ref.popoverId;
-  // `roleToAriaHasPopup` accepts a wider role union (including tooltip-family
-  // roles that map to `undefined`). `TAriaForTriggerRole` excludes those, so
-  // the returned value is guaranteed to be a defined string. The cast narrows
-  // the wider helper signature to match.
-  var ariaHasPopup = (0, _roleToAriaHasPopup.roleToAriaHasPopup)({
-    role: role
-  });
   // `aria-controls` is set to `undefined` while closed. The `Popover` /
   // `Dialog` primitives unmount their host element after the exit
   // animation finishes, so a closed-state `aria-controls` would point
@@ -86,7 +100,7 @@ function getAriaForTrigger(_ref) {
   // until the target exists, avoiding the dangling reference while
   // keeping the relationship live whenever it is meaningful.
   return {
-    'aria-haspopup': ariaHasPopup,
+    'aria-haspopup': roleToAriaHasPopup[role],
     'aria-expanded': isOpen,
     'aria-controls': isOpen ? popoverId : undefined
   };

package/dist/cjs/internal/role-types.js

@@ -1,64 +1 @@
-"use strict";
-
-Object.defineProperty(exports, "__esModule", {
-  value: true
-});
-exports.shouldFocusIntoPopover = shouldFocusIntoPopover;
-/**
- * Valid values for the `aria-haspopup` attribute.
- *
- * Derived from the HTML spec - maps popover roles to what the trigger
- * announces. `undefined` means the attribute is omitted entirely (used for
- * non-popup roles like `tooltip`/`status`/`alert`/`note`/`log` where
- * `aria-haspopup` would be misleading).
- *
- * `true` is intentionally NOT in the union - the runtime only ever produces
- * the explicit string forms, so widening the type would invite consumers to
- * pass `true` and get an `aria-haspopup="true"` serialisation that the
- * runtime no longer emits.
- */
-
-/**
- * Roles that require an accessible name (`label` or `labelledBy`) per WCAG 4.1.2.
- * Without a name, assistive technology cannot identify these landmarks.
- */
-
-/**
- * Roles where the accessible name is derived from content or provided externally
- * (e.g. a combobox labels its listbox, tooltip content IS the accessible name).
- */
-
-// Shared ARIA role discrimination types
-//
-// These encode the WCAG 4.1.2 constraint: roles like `dialog`, `alertdialog`,
-// and `menu` MUST have an accessible name (either `label` or `labelledBy`).
-// TypeScript enforces this at compile time via discriminated unions.
-
-/**
- * ARIA role props where a role is always required.
- *
- * Used by `TPopupContentProps`. Popup content must always declare
- * its role so assistive technology can identify the layer.
- */
-
-/**
- * ARIA role props where a role is optional.
- *
- * Used by `TPopoverProps`. The low-level primitive allows omitting
- * the role for cases where it is set externally or not needed.
- */
-
-var rolesThatMoveFocus = new Set(['dialog', 'alertdialog', 'menu', 'listbox', 'tree', 'grid']);
-
-/**
- * Returns `true` when the given popover role moves focus into the popover
- * on open, and `false` otherwise (including when `role` is `undefined`).
- */
-// eslint-disable-next-line @atlaskit/volt-strict-mode/no-multiple-exports
-function shouldFocusIntoPopover(_ref) {
-  var role = _ref.role;
-  if (!role) {
-    return false;
-  }
-  return rolesThatMoveFocus.has(role);
-}
+"use strict";

package/dist/cjs/internal/use-anchor-position.js

@@ -324,11 +324,10 @@ function useAnchorPosition(_ref3) {
        * See `notes/decisions/anchor-name-lifetime.md`
        */
       trigger.style.setProperty('anchor-name', anchorName);
-      var _undoPositioning = (0, _combine.combine)((0, _setStyle.setStyle)({
+      return (0, _setStyle.setStyle)({
         element: popover,
         styles: popoverStyles
-      }));
-      return _undoPositioning;
+      });
     }
 
     // JS fallback. The popover is already in the top layer via
@@ -344,6 +343,38 @@ function useAnchorPosition(_ref3) {
         value: 'auto'
       }]
     });
+
+    // The popover can be consumer-owned (`@atlaskit/popper`'s `createPopper`),
+    // so restore prior inline values rather than removing ours.
+    var undoPosition;
+    var undoHide;
+
+    // `opacity: 0` not `visibility: hidden`: Firefox skips visibility-hidden
+    // elements during `<dialog>` initial-focus traversal.
+    function hideUntilPositioned() {
+      // Keep the first snapshot, else we capture our own `opacity: 0`.
+      // (`!popover` is for TS: narrowing does not reach nested functions.)
+      if (!popover || undoHide) {
+        return;
+      }
+      undoHide = (0, _setStyle.setStyle)({
+        element: popover,
+        styles: [{
+          property: 'opacity',
+          value: '0'
+        }]
+      });
+    }
+    function reveal() {
+      var _undoHide;
+      (_undoHide = undoHide) === null || _undoHide === void 0 || _undoHide();
+      undoHide = undefined;
+    }
+    function restorePosition() {
+      var _undoPosition;
+      (_undoPosition = undoPosition) === null || _undoPosition === void 0 || _undoPosition();
+      undoPosition = undefined;
+    }
     function update() {
       if (!trigger || !popover) {
         return;
@@ -382,11 +413,20 @@ function useAnchorPosition(_ref3) {
         }),
         top = _computeFallbackPosit.top,
         left = _computeFallbackPosit.left;
-      popover.style.setProperty('top', "".concat(top, "px"));
-      popover.style.setProperty('left', "".concat(left, "px"));
-      // Reveal the popover only after it has been positioned.
-      // See the toggle listener below for why we hide on open.
-      popover.style.removeProperty('opacity');
+
+      // Restore first so the snapshot stays the consumer's value.
+      restorePosition();
+      undoPosition = (0, _setStyle.setStyle)({
+        element: popover,
+        styles: [{
+          property: 'top',
+          value: "".concat(top, "px")
+        }, {
+          property: 'left',
+          value: "".concat(left, "px")
+        }]
+      });
+      reveal();
     }
 
     // Throttle scroll/resize updates to one per animation frame
@@ -420,22 +460,17 @@ function useAnchorPosition(_ref3) {
     // event has already fired and our listener below would miss it. Start
     // observing immediately so the first measurement still happens.
     if (isPopoverOpen(popover)) {
-      popover.style.setProperty('opacity', '0');
+      hideUntilPositioned();
       resizeObserver.observe(popover);
     }
     var undoPositioning = (0, _combine.combine)(cleanupBaseStyles,
-    // On every open: hide synchronously so the user never sees
-    // the UA-default position, then re-observe for a fresh
-    // measurement. We use `opacity: 0` rather than
-    // `visibility: hidden` because Firefox skips visibility-hidden
-    // elements during `<dialog>` initial-focus traversal. See
-    // `form-in-popup.spec.tsx` on `desktop-firefox`.
+    // Each open needs a fresh measurement, so hide and re-observe.
     (0, _bindEventListener.bind)(popover, {
       type: 'toggle',
       listener: function listener(event) {
         var toggleEvent = event;
         if (toggleEvent.newState === 'open') {
-          popover.style.setProperty('opacity', '0');
+          hideUntilPositioned();
           resizeObserver.observe(popover);
         }
       }
@@ -456,9 +491,8 @@ function useAnchorPosition(_ref3) {
       }
     }), function () {
       scheduledUpdate.cancel();
-      popover.style.removeProperty('top');
-      popover.style.removeProperty('left');
-      popover.style.removeProperty('opacity');
+      restorePosition();
+      reveal();
     });
     return undoPositioning;
   }, [anchorRef, popoverRef, stablePlacement, forceFallbackPositioning, isEnabled, id, isOpen]);

package/dist/cjs/popover/popover.js

@@ -16,7 +16,7 @@ var _mergeRefs = _interopRequireDefault(require("@atlaskit/ds-lib/merge-refs"));
 var _once = _interopRequireDefault(require("@atlaskit/ds-lib/once"));
 var _useNotifyOpenLayerObserver = require("@atlaskit/layering/use-notify-open-layer-observer");
 var _resolvePlacement2 = require("../internal/resolve-placement");
-var _roleTypes = require("../internal/role-types");
+var _shouldFocusIntoPopover = require("../internal/should-focus-into-popover");
 var _useAnimatedVisibility = require("../internal/use-animated-visibility");
 var _useFocusWrap = require("../internal/use-focus-wrap");
 var _useInitialFocus = require("../internal/use-initial-focus");
@@ -234,7 +234,7 @@ var Popover = exports.Popover = /*#__PURE__*/(0, _react.forwardRef)(function Pop
         var previouslyFocused = previouslyFocusedElementRef.current;
         var _reason = closeReasonRef.current;
         var isProgrammatic = programmaticCloseRef.current;
-        var shouldRestore = previouslyFocused !== null && previouslyFocused.isConnected && (0, _roleTypes.shouldFocusIntoPopover)({
+        var shouldRestore = previouslyFocused !== null && previouslyFocused.isConnected && (0, _shouldFocusIntoPopover.shouldFocusIntoPopover)({
           role: role
         }) && (_reason === 'escape' || isProgrammatic);
         if (shouldRestore && previouslyFocused) {

package/dist/es2019/focus/is-in-same-layer.js

@@ -8,11 +8,5 @@ export function isInSameLayer({
   element,
   container
 }) {
-  const elementLayer = element.closest(topLayerSelector);
-  const containerLayer = container.closest(topLayerSelector);
-  // Both elements are in the "document" layer
-  if (!elementLayer && !containerLayer) {
-    return true;
-  }
-  return elementLayer === containerLayer;
+  return element.closest(topLayerSelector) === container.closest(topLayerSelector);
 }

package/dist/es2019/focus/selectors.js

@@ -2,7 +2,7 @@ export const selectors = (() => {
   // Common exclusion filter applied to every selector.
   const not = ':not([tabindex="-1"]):not([aria-disabled="true"]):not([aria-hidden="true"])';
   const notDisabled = `:not([disabled])${not}`;
-  const focusable = [`a[href]${not}`, `area[href]${not}`, `input${notDisabled}:not([type="hidden"])`, `select${notDisabled}`, `textarea${notDisabled}`, `button${notDisabled}`, `iframe${not}`, `audio[controls]${not}`, `video[controls]${not}`, `[contenteditable]:not([contenteditable="false"])${not}`, `[tabindex]${notDisabled}${not}`];
+  const focusable = [`a[href]${not}`, `area[href]${not}`, `input${notDisabled}:not([type="hidden"])`, `select${notDisabled}`, `textarea${notDisabled}`, `button${notDisabled}`, `iframe${not}`, `audio[controls]${not}`, `video[controls]${not}`, `[contenteditable]:not([contenteditable="false"])${not}`, `[tabindex]${notDisabled}`];
   return {
     focusable: focusable.join(','),
     // Build the `:focus` selector

package/dist/es2019/internal/get-aria-for-trigger.js

@@ -1,5 +1,3 @@
-import { roleToAriaHasPopup } from './role-to-aria-has-popup';
-
 /**
  * Roles accepted by `getAriaForTrigger`.
  *
@@ -9,12 +7,34 @@ import { roleToAriaHasPopup } from './role-to-aria-has-popup';
  * manually for tooltip triggers.
  */
 
+/**
+ * Valid values for the `aria-haspopup` attribute.
+ *
+ * Derived from the HTML spec - maps popover roles to what the trigger
+ * announces. `undefined` means the attribute is omitted entirely (used for
+ * non-popup roles like `tooltip`/`status`/`alert`/`note`/`log` where
+ * `aria-haspopup` would be misleading).
+ *
+ * `true` is intentionally NOT in the union - the runtime only ever produces
+ * the explicit string forms, so widening the type would invite consumers to
+ * pass `true` and get an `aria-haspopup="true"` serialisation that the
+ * runtime no longer emits.
+ */
+
 /**
  * Non-undefined subset of `TAriaHasPopupValue`. Every role accepted by
  * `getAriaForTrigger` maps to a concrete `aria-haspopup` string, so the
  * trigger always receives a defined attribute value.
  */
 
+const roleToAriaHasPopup = {
+  dialog: 'dialog',
+  alertdialog: 'dialog',
+  menu: 'menu',
+  listbox: 'listbox',
+  tree: 'tree',
+  grid: 'grid'
+};
 /**
  * Returns the ARIA attributes to spread onto a click-activated popover trigger.
  *
@@ -67,13 +87,6 @@ export function getAriaForTrigger({
   isOpen,
   popoverId
 }) {
-  // `roleToAriaHasPopup` accepts a wider role union (including tooltip-family
-  // roles that map to `undefined`). `TAriaForTriggerRole` excludes those, so
-  // the returned value is guaranteed to be a defined string. The cast narrows
-  // the wider helper signature to match.
-  const ariaHasPopup = roleToAriaHasPopup({
-    role
-  });
   // `aria-controls` is set to `undefined` while closed. The `Popover` /
   // `Dialog` primitives unmount their host element after the exit
   // animation finishes, so a closed-state `aria-controls` would point
@@ -82,7 +95,7 @@ export function getAriaForTrigger({
   // until the target exists, avoiding the dangling reference while
   // keeping the relationship live whenever it is meaningful.
   return {
-    'aria-haspopup': ariaHasPopup,
+    'aria-haspopup': roleToAriaHasPopup[role],
     'aria-expanded': isOpen,
     'aria-controls': isOpen ? popoverId : undefined
   };

package/dist/es2019/internal/role-types.js

@@ -1,59 +0,0 @@
-/**
- * Valid values for the `aria-haspopup` attribute.
- *
- * Derived from the HTML spec - maps popover roles to what the trigger
- * announces. `undefined` means the attribute is omitted entirely (used for
- * non-popup roles like `tooltip`/`status`/`alert`/`note`/`log` where
- * `aria-haspopup` would be misleading).
- *
- * `true` is intentionally NOT in the union - the runtime only ever produces
- * the explicit string forms, so widening the type would invite consumers to
- * pass `true` and get an `aria-haspopup="true"` serialisation that the
- * runtime no longer emits.
- */
-
-/**
- * Roles that require an accessible name (`label` or `labelledBy`) per WCAG 4.1.2.
- * Without a name, assistive technology cannot identify these landmarks.
- */
-
-/**
- * Roles where the accessible name is derived from content or provided externally
- * (e.g. a combobox labels its listbox, tooltip content IS the accessible name).
- */
-
-// Shared ARIA role discrimination types
-//
-// These encode the WCAG 4.1.2 constraint: roles like `dialog`, `alertdialog`,
-// and `menu` MUST have an accessible name (either `label` or `labelledBy`).
-// TypeScript enforces this at compile time via discriminated unions.
-
-/**
- * ARIA role props where a role is always required.
- *
- * Used by `TPopupContentProps`. Popup content must always declare
- * its role so assistive technology can identify the layer.
- */
-
-/**
- * ARIA role props where a role is optional.
- *
- * Used by `TPopoverProps`. The low-level primitive allows omitting
- * the role for cases where it is set externally or not needed.
- */
-
-const rolesThatMoveFocus = new Set(['dialog', 'alertdialog', 'menu', 'listbox', 'tree', 'grid']);
-
-/**
- * Returns `true` when the given popover role moves focus into the popover
- * on open, and `false` otherwise (including when `role` is `undefined`).
- */
-// eslint-disable-next-line @atlaskit/volt-strict-mode/no-multiple-exports
-export function shouldFocusIntoPopover({
-  role
-}) {
-  if (!role) {
-    return false;
-  }
-  return rolesThatMoveFocus.has(role);
-}

package/dist/es2019/internal/use-anchor-position.js

@@ -307,11 +307,10 @@ export function useAnchorPosition({
        * See `notes/decisions/anchor-name-lifetime.md`
        */
       trigger.style.setProperty('anchor-name', anchorName);
-      const undoPositioning = combine(setStyle({
+      return setStyle({
         element: popover,
         styles: popoverStyles
-      }));
-      return undoPositioning;
+      });
     }
 
     // JS fallback. The popover is already in the top layer via
@@ -327,6 +326,38 @@ export function useAnchorPosition({
         value: 'auto'
       }]
     });
+
+    // The popover can be consumer-owned (`@atlaskit/popper`'s `createPopper`),
+    // so restore prior inline values rather than removing ours.
+    let undoPosition;
+    let undoHide;
+
+    // `opacity: 0` not `visibility: hidden`: Firefox skips visibility-hidden
+    // elements during `<dialog>` initial-focus traversal.
+    function hideUntilPositioned() {
+      // Keep the first snapshot, else we capture our own `opacity: 0`.
+      // (`!popover` is for TS: narrowing does not reach nested functions.)
+      if (!popover || undoHide) {
+        return;
+      }
+      undoHide = setStyle({
+        element: popover,
+        styles: [{
+          property: 'opacity',
+          value: '0'
+        }]
+      });
+    }
+    function reveal() {
+      var _undoHide;
+      (_undoHide = undoHide) === null || _undoHide === void 0 ? void 0 : _undoHide();
+      undoHide = undefined;
+    }
+    function restorePosition() {
+      var _undoPosition;
+      (_undoPosition = undoPosition) === null || _undoPosition === void 0 ? void 0 : _undoPosition();
+      undoPosition = undefined;
+    }
     function update() {
       if (!trigger || !popover) {
         return;
@@ -366,11 +397,20 @@ export function useAnchorPosition({
           direction: stablePlacement.offset.crossAxisShift.direction
         }
       });
-      popover.style.setProperty('top', `${top}px`);
-      popover.style.setProperty('left', `${left}px`);
-      // Reveal the popover only after it has been positioned.
-      // See the toggle listener below for why we hide on open.
-      popover.style.removeProperty('opacity');
+
+      // Restore first so the snapshot stays the consumer's value.
+      restorePosition();
+      undoPosition = setStyle({
+        element: popover,
+        styles: [{
+          property: 'top',
+          value: `${top}px`
+        }, {
+          property: 'left',
+          value: `${left}px`
+        }]
+      });
+      reveal();
     }
 
     // Throttle scroll/resize updates to one per animation frame
@@ -404,22 +444,17 @@ export function useAnchorPosition({
     // event has already fired and our listener below would miss it. Start
     // observing immediately so the first measurement still happens.
     if (isPopoverOpen(popover)) {
-      popover.style.setProperty('opacity', '0');
+      hideUntilPositioned();
       resizeObserver.observe(popover);
     }
     const undoPositioning = combine(cleanupBaseStyles,
-    // On every open: hide synchronously so the user never sees
-    // the UA-default position, then re-observe for a fresh
-    // measurement. We use `opacity: 0` rather than
-    // `visibility: hidden` because Firefox skips visibility-hidden
-    // elements during `<dialog>` initial-focus traversal. See
-    // `form-in-popup.spec.tsx` on `desktop-firefox`.
+    // Each open needs a fresh measurement, so hide and re-observe.
     bind(popover, {
       type: 'toggle',
       listener: event => {
         const toggleEvent = event;
         if (toggleEvent.newState === 'open') {
-          popover.style.setProperty('opacity', '0');
+          hideUntilPositioned();
           resizeObserver.observe(popover);
         }
       }
@@ -438,9 +473,8 @@ export function useAnchorPosition({
       }
     }), () => {
       scheduledUpdate.cancel();
-      popover.style.removeProperty('top');
-      popover.style.removeProperty('left');
-      popover.style.removeProperty('opacity');
+      restorePosition();
+      reveal();
     });
     return undoPositioning;
   }, [anchorRef, popoverRef, stablePlacement, forceFallbackPositioning, isEnabled, id, isOpen]);

package/dist/es2019/popover/popover.js

@@ -8,7 +8,7 @@ import mergeRefs from '@atlaskit/ds-lib/merge-refs';
 import once from '@atlaskit/ds-lib/once';
 import { useNotifyOpenLayerObserver } from '@atlaskit/layering/use-notify-open-layer-observer';
 import { resolvePlacement } from '../internal/resolve-placement';
-import { shouldFocusIntoPopover } from '../internal/role-types';
+import { shouldFocusIntoPopover } from '../internal/should-focus-into-popover';
 import { useAnimatedVisibility } from '../internal/use-animated-visibility';
 import { useFocusWrap } from '../internal/use-focus-wrap';
 import { useInitialFocus } from '../internal/use-initial-focus';

package/dist/esm/focus/is-in-same-layer.js

@@ -7,11 +7,5 @@ var topLayerSelector = '[popover], dialog, [role="dialog"], [role="alertdialog"]
 export function isInSameLayer(_ref) {
   var element = _ref.element,
     container = _ref.container;
-  var elementLayer = element.closest(topLayerSelector);
-  var containerLayer = container.closest(topLayerSelector);
-  // Both elements are in the "document" layer
-  if (!elementLayer && !containerLayer) {
-    return true;
-  }
-  return elementLayer === containerLayer;
+  return element.closest(topLayerSelector) === container.closest(topLayerSelector);
 }

package/dist/esm/focus/selectors.js

@@ -2,7 +2,7 @@ export var selectors = function () {
   // Common exclusion filter applied to every selector.
   var not = ':not([tabindex="-1"]):not([aria-disabled="true"]):not([aria-hidden="true"])';
   var notDisabled = ":not([disabled])".concat(not);
-  var focusable = ["a[href]".concat(not), "area[href]".concat(not), "input".concat(notDisabled, ":not([type=\"hidden\"])"), "select".concat(notDisabled), "textarea".concat(notDisabled), "button".concat(notDisabled), "iframe".concat(not), "audio[controls]".concat(not), "video[controls]".concat(not), "[contenteditable]:not([contenteditable=\"false\"])".concat(not), "[tabindex]".concat(notDisabled).concat(not)];
+  var focusable = ["a[href]".concat(not), "area[href]".concat(not), "input".concat(notDisabled, ":not([type=\"hidden\"])"), "select".concat(notDisabled), "textarea".concat(notDisabled), "button".concat(notDisabled), "iframe".concat(not), "audio[controls]".concat(not), "video[controls]".concat(not), "[contenteditable]:not([contenteditable=\"false\"])".concat(not), "[tabindex]".concat(notDisabled)];
   return {
     focusable: focusable.join(','),
     // Build the `:focus` selector