@atlaskit/top-layer 0.12.1 → 0.12.2
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/CHANGELOG.md +7 -0
- package/dist/cjs/animations/presets.js +5 -5
- package/dist/cjs/dialog/create-close-event.js +1 -1
- package/dist/cjs/dialog/dialog-content.js +5 -5
- package/dist/cjs/internal/ensure-preset-styles.js +1 -1
- package/dist/cjs/internal/reduced-motion.js +1 -1
- package/dist/cjs/internal/resolve-placement.js +2 -2
- package/dist/cjs/internal/role-types.js +1 -1
- package/dist/cjs/internal/slot.js +3 -3
- package/dist/cjs/internal/use-anchor-position.js +15 -30
- package/dist/cjs/internal/use-animated-visibility.js +10 -10
- package/dist/cjs/internal/use-animation-preset.js +1 -1
- package/dist/cjs/internal/use-preset-styles.js +1 -1
- package/dist/cjs/internal/use-width-from-anchor.js +4 -4
- package/dist/cjs/popover/create-close-event.js +1 -1
- package/dist/cjs/popover/popover.js +3 -3
- package/dist/cjs/popup/popup-content.js +4 -4
- package/dist/cjs/testing/polyfill.js +8 -8
- package/dist/cjs/testing/to-be-visible.js +5 -5
- package/dist/cjs/use-arrow-navigation/is-at-current-menu-level.js +19 -12
- package/dist/cjs/use-simple-light-dismiss/index.js +3 -3
- package/dist/es2019/animations/presets.js +5 -5
- package/dist/es2019/dialog/create-close-event.js +1 -1
- package/dist/es2019/dialog/dialog-content.js +5 -5
- package/dist/es2019/internal/ensure-preset-styles.js +1 -1
- package/dist/es2019/internal/reduced-motion.js +1 -1
- package/dist/es2019/internal/resolve-placement.js +2 -2
- package/dist/es2019/internal/role-types.js +1 -1
- package/dist/es2019/internal/slot.js +3 -3
- package/dist/es2019/internal/use-anchor-position.js +13 -16
- package/dist/es2019/internal/use-animated-visibility.js +10 -10
- package/dist/es2019/internal/use-animation-preset.js +1 -1
- package/dist/es2019/internal/use-preset-styles.js +1 -1
- package/dist/es2019/internal/use-width-from-anchor.js +4 -4
- package/dist/es2019/popover/create-close-event.js +1 -1
- package/dist/es2019/popover/popover.js +3 -3
- package/dist/es2019/popup/popup-content.js +4 -4
- package/dist/es2019/testing/polyfill.js +8 -8
- package/dist/es2019/testing/to-be-visible.js +5 -5
- package/dist/es2019/use-arrow-navigation/is-at-current-menu-level.js +19 -12
- package/dist/es2019/use-simple-light-dismiss/index.js +3 -3
- package/dist/esm/animations/presets.js +5 -5
- package/dist/esm/dialog/create-close-event.js +1 -1
- package/dist/esm/dialog/dialog-content.js +5 -5
- package/dist/esm/internal/ensure-preset-styles.js +1 -1
- package/dist/esm/internal/reduced-motion.js +1 -1
- package/dist/esm/internal/resolve-placement.js +2 -2
- package/dist/esm/internal/role-types.js +1 -1
- package/dist/esm/internal/slot.js +3 -3
- package/dist/esm/internal/use-anchor-position.js +15 -30
- package/dist/esm/internal/use-animated-visibility.js +10 -10
- package/dist/esm/internal/use-animation-preset.js +1 -1
- package/dist/esm/internal/use-preset-styles.js +1 -1
- package/dist/esm/internal/use-width-from-anchor.js +4 -4
- package/dist/esm/popover/create-close-event.js +1 -1
- package/dist/esm/popover/popover.js +3 -3
- package/dist/esm/popup/popup-content.js +4 -4
- package/dist/esm/testing/polyfill.js +8 -8
- package/dist/esm/testing/to-be-visible.js +5 -5
- package/dist/esm/use-arrow-navigation/is-at-current-menu-level.js +19 -12
- package/dist/esm/use-simple-light-dismiss/index.js +3 -3
- package/dist/types/dialog/create-close-event.d.ts +1 -1
- package/dist/types/dialog/types.d.ts +8 -0
- package/dist/types/internal/reduced-motion.d.ts +1 -1
- package/dist/types/internal/resolve-placement.d.ts +2 -2
- package/dist/types/internal/slot.d.ts +4 -4
- package/dist/types/internal/use-animated-visibility.d.ts +3 -3
- package/dist/types/internal/use-animation-preset.d.ts +1 -1
- package/dist/types/internal/use-preset-styles.d.ts +1 -1
- package/dist/types/internal/use-width-from-anchor.d.ts +2 -2
- package/dist/types/popover/create-close-event.d.ts +1 -1
- package/dist/types/popover/popover.d.ts +1 -1
- package/dist/types/popup/popup-context.d.ts +1 -1
- package/dist/types/testing/to-be-visible.d.ts +3 -3
- package/dist/types/use-simple-light-dismiss/index.d.ts +1 -1
- package/dist/types-ts4.5/dialog/create-close-event.d.ts +1 -1
- package/dist/types-ts4.5/dialog/types.d.ts +8 -0
- package/dist/types-ts4.5/internal/reduced-motion.d.ts +1 -1
- package/dist/types-ts4.5/internal/resolve-placement.d.ts +2 -2
- package/dist/types-ts4.5/internal/slot.d.ts +4 -4
- package/dist/types-ts4.5/internal/use-animated-visibility.d.ts +3 -3
- package/dist/types-ts4.5/internal/use-animation-preset.d.ts +1 -1
- package/dist/types-ts4.5/internal/use-preset-styles.d.ts +1 -1
- package/dist/types-ts4.5/internal/use-width-from-anchor.d.ts +2 -2
- package/dist/types-ts4.5/popover/create-close-event.d.ts +1 -1
- package/dist/types-ts4.5/popover/popover.d.ts +1 -1
- package/dist/types-ts4.5/popup/popup-context.d.ts +1 -1
- package/dist/types-ts4.5/testing/to-be-visible.d.ts +3 -3
- package/dist/types-ts4.5/use-simple-light-dismiss/index.d.ts +1 -1
- package/package.json +1 -1
|
@@ -2,21 +2,21 @@ import { type ForwardRefExoticComponent, type ReactNode, type RefAttributes } fr
|
|
|
2
2
|
/**
|
|
3
3
|
* Extra DOM/event props are passed through to the cloned child.
|
|
4
4
|
*/
|
|
5
|
-
export type
|
|
5
|
+
export type TSlotProps = {
|
|
6
6
|
children: ReactNode;
|
|
7
7
|
} & Record<string, unknown>;
|
|
8
8
|
/**
|
|
9
9
|
* Merges props (including ref) onto a single React element child.
|
|
10
10
|
*
|
|
11
11
|
* A safer alternative to raw `cloneElement` that:
|
|
12
|
-
* 1. Guards with `isValidElement`
|
|
12
|
+
* 1. Guards with `isValidElement` - non-element children (strings,
|
|
13
13
|
* fragments, null) are returned as-is instead of crashing.
|
|
14
14
|
* 2. Merges refs via `mergeRefs` so both the caller's ref and the
|
|
15
15
|
* child's existing ref are honoured.
|
|
16
16
|
* 3. Spreads any additional props (ARIA attributes, event handlers, etc.)
|
|
17
17
|
* onto the child element.
|
|
18
18
|
*
|
|
19
|
-
* Event handlers (e.g. `onClick`) are **not** auto-merged
|
|
19
|
+
* Event handlers (e.g. `onClick`) are **not** auto-merged - the caller's
|
|
20
20
|
* handler replaces the child's. Compose handlers before passing them in.
|
|
21
21
|
*
|
|
22
22
|
* @example
|
|
@@ -26,4 +26,4 @@ export type SlotProps = {
|
|
|
26
26
|
* </Slot>
|
|
27
27
|
* ```
|
|
28
28
|
*/
|
|
29
|
-
export declare const Slot: ForwardRefExoticComponent<
|
|
29
|
+
export declare const Slot: ForwardRefExoticComponent<TSlotProps & RefAttributes<HTMLElement>>;
|
|
@@ -44,19 +44,19 @@ type TUseAnimatedVisibilityResult = {
|
|
|
44
44
|
*
|
|
45
45
|
* Used by both `Popover` and `Dialog` to share the same animation lifecycle
|
|
46
46
|
* logic. Those components own their own show/hide mechanisms (showPopover /
|
|
47
|
-
* hidePopover vs showModal / close) and event handling
|
|
47
|
+
* hidePopover vs showModal / close) and event handling - this hook only
|
|
48
48
|
* manages the relationship between `isOpen` and when children are rendered.
|
|
49
49
|
*
|
|
50
50
|
* ## Problem
|
|
51
51
|
*
|
|
52
52
|
* We want to delay the unmount of children until a CSS exit transition has
|
|
53
53
|
* finished playing. If we unmount children the moment `isOpen` becomes
|
|
54
|
-
* `false`, the exit animation is never visible
|
|
54
|
+
* `false`, the exit animation is never visible - the content just disappears.
|
|
55
55
|
*
|
|
56
56
|
* ## How it works
|
|
57
57
|
*
|
|
58
58
|
* `showChildren` tracks whether the consumer's children should be in the DOM.
|
|
59
|
-
* It does not mirror `isOpen` exactly
|
|
59
|
+
* It does not mirror `isOpen` exactly - it intentionally lags behind during
|
|
60
60
|
* exit animations:
|
|
61
61
|
*
|
|
62
62
|
* ```
|
|
@@ -5,7 +5,7 @@ type TPresetWithCssAndName = {
|
|
|
5
5
|
/**
|
|
6
6
|
* Normalizes the `animate` prop to a preset (or null) and ensures its CSS
|
|
7
7
|
* is injected once into document.head. Used by PopupContent, Popover, and
|
|
8
|
-
* DialogContent so they
|
|
8
|
+
* DialogContent so they do not duplicate this logic.
|
|
9
9
|
*/
|
|
10
10
|
export declare function useAnimationPreset<T extends TPresetWithCssAndName>(animate: T | false | null | undefined): T | null;
|
|
11
11
|
export {};
|
|
@@ -6,7 +6,7 @@ type TPresetWithCssAndName = {
|
|
|
6
6
|
* Normalizes a preset prop to a value (or null) and ensures its CSS
|
|
7
7
|
* is injected once into `document.head`.
|
|
8
8
|
*
|
|
9
|
-
* Works with any preset that has `{ css, name }`
|
|
9
|
+
* Works with any preset that has `{ css, name }` - animation presets
|
|
10
10
|
* (TAnimationPreset) satisfies this shape.
|
|
11
11
|
*/
|
|
12
12
|
export declare function usePresetStyles<T extends TPresetWithCssAndName>({ preset, }: {
|
|
@@ -3,8 +3,8 @@ import type { TWidthFromAnchorMode } from '../popover/types';
|
|
|
3
3
|
/**
|
|
4
4
|
* Sets the width of a popover element relative to its anchor element.
|
|
5
5
|
*
|
|
6
|
-
* - `'match-anchor'` → `width: anchor-size(width)`
|
|
7
|
-
* - `'min-anchor'` → `min-width: anchor-size(width)`
|
|
6
|
+
* - `'match-anchor'` → `width: anchor-size(width)` - popover matches anchor width exactly.
|
|
7
|
+
* - `'min-anchor'` → `min-width: anchor-size(width)` - popover is at least as wide as anchor,
|
|
8
8
|
* but can grow wider.
|
|
9
9
|
* - `'none'` → no explicit width is set (default behaviour)
|
|
10
10
|
*
|
|
@@ -3,7 +3,7 @@ import type { TPopoverCloseReason } from './types';
|
|
|
3
3
|
* Creates a synthetic DOM event from a `TPopoverCloseReason`.
|
|
4
4
|
*
|
|
5
5
|
* Useful when bridging the Popover primitive's `onClose({ reason })` callback
|
|
6
|
-
* to a legacy API that expects a native DOM event
|
|
6
|
+
* to a legacy API that expects a native DOM event - for example,
|
|
7
7
|
* `@atlaskit/inline-dialog`'s `onClose(event)` contract.
|
|
8
8
|
*
|
|
9
9
|
* - `'escape'` → `KeyboardEvent('keydown', { key: 'Escape' })`
|
|
@@ -8,7 +8,7 @@ import { type TPopoverForwardedProps } from './types';
|
|
|
8
8
|
* Unopinionated top-layer primitive.
|
|
9
9
|
*
|
|
10
10
|
* Manages only visibility (isOpen) and animation (animate). Has no knowledge
|
|
11
|
-
* of positioning
|
|
11
|
+
* of positioning - compose with `useAnchorPosition` for anchor positioning
|
|
12
12
|
* and optionally `useWidthFromAnchor` for setting the width of a popover element
|
|
13
13
|
* relative to its anchor trigger.
|
|
14
14
|
*
|
|
@@ -79,7 +79,7 @@ export type TPopupContextValue = {
|
|
|
79
79
|
*/
|
|
80
80
|
ariaHasPopup: TAriaHasPopupValue;
|
|
81
81
|
/**
|
|
82
|
-
* Updates `ariaHasPopup`
|
|
82
|
+
* Updates `ariaHasPopup` - called by Content on mount/role change.
|
|
83
83
|
*/
|
|
84
84
|
setAriaHasPopup: (value: TAriaHasPopupValue) => void;
|
|
85
85
|
/**
|
|
@@ -3,13 +3,13 @@
|
|
|
3
3
|
*
|
|
4
4
|
* jest-dom's `toBeVisible()` does not know about the Popover API. In real
|
|
5
5
|
* browsers the UA stylesheet hides `[popover]` with `display: none`, but
|
|
6
|
-
* jsdom has no such stylesheet
|
|
6
|
+
* jsdom has no such stylesheet - so closed popovers incorrectly appear visible.
|
|
7
7
|
*
|
|
8
8
|
* Raw jest-dom results in jsdom:
|
|
9
9
|
*
|
|
10
|
-
* closed popover / child → true (WRONG
|
|
10
|
+
* closed popover / child → true (WRONG - should be false)
|
|
11
11
|
* open popover / child → true (correct)
|
|
12
|
-
* closed dialog / child → false (correct
|
|
12
|
+
* closed dialog / child → false (correct - jsdom natively hides <dialog>)
|
|
13
13
|
* open dialog / child → true (correct)
|
|
14
14
|
*
|
|
15
15
|
* We correct both false positives and false negatives:
|
|
@@ -34,7 +34,7 @@ type TUseSimpleLightDismissOptions = {
|
|
|
34
34
|
* **No stacking awareness:** This hook does not track a popover stack.
|
|
35
35
|
* If multiple manual popovers are open and all use this hook, a single
|
|
36
36
|
* Escape press or outside click will dismiss **all of them simultaneously**.
|
|
37
|
-
* This is by design
|
|
37
|
+
* This is by design - the hook is intentionally simple for cases where
|
|
38
38
|
* only one manual popover is open at a time.
|
|
39
39
|
*
|
|
40
40
|
* For stacked/nested popovers that should dismiss one-at-a-time, use
|
|
@@ -3,7 +3,7 @@ import type { TDialogCloseReason } from './types';
|
|
|
3
3
|
* Creates a synthetic DOM event from a `TDialogCloseReason`.
|
|
4
4
|
*
|
|
5
5
|
* Useful when bridging the Dialog primitive's `onClose({ reason })` callback
|
|
6
|
-
* to a legacy API that expects a `KeyboardEvent` or `MouseEvent`
|
|
6
|
+
* to a legacy API that expects a `KeyboardEvent` or `MouseEvent` - for example,
|
|
7
7
|
* `@atlaskit/modal-dialog`'s `onClose(event, analyticsEvent)` contract.
|
|
8
8
|
*
|
|
9
9
|
* - `'escape'` → `KeyboardEvent('keydown', { key: 'Escape' })`
|
|
@@ -49,6 +49,14 @@ type TDialogBaseProps = {
|
|
|
49
49
|
* Additional inline styles applied to the `<dialog>` element.
|
|
50
50
|
*
|
|
51
51
|
* Use for custom width, height, transform, or other overrides.
|
|
52
|
+
*
|
|
53
|
+
* Rule deviation: the house rules ban unbounded `style` props on
|
|
54
|
+
* components. `Dialog` is a low-level primitive that intentionally has
|
|
55
|
+
* no visual opinions of its own; consumers such as `@atlaskit/modal-dialog`
|
|
56
|
+
* must be able to set width, height, and transforms on the native
|
|
57
|
+
* `<dialog>` element. Removing this prop would be a breaking change
|
|
58
|
+
* and is tracked separately. Keep until an xcss-based replacement
|
|
59
|
+
* exists on the primitive.
|
|
52
60
|
*/
|
|
53
61
|
style?: CSSProperties;
|
|
54
62
|
/**
|
|
@@ -5,7 +5,7 @@
|
|
|
5
5
|
*
|
|
6
6
|
* The result is cached after the first call via `once`. This avoids
|
|
7
7
|
* calling `matchMedia` on every render. The trade-off is that if a user
|
|
8
|
-
* toggles the OS reduced-motion setting mid-session, the change
|
|
8
|
+
* toggles the OS reduced-motion setting mid-session, the change will not
|
|
9
9
|
* take effect until the next page load. This is acceptable because
|
|
10
10
|
* toggling this system-level preference mid-session is extremely rare,
|
|
11
11
|
* and a page refresh is a reasonable expectation for system accessibility
|
|
@@ -30,8 +30,8 @@ export type TPlacement = {
|
|
|
30
30
|
* CSS length string (e.g. `token('space.100')`).
|
|
31
31
|
*
|
|
32
32
|
* The two offset axes are named for clarity at the call site:
|
|
33
|
-
* - `gap`
|
|
34
|
-
* - `crossAxisShift`
|
|
33
|
+
* - `gap` - distance away from the trigger along the placement axis
|
|
34
|
+
* - `crossAxisShift` - nudge along the trigger edge (perpendicular to the placement axis)
|
|
35
35
|
*/
|
|
36
36
|
export type TPlacementOptions = {
|
|
37
37
|
axis?: 'block' | 'inline';
|
|
@@ -2,21 +2,21 @@ import { type ForwardRefExoticComponent, type ReactNode, type RefAttributes } fr
|
|
|
2
2
|
/**
|
|
3
3
|
* Extra DOM/event props are passed through to the cloned child.
|
|
4
4
|
*/
|
|
5
|
-
export type
|
|
5
|
+
export type TSlotProps = {
|
|
6
6
|
children: ReactNode;
|
|
7
7
|
} & Record<string, unknown>;
|
|
8
8
|
/**
|
|
9
9
|
* Merges props (including ref) onto a single React element child.
|
|
10
10
|
*
|
|
11
11
|
* A safer alternative to raw `cloneElement` that:
|
|
12
|
-
* 1. Guards with `isValidElement`
|
|
12
|
+
* 1. Guards with `isValidElement` - non-element children (strings,
|
|
13
13
|
* fragments, null) are returned as-is instead of crashing.
|
|
14
14
|
* 2. Merges refs via `mergeRefs` so both the caller's ref and the
|
|
15
15
|
* child's existing ref are honoured.
|
|
16
16
|
* 3. Spreads any additional props (ARIA attributes, event handlers, etc.)
|
|
17
17
|
* onto the child element.
|
|
18
18
|
*
|
|
19
|
-
* Event handlers (e.g. `onClick`) are **not** auto-merged
|
|
19
|
+
* Event handlers (e.g. `onClick`) are **not** auto-merged - the caller's
|
|
20
20
|
* handler replaces the child's. Compose handlers before passing them in.
|
|
21
21
|
*
|
|
22
22
|
* @example
|
|
@@ -26,4 +26,4 @@ export type SlotProps = {
|
|
|
26
26
|
* </Slot>
|
|
27
27
|
* ```
|
|
28
28
|
*/
|
|
29
|
-
export declare const Slot: ForwardRefExoticComponent<
|
|
29
|
+
export declare const Slot: ForwardRefExoticComponent<TSlotProps & RefAttributes<HTMLElement>>;
|
|
@@ -44,19 +44,19 @@ type TUseAnimatedVisibilityResult = {
|
|
|
44
44
|
*
|
|
45
45
|
* Used by both `Popover` and `Dialog` to share the same animation lifecycle
|
|
46
46
|
* logic. Those components own their own show/hide mechanisms (showPopover /
|
|
47
|
-
* hidePopover vs showModal / close) and event handling
|
|
47
|
+
* hidePopover vs showModal / close) and event handling - this hook only
|
|
48
48
|
* manages the relationship between `isOpen` and when children are rendered.
|
|
49
49
|
*
|
|
50
50
|
* ## Problem
|
|
51
51
|
*
|
|
52
52
|
* We want to delay the unmount of children until a CSS exit transition has
|
|
53
53
|
* finished playing. If we unmount children the moment `isOpen` becomes
|
|
54
|
-
* `false`, the exit animation is never visible
|
|
54
|
+
* `false`, the exit animation is never visible - the content just disappears.
|
|
55
55
|
*
|
|
56
56
|
* ## How it works
|
|
57
57
|
*
|
|
58
58
|
* `showChildren` tracks whether the consumer's children should be in the DOM.
|
|
59
|
-
* It does not mirror `isOpen` exactly
|
|
59
|
+
* It does not mirror `isOpen` exactly - it intentionally lags behind during
|
|
60
60
|
* exit animations:
|
|
61
61
|
*
|
|
62
62
|
* ```
|
|
@@ -5,7 +5,7 @@ type TPresetWithCssAndName = {
|
|
|
5
5
|
/**
|
|
6
6
|
* Normalizes the `animate` prop to a preset (or null) and ensures its CSS
|
|
7
7
|
* is injected once into document.head. Used by PopupContent, Popover, and
|
|
8
|
-
* DialogContent so they
|
|
8
|
+
* DialogContent so they do not duplicate this logic.
|
|
9
9
|
*/
|
|
10
10
|
export declare function useAnimationPreset<T extends TPresetWithCssAndName>(animate: T | false | null | undefined): T | null;
|
|
11
11
|
export {};
|
|
@@ -6,7 +6,7 @@ type TPresetWithCssAndName = {
|
|
|
6
6
|
* Normalizes a preset prop to a value (or null) and ensures its CSS
|
|
7
7
|
* is injected once into `document.head`.
|
|
8
8
|
*
|
|
9
|
-
* Works with any preset that has `{ css, name }`
|
|
9
|
+
* Works with any preset that has `{ css, name }` - animation presets
|
|
10
10
|
* (TAnimationPreset) satisfies this shape.
|
|
11
11
|
*/
|
|
12
12
|
export declare function usePresetStyles<T extends TPresetWithCssAndName>({ preset, }: {
|
|
@@ -3,8 +3,8 @@ import type { TWidthFromAnchorMode } from '../popover/types';
|
|
|
3
3
|
/**
|
|
4
4
|
* Sets the width of a popover element relative to its anchor element.
|
|
5
5
|
*
|
|
6
|
-
* - `'match-anchor'` → `width: anchor-size(width)`
|
|
7
|
-
* - `'min-anchor'` → `min-width: anchor-size(width)`
|
|
6
|
+
* - `'match-anchor'` → `width: anchor-size(width)` - popover matches anchor width exactly.
|
|
7
|
+
* - `'min-anchor'` → `min-width: anchor-size(width)` - popover is at least as wide as anchor,
|
|
8
8
|
* but can grow wider.
|
|
9
9
|
* - `'none'` → no explicit width is set (default behaviour)
|
|
10
10
|
*
|
|
@@ -3,7 +3,7 @@ import type { TPopoverCloseReason } from './types';
|
|
|
3
3
|
* Creates a synthetic DOM event from a `TPopoverCloseReason`.
|
|
4
4
|
*
|
|
5
5
|
* Useful when bridging the Popover primitive's `onClose({ reason })` callback
|
|
6
|
-
* to a legacy API that expects a native DOM event
|
|
6
|
+
* to a legacy API that expects a native DOM event - for example,
|
|
7
7
|
* `@atlaskit/inline-dialog`'s `onClose(event)` contract.
|
|
8
8
|
*
|
|
9
9
|
* - `'escape'` → `KeyboardEvent('keydown', { key: 'Escape' })`
|
|
@@ -8,7 +8,7 @@ import { type TPopoverForwardedProps } from './types';
|
|
|
8
8
|
* Unopinionated top-layer primitive.
|
|
9
9
|
*
|
|
10
10
|
* Manages only visibility (isOpen) and animation (animate). Has no knowledge
|
|
11
|
-
* of positioning
|
|
11
|
+
* of positioning - compose with `useAnchorPosition` for anchor positioning
|
|
12
12
|
* and optionally `useWidthFromAnchor` for setting the width of a popover element
|
|
13
13
|
* relative to its anchor trigger.
|
|
14
14
|
*
|
|
@@ -79,7 +79,7 @@ export type TPopupContextValue = {
|
|
|
79
79
|
*/
|
|
80
80
|
ariaHasPopup: TAriaHasPopupValue;
|
|
81
81
|
/**
|
|
82
|
-
* Updates `ariaHasPopup`
|
|
82
|
+
* Updates `ariaHasPopup` - called by Content on mount/role change.
|
|
83
83
|
*/
|
|
84
84
|
setAriaHasPopup: (value: TAriaHasPopupValue) => void;
|
|
85
85
|
/**
|
|
@@ -3,13 +3,13 @@
|
|
|
3
3
|
*
|
|
4
4
|
* jest-dom's `toBeVisible()` does not know about the Popover API. In real
|
|
5
5
|
* browsers the UA stylesheet hides `[popover]` with `display: none`, but
|
|
6
|
-
* jsdom has no such stylesheet
|
|
6
|
+
* jsdom has no such stylesheet - so closed popovers incorrectly appear visible.
|
|
7
7
|
*
|
|
8
8
|
* Raw jest-dom results in jsdom:
|
|
9
9
|
*
|
|
10
|
-
* closed popover / child → true (WRONG
|
|
10
|
+
* closed popover / child → true (WRONG - should be false)
|
|
11
11
|
* open popover / child → true (correct)
|
|
12
|
-
* closed dialog / child → false (correct
|
|
12
|
+
* closed dialog / child → false (correct - jsdom natively hides <dialog>)
|
|
13
13
|
* open dialog / child → true (correct)
|
|
14
14
|
*
|
|
15
15
|
* We correct both false positives and false negatives:
|
|
@@ -34,7 +34,7 @@ type TUseSimpleLightDismissOptions = {
|
|
|
34
34
|
* **No stacking awareness:** This hook does not track a popover stack.
|
|
35
35
|
* If multiple manual popovers are open and all use this hook, a single
|
|
36
36
|
* Escape press or outside click will dismiss **all of them simultaneously**.
|
|
37
|
-
* This is by design
|
|
37
|
+
* This is by design - the hook is intentionally simple for cases where
|
|
38
38
|
* only one manual popover is open at a time.
|
|
39
39
|
*
|
|
40
40
|
* For stacked/nested popovers that should dismiss one-at-a-time, use
|
package/package.json
CHANGED
|
@@ -1,6 +1,6 @@
|
|
|
1
1
|
{
|
|
2
2
|
"name": "@atlaskit/top-layer",
|
|
3
|
-
"version": "0.12.
|
|
3
|
+
"version": "0.12.2",
|
|
4
4
|
"description": "Low-level layering primitives based on popover and dialog",
|
|
5
5
|
"homepage": "https://atlassian.design/components/top-layer",
|
|
6
6
|
"repository": "https://bitbucket.org/atlassian/atlassian-frontend-mirror",
|