@atlaskit/smart-card 26.9.19 → 26.11.0

package/CHANGELOG.md

@@ -1,5 +1,18 @@
 # @atlaskit/smart-card
 
+## 26.11.0
+
+### Minor Changes
+
+- [`fdfe07831c7`](https://bitbucket.org/atlassian/atlassian-frontend/commits/fdfe07831c7) - - Deprecate standalone hover card `onAuthorize` prop (no implementation)
+  - Hide auth tooltip on unauthenticated inline link with no auth flow (new design, behind feature flag)
+
+## 26.10.0
+
+### Minor Changes
+
+- [`fa12a765333`](https://bitbucket.org/atlassian/atlassian-frontend/commits/fa12a765333) - Cleansup a FF introduced in 26.3.5 (platform.linking-platform.smart-card.remove-dispatch-analytics-as-prop) providing default display attribute now prefers analytics context instead of passing a dispatch function as prop.
+
 ## 26.9.19
 
 ### Patch Changes

package/dist/cjs/version.json

@@ -1,5 +1,5 @@
 {
 	"name": "@atlaskit/smart-card",
-	"version": "26.9.19",
+	"version": "26.11.0",
 	"sideEffects": false
 }

package/dist/cjs/view/CardWithUrl/loader.js

@@ -9,11 +9,9 @@ var _typeof2 = _interopRequireDefault(require("@babel/runtime/helpers/typeof"));
 var _slicedToArray2 = _interopRequireDefault(require("@babel/runtime/helpers/slicedToArray"));
 var _react = _interopRequireWildcard(require("react"));
 var _uuid = _interopRequireDefault(require("uuid"));
-var _platformFeatureFlags = require("@atlaskit/platform-feature-flags");
-var _analytics = require("../../utils/analytics");
 var _performance = require("../../utils/performance");
 var _reactErrorBoundary = require("react-error-boundary");
-var _analytics2 = require("../../state/analytics");
+var _analytics = require("../../state/analytics");
 var _LazyFallback = require("./component-lazy/LazyFallback");
 var _utils = require("../../utils");
 var _flexible = require("../../utils/flexible");
@@ -56,7 +54,6 @@ function CardWithURLRenderer(props) {
     embedIframeRef = props.embedIframeRef,
     embedIframeUrlType = props.embedIframeUrlType,
     inlinePreloaderStyle = props.inlinePreloaderStyle,
-    createAnalyticsEvent = props.createAnalyticsEvent,
     children = props.children,
     ui = props.ui,
     showHoverPreview = props.showHoverPreview,
@@ -64,33 +61,7 @@ function CardWithURLRenderer(props) {
     analyticsEvents = props.analyticsEvents,
     placeholder = props.placeholder,
     fallbackComponent = props.fallbackComponent;
-
-  // Wrapper around analytics.
-  var dispatchAnalytics = (0, _react.useMemo)(function () {
-    /**
-     * If feature flag is on, return `undefined` for dispatch, which will be passed down
-     * to the components as undefined and the fallback method will be used instead to dispatch
-     * analytics events:
-     * packages/linking-platform/smart-card/src/state/analytics/useDispatchAnalytics.ts
-     *
-     * For FF cleanup, we should be able to remove the prop from all the places where this is
-     * being passed down to.
-     */
-    if ((0, _platformFeatureFlags.getBooleanFF)('platform.linking-platform.smart-card.remove-dispatch-analytics-as-prop')) {
-      return undefined;
-    }
-    return function (analyticsPayload) {
-      if (analyticsPayload && analyticsPayload.attributes) {
-        // Update if we haven't already set the display - possible
-        // in the case of `preview` which is rendered differently.
-        if (!analyticsPayload.attributes.display) {
-          analyticsPayload.attributes.display = appearance;
-        }
-      }
-      (0, _analytics.fireSmartLinkEvent)(analyticsPayload, createAnalyticsEvent);
-    };
-  }, [appearance, createAnalyticsEvent]);
-  var analytics = (0, _analytics2.useSmartLinkAnalytics)(url !== null && url !== void 0 ? url : '', dispatchAnalytics, id);
+  var analytics = (0, _analytics.useSmartLinkAnalytics)(url !== null && url !== void 0 ? url : '', undefined, id);
   var isFlexibleUi = (0, _flexible.isFlexibleUiCard)(children);
   var errorHandler = (0, _react.useCallback)(function (error, info) {
     var componentStack = info.componentStack;
@@ -140,7 +111,6 @@ function CardWithURLRenderer(props) {
     isSelected: isSelected,
     isFrameVisible: isFrameVisible,
     frameStyle: frameStyle,
-    dispatchAnalytics: dispatchAnalytics,
     container: container,
     onResolve: onResolve,
     onError: onError,

package/dist/cjs/view/FlexibleCard/components/container/index.js

@@ -166,6 +166,8 @@ var Container = function Container(_ref3) {
   var context = (0, _react.useContext)(_flexibleUiContext.FlexibleUiContext);
   var childrenOptions = getChildrenOptions(children, context);
   var canShowHoverPreview = showHoverPreview && status === 'resolved';
+  // `retry` object contains action that can be performed on
+  // unresolved link (unauthorized, forbidden, not found, etc.)
   var canShowAuthTooltip = showAuthTooltip && status === 'unauthorized' && retry !== undefined;
   var container = (0, _react2.jsx)("div", {
     css: getContainerStyles(size, hideBackground, hideElevation, hidePadding, clickableContainer, childrenOptions),

package/dist/cjs/view/InlineCard/UnauthorisedView/index.js

@@ -100,7 +100,6 @@ var InlineCardUnauthorizedView = /*#__PURE__*/function (_React$Component) {
       if (onAuthorise && showAuthTooltip) {
         return /*#__PURE__*/_react.default.createElement(_HoverCard.HoverCard, {
           url: url,
-          onAuthorize: onAuthorise,
           id: this.props.id
         }, inlineCardUnauthenticatedView);
       }

package/dist/cjs/view/RedesignedInlineCard/UnauthorisedView/index.js

@@ -81,6 +81,7 @@ var InlineCardUnauthorizedView = /*#__PURE__*/function (_React$Component) {
       var _this$props3 = this.props,
         url = _this$props3.url,
         icon = _this$props3.icon,
+        onAuthorise = _this$props3.onAuthorise,
         onClick = _this$props3.onClick,
         isSelected = _this$props3.isSelected,
         _this$props3$testId = _this$props3.testId,
@@ -98,10 +99,9 @@ var InlineCardUnauthorizedView = /*#__PURE__*/function (_React$Component) {
         onClick: onClick,
         titleColor: "var(--ds-text-subtle, ".concat(_colors.N500, ")")
       }), this.renderActionButton());
-      if (showAuthTooltip) {
+      if (onAuthorise && showAuthTooltip) {
         return /*#__PURE__*/_react.default.createElement(_HoverCard.HoverCard, {
           url: url,
-          onAuthorize: this.props.onAuthorise,
           id: this.props.id
         }, inlineCardUnauthenticatedView);
       }

package/dist/es2019/state/analytics/useDispatchAnalytics.js

@@ -1,6 +1,7 @@
 import { useMemo } from 'react';
 import { useAnalyticsEvents } from '@atlaskit/analytics-next';
 import { ANALYTICS_CHANNEL } from '../../utils/analytics';
+
 /**
  * Hook designed to use a handler if provided (ideally not)
  * Use this for the short-term to support deprecating `analyticsHandler`s that are being provided externally,

package/dist/es2019/version.json

@@ -1,5 +1,5 @@
 {
 	"name": "@atlaskit/smart-card",
-	"version": "26.9.19",
+	"version": "26.11.0",
 	"sideEffects": false
 }

package/dist/es2019/view/CardWithUrl/loader.js

@@ -1,7 +1,5 @@
-import React, { lazy, useEffect, useState, Suspense, useCallback, useMemo } from 'react';
+import React, { lazy, useEffect, useState, Suspense, useCallback } from 'react';
 import uuid from 'uuid';
-import { getBooleanFF } from '@atlaskit/platform-feature-flags';
-import { fireSmartLinkEvent } from '../../utils/analytics';
 import { clearMarks, clearMeasures } from '../../utils/performance';
 import { ErrorBoundary } from 'react-error-boundary';
 import { useSmartLinkAnalytics } from '../../state/analytics';
@@ -36,7 +34,6 @@ export function CardWithURLRenderer(props) {
     embedIframeRef,
     embedIframeUrlType,
     inlinePreloaderStyle,
-    createAnalyticsEvent,
     children,
     ui,
     showHoverPreview,
@@ -45,33 +42,7 @@ export function CardWithURLRenderer(props) {
     placeholder,
     fallbackComponent
   } = props;
-
-  // Wrapper around analytics.
-  const dispatchAnalytics = useMemo(() => {
-    /**
-     * If feature flag is on, return `undefined` for dispatch, which will be passed down
-     * to the components as undefined and the fallback method will be used instead to dispatch
-     * analytics events:
-     * packages/linking-platform/smart-card/src/state/analytics/useDispatchAnalytics.ts
-     *
-     * For FF cleanup, we should be able to remove the prop from all the places where this is
-     * being passed down to.
-     */
-    if (getBooleanFF('platform.linking-platform.smart-card.remove-dispatch-analytics-as-prop')) {
-      return undefined;
-    }
-    return analyticsPayload => {
-      if (analyticsPayload && analyticsPayload.attributes) {
-        // Update if we haven't already set the display - possible
-        // in the case of `preview` which is rendered differently.
-        if (!analyticsPayload.attributes.display) {
-          analyticsPayload.attributes.display = appearance;
-        }
-      }
-      fireSmartLinkEvent(analyticsPayload, createAnalyticsEvent);
-    };
-  }, [appearance, createAnalyticsEvent]);
-  const analytics = useSmartLinkAnalytics(url !== null && url !== void 0 ? url : '', dispatchAnalytics, id);
+  const analytics = useSmartLinkAnalytics(url !== null && url !== void 0 ? url : '', undefined, id);
   const isFlexibleUi = isFlexibleUiCard(children);
   const errorHandler = useCallback((error, info) => {
     const {
@@ -119,7 +90,6 @@ export function CardWithURLRenderer(props) {
     isSelected,
     isFrameVisible,
     frameStyle,
-    dispatchAnalytics,
     container,
     onResolve,
     onError,

package/dist/es2019/view/FlexibleCard/components/container/index.js

@@ -187,6 +187,8 @@ const Container = ({
   const context = useContext(FlexibleUiContext);
   const childrenOptions = getChildrenOptions(children, context);
   const canShowHoverPreview = showHoverPreview && status === 'resolved';
+  // `retry` object contains action that can be performed on
+  // unresolved link (unauthorized, forbidden, not found, etc.)
   const canShowAuthTooltip = showAuthTooltip && status === 'unauthorized' && retry !== undefined;
   const container = jsx("div", {
     css: getContainerStyles(size, hideBackground, hideElevation, hidePadding, clickableContainer, childrenOptions),

package/dist/es2019/view/InlineCard/UnauthorisedView/index.js

@@ -76,7 +76,6 @@ export class InlineCardUnauthorizedView extends React.Component {
     if (onAuthorise && showAuthTooltip) {
       return /*#__PURE__*/React.createElement(HoverCard, {
         url: url,
-        onAuthorize: onAuthorise,
         id: this.props.id
       }, inlineCardUnauthenticatedView);
     }

package/dist/es2019/view/RedesignedInlineCard/UnauthorisedView/index.js

@@ -58,6 +58,7 @@ export class InlineCardUnauthorizedView extends React.Component {
     const {
       url,
       icon,
+      onAuthorise,
       onClick,
       isSelected,
       testId = 'inline-card-unauthorized-view',
@@ -74,10 +75,9 @@ export class InlineCardUnauthorizedView extends React.Component {
       onClick: onClick,
       titleColor: `var(--ds-text-subtle, ${N500})`
     }), this.renderActionButton());
-    if (showAuthTooltip) {
+    if (onAuthorise && showAuthTooltip) {
       return /*#__PURE__*/React.createElement(HoverCard, {
         url: url,
-        onAuthorize: this.props.onAuthorise,
         id: this.props.id
       }, inlineCardUnauthenticatedView);
     }

package/dist/esm/state/analytics/useDispatchAnalytics.js

@@ -1,6 +1,7 @@
 import { useMemo } from 'react';
 import { useAnalyticsEvents } from '@atlaskit/analytics-next';
 import { ANALYTICS_CHANNEL } from '../../utils/analytics';
+
 /**
  * Hook designed to use a handler if provided (ideally not)
  * Use this for the short-term to support deprecating `analyticsHandler`s that are being provided externally,

package/dist/esm/version.json

@@ -1,5 +1,5 @@
 {
 	"name": "@atlaskit/smart-card",
-	"version": "26.9.19",
+	"version": "26.11.0",
 	"sideEffects": false
 }

package/dist/esm/view/CardWithUrl/loader.js

@@ -1,8 +1,6 @@
 import _slicedToArray from "@babel/runtime/helpers/slicedToArray";
-import React, { lazy, useEffect, useState, Suspense, useCallback, useMemo } from 'react';
+import React, { lazy, useEffect, useState, Suspense, useCallback } from 'react';
 import uuid from 'uuid';
-import { getBooleanFF } from '@atlaskit/platform-feature-flags';
-import { fireSmartLinkEvent } from '../../utils/analytics';
 import { clearMarks, clearMeasures } from '../../utils/performance';
 import { ErrorBoundary } from 'react-error-boundary';
 import { useSmartLinkAnalytics } from '../../state/analytics';
@@ -44,7 +42,6 @@ export function CardWithURLRenderer(props) {
     embedIframeRef = props.embedIframeRef,
     embedIframeUrlType = props.embedIframeUrlType,
     inlinePreloaderStyle = props.inlinePreloaderStyle,
-    createAnalyticsEvent = props.createAnalyticsEvent,
     children = props.children,
     ui = props.ui,
     showHoverPreview = props.showHoverPreview,
@@ -52,33 +49,7 @@ export function CardWithURLRenderer(props) {
     analyticsEvents = props.analyticsEvents,
     placeholder = props.placeholder,
     fallbackComponent = props.fallbackComponent;
-
-  // Wrapper around analytics.
-  var dispatchAnalytics = useMemo(function () {
-    /**
-     * If feature flag is on, return `undefined` for dispatch, which will be passed down
-     * to the components as undefined and the fallback method will be used instead to dispatch
-     * analytics events:
-     * packages/linking-platform/smart-card/src/state/analytics/useDispatchAnalytics.ts
-     *
-     * For FF cleanup, we should be able to remove the prop from all the places where this is
-     * being passed down to.
-     */
-    if (getBooleanFF('platform.linking-platform.smart-card.remove-dispatch-analytics-as-prop')) {
-      return undefined;
-    }
-    return function (analyticsPayload) {
-      if (analyticsPayload && analyticsPayload.attributes) {
-        // Update if we haven't already set the display - possible
-        // in the case of `preview` which is rendered differently.
-        if (!analyticsPayload.attributes.display) {
-          analyticsPayload.attributes.display = appearance;
-        }
-      }
-      fireSmartLinkEvent(analyticsPayload, createAnalyticsEvent);
-    };
-  }, [appearance, createAnalyticsEvent]);
-  var analytics = useSmartLinkAnalytics(url !== null && url !== void 0 ? url : '', dispatchAnalytics, id);
+  var analytics = useSmartLinkAnalytics(url !== null && url !== void 0 ? url : '', undefined, id);
   var isFlexibleUi = isFlexibleUiCard(children);
   var errorHandler = useCallback(function (error, info) {
     var componentStack = info.componentStack;
@@ -128,7 +99,6 @@ export function CardWithURLRenderer(props) {
     isSelected: isSelected,
     isFrameVisible: isFrameVisible,
     frameStyle: frameStyle,
-    dispatchAnalytics: dispatchAnalytics,
     container: container,
     onResolve: onResolve,
     onError: onError,

package/dist/esm/view/FlexibleCard/components/container/index.js

@@ -155,6 +155,8 @@ var Container = function Container(_ref3) {
   var context = useContext(FlexibleUiContext);
   var childrenOptions = getChildrenOptions(children, context);
   var canShowHoverPreview = showHoverPreview && status === 'resolved';
+  // `retry` object contains action that can be performed on
+  // unresolved link (unauthorized, forbidden, not found, etc.)
   var canShowAuthTooltip = showAuthTooltip && status === 'unauthorized' && retry !== undefined;
   var container = jsx("div", {
     css: getContainerStyles(size, hideBackground, hideElevation, hidePadding, clickableContainer, childrenOptions),

package/dist/esm/view/InlineCard/UnauthorisedView/index.js

@@ -93,7 +93,6 @@ export var InlineCardUnauthorizedView = /*#__PURE__*/function (_React$Component)
       if (onAuthorise && showAuthTooltip) {
         return /*#__PURE__*/React.createElement(HoverCard, {
           url: url,
-          onAuthorize: onAuthorise,
           id: this.props.id
         }, inlineCardUnauthenticatedView);
       }

package/dist/esm/view/RedesignedInlineCard/UnauthorisedView/index.js

@@ -74,6 +74,7 @@ export var InlineCardUnauthorizedView = /*#__PURE__*/function (_React$Component)
       var _this$props3 = this.props,
         url = _this$props3.url,
         icon = _this$props3.icon,
+        onAuthorise = _this$props3.onAuthorise,
         onClick = _this$props3.onClick,
         isSelected = _this$props3.isSelected,
         _this$props3$testId = _this$props3.testId,
@@ -91,10 +92,9 @@ export var InlineCardUnauthorizedView = /*#__PURE__*/function (_React$Component)
         onClick: onClick,
         titleColor: "var(--ds-text-subtle, ".concat(N500, ")")
       }), this.renderActionButton());
-      if (showAuthTooltip) {
+      if (onAuthorise && showAuthTooltip) {
         return /*#__PURE__*/React.createElement(HoverCard, {
           url: url,
-          onAuthorize: this.props.onAuthorise,
           id: this.props.id
         }, inlineCardUnauthenticatedView);
       }

package/dist/types/view/HoverCard/types.d.ts

@@ -22,6 +22,7 @@ export interface HoverCardProps extends WithAnalyticsEventsProps {
     children: ReactElement;
     /**
      * Function to be called when user is authorized to view a link.
+     * @deprecated See EDM-7411
      */
     onAuthorize?: () => void;
     /**

package/dist/types-ts4.5/view/HoverCard/types.d.ts

@@ -22,6 +22,7 @@ export interface HoverCardProps extends WithAnalyticsEventsProps {
     children: ReactElement;
     /**
      * Function to be called when user is authorized to view a link.
+     * @deprecated See EDM-7411
      */
     onAuthorize?: () => void;
     /**

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@atlaskit/smart-card",
-  "version": "26.9.19",
+  "version": "26.11.0",
   "description": "Smart card component",
   "publishConfig": {
     "registry": "https://registry.npmjs.org/"
@@ -74,7 +74,7 @@
     "@af/visual-regression": "*",
     "@atlaskit/avatar": "^21.3.0",
     "@atlaskit/css-reset": "^6.5.0",
-    "@atlaskit/link-test-helpers": "^4.2.0",
+    "@atlaskit/link-test-helpers": "^5.0.0",
     "@atlaskit/lozenge": "^11.4.0",
     "@atlaskit/media-integration-test-helpers": "^3.0.0",
     "@atlaskit/media-test-helpers": "^33.0.0",
@@ -134,9 +134,6 @@
     ".": "./src/index.ts"
   },
   "platform-feature-flags": {
-    "platform.linking-platform.smart-card.remove-dispatch-analytics-as-prop": {
-      "type": "boolean"
-    },
     "platform.linking-platform.smart-card.enable-block-card-clicks-opening-in-same-tab": {
       "type": "boolean"
     },