@atlaskit/smart-card 26.8.1 → 26.9.0

package/CHANGELOG.md

@@ -1,5 +1,11 @@
 # @atlaskit/smart-card
 
+## 26.9.0
+
+### Minor Changes
+
+- [`7811ab546b9`](https://bitbucket.org/atlassian/atlassian-frontend/commits/7811ab546b9) - Cleans up FF platform.linking-platform.smart-card.enable-analytics-context introduced in 26.2.2 — resolved attributes now provided to all events fired within Smart Card by default.
+
 ## 26.8.1
 
 ### Patch Changes

package/dist/cjs/state/hooks/use-resolve/index.js

@@ -12,7 +12,6 @@ var _reactDom = require("react-dom");
 var _analytics = require("../../analytics");
 var _helpers = require("../../helpers");
 var _linkingCommon = require("@atlaskit/linking-common");
-var _platformFeatureFlags = require("@atlaskit/platform-feature-flags");
 var _constants = require("../../actions/constants");
 var _jsonld = require("../../../utils/jsonld");
 var _constants2 = require("../../../constants");
@@ -120,19 +119,16 @@ var useResolve = function useResolve() {
       handleResolvedLinkError(resourceUrl, new _linkingCommon.APIError('error', hostname, _constants.ERROR_MESSAGE_METADATA), response, isMetadataRequest);
       return;
     }
-    if ((0, _platformFeatureFlags.getBooleanFF)('platform.linking-platform.smart-card.enable-analytics-context')) {
-      /**
-       * Using unstable_batchedUpdates because this store update happens async and trigers a rerender
-       * more info:
-       * https://github.com/facebook/react/blob/v18.2.0/packages/use-sync-external-store/src/useSyncExternalStoreShimClient.js#L113
-       * https://react-redux.js.org/api/batch
-       */
-      (0, _reactDom.unstable_batchedUpdates)(function () {
-        handleResolvedLinkSuccess(resourceUrl, response, isReloading, isMetadataRequest);
-      });
-    } else {
+
+    /**
+     * Using unstable_batchedUpdates because this store update happens async and trigers a rerender
+     * more info:
+     * https://github.com/facebook/react/blob/v18.2.0/packages/use-sync-external-store/src/useSyncExternalStoreShimClient.js#L113
+     * https://react-redux.js.org/api/batch
+     */
+    (0, _reactDom.unstable_batchedUpdates)(function () {
       handleResolvedLinkSuccess(resourceUrl, response, isReloading, isMetadataRequest);
-    }
+    });
   }, [handleResolvedLinkError, handleResolvedLinkSuccess, hasAuthFlowSupported]);
   return (0, _react.useCallback)( /*#__PURE__*/function () {
     var _ref2 = (0, _asyncToGenerator2.default)( /*#__PURE__*/_regenerator.default.mark(function _callee(url) {

package/dist/cjs/version.json

@@ -1,5 +1,5 @@
 {
 	"name": "@atlaskit/smart-card",
-	"version": "26.8.1",
+	"version": "26.9.0",
 	"sideEffects": false
 }

package/dist/cjs/view/CardWithUrl/component.js

@@ -9,7 +9,6 @@ exports.CardWithUrlContent = void 0;
 var _react = _interopRequireWildcard(require("react"));
 var _analyticsNext = require("@atlaskit/analytics-next");
 var _linkProvider = require("@atlaskit/link-provider");
-var _platformFeatureFlags = require("@atlaskit/platform-feature-flags");
 var _utils = require("../../utils");
 var measure = _interopRequireWildcard(require("../../utils/performance"));
 var _helpers = require("../../state/helpers");
@@ -273,14 +272,11 @@ function Component(_ref) {
   }
 }
 var CardWithUrlContent = function CardWithUrlContent(props) {
-  if ((0, _platformFeatureFlags.getBooleanFF)('platform.linking-platform.smart-card.enable-analytics-context')) {
-    var display = (0, _flexible.isFlexibleUiCard)(props.children) ? _constants.CardDisplay.Flexible : props.appearance;
-    return /*#__PURE__*/_react.default.createElement(_SmartLinkAnalyticsContext.SmartLinkAnalyticsContext, {
-      url: props.url,
-      id: props.id,
-      display: display
-    }, /*#__PURE__*/_react.default.createElement(Component, props));
-  }
-  return /*#__PURE__*/_react.default.createElement(Component, props);
+  var display = (0, _flexible.isFlexibleUiCard)(props.children) ? _constants.CardDisplay.Flexible : props.appearance;
+  return /*#__PURE__*/_react.default.createElement(_SmartLinkAnalyticsContext.SmartLinkAnalyticsContext, {
+    url: props.url,
+    id: props.id,
+    display: display
+  }, /*#__PURE__*/_react.default.createElement(Component, props));
 };
 exports.CardWithUrlContent = CardWithUrlContent;

package/dist/es2019/state/hooks/use-resolve/index.js

@@ -3,7 +3,6 @@ import { unstable_batchedUpdates } from 'react-dom';
 import { addMetadataToExperience } from '../../analytics';
 import { getStatus } from '../../helpers';
 import { ACTION_ERROR, ACTION_ERROR_FALLBACK, ACTION_RELOADING, ACTION_RESOLVED, ACTION_UPDATE_METADATA_STATUS, APIError, cardAction } from '@atlaskit/linking-common';
-import { getBooleanFF } from '@atlaskit/platform-feature-flags';
 import { ERROR_MESSAGE_FATAL, ERROR_MESSAGE_METADATA, ERROR_MESSAGE_OAUTH } from '../../actions/constants';
 import { getUnauthorizedJsonLd } from '../../../utils/jsonld';
 import { SmartLinkStatus } from '../../../constants';
@@ -113,19 +112,16 @@ const useResolve = () => {
       handleResolvedLinkError(resourceUrl, new APIError('error', hostname, ERROR_MESSAGE_METADATA), response, isMetadataRequest);
       return;
     }
-    if (getBooleanFF('platform.linking-platform.smart-card.enable-analytics-context')) {
-      /**
-       * Using unstable_batchedUpdates because this store update happens async and trigers a rerender
-       * more info:
-       * https://github.com/facebook/react/blob/v18.2.0/packages/use-sync-external-store/src/useSyncExternalStoreShimClient.js#L113
-       * https://react-redux.js.org/api/batch
-       */
-      unstable_batchedUpdates(() => {
-        handleResolvedLinkSuccess(resourceUrl, response, isReloading, isMetadataRequest);
-      });
-    } else {
+
+    /**
+     * Using unstable_batchedUpdates because this store update happens async and trigers a rerender
+     * more info:
+     * https://github.com/facebook/react/blob/v18.2.0/packages/use-sync-external-store/src/useSyncExternalStoreShimClient.js#L113
+     * https://react-redux.js.org/api/batch
+     */
+    unstable_batchedUpdates(() => {
       handleResolvedLinkSuccess(resourceUrl, response, isReloading, isMetadataRequest);
-    }
+    });
   }, [handleResolvedLinkError, handleResolvedLinkSuccess, hasAuthFlowSupported]);
   return useCallback(async (url, isReloading = false, isMetadataRequest = false, id = '') => {
     const {

package/dist/es2019/version.json

@@ -1,5 +1,5 @@
 {
 	"name": "@atlaskit/smart-card",
-	"version": "26.8.1",
+	"version": "26.9.0",
 	"sideEffects": false
 }

package/dist/es2019/view/CardWithUrl/component.js

@@ -1,7 +1,6 @@
 import React, { useEffect, useCallback, useMemo } from 'react';
 import { useAnalyticsEvents } from '@atlaskit/analytics-next';
 import { useFeatureFlag } from '@atlaskit/link-provider';
-import { getBooleanFF } from '@atlaskit/platform-feature-flags';
 import { isSpecialEvent } from '../../utils';
 import * as measure from '../../utils/performance';
 import { getDefinitionId, getServices, isFinalState, getClickUrl, getResourceType, getExtensionKey, getSubproduct, getProduct } from '../../state/helpers';
@@ -260,13 +259,10 @@ function Component({
   }
 }
 export const CardWithUrlContent = props => {
-  if (getBooleanFF('platform.linking-platform.smart-card.enable-analytics-context')) {
-    const display = isFlexibleUiCard(props.children) ? CardDisplay.Flexible : props.appearance;
-    return /*#__PURE__*/React.createElement(SmartLinkAnalyticsContext, {
-      url: props.url,
-      id: props.id,
-      display: display
-    }, /*#__PURE__*/React.createElement(Component, props));
-  }
-  return /*#__PURE__*/React.createElement(Component, props);
+  const display = isFlexibleUiCard(props.children) ? CardDisplay.Flexible : props.appearance;
+  return /*#__PURE__*/React.createElement(SmartLinkAnalyticsContext, {
+    url: props.url,
+    id: props.id,
+    display: display
+  }, /*#__PURE__*/React.createElement(Component, props));
 };

package/dist/esm/state/hooks/use-resolve/index.js

@@ -5,7 +5,6 @@ import { unstable_batchedUpdates } from 'react-dom';
 import { addMetadataToExperience } from '../../analytics';
 import { getStatus } from '../../helpers';
 import { ACTION_ERROR, ACTION_ERROR_FALLBACK, ACTION_RELOADING, ACTION_RESOLVED, ACTION_UPDATE_METADATA_STATUS, APIError, cardAction } from '@atlaskit/linking-common';
-import { getBooleanFF } from '@atlaskit/platform-feature-flags';
 import { ERROR_MESSAGE_FATAL, ERROR_MESSAGE_METADATA, ERROR_MESSAGE_OAUTH } from '../../actions/constants';
 import { getUnauthorizedJsonLd } from '../../../utils/jsonld';
 import { SmartLinkStatus } from '../../../constants';
@@ -113,19 +112,16 @@ var useResolve = function useResolve() {
       handleResolvedLinkError(resourceUrl, new APIError('error', hostname, ERROR_MESSAGE_METADATA), response, isMetadataRequest);
       return;
     }
-    if (getBooleanFF('platform.linking-platform.smart-card.enable-analytics-context')) {
-      /**
-       * Using unstable_batchedUpdates because this store update happens async and trigers a rerender
-       * more info:
-       * https://github.com/facebook/react/blob/v18.2.0/packages/use-sync-external-store/src/useSyncExternalStoreShimClient.js#L113
-       * https://react-redux.js.org/api/batch
-       */
-      unstable_batchedUpdates(function () {
-        handleResolvedLinkSuccess(resourceUrl, response, isReloading, isMetadataRequest);
-      });
-    } else {
+
+    /**
+     * Using unstable_batchedUpdates because this store update happens async and trigers a rerender
+     * more info:
+     * https://github.com/facebook/react/blob/v18.2.0/packages/use-sync-external-store/src/useSyncExternalStoreShimClient.js#L113
+     * https://react-redux.js.org/api/batch
+     */
+    unstable_batchedUpdates(function () {
       handleResolvedLinkSuccess(resourceUrl, response, isReloading, isMetadataRequest);
-    }
+    });
   }, [handleResolvedLinkError, handleResolvedLinkSuccess, hasAuthFlowSupported]);
   return useCallback( /*#__PURE__*/function () {
     var _ref2 = _asyncToGenerator( /*#__PURE__*/_regeneratorRuntime.mark(function _callee(url) {

package/dist/esm/version.json

@@ -1,5 +1,5 @@
 {
 	"name": "@atlaskit/smart-card",
-	"version": "26.8.1",
+	"version": "26.9.0",
 	"sideEffects": false
 }

package/dist/esm/view/CardWithUrl/component.js

@@ -1,7 +1,6 @@
 import React, { useEffect, useCallback, useMemo } from 'react';
 import { useAnalyticsEvents } from '@atlaskit/analytics-next';
 import { useFeatureFlag } from '@atlaskit/link-provider';
-import { getBooleanFF } from '@atlaskit/platform-feature-flags';
 import { isSpecialEvent } from '../../utils';
 import * as measure from '../../utils/performance';
 import { getDefinitionId, getServices, isFinalState, getClickUrl, getResourceType, getExtensionKey, getSubproduct, getProduct } from '../../state/helpers';
@@ -263,13 +262,10 @@ function Component(_ref) {
   }
 }
 export var CardWithUrlContent = function CardWithUrlContent(props) {
-  if (getBooleanFF('platform.linking-platform.smart-card.enable-analytics-context')) {
-    var display = isFlexibleUiCard(props.children) ? CardDisplay.Flexible : props.appearance;
-    return /*#__PURE__*/React.createElement(SmartLinkAnalyticsContext, {
-      url: props.url,
-      id: props.id,
-      display: display
-    }, /*#__PURE__*/React.createElement(Component, props));
-  }
-  return /*#__PURE__*/React.createElement(Component, props);
+  var display = isFlexibleUiCard(props.children) ? CardDisplay.Flexible : props.appearance;
+  return /*#__PURE__*/React.createElement(SmartLinkAnalyticsContext, {
+    url: props.url,
+    id: props.id,
+    display: display
+  }, /*#__PURE__*/React.createElement(Component, props));
 };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@atlaskit/smart-card",
-  "version": "26.8.1",
+  "version": "26.9.0",
   "description": "Smart card component",
   "publishConfig": {
     "registry": "https://registry.npmjs.org/"
@@ -138,9 +138,6 @@
     ".": "./src/index.ts"
   },
   "platform-feature-flags": {
-    "platform.linking-platform.smart-card.enable-analytics-context": {
-      "type": "boolean"
-    },
     "platform.linking-platform.smart-card.remove-dispatch-analytics-as-prop": {
       "type": "boolean"
     },