@atlaskit/smart-card 26.8.0 → 26.9.0

package/CHANGELOG.md

@@ -1,5 +1,17 @@
 # @atlaskit/smart-card
 
+## 26.9.0
+
+### Minor Changes
+
+- [`7811ab546b9`](https://bitbucket.org/atlassian/atlassian-frontend/commits/7811ab546b9) - Cleans up FF platform.linking-platform.smart-card.enable-analytics-context introduced in 26.2.2 — resolved attributes now provided to all events fired within Smart Card by default.
+
+## 26.8.1
+
+### Patch Changes
+
+- [`0b148ef0a04`](https://bitbucket.org/atlassian/atlassian-frontend/commits/0b148ef0a04) - [ux] Updated fade in delay for hover card to be 500ms
+
 ## 26.8.0
 
 ### Minor Changes

package/dist/cjs/state/hooks/use-resolve/index.js

@@ -12,7 +12,6 @@ var _reactDom = require("react-dom");
 var _analytics = require("../../analytics");
 var _helpers = require("../../helpers");
 var _linkingCommon = require("@atlaskit/linking-common");
-var _platformFeatureFlags = require("@atlaskit/platform-feature-flags");
 var _constants = require("../../actions/constants");
 var _jsonld = require("../../../utils/jsonld");
 var _constants2 = require("../../../constants");
@@ -120,19 +119,16 @@ var useResolve = function useResolve() {
       handleResolvedLinkError(resourceUrl, new _linkingCommon.APIError('error', hostname, _constants.ERROR_MESSAGE_METADATA), response, isMetadataRequest);
       return;
     }
-    if ((0, _platformFeatureFlags.getBooleanFF)('platform.linking-platform.smart-card.enable-analytics-context')) {
-      /**
-       * Using unstable_batchedUpdates because this store update happens async and trigers a rerender
-       * more info:
-       * https://github.com/facebook/react/blob/v18.2.0/packages/use-sync-external-store/src/useSyncExternalStoreShimClient.js#L113
-       * https://react-redux.js.org/api/batch
-       */
-      (0, _reactDom.unstable_batchedUpdates)(function () {
-        handleResolvedLinkSuccess(resourceUrl, response, isReloading, isMetadataRequest);
-      });
-    } else {
+
+    /**
+     * Using unstable_batchedUpdates because this store update happens async and trigers a rerender
+     * more info:
+     * https://github.com/facebook/react/blob/v18.2.0/packages/use-sync-external-store/src/useSyncExternalStoreShimClient.js#L113
+     * https://react-redux.js.org/api/batch
+     */
+    (0, _reactDom.unstable_batchedUpdates)(function () {
       handleResolvedLinkSuccess(resourceUrl, response, isReloading, isMetadataRequest);
-    }
+    });
   }, [handleResolvedLinkError, handleResolvedLinkSuccess, hasAuthFlowSupported]);
   return (0, _react.useCallback)( /*#__PURE__*/function () {
     var _ref2 = (0, _asyncToGenerator2.default)( /*#__PURE__*/_regenerator.default.mark(function _callee(url) {

package/dist/cjs/version.json

@@ -1,5 +1,5 @@
 {
 	"name": "@atlaskit/smart-card",
-	"version": "26.8.0",
+	"version": "26.9.0",
 	"sideEffects": false
 }

package/dist/cjs/view/CardWithUrl/component.js

@@ -9,7 +9,6 @@ exports.CardWithUrlContent = void 0;
 var _react = _interopRequireWildcard(require("react"));
 var _analyticsNext = require("@atlaskit/analytics-next");
 var _linkProvider = require("@atlaskit/link-provider");
-var _platformFeatureFlags = require("@atlaskit/platform-feature-flags");
 var _utils = require("../../utils");
 var measure = _interopRequireWildcard(require("../../utils/performance"));
 var _helpers = require("../../state/helpers");
@@ -273,14 +272,11 @@ function Component(_ref) {
   }
 }
 var CardWithUrlContent = function CardWithUrlContent(props) {
-  if ((0, _platformFeatureFlags.getBooleanFF)('platform.linking-platform.smart-card.enable-analytics-context')) {
-    var display = (0, _flexible.isFlexibleUiCard)(props.children) ? _constants.CardDisplay.Flexible : props.appearance;
-    return /*#__PURE__*/_react.default.createElement(_SmartLinkAnalyticsContext.SmartLinkAnalyticsContext, {
-      url: props.url,
-      id: props.id,
-      display: display
-    }, /*#__PURE__*/_react.default.createElement(Component, props));
-  }
-  return /*#__PURE__*/_react.default.createElement(Component, props);
+  var display = (0, _flexible.isFlexibleUiCard)(props.children) ? _constants.CardDisplay.Flexible : props.appearance;
+  return /*#__PURE__*/_react.default.createElement(_SmartLinkAnalyticsContext.SmartLinkAnalyticsContext, {
+    url: props.url,
+    id: props.id,
+    display: display
+  }, /*#__PURE__*/_react.default.createElement(Component, props));
 };
 exports.CardWithUrlContent = CardWithUrlContent;

package/dist/cjs/view/HoverCard/components/HoverCardComponent.js

@@ -25,6 +25,9 @@ function _interopRequireWildcard(obj, nodeInterop) { if (!nodeInterop && obj &&
 /** @jsx jsx */
 
 var HOVER_CARD_SOURCE = 'smartLinkPreviewHoverCard';
+var FADE_IN_DELAY = 500;
+var FADE_OUT_DELAY = 300;
+var RESOLVE_DELAY = 100;
 var HoverCardComponent = function HoverCardComponent(_ref) {
   var children = _ref.children,
     url = _ref.url,
@@ -39,8 +42,6 @@ var HoverCardComponent = function HoverCardComponent(_ref) {
     hidePreviewButton = _ref$hidePreviewButto === void 0 ? false : _ref$hidePreviewButto,
     _ref$showServerAction = _ref.showServerActions,
     showServerActions = _ref$showServerAction === void 0 ? false : _ref$showServerAction;
-  var delay = 300;
-  var resolveDelay = 100;
   var _React$useState = _react2.default.useState(false),
     _React$useState2 = (0, _slicedToArray2.default)(_React$useState, 2),
     isOpen = _React$useState2[0],
@@ -83,7 +84,7 @@ var HoverCardComponent = function HoverCardComponent(_ref) {
     }
     fadeOutTimeoutId.current = setTimeout(function () {
       return hideCard();
-    }, delay);
+    }, FADE_OUT_DELAY);
   }, [hideCard]);
 
   // clearing out the timeouts in order to avoid memory leaks
@@ -116,7 +117,7 @@ var HoverCardComponent = function HoverCardComponent(_ref) {
     if (!resolveTimeOutId.current && isLinkUnresolved) {
       resolveTimeOutId.current = setTimeout(function () {
         loadMetadata();
-      }, resolveDelay);
+      }, RESOLVE_DELAY);
     }
   }, [linkState, loadMetadata]);
   var initShowCard = (0, _react2.useCallback)(function (event) {
@@ -141,7 +142,7 @@ var HoverCardComponent = function HoverCardComponent(_ref) {
           popupOffset.current = [mousePos.current.x - left, mousePos.current.y - bottom + _styled.CARD_GAP_PX];
         }
         setIsOpen(true);
-      }, delay);
+      }, FADE_IN_DELAY);
     }
   }, [initResolve, isOpen, setMousePosition]);
   var linkActions = (0, _useSmartLinkActions.useSmartLinkActions)({

package/dist/es2019/state/hooks/use-resolve/index.js

@@ -3,7 +3,6 @@ import { unstable_batchedUpdates } from 'react-dom';
 import { addMetadataToExperience } from '../../analytics';
 import { getStatus } from '../../helpers';
 import { ACTION_ERROR, ACTION_ERROR_FALLBACK, ACTION_RELOADING, ACTION_RESOLVED, ACTION_UPDATE_METADATA_STATUS, APIError, cardAction } from '@atlaskit/linking-common';
-import { getBooleanFF } from '@atlaskit/platform-feature-flags';
 import { ERROR_MESSAGE_FATAL, ERROR_MESSAGE_METADATA, ERROR_MESSAGE_OAUTH } from '../../actions/constants';
 import { getUnauthorizedJsonLd } from '../../../utils/jsonld';
 import { SmartLinkStatus } from '../../../constants';
@@ -113,19 +112,16 @@ const useResolve = () => {
       handleResolvedLinkError(resourceUrl, new APIError('error', hostname, ERROR_MESSAGE_METADATA), response, isMetadataRequest);
       return;
     }
-    if (getBooleanFF('platform.linking-platform.smart-card.enable-analytics-context')) {
-      /**
-       * Using unstable_batchedUpdates because this store update happens async and trigers a rerender
-       * more info:
-       * https://github.com/facebook/react/blob/v18.2.0/packages/use-sync-external-store/src/useSyncExternalStoreShimClient.js#L113
-       * https://react-redux.js.org/api/batch
-       */
-      unstable_batchedUpdates(() => {
-        handleResolvedLinkSuccess(resourceUrl, response, isReloading, isMetadataRequest);
-      });
-    } else {
+
+    /**
+     * Using unstable_batchedUpdates because this store update happens async and trigers a rerender
+     * more info:
+     * https://github.com/facebook/react/blob/v18.2.0/packages/use-sync-external-store/src/useSyncExternalStoreShimClient.js#L113
+     * https://react-redux.js.org/api/batch
+     */
+    unstable_batchedUpdates(() => {
       handleResolvedLinkSuccess(resourceUrl, response, isReloading, isMetadataRequest);
-    }
+    });
   }, [handleResolvedLinkError, handleResolvedLinkSuccess, hasAuthFlowSupported]);
   return useCallback(async (url, isReloading = false, isMetadataRequest = false, id = '') => {
     const {

package/dist/es2019/version.json

@@ -1,5 +1,5 @@
 {
 	"name": "@atlaskit/smart-card",
-	"version": "26.8.0",
+	"version": "26.9.0",
 	"sideEffects": false
 }

package/dist/es2019/view/CardWithUrl/component.js

@@ -1,7 +1,6 @@
 import React, { useEffect, useCallback, useMemo } from 'react';
 import { useAnalyticsEvents } from '@atlaskit/analytics-next';
 import { useFeatureFlag } from '@atlaskit/link-provider';
-import { getBooleanFF } from '@atlaskit/platform-feature-flags';
 import { isSpecialEvent } from '../../utils';
 import * as measure from '../../utils/performance';
 import { getDefinitionId, getServices, isFinalState, getClickUrl, getResourceType, getExtensionKey, getSubproduct, getProduct } from '../../state/helpers';
@@ -260,13 +259,10 @@ function Component({
   }
 }
 export const CardWithUrlContent = props => {
-  if (getBooleanFF('platform.linking-platform.smart-card.enable-analytics-context')) {
-    const display = isFlexibleUiCard(props.children) ? CardDisplay.Flexible : props.appearance;
-    return /*#__PURE__*/React.createElement(SmartLinkAnalyticsContext, {
-      url: props.url,
-      id: props.id,
-      display: display
-    }, /*#__PURE__*/React.createElement(Component, props));
-  }
-  return /*#__PURE__*/React.createElement(Component, props);
+  const display = isFlexibleUiCard(props.children) ? CardDisplay.Flexible : props.appearance;
+  return /*#__PURE__*/React.createElement(SmartLinkAnalyticsContext, {
+    url: props.url,
+    id: props.id,
+    display: display
+  }, /*#__PURE__*/React.createElement(Component, props));
 };

package/dist/es2019/view/HoverCard/components/HoverCardComponent.js

@@ -13,6 +13,9 @@ import { SmartLinkAnalyticsContext } from '../../../utils/analytics/SmartLinkAna
 import { useSmartCardActions } from '../../../state/actions';
 import { useSmartLinkAnalytics } from '../../../state/analytics';
 const HOVER_CARD_SOURCE = 'smartLinkPreviewHoverCard';
+const FADE_IN_DELAY = 500;
+const FADE_OUT_DELAY = 300;
+const RESOLVE_DELAY = 100;
 export const HoverCardComponent = ({
   children,
   url,
@@ -23,8 +26,6 @@ export const HoverCardComponent = ({
   hidePreviewButton = false,
   showServerActions = false
 }) => {
-  const delay = 300;
-  const resolveDelay = 100;
   const [isOpen, setIsOpen] = React.useState(false);
   const fadeOutTimeoutId = useRef();
   const fadeInTimeoutId = useRef();
@@ -63,7 +64,7 @@ export const HoverCardComponent = ({
       // we want to clear out the reference to signify that there's no in-progress resolve event
       resolveTimeOutId.current = undefined;
     }
-    fadeOutTimeoutId.current = setTimeout(() => hideCard(), delay);
+    fadeOutTimeoutId.current = setTimeout(() => hideCard(), FADE_OUT_DELAY);
   }, [hideCard]);
 
   // clearing out the timeouts in order to avoid memory leaks
@@ -96,7 +97,7 @@ export const HoverCardComponent = ({
     if (!resolveTimeOutId.current && isLinkUnresolved) {
       resolveTimeOutId.current = setTimeout(() => {
         loadMetadata();
-      }, resolveDelay);
+      }, RESOLVE_DELAY);
     }
   }, [linkState, loadMetadata]);
   const initShowCard = useCallback(event => {
@@ -122,7 +123,7 @@ export const HoverCardComponent = ({
           popupOffset.current = [mousePos.current.x - left, mousePos.current.y - bottom + CARD_GAP_PX];
         }
         setIsOpen(true);
-      }, delay);
+      }, FADE_IN_DELAY);
     }
   }, [initResolve, isOpen, setMousePosition]);
   const linkActions = useSmartLinkActions({

package/dist/esm/state/hooks/use-resolve/index.js

@@ -5,7 +5,6 @@ import { unstable_batchedUpdates } from 'react-dom';
 import { addMetadataToExperience } from '../../analytics';
 import { getStatus } from '../../helpers';
 import { ACTION_ERROR, ACTION_ERROR_FALLBACK, ACTION_RELOADING, ACTION_RESOLVED, ACTION_UPDATE_METADATA_STATUS, APIError, cardAction } from '@atlaskit/linking-common';
-import { getBooleanFF } from '@atlaskit/platform-feature-flags';
 import { ERROR_MESSAGE_FATAL, ERROR_MESSAGE_METADATA, ERROR_MESSAGE_OAUTH } from '../../actions/constants';
 import { getUnauthorizedJsonLd } from '../../../utils/jsonld';
 import { SmartLinkStatus } from '../../../constants';
@@ -113,19 +112,16 @@ var useResolve = function useResolve() {
       handleResolvedLinkError(resourceUrl, new APIError('error', hostname, ERROR_MESSAGE_METADATA), response, isMetadataRequest);
       return;
     }
-    if (getBooleanFF('platform.linking-platform.smart-card.enable-analytics-context')) {
-      /**
-       * Using unstable_batchedUpdates because this store update happens async and trigers a rerender
-       * more info:
-       * https://github.com/facebook/react/blob/v18.2.0/packages/use-sync-external-store/src/useSyncExternalStoreShimClient.js#L113
-       * https://react-redux.js.org/api/batch
-       */
-      unstable_batchedUpdates(function () {
-        handleResolvedLinkSuccess(resourceUrl, response, isReloading, isMetadataRequest);
-      });
-    } else {
+
+    /**
+     * Using unstable_batchedUpdates because this store update happens async and trigers a rerender
+     * more info:
+     * https://github.com/facebook/react/blob/v18.2.0/packages/use-sync-external-store/src/useSyncExternalStoreShimClient.js#L113
+     * https://react-redux.js.org/api/batch
+     */
+    unstable_batchedUpdates(function () {
       handleResolvedLinkSuccess(resourceUrl, response, isReloading, isMetadataRequest);
-    }
+    });
   }, [handleResolvedLinkError, handleResolvedLinkSuccess, hasAuthFlowSupported]);
   return useCallback( /*#__PURE__*/function () {
     var _ref2 = _asyncToGenerator( /*#__PURE__*/_regeneratorRuntime.mark(function _callee(url) {

package/dist/esm/version.json

@@ -1,5 +1,5 @@
 {
 	"name": "@atlaskit/smart-card",
-	"version": "26.8.0",
+	"version": "26.9.0",
 	"sideEffects": false
 }

package/dist/esm/view/CardWithUrl/component.js

@@ -1,7 +1,6 @@
 import React, { useEffect, useCallback, useMemo } from 'react';
 import { useAnalyticsEvents } from '@atlaskit/analytics-next';
 import { useFeatureFlag } from '@atlaskit/link-provider';
-import { getBooleanFF } from '@atlaskit/platform-feature-flags';
 import { isSpecialEvent } from '../../utils';
 import * as measure from '../../utils/performance';
 import { getDefinitionId, getServices, isFinalState, getClickUrl, getResourceType, getExtensionKey, getSubproduct, getProduct } from '../../state/helpers';
@@ -263,13 +262,10 @@ function Component(_ref) {
   }
 }
 export var CardWithUrlContent = function CardWithUrlContent(props) {
-  if (getBooleanFF('platform.linking-platform.smart-card.enable-analytics-context')) {
-    var display = isFlexibleUiCard(props.children) ? CardDisplay.Flexible : props.appearance;
-    return /*#__PURE__*/React.createElement(SmartLinkAnalyticsContext, {
-      url: props.url,
-      id: props.id,
-      display: display
-    }, /*#__PURE__*/React.createElement(Component, props));
-  }
-  return /*#__PURE__*/React.createElement(Component, props);
+  var display = isFlexibleUiCard(props.children) ? CardDisplay.Flexible : props.appearance;
+  return /*#__PURE__*/React.createElement(SmartLinkAnalyticsContext, {
+    url: props.url,
+    id: props.id,
+    display: display
+  }, /*#__PURE__*/React.createElement(Component, props));
 };

package/dist/esm/view/HoverCard/components/HoverCardComponent.js

@@ -14,6 +14,9 @@ import { SmartLinkAnalyticsContext } from '../../../utils/analytics/SmartLinkAna
 import { useSmartCardActions } from '../../../state/actions';
 import { useSmartLinkAnalytics } from '../../../state/analytics';
 var HOVER_CARD_SOURCE = 'smartLinkPreviewHoverCard';
+var FADE_IN_DELAY = 500;
+var FADE_OUT_DELAY = 300;
+var RESOLVE_DELAY = 100;
 export var HoverCardComponent = function HoverCardComponent(_ref) {
   var children = _ref.children,
     url = _ref.url,
@@ -28,8 +31,6 @@ export var HoverCardComponent = function HoverCardComponent(_ref) {
     hidePreviewButton = _ref$hidePreviewButto === void 0 ? false : _ref$hidePreviewButto,
     _ref$showServerAction = _ref.showServerActions,
     showServerActions = _ref$showServerAction === void 0 ? false : _ref$showServerAction;
-  var delay = 300;
-  var resolveDelay = 100;
   var _React$useState = React.useState(false),
     _React$useState2 = _slicedToArray(_React$useState, 2),
     isOpen = _React$useState2[0],
@@ -72,7 +73,7 @@ export var HoverCardComponent = function HoverCardComponent(_ref) {
     }
     fadeOutTimeoutId.current = setTimeout(function () {
       return hideCard();
-    }, delay);
+    }, FADE_OUT_DELAY);
   }, [hideCard]);
 
   // clearing out the timeouts in order to avoid memory leaks
@@ -105,7 +106,7 @@ export var HoverCardComponent = function HoverCardComponent(_ref) {
     if (!resolveTimeOutId.current && isLinkUnresolved) {
       resolveTimeOutId.current = setTimeout(function () {
         loadMetadata();
-      }, resolveDelay);
+      }, RESOLVE_DELAY);
     }
   }, [linkState, loadMetadata]);
   var initShowCard = useCallback(function (event) {
@@ -130,7 +131,7 @@ export var HoverCardComponent = function HoverCardComponent(_ref) {
           popupOffset.current = [mousePos.current.x - left, mousePos.current.y - bottom + CARD_GAP_PX];
         }
         setIsOpen(true);
-      }, delay);
+      }, FADE_IN_DELAY);
     }
   }, [initResolve, isOpen, setMousePosition]);
   var linkActions = useSmartLinkActions({

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@atlaskit/smart-card",
-  "version": "26.8.0",
+  "version": "26.9.0",
   "description": "Smart card component",
   "publishConfig": {
     "registry": "https://registry.npmjs.org/"
@@ -45,7 +45,7 @@
     "@atlaskit/link-analytics": "^8.1.0",
     "@atlaskit/link-client-extension": "^1.5.0",
     "@atlaskit/linking-common": "^3.1.0",
-    "@atlaskit/linking-types": "^8.0.0",
+    "@atlaskit/linking-types": "^8.1.0",
     "@atlaskit/logo": "^13.14.0",
     "@atlaskit/lozenge": "^11.4.0",
     "@atlaskit/media-common": "^7.1.0",
@@ -55,7 +55,7 @@
     "@atlaskit/popup": "^1.8.0",
     "@atlaskit/spinner": "^15.5.0",
     "@atlaskit/theme": "^12.5.0",
-    "@atlaskit/tokens": "^1.10.0",
+    "@atlaskit/tokens": "^1.11.0",
     "@atlaskit/tooltip": "^17.8.0",
     "@atlaskit/ufo": "^0.2.0",
     "@babel/runtime": "^7.0.0",
@@ -138,9 +138,6 @@
     ".": "./src/index.ts"
   },
   "platform-feature-flags": {
-    "platform.linking-platform.smart-card.enable-analytics-context": {
-      "type": "boolean"
-    },
     "platform.linking-platform.smart-card.remove-dispatch-analytics-as-prop": {
       "type": "boolean"
     },