@atlaskit/smart-card 26.42.1 → 26.42.3

package/CHANGELOG.md

@@ -1,5 +1,18 @@
 # @atlaskit/smart-card
 
+## 26.42.3
+
+### Patch Changes
+
+- [#43009](https://bitbucket.org/atlassian/atlassian-frontend/pull-requests/43009) [`df50e1df692`](https://bitbucket.org/atlassian/atlassian-frontend/commits/df50e1df692) - Remove should-call-onclick-in-warning-modal-only-when-safe FF
+- Updated dependencies
+
+## 26.42.2
+
+### Patch Changes
+
+- [#43024](https://bitbucket.org/atlassian/atlassian-frontend/pull-requests/43024) [`4e36cb30932`](https://bitbucket.org/atlassian/atlassian-frontend/commits/4e36cb30932) - Update embed card and embed modal internal structure and unskip vr tests
+
 ## 26.42.1
 
 ### Patch Changes

package/dist/cjs/utils/analytics/analytics.js

@@ -22,7 +22,7 @@ var ANALYTICS_CHANNEL = exports.ANALYTICS_CHANNEL = 'media';
 var context = exports.context = {
   componentName: 'smart-cards',
   packageName: "@atlaskit/smart-card",
-  packageVersion: "26.42.1"
+  packageVersion: "26.42.3"
 };
 var TrackQuickActionType = exports.TrackQuickActionType = /*#__PURE__*/function (TrackQuickActionType) {
   TrackQuickActionType["StatusUpdate"] = "StatusUpdate";

package/dist/cjs/view/EmbedCard/components/Frame.js

@@ -9,8 +9,10 @@ exports.Frame = void 0;
 var _slicedToArray2 = _interopRequireDefault(require("@babel/runtime/helpers/slicedToArray"));
 var _react = require("@emotion/react");
 var _react2 = _interopRequireWildcard(require("react"));
+var _reactMagneticDi = require("react-magnetic-di");
 var _utils = require("../../../utils");
 var _IframeDwellTracker = require("./IframeDwellTracker");
+var _IFrame = require("./IFrame");
 function _getRequireWildcardCache(nodeInterop) { if (typeof WeakMap !== "function") return null; var cacheBabelInterop = new WeakMap(); var cacheNodeInterop = new WeakMap(); return (_getRequireWildcardCache = function _getRequireWildcardCache(nodeInterop) { return nodeInterop ? cacheNodeInterop : cacheBabelInterop; })(nodeInterop); }
 function _interopRequireWildcard(obj, nodeInterop) { if (!nodeInterop && obj && obj.__esModule) { return obj; } if (obj === null || _typeof(obj) !== "object" && typeof obj !== "function") { return { default: obj }; } var cache = _getRequireWildcardCache(nodeInterop); if (cache && cache.has(obj)) { return cache.get(obj); } var newObj = {}; var hasPropertyDescriptor = Object.defineProperty && Object.getOwnPropertyDescriptor; for (var key in obj) { if (key !== "default" && Object.prototype.hasOwnProperty.call(obj, key)) { var desc = hasPropertyDescriptor ? Object.getOwnPropertyDescriptor(obj, key) : null; if (desc && (desc.get || desc.set)) { Object.defineProperty(newObj, key, desc); } else { newObj[key] = obj[key]; } } } newObj.default = obj; if (cache) { cache.set(obj, newObj); } return newObj; }
 /** @jsx jsx */
@@ -102,8 +104,8 @@ var Frame = exports.Frame = /*#__PURE__*/_react2.default.forwardRef(function (_r
     isWindowFocused: isWindowFocused,
     iframePercentVisible: percentVisible,
     onIframeDwell: onIframeDwell
-  }), (0, _react.jsx)("iframe", {
-    ref: mergedRef,
+  }), (0, _react.jsx)(_IFrame.IFrame, {
+    childRef: mergedRef,
     src: url,
     "data-testid": "".concat(testId, "-frame"),
     "data-iframe-loaded": isIframeLoaded,

package/dist/cjs/view/EmbedCard/components/IFrame.js

@@ -0,0 +1,21 @@
+"use strict";
+
+var _interopRequireDefault = require("@babel/runtime/helpers/interopRequireDefault");
+Object.defineProperty(exports, "__esModule", {
+  value: true
+});
+exports.IFrame = void 0;
+var _extends2 = _interopRequireDefault(require("@babel/runtime/helpers/extends"));
+var _objectWithoutProperties2 = _interopRequireDefault(require("@babel/runtime/helpers/objectWithoutProperties"));
+var _react = _interopRequireDefault(require("react"));
+var _excluded = ["childRef"];
+/**
+ * Iframe element isolated for DI purposes
+ */
+var IFrame = exports.IFrame = function IFrame(_ref) {
+  var childRef = _ref.childRef,
+    props = (0, _objectWithoutProperties2.default)(_ref, _excluded);
+  return /*#__PURE__*/_react.default.createElement("iframe", (0, _extends2.default)({}, props, {
+    ref: childRef
+  }));
+};

package/dist/cjs/view/EmbedModal/components/embed-content/index.js

@@ -6,8 +6,10 @@ Object.defineProperty(exports, "__esModule", {
 });
 exports.default = void 0;
 var _taggedTemplateLiteral2 = _interopRequireDefault(require("@babel/runtime/helpers/taggedTemplateLiteral"));
+var _reactMagneticDi = require("react-magnetic-di");
 var _react = require("@emotion/react");
 var _utils = require("../../../../utils");
+var _IFrame = require("../../../EmbedCard/components/IFrame");
 var _templateObject;
 /** @jsx jsx */
 var iframeCss = (0, _react.css)(_templateObject || (_templateObject = (0, _taggedTemplateLiteral2.default)(["\n  width: 100%;\n  height: calc(100vh - 208px);\n"])));
@@ -25,6 +27,6 @@ var EmbedContent = function EmbedContent(_ref) {
     src: src,
     'data-testid': "".concat(testId, "-embed")
   };
-  return (0, _react.jsx)("iframe", props);
+  return (0, _react.jsx)(_IFrame.IFrame, props);
 };
 var _default = exports.default = EmbedContent;

package/dist/cjs/view/LinkUrl/index.js

@@ -13,12 +13,11 @@ var _click = require("../../utils/analytics/click");
 var _LinkAnalyticsContext = require("../../utils/analytics/LinkAnalyticsContext");
 var _useLinkWarningModal2 = require("./LinkWarningModal/hooks/use-link-warning-modal");
 var _LinkWarningModal = _interopRequireDefault(require("./LinkWarningModal"));
-var _platformFeatureFlags = require("@atlaskit/platform-feature-flags");
 var _excluded = ["href", "children", "checkSafety", "onClick", "testId"],
   _excluded2 = ["isLinkSafe", "showSafetyWarningModal"];
 var PACKAGE_DATA = {
   packageName: "@atlaskit/smart-card",
-  packageVersion: "26.42.1",
+  packageVersion: "26.42.3",
   componentName: 'linkUrl'
 };
 var Link = (0, _click.withLinkClickedEvent)('a');
@@ -42,24 +41,16 @@ var LinkUrl = function LinkUrl(_ref) {
     "data-testid": testId,
     href: href,
     onClick: function onClick(e) {
-      if ((0, _platformFeatureFlags.getBooleanFF)('platform.linking-platform.smart-card.should-call-onclick-in-warning-modal-only-when-safe')) {
-        if (!checkSafety) {
-          _onClick && _onClick(e);
-          return;
-        }
+      if (!checkSafety) {
+        _onClick && _onClick(e);
+        return;
+      }
 
-        // Only call the onClick if the link is safe
-        if (isLinkSafe(e, href)) {
-          _onClick && _onClick(e);
-        } else {
-          showSafetyWarningModal(e, href);
-        }
-      } else {
-        if (checkSafety && !isLinkSafe(e, href)) {
-          showSafetyWarningModal(e, href);
-        }
-        // Call the onClick regardless of the link safety
+      // Only call the onClick if the link is safe
+      if (isLinkSafe(e, href)) {
         _onClick && _onClick(e);
+      } else {
+        showSafetyWarningModal(e, href);
       }
     }
   }, props), children)), checkSafety && /*#__PURE__*/_react.default.createElement(_LinkWarningModal.default, linkWarningModalProps));

package/dist/es2019/utils/analytics/analytics.js

@@ -4,7 +4,7 @@ export const ANALYTICS_CHANNEL = 'media';
 export const context = {
   componentName: 'smart-cards',
   packageName: "@atlaskit/smart-card",
-  packageVersion: "26.42.1"
+  packageVersion: "26.42.3"
 };
 export let TrackQuickActionType = /*#__PURE__*/function (TrackQuickActionType) {
   TrackQuickActionType["StatusUpdate"] = "StatusUpdate";

package/dist/es2019/view/EmbedCard/components/Frame.js

@@ -1,8 +1,10 @@
 /** @jsx jsx */
 import { jsx } from '@emotion/react';
 import React, { useEffect, useState, useRef } from 'react';
+import { di } from 'react-magnetic-di';
 import { getIframeSandboxAttribute } from '../../../utils';
 import { IframeDwellTracker } from './IframeDwellTracker';
+import { IFrame } from './IFrame';
 function mergeRefs(refs) {
   return value => {
     refs.forEach(ref => {
@@ -76,8 +78,8 @@ export const Frame = /*#__PURE__*/React.forwardRef(({
     isWindowFocused: isWindowFocused,
     iframePercentVisible: percentVisible,
     onIframeDwell: onIframeDwell
-  }), jsx("iframe", {
-    ref: mergedRef,
+  }), jsx(IFrame, {
+    childRef: mergedRef,
     src: url,
     "data-testid": `${testId}-frame`,
     "data-iframe-loaded": isIframeLoaded,

package/dist/es2019/view/EmbedCard/components/IFrame.js

@@ -0,0 +1,13 @@
+import _extends from "@babel/runtime/helpers/extends";
+import React from 'react';
+/**
+ * Iframe element isolated for DI purposes
+ */
+export const IFrame = ({
+  childRef,
+  ...props
+}) => {
+  return /*#__PURE__*/React.createElement("iframe", _extends({}, props, {
+    ref: childRef
+  }));
+};

package/dist/es2019/view/EmbedModal/components/embed-content/index.js

@@ -1,7 +1,9 @@
 /** @jsx jsx */
 
+import { di } from 'react-magnetic-di';
 import { css, jsx } from '@emotion/react';
 import { getIframeSandboxAttribute } from '../../../../utils';
+import { IFrame } from '../../../EmbedCard/components/IFrame';
 const iframeCss = css`
   width: 100%;
   height: calc(100vh - 208px);
@@ -21,6 +23,6 @@ const EmbedContent = ({
     src,
     'data-testid': `${testId}-embed`
   };
-  return jsx("iframe", props);
+  return jsx(IFrame, props);
 };
 export default EmbedContent;

package/dist/es2019/view/LinkUrl/index.js

@@ -5,10 +5,9 @@ import { withLinkClickedEvent } from '../../utils/analytics/click';
 import { LinkAnalyticsContext } from '../../utils/analytics/LinkAnalyticsContext';
 import { useLinkWarningModal } from './LinkWarningModal/hooks/use-link-warning-modal';
 import LinkWarningModal from './LinkWarningModal';
-import { getBooleanFF } from '@atlaskit/platform-feature-flags';
 const PACKAGE_DATA = {
   packageName: "@atlaskit/smart-card",
-  packageVersion: "26.42.1",
+  packageVersion: "26.42.3",
   componentName: 'linkUrl'
 };
 const Link = withLinkClickedEvent('a');
@@ -32,24 +31,16 @@ const LinkUrl = ({
     "data-testid": testId,
     href: href,
     onClick: e => {
-      if (getBooleanFF('platform.linking-platform.smart-card.should-call-onclick-in-warning-modal-only-when-safe')) {
-        if (!checkSafety) {
-          onClick && onClick(e);
-          return;
-        }
+      if (!checkSafety) {
+        onClick && onClick(e);
+        return;
+      }
 
-        // Only call the onClick if the link is safe
-        if (isLinkSafe(e, href)) {
-          onClick && onClick(e);
-        } else {
-          showSafetyWarningModal(e, href);
-        }
-      } else {
-        if (checkSafety && !isLinkSafe(e, href)) {
-          showSafetyWarningModal(e, href);
-        }
-        // Call the onClick regardless of the link safety
+      // Only call the onClick if the link is safe
+      if (isLinkSafe(e, href)) {
         onClick && onClick(e);
+      } else {
+        showSafetyWarningModal(e, href);
       }
     }
   }, props), children)), checkSafety && /*#__PURE__*/React.createElement(LinkWarningModal, linkWarningModalProps));

package/dist/esm/utils/analytics/analytics.js

@@ -15,7 +15,7 @@ export var ANALYTICS_CHANNEL = 'media';
 export var context = {
   componentName: 'smart-cards',
   packageName: "@atlaskit/smart-card",
-  packageVersion: "26.42.1"
+  packageVersion: "26.42.3"
 };
 export var TrackQuickActionType = /*#__PURE__*/function (TrackQuickActionType) {
   TrackQuickActionType["StatusUpdate"] = "StatusUpdate";

package/dist/esm/view/EmbedCard/components/Frame.js

@@ -2,8 +2,10 @@ import _slicedToArray from "@babel/runtime/helpers/slicedToArray";
 /** @jsx jsx */
 import { jsx } from '@emotion/react';
 import React, { useEffect, useState, useRef } from 'react';
+import { di } from 'react-magnetic-di';
 import { getIframeSandboxAttribute } from '../../../utils';
 import { IframeDwellTracker } from './IframeDwellTracker';
+import { IFrame } from './IFrame';
 function mergeRefs(refs) {
   return function (value) {
     refs.forEach(function (ref) {
@@ -91,8 +93,8 @@ export var Frame = /*#__PURE__*/React.forwardRef(function (_ref, iframeRef) {
     isWindowFocused: isWindowFocused,
     iframePercentVisible: percentVisible,
     onIframeDwell: onIframeDwell
-  }), jsx("iframe", {
-    ref: mergedRef,
+  }), jsx(IFrame, {
+    childRef: mergedRef,
     src: url,
     "data-testid": "".concat(testId, "-frame"),
     "data-iframe-loaded": isIframeLoaded,

package/dist/esm/view/EmbedCard/components/IFrame.js

@@ -0,0 +1,14 @@
+import _extends from "@babel/runtime/helpers/extends";
+import _objectWithoutProperties from "@babel/runtime/helpers/objectWithoutProperties";
+var _excluded = ["childRef"];
+import React from 'react';
+/**
+ * Iframe element isolated for DI purposes
+ */
+export var IFrame = function IFrame(_ref) {
+  var childRef = _ref.childRef,
+    props = _objectWithoutProperties(_ref, _excluded);
+  return /*#__PURE__*/React.createElement("iframe", _extends({}, props, {
+    ref: childRef
+  }));
+};

package/dist/esm/view/EmbedModal/components/embed-content/index.js

@@ -2,8 +2,10 @@ import _taggedTemplateLiteral from "@babel/runtime/helpers/taggedTemplateLiteral
 var _templateObject;
 /** @jsx jsx */
 
+import { di } from 'react-magnetic-di';
 import { css, jsx } from '@emotion/react';
 import { getIframeSandboxAttribute } from '../../../../utils';
+import { IFrame } from '../../../EmbedCard/components/IFrame';
 var iframeCss = css(_templateObject || (_templateObject = _taggedTemplateLiteral(["\n  width: 100%;\n  height: calc(100vh - 208px);\n"])));
 var EmbedContent = function EmbedContent(_ref) {
   var isTrusted = _ref.isTrusted,
@@ -19,6 +21,6 @@ var EmbedContent = function EmbedContent(_ref) {
     src: src,
     'data-testid': "".concat(testId, "-embed")
   };
-  return jsx("iframe", props);
+  return jsx(IFrame, props);
 };
 export default EmbedContent;

package/dist/esm/view/LinkUrl/index.js

@@ -8,10 +8,9 @@ import { withLinkClickedEvent } from '../../utils/analytics/click';
 import { LinkAnalyticsContext } from '../../utils/analytics/LinkAnalyticsContext';
 import { useLinkWarningModal } from './LinkWarningModal/hooks/use-link-warning-modal';
 import LinkWarningModal from './LinkWarningModal';
-import { getBooleanFF } from '@atlaskit/platform-feature-flags';
 var PACKAGE_DATA = {
   packageName: "@atlaskit/smart-card",
-  packageVersion: "26.42.1",
+  packageVersion: "26.42.3",
   componentName: 'linkUrl'
 };
 var Link = withLinkClickedEvent('a');
@@ -35,24 +34,16 @@ var LinkUrl = function LinkUrl(_ref) {
     "data-testid": testId,
     href: href,
     onClick: function onClick(e) {
-      if (getBooleanFF('platform.linking-platform.smart-card.should-call-onclick-in-warning-modal-only-when-safe')) {
-        if (!checkSafety) {
-          _onClick && _onClick(e);
-          return;
-        }
+      if (!checkSafety) {
+        _onClick && _onClick(e);
+        return;
+      }
 
-        // Only call the onClick if the link is safe
-        if (isLinkSafe(e, href)) {
-          _onClick && _onClick(e);
-        } else {
-          showSafetyWarningModal(e, href);
-        }
-      } else {
-        if (checkSafety && !isLinkSafe(e, href)) {
-          showSafetyWarningModal(e, href);
-        }
-        // Call the onClick regardless of the link safety
+      // Only call the onClick if the link is safe
+      if (isLinkSafe(e, href)) {
         _onClick && _onClick(e);
+      } else {
+        showSafetyWarningModal(e, href);
       }
     }
   }, props), children)), checkSafety && /*#__PURE__*/React.createElement(LinkWarningModal, linkWarningModalProps));

package/dist/types/view/EmbedCard/components/IFrame.d.ts

@@ -0,0 +1,9 @@
+import React from 'react';
+interface IFrameProps {
+    childRef?: React.Ref<HTMLIFrameElement>;
+}
+/**
+ * Iframe element isolated for DI purposes
+ */
+export declare const IFrame: ({ childRef, ...props }: React.ComponentProps<'iframe'> & IFrameProps) => JSX.Element;
+export {};

package/dist/types-ts4.5/view/EmbedCard/components/IFrame.d.ts

@@ -0,0 +1,9 @@
+import React from 'react';
+interface IFrameProps {
+    childRef?: React.Ref<HTMLIFrameElement>;
+}
+/**
+ * Iframe element isolated for DI purposes
+ */
+export declare const IFrame: ({ childRef, ...props }: React.ComponentProps<'iframe'> & IFrameProps) => JSX.Element;
+export {};

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@atlaskit/smart-card",
-  "version": "26.42.1",
+  "version": "26.42.3",
   "description": "Smart card component",
   "publishConfig": {
     "registry": "https://registry.npmjs.org/"
@@ -27,7 +27,7 @@
     "@atlaskit/avatar": "^21.4.0",
     "@atlaskit/avatar-group": "^9.4.0",
     "@atlaskit/badge": "^15.1.0",
-    "@atlaskit/button": "^16.13.0",
+    "@atlaskit/button": "^16.16.0",
     "@atlaskit/dropdown-menu": "^12.1.0",
     "@atlaskit/frontend-utilities": "^2.7.0",
     "@atlaskit/icon": "^21.12.0",
@@ -38,7 +38,7 @@
     "@atlaskit/link-analytics": "^8.3.0",
     "@atlaskit/link-client-extension": "^1.8.0",
     "@atlaskit/link-extractors": "^1.2.0",
-    "@atlaskit/linking-common": "^4.17.0",
+    "@atlaskit/linking-common": "^4.18.0",
     "@atlaskit/linking-types": "^8.4.0",
     "@atlaskit/logo": "^13.14.0",
     "@atlaskit/lozenge": "^11.4.0",
@@ -46,7 +46,7 @@
     "@atlaskit/outbound-auth-flow-client": "^3.4.0",
     "@atlaskit/platform-feature-flags": "^0.2.1",
     "@atlaskit/popup": "^1.11.0",
-    "@atlaskit/primitives": "^1.9.0",
+    "@atlaskit/primitives": "^1.10.0",
     "@atlaskit/spinner": "^15.6.0",
     "@atlaskit/theme": "^12.6.0",
     "@atlaskit/tokens": "^1.28.0",
@@ -141,9 +141,6 @@
     "platform.linking-platform.smart-card.follow-button": {
       "type": "boolean"
     },
-    "platform.linking-platform.smart-card.should-call-onclick-in-warning-modal-only-when-safe": {
-      "type": "boolean"
-    },
     "platform.linking-platform.smart-card.show-smart-links-refreshed-design": {
       "type": "boolean"
     },