@atlaskit/smart-card 26.10.0 → 26.11.1

package/CHANGELOG.md

@@ -1,5 +1,18 @@
 # @atlaskit/smart-card
 
+## 26.11.1
+
+### Patch Changes
+
+- [`b37a26be833`](https://bitbucket.org/atlassian/atlassian-frontend/commits/b37a26be833) - Prevent LinkUrl from throwing error on validation
+
+## 26.11.0
+
+### Minor Changes
+
+- [`fdfe07831c7`](https://bitbucket.org/atlassian/atlassian-frontend/commits/fdfe07831c7) - - Deprecate standalone hover card `onAuthorize` prop (no implementation)
+  - Hide auth tooltip on unauthenticated inline link with no auth flow (new design, behind feature flag)
+
 ## 26.10.0
 
 ### Minor Changes

package/dist/cjs/version.json

@@ -1,5 +1,5 @@
 {
 	"name": "@atlaskit/smart-card",
-	"version": "26.10.0",
+	"version": "26.11.1",
 	"sideEffects": false
 }

package/dist/cjs/view/FlexibleCard/components/container/index.js

@@ -166,6 +166,8 @@ var Container = function Container(_ref3) {
   var context = (0, _react.useContext)(_flexibleUiContext.FlexibleUiContext);
   var childrenOptions = getChildrenOptions(children, context);
   var canShowHoverPreview = showHoverPreview && status === 'resolved';
+  // `retry` object contains action that can be performed on
+  // unresolved link (unauthorized, forbidden, not found, etc.)
   var canShowAuthTooltip = showAuthTooltip && status === 'unauthorized' && retry !== undefined;
   var container = (0, _react2.jsx)("div", {
     css: getContainerStyles(size, hideBackground, hideElevation, hidePadding, clickableContainer, childrenOptions),

package/dist/cjs/view/InlineCard/UnauthorisedView/index.js

@@ -100,7 +100,6 @@ var InlineCardUnauthorizedView = /*#__PURE__*/function (_React$Component) {
       if (onAuthorise && showAuthTooltip) {
         return /*#__PURE__*/_react.default.createElement(_HoverCard.HoverCard, {
           url: url,
-          onAuthorize: onAuthorise,
           id: this.props.id
         }, inlineCardUnauthenticatedView);
       }

package/dist/cjs/view/LinkUrl/LinkWarningModal/hooks/use-link-warning-modal.js

@@ -10,6 +10,13 @@ var _react = require("react");
 var _url = require("@atlaskit/linking-common/url");
 var _analyticsNext = require("@atlaskit/analytics-next");
 var _analytics = require("../../../../utils/analytics");
+var toUrl = function toUrl(url, base) {
+  try {
+    return new URL(url, base);
+  } catch (_unused) {
+    return undefined;
+  }
+};
 var useLinkWarningModal = function useLinkWarningModal() {
   var _useState = (0, _react.useState)(null),
     _useState2 = (0, _slicedToArray2.default)(_useState, 2),
@@ -57,8 +64,9 @@ var useLinkWarningModal = function useLinkWarningModal() {
       return true;
     }
     var anchorLinkRegex = new RegExp(/^#/im);
-    var isAnchorLink = anchorLinkRegex.test(linkText);
-    if (isAnchorLink) {
+    var isLinkTextAnchorLink = anchorLinkRegex.test(linkText);
+    var isAnchorLink = anchorLinkRegex.test(href);
+    if (isAnchorLink || isLinkTextAnchorLink) {
       return true;
     }
     var relativeLinkRegex = new RegExp(/^\//im);
@@ -66,8 +74,11 @@ var useLinkWarningModal = function useLinkWarningModal() {
     if (isRelativeHrefLink) {
       return true;
     }
-    var hrefUrl = new URL(href, window.location.origin);
-    var linkTextUrl = new URL(normalisedUrlFromLinkText, hrefUrl.origin);
+    var hrefUrl = toUrl(href, window.location.origin);
+    var linkTextUrl = toUrl(normalisedUrlFromLinkText, hrefUrl === null || hrefUrl === void 0 ? void 0 : hrefUrl.origin);
+    if (!hrefUrl || !linkTextUrl) {
+      return true;
+    }
     var httpProtocols = ['http:', 'https:'];
     var areProtocolsEquivalent;
     if (httpProtocols.includes(linkTextUrl.protocol) && httpProtocols.includes(hrefUrl.protocol)) {

package/dist/cjs/view/RedesignedInlineCard/UnauthorisedView/index.js

@@ -81,6 +81,7 @@ var InlineCardUnauthorizedView = /*#__PURE__*/function (_React$Component) {
       var _this$props3 = this.props,
         url = _this$props3.url,
         icon = _this$props3.icon,
+        onAuthorise = _this$props3.onAuthorise,
         onClick = _this$props3.onClick,
         isSelected = _this$props3.isSelected,
         _this$props3$testId = _this$props3.testId,
@@ -98,10 +99,9 @@ var InlineCardUnauthorizedView = /*#__PURE__*/function (_React$Component) {
         onClick: onClick,
         titleColor: "var(--ds-text-subtle, ".concat(_colors.N500, ")")
       }), this.renderActionButton());
-      if (showAuthTooltip) {
+      if (onAuthorise && showAuthTooltip) {
         return /*#__PURE__*/_react.default.createElement(_HoverCard.HoverCard, {
           url: url,
-          onAuthorize: this.props.onAuthorise,
           id: this.props.id
         }, inlineCardUnauthenticatedView);
       }

package/dist/es2019/version.json

@@ -1,5 +1,5 @@
 {
 	"name": "@atlaskit/smart-card",
-	"version": "26.10.0",
+	"version": "26.11.1",
 	"sideEffects": false
 }

package/dist/es2019/view/FlexibleCard/components/container/index.js

@@ -187,6 +187,8 @@ const Container = ({
   const context = useContext(FlexibleUiContext);
   const childrenOptions = getChildrenOptions(children, context);
   const canShowHoverPreview = showHoverPreview && status === 'resolved';
+  // `retry` object contains action that can be performed on
+  // unresolved link (unauthorized, forbidden, not found, etc.)
   const canShowAuthTooltip = showAuthTooltip && status === 'unauthorized' && retry !== undefined;
   const container = jsx("div", {
     css: getContainerStyles(size, hideBackground, hideElevation, hidePadding, clickableContainer, childrenOptions),

package/dist/es2019/view/InlineCard/UnauthorisedView/index.js

@@ -76,7 +76,6 @@ export class InlineCardUnauthorizedView extends React.Component {
     if (onAuthorise && showAuthTooltip) {
       return /*#__PURE__*/React.createElement(HoverCard, {
         url: url,
-        onAuthorize: onAuthorise,
         id: this.props.id
       }, inlineCardUnauthenticatedView);
     }

package/dist/es2019/view/LinkUrl/LinkWarningModal/hooks/use-link-warning-modal.js

@@ -2,6 +2,13 @@ import { useState } from 'react';
 import { normalizeUrl } from '@atlaskit/linking-common/url';
 import { useAnalyticsEvents } from '@atlaskit/analytics-next';
 import { ANALYTICS_CHANNEL } from '../../../../utils/analytics';
+const toUrl = (url, base) => {
+  try {
+    return new URL(url, base);
+  } catch {
+    return undefined;
+  }
+};
 export const useLinkWarningModal = () => {
   const [unsafeLinkText, setUnsafeLinkText] = useState(null);
   const [url, setUrl] = useState(null);
@@ -41,8 +48,9 @@ export const useLinkWarningModal = () => {
       return true;
     }
     const anchorLinkRegex = new RegExp(/^#/im);
-    const isAnchorLink = anchorLinkRegex.test(linkText);
-    if (isAnchorLink) {
+    const isLinkTextAnchorLink = anchorLinkRegex.test(linkText);
+    const isAnchorLink = anchorLinkRegex.test(href);
+    if (isAnchorLink || isLinkTextAnchorLink) {
       return true;
     }
     const relativeLinkRegex = new RegExp(/^\//im);
@@ -50,8 +58,11 @@ export const useLinkWarningModal = () => {
     if (isRelativeHrefLink) {
       return true;
     }
-    const hrefUrl = new URL(href, window.location.origin);
-    const linkTextUrl = new URL(normalisedUrlFromLinkText, hrefUrl.origin);
+    const hrefUrl = toUrl(href, window.location.origin);
+    const linkTextUrl = toUrl(normalisedUrlFromLinkText, hrefUrl === null || hrefUrl === void 0 ? void 0 : hrefUrl.origin);
+    if (!hrefUrl || !linkTextUrl) {
+      return true;
+    }
     const httpProtocols = ['http:', 'https:'];
     let areProtocolsEquivalent;
     if (httpProtocols.includes(linkTextUrl.protocol) && httpProtocols.includes(hrefUrl.protocol)) {

package/dist/es2019/view/RedesignedInlineCard/UnauthorisedView/index.js

@@ -58,6 +58,7 @@ export class InlineCardUnauthorizedView extends React.Component {
     const {
       url,
       icon,
+      onAuthorise,
       onClick,
       isSelected,
       testId = 'inline-card-unauthorized-view',
@@ -74,10 +75,9 @@ export class InlineCardUnauthorizedView extends React.Component {
       onClick: onClick,
       titleColor: `var(--ds-text-subtle, ${N500})`
     }), this.renderActionButton());
-    if (showAuthTooltip) {
+    if (onAuthorise && showAuthTooltip) {
       return /*#__PURE__*/React.createElement(HoverCard, {
         url: url,
-        onAuthorize: this.props.onAuthorise,
         id: this.props.id
       }, inlineCardUnauthenticatedView);
     }

package/dist/esm/version.json

@@ -1,5 +1,5 @@
 {
 	"name": "@atlaskit/smart-card",
-	"version": "26.10.0",
+	"version": "26.11.1",
 	"sideEffects": false
 }

package/dist/esm/view/FlexibleCard/components/container/index.js

@@ -155,6 +155,8 @@ var Container = function Container(_ref3) {
   var context = useContext(FlexibleUiContext);
   var childrenOptions = getChildrenOptions(children, context);
   var canShowHoverPreview = showHoverPreview && status === 'resolved';
+  // `retry` object contains action that can be performed on
+  // unresolved link (unauthorized, forbidden, not found, etc.)
   var canShowAuthTooltip = showAuthTooltip && status === 'unauthorized' && retry !== undefined;
   var container = jsx("div", {
     css: getContainerStyles(size, hideBackground, hideElevation, hidePadding, clickableContainer, childrenOptions),

package/dist/esm/view/InlineCard/UnauthorisedView/index.js

@@ -93,7 +93,6 @@ export var InlineCardUnauthorizedView = /*#__PURE__*/function (_React$Component)
       if (onAuthorise && showAuthTooltip) {
         return /*#__PURE__*/React.createElement(HoverCard, {
           url: url,
-          onAuthorize: onAuthorise,
           id: this.props.id
         }, inlineCardUnauthenticatedView);
       }

package/dist/esm/view/LinkUrl/LinkWarningModal/hooks/use-link-warning-modal.js

@@ -3,6 +3,13 @@ import { useState } from 'react';
 import { normalizeUrl } from '@atlaskit/linking-common/url';
 import { useAnalyticsEvents } from '@atlaskit/analytics-next';
 import { ANALYTICS_CHANNEL } from '../../../../utils/analytics';
+var toUrl = function toUrl(url, base) {
+  try {
+    return new URL(url, base);
+  } catch (_unused) {
+    return undefined;
+  }
+};
 export var useLinkWarningModal = function useLinkWarningModal() {
   var _useState = useState(null),
     _useState2 = _slicedToArray(_useState, 2),
@@ -50,8 +57,9 @@ export var useLinkWarningModal = function useLinkWarningModal() {
       return true;
     }
     var anchorLinkRegex = new RegExp(/^#/im);
-    var isAnchorLink = anchorLinkRegex.test(linkText);
-    if (isAnchorLink) {
+    var isLinkTextAnchorLink = anchorLinkRegex.test(linkText);
+    var isAnchorLink = anchorLinkRegex.test(href);
+    if (isAnchorLink || isLinkTextAnchorLink) {
       return true;
     }
     var relativeLinkRegex = new RegExp(/^\//im);
@@ -59,8 +67,11 @@ export var useLinkWarningModal = function useLinkWarningModal() {
     if (isRelativeHrefLink) {
       return true;
     }
-    var hrefUrl = new URL(href, window.location.origin);
-    var linkTextUrl = new URL(normalisedUrlFromLinkText, hrefUrl.origin);
+    var hrefUrl = toUrl(href, window.location.origin);
+    var linkTextUrl = toUrl(normalisedUrlFromLinkText, hrefUrl === null || hrefUrl === void 0 ? void 0 : hrefUrl.origin);
+    if (!hrefUrl || !linkTextUrl) {
+      return true;
+    }
     var httpProtocols = ['http:', 'https:'];
     var areProtocolsEquivalent;
     if (httpProtocols.includes(linkTextUrl.protocol) && httpProtocols.includes(hrefUrl.protocol)) {

package/dist/esm/view/RedesignedInlineCard/UnauthorisedView/index.js

@@ -74,6 +74,7 @@ export var InlineCardUnauthorizedView = /*#__PURE__*/function (_React$Component)
       var _this$props3 = this.props,
         url = _this$props3.url,
         icon = _this$props3.icon,
+        onAuthorise = _this$props3.onAuthorise,
         onClick = _this$props3.onClick,
         isSelected = _this$props3.isSelected,
         _this$props3$testId = _this$props3.testId,
@@ -91,10 +92,9 @@ export var InlineCardUnauthorizedView = /*#__PURE__*/function (_React$Component)
         onClick: onClick,
         titleColor: "var(--ds-text-subtle, ".concat(N500, ")")
       }), this.renderActionButton());
-      if (showAuthTooltip) {
+      if (onAuthorise && showAuthTooltip) {
         return /*#__PURE__*/React.createElement(HoverCard, {
           url: url,
-          onAuthorize: this.props.onAuthorise,
           id: this.props.id
         }, inlineCardUnauthenticatedView);
       }

package/dist/types/view/HoverCard/types.d.ts

@@ -22,6 +22,7 @@ export interface HoverCardProps extends WithAnalyticsEventsProps {
     children: ReactElement;
     /**
      * Function to be called when user is authorized to view a link.
+     * @deprecated See EDM-7411
      */
     onAuthorize?: () => void;
     /**

package/dist/types-ts4.5/view/HoverCard/types.d.ts

@@ -22,6 +22,7 @@ export interface HoverCardProps extends WithAnalyticsEventsProps {
     children: ReactElement;
     /**
      * Function to be called when user is authorized to view a link.
+     * @deprecated See EDM-7411
      */
     onAuthorize?: () => void;
     /**

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@atlaskit/smart-card",
-  "version": "26.10.0",
+  "version": "26.11.1",
   "description": "Smart card component",
   "publishConfig": {
     "registry": "https://registry.npmjs.org/"
@@ -74,7 +74,7 @@
     "@af/visual-regression": "*",
     "@atlaskit/avatar": "^21.3.0",
     "@atlaskit/css-reset": "^6.5.0",
-    "@atlaskit/link-test-helpers": "^4.2.0",
+    "@atlaskit/link-test-helpers": "^5.0.0",
     "@atlaskit/lozenge": "^11.4.0",
     "@atlaskit/media-integration-test-helpers": "^3.0.0",
     "@atlaskit/media-test-helpers": "^33.0.0",