@atlaskit/smart-card 22.1.2 → 22.2.0

package/CHANGELOG.md

@@ -1,5 +1,11 @@
 # @atlaskit/smart-card
 
+## 22.2.0
+
+### Minor Changes
+
+- [`9a0c1c39d27`](https://bitbucket.org/atlassian/atlassian-frontend/commits/9a0c1c39d27) - Rethrow errors from child component of smart-card so all non API errors will be handed to parent of smart-card
+
 ## 22.1.2
 
 ### Patch Changes

package/dist/cjs/state/hooks/usePrefetch.js

@@ -23,15 +23,27 @@ function usePrefetch(url) {
       prefetchStore = _useSmartLinkContext.prefetchStore,
       connections = _useSmartLinkContext.connections;
 
-  var dispatch = store.dispatch,
-      getState = store.getState;
-  var client = connections.client;
+  var _ref = store || {},
+      dispatch = _ref.dispatch,
+      getState = _ref.getState;
+
+  var _ref2 = connections || {},
+      client = _ref2.client;
+
   return (0, _react.useCallback)( /*#__PURE__*/(0, _asyncToGenerator2.default)( /*#__PURE__*/_regenerator.default.mark(function _callee() {
     var isPrefetching, isFetching, needsPrefetch, response;
     return _regenerator.default.wrap(function _callee$(_context) {
       while (1) {
         switch (_context.prev = _context.next) {
           case 0:
+            if (!(!store || !prefetchStore || !connections)) {
+              _context.next = 2;
+              break;
+            }
+
+            return _context.abrupt("return");
+
+          case 2:
             // If the link is already being prefetched, the prefetch store
             // should have a flag set against the URL. The prefetch store is purposefully
             // separate from the UI in order to ensure no rendering takes place;
@@ -45,7 +57,7 @@ function usePrefetch(url) {
             needsPrefetch = !isPrefetching && !isFetching;
 
             if (!needsPrefetch) {
-              _context.next = 14;
+              _context.next = 16;
               break;
             }
 
@@ -57,11 +69,11 @@ function usePrefetch(url) {
             // requests by domain (as usual) to ensure we minimize the amount of connections
             // we create between browser -> ORS when making network requests.
 
-            _context.prev = 5;
-            _context.next = 8;
+            _context.prev = 7;
+            _context.next = 10;
             return client.prefetchData(url);
 
-          case 8:
+          case 10:
             response = _context.sent;
 
             // Once the data comes back, we put the link in the `resolved` status. This ensures
@@ -80,18 +92,18 @@ function usePrefetch(url) {
               }, undefined, undefined, 'resolved'));
             }
 
-            _context.next = 14;
+            _context.next = 16;
             break;
 
-          case 12:
-            _context.prev = 12;
-            _context.t0 = _context["catch"](5);
-
           case 14:
+            _context.prev = 14;
+            _context.t0 = _context["catch"](7);
+
+          case 16:
           case "end":
             return _context.stop();
         }
       }
-    }, _callee, null, [[5, 12]]);
-  })), [prefetchStore, url, getState, client, dispatch]);
+    }, _callee, null, [[7, 14]]);
+  })), [store, prefetchStore, connections, url, getState, client, dispatch]);
 }

package/dist/cjs/version.json

@@ -1,5 +1,5 @@
 {
 	"name": "@atlaskit/smart-card",
-	"version": "22.1.2",
+	"version": "22.2.0",
 	"sideEffects": false
 }

package/dist/cjs/view/CardWithUrl/loader.js

@@ -83,16 +83,12 @@ function CardWithURLRenderer(props) {
   }, [appearance, createAnalyticsEvent]);
   var analytics = (0, _analytics2.useSmartLinkAnalytics)(url !== null && url !== void 0 ? url : '', dispatchAnalytics, id);
   var logError = (0, _react.useCallback)(function (error, info) {
-    var componentStack = info.componentStack; // NB: APIErrors are thrown in response to Object Resolver Service.
-    // In these cases, control is handed back to the Editor. We do not
+    var componentStack = info.componentStack; // NB: APIErrors are thrown in response to Object Resolver Service. We do not
     // fire an event for these, as they do not cover failed UI render events.
+    // The rest of the errors caught here are unexpected, and correlate
+    // to the reliability of the smart-card front-end components.
 
-    if (error.name === 'APIError') {
-      throw error;
-    } // NB: the rest of the errors caught here are unexpected, and correlate
-    // to the reliability of the smart-card front-end components. We instrument
-    // these in order to measure our front-end reliability.
-    else {
+    if (error.name !== 'APIError') {
       var errorInfo = {
         componentStack: componentStack
       };
@@ -102,7 +98,11 @@ function CardWithURLRenderer(props) {
         error: error,
         errorInfo: errorInfo
       });
-    }
+    } // Rethrow to hand control to the consumer of Smart-card.
+    // In the case of editor this allows the Smart Link to fallback to a blue link.
+
+
+    throw error;
   }, [analytics.ui, appearance, id]);
 
   if (!url) {
@@ -140,5 +140,5 @@ function CardWithURLRenderer(props) {
 }
 
 var ErrorFallback = function ErrorFallback() {
-  return /*#__PURE__*/_react.default.createElement("span", null);
+  return null;
 };

package/dist/es2019/state/hooks/usePrefetch.js

@@ -10,15 +10,20 @@ export function usePrefetch(url) {
   const {
     dispatch,
     getState
-  } = store;
+  } = store || {};
   const {
     client
-  } = connections;
+  } = connections || {};
   return useCallback(async () => {
-    // If the link is already being prefetched, the prefetch store
+    // If smartlink context props are undefined do nothing.
+    if (!store || !prefetchStore || !connections) {
+      return;
+    } // If the link is already being prefetched, the prefetch store
     // should have a flag set against the URL. The prefetch store is purposefully
     // separate from the UI in order to ensure no rendering takes place;
     // all mutations which occur are purely store-based mutations.
+
+
     const isPrefetching = prefetchStore[url]; // If the link has already been registered in the store, then it no
     // longer needs to be prefetched, as the normal flow of a link being in
     // the viewport and being fetched is now in motion.
@@ -59,5 +64,5 @@ export function usePrefetch(url) {
         // mutations yet, the link will behave like a 'brand new' link.
       }
     }
-  }, [prefetchStore, url, getState, client, dispatch]);
+  }, [store, prefetchStore, connections, url, getState, client, dispatch]);
 }

package/dist/es2019/version.json

@@ -1,5 +1,5 @@
 {
 	"name": "@atlaskit/smart-card",
-	"version": "22.1.2",
+	"version": "22.2.0",
 	"sideEffects": false
 }

package/dist/es2019/view/CardWithUrl/loader.js

@@ -55,16 +55,12 @@ export function CardWithURLRenderer(props) {
   const logError = useCallback((error, info) => {
     const {
       componentStack
-    } = info; // NB: APIErrors are thrown in response to Object Resolver Service.
-    // In these cases, control is handed back to the Editor. We do not
+    } = info; // NB: APIErrors are thrown in response to Object Resolver Service. We do not
     // fire an event for these, as they do not cover failed UI render events.
+    // The rest of the errors caught here are unexpected, and correlate
+    // to the reliability of the smart-card front-end components.
 
-    if (error.name === 'APIError') {
-      throw error;
-    } // NB: the rest of the errors caught here are unexpected, and correlate
-    // to the reliability of the smart-card front-end components. We instrument
-    // these in order to measure our front-end reliability.
-    else {
+    if (error.name !== 'APIError') {
       const errorInfo = {
         componentStack
       };
@@ -74,7 +70,11 @@ export function CardWithURLRenderer(props) {
         error,
         errorInfo
       });
-    }
+    } // Rethrow to hand control to the consumer of Smart-card.
+    // In the case of editor this allows the Smart Link to fallback to a blue link.
+
+
+    throw error;
   }, [analytics.ui, appearance, id]);
 
   if (!url) {
@@ -112,5 +112,5 @@ export function CardWithURLRenderer(props) {
 }
 
 const ErrorFallback = () => {
-  return /*#__PURE__*/React.createElement("span", null);
+  return null;
 };

package/dist/esm/state/hooks/usePrefetch.js

@@ -9,15 +9,27 @@ export function usePrefetch(url) {
       prefetchStore = _useSmartLinkContext.prefetchStore,
       connections = _useSmartLinkContext.connections;
 
-  var dispatch = store.dispatch,
-      getState = store.getState;
-  var client = connections.client;
+  var _ref = store || {},
+      dispatch = _ref.dispatch,
+      getState = _ref.getState;
+
+  var _ref2 = connections || {},
+      client = _ref2.client;
+
   return useCallback( /*#__PURE__*/_asyncToGenerator( /*#__PURE__*/_regeneratorRuntime.mark(function _callee() {
     var isPrefetching, isFetching, needsPrefetch, response;
     return _regeneratorRuntime.wrap(function _callee$(_context) {
       while (1) {
         switch (_context.prev = _context.next) {
           case 0:
+            if (!(!store || !prefetchStore || !connections)) {
+              _context.next = 2;
+              break;
+            }
+
+            return _context.abrupt("return");
+
+          case 2:
             // If the link is already being prefetched, the prefetch store
             // should have a flag set against the URL. The prefetch store is purposefully
             // separate from the UI in order to ensure no rendering takes place;
@@ -31,7 +43,7 @@ export function usePrefetch(url) {
             needsPrefetch = !isPrefetching && !isFetching;
 
             if (!needsPrefetch) {
-              _context.next = 14;
+              _context.next = 16;
               break;
             }
 
@@ -43,11 +55,11 @@ export function usePrefetch(url) {
             // requests by domain (as usual) to ensure we minimize the amount of connections
             // we create between browser -> ORS when making network requests.
 
-            _context.prev = 5;
-            _context.next = 8;
+            _context.prev = 7;
+            _context.next = 10;
             return client.prefetchData(url);
 
-          case 8:
+          case 10:
             response = _context.sent;
 
             // Once the data comes back, we put the link in the `resolved` status. This ensures
@@ -66,18 +78,18 @@ export function usePrefetch(url) {
               }, undefined, undefined, 'resolved'));
             }
 
-            _context.next = 14;
+            _context.next = 16;
             break;
 
-          case 12:
-            _context.prev = 12;
-            _context.t0 = _context["catch"](5);
-
           case 14:
+            _context.prev = 14;
+            _context.t0 = _context["catch"](7);
+
+          case 16:
           case "end":
             return _context.stop();
         }
       }
-    }, _callee, null, [[5, 12]]);
-  })), [prefetchStore, url, getState, client, dispatch]);
+    }, _callee, null, [[7, 14]]);
+  })), [store, prefetchStore, connections, url, getState, client, dispatch]);
 }

package/dist/esm/version.json

@@ -1,5 +1,5 @@
 {
 	"name": "@atlaskit/smart-card",
-	"version": "22.1.2",
+	"version": "22.2.0",
 	"sideEffects": false
 }

package/dist/esm/view/CardWithUrl/loader.js

@@ -59,16 +59,12 @@ export function CardWithURLRenderer(props) {
   }, [appearance, createAnalyticsEvent]);
   var analytics = useSmartLinkAnalytics(url !== null && url !== void 0 ? url : '', dispatchAnalytics, id);
   var logError = useCallback(function (error, info) {
-    var componentStack = info.componentStack; // NB: APIErrors are thrown in response to Object Resolver Service.
-    // In these cases, control is handed back to the Editor. We do not
+    var componentStack = info.componentStack; // NB: APIErrors are thrown in response to Object Resolver Service. We do not
     // fire an event for these, as they do not cover failed UI render events.
+    // The rest of the errors caught here are unexpected, and correlate
+    // to the reliability of the smart-card front-end components.
 
-    if (error.name === 'APIError') {
-      throw error;
-    } // NB: the rest of the errors caught here are unexpected, and correlate
-    // to the reliability of the smart-card front-end components. We instrument
-    // these in order to measure our front-end reliability.
-    else {
+    if (error.name !== 'APIError') {
       var errorInfo = {
         componentStack: componentStack
       };
@@ -78,7 +74,11 @@ export function CardWithURLRenderer(props) {
         error: error,
         errorInfo: errorInfo
       });
-    }
+    } // Rethrow to hand control to the consumer of Smart-card.
+    // In the case of editor this allows the Smart Link to fallback to a blue link.
+
+
+    throw error;
   }, [analytics.ui, appearance, id]);
 
   if (!url) {
@@ -116,5 +116,5 @@ export function CardWithURLRenderer(props) {
 }
 
 var ErrorFallback = function ErrorFallback() {
-  return /*#__PURE__*/React.createElement("span", null);
+  return null;
 };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@atlaskit/smart-card",
-  "version": "22.1.2",
+  "version": "22.2.0",
   "description": "Smart card component",
   "publishConfig": {
     "registry": "https://registry.npmjs.org/"