@atlaskit/smart-card 19.0.1 → 19.0.2

package/CHANGELOG.md

@@ -1,5 +1,11 @@
 # @atlaskit/smart-card
 
+## 19.0.2
+
+### Patch Changes
+
+- [`f3026520fc6`](https://bitbucket.org/atlassian/atlassian-frontend/commits/f3026520fc6) - Fix long tti times for UFO smart-link-rendered experience
+
 ## 19.0.1
 
 ### Patch Changes

package/dist/cjs/version.json

@@ -1,5 +1,5 @@
 {
 	"name": "@atlaskit/smart-card",
-	"version": "19.0.1",
+	"version": "19.0.2",
 	"sideEffects": false
 }

package/dist/cjs/view/CardWithUrl/component-lazy/LazyIntersectionObserverCard.js

@@ -21,6 +21,8 @@ var _component = require("../component");
 
 var _LazyFallback = require("./LazyFallback");
 
+var _ufoExperiences = require("../../../state/analytics/ufoExperiences");
+
 function _getRequireWildcardCache(nodeInterop) { if (typeof WeakMap !== "function") return null; var cacheBabelInterop = new WeakMap(); var cacheNodeInterop = new WeakMap(); return (_getRequireWildcardCache = function _getRequireWildcardCache(nodeInterop) { return nodeInterop ? cacheNodeInterop : cacheBabelInterop; })(nodeInterop); }
 
 function _interopRequireWildcard(obj, nodeInterop) { if (!nodeInterop && obj && obj.__esModule) { return obj; } if (obj === null || _typeof(obj) !== "object" && typeof obj !== "function") { return { default: obj }; } var cache = _getRequireWildcardCache(nodeInterop); if (cache && cache.has(obj)) { return cache.get(obj); } var newObj = {}; var hasPropertyDescriptor = Object.defineProperty && Object.getOwnPropertyDescriptor; for (var key in obj) { if (key !== "default" && Object.prototype.hasOwnProperty.call(obj, key)) { var desc = hasPropertyDescriptor ? Object.getOwnPropertyDescriptor(obj, key) : null; if (desc && (desc.get || desc.set)) { Object.defineProperty(newObj, key, desc); } else { newObj[key] = obj[key]; } } } newObj.default = obj; if (cache) { cache.set(obj, newObj); } return newObj; }
@@ -39,7 +41,8 @@ function LazyIntersectionObserverCard(props) {
 
   var showActions = props.showActions,
       appearance = props.appearance,
-      url = props.url;
+      url = props.url,
+      id = props.id;
   var prefetch = (0, _state.usePrefetch)(url);
   var Component = appearance === 'inline' ? 'span' : 'div';
   var ComponentObserver = Component;
@@ -49,12 +52,13 @@ function LazyIntersectionObserverCard(props) {
     });
 
     if (isVisible) {
+      (0, _ufoExperiences.startUfoExperience)('smart-link-rendered', id);
       setIsIntersecting(true);
       observer.disconnect();
     } else {
       prefetch();
     }
-  }, [prefetch]);
+  }, [prefetch, id]);
   var onRef = (0, _react.useCallback)(function (element) {
     if (!element) {
       return;

package/dist/cjs/view/CardWithUrl/component-lazy/LazyLazilyRenderCard.js

@@ -2,6 +2,8 @@
 
 var _interopRequireDefault = require("@babel/runtime/helpers/interopRequireDefault");
 
+var _typeof = require("@babel/runtime/helpers/typeof");
+
 Object.defineProperty(exports, "__esModule", {
   value: true
 });
@@ -9,7 +11,7 @@ exports.LazyLazilyRenderCard = LazyLazilyRenderCard;
 
 var _extends2 = _interopRequireDefault(require("@babel/runtime/helpers/extends"));
 
-var _react = _interopRequireDefault(require("react"));
+var _react = _interopRequireWildcard(require("react"));
 
 var _reactLazilyRender = _interopRequireDefault(require("react-lazily-render"));
 
@@ -17,11 +19,22 @@ var _component = require("../component");
 
 var _LazyFallback = require("./LazyFallback");
 
+var _ufoExperiences = require("../../../state/analytics/ufoExperiences");
+
+function _getRequireWildcardCache(nodeInterop) { if (typeof WeakMap !== "function") return null; var cacheBabelInterop = new WeakMap(); var cacheNodeInterop = new WeakMap(); return (_getRequireWildcardCache = function _getRequireWildcardCache(nodeInterop) { return nodeInterop ? cacheNodeInterop : cacheBabelInterop; })(nodeInterop); }
+
+function _interopRequireWildcard(obj, nodeInterop) { if (!nodeInterop && obj && obj.__esModule) { return obj; } if (obj === null || _typeof(obj) !== "object" && typeof obj !== "function") { return { default: obj }; } var cache = _getRequireWildcardCache(nodeInterop); if (cache && cache.has(obj)) { return cache.get(obj); } var newObj = {}; var hasPropertyDescriptor = Object.defineProperty && Object.getOwnPropertyDescriptor; for (var key in obj) { if (key !== "default" && Object.prototype.hasOwnProperty.call(obj, key)) { var desc = hasPropertyDescriptor ? Object.getOwnPropertyDescriptor(obj, key) : null; if (desc && (desc.get || desc.set)) { Object.defineProperty(newObj, key, desc); } else { newObj[key] = obj[key]; } } } newObj.default = obj; if (cache) { cache.set(obj, newObj); } return newObj; }
+
 function LazyLazilyRenderCard(props) {
   var appearance = props.appearance,
       container = props.container,
-      showActions = props.showActions;
+      showActions = props.showActions,
+      id = props.id;
   var offset = Math.ceil(window.innerHeight / 4);
+  (0, _react.useState)(function () {
+    // Start of experience when intersectionObserver is not supported.
+    (0, _ufoExperiences.startUfoExperience)('smart-link-rendered', id);
+  });
   return /*#__PURE__*/_react.default.createElement(_reactLazilyRender.default, {
     offset: offset,
     component: appearance === 'inline' ? 'span' : 'div',

package/dist/cjs/view/CardWithUrl/loader.js

@@ -40,13 +40,8 @@ function CardWithURLRenderer(props) {
     return (0, _uuid.default)();
   }),
       _useState2 = (0, _slicedToArray2.default)(_useState, 1),
-      id = _useState2[0]; // Equivalent to ComponentWillMount
+      id = _useState2[0];
 
-
-  (0, _react.useState)(function () {
-    // We want to start timing of render event only once and right at the start
-    (0, _ufoExperiences.startUfoExperience)('smart-link-rendered', id);
-  });
   (0, _react.useEffect)(function () {
     // ComponentWillUnmount
     return function () {
@@ -96,7 +91,10 @@ function CardWithURLRenderer(props) {
     else {
       var errorInfo = {
         componentStack: componentStack
-      };
+      }; // Start and fail the smart-link-rendered experience. If it has already
+      // been started nothing happens.
+
+      (0, _ufoExperiences.startUfoExperience)('smart-link-rendered', id);
       (0, _ufoExperiences.failUfoExperience)('smart-link-rendered', id);
       (0, _ufoExperiences.failUfoExperience)('smart-link-authenticated', id);
       dispatchAnalytics((0, _analytics.uiRenderFailedEvent)(appearance, error, errorInfo));

package/dist/es2019/version.json

@@ -1,5 +1,5 @@
 {
 	"name": "@atlaskit/smart-card",
-	"version": "19.0.1",
+	"version": "19.0.2",
 	"sideEffects": false
 }

package/dist/es2019/view/CardWithUrl/component-lazy/LazyIntersectionObserverCard.js

@@ -2,7 +2,8 @@ import _extends from "@babel/runtime/helpers/extends";
 import React, { useCallback, useState } from 'react';
 import { usePrefetch } from '../../../state';
 import { CardWithUrlContent } from '../component';
-import { LoadingCardLink } from './LazyFallback'; // This property enables the intersection observer to be run once the
+import { LoadingCardLink } from './LazyFallback';
+import { startUfoExperience } from '../../../state/analytics/ufoExperiences'; // This property enables the intersection observer to be run once the
 // HTML element being observed is within `X` px of the target container it is
 // being compared to. Since the default container is the `document`, we set this
 // up to check once a Smart Link is within `X` px from the bottom of the viewport.
@@ -13,7 +14,8 @@ export function LazyIntersectionObserverCard(props) {
   const {
     showActions,
     appearance,
-    url
+    url,
+    id
   } = props;
   const prefetch = usePrefetch(url);
   const Component = appearance === 'inline' ? 'span' : 'div';
@@ -22,12 +24,13 @@ export function LazyIntersectionObserverCard(props) {
     const isVisible = entries.some(entry => entry.isIntersecting);
 
     if (isVisible) {
+      startUfoExperience('smart-link-rendered', id);
       setIsIntersecting(true);
       observer.disconnect();
     } else {
       prefetch();
     }
-  }, [prefetch]);
+  }, [prefetch, id]);
   const onRef = useCallback(element => {
     if (!element) {
       return;

package/dist/es2019/view/CardWithUrl/component-lazy/LazyLazilyRenderCard.js

@@ -1,15 +1,21 @@
 import _extends from "@babel/runtime/helpers/extends";
-import React from 'react';
+import React, { useState } from 'react';
 import LazilyRender from 'react-lazily-render';
 import { CardWithUrlContent } from '../component';
 import { LoadingCardLink } from './LazyFallback';
+import { startUfoExperience } from '../../../state/analytics/ufoExperiences';
 export function LazyLazilyRenderCard(props) {
   const {
     appearance,
     container,
-    showActions
+    showActions,
+    id
   } = props;
   const offset = Math.ceil(window.innerHeight / 4);
+  useState(() => {
+    // Start of experience when intersectionObserver is not supported.
+    startUfoExperience('smart-link-rendered', id);
+  });
   return /*#__PURE__*/React.createElement(LazilyRender, {
     offset: offset,
     component: appearance === 'inline' ? 'span' : 'div',

package/dist/es2019/view/CardWithUrl/loader.js

@@ -9,12 +9,7 @@ const LazyCardWithUrlContent = /*#__PURE__*/lazy(() => import(
 /* webpackChunkName: "@atlaskit-internal_smartcard-urlcardcontent" */
 './component-lazy/index'));
 export function CardWithURLRenderer(props) {
-  const [id] = useState(() => uuid()); // Equivalent to ComponentWillMount
-
-  useState(() => {
-    // We want to start timing of render event only once and right at the start
-    startUfoExperience('smart-link-rendered', id);
-  });
+  const [id] = useState(() => uuid());
   useEffect(() => {
     // ComponentWillUnmount
     return () => {
@@ -68,7 +63,10 @@ export function CardWithURLRenderer(props) {
     else {
       const errorInfo = {
         componentStack
-      };
+      }; // Start and fail the smart-link-rendered experience. If it has already
+      // been started nothing happens.
+
+      startUfoExperience('smart-link-rendered', id);
       failUfoExperience('smart-link-rendered', id);
       failUfoExperience('smart-link-authenticated', id);
       dispatchAnalytics(uiRenderFailedEvent(appearance, error, errorInfo));

package/dist/esm/version.json

@@ -1,5 +1,5 @@
 {
 	"name": "@atlaskit/smart-card",
-	"version": "19.0.1",
+	"version": "19.0.2",
 	"sideEffects": false
 }

package/dist/esm/view/CardWithUrl/component-lazy/LazyIntersectionObserverCard.js

@@ -3,7 +3,8 @@ import _slicedToArray from "@babel/runtime/helpers/slicedToArray";
 import React, { useCallback, useState } from 'react';
 import { usePrefetch } from '../../../state';
 import { CardWithUrlContent } from '../component';
-import { LoadingCardLink } from './LazyFallback'; // This property enables the intersection observer to be run once the
+import { LoadingCardLink } from './LazyFallback';
+import { startUfoExperience } from '../../../state/analytics/ufoExperiences'; // This property enables the intersection observer to be run once the
 // HTML element being observed is within `X` px of the target container it is
 // being compared to. Since the default container is the `document`, we set this
 // up to check once a Smart Link is within `X` px from the bottom of the viewport.
@@ -17,7 +18,8 @@ export function LazyIntersectionObserverCard(props) {
 
   var showActions = props.showActions,
       appearance = props.appearance,
-      url = props.url;
+      url = props.url,
+      id = props.id;
   var prefetch = usePrefetch(url);
   var Component = appearance === 'inline' ? 'span' : 'div';
   var ComponentObserver = Component;
@@ -27,12 +29,13 @@ export function LazyIntersectionObserverCard(props) {
     });
 
     if (isVisible) {
+      startUfoExperience('smart-link-rendered', id);
       setIsIntersecting(true);
       observer.disconnect();
     } else {
       prefetch();
     }
-  }, [prefetch]);
+  }, [prefetch, id]);
   var onRef = useCallback(function (element) {
     if (!element) {
       return;

package/dist/esm/view/CardWithUrl/component-lazy/LazyLazilyRenderCard.js

@@ -1,13 +1,19 @@
 import _extends from "@babel/runtime/helpers/extends";
-import React from 'react';
+import React, { useState } from 'react';
 import LazilyRender from 'react-lazily-render';
 import { CardWithUrlContent } from '../component';
 import { LoadingCardLink } from './LazyFallback';
+import { startUfoExperience } from '../../../state/analytics/ufoExperiences';
 export function LazyLazilyRenderCard(props) {
   var appearance = props.appearance,
       container = props.container,
-      showActions = props.showActions;
+      showActions = props.showActions,
+      id = props.id;
   var offset = Math.ceil(window.innerHeight / 4);
+  useState(function () {
+    // Start of experience when intersectionObserver is not supported.
+    startUfoExperience('smart-link-rendered', id);
+  });
   return /*#__PURE__*/React.createElement(LazilyRender, {
     offset: offset,
     component: appearance === 'inline' ? 'span' : 'div',

package/dist/esm/view/CardWithUrl/loader.js

@@ -16,13 +16,8 @@ export function CardWithURLRenderer(props) {
     return uuid();
   }),
       _useState2 = _slicedToArray(_useState, 1),
-      id = _useState2[0]; // Equivalent to ComponentWillMount
+      id = _useState2[0];
 
-
-  useState(function () {
-    // We want to start timing of render event only once and right at the start
-    startUfoExperience('smart-link-rendered', id);
-  });
   useEffect(function () {
     // ComponentWillUnmount
     return function () {
@@ -72,7 +67,10 @@ export function CardWithURLRenderer(props) {
     else {
       var errorInfo = {
         componentStack: componentStack
-      };
+      }; // Start and fail the smart-link-rendered experience. If it has already
+      // been started nothing happens.
+
+      startUfoExperience('smart-link-rendered', id);
       failUfoExperience('smart-link-rendered', id);
       failUfoExperience('smart-link-authenticated', id);
       dispatchAnalytics(uiRenderFailedEvent(appearance, error, errorInfo));

package/dist/types/view/__mocks__/intersection-observer.d.ts

@@ -13,8 +13,11 @@ export declare const MockIntersectionObserverFactory: (mockIntersectionObserverO
         readonly root: Element | null;
         readonly rootMargin: string;
         readonly thresholds: ReadonlyArray<number>;
+        previousMockEntries: MockEntry[];
         callback: IntersectionObserverCallback;
         observe(_element: HTMLElement): void;
+        callIntersectionObserverCallback: () => void;
+        checkIntersection: () => void;
         disconnect: jest.Mock<any, any>;
         takeRecords: jest.Mock<any, any>;
         unobserve: jest.Mock<any, any>;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@atlaskit/smart-card",
-  "version": "19.0.1",
+  "version": "19.0.2",
   "description": "Smart card component",
   "publishConfig": {
     "registry": "https://registry.npmjs.org/"