@atlaskit/smart-card 18.0.6 → 18.0.9

package/CHANGELOG.md

@@ -1,5 +1,23 @@
 # @atlaskit/smart-card
 
+## 18.0.9
+
+### Patch Changes
+
+- [`6adaa6b5c18`](https://bitbucket.org/atlassian/atlassian-frontend/commits/6adaa6b5c18) - Updated default renderer onClick to not fire on a Flexible UI link to prevent links from being openned twice
+
+## 18.0.8
+
+### Patch Changes
+
+- [`d9b55e7cd29`](https://bitbucket.org/atlassian/atlassian-frontend/commits/d9b55e7cd29) - Add classname for placeholder element that is shown while we load js module
+
+## 18.0.7
+
+### Patch Changes
+
+- [`1f377bd17a4`](https://bitbucket.org/atlassian/atlassian-frontend/commits/1f377bd17a4) - Added open in new tab action to titleblock and refactored tests
+
 ## 18.0.6
 
 ### Patch Changes

package/dist/cjs/version.json

@@ -1,5 +1,5 @@
 {
 	"name": "@atlaskit/smart-card",
-	"version": "18.0.6",
+	"version": "18.0.9",
 	"sideEffects": false
 }

package/dist/cjs/view/CardWithUrl/component.js

@@ -80,7 +80,11 @@ function CardWithUrlContent(_ref) {
       analytics.ui.cardClickedEvent(isFlexibleUi ? 'flexible' : appearance, definitionId, extensionKey, isModifierKeyPressed);
     }
 
-    onClick ? onClick(event) : handleClick(event);
+    if (onClick) {
+      onClick(event);
+    } else if (!isFlexibleUi) {
+      handleClick(event);
+    }
   }, [state.status, analytics.ui, appearance, definitionId, extensionKey, onClick, handleClick, isFlexibleUi]);
   var handleAuthorize = (0, _react.useCallback)(function () {
     return actions.authorize(appearance);

package/dist/cjs/view/CardWithUrl/loader.js

@@ -23,7 +23,7 @@ var _reactErrorBoundary = require("react-error-boundary");
 
 var _ufoExperiences = require("../../state/analytics/ufoExperiences");
 
-var _LinkView = require("../LinkView");
+var _LazyFallback = require("./component-lazy/LazyFallback");
 
 function _getRequireWildcardCache(nodeInterop) { if (typeof WeakMap !== "function") return null; var cacheBabelInterop = new WeakMap(); var cacheNodeInterop = new WeakMap(); return (_getRequireWildcardCache = function _getRequireWildcardCache(nodeInterop) { return nodeInterop ? cacheNodeInterop : cacheBabelInterop; })(nodeInterop); }
 
@@ -106,15 +106,7 @@ function CardWithURLRenderer(props) {
     throw new Error('@atlaskit/smart-card: url property is missing.');
   }
 
-  return /*#__PURE__*/_react.default.createElement(_reactErrorBoundary.ErrorBoundary, {
-    FallbackComponent: ErrorFallback,
-    onError: logError
-  }, /*#__PURE__*/_react.default.createElement(_react.Suspense, {
-    fallback: /*#__PURE__*/_react.default.createElement(_LinkView.CardLinkView, {
-      key: 'chunk-placeholder',
-      link: url
-    })
-  }, /*#__PURE__*/_react.default.createElement(LazyCardWithUrlContent, {
+  var cardWithUrlProps = {
     id: id,
     url: url,
     appearance: appearance,
@@ -131,7 +123,13 @@ function CardWithURLRenderer(props) {
     embedIframeRef: embedIframeRef,
     inlinePreloaderStyle: inlinePreloaderStyle,
     ui: ui
-  }, children)));
+  };
+  return /*#__PURE__*/_react.default.createElement(_reactErrorBoundary.ErrorBoundary, {
+    FallbackComponent: ErrorFallback,
+    onError: logError
+  }, /*#__PURE__*/_react.default.createElement(_react.Suspense, {
+    fallback: /*#__PURE__*/_react.default.createElement(_LazyFallback.LoadingCardLink, cardWithUrlProps)
+  }, /*#__PURE__*/_react.default.createElement(LazyCardWithUrlContent, cardWithUrlProps, children)));
 }
 
 var ErrorFallback = function ErrorFallback() {

package/dist/cjs/view/HoverCard/index.js

@@ -29,6 +29,8 @@ var _useSmartLinkActions = require("../../state/hooks-external/useSmartLinkActio
 
 var _styled = require("./styled");
 
+var _shortcut = _interopRequireDefault(require("@atlaskit/icon/glyph/shortcut"));
+
 function _getRequireWildcardCache(nodeInterop) { if (typeof WeakMap !== "function") return null; var cacheBabelInterop = new WeakMap(); var cacheNodeInterop = new WeakMap(); return (_getRequireWildcardCache = function _getRequireWildcardCache(nodeInterop) { return nodeInterop ? cacheNodeInterop : cacheBabelInterop; })(nodeInterop); }
 
 function _interopRequireWildcard(obj, nodeInterop) { if (!nodeInterop && obj && obj.__esModule) { return obj; } if (obj === null || _typeof(obj) !== "object" && typeof obj !== "function") { return { default: obj }; } var cache = _getRequireWildcardCache(nodeInterop); if (cache && cache.has(obj)) { return cache.get(obj); } var newObj = {}; var hasPropertyDescriptor = Object.defineProperty && Object.getOwnPropertyDescriptor; for (var key in obj) { if (key !== "default" && Object.prototype.hasOwnProperty.call(obj, key)) { var desc = hasPropertyDescriptor ? Object.getOwnPropertyDescriptor(obj, key) : null; if (desc && (desc.get || desc.set)) { Object.defineProperty(newObj, key, desc); } else { newObj[key] = obj[key]; } } } newObj.default = obj; if (cache) { cache.set(obj, newObj); } return newObj; }
@@ -71,7 +73,7 @@ var HoverCard = function HoverCard(_ref) {
     appearance: 'block',
     analyticsHandler: analyticsHandler
   });
-  var actions = (0, _react.useMemo)(function () {
+  var smartlinkActions = (0, _react.useMemo)(function () {
     return linkActions.map(function (action) {
       return {
         content: action.text,
@@ -83,6 +85,20 @@ var HoverCard = function HoverCard(_ref) {
       };
     });
   }, [linkActions]);
+  var openAction = (0, _react.useMemo)(function () {
+    return {
+      name: _constants.ActionName.CustomAction,
+      icon: (0, _core.jsx)(_shortcut.default, {
+        label: "open in new tab",
+        size: "medium"
+      }),
+      iconPosition: 'before',
+      onClick: function onClick() {
+        return window.open(url, '_blank');
+      },
+      testId: 'hover-card-open-button'
+    };
+  }, [url]);
 
   var cardComponent = function cardComponent() {
     return (0, _core.jsx)("div", {
@@ -96,8 +112,10 @@ var HoverCard = function HoverCard(_ref) {
         hideElevation: true,
         size: _constants.SmartLinkSize.Large
       }
-    }, (0, _core.jsx)(_blocks.TitleBlock, null), (0, _core.jsx)(_blocks.SnippetBlock, null), (0, _core.jsx)(_blocks.FooterBlock, {
-      actions: actions
+    }, (0, _core.jsx)(_blocks.TitleBlock, {
+      actions: [openAction]
+    }), (0, _core.jsx)(_blocks.SnippetBlock, null), (0, _core.jsx)(_blocks.FooterBlock, {
+      actions: smartlinkActions
     })));
   };
 

package/dist/es2019/version.json

@@ -1,5 +1,5 @@
 {
 	"name": "@atlaskit/smart-card",
-	"version": "18.0.6",
+	"version": "18.0.9",
 	"sideEffects": false
 }

package/dist/es2019/view/CardWithUrl/component.js

@@ -52,7 +52,11 @@ export function CardWithUrlContent({
       analytics.ui.cardClickedEvent(isFlexibleUi ? 'flexible' : appearance, definitionId, extensionKey, isModifierKeyPressed);
     }
 
-    onClick ? onClick(event) : handleClick(event);
+    if (onClick) {
+      onClick(event);
+    } else if (!isFlexibleUi) {
+      handleClick(event);
+    }
   }, [state.status, analytics.ui, appearance, definitionId, extensionKey, onClick, handleClick, isFlexibleUi]);
   const handleAuthorize = useCallback(() => actions.authorize(appearance), [actions, appearance]);
   const handleRetry = useCallback(() => {

package/dist/es2019/view/CardWithUrl/loader.js

@@ -4,7 +4,7 @@ import { uiRenderFailedEvent, fireSmartLinkEvent } from '../../utils/analytics';
 import { clearMarks, clearMeasures } from '../../utils/performance';
 import { ErrorBoundary } from 'react-error-boundary';
 import { failUfoExperience, startUfoExperience } from '../../state/analytics/ufoExperiences';
-import { CardLinkView } from '../LinkView';
+import { LoadingCardLink } from './component-lazy/LazyFallback';
 const LazyCardWithUrlContent = /*#__PURE__*/lazy(() => import(
 /* webpackChunkName: "@atlaskit-internal_smartcard-urlcardcontent" */
 './component-lazy/index'));
@@ -78,32 +78,30 @@ export function CardWithURLRenderer(props) {
     throw new Error('@atlaskit/smart-card: url property is missing.');
   }
 
+  const cardWithUrlProps = {
+    id,
+    url,
+    appearance,
+    onClick,
+    isSelected,
+    isFrameVisible,
+    dispatchAnalytics,
+    container,
+    onResolve,
+    testId,
+    showActions,
+    inheritDimensions,
+    platform,
+    embedIframeRef,
+    inlinePreloaderStyle,
+    ui
+  };
   return /*#__PURE__*/React.createElement(ErrorBoundary, {
     FallbackComponent: ErrorFallback,
     onError: logError
   }, /*#__PURE__*/React.createElement(Suspense, {
-    fallback: /*#__PURE__*/React.createElement(CardLinkView, {
-      key: 'chunk-placeholder',
-      link: url
-    })
-  }, /*#__PURE__*/React.createElement(LazyCardWithUrlContent, {
-    id: id,
-    url: url,
-    appearance: appearance,
-    onClick: onClick,
-    isSelected: isSelected,
-    isFrameVisible: isFrameVisible,
-    dispatchAnalytics: dispatchAnalytics,
-    container: container,
-    onResolve: onResolve,
-    testId: testId,
-    showActions: showActions,
-    inheritDimensions: inheritDimensions,
-    platform: platform,
-    embedIframeRef: embedIframeRef,
-    inlinePreloaderStyle: inlinePreloaderStyle,
-    ui: ui
-  }, children)));
+    fallback: /*#__PURE__*/React.createElement(LoadingCardLink, cardWithUrlProps)
+  }, /*#__PURE__*/React.createElement(LazyCardWithUrlContent, cardWithUrlProps, children)));
 }
 
 const ErrorFallback = () => {

package/dist/es2019/view/HoverCard/index.js

@@ -9,6 +9,7 @@ import Popup from '@atlaskit/popup';
 import { SmartLinkSize, ActionName } from '../../constants';
 import { useSmartLinkActions } from '../../state/hooks-external/useSmartLinkActions';
 import { HoverCardContainer } from './styled';
+import ShortcutIcon from '@atlaskit/icon/glyph/shortcut';
 export const HoverCard = ({
   children,
   url
@@ -42,12 +43,24 @@ export const HoverCard = ({
     appearance: 'block',
     analyticsHandler
   });
-  const actions = useMemo(() => linkActions.map(action => ({
+  const smartlinkActions = useMemo(() => linkActions.map(action => ({
     content: action.text,
     name: ActionName.CustomAction,
     onClick: () => action.invoke(),
     testId: action.id
   })), [linkActions]);
+  const openAction = useMemo(() => {
+    return {
+      name: ActionName.CustomAction,
+      icon: jsx(ShortcutIcon, {
+        label: "open in new tab",
+        size: "medium"
+      }),
+      iconPosition: 'before',
+      onClick: () => window.open(url, '_blank'),
+      testId: 'hover-card-open-button'
+    };
+  }, [url]);
 
   const cardComponent = () => jsx("div", {
     onMouseEnter: initShowCard,
@@ -60,8 +73,10 @@ export const HoverCard = ({
       hideElevation: true,
       size: SmartLinkSize.Large
     }
-  }, jsx(TitleBlock, null), jsx(SnippetBlock, null), jsx(FooterBlock, {
-    actions: actions
+  }, jsx(TitleBlock, {
+    actions: [openAction]
+  }), jsx(SnippetBlock, null), jsx(FooterBlock, {
+    actions: smartlinkActions
   })));
 
   const onClose = useCallback(() => setIsOpen(false), []);

package/dist/esm/version.json

@@ -1,5 +1,5 @@
 {
 	"name": "@atlaskit/smart-card",
-	"version": "18.0.6",
+	"version": "18.0.9",
 	"sideEffects": false
 }

package/dist/esm/view/CardWithUrl/component.js

@@ -54,7 +54,11 @@ export function CardWithUrlContent(_ref) {
       analytics.ui.cardClickedEvent(isFlexibleUi ? 'flexible' : appearance, definitionId, extensionKey, isModifierKeyPressed);
     }
 
-    onClick ? onClick(event) : handleClick(event);
+    if (onClick) {
+      onClick(event);
+    } else if (!isFlexibleUi) {
+      handleClick(event);
+    }
   }, [state.status, analytics.ui, appearance, definitionId, extensionKey, onClick, handleClick, isFlexibleUi]);
   var handleAuthorize = useCallback(function () {
     return actions.authorize(appearance);

package/dist/esm/view/CardWithUrl/loader.js

@@ -5,7 +5,7 @@ import { uiRenderFailedEvent, fireSmartLinkEvent } from '../../utils/analytics';
 import { clearMarks, clearMeasures } from '../../utils/performance';
 import { ErrorBoundary } from 'react-error-boundary';
 import { failUfoExperience, startUfoExperience } from '../../state/analytics/ufoExperiences';
-import { CardLinkView } from '../LinkView';
+import { LoadingCardLink } from './component-lazy/LazyFallback';
 var LazyCardWithUrlContent = /*#__PURE__*/lazy(function () {
   return import(
   /* webpackChunkName: "@atlaskit-internal_smartcard-urlcardcontent" */
@@ -82,15 +82,7 @@ export function CardWithURLRenderer(props) {
     throw new Error('@atlaskit/smart-card: url property is missing.');
   }
 
-  return /*#__PURE__*/React.createElement(ErrorBoundary, {
-    FallbackComponent: ErrorFallback,
-    onError: logError
-  }, /*#__PURE__*/React.createElement(Suspense, {
-    fallback: /*#__PURE__*/React.createElement(CardLinkView, {
-      key: 'chunk-placeholder',
-      link: url
-    })
-  }, /*#__PURE__*/React.createElement(LazyCardWithUrlContent, {
+  var cardWithUrlProps = {
     id: id,
     url: url,
     appearance: appearance,
@@ -107,7 +99,13 @@ export function CardWithURLRenderer(props) {
     embedIframeRef: embedIframeRef,
     inlinePreloaderStyle: inlinePreloaderStyle,
     ui: ui
-  }, children)));
+  };
+  return /*#__PURE__*/React.createElement(ErrorBoundary, {
+    FallbackComponent: ErrorFallback,
+    onError: logError
+  }, /*#__PURE__*/React.createElement(Suspense, {
+    fallback: /*#__PURE__*/React.createElement(LoadingCardLink, cardWithUrlProps)
+  }, /*#__PURE__*/React.createElement(LazyCardWithUrlContent, cardWithUrlProps, children)));
 }
 
 var ErrorFallback = function ErrorFallback() {

package/dist/esm/view/HoverCard/index.js

@@ -10,6 +10,7 @@ import Popup from '@atlaskit/popup';
 import { SmartLinkSize, ActionName } from '../../constants';
 import { useSmartLinkActions } from '../../state/hooks-external/useSmartLinkActions';
 import { HoverCardContainer } from './styled';
+import ShortcutIcon from '@atlaskit/icon/glyph/shortcut';
 export var HoverCard = function HoverCard(_ref) {
   var children = _ref.children,
       url = _ref.url;
@@ -47,7 +48,7 @@ export var HoverCard = function HoverCard(_ref) {
     appearance: 'block',
     analyticsHandler: analyticsHandler
   });
-  var actions = useMemo(function () {
+  var smartlinkActions = useMemo(function () {
     return linkActions.map(function (action) {
       return {
         content: action.text,
@@ -59,6 +60,20 @@ export var HoverCard = function HoverCard(_ref) {
       };
     });
   }, [linkActions]);
+  var openAction = useMemo(function () {
+    return {
+      name: ActionName.CustomAction,
+      icon: jsx(ShortcutIcon, {
+        label: "open in new tab",
+        size: "medium"
+      }),
+      iconPosition: 'before',
+      onClick: function onClick() {
+        return window.open(url, '_blank');
+      },
+      testId: 'hover-card-open-button'
+    };
+  }, [url]);
 
   var cardComponent = function cardComponent() {
     return jsx("div", {
@@ -72,8 +87,10 @@ export var HoverCard = function HoverCard(_ref) {
         hideElevation: true,
         size: SmartLinkSize.Large
       }
-    }, jsx(TitleBlock, null), jsx(SnippetBlock, null), jsx(FooterBlock, {
-      actions: actions
+    }, jsx(TitleBlock, {
+      actions: [openAction]
+    }), jsx(SnippetBlock, null), jsx(FooterBlock, {
+      actions: smartlinkActions
     })));
   };
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@atlaskit/smart-card",
-  "version": "18.0.6",
+  "version": "18.0.9",
   "description": "Smart card component",
   "publishConfig": {
     "registry": "https://registry.npmjs.org/"