@atlaskit/smart-card 16.2.0 → 16.2.1

package/CHANGELOG.md

@@ -1,5 +1,11 @@
 # @atlaskit/smart-card
 
+## 16.2.1
+
+### Patch Changes
+
+- [`d7f743bbbdd`](https://bitbucket.org/atlassian/atlassian-frontend/commits/d7f743bbbdd) - useCallback for dispatchAnalytics to prevent multiple events firing on hover
+
 ## 16.2.0
 
 ### Minor Changes

package/dist/cjs/version.json

@@ -1,5 +1,5 @@
 {
 	"name": "@atlaskit/smart-card",
-	"version": "16.2.0",
+	"version": "16.2.1",
 	"sideEffects": false
 }

package/dist/cjs/view/CardWithUrl/loader.js

@@ -54,8 +54,33 @@ function CardWithURLRenderer(props) {
       (0, _performance.clearMeasures)(id);
     };
   }, [id]);
+  var url = props.url,
+      appearance = props.appearance,
+      isSelected = props.isSelected,
+      isFrameVisible = props.isFrameVisible,
+      onClick = props.onClick,
+      container = props.container,
+      onResolve = props.onResolve,
+      testId = props.testId,
+      showActions = props.showActions,
+      inheritDimensions = props.inheritDimensions,
+      platform = props.platform,
+      embedIframeRef = props.embedIframeRef,
+      inlinePreloaderStyle = props.inlinePreloaderStyle,
+      createAnalyticsEvent = props.createAnalyticsEvent; // Wrapper around analytics.
 
-  var logError = function logError(error, info) {
+  var dispatchAnalytics = (0, _react.useCallback)(function (analyticsPayload) {
+    if (analyticsPayload && analyticsPayload.attributes) {
+      // Update if we haven't already set the display - possible
+      // in the case of `preview` which is rendered differently.
+      if (!analyticsPayload.attributes.display) {
+        analyticsPayload.attributes.display = appearance;
+      }
+    }
+
+    (0, _analytics.fireSmartLinkEvent)(analyticsPayload, createAnalyticsEvent);
+  }, [appearance, createAnalyticsEvent]);
+  var logError = (0, _react.useCallback)(function (error, info) {
     var componentStack = info.componentStack; // NB: APIErrors are thrown in response to Object Resolver Service.
     // In these cases, control is handed back to the Editor. We do not
     // fire an event for these, as they do not cover failed UI render events.
@@ -73,37 +98,7 @@ function CardWithURLRenderer(props) {
       (0, _ufoExperiences.failUfoExperience)('smart-link-authenticated', id);
       dispatchAnalytics((0, _analytics.uiRenderFailedEvent)(appearance, error, errorInfo));
     }
-  }; // Wrapper around analytics.
-
-
-  var dispatchAnalytics = function dispatchAnalytics(analyticsPayload) {
-    var appearance = props.appearance,
-        createAnalyticsEvent = props.createAnalyticsEvent;
-
-    if (analyticsPayload && analyticsPayload.attributes) {
-      // Update if we haven't already set the display - possible
-      // in the case of `preview` which is rendered differently.
-      if (!analyticsPayload.attributes.display) {
-        analyticsPayload.attributes.display = appearance;
-      }
-    }
-
-    (0, _analytics.fireSmartLinkEvent)(analyticsPayload, createAnalyticsEvent);
-  };
-
-  var url = props.url,
-      appearance = props.appearance,
-      isSelected = props.isSelected,
-      isFrameVisible = props.isFrameVisible,
-      onClick = props.onClick,
-      container = props.container,
-      onResolve = props.onResolve,
-      testId = props.testId,
-      showActions = props.showActions,
-      inheritDimensions = props.inheritDimensions,
-      platform = props.platform,
-      embedIframeRef = props.embedIframeRef,
-      inlinePreloaderStyle = props.inlinePreloaderStyle;
+  }, [appearance, dispatchAnalytics, id]);
 
   if (!url) {
     throw new Error('@atlaskit/smart-card: url property is missing.');

package/dist/es2019/version.json

@@ -1,5 +1,5 @@
 {
 	"name": "@atlaskit/smart-card",
-	"version": "16.2.0",
+	"version": "16.2.1",
 	"sideEffects": false
 }

package/dist/es2019/view/CardWithUrl/loader.js

@@ -1,4 +1,4 @@
-import React, { lazy, useEffect, useState, Suspense } from 'react';
+import React, { lazy, useEffect, useState, Suspense, useCallback } from 'react';
 import uuid from 'uuid';
 import { CardLinkView } from '@atlaskit/media-ui';
 import { uiRenderFailedEvent, fireSmartLinkEvent } from '../../utils/analytics';
@@ -22,8 +22,35 @@ export function CardWithURLRenderer(props) {
       clearMeasures(id);
     };
   }, [id]);
+  const {
+    url,
+    appearance,
+    isSelected,
+    isFrameVisible,
+    onClick,
+    container,
+    onResolve,
+    testId,
+    showActions,
+    inheritDimensions,
+    platform,
+    embedIframeRef,
+    inlinePreloaderStyle,
+    createAnalyticsEvent
+  } = props; // Wrapper around analytics.
 
-  const logError = (error, info) => {
+  const dispatchAnalytics = useCallback(analyticsPayload => {
+    if (analyticsPayload && analyticsPayload.attributes) {
+      // Update if we haven't already set the display - possible
+      // in the case of `preview` which is rendered differently.
+      if (!analyticsPayload.attributes.display) {
+        analyticsPayload.attributes.display = appearance;
+      }
+    }
+
+    fireSmartLinkEvent(analyticsPayload, createAnalyticsEvent);
+  }, [appearance, createAnalyticsEvent]);
+  const logError = useCallback((error, info) => {
     const {
       componentStack
     } = info; // NB: APIErrors are thrown in response to Object Resolver Service.
@@ -43,41 +70,7 @@ export function CardWithURLRenderer(props) {
       failUfoExperience('smart-link-authenticated', id);
       dispatchAnalytics(uiRenderFailedEvent(appearance, error, errorInfo));
     }
-  }; // Wrapper around analytics.
-
-
-  const dispatchAnalytics = analyticsPayload => {
-    const {
-      appearance,
-      createAnalyticsEvent
-    } = props;
-
-    if (analyticsPayload && analyticsPayload.attributes) {
-      // Update if we haven't already set the display - possible
-      // in the case of `preview` which is rendered differently.
-      if (!analyticsPayload.attributes.display) {
-        analyticsPayload.attributes.display = appearance;
-      }
-    }
-
-    fireSmartLinkEvent(analyticsPayload, createAnalyticsEvent);
-  };
-
-  const {
-    url,
-    appearance,
-    isSelected,
-    isFrameVisible,
-    onClick,
-    container,
-    onResolve,
-    testId,
-    showActions,
-    inheritDimensions,
-    platform,
-    embedIframeRef,
-    inlinePreloaderStyle
-  } = props;
+  }, [appearance, dispatchAnalytics, id]);
 
   if (!url) {
     throw new Error('@atlaskit/smart-card: url property is missing.');

package/dist/esm/version.json

@@ -1,5 +1,5 @@
 {
 	"name": "@atlaskit/smart-card",
-	"version": "16.2.0",
+	"version": "16.2.1",
 	"sideEffects": false
 }

package/dist/esm/view/CardWithUrl/loader.js

@@ -1,5 +1,5 @@
 import _slicedToArray from "@babel/runtime/helpers/slicedToArray";
-import React, { lazy, useEffect, useState, Suspense } from 'react';
+import React, { lazy, useEffect, useState, Suspense, useCallback } from 'react';
 import uuid from 'uuid';
 import { CardLinkView } from '@atlaskit/media-ui';
 import { uiRenderFailedEvent, fireSmartLinkEvent } from '../../utils/analytics';
@@ -30,8 +30,33 @@ export function CardWithURLRenderer(props) {
       clearMeasures(id);
     };
   }, [id]);
+  var url = props.url,
+      appearance = props.appearance,
+      isSelected = props.isSelected,
+      isFrameVisible = props.isFrameVisible,
+      onClick = props.onClick,
+      container = props.container,
+      onResolve = props.onResolve,
+      testId = props.testId,
+      showActions = props.showActions,
+      inheritDimensions = props.inheritDimensions,
+      platform = props.platform,
+      embedIframeRef = props.embedIframeRef,
+      inlinePreloaderStyle = props.inlinePreloaderStyle,
+      createAnalyticsEvent = props.createAnalyticsEvent; // Wrapper around analytics.
 
-  var logError = function logError(error, info) {
+  var dispatchAnalytics = useCallback(function (analyticsPayload) {
+    if (analyticsPayload && analyticsPayload.attributes) {
+      // Update if we haven't already set the display - possible
+      // in the case of `preview` which is rendered differently.
+      if (!analyticsPayload.attributes.display) {
+        analyticsPayload.attributes.display = appearance;
+      }
+    }
+
+    fireSmartLinkEvent(analyticsPayload, createAnalyticsEvent);
+  }, [appearance, createAnalyticsEvent]);
+  var logError = useCallback(function (error, info) {
     var componentStack = info.componentStack; // NB: APIErrors are thrown in response to Object Resolver Service.
     // In these cases, control is handed back to the Editor. We do not
     // fire an event for these, as they do not cover failed UI render events.
@@ -49,37 +74,7 @@ export function CardWithURLRenderer(props) {
       failUfoExperience('smart-link-authenticated', id);
       dispatchAnalytics(uiRenderFailedEvent(appearance, error, errorInfo));
     }
-  }; // Wrapper around analytics.
-
-
-  var dispatchAnalytics = function dispatchAnalytics(analyticsPayload) {
-    var appearance = props.appearance,
-        createAnalyticsEvent = props.createAnalyticsEvent;
-
-    if (analyticsPayload && analyticsPayload.attributes) {
-      // Update if we haven't already set the display - possible
-      // in the case of `preview` which is rendered differently.
-      if (!analyticsPayload.attributes.display) {
-        analyticsPayload.attributes.display = appearance;
-      }
-    }
-
-    fireSmartLinkEvent(analyticsPayload, createAnalyticsEvent);
-  };
-
-  var url = props.url,
-      appearance = props.appearance,
-      isSelected = props.isSelected,
-      isFrameVisible = props.isFrameVisible,
-      onClick = props.onClick,
-      container = props.container,
-      onResolve = props.onResolve,
-      testId = props.testId,
-      showActions = props.showActions,
-      inheritDimensions = props.inheritDimensions,
-      platform = props.platform,
-      embedIframeRef = props.embedIframeRef,
-      inlinePreloaderStyle = props.inlinePreloaderStyle;
+  }, [appearance, dispatchAnalytics, id]);
 
   if (!url) {
     throw new Error('@atlaskit/smart-card: url property is missing.');

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@atlaskit/smart-card",
-  "version": "16.2.0",
+  "version": "16.2.1",
   "description": "Smart card component",
   "publishConfig": {
     "registry": "https://registry.npmjs.org/"