@atlaskit/select 20.0.6 → 20.0.8

package/CHANGELOG.md

@@ -1,5 +1,23 @@
 # @atlaskit/select
 
+## 20.0.8
+
+### Patch Changes
+
+- [#131835](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/pull-requests/131835)
+  [`11b3a9f6a407e`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/11b3a9f6a407e) -
+  [Popup Select] Improve assistive technology support by reducing reliance on live regions.
+- Updated dependencies
+
+## 20.0.7
+
+### Patch Changes
+
+- [#127093](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/pull-requests/127093)
+  [`1378ea7a99ce1`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/1378ea7a99ce1) -
+  Upgrades `jscodeshift` to handle generics properly.
+- Updated dependencies
+
 ## 20.0.6
 
 ### Patch Changes

package/codemods/__tests__/next-select-props.tsx

@@ -30,7 +30,7 @@ describe('Update Select props', () => {
 			import Foo from '@atlaskit/select';
 
 			const App = () => {
-				return <Foo />;
+				return (<Foo />);
 			};
 		`,
 		'should remove all deleted props with aliased import name',
@@ -113,7 +113,7 @@ describe('Update Select props', () => {
 				import ${variant} from '@atlaskit/select';
 
 				const App = () => {
-					return <${identifier} />;
+					return (<${identifier} />);
 				};
       		`,
 			`should remove all deleted props for ${identifier} `,
@@ -291,7 +291,7 @@ describe('Update Select props', () => {
 				import ${identifier === 'Select' ? `Ak${identifier}` : `{${identifier} as Ak${identifier}}`} from '@atlaskit/select';
 
 				const App = () => {
-					return <Ak${identifier} />;
+					return (<Ak${identifier} />);
 				};
       		`,
 			`should handle named imports for ${identifier} `,

package/dist/cjs/PopupSelect/PopupSelect.js

@@ -34,7 +34,7 @@ function _interopRequireWildcard(e, r) { if (!r && e && e.__esModule) return e;
 function ownKeys(e, r) { var t = Object.keys(e); if (Object.getOwnPropertySymbols) { var o = Object.getOwnPropertySymbols(e); r && (o = o.filter(function (r) { return Object.getOwnPropertyDescriptor(e, r).enumerable; })), t.push.apply(t, o); } return t; }
 function _objectSpread(e) { for (var r = 1; r < arguments.length; r++) { var t = null != arguments[r] ? arguments[r] : {}; r % 2 ? ownKeys(Object(t), !0).forEach(function (r) { (0, _defineProperty2.default)(e, r, t[r]); }) : Object.getOwnPropertyDescriptors ? Object.defineProperties(e, Object.getOwnPropertyDescriptors(t)) : ownKeys(Object(t)).forEach(function (r) { Object.defineProperty(e, r, Object.getOwnPropertyDescriptor(t, r)); }); } return e; }
 function _callSuper(t, o, e) { return o = (0, _getPrototypeOf2.default)(o), (0, _possibleConstructorReturn2.default)(t, _isNativeReflectConstruct() ? Reflect.construct(o, e || [], (0, _getPrototypeOf2.default)(t).constructor) : o.apply(t, e)); }
-function _isNativeReflectConstruct() { try { var t = !Boolean.prototype.valueOf.call(Reflect.construct(Boolean, [], function () {})); } catch (t) {} return (_isNativeReflectConstruct = function _isNativeReflectConstruct() { return !!t; })(); } // eslint-disable-next-line @repo/internal/fs/filename-pattern-match
+function _isNativeReflectConstruct() { try { var t = !Boolean.prototype.valueOf.call(Reflect.construct(Boolean, [], function () {})); } catch (t) {} return (_isNativeReflectConstruct = function _isNativeReflectConstruct() { return !!t; })(); } /* eslint-disable @atlaskit/platform/ensure-feature-flag-prefix */ // eslint-disable-next-line @repo/internal/fs/filename-pattern-match
 /**
  * Are we rendering on the client or server?
  */
@@ -355,6 +355,7 @@ var PopupSelect = exports.default = /*#__PURE__*/function (_PureComponent) {
         if ((_this$selectRef = _this.selectRef) !== null && _this$selectRef !== void 0 && (_this$selectRef = _this$selectRef.select) !== null && _this$selectRef !== void 0 && _this$selectRef.inputRef) {
           var _this$selectRef2;
           if (providedAriaLabel) {
+            // I might want to use a comma instead of a period here, when the feature flag is removed.
             ariaLabelText = "".concat(providedAriaLabel, ". ").concat(ariaLabelText);
           }
           (_this$selectRef2 = _this.selectRef) === null || _this$selectRef2 === void 0 || (_this$selectRef2 = _this$selectRef2.select.inputRef) === null || _this$selectRef2 === void 0 || _this$selectRef2.setAttribute('aria-label', ariaLabelText);
@@ -369,7 +370,7 @@ var PopupSelect = exports.default = /*#__PURE__*/function (_PureComponent) {
           return option === focused;
         })) !== null && _options$findIndex !== void 0 ? _options$findIndex : 0;
         var optionName = typeof (props === null || props === void 0 ? void 0 : props.getOptionLabel) === 'function' ? props.getOptionLabel(focused) : focused.label;
-        var ariaLabelText = (0, _platformFeatureFlags.fg)('design_system_select-a11y-improvement') ? "".concat(optionName) : "Option ".concat(optionName, " focused, ").concat(optionIndex + 1, " of ").concat(totalLength, ".\n\t\t\t").concat(totalLength, " results available.\n\t\t\t").concat(ariaLabelSuffix, "\n\t\t\t");
+        var ariaLabelText = (0, _platformFeatureFlags.fg)('design_system_select-a11y-improvement') ? "".concat(optionName, ", (").concat(optionIndex + 1, " of ").concat(totalLength, ")") : "Option ".concat(optionName, " focused, ").concat(optionIndex + 1, " of ").concat(totalLength, ".\n\t\t\t").concat(totalLength, " results available.\n\t\t\t").concat(ariaLabelSuffix, "\n\t\t\t");
         // Option LABEL focused, 1 of 8. 8 results available.
         // Use Up and Down to choose options, press Enter to select the currently focused option,
         // press Escape to exit the menu.
@@ -389,7 +390,11 @@ var PopupSelect = exports.default = /*#__PURE__*/function (_PureComponent) {
             ariaLabelText = generateNoGroupsAriaText(onFocusProps, ariaLabelSuffix);
             ariaLiveMessage = ariaLabelText;
           }
-          updateInputAriaLabel(ariaLabelText);
+          // Safari still does not announce the first option when menu is opened, so forcing a change to the input label
+          // will include the first option in the initial announcement.
+          if (!(0, _platformFeatureFlags.fg)('design_system_select-a11y-improvement') || (0, _deviceCheck.isSafari)() && (0, _platformFeatureFlags.fg)('design_system_select-a11y-improvement')) {
+            updateInputAriaLabel(ariaLabelText);
+          }
           return ariaLiveMessage;
         }
         return ariaLiveMessage;

package/dist/cjs/Select.js

@@ -11,7 +11,7 @@ var _createSelect = _interopRequireDefault(require("./createSelect"));
 /* eslint-disable @repo/internal/react/require-jsdoc */
 
 var packageName = "@atlaskit/select";
-var packageVersion = "20.0.6";
+var packageVersion = "20.0.8";
 var SelectWithoutAnalytics = exports.SelectWithoutAnalytics = (0, _createSelect.default)(_async.default);
 var createAndFireEventOnAtlaskit = (0, _analyticsNext.createAndFireEvent)('atlaskit');
 var Select = (0, _analyticsNext.withAnalyticsContext)({

package/dist/es2019/PopupSelect/PopupSelect.js

@@ -1,5 +1,6 @@
 import _extends from "@babel/runtime/helpers/extends";
 import _defineProperty from "@babel/runtime/helpers/defineProperty";
+/* eslint-disable @atlaskit/platform/ensure-feature-flag-prefix */
 // eslint-disable-next-line @repo/internal/fs/filename-pattern-match
 import React, { PureComponent } from 'react';
 import { bind } from 'bind-event-listener';
@@ -7,7 +8,7 @@ import { createPortal } from 'react-dom';
 import FocusLock from 'react-focus-lock';
 import { Manager, Popper, Reference } from 'react-popper';
 import { shallowEqualObjects } from 'shallow-equal';
-import { isAppleDevice } from '@atlaskit/ds-lib/device-check';
+import { isAppleDevice, isSafari } from '@atlaskit/ds-lib/device-check';
 import { IdProvider } from '@atlaskit/ds-lib/use-id';
 import { fg } from '@atlaskit/platform-feature-flags';
 import { mergeStyles } from '@atlaskit/react-select';
@@ -333,6 +334,7 @@ export default class PopupSelect extends PureComponent {
         if ((_this$selectRef = this.selectRef) !== null && _this$selectRef !== void 0 && (_this$selectRef$selec3 = _this$selectRef.select) !== null && _this$selectRef$selec3 !== void 0 && _this$selectRef$selec3.inputRef) {
           var _this$selectRef2, _this$selectRef2$sele;
           if (providedAriaLabel) {
+            // I might want to use a comma instead of a period here, when the feature flag is removed.
             ariaLabelText = `${providedAriaLabel}. ${ariaLabelText}`;
           }
           (_this$selectRef2 = this.selectRef) === null || _this$selectRef2 === void 0 ? void 0 : (_this$selectRef2$sele = _this$selectRef2.select.inputRef) === null || _this$selectRef2$sele === void 0 ? void 0 : _this$selectRef2$sele.setAttribute('aria-label', ariaLabelText);
@@ -347,7 +349,7 @@ export default class PopupSelect extends PureComponent {
         const totalLength = options === null || options === void 0 ? void 0 : options.length;
         const optionIndex = (_options$findIndex = options === null || options === void 0 ? void 0 : options.findIndex(option => option === focused)) !== null && _options$findIndex !== void 0 ? _options$findIndex : 0;
         const optionName = typeof (props === null || props === void 0 ? void 0 : props.getOptionLabel) === 'function' ? props.getOptionLabel(focused) : focused.label;
-        const ariaLabelText = fg('design_system_select-a11y-improvement') ? `${optionName}` : `Option ${optionName} focused, ${optionIndex + 1} of ${totalLength}.
+        const ariaLabelText = fg('design_system_select-a11y-improvement') ? `${optionName}, (${optionIndex + 1} of ${totalLength})` : `Option ${optionName} focused, ${optionIndex + 1} of ${totalLength}.
 			${totalLength} results available.
 			${ariaLabelSuffix}
 			`;
@@ -370,7 +372,11 @@ export default class PopupSelect extends PureComponent {
             ariaLabelText = generateNoGroupsAriaText(onFocusProps, ariaLabelSuffix);
             ariaLiveMessage = ariaLabelText;
           }
-          updateInputAriaLabel(ariaLabelText);
+          // Safari still does not announce the first option when menu is opened, so forcing a change to the input label
+          // will include the first option in the initial announcement.
+          if (!fg('design_system_select-a11y-improvement') || isSafari() && fg('design_system_select-a11y-improvement')) {
+            updateInputAriaLabel(ariaLabelText);
+          }
           return ariaLiveMessage;
         }
         return ariaLiveMessage;

package/dist/es2019/Select.js

@@ -3,7 +3,7 @@ import { createAndFireEvent, withAnalyticsContext, withAnalyticsEvents } from '@
 import AsyncSelect from '@atlaskit/react-select/async';
 import createSelect from './createSelect';
 const packageName = "@atlaskit/select";
-const packageVersion = "20.0.6";
+const packageVersion = "20.0.8";
 export const SelectWithoutAnalytics = createSelect(AsyncSelect);
 const createAndFireEventOnAtlaskit = createAndFireEvent('atlaskit');
 const Select = withAnalyticsContext({

package/dist/esm/PopupSelect/PopupSelect.js

@@ -11,6 +11,7 @@ function ownKeys(e, r) { var t = Object.keys(e); if (Object.getOwnPropertySymbol
 function _objectSpread(e) { for (var r = 1; r < arguments.length; r++) { var t = null != arguments[r] ? arguments[r] : {}; r % 2 ? ownKeys(Object(t), !0).forEach(function (r) { _defineProperty(e, r, t[r]); }) : Object.getOwnPropertyDescriptors ? Object.defineProperties(e, Object.getOwnPropertyDescriptors(t)) : ownKeys(Object(t)).forEach(function (r) { Object.defineProperty(e, r, Object.getOwnPropertyDescriptor(t, r)); }); } return e; }
 function _callSuper(t, o, e) { return o = _getPrototypeOf(o), _possibleConstructorReturn(t, _isNativeReflectConstruct() ? Reflect.construct(o, e || [], _getPrototypeOf(t).constructor) : o.apply(t, e)); }
 function _isNativeReflectConstruct() { try { var t = !Boolean.prototype.valueOf.call(Reflect.construct(Boolean, [], function () {})); } catch (t) {} return (_isNativeReflectConstruct = function _isNativeReflectConstruct() { return !!t; })(); }
+/* eslint-disable @atlaskit/platform/ensure-feature-flag-prefix */
 // eslint-disable-next-line @repo/internal/fs/filename-pattern-match
 import React, { PureComponent } from 'react';
 import { bind } from 'bind-event-listener';
@@ -18,7 +19,7 @@ import { createPortal } from 'react-dom';
 import FocusLock from 'react-focus-lock';
 import { Manager, Popper, Reference } from 'react-popper';
 import { shallowEqualObjects } from 'shallow-equal';
-import { isAppleDevice } from '@atlaskit/ds-lib/device-check';
+import { isAppleDevice, isSafari } from '@atlaskit/ds-lib/device-check';
 import { IdProvider } from '@atlaskit/ds-lib/use-id';
 import { fg } from '@atlaskit/platform-feature-flags';
 import { mergeStyles } from '@atlaskit/react-select';
@@ -346,6 +347,7 @@ var PopupSelect = /*#__PURE__*/function (_PureComponent) {
         if ((_this$selectRef = _this.selectRef) !== null && _this$selectRef !== void 0 && (_this$selectRef = _this$selectRef.select) !== null && _this$selectRef !== void 0 && _this$selectRef.inputRef) {
           var _this$selectRef2;
           if (providedAriaLabel) {
+            // I might want to use a comma instead of a period here, when the feature flag is removed.
             ariaLabelText = "".concat(providedAriaLabel, ". ").concat(ariaLabelText);
           }
           (_this$selectRef2 = _this.selectRef) === null || _this$selectRef2 === void 0 || (_this$selectRef2 = _this$selectRef2.select.inputRef) === null || _this$selectRef2 === void 0 || _this$selectRef2.setAttribute('aria-label', ariaLabelText);
@@ -360,7 +362,7 @@ var PopupSelect = /*#__PURE__*/function (_PureComponent) {
           return option === focused;
         })) !== null && _options$findIndex !== void 0 ? _options$findIndex : 0;
         var optionName = typeof (props === null || props === void 0 ? void 0 : props.getOptionLabel) === 'function' ? props.getOptionLabel(focused) : focused.label;
-        var ariaLabelText = fg('design_system_select-a11y-improvement') ? "".concat(optionName) : "Option ".concat(optionName, " focused, ").concat(optionIndex + 1, " of ").concat(totalLength, ".\n\t\t\t").concat(totalLength, " results available.\n\t\t\t").concat(ariaLabelSuffix, "\n\t\t\t");
+        var ariaLabelText = fg('design_system_select-a11y-improvement') ? "".concat(optionName, ", (").concat(optionIndex + 1, " of ").concat(totalLength, ")") : "Option ".concat(optionName, " focused, ").concat(optionIndex + 1, " of ").concat(totalLength, ".\n\t\t\t").concat(totalLength, " results available.\n\t\t\t").concat(ariaLabelSuffix, "\n\t\t\t");
         // Option LABEL focused, 1 of 8. 8 results available.
         // Use Up and Down to choose options, press Enter to select the currently focused option,
         // press Escape to exit the menu.
@@ -380,7 +382,11 @@ var PopupSelect = /*#__PURE__*/function (_PureComponent) {
             ariaLabelText = generateNoGroupsAriaText(onFocusProps, ariaLabelSuffix);
             ariaLiveMessage = ariaLabelText;
           }
-          updateInputAriaLabel(ariaLabelText);
+          // Safari still does not announce the first option when menu is opened, so forcing a change to the input label
+          // will include the first option in the initial announcement.
+          if (!fg('design_system_select-a11y-improvement') || isSafari() && fg('design_system_select-a11y-improvement')) {
+            updateInputAriaLabel(ariaLabelText);
+          }
           return ariaLiveMessage;
         }
         return ariaLiveMessage;

package/dist/esm/Select.js

@@ -3,7 +3,7 @@ import { createAndFireEvent, withAnalyticsContext, withAnalyticsEvents } from '@
 import AsyncSelect from '@atlaskit/react-select/async';
 import createSelect from './createSelect';
 var packageName = "@atlaskit/select";
-var packageVersion = "20.0.6";
+var packageVersion = "20.0.8";
 export var SelectWithoutAnalytics = createSelect(AsyncSelect);
 var createAndFireEventOnAtlaskit = createAndFireEvent('atlaskit');
 var Select = withAnalyticsContext({

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@atlaskit/select",
-	"version": "20.0.6",
+	"version": "20.0.8",
 	"description": "Select allows users to make a single selection or multiple selections from a list of options.",
 	"publishConfig": {
 		"registry": "https://registry.npmjs.org/"
@@ -43,7 +43,7 @@
 	"dependencies": {
 		"@atlaskit/analytics-next": "^11.0.0",
 		"@atlaskit/ds-lib": "^4.0.0",
-		"@atlaskit/icon": "^25.0.0",
+		"@atlaskit/icon": "^25.1.0",
 		"@atlaskit/platform-feature-flags": "^1.1.0",
 		"@atlaskit/primitives": "^14.2.0",
 		"@atlaskit/react-select": "^2.0.0",
@@ -74,7 +74,7 @@
 		"@atlaskit/form": "^12.0.0",
 		"@atlaskit/link": "^3.0.0",
 		"@atlaskit/logo": "^16.0.0",
-		"@atlaskit/modal-dialog": "^13.4.0",
+		"@atlaskit/modal-dialog": "^14.0.0",
 		"@atlaskit/radio": "^8.0.0",
 		"@atlaskit/section-message": "^8.2.0",
 		"@atlaskit/ssr": "^0.4.0",
@@ -82,7 +82,7 @@
 		"@testing-library/user-event": "^14.4.3",
 		"ast-types": "^0.13.3",
 		"jest-in-case": "^1.0.2",
-		"jscodeshift": "^0.13.0",
+		"jscodeshift": "^17.0.0",
 		"react-dom": "^18.2.0",
 		"react-select-event": "^5.5.0",
 		"typescript": "~5.4.2"