@atlaskit/select 18.1.1 → 18.1.2

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
package/CHANGELOG.md CHANGED
@@ -1,5 +1,15 @@
1
1
  # @atlaskit/select
2
2
 
3
+ ## 18.1.2
4
+
5
+ ### Patch Changes
6
+
7
+ - [#153221](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/pull-requests/153221)
8
+ [`e362b41d4b35f`](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/commits/e362b41d4b35f) -
9
+ This version removes `tab-event-should-close-popupSelect` feature flag. Tab and Shift+Tab now
10
+ dismisses the list of opened popup select options and allows users to navigate to next or previous
11
+ elements accordingly.
12
+
3
13
  ## 18.1.1
4
14
 
5
15
  ### Patch Changes
@@ -121,11 +121,9 @@ var PopupSelect = exports.default = /*#__PURE__*/function (_PureComponent) {
121
121
  });
122
122
  (0, _defineProperty2.default)((0, _assertThisInitialized2.default)(_this), "handleKeyDown", function (event) {
123
123
  //We shouldn't close PopupSelect on tab event if there are custom interactive element.
124
- if ((0, _platformFeatureFlags.fg)('tab-event-should-close-popupSelect')) {
125
- var tabEvent = event.key === 'Tab' && event.shiftKey || event.key === 'Tab';
126
- if (_this.props.shouldCloseMenuOnTab && tabEvent) {
127
- _this.close();
128
- }
124
+ var tabEvent = event.key === 'Tab' && event.shiftKey || event.key === 'Tab';
125
+ if (_this.props.shouldCloseMenuOnTab && tabEvent) {
126
+ _this.close();
129
127
  }
130
128
  switch (event.key) {
131
129
  case 'Escape':
@@ -11,7 +11,7 @@ var _createSelect = _interopRequireDefault(require("./createSelect"));
11
11
  /* eslint-disable @repo/internal/react/require-jsdoc */
12
12
 
13
13
  var packageName = "@atlaskit/select";
14
- var packageVersion = "18.1.1";
14
+ var packageVersion = "18.1.2";
15
15
  var SelectWithoutAnalytics = exports.SelectWithoutAnalytics = (0, _createSelect.default)(_reactSelect.default);
16
16
  var createAndFireEventOnAtlaskit = (0, _analyticsNext.createAndFireEvent)('atlaskit');
17
17
  var Select = (0, _analyticsNext.withAnalyticsContext)({
@@ -88,11 +88,9 @@ export default class PopupSelect extends PureComponent {
88
88
  });
89
89
  _defineProperty(this, "handleKeyDown", event => {
90
90
  //We shouldn't close PopupSelect on tab event if there are custom interactive element.
91
- if (fg('tab-event-should-close-popupSelect')) {
92
- const tabEvent = event.key === 'Tab' && event.shiftKey || event.key === 'Tab';
93
- if (this.props.shouldCloseMenuOnTab && tabEvent) {
94
- this.close();
95
- }
91
+ const tabEvent = event.key === 'Tab' && event.shiftKey || event.key === 'Tab';
92
+ if (this.props.shouldCloseMenuOnTab && tabEvent) {
93
+ this.close();
96
94
  }
97
95
  switch (event.key) {
98
96
  case 'Escape':
@@ -3,7 +3,7 @@ import { createAndFireEvent, withAnalyticsContext, withAnalyticsEvents } from '@
3
3
  import ReactSelect from '@atlaskit/react-select';
4
4
  import createSelect from './createSelect';
5
5
  const packageName = "@atlaskit/select";
6
- const packageVersion = "18.1.1";
6
+ const packageVersion = "18.1.2";
7
7
  export const SelectWithoutAnalytics = createSelect(ReactSelect);
8
8
  const createAndFireEventOnAtlaskit = createAndFireEvent('atlaskit');
9
9
  const Select = withAnalyticsContext({
@@ -112,11 +112,9 @@ var PopupSelect = /*#__PURE__*/function (_PureComponent) {
112
112
  });
113
113
  _defineProperty(_assertThisInitialized(_this), "handleKeyDown", function (event) {
114
114
  //We shouldn't close PopupSelect on tab event if there are custom interactive element.
115
- if (fg('tab-event-should-close-popupSelect')) {
116
- var tabEvent = event.key === 'Tab' && event.shiftKey || event.key === 'Tab';
117
- if (_this.props.shouldCloseMenuOnTab && tabEvent) {
118
- _this.close();
119
- }
115
+ var tabEvent = event.key === 'Tab' && event.shiftKey || event.key === 'Tab';
116
+ if (_this.props.shouldCloseMenuOnTab && tabEvent) {
117
+ _this.close();
120
118
  }
121
119
  switch (event.key) {
122
120
  case 'Escape':
@@ -3,7 +3,7 @@ import { createAndFireEvent, withAnalyticsContext, withAnalyticsEvents } from '@
3
3
  import ReactSelect from '@atlaskit/react-select';
4
4
  import createSelect from './createSelect';
5
5
  var packageName = "@atlaskit/select";
6
- var packageVersion = "18.1.1";
6
+ var packageVersion = "18.1.2";
7
7
  export var SelectWithoutAnalytics = createSelect(ReactSelect);
8
8
  var createAndFireEventOnAtlaskit = createAndFireEvent('atlaskit');
9
9
  var Select = withAnalyticsContext({
package/package.json CHANGED
@@ -1,6 +1,6 @@
1
1
  {
2
2
  "name": "@atlaskit/select",
3
- "version": "18.1.1",
3
+ "version": "18.1.2",
4
4
  "description": "Select allows users to make a single selection or multiple selections from a list of options.",
5
5
  "publishConfig": {
6
6
  "registry": "https://registry.npmjs.org/"
@@ -45,7 +45,7 @@
45
45
  "@atlaskit/primitives": "^12.2.0",
46
46
  "@atlaskit/react-select": "^1.0.1",
47
47
  "@atlaskit/spinner": "^16.3.0",
48
- "@atlaskit/theme": "^13.0.0",
48
+ "@atlaskit/theme": "^13.1.0",
49
49
  "@atlaskit/tokens": "^2.0.0",
50
50
  "@atlaskit/visually-hidden": "^1.5.0",
51
51
  "@babel/runtime": "^7.0.0",
@@ -108,9 +108,6 @@
108
108
  "platform-visual-refresh-icons-legacy-facade": {
109
109
  "type": "boolean"
110
110
  },
111
- "tab-event-should-close-popupSelect": {
112
- "type": "boolean"
113
- },
114
111
  "platform_dst_select-bump-react-focus-lock": {
115
112
  "type": "boolean"
116
113
  }