@atlaskit/select 17.10.3 → 17.11.0

package/CHANGELOG.md

@@ -1,5 +1,26 @@
 # @atlaskit/select
 
+## 17.11.0
+
+### Minor Changes
+
+- [#110836](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/pull-requests/110836)
+  [`a8bd419fd70b9`](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/commits/a8bd419fd70b9) -
+  Explicitly set jsxRuntime to classic via pragma comments in order to avoid issues where jsxRuntime
+  is implicitly set to automatic.
+
+### Patch Changes
+
+- Updated dependencies
+
+## 17.10.4
+
+### Patch Changes
+
+- [#111724](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/pull-requests/111724)
+  [`c260b95b219de`](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/commits/c260b95b219de) -
+  Update react-select typescript module augmentation path
+
 ## 17.10.3
 
 ### Patch Changes
@@ -29,7 +50,7 @@
 
 - [#104208](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/pull-requests/104208)
   [`0d4480895db7`](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/commits/0d4480895db7) -
-  Add support for React 18.
+  Add support for React 18 in non-strict mode.
 
 ## 17.9.0
 

package/README.md

@@ -1,6 +1,7 @@
 # Select
 
-Select gives users the ability to make a single selection, or multiple selections from a number of options.
+Select gives users the ability to make a single selection, or multiple selections from a number of
+options.
 
 ## Installation
 

package/__perf__/default.tsx

@@ -2,14 +2,14 @@ import React from 'react';
 import Select from '../src';
 
 const options = [
-  { label: 'Adelaide', value: 'adelaide' },
-  { label: 'Brisbane', value: 'brisbane' },
-  { label: 'Canberra', value: 'canberra' },
-  { label: 'Darwin', value: 'darwin' },
-  { label: 'Hobart', value: 'hobart' },
-  { label: 'Melbourne', value: 'melbourne' },
-  { label: 'Perth', value: 'perth' },
-  { label: 'Sydney', value: 'sydney' },
+	{ label: 'Adelaide', value: 'adelaide' },
+	{ label: 'Brisbane', value: 'brisbane' },
+	{ label: 'Canberra', value: 'canberra' },
+	{ label: 'Darwin', value: 'darwin' },
+	{ label: 'Hobart', value: 'hobart' },
+	{ label: 'Melbourne', value: 'melbourne' },
+	{ label: 'Perth', value: 'perth' },
+	{ label: 'Sydney', value: 'sydney' },
 ];
 
 export default () => <Select options={options} placeholder="Choose a City" />;

package/codemods/13.0.0-popper-props.ts

@@ -1,71 +1,62 @@
 import {
-  addCommentToStartOfFile,
-  getJSXAttributesByName,
-  getSpecifierName,
-  hasImportDeclaration,
-  isUsingProp,
+	addCommentToStartOfFile,
+	getJSXAttributesByName,
+	getSpecifierName,
+	hasImportDeclaration,
+	isUsingProp,
 } from './utils/helpers';
 
 import {
-  type default as core,
-  type API,
-  type ASTPath,
-  type FileInfo,
-  type JSXElement,
-  type Options,
+	type default as core,
+	type API,
+	type ASTPath,
+	type FileInfo,
+	type JSXElement,
+	type Options,
 } from 'jscodeshift';
 import { type Collection } from 'jscodeshift/src/Collection';
 
-function updatePopperProps(
-  j: core.JSCodeshift,
-  source: Collection<any>,
-  specifier: string,
-) {
-  source.findJSXElements(specifier).forEach((path: ASTPath<JSXElement>) => {
-    if (
-      isUsingProp({
-        j,
-        base: source,
-        element: path,
-        propName: 'popperProps',
-      })
-    ) {
-      // Get value from prop
-      getJSXAttributesByName({
-        j,
-        element: path,
-        attributeName: 'popperProps',
-      }).forEach((attribute) => {
-        // convert positionFixed
-        j(attribute)
-          .find(j.JSXExpressionContainer)
-          .find(j.ObjectExpression)
-          .find(j.ObjectProperty)
-          // @ts-ignore
-          .filter((property) => property.node.key.name === 'positionFixed')
-          .forEach((property) => {
-            // @ts-ignore
-            const strategy = property.node.value.value ? 'fixed' : 'absolute';
-            property.replace(
-              j.objectProperty(
-                j.identifier('strategy'),
-                j.stringLiteral(strategy),
-              ),
-            );
-          });
+function updatePopperProps(j: core.JSCodeshift, source: Collection<any>, specifier: string) {
+	source.findJSXElements(specifier).forEach((path: ASTPath<JSXElement>) => {
+		if (
+			isUsingProp({
+				j,
+				base: source,
+				element: path,
+				propName: 'popperProps',
+			})
+		) {
+			// Get value from prop
+			getJSXAttributesByName({
+				j,
+				element: path,
+				attributeName: 'popperProps',
+			}).forEach((attribute) => {
+				// convert positionFixed
+				j(attribute)
+					.find(j.JSXExpressionContainer)
+					.find(j.ObjectExpression)
+					.find(j.ObjectProperty)
+					// @ts-ignore
+					.filter((property) => property.node.key.name === 'positionFixed')
+					.forEach((property) => {
+						// @ts-ignore
+						const strategy = property.node.value.value ? 'fixed' : 'absolute';
+						property.replace(j.objectProperty(j.identifier('strategy'), j.stringLiteral(strategy)));
+					});
 
-        // warn about modifiers prop
-        j(attribute)
-          .find(j.JSXExpressionContainer)
-          .find(j.ObjectExpression)
-          .find(j.ObjectProperty)
-          //@ts-ignore
-          .filter((property) => property.node.key.name === 'modifiers')
-          .forEach(() => {
-            addCommentToStartOfFile({
-              j,
-              base: source,
-              message: `
+				// warn about modifiers prop
+				j(attribute)
+					.find(j.JSXExpressionContainer)
+					.find(j.ObjectExpression)
+					.find(j.ObjectProperty)
+					//@ts-ignore
+					.filter((property) => property.node.key.name === 'modifiers')
+					.forEach(() => {
+						addCommentToStartOfFile({
+							j,
+							base: source,
+							message: `
                 Popper.js has been upgraded from 1.14.1 to 2.4.2,
                 and as a result the modifier prop has changed significantly. The format has been
                 changed from object of objects, to array of objects, with the key for each modifier
@@ -73,39 +64,35 @@ function updatePopperProps(
                 pair for configuration and other changes unique to each modifier.
                 Further details can be found in the popper docs: https://popper.js.org/docs/v2/modifiers/
                 `,
-            });
-          });
-      });
-    }
-  });
+						});
+					});
+			});
+		}
+	});
 }
 
-export default function transformer(
-  file: FileInfo,
-  { jscodeshift: j }: API,
-  options: Options,
-) {
-  const source = j(file.source);
+export default function transformer(file: FileInfo, { jscodeshift: j }: API, options: Options) {
+	const source = j(file.source);
 
-  // Exit early if not relevant
-  // We are doing this so we don't touch the formatting of unrelated files
-  if (!hasImportDeclaration(j, file.source, '@atlaskit/select')) {
-    return file.source;
-  }
+	// Exit early if not relevant
+	// We are doing this so we don't touch the formatting of unrelated files
+	if (!hasImportDeclaration(j, file.source, '@atlaskit/select')) {
+		return file.source;
+	}
 
-  // Get imported name for the component
-  const specifier = getSpecifierName({
-    j,
-    base: source,
-    packageName: '@atlaskit/select',
-    component: 'PopupSelect',
-  });
-  if (!specifier) {
-    return file.source;
-  }
+	// Get imported name for the component
+	const specifier = getSpecifierName({
+		j,
+		base: source,
+		packageName: '@atlaskit/select',
+		component: 'PopupSelect',
+	});
+	if (!specifier) {
+		return file.source;
+	}
 
-  // Convert boundaries prop
-  updatePopperProps(j, source, specifier);
+	// Convert boundaries prop
+	updatePopperProps(j, source, specifier);
 
-  return source.toSource(options.printOptions || { quote: 'single' });
+	return source.toSource(options.printOptions || { quote: 'single' });
 }

package/codemods/__tests__/13.0.0-popper-props.ts

@@ -5,43 +5,43 @@ import transformer from '../13.0.0-popper-props';
 const applyTransform = require('jscodeshift/dist/testUtils').applyTransform;
 
 type TestArgs = {
-  it: string;
-  original: string;
-  expected: string;
-  mode?: 'only' | 'skip';
-  before?: () => void;
-  after?: () => void;
+	it: string;
+	original: string;
+	expected: string;
+	mode?: 'only' | 'skip';
+	before?: () => void;
+	after?: () => void;
 };
 
 function noop() {}
 
 function check({
-  it: name,
-  original,
-  expected,
-  before = noop,
-  after = noop,
-  mode = undefined,
+	it: name,
+	original,
+	expected,
+	before = noop,
+	after = noop,
+	mode = undefined,
 }: TestArgs) {
-  const run = mode === 'only' ? it.only : mode === 'skip' ? it.skip : it;
-
-  run(name, () => {
-    before();
-    try {
-      const output: string = applyTransform(
-        { default: transformer, parser: 'tsx' },
-        {},
-        { source: original },
-      );
-      expect(output).toBe(expected.trim());
-    } catch (e) {
-      // a failed assertion will throw
-      after();
-      throw e;
-    }
-    // will only be hit if we don't throw
-    after();
-  });
+	const run = mode === 'only' ? it.only : mode === 'skip' ? it.skip : it;
+
+	run(name, () => {
+		before();
+		try {
+			const output: string = applyTransform(
+				{ default: transformer, parser: 'tsx' },
+				{},
+				{ source: original },
+			);
+			expect(output).toBe(expected.trim());
+		} catch (e) {
+			// a failed assertion will throw
+			after();
+			throw e;
+		}
+		// will only be hit if we don't throw
+		after();
+	});
 }
 
 /**
@@ -50,9 +50,9 @@ function check({
 */
 
 describe('Convert positionFixed:boolean to strategy:"fixed"|"absolute"', () => {
-  check({
-    it: 'Convert `positionFixed: true` to `strategy: "fixed"`',
-    original: `
+	check({
+		it: 'Convert `positionFixed: true` to `strategy: "fixed"`',
+		original: `
       import { PopupSelect } from '@atlaskit/select';
 
       export default () => (
@@ -71,7 +71,7 @@ describe('Convert positionFixed:boolean to strategy:"fixed"|"absolute"', () => {
         />
       );
     `,
-    expected: `
+		expected: `
       import { PopupSelect } from '@atlaskit/select';
 
       export default () => (
@@ -90,11 +90,11 @@ describe('Convert positionFixed:boolean to strategy:"fixed"|"absolute"', () => {
         />
       );
     `,
-  });
+	});
 
-  check({
-    it: 'Convert `positionFixed: {something truthy}` to `strategy: "fixed"`',
-    original: `
+	check({
+		it: 'Convert `positionFixed: {something truthy}` to `strategy: "fixed"`',
+		original: `
       import { PopupSelect } from '@atlaskit/select';
 
       export default () => (
@@ -113,7 +113,7 @@ describe('Convert positionFixed:boolean to strategy:"fixed"|"absolute"', () => {
         />
       );
     `,
-    expected: `
+		expected: `
       import { PopupSelect } from '@atlaskit/select';
 
       export default () => (
@@ -132,11 +132,11 @@ describe('Convert positionFixed:boolean to strategy:"fixed"|"absolute"', () => {
         />
       );
     `,
-  });
+	});
 
-  check({
-    it: 'Convert `positionFixed: false` to `strategy:"absolute"`',
-    original: `
+	check({
+		it: 'Convert `positionFixed: false` to `strategy:"absolute"`',
+		original: `
       import { PopupSelect } from '@atlaskit/select';
 
       export default () => (
@@ -155,7 +155,7 @@ describe('Convert positionFixed:boolean to strategy:"fixed"|"absolute"', () => {
         />
       );
     `,
-    expected: `
+		expected: `
       import { PopupSelect } from '@atlaskit/select';
 
       export default () => (
@@ -174,7 +174,7 @@ describe('Convert positionFixed:boolean to strategy:"fixed"|"absolute"', () => {
         />
       );
     `,
-  });
+	});
 });
 
 /**
@@ -183,9 +183,9 @@ describe('Convert positionFixed:boolean to strategy:"fixed"|"absolute"', () => {
 */
 
 describe('Warn use of the `modifiers` prop', () => {
-  check({
-    it: 'should add warning comment when using the modifier prop in `popperProps`',
-    original: `
+	check({
+		it: 'should add warning comment when using the modifier prop in `popperProps`',
+		original: `
       import { PopupSelect } from '@atlaskit/select';
 
       export default () => (
@@ -204,7 +204,7 @@ describe('Warn use of the `modifiers` prop', () => {
         />
       );
     `,
-    expected: `
+		expected: `
     /* TODO: (from codemod) Popper.js has been upgraded from 1.14.1 to 2.4.2,
       and as a result the modifier prop has changed significantly. The format has been
       changed from object of objects, to array of objects, with the key for each modifier
@@ -229,5 +229,5 @@ describe('Warn use of the `modifiers` prop', () => {
         />
       );
     `,
-  });
+	});
 });