@atlaskit/renderer 140.2.7 → 140.2.8

package/CHANGELOG.md

@@ -1,5 +1,13 @@
 # @atlaskit/renderer
 
+## 140.2.8
+
+### Patch Changes
+
+- [`edc1eb0f84ed8`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/edc1eb0f84ed8) -
+  Clean up experiment `platform_editor_comment_on_bodied_extensions`
+- Updated dependencies
+
 ## 140.2.7
 
 ### Patch Changes

package/dist/cjs/react/index.js

@@ -14,7 +14,6 @@ var _defineProperty2 = _interopRequireDefault(require("@babel/runtime/helpers/de
 var _react = _interopRequireDefault(require("react"));
 var _model = require("@atlaskit/editor-prosemirror/model");
 var _expValEquals = require("@atlaskit/tmp-editor-statsig/exp-val-equals");
-var _editorExperiment = require("@atlaskit/tmp-editor-statsig/editor-experiment");
 var _expandBody = require("../ui/utils/expand-body");
 var _nodes = require("./nodes");
 var _textWrapper = _interopRequireDefault(require("./nodes/text-wrapper"));
@@ -184,13 +183,8 @@ var ReactSerializer = exports.default = /*#__PURE__*/function () {
       });
       return props;
     });
-    if ((0, _editorExperiment.editorExperiment)('comment_on_bodied_extensions', true)) {
-      this.initStartPos = init.startPos || 1;
-      this.startPos = init.startPos || 1;
-    } else {
-      this.initStartPos = 1;
-      this.startPos = 1;
-    }
+    this.initStartPos = init.startPos || 1;
+    this.startPos = init.startPos || 1;
     this.providers = init.providers;
     this.eventHandlers = init.eventHandlers;
     this.extensionHandlers = init.extensionHandlers;

package/dist/cjs/ui/Renderer/index.js

@@ -73,7 +73,7 @@ var DEGRADED_SEVERITY_THRESHOLD = exports.DEGRADED_SEVERITY_THRESHOLD = 3000;
 var TABLE_INFO_TIMEOUT = 10000;
 var RENDER_EVENT_SAMPLE_RATE = 0.1;
 var packageName = "@atlaskit/renderer";
-var packageVersion = "140.2.6";
+var packageVersion = "140.2.7";
 var setAsQueryContainerStyles = (0, _react2.css)({
   containerName: 'ak-renderer-wrapper',
   containerType: 'inline-size'
@@ -828,16 +828,10 @@ function RendererActionsInternalUpdater(_ref2) {
   // It is set to the root renderer's doc as otherwise the resulting document will
   // be incorrect (nested renderers use a fake document which represents a subset
   // of the actual document).
-  var _doc;
-  if ((0, _editorExperiment.editorExperiment)('comment_on_bodied_extensions', true) && rootRendererContextValue) {
-    // If rootRendererContextValue is set -- we are inside a nested renderer
-    // and should always use the doc from the root renderer
-    _doc = rootRendererContextValue.doc;
-  } else {
-    // If rootRendererContextValue is not set -- we are in the root renderer
-    // and set the doc to the current doc.
-    _doc = doc;
-  }
+  // If rootRendererContextValue is set -- we are inside a nested renderer
+  // and should always use the doc from the root renderer.
+  // Otherwise we are in the root renderer and set the doc to the current doc.
+  var _doc = rootRendererContextValue ? rootRendererContextValue.doc : doc;
   (0, _react.useLayoutEffect)(function () {
     if (_doc) {
       actions._privateRegisterRenderer(rendererRef, _doc, schema, onAnalyticsEvent);
@@ -848,17 +842,17 @@ function RendererActionsInternalUpdater(_ref2) {
       return actions._privateUnregisterRenderer();
     };
   }, [actions, schema, _doc, onAnalyticsEvent]);
-  if ((0, _editorExperiment.editorExperiment)('comment_on_bodied_extensions', true)) {
-    return (
-      // eslint-disable-next-line @atlassian/perf-linting/no-inline-context-value, @atlassian/perf-linting/no-unstable-inline-props -- Ignored via go/ees017 (to be fixed)
-      (0, _react2.jsx)(RootRendererContext.Provider, {
-        value: {
-          doc: _doc
-        }
-      }, children)
-    );
-  }
-  return children;
+
+  // Memoised so nested renderers don't re-render on every root renderer render
+  // when the doc itself is unchanged.
+  var rootRendererValue = (0, _react.useMemo)(function () {
+    return {
+      doc: _doc
+    };
+  }, [_doc]);
+  return (0, _react2.jsx)(RootRendererContext.Provider, {
+    value: rootRendererValue
+  }, children);
 }
 
 // Usage notes:

package/dist/es2019/react/index.js

@@ -3,7 +3,6 @@ import _defineProperty from "@babel/runtime/helpers/defineProperty";
 import React from 'react';
 import { MarkType } from '@atlaskit/editor-prosemirror/model';
 import { expValEquals } from '@atlaskit/tmp-editor-statsig/exp-val-equals';
-import { editorExperiment } from '@atlaskit/tmp-editor-statsig/editor-experiment';
 import { mergeExpandBodyText, withExpandBodyBlock } from '../ui/utils/expand-body';
 import { Doc, DocWithSelectAllTrap, isTextNode, isTextWrapper, mergeTextNodes, toReact } from './nodes';
 import TextWrapperComponent from './nodes/text-wrapper';
@@ -171,13 +170,8 @@ export default class ReactSerializer {
       };
       return props;
     });
-    if (editorExperiment('comment_on_bodied_extensions', true)) {
-      this.initStartPos = init.startPos || 1;
-      this.startPos = init.startPos || 1;
-    } else {
-      this.initStartPos = 1;
-      this.startPos = 1;
-    }
+    this.initStartPos = init.startPos || 1;
+    this.startPos = init.startPos || 1;
     this.providers = init.providers;
     this.eventHandlers = init.eventHandlers;
     this.extensionHandlers = init.extensionHandlers;

package/dist/es2019/ui/Renderer/index.js

@@ -59,7 +59,7 @@ export const DEGRADED_SEVERITY_THRESHOLD = 3000;
 const TABLE_INFO_TIMEOUT = 10000;
 const RENDER_EVENT_SAMPLE_RATE = 0.1;
 const packageName = "@atlaskit/renderer";
-const packageVersion = "140.2.6";
+const packageVersion = "140.2.7";
 const setAsQueryContainerStyles = css({
   containerName: 'ak-renderer-wrapper',
   containerType: 'inline-size'
@@ -821,16 +821,10 @@ function RendererActionsInternalUpdater({
   // It is set to the root renderer's doc as otherwise the resulting document will
   // be incorrect (nested renderers use a fake document which represents a subset
   // of the actual document).
-  let _doc;
-  if (editorExperiment('comment_on_bodied_extensions', true) && rootRendererContextValue) {
-    // If rootRendererContextValue is set -- we are inside a nested renderer
-    // and should always use the doc from the root renderer
-    _doc = rootRendererContextValue.doc;
-  } else {
-    // If rootRendererContextValue is not set -- we are in the root renderer
-    // and set the doc to the current doc.
-    _doc = doc;
-  }
+  // If rootRendererContextValue is set -- we are inside a nested renderer
+  // and should always use the doc from the root renderer.
+  // Otherwise we are in the root renderer and set the doc to the current doc.
+  const _doc = rootRendererContextValue ? rootRendererContextValue.doc : doc;
   useLayoutEffect(() => {
     if (_doc) {
       actions._privateRegisterRenderer(rendererRef, _doc, schema, onAnalyticsEvent);
@@ -839,17 +833,15 @@ function RendererActionsInternalUpdater({
     }
     return () => actions._privateUnregisterRenderer();
   }, [actions, schema, _doc, onAnalyticsEvent]);
-  if (editorExperiment('comment_on_bodied_extensions', true)) {
-    return (
-      // eslint-disable-next-line @atlassian/perf-linting/no-inline-context-value, @atlassian/perf-linting/no-unstable-inline-props -- Ignored via go/ees017 (to be fixed)
-      jsx(RootRendererContext.Provider, {
-        value: {
-          doc: _doc
-        }
-      }, children)
-    );
-  }
-  return children;
+
+  // Memoised so nested renderers don't re-render on every root renderer render
+  // when the doc itself is unchanged.
+  const rootRendererValue = useMemo(() => ({
+    doc: _doc
+  }), [_doc]);
+  return jsx(RootRendererContext.Provider, {
+    value: rootRendererValue
+  }, children);
 }
 
 // Usage notes:

package/dist/esm/react/index.js

@@ -10,7 +10,6 @@ function _objectSpread(e) { for (var r = 1; r < arguments.length; r++) { var t =
 import React from 'react';
 import { MarkType } from '@atlaskit/editor-prosemirror/model';
 import { expValEquals } from '@atlaskit/tmp-editor-statsig/exp-val-equals';
-import { editorExperiment } from '@atlaskit/tmp-editor-statsig/editor-experiment';
 import { mergeExpandBodyText, withExpandBodyBlock } from '../ui/utils/expand-body';
 import { Doc, DocWithSelectAllTrap, isTextNode, isTextWrapper, mergeTextNodes, toReact } from './nodes';
 import TextWrapperComponent from './nodes/text-wrapper';
@@ -177,13 +176,8 @@ var ReactSerializer = /*#__PURE__*/function () {
       });
       return props;
     });
-    if (editorExperiment('comment_on_bodied_extensions', true)) {
-      this.initStartPos = init.startPos || 1;
-      this.startPos = init.startPos || 1;
-    } else {
-      this.initStartPos = 1;
-      this.startPos = 1;
-    }
+    this.initStartPos = init.startPos || 1;
+    this.startPos = init.startPos || 1;
     this.providers = init.providers;
     this.eventHandlers = init.eventHandlers;
     this.extensionHandlers = init.extensionHandlers;

package/dist/esm/ui/Renderer/index.js

@@ -64,7 +64,7 @@ export var DEGRADED_SEVERITY_THRESHOLD = 3000;
 var TABLE_INFO_TIMEOUT = 10000;
 var RENDER_EVENT_SAMPLE_RATE = 0.1;
 var packageName = "@atlaskit/renderer";
-var packageVersion = "140.2.6";
+var packageVersion = "140.2.7";
 var setAsQueryContainerStyles = css({
   containerName: 'ak-renderer-wrapper',
   containerType: 'inline-size'
@@ -819,16 +819,10 @@ function RendererActionsInternalUpdater(_ref2) {
   // It is set to the root renderer's doc as otherwise the resulting document will
   // be incorrect (nested renderers use a fake document which represents a subset
   // of the actual document).
-  var _doc;
-  if (editorExperiment('comment_on_bodied_extensions', true) && rootRendererContextValue) {
-    // If rootRendererContextValue is set -- we are inside a nested renderer
-    // and should always use the doc from the root renderer
-    _doc = rootRendererContextValue.doc;
-  } else {
-    // If rootRendererContextValue is not set -- we are in the root renderer
-    // and set the doc to the current doc.
-    _doc = doc;
-  }
+  // If rootRendererContextValue is set -- we are inside a nested renderer
+  // and should always use the doc from the root renderer.
+  // Otherwise we are in the root renderer and set the doc to the current doc.
+  var _doc = rootRendererContextValue ? rootRendererContextValue.doc : doc;
   useLayoutEffect(function () {
     if (_doc) {
       actions._privateRegisterRenderer(rendererRef, _doc, schema, onAnalyticsEvent);
@@ -839,17 +833,17 @@ function RendererActionsInternalUpdater(_ref2) {
       return actions._privateUnregisterRenderer();
     };
   }, [actions, schema, _doc, onAnalyticsEvent]);
-  if (editorExperiment('comment_on_bodied_extensions', true)) {
-    return (
-      // eslint-disable-next-line @atlassian/perf-linting/no-inline-context-value, @atlassian/perf-linting/no-unstable-inline-props -- Ignored via go/ees017 (to be fixed)
-      jsx(RootRendererContext.Provider, {
-        value: {
-          doc: _doc
-        }
-      }, children)
-    );
-  }
-  return children;
+
+  // Memoised so nested renderers don't re-render on every root renderer render
+  // when the doc itself is unchanged.
+  var rootRendererValue = useMemo(function () {
+    return {
+      doc: _doc
+    };
+  }, [_doc]);
+  return jsx(RootRendererContext.Provider, {
+    value: rootRendererValue
+  }, children);
 }
 
 // Usage notes:

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@atlaskit/renderer",
-	"version": "140.2.7",
+	"version": "140.2.8",
 	"description": "Renderer component",
 	"publishConfig": {
 		"registry": "https://registry.npmjs.org/"
@@ -26,6 +26,9 @@
 		},
 		"team": "Editor",
 		"website": {
+			"tags": [
+				"platform-labs"
+			],
 			"name": "Renderer"
 		}
 	},
@@ -70,8 +73,8 @@
 		"@atlaskit/status": "^5.11.0",
 		"@atlaskit/task-decision": "^21.10.0",
 		"@atlaskit/theme": "^28.2.0",
-		"@atlaskit/tmp-editor-statsig": "^198.0.0",
-		"@atlaskit/tokens": "^17.0.0",
+		"@atlaskit/tmp-editor-statsig": "^199.0.0",
+		"@atlaskit/tokens": "^18.0.0",
 		"@atlaskit/tooltip": "^24.3.0",
 		"@atlaskit/visually-hidden": "^4.4.0",
 		"@babel/runtime": "^7.0.0",
@@ -85,7 +88,7 @@
 		"uuid": "^11.1.1"
 	},
 	"peerDependencies": {
-		"@atlaskit/editor-common": "^122.10.0",
+		"@atlaskit/editor-common": "^122.11.0",
 		"@atlaskit/link-provider": "^5.7.0",
 		"@atlaskit/media-core": "^38.2.0",
 		"react": "^18.2.0 || ^19.2.0",
@@ -109,7 +112,7 @@
 		"@atlaskit/media-test-helpers": "^42.4.0",
 		"@atlaskit/mention": "^29.2.0",
 		"@atlaskit/modal-dialog": "^16.6.0",
-		"@atlaskit/navigation-system": "^10.16.0",
+		"@atlaskit/navigation-system": "^10.17.0",
 		"@atlaskit/primitives": "^22.5.0",
 		"@atlaskit/profilecard": "^26.24.0",
 		"@atlaskit/radio": "^10.2.0",