@atlaskit/renderer 137.1.2 → 137.1.4

package/dist/es2019/react/nodes/extension.js

@@ -16,6 +16,13 @@ import { isExperimentEnabled } from '@atlaskit/platform-feature-experiments/is-e
 import { expValEquals } from '@atlaskit/tmp-editor-statsig/exp-val-equals';
 import { calcBreakoutWidthCss } from '../utils/breakout';
 import { fg } from '@atlaskit/platform-feature-flags/fg';
+const FORGE_EXTENSION_TYPE = 'com.atlassian.ecosystem';
+/**
+ * Mirrors `FORGE_INLINE_BODIED_PARAM` in `@atlassian/xen-editor-provider`. Duplicated rather than
+ * imported: the renderer must not depend on a Forge package, and this is a stored parameter name,
+ * so it is part of the document contract rather than that package's API.
+ */
+const FORGE_INLINE_BODIED_PARAM = 'atlassianForgeInlineBodied';
 const viewportSizes = ['small', 'medium', 'default', 'large', 'xlarge'];
 // Mirrors sizes from https://bitbucket.org/atlassian/atlassian-frontend-monorepo/src/master/platform/packages/forge/xen-editor-provider/src/render/renderers/ForgeUIExtension.tsx
 const macroHeights = {
@@ -62,6 +69,7 @@ const FireExtensionAsInlineAnalytics = ({
   return null;
 };
 export const renderExtension = (content, layout, options = {}, removeOverflow, extensionId, extensionViewportSizes, nodeHeight, localId, shouldDisplayExtensionAsInline, node, isInsideOfInlineExtension) => {
+  var _node$parameters, _node$parameters$gues;
   const overflowContainerClass = !removeOverflow ? RendererCssClassName.EXTENSION_OVERFLOW_CONTAINER : '';
 
   // by default, we assume the extension is at top level, (direct child of doc node)
@@ -84,8 +92,36 @@ export const renderExtension = (content, layout, options = {}, removeOverflow, e
    */
   const viewportSize = getViewportSize(extensionId, extensionViewportSizes);
   const extensionHeight = nodeHeight || viewportSize;
-  const isInline = (shouldDisplayExtensionAsInline === null || shouldDisplayExtensionAsInline === void 0 ? void 0 : shouldDisplayExtensionAsInline(node)) && expValEquals('platform_editor_render_bodied_extension_as_inline', 'isEnabled', true);
+  /**
+   * Scoped to nodes inserted by an app declaring `outputType: inline`, which is what writes
+   * `atlassianForgeInlineBodied`. The output-type marker alone would also match migrated Connect
+   * content — it carries the same marker, and after an upgrade plus a storage round trip in the
+   * same shape — so keying on it would change how existing content renders. The renderer only
+   * ever sees the stored node, never the manifest, so a parameter this code writes is the only
+   * available signal.
+   *
+   * Evaluated once and shared with `isNativeForgeInline` below, so the gate is read a single time
+   * per render, and the cheap checks stay in front of it so anything ineligible short-circuits
+   * without firing an exposure it can never act on.
+   */
+  const isForgeInlineBodiedEnabled = Boolean((node === null || node === void 0 ? void 0 : node.extensionType) === FORGE_EXTENSION_TYPE && (node === null || node === void 0 ? void 0 : node.content) && (node === null || node === void 0 ? void 0 : (_node$parameters = node.parameters) === null || _node$parameters === void 0 ? void 0 : (_node$parameters$gues = _node$parameters.guestParams) === null || _node$parameters$gues === void 0 ? void 0 : _node$parameters$gues[FORGE_INLINE_BODIED_PARAM]) === 'true' && fg('platform_forge_inline_bodied_macro'));
+  /**
+   * The pass that marks the sibling textblocks around an inline extension resolves their
+   * positions without a depth term, so it only ever matches at the top level. Inlining a nested
+   * container without joining its neighbours leaves a shrink-wrapped box alone on its own line,
+   * which is worse than leaving it a block — so keep nested inline-bodied Forge macros as
+   * blocks until the sibling marking works at depth.
+   */
+  const isNestedForgeInlineBodied = !isTopLevel && isForgeInlineBodiedEnabled;
+  const isInline = (shouldDisplayExtensionAsInline === null || shouldDisplayExtensionAsInline === void 0 ? void 0 : shouldDisplayExtensionAsInline(node)) && expValEquals('platform_editor_render_bodied_extension_as_inline', 'isEnabled', true) && !isNestedForgeInlineBodied;
   const inlineClassName = isInline ? RendererCssClassName.EXTENSION_AS_INLINE : '';
+  /**
+   * A native Forge macro does not have its body rendered by the product — the body ADF is
+   * sent to the app over the bridge and the app renders it with its own nested renderer.
+   * The inline styling above stops at the outer wrapper, so mark these nodes to let the
+   * nested document's block spacing be collapsed too.
+   */
+  const isNativeForgeInline = Boolean(isInline && isForgeInlineBodiedEnabled);
   const asInlineAnalytics = isInline && fireAnalyticsEvent && node ? jsx(FireExtensionAsInlineAnalytics, {
     fireAnalyticsEvent: fireAnalyticsEvent,
     node: node
@@ -107,7 +143,8 @@ export const renderExtension = (content, layout, options = {}, removeOverflow, e
       "data-local-id": localId,
       "data-testid": "extension--wrapper",
       "data-node-type": "extension",
-      "data-top-level": isTopLevel || undefined
+      "data-top-level": isTopLevel || undefined,
+      "data-forge-inline": isNativeForgeInline || undefined
     }, jsx("div", {
       tabIndex: options.tabIndex
       // eslint-disable-next-line @atlaskit/ui-styling-standard/no-classname-prop
@@ -138,7 +175,8 @@ export const renderExtension = (content, layout, options = {}, removeOverflow, e
       },
       "data-layout": layout,
       "data-local-id": localId,
-      "data-top-level": isTopLevel || undefined
+      "data-top-level": isTopLevel || undefined,
+      "data-forge-inline": isNativeForgeInline || undefined
     }, jsx("div", {
       tabIndex: options.tabIndex
       // eslint-disable-next-line @atlaskit/ui-styling-standard/no-classname-prop

package/dist/es2019/react/utils/EditorMediaClientProvider.js

@@ -6,7 +6,7 @@ import { fg } from '@atlaskit/platform-feature-flags/fg';
 import { expValEquals } from '@atlaskit/tmp-editor-statsig/exp-val-equals';
 const getMediaClientConfigForRenderer = provider => {
   // eslint-disable-next-line @atlaskit/platform/no-preconditioning
-  return provider.viewAndUploadMediaClientConfig && fg('platform_media_video_captions') && fg('platform_editor_video_caption_commit') ? provider.viewAndUploadMediaClientConfig : provider.viewMediaClientConfig;
+  return provider.viewAndUploadMediaClientConfig && fg('platform_media_video_captions') ? provider.viewAndUploadMediaClientConfig : provider.viewMediaClientConfig;
 };
 export const EditorMediaClientProvider = ({
   children,

package/dist/es2019/ui/Expand.js

@@ -4,7 +4,7 @@
  */
 // eslint-disable-next-line @atlaskit/ui-styling-standard/use-compiled -- Ignored via go/DSP-18766
 import { css, jsx } from '@emotion/react';
-import React, { useCallback, useRef, Suspense, lazy } from 'react';
+import React, { useCallback, useEffect, useMemo, useRef, useState } from 'react';
 import { bind } from 'bind-event-listener';
 import { getDocument } from '@atlaskit/browser-apis';
 import { ACTION, ACTION_SUBJECT, EVENT_TYPE } from '@atlaskit/editor-common/analytics';
@@ -12,8 +12,9 @@ import { ExpandIconWrapper, ExpandLayoutWrapperWithRef, expandMessages, WidthPro
 import { akEditorLineHeight, akEditorSwoopCubicBezier, akLayoutGutterOffset } from '@atlaskit/editor-shared-styles';
 import ChevronRightIcon from '@atlaskit/icon/core/chevron-right';
 import Tooltip from '@atlaskit/tooltip/Tooltip';
+import { isExperimentEnabled } from '@atlaskit/platform-feature-experiments/is-experiment-enabled';
 import { fg } from '@atlaskit/platform-feature-flags/fg';
-import { expValEquals } from '@atlaskit/tmp-editor-statsig/exp-val-equals';
+import { getExpandSearchText } from './utils/expand-search-text';
 import _uniqueId from 'lodash/uniqueId';
 import { injectIntl } from 'react-intl';
 import { MODE, PLATFORM } from '../analytics/events';
@@ -153,17 +154,6 @@ const clearNextSiblingMarginTopStyle = css({
     marginTop: '0 !important'
   }
 });
-
-// Lazy-loaded children component
-const LazyChildren = /*#__PURE__*/lazy(() => {
-  return Promise.resolve({
-    default: ({
-      children
-    }) => {
-      return /*#__PURE__*/React.createElement(React.Fragment, null, children);
-    }
-  });
-});
 const Container = props => {
   return jsx("div", {
     css: [containerStyles, props['data-node-type'] === 'expand' && containerStylesDataNodeTypeExpand, props.expanded && containerStylesExpanded, props.focused && containerStylesFocused],
@@ -223,12 +213,19 @@ function Expand({
   localId,
   nestedHeaderIds,
   rendererContentMode,
-  loadBodyContent,
-  searchText
+  node
 }) {
-  const [expanded, setExpanded] = React.useState(false);
-  const [focused, setFocused] = React.useState(false);
-  const [hasLoadedChildren, setHasLoadedChildren] = React.useState(false);
+  const [expanded, setExpanded] = useState(false);
+  const [focused, setFocused] = useState(false);
+  /**
+   * PGXT-9021: latches on the first open so the body stays mounted once rendered, including after
+   * the expand is collapsed again. Remounting it would re-run every macro and Forge data fetch
+   * inside on each reopen, which is both slower and visibly reloads content the reader has already
+   * seen. The saving this gate exists for is at initial load, where the body has never been opened,
+   * so nothing is given up by keeping it after that. Never set on the server, so the server and the
+   * client's first render agree and hydration cannot desync.
+   */
+  const [hasBeenExpanded, setHasBeenExpanded] = useState(false);
   const isMobile = false;
   const label = intl.formatMessage(expanded ? expandMessages.collapseNode : expandMessages.expandNode);
   const {
@@ -238,16 +235,12 @@ function Expand({
   const contentWrapperRef = useRef(null);
   const handleFocus = useCallback(() => setFocused(true), []);
   const handleBlur = useCallback(() => setFocused(false), []);
-  const expandForBrowserFind = useCallback(() => {
-    setHasLoadedChildren(true);
+  // Both state updates happen in the same handler so they land in one render, rather than the
+  // latch reacting to `expanded` from an effect.
+  const openBody = useCallback(() => {
     setExpanded(true);
+    setHasBeenExpanded(true);
   }, []);
-  const shouldRenderLazyChildren = hasLoadedChildren || loadBodyContent;
-  // Only render the lightweight text placeholder when lazy load is ON and
-  // children haven't been loaded yet. When lazy load is OFF, children are
-  // always in the DOM — hidden="until-found" on the wrapper already makes
-  // them searchable by browser find, so no placeholder is needed.
-  const shouldRenderBrowserFindText = !shouldRenderLazyChildren && searchText && fg('hot-121622_lazy_load_expand_content') && expValEquals('platform_editor_close_expand_find', 'isEnabled', true);
 
   // Feature-detect hidden="until-found" support via the beforematch event.
   // Chrome 102+ and Firefox 130+ support it; Safari does not yet.
@@ -256,8 +249,8 @@ function Expand({
   // Initialised as false and set in useEffect to avoid SSR/client hydration mismatch —
   // useMemo would return true on the client's first render in supported browsers,
   // differing from the server snapshot which always produces false.
-  const [supportsHiddenUntilFound, setSupportsHiddenUntilFound] = React.useState(false);
-  React.useEffect(() => {
+  const [supportsHiddenUntilFound, setSupportsHiddenUntilFound] = useState(false);
+  useEffect(() => {
     const doc = getDocument();
     setSupportsHiddenUntilFound(doc !== null && doc !== void 0 && doc.body ? 'onbeforematch' in doc.body : false);
   }, []);
@@ -273,13 +266,13 @@ function Expand({
   // In unsupported browsers (Safari), we skip this entirely and fall back to the normal
   // CSS hiding (visibility:hidden + height:0), which doesn't support find-in-page but
   // still works correctly for expand/collapse.
-  React.useEffect(() => {
+  useEffect(() => {
     const contentContainer = contentContainerRef.current;
     const contentWrapper = contentWrapperRef.current;
     if (!contentWrapper) {
       return;
     }
-    if (supportsHiddenUntilFound && expValEquals('platform_editor_close_expand_find', 'isEnabled', true) && !expanded) {
+    if (supportsHiddenUntilFound && isExperimentEnabled('platform_editor_close_expand_find') && !expanded) {
       contentWrapper.setAttribute('hidden', 'until-found');
       // Override the CSS visibility:hidden from contentContainerStyles — hidden="until-found"
       // now handles hiding via content-visibility:hidden, which allows browser find to index
@@ -293,31 +286,27 @@ function Expand({
       contentWrapper.style.visibility = '';
     }
   }, [expanded, supportsHiddenUntilFound]);
-  React.useEffect(() => {
-    if (!expValEquals('platform_editor_close_expand_find', 'isEnabled', true) || expanded) {
+  useEffect(() => {
+    if (!isExperimentEnabled('platform_editor_close_expand_find') || expanded) {
       return;
     }
     const contentWrapper = contentWrapperRef.current;
     const unbindWrapperBeforeMatch = contentWrapper && supportsHiddenUntilFound ? bind(contentWrapper, {
       type: 'beforematch',
-      listener: expandForBrowserFind
+      listener: openBody
     }) : undefined;
     return () => {
       unbindWrapperBeforeMatch === null || unbindWrapperBeforeMatch === void 0 ? void 0 : unbindWrapperBeforeMatch();
     };
-  }, [expandForBrowserFind, expanded, supportsHiddenUntilFound]);
-  let expandContent = children;
-  if (shouldRenderBrowserFindText) {
-    // Browser find path: keep a lightweight text mirror in the closed expand
-    // so Ctrl+F can index it without mounting the rich children tree.
-    expandContent = jsx("span", null, searchText);
-  } else if (!shouldRenderLazyChildren && fg('hot-121622_lazy_load_expand_content')) {
-    expandContent = null;
-  } else if (fg('hot-121622_lazy_load_expand_content')) {
-    expandContent = jsx(Suspense, {
-      fallback: jsx("div", null, intl.formatMessage(expandMessages.loading))
-    }, jsx(LazyChildren, null, children));
-  }
+  }, [expanded, openBody, supportsHiddenUntilFound]);
+
+  // Until the expand is first opened, stand in a plain-text mirror of the body so
+  // hidden="until-found" keeps the content findable by browser find without mounting the real
+  // subtree. The beforematch listener above expands before the browser scrolls to its match.
+  // Computed lazily: a nested expand is not mounted until its ancestor opens, so its mirror is
+  // never built on initial load.
+  const searchText = useMemo(() => node && fg('hot-121622_lazy_load_expand_content') ? getExpandSearchText(node) : undefined, [node]);
+  const expandContent = searchText && !expanded && !hasBeenExpanded ? jsx("span", null, searchText) : children;
   return jsx(Container, {
     "data-testid": `expand-container-${nodeType}-${id}`,
     "data-node-type": nodeType,
@@ -327,15 +316,8 @@ function Expand({
     expanded: expanded,
     focused: focused
   }, nestedHeaderIds && nestedHeaderIds.length > 0 ? jsx(ActiveHeaderIdConsumer, {
-    nestedHeaderIds: nestedHeaderIds
-    // eslint-disable-next-line @atlassian/perf-linting/no-unstable-inline-props -- Ignored via go/ees017 (to be fixed)
-    ,
-    onNestedHeaderIdMatch: () => {
-      if (!hasLoadedChildren) {
-        setHasLoadedChildren(true);
-      }
-      setExpanded(true);
-    }
+    nestedHeaderIds: nestedHeaderIds,
+    onNestedHeaderIdMatch: openBody
   }) : null, jsx(TitleContainer
   // eslint-disable-next-line @atlassian/perf-linting/no-unstable-inline-props -- Ignored via go/ees017 (to be fixed)
   , {
@@ -343,12 +325,11 @@ function Expand({
       e.preventDefault();
       e.stopPropagation();
       fireExpandToggleAnalytics(nodeType, expanded, fireAnalyticsEvent);
-
-      // Mark children as loaded when expanding for the first time
-      if (!expanded && !hasLoadedChildren) {
-        setHasLoadedChildren(true);
+      if (expanded) {
+        setExpanded(false);
+      } else {
+        openBody();
       }
-      setExpanded(!expanded);
       e.persist();
       // @ts-ignore detail doesn't exist on type
       e.detail ? handleBlur() : handleFocus();
@@ -383,7 +364,7 @@ function Expand({
     id: id
   }, title || intl.formatMessage(expandMessages.expandDefaultTitle))), jsx(ContentContainer, {
     expanded: expanded,
-    enableBrowserFind: supportsHiddenUntilFound && expValEquals('platform_editor_close_expand_find', 'isEnabled', true),
+    enableBrowserFind: supportsHiddenUntilFound && isExperimentEnabled('platform_editor_close_expand_find'),
     contentRef: contentContainerRef
   }, jsx("div", {
     className: `${nodeType}-content-wrapper`,

package/dist/es2019/ui/Renderer/RendererStyleContainer.js

@@ -1027,6 +1027,26 @@ const extensionAsInlineStyle = css({
     display: 'inline-block'
   }
 });
+const forgeInlineBodiedSpacingStyle = css({
+  [`.${RendererCssClassName.DOCUMENT} .${RendererCssClassName.EXTENSION_AS_INLINE}[data-forge-inline]`]: {
+    marginBottom: 0,
+    verticalAlign: 'baseline',
+    maxWidth: '100%'
+  },
+  [[`.${RendererCssClassName.DOCUMENT} [data-forge-inline] + [data-as-inline="on"]`, `.${RendererCssClassName.DOCUMENT} [data-as-inline="on"]:has(+ [data-forge-inline])`].join(', ')]: {
+    display: 'inline'
+  },
+  [`.${RendererCssClassName.EXTENSION_AS_INLINE}[data-forge-inline] *`]: {
+    maxWidth: '100%'
+  },
+  [`.${RendererCssClassName.EXTENSION_AS_INLINE}[data-forge-inline] .${RendererCssClassName.EXTENSION_OVERFLOW_CONTAINER}`]: {
+    overflowX: 'auto'
+  },
+  [`.${RendererCssClassName.EXTENSION_AS_INLINE}[data-forge-inline] .${RendererCssClassName.DOCUMENT} > p`]: {
+    display: 'inline',
+    margin: 0
+  }
+});
 
 // Removes the blockNodesVerticalMargin styling for inline extensions, i.e. borderless excerpt-include
 const inlineExtensionRendererMarginFix = css({
@@ -2915,7 +2935,7 @@ export const RendererStyleContainer = props => {
     // eslint-disable-next-line @atlaskit/platform/no-preconditioning
     fg('editor_inline_comments_on_inline_nodes') && rendererAnnotationStylesCommentHeightFix, expValEquals('platform_editor_copy_link_a11y_inconsistency_fix', 'isEnabled', true) ? baseOtherStyles : baseOtherStylesDuplicateAnchor,
     // this should be placed after baseOtherStyles
-    expValEquals('platform_editor_render_bodied_extension_as_inline', 'isEnabled', true) && (expValEquals('platform_editor_remove_important_in_render_ext', 'isEnabled', true) ? extensionAsInlineStyle : oldExtensionAsInlineStyle), inlineExtensionRendererMarginFix, allowNestedHeaderLinks && (expValEquals('platform_editor_copy_link_a11y_inconsistency_fix', 'isEnabled', true) ? alignedHeadingAnchorStyle : alignedHeadingAnchorStyleDuplicateAnchor), mediaSingleSharedStyle,
+    expValEquals('platform_editor_render_bodied_extension_as_inline', 'isEnabled', true) && (expValEquals('platform_editor_remove_important_in_render_ext', 'isEnabled', true) ? extensionAsInlineStyle : oldExtensionAsInlineStyle), forgeInlineBodiedSpacingStyle, inlineExtensionRendererMarginFix, allowNestedHeaderLinks && (expValEquals('platform_editor_copy_link_a11y_inconsistency_fix', 'isEnabled', true) ? alignedHeadingAnchorStyle : alignedHeadingAnchorStyleDuplicateAnchor), mediaSingleSharedStyle,
     // merge firstWrappedMediaStyles with mediaSingleSharedStyle when clean up platform_editor_fix_media_in_renderer
     fg('platform_editor_fix_media_in_renderer') && firstWrappedMediaStyles, tableSharedStyle, expValEquals('platform_editor_table_q4_loveability', 'isEnabled', true) && roundedTableOuterBorderOverlayStyles, expValEquals('platform_editor_table_q4_loveability', 'isEnabled', true) && !isExperimentEnabled('platform_editor_table_q4_patch_7') && roundedTableLegacyClipPathStyles, expValEquals('platform_editor_table_q4_loveability', 'isEnabled', true) && roundedTableRemixBlockHighlightStyles, expValEquals('platform_editor_table_fit_to_content_auto_convert', 'isEnabled', true) && tableContentModeScopedStyles, expValEquals('platform_editor_table_fit_to_content_auto_convert', 'isEnabled', true) && tableContentModeNestedTableStyles, tableRendererHeaderStylesForTableCellOnly, fg('platform_editor_bordered_panel_nested_in_table') && tableRendererNestedPanelStyles, isBackgroundClipBrowserFixNeeded() && tableStylesBackGroundClipForGeckoForTableCellOnly, firstNodeWithNotMarginTopWithNestedDnD, rendererTableStyles, isStickyScrollbarOn && stickyScrollbarStyles, isStickyScrollbarOn && expValEquals('platform_editor_table_css_overflow_shadow', 'isEnabled', true) && stickyScrollbarOverflowShadowFixStyles, rendererTableHeaderEqualHeightStylesForTableCellOnly, allowColumnSorting && rendererTableSortableColumnStyles, allowColumnSorting && expValEqualsNoExposure('platform_editor_table_menu_updates', 'isEnabled', true) && rendererTableSortableColumnValignStyles, allowColumnSorting && allowNestedHeaderLinks && (expValEquals('platform_editor_copy_link_a11y_inconsistency_fix', 'isEnabled', true) ? rendererTableHeaderEqualHeightStylesAllowNestedHeaderLinks : rendererTableHeaderEqualHeightStylesAllowNestedHeaderLinksDuplicateAnchor), rendererTableColumnStyles, stickyHeaderStyles, codeBlockAndLayoutStyles, columnLayoutSharedStyle, isAdvancedLayoutsOn && columnLayoutResponsiveSharedStyle, isAdvancedLayoutsOn && columnLayoutResponsiveRendererStyles, isAdvancedLayoutsOn && layoutSectionForAdvancedLayoutsStyles, !useBlockRenderForCodeBlock && gridRenderForCodeBlockStyles, browser.safari && codeBlockInListSafariFixStyles, appearance === 'full-page' && !isPreviewPanelResponsivenessOn && responsiveBreakoutWidth, appearance === 'full-page' && isPreviewPanelResponsivenessOn && responsiveBreakoutWidthWithReducedPadding, (appearance === 'full-width' || appearance === 'max' && (expValEquals('editor_tinymce_full_width_mode', 'isEnabled', true) || expValEquals('confluence_max_width_content_appearance', 'isEnabled', true))) && responsiveBreakoutWidthFullWidth, expValEquals('platform_editor_lovability_emoji_scaling', 'isEnabled', true) ? contentMode === 'compact' ? scaledDenseEmojiStyles : scaledEmojiStyles : contentMode === 'compact' ? denseStyles : undefined, contentMode === 'compact' ? scaledDenseUnicodeEmojiStylesNew : scaledUnicodeEmojiStylesNew, syncBlockStyles, centerWrapperStyles, isInsideSyncBlock ? syncBlockRendererStyles : null, isInsideSyncBlock && tableFakeBorderStyles, isInsideSyncBlock && expValEquals('platform_editor_table_q4_loveability', 'isEnabled', true) ? roundedTableFakeBorderOverlayStyles : null, expValEquals('platform_editor_hide_extension_renderer_support', 'isEnabled', true) && hideExtensionStyles],
     "data-testid": testId

package/dist/es2019/ui/Renderer/index.js

@@ -60,7 +60,7 @@ export const DEGRADED_SEVERITY_THRESHOLD = 3000;
 const TABLE_INFO_TIMEOUT = 10000;
 const RENDER_EVENT_SAMPLE_RATE = 0.1;
 const packageName = "@atlaskit/renderer";
-const packageVersion = "137.1.1";
+const packageVersion = "137.1.3";
 const setAsQueryContainerStyles = css({
   containerName: 'ak-renderer-wrapper',
   containerType: 'inline-size'

package/dist/es2019/ui/utils/expand-search-text.js

@@ -0,0 +1,84 @@
+import { findChildrenByMark } from '@atlaskit/editor-prosemirror/utils';
+
+/**
+ * Minimal structural view of an ADF entity. `parameters.nestedContent` holds raw ADF JSON rather
+ * than ProseMirror nodes, so it cannot be walked with the model API.
+ */
+
+/** Separates text from adjacent blocks so phrases cannot fuse across block boundaries. */
+const BLOCK_SEPARATOR = ' ';
+const asText = value => typeof value === 'string' ? value : '';
+
+/**
+ * Extracts text from raw ADF JSON.
+ *
+ * Needed because some extensions stash a whole ADF subtree in `attrs.parameters.nestedContent`
+ * instead of in their node content — Confluence does this when it coerces nesting the schema
+ * cannot represent (an expand more than two collapsible layers deep, say). Such a node is a
+ * ProseMirror leaf, so the model walk cannot see the subtree even though it renders on the page
+ * via a nested renderer. Recurses, because nestedContent routinely holds further nested content.
+ */
+const adfEntityText = entity => {
+  var _entity$attrs, _entity$attrs$paramet, _entity$content;
+  if (!entity) {
+    return '';
+  }
+  const parts = [];
+  if (entity.type === 'text') {
+    parts.push(asText(entity.text));
+  }
+  const nestedContent = (_entity$attrs = entity.attrs) === null || _entity$attrs === void 0 ? void 0 : (_entity$attrs$paramet = _entity$attrs.parameters) === null || _entity$attrs$paramet === void 0 ? void 0 : _entity$attrs$paramet.nestedContent;
+  if (nestedContent) {
+    // Prefer the real subtree over `attrs.text`, which is only a placeholder label for it.
+    parts.push(adfEntityText(nestedContent));
+  } else {
+    var _entity$attrs2;
+    parts.push(asText((_entity$attrs2 = entity.attrs) === null || _entity$attrs2 === void 0 ? void 0 : _entity$attrs2.text));
+  }
+  (_entity$content = entity.content) === null || _entity$content === void 0 ? void 0 : _entity$content.forEach(child => parts.push(adfEntityText(child)));
+  return parts.filter(Boolean).join(BLOCK_SEPARATOR);
+};
+
+/**
+ * `textBetween` drops every non-text leaf unless the node spec declares `leafText`, and no ADF
+ * node does. Leaves carry their visible text in attrs, so recover it here.
+ */
+const leafText = leaf => {
+  var _leaf$attrs, _leaf$attrs$parameter, _leaf$attrs2;
+  const nestedContent = (_leaf$attrs = leaf.attrs) === null || _leaf$attrs === void 0 ? void 0 : (_leaf$attrs$parameter = _leaf$attrs.parameters) === null || _leaf$attrs$parameter === void 0 ? void 0 : _leaf$attrs$parameter.nestedContent;
+  if (nestedContent) {
+    return adfEntityText(nestedContent);
+  }
+  return asText((_leaf$attrs2 = leaf.attrs) === null || _leaf$attrs2 === void 0 ? void 0 : _leaf$attrs2.text);
+};
+const hasInlineComment = node => findChildrenByMark(node, node.type.schema.marks.annotation, true).some(annotation => annotation.node.marks.some(mark => mark.attrs.annotationType === 'inlineComment'));
+
+/** `null` is a cached "no mirror for this node", as distinct from `undefined` for a cache miss. */
+const searchTextCache = new WeakMap();
+
+/**
+ * Plain-text mirror of an expand's body, rendered in its place while collapsed so browser
+ * find-in-page can still reach the content.
+ *
+ * Cached on the node. ProseMirror nodes are immutable and `render-document` memoises
+ * `nodeFromJSON`, so the same node instance is reused across renders — including across the
+ * serializer rebuilds that invalidate the module-level `memoizeOne` caches.
+ *
+ * @returns the mirror text, or `undefined` if this expand must keep its body rendered.
+ */
+export const getExpandSearchText = node => {
+  var _cached;
+  let cached = searchTextCache.get(node);
+  if (cached === undefined) {
+    cached = hasInlineComment(node) ?
+    // Withhold the mirror, which makes Expand keep rendering `children`. Comment
+    // navigation walks the DOM to find the annotated node and scrolls it into view, so
+    // the annotation has to exist as a real element — a flat text mirror carries no
+    // annotation marks and cannot stand in for it. Without this, stepping through
+    // comments with the arrow keys silently fails to reach any comment inside a
+    // collapsed expand. Costs the lazy-load win for these expands, deliberately.
+    null : node.textBetween(0, node.content.size, BLOCK_SEPARATOR, leafText);
+    searchTextCache.set(node, cached);
+  }
+  return (_cached = cached) !== null && _cached !== void 0 ? _cached : undefined;
+};

package/dist/esm/react/index.js

@@ -16,7 +16,7 @@ import TextWrapperComponent from './nodes/text-wrapper';
 import { isNestedHeaderLinksEnabled } from './utils/links';
 import { getColumnWidths } from '@atlaskit/editor-common/utils';
 import { getMarksByOrder, isSameMark } from '@atlaskit/editor-common/validator';
-import { findChildrenByMark, findChildrenByType } from '@atlaskit/editor-prosemirror/utils';
+import { findChildrenByType } from '@atlaskit/editor-prosemirror/utils';
 import { isExperimentEnabled } from '@atlaskit/platform-feature-experiments/is-experiment-enabled';
 import { fg } from '@atlaskit/platform-feature-flags/fg';
 import { getText } from '../utils';
@@ -729,25 +729,14 @@ var ReactSerializer = /*#__PURE__*/function () {
     value: function getExpandProps(node) {
       var _this7 = this;
       var _path = arguments.length > 1 && arguments[1] !== undefined ? arguments[1] : [];
-      var loadBodyContent = false;
-      if (fg('hot-121622_lazy_load_expand_content')) {
-        var annotations = findChildrenByMark(node, node.type.schema.marks.annotation, true);
-        // Force rendering children if there are inline comments to support comments navigation
-        // which relies on the HTML node to be present.
-        loadBodyContent = annotations.some(function (annotation) {
-          return annotation.node.marks.some(function (mark) {
-            return mark.attrs.annotationType === 'inlineComment';
-          });
-        });
-      }
-
-      // Only compute searchText when the browser find experiment is enabled,
-      // to avoid unnecessary node.textContent string allocations per expand node.
-      var searchText = expValEquals('platform_editor_close_expand_find', 'isEnabled', true) ? node.textContent : undefined;
+      // Expand receives the node rather than a precomputed string so it can derive the collapsed
+      // text mirror only when it actually renders one — a nested expand is not mounted until its
+      // ancestor opens — and so that derivation can reach content the model walk cannot, such as
+      // the ADF stashed in a coerced extension's `parameters.nestedContent`. Expand owns the
+      // feature gate check.
       if (!isNestedHeaderLinksEnabled(this.allowHeadingAnchorLinks)) {
         return _objectSpread(_objectSpread({}, this.getProps(node)), {}, {
-          loadBodyContent: loadBodyContent,
-          searchText: searchText
+          node: node
         });
       }
       var nestedHeaderIds = findChildrenByType(node, node.type.schema.nodes.heading).map(function (_ref4) {
@@ -756,8 +745,7 @@ var ReactSerializer = /*#__PURE__*/function () {
       });
       return _objectSpread(_objectSpread({}, this.getProps(node)), {}, {
         nestedHeaderIds: nestedHeaderIds,
-        loadBodyContent: loadBodyContent,
-        searchText: searchText
+        node: node
       });
     }
 

package/dist/esm/react/nodes/extension.js

@@ -16,6 +16,13 @@ import { isExperimentEnabled } from '@atlaskit/platform-feature-experiments/is-e
 import { expValEquals } from '@atlaskit/tmp-editor-statsig/exp-val-equals';
 import { calcBreakoutWidthCss } from '../utils/breakout';
 import { fg } from '@atlaskit/platform-feature-flags/fg';
+var FORGE_EXTENSION_TYPE = 'com.atlassian.ecosystem';
+/**
+ * Mirrors `FORGE_INLINE_BODIED_PARAM` in `@atlassian/xen-editor-provider`. Duplicated rather than
+ * imported: the renderer must not depend on a Forge package, and this is a stored parameter name,
+ * so it is part of the document contract rather than that package's API.
+ */
+var FORGE_INLINE_BODIED_PARAM = 'atlassianForgeInlineBodied';
 var viewportSizes = ['small', 'medium', 'default', 'large', 'xlarge'];
 // Mirrors sizes from https://bitbucket.org/atlassian/atlassian-frontend-monorepo/src/master/platform/packages/forge/xen-editor-provider/src/render/renderers/ForgeUIExtension.tsx
 var macroHeights = {
@@ -63,6 +70,7 @@ var FireExtensionAsInlineAnalytics = function FireExtensionAsInlineAnalytics(_re
   return null;
 };
 export var renderExtension = function renderExtension(content, layout) {
+  var _node$parameters;
   var options = arguments.length > 2 && arguments[2] !== undefined ? arguments[2] : {};
   var removeOverflow = arguments.length > 3 ? arguments[3] : undefined;
   var extensionId = arguments.length > 4 ? arguments[4] : undefined;
@@ -95,8 +103,36 @@ export var renderExtension = function renderExtension(content, layout) {
    */
   var viewportSize = getViewportSize(extensionId, extensionViewportSizes);
   var extensionHeight = nodeHeight || viewportSize;
-  var isInline = (shouldDisplayExtensionAsInline === null || shouldDisplayExtensionAsInline === void 0 ? void 0 : shouldDisplayExtensionAsInline(node)) && expValEquals('platform_editor_render_bodied_extension_as_inline', 'isEnabled', true);
+  /**
+   * Scoped to nodes inserted by an app declaring `outputType: inline`, which is what writes
+   * `atlassianForgeInlineBodied`. The output-type marker alone would also match migrated Connect
+   * content — it carries the same marker, and after an upgrade plus a storage round trip in the
+   * same shape — so keying on it would change how existing content renders. The renderer only
+   * ever sees the stored node, never the manifest, so a parameter this code writes is the only
+   * available signal.
+   *
+   * Evaluated once and shared with `isNativeForgeInline` below, so the gate is read a single time
+   * per render, and the cheap checks stay in front of it so anything ineligible short-circuits
+   * without firing an exposure it can never act on.
+   */
+  var isForgeInlineBodiedEnabled = Boolean((node === null || node === void 0 ? void 0 : node.extensionType) === FORGE_EXTENSION_TYPE && (node === null || node === void 0 ? void 0 : node.content) && (node === null || node === void 0 || (_node$parameters = node.parameters) === null || _node$parameters === void 0 || (_node$parameters = _node$parameters.guestParams) === null || _node$parameters === void 0 ? void 0 : _node$parameters[FORGE_INLINE_BODIED_PARAM]) === 'true' && fg('platform_forge_inline_bodied_macro'));
+  /**
+   * The pass that marks the sibling textblocks around an inline extension resolves their
+   * positions without a depth term, so it only ever matches at the top level. Inlining a nested
+   * container without joining its neighbours leaves a shrink-wrapped box alone on its own line,
+   * which is worse than leaving it a block — so keep nested inline-bodied Forge macros as
+   * blocks until the sibling marking works at depth.
+   */
+  var isNestedForgeInlineBodied = !isTopLevel && isForgeInlineBodiedEnabled;
+  var isInline = (shouldDisplayExtensionAsInline === null || shouldDisplayExtensionAsInline === void 0 ? void 0 : shouldDisplayExtensionAsInline(node)) && expValEquals('platform_editor_render_bodied_extension_as_inline', 'isEnabled', true) && !isNestedForgeInlineBodied;
   var inlineClassName = isInline ? RendererCssClassName.EXTENSION_AS_INLINE : '';
+  /**
+   * A native Forge macro does not have its body rendered by the product — the body ADF is
+   * sent to the app over the bridge and the app renders it with its own nested renderer.
+   * The inline styling above stops at the outer wrapper, so mark these nodes to let the
+   * nested document's block spacing be collapsed too.
+   */
+  var isNativeForgeInline = Boolean(isInline && isForgeInlineBodiedEnabled);
   var asInlineAnalytics = isInline && fireAnalyticsEvent && node ? jsx(FireExtensionAsInlineAnalytics, {
     fireAnalyticsEvent: fireAnalyticsEvent,
     node: node
@@ -118,7 +154,8 @@ export var renderExtension = function renderExtension(content, layout) {
       "data-local-id": localId,
       "data-testid": "extension--wrapper",
       "data-node-type": "extension",
-      "data-top-level": isTopLevel || undefined
+      "data-top-level": isTopLevel || undefined,
+      "data-forge-inline": isNativeForgeInline || undefined
     }, jsx("div", {
       tabIndex: options.tabIndex
       // eslint-disable-next-line @atlaskit/ui-styling-standard/no-classname-prop
@@ -148,7 +185,8 @@ export var renderExtension = function renderExtension(content, layout) {
       },
       "data-layout": layout,
       "data-local-id": localId,
-      "data-top-level": isTopLevel || undefined
+      "data-top-level": isTopLevel || undefined,
+      "data-forge-inline": isNativeForgeInline || undefined
     }, jsx("div", {
       tabIndex: options.tabIndex
       // eslint-disable-next-line @atlaskit/ui-styling-standard/no-classname-prop

package/dist/esm/react/utils/EditorMediaClientProvider.js

@@ -7,7 +7,7 @@ import { fg } from '@atlaskit/platform-feature-flags/fg';
 import { expValEquals } from '@atlaskit/tmp-editor-statsig/exp-val-equals';
 var getMediaClientConfigForRenderer = function getMediaClientConfigForRenderer(provider) {
   // eslint-disable-next-line @atlaskit/platform/no-preconditioning
-  return provider.viewAndUploadMediaClientConfig && fg('platform_media_video_captions') && fg('platform_editor_video_caption_commit') ? provider.viewAndUploadMediaClientConfig : provider.viewMediaClientConfig;
+  return provider.viewAndUploadMediaClientConfig && fg('platform_media_video_captions') ? provider.viewAndUploadMediaClientConfig : provider.viewMediaClientConfig;
 };
 export var EditorMediaClientProvider = function EditorMediaClientProvider(_ref) {
   var children = _ref.children,