@atlaskit/renderer 136.2.2 → 136.2.4

package/CHANGELOG.md

@@ -1,5 +1,23 @@
 # @atlaskit/renderer
 
+## 136.2.4
+
+### Patch Changes
+
+- [`b6733d7c1b79e`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/b6733d7c1b79e) -
+  [ux] Updated styles for collapsible headings to ensure any element with height set via inline
+  style is not taking space when heading is collapsed.
+- Updated dependencies
+
+## 136.2.3
+
+### Patch Changes
+
+- [`9e4a665de419a`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/9e4a665de419a) -
+  Clean up of expriment flag `platform_editor_preview_panel_linking_exp_conf` and
+  `platform_editor_preview_panel_linking_exp_jira`.
+- Updated dependencies
+
 ## 136.2.2
 
 ### Patch Changes

package/dist/cjs/react/nodes/inlineCard.js

@@ -17,8 +17,6 @@ var _ssr = require("@atlaskit/smart-card/ssr");
 var _ui = require("@atlaskit/editor-common/ui");
 var _platformFeatureFlags = require("@atlaskit/platform-feature-flags");
 var _analyticsNext = require("@atlaskit/analytics-next");
-var _platformFeatureFlagsReact = require("@atlaskit/platform-feature-flags-react");
-var _experiments = require("@atlaskit/tmp-editor-statsig/experiments");
 var _expValEquals = require("@atlaskit/tmp-editor-statsig/exp-val-equals");
 var _analytics = require("@atlaskit/editor-common/analytics");
 var _editorSmartLinkDraggable = require("@atlaskit/editor-smart-link-draggable");
@@ -41,11 +39,6 @@ var _linkExtractors = require("@atlaskit/link-extractors");
 var HoverLinkOverlayNoop = function HoverLinkOverlayNoop(props) {
   return (0, _react2.jsx)(_react.Fragment, null, props.children);
 };
-var HoverLinkOverlayWithCondition = (0, _platformFeatureFlagsReact.componentWithCondition)(function () {
-  return (0, _experiments.editorExperiment)('platform_editor_preview_panel_linking_exp', true, {
-    exposure: true
-  });
-}, _ui.HoverLinkOverlay, HoverLinkOverlayNoop);
 var OverlayWithCardContext = function OverlayWithCardContext(_ref) {
   var _cardContext$value2, _cardContext$value3, _cardContext$value3$i, _cardContext$value4;
   var rendererAppearance = _ref.rendererAppearance,
@@ -106,7 +99,7 @@ var OverlayWithCardContext = function OverlayWithCardContext(_ref) {
   // When inside preview panel iframe, hide the overlay button
   var isInPreviewPanel = (0, _utils.isWithinPreviewPanelIFrame)();
   var showPanelButton = isInPreviewPanel ? isPreviewPanelAvailable : isPreviewAvailable;
-  var Overlay = isPreviewAvailable ? HoverLinkOverlayWithCondition : HoverLinkOverlayNoop;
+  var Overlay = isPreviewAvailable ? _ui.HoverLinkOverlay : HoverLinkOverlayNoop;
   return (0, _react2.jsx)(Overlay, {
     isVisible: isResolvedViewRendered,
     url: url,
@@ -130,17 +123,13 @@ var OverlayWithCardContext = function OverlayWithCardContext(_ref) {
             embedUrl: (0, _expValEquals.expValEquals)('platform_hover_card_preview_panel', 'cohort', 'test') ? (_extractSmartLinkEmbe = (0, _linkExtractors.extractSmartLinkEmbed)(cardState === null || cardState === void 0 ? void 0 : cardState.details)) === null || _extractSmartLinkEmbe === void 0 ? void 0 : _extractSmartLinkEmbe.src : undefined
           }
         });
-        (0, _experiments.editorExperiment)('platform_editor_preview_panel_linking_exp', true, {
-          exposure: true
-        }) && fireHoverLabelAEP('panel');
+        fireHoverLabelAEP('panel');
       } else if (isPreviewModalAvailable) {
         event.preventDefault();
         if (preview) {
           preview.invoke();
         }
-        (0, _experiments.editorExperiment)('platform_editor_preview_panel_linking_exp', true, {
-          exposure: true
-        }) && fireHoverLabelAEP('modal');
+        fireHoverLabelAEP('modal');
       }
     }
   }, children);
@@ -228,52 +217,7 @@ var InlineCard = function InlineCard(props) {
     }
   }, [provider, url]);
   var MaybeOverlay = cardContext !== null && cardContext !== void 0 && cardContext.value ? OverlayWithCardContext : HoverLinkOverlayNoop;
-  if ((ssr || cardState && (0, _expValEquals.expValEquals)('platform_editor_smartlink_local_cache', 'isEnabled', true)) && url && !(0, _experiments.editorExperiment)('platform_editor_preview_panel_linking_exp', true, {
-    exposure: true
-  })) {
-    if (
-    // eslint-disable-next-line @atlaskit/platform/no-invalid-feature-flag-usage
-    (0, _platformFeatureFlags.fg)('editor_inline_comments_on_inline_nodes')) {
-      return (0, _react2.jsx)(_editorSmartLinkDraggable.SmartLinkDraggable, {
-        url: url,
-        appearance: _editorSmartLinkDraggable.SMART_LINK_APPEARANCE.INLINE,
-        source: _editorSmartLinkDraggable.SMART_LINK_DRAG_TYPES.RENDERER
-      }, (0, _react2.jsx)("span", (0, _extends2.default)({
-        "data-inline-card": true
-        // eslint-disable-next-line @atlassian/perf-linting/no-expensive-computations-in-render -- Ignored via go/ees017 (to be fixed)
-        ,
-        "data-card-data": data ? JSON.stringify(data) : undefined,
-        "data-card-url": url
-        // Ignored via go/ees005
-        // eslint-disable-next-line react/jsx-props-no-spreading
-      }, inlineAnnotationProps), (0, _react2.jsx)(_analyticsNext.AnalyticsContext, {
-        data: analyticsData
-      }, wrapWithSuspense((0, _react2.jsx)(_ssr.CardSSR, {
-        appearance: "inline",
-        url: url,
-        showHoverPreview: !hideHoverPreview,
-        actionOptions: actionOptions,
-        onClick: onClick,
-        resolvingPlaceholder: resolvingPlaceholder
-      })))));
-    }
-    return (0, _react2.jsx)(_editorSmartLinkDraggable.SmartLinkDraggable, {
-      url: url,
-      appearance: _editorSmartLinkDraggable.SMART_LINK_APPEARANCE.INLINE,
-      source: _editorSmartLinkDraggable.SMART_LINK_DRAG_TYPES.RENDERER
-    }, (0, _react2.jsx)(_analyticsNext.AnalyticsContext, {
-      data: analyticsData
-    }, wrapWithSuspense((0, _react2.jsx)(_ssr.CardSSR, {
-      appearance: "inline",
-      url: url,
-      showHoverPreview: !hideHoverPreview,
-      actionOptions: actionOptions,
-      onClick: onClick,
-      resolvingPlaceholder: resolvingPlaceholder
-    })), CompetitorPromptComponent));
-  } else if ((ssr || cardState && (0, _expValEquals.expValEquals)('platform_editor_smartlink_local_cache', 'isEnabled', true)) && url && (0, _experiments.editorExperiment)('platform_editor_preview_panel_linking_exp', true, {
-    exposure: true
-  })) {
+  if ((ssr || cardState && (0, _expValEquals.expValEquals)('platform_editor_smartlink_local_cache', 'isEnabled', true)) && url) {
     if (
     // eslint-disable-next-line @atlaskit/platform/no-invalid-feature-flag-usage
     (0, _platformFeatureFlags.fg)('editor_inline_comments_on_inline_nodes')) {
@@ -398,10 +342,10 @@ var InlineCard = function InlineCard(props) {
         setIsResolvedViewRendered(true);
       }
     },
-    onError: onError,
-    disablePreviewPanel: (0, _experiments.editorExperiment)('platform_editor_preview_panel_linking_exp', true, {
-      exposure: true
-    })
+    onError: onError
+    // Setting disablePreviewPanel={true} leaves the overlay button as the only way to open the panel.
+    ,
+    disablePreviewPanel: true
   })))), CompetitorPromptComponent))));
 };
 var _default_1 = (0, _SmartCardStorage.withSmartCardStorage)(InlineCard);

package/dist/cjs/ui/Renderer/RendererStyleContainer.js

@@ -99,10 +99,17 @@ var baseStyles = (0, _react.css)((0, _defineProperty2.default)((0, _defineProper
   clear: 'both'
 }), ".".concat(_consts.RendererCssClassName.DOCUMENT), (0, _defineProperty2.default)((0, _defineProperty2.default)((0, _defineProperty2.default)((0, _defineProperty2.default)((0, _defineProperty2.default)((0, _defineProperty2.default)((0, _defineProperty2.default)((0, _defineProperty2.default)({}, "> [".concat(_collapsibleHeadingsDom.COLLAPSED_CONTENT_OWNERS_ATTRIBUTE, "][hidden='until-found']"), {
   display: 'block',
-  minBlockSize: 0,
-  marginBlock: 0,
-  paddingBlock: 0,
-  borderBlockWidth: 0
+  // `hidden='until-found'` maps to `content-visibility: hidden`, which skips the element's
+  // contents but keeps its own box, sized by its own specified sizes. Everything below
+  // needs `!important` because extension nodes are sized and spaced by declarations that
+  // would otherwise win: an inline `height`/`min-height` reserving macro height (see
+  // `react/nodes/extension.tsx`), and `!important` alignment margins from
+  // `@atlaskit/native-embeds-common`. Without it the collapsed section keeps a visible gap.
+  blockSize: '0 !important',
+  minBlockSize: '0 !important',
+  marginBlock: '0 !important',
+  paddingBlock: '0 !important',
+  borderBlockWidth: '0 !important'
 }), ".".concat(_mediaInline.INLINE_IMAGE_WRAPPER_CLASS_NAME), {
   height: '22px',
   transform: "translateY(-2px)"
@@ -2287,7 +2294,7 @@ var RendererStyleContainer = exports.RendererStyleContainer = function RendererS
     }),
     css: [(0, _expValEquals.expValEquals)('confluence_ttvc_inline_extensions', 'isEnabled', true) ? baseFontStyle : originalBaseFontLineHeight, baseStyles, (0, _expValEquals.expValEquals)('platform_editor_small_font_size', 'isEnabled', true) && fontSizeStyles, (0, _expValEquals.expValEquals)('platform_editor_copy_link_a11y_inconsistency_fix', 'isEnabled', true) ? headingAnchorStyles : headingAnchorStylesDuplicateAnchor, headingAnchorButtonFocusVisibleStyles, (0, _expValEquals.expValEquals)('platform_editor_copy_link_a11y_inconsistency_fix', 'isEnabled', true) ? hideHeadingCopyLinkWrapperStyles : hideHeadingCopyLinkWrapperStylesDuplicateAnchor, appearance === 'full-page' && isPreviewPanelResponsivenessOn && rendererFullPageStylesWithReducedPadding, appearance === 'full-page' && !isPreviewPanelResponsivenessOn && rendererFullPageStyles, appearance === 'full-width' && ((0, _expValEquals.expValEquals)('platform_editor_remove_important_in_render_ext', 'isEnabled', true) ? rendererFullWidthStyles : oldRendererFullWidthStyles), (appearance === 'full-width' || appearance === 'max' && ((0, _expValEquals.expValEquals)('editor_tinymce_full_width_mode', 'isEnabled', true) || (0, _expValEquals.expValEquals)('confluence_max_width_content_appearance', 'isEnabled', true))) && !(0, _table.isTableResizingEnabled)(appearance) && rendererFullWidthStylesForTableResizing, appearance === 'max' && ((0, _expValEquals.expValEquals)('editor_tinymce_full_width_mode', 'isEnabled', true) || (0, _expValEquals.expValEquals)('confluence_max_width_content_appearance', 'isEnabled', true)) && ((0, _expValEquals.expValEquals)('platform_editor_remove_important_in_render_ext', 'isEnabled', true) ? rendererMaxWidthStyles : oldRendererMaxWidthStyles), rovoTelepointerStyles, whitespaceSharedStyles, blockquoteSharedStyles, headingsSharedStyles, (0, _expValEquals.expValEquals)('platform_editor_copy_link_a11y_inconsistency_fix', 'isEnabled', true) && headingWrapperInlineFlowStyles, (0, _expValEquals.expValEquals)('platform_editor_copy_link_a11y_inconsistency_fix', 'isEnabled', true) ? headingWithAlignmentStyles : headingWithAlignmentStylesDuplicateAnchor, ruleSharedStyles, contentMode === 'compact' && extensionStyle, contentMode === 'compact' ? paragraphStylesUGCScaledMargin : paragraphSharedStylesWithEditorUGC, listsSharedStyles, browser.gecko && listsSharedStylesForGekko, (0, _expValEquals.expValEquals)('platform_editor_flexible_list_schema', 'isEnabled', true) && listItemHiddenMarkerStyles, indentationSharedStyles, indentationSharedStylesWithMarginFix, (0, _expValEquals.expValEquals)('platform_editor_copy_link_a11y_inconsistency_fix', 'isEnabled', true) ? blockMarksSharedStyles : blockMarksSharedStylesDuplicateAnchor, codeMarkSharedStyles, shadowSharedStyle, dateSharedStyle, textColorStyles, backgroundColorStyles, !(0, _expValEquals.expValEquals)('platform_editor_lovability_text_bg_color', 'isEnabled', true) && highlightLinksUnsetStyles,
     // eslint-disable-next-line @atlaskit/ui-styling-standard/no-imported-style-values
-    textHighlightPaddingStyles, tasksAndDecisionsStyles, (0, _expValEquals.expValEquals)('platform_editor_copy_link_a11y_inconsistency_fix', 'isEnabled', true) && headingPanelStyles, smartCardStyles, smartCardStylesAvatarFix, (0, _experiments.editorExperiment)('platform_editor_preview_panel_linking_exp', true) && headerSmartCardStyles, smartCardStylesAvatarMarginFix, smartCardStylesAvatarListZeroMarginTop, (0, _platformFeatureFlags.fg)('editor_inline_comments_on_inline_nodes') && ((0, _expValEquals.expValEquals)('confluence_fe_renderer_inline_node_mark_color_fix', 'isEnabled', true) ? rendererAnnotationStyles : rendererAnnotationStylesOld),
+    textHighlightPaddingStyles, tasksAndDecisionsStyles, (0, _expValEquals.expValEquals)('platform_editor_copy_link_a11y_inconsistency_fix', 'isEnabled', true) && headingPanelStyles, smartCardStyles, smartCardStylesAvatarFix, headerSmartCardStyles, smartCardStylesAvatarMarginFix, smartCardStylesAvatarListZeroMarginTop, (0, _platformFeatureFlags.fg)('editor_inline_comments_on_inline_nodes') && ((0, _expValEquals.expValEquals)('confluence_fe_renderer_inline_node_mark_color_fix', 'isEnabled', true) ? rendererAnnotationStyles : rendererAnnotationStylesOld),
     // eslint-disable-next-line @atlaskit/platform/no-preconditioning
     (0, _platformFeatureFlags.fg)('editor_inline_comments_on_inline_nodes') && rendererAnnotationStylesCommentHeightFix, (0, _expValEquals.expValEquals)('platform_editor_copy_link_a11y_inconsistency_fix', 'isEnabled', true) ? baseOtherStyles : baseOtherStylesDuplicateAnchor, !(0, _expValEquals.expValEquals)('platform_editor_flex_based_centering', 'isEnabled', true) && extensionCenterAlignLegacyStyles,
     // this should be placed after baseOtherStyles

package/dist/cjs/ui/Renderer/index.js

@@ -74,7 +74,7 @@ var DEGRADED_SEVERITY_THRESHOLD = exports.DEGRADED_SEVERITY_THRESHOLD = 3000;
 var TABLE_INFO_TIMEOUT = 10000;
 var RENDER_EVENT_SAMPLE_RATE = 0.1;
 var packageName = "@atlaskit/renderer";
-var packageVersion = "136.2.1";
+var packageVersion = "136.2.3";
 var setAsQueryContainerStyles = (0, _react2.css)({
   containerName: 'ak-renderer-wrapper',
   containerType: 'inline-size'

package/dist/es2019/react/nodes/inlineCard.js

@@ -15,8 +15,6 @@ import { CardSSR } from '@atlaskit/smart-card/ssr';
 import { HoverLinkOverlay, UnsupportedInline } from '@atlaskit/editor-common/ui';
 import { fg } from '@atlaskit/platform-feature-flags';
 import { AnalyticsContext } from '@atlaskit/analytics-next';
-import { componentWithCondition } from '@atlaskit/platform-feature-flags-react';
-import { editorExperiment } from '@atlaskit/tmp-editor-statsig/experiments';
 import { expValEquals } from '@atlaskit/tmp-editor-statsig/exp-val-equals';
 import { ACTION, ACTION_SUBJECT, ACTION_SUBJECT_ID, EVENT_TYPE } from '@atlaskit/editor-common/analytics';
 import { SmartLinkDraggable, SMART_LINK_DRAG_TYPES, SMART_LINK_APPEARANCE } from '@atlaskit/editor-smart-link-draggable';
@@ -29,9 +27,6 @@ import { useInlineAnnotationProps } from '../../ui/annotations/element/useInline
 import { usePortal } from '../../ui/Renderer/PortalContext';
 import { extractSmartLinkEmbed } from '@atlaskit/link-extractors';
 const HoverLinkOverlayNoop = props => jsx(Fragment, null, props.children);
-const HoverLinkOverlayWithCondition = componentWithCondition(() => editorExperiment('platform_editor_preview_panel_linking_exp', true, {
-  exposure: true
-}), HoverLinkOverlay, HoverLinkOverlayNoop);
 const OverlayWithCardContext = ({
   rendererAppearance,
   isResolvedViewRendered,
@@ -89,7 +84,7 @@ const OverlayWithCardContext = ({
   // When inside preview panel iframe, hide the overlay button
   const isInPreviewPanel = isWithinPreviewPanelIFrame();
   const showPanelButton = isInPreviewPanel ? isPreviewPanelAvailable : isPreviewAvailable;
-  const Overlay = isPreviewAvailable ? HoverLinkOverlayWithCondition : HoverLinkOverlayNoop;
+  const Overlay = isPreviewAvailable ? HoverLinkOverlay : HoverLinkOverlayNoop;
   return jsx(Overlay, {
     isVisible: isResolvedViewRendered,
     url: url,
@@ -113,17 +108,13 @@ const OverlayWithCardContext = ({
             embedUrl: expValEquals('platform_hover_card_preview_panel', 'cohort', 'test') ? (_extractSmartLinkEmbe = extractSmartLinkEmbed(cardState === null || cardState === void 0 ? void 0 : cardState.details)) === null || _extractSmartLinkEmbe === void 0 ? void 0 : _extractSmartLinkEmbe.src : undefined
           }
         });
-        editorExperiment('platform_editor_preview_panel_linking_exp', true, {
-          exposure: true
-        }) && fireHoverLabelAEP('panel');
+        fireHoverLabelAEP('panel');
       } else if (isPreviewModalAvailable) {
         event.preventDefault();
         if (preview) {
           preview.invoke();
         }
-        editorExperiment('platform_editor_preview_panel_linking_exp', true, {
-          exposure: true
-        }) && fireHoverLabelAEP('modal');
+        fireHoverLabelAEP('modal');
       }
     }
   }, children);
@@ -213,52 +204,7 @@ const InlineCard = props => {
     }
   }, [provider, url]);
   const MaybeOverlay = cardContext !== null && cardContext !== void 0 && cardContext.value ? OverlayWithCardContext : HoverLinkOverlayNoop;
-  if ((ssr || cardState && expValEquals('platform_editor_smartlink_local_cache', 'isEnabled', true)) && url && !editorExperiment('platform_editor_preview_panel_linking_exp', true, {
-    exposure: true
-  })) {
-    if (
-    // eslint-disable-next-line @atlaskit/platform/no-invalid-feature-flag-usage
-    fg('editor_inline_comments_on_inline_nodes')) {
-      return jsx(SmartLinkDraggable, {
-        url: url,
-        appearance: SMART_LINK_APPEARANCE.INLINE,
-        source: SMART_LINK_DRAG_TYPES.RENDERER
-      }, jsx("span", _extends({
-        "data-inline-card": true
-        // eslint-disable-next-line @atlassian/perf-linting/no-expensive-computations-in-render -- Ignored via go/ees017 (to be fixed)
-        ,
-        "data-card-data": data ? JSON.stringify(data) : undefined,
-        "data-card-url": url
-        // Ignored via go/ees005
-        // eslint-disable-next-line react/jsx-props-no-spreading
-      }, inlineAnnotationProps), jsx(AnalyticsContext, {
-        data: analyticsData
-      }, wrapWithSuspense(jsx(CardSSR, {
-        appearance: "inline",
-        url: url,
-        showHoverPreview: !hideHoverPreview,
-        actionOptions: actionOptions,
-        onClick: onClick,
-        resolvingPlaceholder: resolvingPlaceholder
-      })))));
-    }
-    return jsx(SmartLinkDraggable, {
-      url: url,
-      appearance: SMART_LINK_APPEARANCE.INLINE,
-      source: SMART_LINK_DRAG_TYPES.RENDERER
-    }, jsx(AnalyticsContext, {
-      data: analyticsData
-    }, wrapWithSuspense(jsx(CardSSR, {
-      appearance: "inline",
-      url: url,
-      showHoverPreview: !hideHoverPreview,
-      actionOptions: actionOptions,
-      onClick: onClick,
-      resolvingPlaceholder: resolvingPlaceholder
-    })), CompetitorPromptComponent));
-  } else if ((ssr || cardState && expValEquals('platform_editor_smartlink_local_cache', 'isEnabled', true)) && url && editorExperiment('platform_editor_preview_panel_linking_exp', true, {
-    exposure: true
-  })) {
+  if ((ssr || cardState && expValEquals('platform_editor_smartlink_local_cache', 'isEnabled', true)) && url) {
     if (
     // eslint-disable-next-line @atlaskit/platform/no-invalid-feature-flag-usage
     fg('editor_inline_comments_on_inline_nodes')) {
@@ -383,10 +329,10 @@ const InlineCard = props => {
         setIsResolvedViewRendered(true);
       }
     },
-    onError: onError,
-    disablePreviewPanel: editorExperiment('platform_editor_preview_panel_linking_exp', true, {
-      exposure: true
-    })
+    onError: onError
+    // Setting disablePreviewPanel={true} leaves the overlay button as the only way to open the panel.
+    ,
+    disablePreviewPanel: true
   })))), CompetitorPromptComponent))));
 };
 const _default_1 = withSmartCardStorage(InlineCard);

package/dist/es2019/ui/Renderer/RendererStyleContainer.js

@@ -90,10 +90,17 @@ const baseStyles = css({
   [`.${RendererCssClassName.DOCUMENT}`]: {
     [`> [${COLLAPSED_CONTENT_OWNERS_ATTRIBUTE}][hidden='until-found']`]: {
       display: 'block',
-      minBlockSize: 0,
-      marginBlock: 0,
-      paddingBlock: 0,
-      borderBlockWidth: 0
+      // `hidden='until-found'` maps to `content-visibility: hidden`, which skips the element's
+      // contents but keeps its own box, sized by its own specified sizes. Everything below
+      // needs `!important` because extension nodes are sized and spaced by declarations that
+      // would otherwise win: an inline `height`/`min-height` reserving macro height (see
+      // `react/nodes/extension.tsx`), and `!important` alignment margins from
+      // `@atlaskit/native-embeds-common`. Without it the collapsed section keeps a visible gap.
+      blockSize: '0 !important',
+      minBlockSize: '0 !important',
+      marginBlock: '0 !important',
+      paddingBlock: '0 !important',
+      borderBlockWidth: '0 !important'
     },
     // p, h3, and action items
     [`.${INLINE_IMAGE_WRAPPER_CLASS_NAME}`]: {
@@ -2913,7 +2920,7 @@ export const RendererStyleContainer = props => {
     },
     css: [expValEquals('confluence_ttvc_inline_extensions', 'isEnabled', true) ? baseFontStyle : originalBaseFontLineHeight, baseStyles, expValEquals('platform_editor_small_font_size', 'isEnabled', true) && fontSizeStyles, expValEquals('platform_editor_copy_link_a11y_inconsistency_fix', 'isEnabled', true) ? headingAnchorStyles : headingAnchorStylesDuplicateAnchor, headingAnchorButtonFocusVisibleStyles, expValEquals('platform_editor_copy_link_a11y_inconsistency_fix', 'isEnabled', true) ? hideHeadingCopyLinkWrapperStyles : hideHeadingCopyLinkWrapperStylesDuplicateAnchor, appearance === 'full-page' && isPreviewPanelResponsivenessOn && rendererFullPageStylesWithReducedPadding, appearance === 'full-page' && !isPreviewPanelResponsivenessOn && rendererFullPageStyles, appearance === 'full-width' && (expValEquals('platform_editor_remove_important_in_render_ext', 'isEnabled', true) ? rendererFullWidthStyles : oldRendererFullWidthStyles), (appearance === 'full-width' || appearance === 'max' && (expValEquals('editor_tinymce_full_width_mode', 'isEnabled', true) || expValEquals('confluence_max_width_content_appearance', 'isEnabled', true))) && !isTableResizingEnabled(appearance) && rendererFullWidthStylesForTableResizing, appearance === 'max' && (expValEquals('editor_tinymce_full_width_mode', 'isEnabled', true) || expValEquals('confluence_max_width_content_appearance', 'isEnabled', true)) && (expValEquals('platform_editor_remove_important_in_render_ext', 'isEnabled', true) ? rendererMaxWidthStyles : oldRendererMaxWidthStyles), rovoTelepointerStyles, whitespaceSharedStyles, blockquoteSharedStyles, headingsSharedStyles, expValEquals('platform_editor_copy_link_a11y_inconsistency_fix', 'isEnabled', true) && headingWrapperInlineFlowStyles, expValEquals('platform_editor_copy_link_a11y_inconsistency_fix', 'isEnabled', true) ? headingWithAlignmentStyles : headingWithAlignmentStylesDuplicateAnchor, ruleSharedStyles, contentMode === 'compact' && extensionStyle, contentMode === 'compact' ? paragraphStylesUGCScaledMargin : paragraphSharedStylesWithEditorUGC, listsSharedStyles, browser.gecko && listsSharedStylesForGekko, expValEquals('platform_editor_flexible_list_schema', 'isEnabled', true) && listItemHiddenMarkerStyles, indentationSharedStyles, indentationSharedStylesWithMarginFix, expValEquals('platform_editor_copy_link_a11y_inconsistency_fix', 'isEnabled', true) ? blockMarksSharedStyles : blockMarksSharedStylesDuplicateAnchor, codeMarkSharedStyles, shadowSharedStyle, dateSharedStyle, textColorStyles, backgroundColorStyles, !expValEquals('platform_editor_lovability_text_bg_color', 'isEnabled', true) && highlightLinksUnsetStyles,
     // eslint-disable-next-line @atlaskit/ui-styling-standard/no-imported-style-values
-    textHighlightPaddingStyles, tasksAndDecisionsStyles, expValEquals('platform_editor_copy_link_a11y_inconsistency_fix', 'isEnabled', true) && headingPanelStyles, smartCardStyles, smartCardStylesAvatarFix, editorExperiment('platform_editor_preview_panel_linking_exp', true) && headerSmartCardStyles, smartCardStylesAvatarMarginFix, smartCardStylesAvatarListZeroMarginTop, fg('editor_inline_comments_on_inline_nodes') && (expValEquals('confluence_fe_renderer_inline_node_mark_color_fix', 'isEnabled', true) ? rendererAnnotationStyles : rendererAnnotationStylesOld),
+    textHighlightPaddingStyles, tasksAndDecisionsStyles, expValEquals('platform_editor_copy_link_a11y_inconsistency_fix', 'isEnabled', true) && headingPanelStyles, smartCardStyles, smartCardStylesAvatarFix, headerSmartCardStyles, smartCardStylesAvatarMarginFix, smartCardStylesAvatarListZeroMarginTop, fg('editor_inline_comments_on_inline_nodes') && (expValEquals('confluence_fe_renderer_inline_node_mark_color_fix', 'isEnabled', true) ? rendererAnnotationStyles : rendererAnnotationStylesOld),
     // eslint-disable-next-line @atlaskit/platform/no-preconditioning
     fg('editor_inline_comments_on_inline_nodes') && rendererAnnotationStylesCommentHeightFix, expValEquals('platform_editor_copy_link_a11y_inconsistency_fix', 'isEnabled', true) ? baseOtherStyles : baseOtherStylesDuplicateAnchor, !expValEquals('platform_editor_flex_based_centering', 'isEnabled', true) && extensionCenterAlignLegacyStyles,
     // this should be placed after baseOtherStyles

package/dist/es2019/ui/Renderer/index.js

@@ -60,7 +60,7 @@ export const DEGRADED_SEVERITY_THRESHOLD = 3000;
 const TABLE_INFO_TIMEOUT = 10000;
 const RENDER_EVENT_SAMPLE_RATE = 0.1;
 const packageName = "@atlaskit/renderer";
-const packageVersion = "136.2.1";
+const packageVersion = "136.2.3";
 const setAsQueryContainerStyles = css({
   containerName: 'ak-renderer-wrapper',
   containerType: 'inline-size'

package/dist/esm/react/nodes/inlineCard.js

@@ -16,8 +16,6 @@ import { CardSSR } from '@atlaskit/smart-card/ssr';
 import { HoverLinkOverlay, UnsupportedInline } from '@atlaskit/editor-common/ui';
 import { fg } from '@atlaskit/platform-feature-flags';
 import { AnalyticsContext } from '@atlaskit/analytics-next';
-import { componentWithCondition } from '@atlaskit/platform-feature-flags-react';
-import { editorExperiment } from '@atlaskit/tmp-editor-statsig/experiments';
 import { expValEquals } from '@atlaskit/tmp-editor-statsig/exp-val-equals';
 import { ACTION, ACTION_SUBJECT, ACTION_SUBJECT_ID, EVENT_TYPE } from '@atlaskit/editor-common/analytics';
 import { SmartLinkDraggable, SMART_LINK_DRAG_TYPES, SMART_LINK_APPEARANCE } from '@atlaskit/editor-smart-link-draggable';
@@ -32,11 +30,6 @@ import { extractSmartLinkEmbed } from '@atlaskit/link-extractors';
 var HoverLinkOverlayNoop = function HoverLinkOverlayNoop(props) {
   return jsx(Fragment, null, props.children);
 };
-var HoverLinkOverlayWithCondition = componentWithCondition(function () {
-  return editorExperiment('platform_editor_preview_panel_linking_exp', true, {
-    exposure: true
-  });
-}, HoverLinkOverlay, HoverLinkOverlayNoop);
 var OverlayWithCardContext = function OverlayWithCardContext(_ref) {
   var _cardContext$value2, _cardContext$value3, _cardContext$value3$i, _cardContext$value4;
   var rendererAppearance = _ref.rendererAppearance,
@@ -97,7 +90,7 @@ var OverlayWithCardContext = function OverlayWithCardContext(_ref) {
   // When inside preview panel iframe, hide the overlay button
   var isInPreviewPanel = isWithinPreviewPanelIFrame();
   var showPanelButton = isInPreviewPanel ? isPreviewPanelAvailable : isPreviewAvailable;
-  var Overlay = isPreviewAvailable ? HoverLinkOverlayWithCondition : HoverLinkOverlayNoop;
+  var Overlay = isPreviewAvailable ? HoverLinkOverlay : HoverLinkOverlayNoop;
   return jsx(Overlay, {
     isVisible: isResolvedViewRendered,
     url: url,
@@ -121,17 +114,13 @@ var OverlayWithCardContext = function OverlayWithCardContext(_ref) {
             embedUrl: expValEquals('platform_hover_card_preview_panel', 'cohort', 'test') ? (_extractSmartLinkEmbe = extractSmartLinkEmbed(cardState === null || cardState === void 0 ? void 0 : cardState.details)) === null || _extractSmartLinkEmbe === void 0 ? void 0 : _extractSmartLinkEmbe.src : undefined
           }
         });
-        editorExperiment('platform_editor_preview_panel_linking_exp', true, {
-          exposure: true
-        }) && fireHoverLabelAEP('panel');
+        fireHoverLabelAEP('panel');
       } else if (isPreviewModalAvailable) {
         event.preventDefault();
         if (preview) {
           preview.invoke();
         }
-        editorExperiment('platform_editor_preview_panel_linking_exp', true, {
-          exposure: true
-        }) && fireHoverLabelAEP('modal');
+        fireHoverLabelAEP('modal');
       }
     }
   }, children);
@@ -219,52 +208,7 @@ var InlineCard = function InlineCard(props) {
     }
   }, [provider, url]);
   var MaybeOverlay = cardContext !== null && cardContext !== void 0 && cardContext.value ? OverlayWithCardContext : HoverLinkOverlayNoop;
-  if ((ssr || cardState && expValEquals('platform_editor_smartlink_local_cache', 'isEnabled', true)) && url && !editorExperiment('platform_editor_preview_panel_linking_exp', true, {
-    exposure: true
-  })) {
-    if (
-    // eslint-disable-next-line @atlaskit/platform/no-invalid-feature-flag-usage
-    fg('editor_inline_comments_on_inline_nodes')) {
-      return jsx(SmartLinkDraggable, {
-        url: url,
-        appearance: SMART_LINK_APPEARANCE.INLINE,
-        source: SMART_LINK_DRAG_TYPES.RENDERER
-      }, jsx("span", _extends({
-        "data-inline-card": true
-        // eslint-disable-next-line @atlassian/perf-linting/no-expensive-computations-in-render -- Ignored via go/ees017 (to be fixed)
-        ,
-        "data-card-data": data ? JSON.stringify(data) : undefined,
-        "data-card-url": url
-        // Ignored via go/ees005
-        // eslint-disable-next-line react/jsx-props-no-spreading
-      }, inlineAnnotationProps), jsx(AnalyticsContext, {
-        data: analyticsData
-      }, wrapWithSuspense(jsx(CardSSR, {
-        appearance: "inline",
-        url: url,
-        showHoverPreview: !hideHoverPreview,
-        actionOptions: actionOptions,
-        onClick: onClick,
-        resolvingPlaceholder: resolvingPlaceholder
-      })))));
-    }
-    return jsx(SmartLinkDraggable, {
-      url: url,
-      appearance: SMART_LINK_APPEARANCE.INLINE,
-      source: SMART_LINK_DRAG_TYPES.RENDERER
-    }, jsx(AnalyticsContext, {
-      data: analyticsData
-    }, wrapWithSuspense(jsx(CardSSR, {
-      appearance: "inline",
-      url: url,
-      showHoverPreview: !hideHoverPreview,
-      actionOptions: actionOptions,
-      onClick: onClick,
-      resolvingPlaceholder: resolvingPlaceholder
-    })), CompetitorPromptComponent));
-  } else if ((ssr || cardState && expValEquals('platform_editor_smartlink_local_cache', 'isEnabled', true)) && url && editorExperiment('platform_editor_preview_panel_linking_exp', true, {
-    exposure: true
-  })) {
+  if ((ssr || cardState && expValEquals('platform_editor_smartlink_local_cache', 'isEnabled', true)) && url) {
     if (
     // eslint-disable-next-line @atlaskit/platform/no-invalid-feature-flag-usage
     fg('editor_inline_comments_on_inline_nodes')) {
@@ -389,10 +333,10 @@ var InlineCard = function InlineCard(props) {
         setIsResolvedViewRendered(true);
       }
     },
-    onError: onError,
-    disablePreviewPanel: editorExperiment('platform_editor_preview_panel_linking_exp', true, {
-      exposure: true
-    })
+    onError: onError
+    // Setting disablePreviewPanel={true} leaves the overlay button as the only way to open the panel.
+    ,
+    disablePreviewPanel: true
   })))), CompetitorPromptComponent))));
 };
 var _default_1 = withSmartCardStorage(InlineCard);

package/dist/esm/ui/Renderer/RendererStyleContainer.js

@@ -92,10 +92,17 @@ var baseStyles = css(_defineProperty(_defineProperty(_defineProperty(_defineProp
   clear: 'both'
 }), ".".concat(RendererCssClassName.DOCUMENT), _defineProperty(_defineProperty(_defineProperty(_defineProperty(_defineProperty(_defineProperty(_defineProperty(_defineProperty({}, "> [".concat(COLLAPSED_CONTENT_OWNERS_ATTRIBUTE, "][hidden='until-found']"), {
   display: 'block',
-  minBlockSize: 0,
-  marginBlock: 0,
-  paddingBlock: 0,
-  borderBlockWidth: 0
+  // `hidden='until-found'` maps to `content-visibility: hidden`, which skips the element's
+  // contents but keeps its own box, sized by its own specified sizes. Everything below
+  // needs `!important` because extension nodes are sized and spaced by declarations that
+  // would otherwise win: an inline `height`/`min-height` reserving macro height (see
+  // `react/nodes/extension.tsx`), and `!important` alignment margins from
+  // `@atlaskit/native-embeds-common`. Without it the collapsed section keeps a visible gap.
+  blockSize: '0 !important',
+  minBlockSize: '0 !important',
+  marginBlock: '0 !important',
+  paddingBlock: '0 !important',
+  borderBlockWidth: '0 !important'
 }), ".".concat(INLINE_IMAGE_WRAPPER_CLASS_NAME), {
   height: '22px',
   transform: "translateY(-2px)"
@@ -2280,7 +2287,7 @@ export var RendererStyleContainer = function RendererStyleContainer(props) {
     }),
     css: [expValEquals('confluence_ttvc_inline_extensions', 'isEnabled', true) ? baseFontStyle : originalBaseFontLineHeight, baseStyles, expValEquals('platform_editor_small_font_size', 'isEnabled', true) && fontSizeStyles, expValEquals('platform_editor_copy_link_a11y_inconsistency_fix', 'isEnabled', true) ? headingAnchorStyles : headingAnchorStylesDuplicateAnchor, headingAnchorButtonFocusVisibleStyles, expValEquals('platform_editor_copy_link_a11y_inconsistency_fix', 'isEnabled', true) ? hideHeadingCopyLinkWrapperStyles : hideHeadingCopyLinkWrapperStylesDuplicateAnchor, appearance === 'full-page' && isPreviewPanelResponsivenessOn && rendererFullPageStylesWithReducedPadding, appearance === 'full-page' && !isPreviewPanelResponsivenessOn && rendererFullPageStyles, appearance === 'full-width' && (expValEquals('platform_editor_remove_important_in_render_ext', 'isEnabled', true) ? rendererFullWidthStyles : oldRendererFullWidthStyles), (appearance === 'full-width' || appearance === 'max' && (expValEquals('editor_tinymce_full_width_mode', 'isEnabled', true) || expValEquals('confluence_max_width_content_appearance', 'isEnabled', true))) && !isTableResizingEnabled(appearance) && rendererFullWidthStylesForTableResizing, appearance === 'max' && (expValEquals('editor_tinymce_full_width_mode', 'isEnabled', true) || expValEquals('confluence_max_width_content_appearance', 'isEnabled', true)) && (expValEquals('platform_editor_remove_important_in_render_ext', 'isEnabled', true) ? rendererMaxWidthStyles : oldRendererMaxWidthStyles), rovoTelepointerStyles, whitespaceSharedStyles, blockquoteSharedStyles, headingsSharedStyles, expValEquals('platform_editor_copy_link_a11y_inconsistency_fix', 'isEnabled', true) && headingWrapperInlineFlowStyles, expValEquals('platform_editor_copy_link_a11y_inconsistency_fix', 'isEnabled', true) ? headingWithAlignmentStyles : headingWithAlignmentStylesDuplicateAnchor, ruleSharedStyles, contentMode === 'compact' && extensionStyle, contentMode === 'compact' ? paragraphStylesUGCScaledMargin : paragraphSharedStylesWithEditorUGC, listsSharedStyles, browser.gecko && listsSharedStylesForGekko, expValEquals('platform_editor_flexible_list_schema', 'isEnabled', true) && listItemHiddenMarkerStyles, indentationSharedStyles, indentationSharedStylesWithMarginFix, expValEquals('platform_editor_copy_link_a11y_inconsistency_fix', 'isEnabled', true) ? blockMarksSharedStyles : blockMarksSharedStylesDuplicateAnchor, codeMarkSharedStyles, shadowSharedStyle, dateSharedStyle, textColorStyles, backgroundColorStyles, !expValEquals('platform_editor_lovability_text_bg_color', 'isEnabled', true) && highlightLinksUnsetStyles,
     // eslint-disable-next-line @atlaskit/ui-styling-standard/no-imported-style-values
-    textHighlightPaddingStyles, tasksAndDecisionsStyles, expValEquals('platform_editor_copy_link_a11y_inconsistency_fix', 'isEnabled', true) && headingPanelStyles, smartCardStyles, smartCardStylesAvatarFix, editorExperiment('platform_editor_preview_panel_linking_exp', true) && headerSmartCardStyles, smartCardStylesAvatarMarginFix, smartCardStylesAvatarListZeroMarginTop, fg('editor_inline_comments_on_inline_nodes') && (expValEquals('confluence_fe_renderer_inline_node_mark_color_fix', 'isEnabled', true) ? rendererAnnotationStyles : rendererAnnotationStylesOld),
+    textHighlightPaddingStyles, tasksAndDecisionsStyles, expValEquals('platform_editor_copy_link_a11y_inconsistency_fix', 'isEnabled', true) && headingPanelStyles, smartCardStyles, smartCardStylesAvatarFix, headerSmartCardStyles, smartCardStylesAvatarMarginFix, smartCardStylesAvatarListZeroMarginTop, fg('editor_inline_comments_on_inline_nodes') && (expValEquals('confluence_fe_renderer_inline_node_mark_color_fix', 'isEnabled', true) ? rendererAnnotationStyles : rendererAnnotationStylesOld),
     // eslint-disable-next-line @atlaskit/platform/no-preconditioning
     fg('editor_inline_comments_on_inline_nodes') && rendererAnnotationStylesCommentHeightFix, expValEquals('platform_editor_copy_link_a11y_inconsistency_fix', 'isEnabled', true) ? baseOtherStyles : baseOtherStylesDuplicateAnchor, !expValEquals('platform_editor_flex_based_centering', 'isEnabled', true) && extensionCenterAlignLegacyStyles,
     // this should be placed after baseOtherStyles

package/dist/esm/ui/Renderer/index.js

@@ -65,7 +65,7 @@ export var DEGRADED_SEVERITY_THRESHOLD = 3000;
 var TABLE_INFO_TIMEOUT = 10000;
 var RENDER_EVENT_SAMPLE_RATE = 0.1;
 var packageName = "@atlaskit/renderer";
-var packageVersion = "136.2.1";
+var packageVersion = "136.2.3";
 var setAsQueryContainerStyles = css({
   containerName: 'ak-renderer-wrapper',
   containerType: 'inline-size'

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@atlaskit/renderer",
-	"version": "136.2.2",
+	"version": "136.2.4",
 	"description": "Renderer component",
 	"publishConfig": {
 		"registry": "https://registry.npmjs.org/"
@@ -50,7 +50,7 @@
 		"@atlaskit/feature-gate-js-client": "^6.0.0",
 		"@atlaskit/icon": "^37.5.0",
 		"@atlaskit/link": "^5.1.0",
-		"@atlaskit/link-datasource": "^6.6.0",
+		"@atlaskit/link-datasource": "^6.7.0",
 		"@atlaskit/link-extractors": "^4.1.0",
 		"@atlaskit/linking-common": "^12.0.0",
 		"@atlaskit/media-card": "^81.7.0",
@@ -70,7 +70,7 @@
 		"@atlaskit/status": "^5.8.0",
 		"@atlaskit/task-decision": "^21.8.0",
 		"@atlaskit/theme": "^28.1.0",
-		"@atlaskit/tmp-editor-statsig": "^157.0.0",
+		"@atlaskit/tmp-editor-statsig": "^158.0.0",
 		"@atlaskit/tokens": "^16.8.0",
 		"@atlaskit/tooltip": "^24.2.0",
 		"@atlaskit/visually-hidden": "^4.3.0",
@@ -85,7 +85,7 @@
 		"uuid": "^3.1.0"
 	},
 	"peerDependencies": {
-		"@atlaskit/editor-common": "^119.15.0",
+		"@atlaskit/editor-common": "^119.16.0",
 		"@atlaskit/link-provider": "^5.4.0",
 		"@atlaskit/media-core": "^38.0.0",
 		"react": "^18.2.0",
@@ -105,11 +105,11 @@
 		"@atlaskit/mention": "^27.18.0",
 		"@atlaskit/modal-dialog": "^16.5.0",
 		"@atlaskit/navigation-system": "^10.16.0",
-		"@atlaskit/profilecard": "^26.18.0",
+		"@atlaskit/profilecard": "^26.19.0",
 		"@atlaskit/side-nav-items": "^2.3.0",
 		"@atlaskit/util-data-test": "^19.1.0",
-		"@atlassian/a11y-jest-testing": "^0.16.0",
-		"@atlassian/a11y-playwright-testing": "^0.11.0",
+		"@atlassian/a11y-jest-testing": "^0.17.0",
+		"@atlassian/a11y-playwright-testing": "^0.12.0",
 		"@atlassian/experiment-test-utils": "^0.2.0",
 		"@atlassian/feature-flags-test-utils": "^1.2.0",
 		"@atlassian/structured-docs-types": "workspace:^",