@atlaskit/renderer 119.0.6 → 119.1.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
package/CHANGELOG.md CHANGED
@@ -1,5 +1,23 @@
1
1
  # @atlaskit/renderer
2
2
 
3
+ ## 119.1.0
4
+
5
+ ### Minor Changes
6
+
7
+ - [#174989](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/pull-requests/174989)
8
+ [`98dd1fb8d1e0c`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/98dd1fb8d1e0c) -
9
+ [ux] Keep focus on open text editor in comments panel when mouse hovers away
10
+
11
+ ## 119.0.7
12
+
13
+ ### Patch Changes
14
+
15
+ - [#176907](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/pull-requests/176907)
16
+ [`b3cdb5aa072a9`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/b3cdb5aa072a9) -
17
+ [ux] Adjust non-empty selection validation logic for the renderer, to disallow annotations on
18
+ empty block nodes like table cells and expands
19
+ - Updated dependencies
20
+
3
21
  ## 119.0.6
4
22
 
5
23
  ### Patch Changes
@@ -69,8 +69,9 @@ var RendererActions = exports.default = /*#__PURE__*/function () {
69
69
  if (!this.doc || !this.schema) {
70
70
  return false;
71
71
  }
72
+ var isEmptyTextSelectionCheck = (0, _platformFeatureFlags.fg)('cc_comments_more_complete_empty_text_check') ? _utils.isEmptyTextSelectionRenderer : _utils.isEmptyTextSelection;
72
73
  var currentSelection = _state.TextSelection.create(this.doc, from, to);
73
- if ((0, _utils.isEmptyTextSelection)(currentSelection, this.schema)) {
74
+ if (isEmptyTextSelectionCheck(currentSelection, this.schema)) {
74
75
  return false;
75
76
  }
76
77
  var result = (0, _utils.canApplyAnnotationOnRange)({
@@ -14,7 +14,6 @@ var _defineProperty2 = _interopRequireDefault(require("@babel/runtime/helpers/de
14
14
  var _react = _interopRequireDefault(require("react"));
15
15
  var _utils = require("@atlaskit/editor-common/utils");
16
16
  var _types = require("@atlaskit/editor-common/types");
17
- var _platformFeatureFlags = require("@atlaskit/platform-feature-flags");
18
17
  var _consts = require("../../consts");
19
18
  function _callSuper(t, o, e) { return o = (0, _getPrototypeOf2.default)(o), (0, _possibleConstructorReturn2.default)(t, _isNativeReflectConstruct() ? Reflect.construct(o, e || [], (0, _getPrototypeOf2.default)(t).constructor) : o.apply(t, e)); }
20
19
  function _isNativeReflectConstruct() { try { var t = !Boolean.prototype.valueOf.call(Reflect.construct(Boolean, [], function () {})); } catch (t) {} return (_isNativeReflectConstruct = function _isNativeReflectConstruct() { return !!t; })(); }
@@ -36,7 +35,7 @@ var TableRow = exports.default = /*#__PURE__*/function (_React$Component) {
36
35
  allowColumnSorting = _this$props.allowColumnSorting,
37
36
  rowIndex = _this$props.index;
38
37
  var isHeaderRow = !rowIndex;
39
- if (allowColumnSorting && (!(0, _platformFeatureFlags.fg)('cc_complexit_fe_improve_table_sorting') || isHeaderRow)) {
38
+ if (allowColumnSorting && isHeaderRow) {
40
39
  childrenArray = childrenArray.map(function (child, index) {
41
40
  if ( /*#__PURE__*/_react.default.isValidElement(child)) {
42
41
  var tableOrderStatus = _this.props.tableOrderStatus;
@@ -62,7 +62,7 @@ function _objectSpread(e) { for (var r = 1; r < arguments.length; r++) { var t =
62
62
  var NORMAL_SEVERITY_THRESHOLD = exports.NORMAL_SEVERITY_THRESHOLD = 2000;
63
63
  var DEGRADED_SEVERITY_THRESHOLD = exports.DEGRADED_SEVERITY_THRESHOLD = 3000;
64
64
  var packageName = "@atlaskit/renderer";
65
- var packageVersion = "119.0.5";
65
+ var packageVersion = "119.0.7";
66
66
  var setAsQueryContainerStyles = (0, _react2.css)({
67
67
  containerName: 'ak-renderer-wrapper',
68
68
  containerType: 'inline-size'
@@ -12,6 +12,7 @@ var _types = require("@atlaskit/editor-common/types");
12
12
  var _adfSchema = require("@atlaskit/adf-schema");
13
13
  var _analytics = require("@atlaskit/editor-common/analytics");
14
14
  var _types2 = require("@atlaskit/analytics-listeners/types");
15
+ var _platformFeatureFlags = require("@atlaskit/platform-feature-flags");
15
16
  var _AnnotationManagerContext = require("../contexts/AnnotationManagerContext");
16
17
  function ownKeys(e, r) { var t = Object.keys(e); if (Object.getOwnPropertySymbols) { var o = Object.getOwnPropertySymbols(e); r && (o = o.filter(function (r) { return Object.getOwnPropertyDescriptor(e, r).enumerable; })), t.push.apply(t, o); } return t; }
17
18
  function _objectSpread(e) { for (var r = 1; r < arguments.length; r++) { var t = null != arguments[r] ? arguments[r] : {}; r % 2 ? ownKeys(Object(t), !0).forEach(function (r) { (0, _defineProperty2.default)(e, r, t[r]); }) : Object.getOwnPropertyDescriptors ? Object.defineProperties(e, Object.getOwnPropertyDescriptors(t)) : ownKeys(Object(t)).forEach(function (r) { Object.defineProperty(e, r, Object.getOwnPropertyDescriptor(t, r)); }); } return e; }
@@ -99,7 +100,7 @@ var useHasFocusEvent = exports.useHasFocusEvent = function useHasFocusEvent(_ref
99
100
  };
100
101
  var removeHoverEffect = function removeHoverEffect() {
101
102
  setIsHovered(false);
102
- if (document.activeElement instanceof HTMLElement) {
103
+ if (document.activeElement instanceof HTMLElement && !(0, _platformFeatureFlags.fg)('confluence_frontend_comments_panel_editor_focus')) {
103
104
  document.activeElement.blur();
104
105
  }
105
106
  };
@@ -1,6 +1,6 @@
1
1
  import _defineProperty from "@babel/runtime/helpers/defineProperty";
2
2
  import { AnnotationTypes } from '@atlaskit/adf-schema';
3
- import { canApplyAnnotationOnRange, getAnnotationIdsFromRange, getAnnotationInlineNodeTypes, isEmptyTextSelection } from '@atlaskit/editor-common/utils';
3
+ import { canApplyAnnotationOnRange, getAnnotationIdsFromRange, getAnnotationInlineNodeTypes, isEmptyTextSelection, isEmptyTextSelectionRenderer } from '@atlaskit/editor-common/utils';
4
4
  import { JSONTransformer } from '@atlaskit/editor-json-transformer';
5
5
  import { TextSelection } from '@atlaskit/editor-prosemirror/state';
6
6
  import { ACTION, ACTION_SUBJECT, ACTION_SUBJECT_ID, EVENT_TYPE } from '@atlaskit/editor-common/analytics';
@@ -49,8 +49,9 @@ export default class RendererActions {
49
49
  if (!this.doc || !this.schema) {
50
50
  return false;
51
51
  }
52
+ const isEmptyTextSelectionCheck = fg('cc_comments_more_complete_empty_text_check') ? isEmptyTextSelectionRenderer : isEmptyTextSelection;
52
53
  const currentSelection = TextSelection.create(this.doc, from, to);
53
- if (isEmptyTextSelection(currentSelection, this.schema)) {
54
+ if (isEmptyTextSelectionCheck(currentSelection, this.schema)) {
54
55
  return false;
55
56
  }
56
57
  const result = canApplyAnnotationOnRange({
@@ -2,7 +2,6 @@ import _defineProperty from "@babel/runtime/helpers/defineProperty";
2
2
  import React from 'react';
3
3
  import { compose } from '@atlaskit/editor-common/utils';
4
4
  import { SortOrder } from '@atlaskit/editor-common/types';
5
- import { fg } from '@atlaskit/platform-feature-flags';
6
5
  import { RendererCssClassName } from '../../consts';
7
6
  // Ignored via go/ees005
8
7
  // eslint-disable-next-line @repo/internal/react/no-class-components
@@ -18,7 +17,7 @@ export default class TableRow extends React.Component {
18
17
  index: rowIndex
19
18
  } = this.props;
20
19
  const isHeaderRow = !rowIndex;
21
- if (allowColumnSorting && (!fg('cc_complexit_fe_improve_table_sorting') || isHeaderRow)) {
20
+ if (allowColumnSorting && isHeaderRow) {
22
21
  childrenArray = childrenArray.map((child, index) => {
23
22
  if ( /*#__PURE__*/React.isValidElement(child)) {
24
23
  const {
@@ -48,7 +48,7 @@ import { PortalContext } from './PortalContext';
48
48
  export const NORMAL_SEVERITY_THRESHOLD = 2000;
49
49
  export const DEGRADED_SEVERITY_THRESHOLD = 3000;
50
50
  const packageName = "@atlaskit/renderer";
51
- const packageVersion = "119.0.5";
51
+ const packageVersion = "119.0.7";
52
52
  const setAsQueryContainerStyles = css({
53
53
  containerName: 'ak-renderer-wrapper',
54
54
  containerType: 'inline-size'
@@ -3,6 +3,7 @@ import { AnnotationUpdateEvent } from '@atlaskit/editor-common/types';
3
3
  import { AnnotationTypes } from '@atlaskit/adf-schema';
4
4
  import { ACTION, ACTION_SUBJECT, EVENT_TYPE, ACTION_SUBJECT_ID } from '@atlaskit/editor-common/analytics';
5
5
  import { FabricChannel } from '@atlaskit/analytics-listeners/types';
6
+ import { fg } from '@atlaskit/platform-feature-flags';
6
7
  import { useAnnotationManagerDispatch, useAnnotationManagerState } from '../contexts/AnnotationManagerContext';
7
8
  export const useAnnotationStateByTypeEvent = ({
8
9
  type,
@@ -94,7 +95,7 @@ export const useHasFocusEvent = ({
94
95
  };
95
96
  const removeHoverEffect = () => {
96
97
  setIsHovered(false);
97
- if (document.activeElement instanceof HTMLElement) {
98
+ if (document.activeElement instanceof HTMLElement && !fg('confluence_frontend_comments_panel_editor_focus')) {
98
99
  document.activeElement.blur();
99
100
  }
100
101
  };
@@ -5,7 +5,7 @@ import _defineProperty from "@babel/runtime/helpers/defineProperty";
5
5
  function ownKeys(e, r) { var t = Object.keys(e); if (Object.getOwnPropertySymbols) { var o = Object.getOwnPropertySymbols(e); r && (o = o.filter(function (r) { return Object.getOwnPropertyDescriptor(e, r).enumerable; })), t.push.apply(t, o); } return t; }
6
6
  function _objectSpread(e) { for (var r = 1; r < arguments.length; r++) { var t = null != arguments[r] ? arguments[r] : {}; r % 2 ? ownKeys(Object(t), !0).forEach(function (r) { _defineProperty(e, r, t[r]); }) : Object.getOwnPropertyDescriptors ? Object.defineProperties(e, Object.getOwnPropertyDescriptors(t)) : ownKeys(Object(t)).forEach(function (r) { Object.defineProperty(e, r, Object.getOwnPropertyDescriptor(t, r)); }); } return e; }
7
7
  import { AnnotationTypes } from '@atlaskit/adf-schema';
8
- import { canApplyAnnotationOnRange, getAnnotationIdsFromRange, getAnnotationInlineNodeTypes, isEmptyTextSelection } from '@atlaskit/editor-common/utils';
8
+ import { canApplyAnnotationOnRange, getAnnotationIdsFromRange, getAnnotationInlineNodeTypes, isEmptyTextSelection, isEmptyTextSelectionRenderer } from '@atlaskit/editor-common/utils';
9
9
  import { JSONTransformer } from '@atlaskit/editor-json-transformer';
10
10
  import { TextSelection } from '@atlaskit/editor-prosemirror/state';
11
11
  import { ACTION, ACTION_SUBJECT, ACTION_SUBJECT_ID, EVENT_TYPE } from '@atlaskit/editor-common/analytics';
@@ -62,8 +62,9 @@ var RendererActions = /*#__PURE__*/function () {
62
62
  if (!this.doc || !this.schema) {
63
63
  return false;
64
64
  }
65
+ var isEmptyTextSelectionCheck = fg('cc_comments_more_complete_empty_text_check') ? isEmptyTextSelectionRenderer : isEmptyTextSelection;
65
66
  var currentSelection = TextSelection.create(this.doc, from, to);
66
- if (isEmptyTextSelection(currentSelection, this.schema)) {
67
+ if (isEmptyTextSelectionCheck(currentSelection, this.schema)) {
67
68
  return false;
68
69
  }
69
70
  var result = canApplyAnnotationOnRange({
@@ -9,7 +9,6 @@ function _isNativeReflectConstruct() { try { var t = !Boolean.prototype.valueOf.
9
9
  import React from 'react';
10
10
  import { compose } from '@atlaskit/editor-common/utils';
11
11
  import { SortOrder } from '@atlaskit/editor-common/types';
12
- import { fg } from '@atlaskit/platform-feature-flags';
13
12
  import { RendererCssClassName } from '../../consts';
14
13
  // Ignored via go/ees005
15
14
  // eslint-disable-next-line @repo/internal/react/no-class-components
@@ -29,7 +28,7 @@ var TableRow = /*#__PURE__*/function (_React$Component) {
29
28
  allowColumnSorting = _this$props.allowColumnSorting,
30
29
  rowIndex = _this$props.index;
31
30
  var isHeaderRow = !rowIndex;
32
- if (allowColumnSorting && (!fg('cc_complexit_fe_improve_table_sorting') || isHeaderRow)) {
31
+ if (allowColumnSorting && isHeaderRow) {
33
32
  childrenArray = childrenArray.map(function (child, index) {
34
33
  if ( /*#__PURE__*/React.isValidElement(child)) {
35
34
  var tableOrderStatus = _this.props.tableOrderStatus;
@@ -53,7 +53,7 @@ import { PortalContext } from './PortalContext';
53
53
  export var NORMAL_SEVERITY_THRESHOLD = 2000;
54
54
  export var DEGRADED_SEVERITY_THRESHOLD = 3000;
55
55
  var packageName = "@atlaskit/renderer";
56
- var packageVersion = "119.0.5";
56
+ var packageVersion = "119.0.7";
57
57
  var setAsQueryContainerStyles = css({
58
58
  containerName: 'ak-renderer-wrapper',
59
59
  containerType: 'inline-size'
@@ -7,6 +7,7 @@ import { AnnotationUpdateEvent } from '@atlaskit/editor-common/types';
7
7
  import { AnnotationTypes } from '@atlaskit/adf-schema';
8
8
  import { ACTION, ACTION_SUBJECT, EVENT_TYPE, ACTION_SUBJECT_ID } from '@atlaskit/editor-common/analytics';
9
9
  import { FabricChannel } from '@atlaskit/analytics-listeners/types';
10
+ import { fg } from '@atlaskit/platform-feature-flags';
10
11
  import { useAnnotationManagerDispatch, useAnnotationManagerState } from '../contexts/AnnotationManagerContext';
11
12
  export var useAnnotationStateByTypeEvent = function useAnnotationStateByTypeEvent(_ref) {
12
13
  var type = _ref.type,
@@ -92,7 +93,7 @@ export var useHasFocusEvent = function useHasFocusEvent(_ref2) {
92
93
  };
93
94
  var removeHoverEffect = function removeHoverEffect() {
94
95
  setIsHovered(false);
95
- if (document.activeElement instanceof HTMLElement) {
96
+ if (document.activeElement instanceof HTMLElement && !fg('confluence_frontend_comments_panel_editor_focus')) {
96
97
  document.activeElement.blur();
97
98
  }
98
99
  };
package/package.json CHANGED
@@ -1,6 +1,6 @@
1
1
  {
2
2
  "name": "@atlaskit/renderer",
3
- "version": "119.0.6",
3
+ "version": "119.1.0",
4
4
  "description": "Renderer component",
5
5
  "publishConfig": {
6
6
  "registry": "https://registry.npmjs.org/"
@@ -133,10 +133,10 @@
133
133
  "cc_comments_improve_apply_draft_errors": {
134
134
  "type": "boolean"
135
135
  },
136
- "platform-ssr-table-resize": {
136
+ "cc_comments_more_complete_empty_text_check": {
137
137
  "type": "boolean"
138
138
  },
139
- "cc_complexit_fe_improve_table_sorting": {
139
+ "platform-ssr-table-resize": {
140
140
  "type": "boolean"
141
141
  },
142
142
  "cc_complexit_reduce_portal_rerenders": {
@@ -268,6 +268,9 @@
268
268
  },
269
269
  "issue_table_single_line_row_height_fast_follows": {
270
270
  "type": "boolean"
271
+ },
272
+ "confluence_frontend_comments_panel_editor_focus": {
273
+ "type": "boolean"
271
274
  }
272
275
  },
273
276
  "af:exports": {