@atlaskit/renderer 114.6.3 → 114.7.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
package/CHANGELOG.md CHANGED
@@ -1,5 +1,25 @@
1
1
  # @atlaskit/renderer
2
2
 
3
+ ## 114.7.0
4
+
5
+ ### Minor Changes
6
+
7
+ - [#133705](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/pull-requests/133705)
8
+ [`a78567c4a63e2`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/a78567c4a63e2) -
9
+ Reduced the shadows for inline comments
10
+
11
+ ### Patch Changes
12
+
13
+ - Updated dependencies
14
+
15
+ ## 114.6.4
16
+
17
+ ### Patch Changes
18
+
19
+ - [#131961](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/pull-requests/131961)
20
+ [`4d3050222b5bc`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/4d3050222b5bc) -
21
+ fixed issue where providerFactory needed to be passed fresh on every render
22
+
3
23
  ## 114.6.3
4
24
 
5
25
  ### Patch Changes
@@ -67,7 +67,7 @@ function _isNativeReflectConstruct() { try { var t = !Boolean.prototype.valueOf.
67
67
  var NORMAL_SEVERITY_THRESHOLD = exports.NORMAL_SEVERITY_THRESHOLD = 2000;
68
68
  var DEGRADED_SEVERITY_THRESHOLD = exports.DEGRADED_SEVERITY_THRESHOLD = 3000;
69
69
  var packageName = "@atlaskit/renderer";
70
- var packageVersion = "114.6.3";
70
+ var packageVersion = "114.7.0";
71
71
  var setAsQueryContainerStyles = (0, _react2.css)({
72
72
  containerName: 'ak-renderer-wrapper',
73
73
  containerType: 'inline-size',
@@ -753,7 +753,11 @@ var RendererFunctionalComponent = function RendererFunctionalComponent(props) {
753
753
  if (rafID) {
754
754
  window.cancelAnimationFrame(rafID);
755
755
  }
756
- if (dataProviders) {
756
+
757
+ // if this is the ProviderFactory which was created in constructor
758
+ // it's safe to destroy it on Renderer unmount
759
+ // updated to match existing class component
760
+ if (!dataProviders) {
757
761
  providerFactory.destroy();
758
762
  }
759
763
  };
@@ -44,6 +44,14 @@ var markStylesNew = (0, _react2.css)((0, _defineProperty2.default)({
44
44
  cursor: 'pointer'
45
45
  }
46
46
  }));
47
+ var markStylesWithUpdatedShadow = (0, _react2.css)((0, _defineProperty2.default)({}, "&[data-mark-annotation-state='".concat(_adfSchema.AnnotationMarkStates.ACTIVE, "']"), {
48
+ // eslint-disable-next-line @atlaskit/ui-styling-standard/no-nested-selectors
49
+ '&:focus, &[data-has-focus="true"]': {
50
+ background: "var(--ds-background-accent-yellow-subtlest-pressed, #F5CD47)",
51
+ borderBottomColor: "var(--ds-border-accent-yellow, #B38600)",
52
+ boxShadow: "var(--ds-shadow-raised, 0px 1px 1px #091E4240, 0px 0px 1px #091E424f)"
53
+ }
54
+ }));
47
55
  var markStylesNewWithInlineComments = (0, _react2.css)((0, _defineProperty2.default)({}, "&[data-mark-annotation-state='".concat(_adfSchema.AnnotationMarkStates.ACTIVE, "']"), {
48
56
  // was from common in AnnotationSharedCSSByState().common
49
57
  borderBottom: '2px solid transparent',
@@ -208,7 +216,7 @@ var MarkComponent = exports.MarkComponent = function MarkComponent(_ref) {
208
216
  return (0, _react2.jsx)(useBlockLevel ? 'div' : 'mark', _objectSpread(_objectSpread(_objectSpread((0, _defineProperty2.default)({
209
217
  id: id
210
218
  }, (0, _platformFeatureFlags.fg)('editor_inline_comments_on_inline_nodes') ? 'onClickCapture' : 'onClick', onMarkClick), accessibility), overriddenData), !useBlockLevel && {
211
- css: [markStylesNew, (0, _platformFeatureFlags.fg)('editor_inline_comments_on_inline_nodes') && markStylesNewWithInlineComments, (0, _platformFeatureFlags.fg)('confluence-frontend-comments-panel') && markStylesNewWithCommentsPanel, !isMobile() && accessibilityStylesNew],
219
+ css: [markStylesNew, (0, _platformFeatureFlags.fg)('editor_inline_comments_on_inline_nodes') && markStylesNewWithInlineComments, (0, _platformFeatureFlags.fg)('confluence-frontend-comments-panel') && markStylesNewWithCommentsPanel, !isMobile() && accessibilityStylesNew, (0, _platformFeatureFlags.fg)('inline_comment_shadow_update') && markStylesWithUpdatedShadow],
212
220
  style: {
213
221
  '--ak-renderer-annotation-startmarker': intl.formatMessage(_messages.inlineCommentMessages.contentRendererInlineCommentMarkerStart),
214
222
  '--ak-renderer-annotation-endmarker': intl.formatMessage(_messages.inlineCommentMessages.contentRendererInlineCommentMarkerEnd)
@@ -48,7 +48,7 @@ import { removeEmptySpaceAroundContent } from './rendererHelper';
48
48
  export const NORMAL_SEVERITY_THRESHOLD = 2000;
49
49
  export const DEGRADED_SEVERITY_THRESHOLD = 3000;
50
50
  const packageName = "@atlaskit/renderer";
51
- const packageVersion = "114.6.3";
51
+ const packageVersion = "114.7.0";
52
52
  const setAsQueryContainerStyles = css({
53
53
  containerName: 'ak-renderer-wrapper',
54
54
  containerType: 'inline-size',
@@ -732,7 +732,11 @@ const RendererFunctionalComponent = props => {
732
732
  if (rafID) {
733
733
  window.cancelAnimationFrame(rafID);
734
734
  }
735
- if (dataProviders) {
735
+
736
+ // if this is the ProviderFactory which was created in constructor
737
+ // it's safe to destroy it on Renderer unmount
738
+ // updated to match existing class component
739
+ if (!dataProviders) {
736
740
  providerFactory.destroy();
737
741
  }
738
742
  };
@@ -49,6 +49,17 @@ const markStylesNew = css({
49
49
  }
50
50
  }
51
51
  });
52
+ const markStylesWithUpdatedShadow = css({
53
+ // eslint-disable-next-line @atlaskit/ui-styling-standard/no-nested-selectors, @atlaskit/ui-styling-standard/no-unsafe-values, @atlaskit/ui-styling-standard/no-imported-style-values
54
+ [`&[data-mark-annotation-state='${AnnotationMarkStates.ACTIVE}']`]: {
55
+ // eslint-disable-next-line @atlaskit/ui-styling-standard/no-nested-selectors
56
+ '&:focus, &[data-has-focus="true"]': {
57
+ background: "var(--ds-background-accent-yellow-subtlest-pressed, #F5CD47)",
58
+ borderBottomColor: "var(--ds-border-accent-yellow, #B38600)",
59
+ boxShadow: "var(--ds-shadow-raised, 0px 1px 1px #091E4240, 0px 0px 1px #091E424f)"
60
+ }
61
+ }
62
+ });
52
63
  const markStylesNewWithInlineComments = css({
53
64
  // eslint-disable-next-line @atlaskit/ui-styling-standard/no-nested-selectors, @atlaskit/ui-styling-standard/no-unsafe-values, @atlaskit/ui-styling-standard/no-imported-style-values
54
65
  [`&[data-mark-annotation-state='${AnnotationMarkStates.ACTIVE}']`]: {
@@ -221,7 +232,7 @@ export const MarkComponent = ({
221
232
  ...accessibility,
222
233
  ...overriddenData,
223
234
  ...(!useBlockLevel && {
224
- css: [markStylesNew, fg('editor_inline_comments_on_inline_nodes') && markStylesNewWithInlineComments, fg('confluence-frontend-comments-panel') && markStylesNewWithCommentsPanel, !isMobile() && accessibilityStylesNew],
235
+ css: [markStylesNew, fg('editor_inline_comments_on_inline_nodes') && markStylesNewWithInlineComments, fg('confluence-frontend-comments-panel') && markStylesNewWithCommentsPanel, !isMobile() && accessibilityStylesNew, fg('inline_comment_shadow_update') && markStylesWithUpdatedShadow],
225
236
  style: {
226
237
  '--ak-renderer-annotation-startmarker': intl.formatMessage(inlineCommentMessages.contentRendererInlineCommentMarkerStart),
227
238
  '--ak-renderer-annotation-endmarker': intl.formatMessage(inlineCommentMessages.contentRendererInlineCommentMarkerEnd)
@@ -57,7 +57,7 @@ import { removeEmptySpaceAroundContent } from './rendererHelper';
57
57
  export var NORMAL_SEVERITY_THRESHOLD = 2000;
58
58
  export var DEGRADED_SEVERITY_THRESHOLD = 3000;
59
59
  var packageName = "@atlaskit/renderer";
60
- var packageVersion = "114.6.3";
60
+ var packageVersion = "114.7.0";
61
61
  var setAsQueryContainerStyles = css({
62
62
  containerName: 'ak-renderer-wrapper',
63
63
  containerType: 'inline-size',
@@ -743,7 +743,11 @@ var RendererFunctionalComponent = function RendererFunctionalComponent(props) {
743
743
  if (rafID) {
744
744
  window.cancelAnimationFrame(rafID);
745
745
  }
746
- if (dataProviders) {
746
+
747
+ // if this is the ProviderFactory which was created in constructor
748
+ // it's safe to destroy it on Renderer unmount
749
+ // updated to match existing class component
750
+ if (!dataProviders) {
747
751
  providerFactory.destroy();
748
752
  }
749
753
  };
@@ -38,6 +38,14 @@ var markStylesNew = css(_defineProperty({
38
38
  cursor: 'pointer'
39
39
  }
40
40
  }));
41
+ var markStylesWithUpdatedShadow = css(_defineProperty({}, "&[data-mark-annotation-state='".concat(AnnotationMarkStates.ACTIVE, "']"), {
42
+ // eslint-disable-next-line @atlaskit/ui-styling-standard/no-nested-selectors
43
+ '&:focus, &[data-has-focus="true"]': {
44
+ background: "var(--ds-background-accent-yellow-subtlest-pressed, #F5CD47)",
45
+ borderBottomColor: "var(--ds-border-accent-yellow, #B38600)",
46
+ boxShadow: "var(--ds-shadow-raised, 0px 1px 1px #091E4240, 0px 0px 1px #091E424f)"
47
+ }
48
+ }));
41
49
  var markStylesNewWithInlineComments = css(_defineProperty({}, "&[data-mark-annotation-state='".concat(AnnotationMarkStates.ACTIVE, "']"), {
42
50
  // was from common in AnnotationSharedCSSByState().common
43
51
  borderBottom: '2px solid transparent',
@@ -202,7 +210,7 @@ export var MarkComponent = function MarkComponent(_ref) {
202
210
  return jsx(useBlockLevel ? 'div' : 'mark', _objectSpread(_objectSpread(_objectSpread(_defineProperty({
203
211
  id: id
204
212
  }, fg('editor_inline_comments_on_inline_nodes') ? 'onClickCapture' : 'onClick', onMarkClick), accessibility), overriddenData), !useBlockLevel && {
205
- css: [markStylesNew, fg('editor_inline_comments_on_inline_nodes') && markStylesNewWithInlineComments, fg('confluence-frontend-comments-panel') && markStylesNewWithCommentsPanel, !isMobile() && accessibilityStylesNew],
213
+ css: [markStylesNew, fg('editor_inline_comments_on_inline_nodes') && markStylesNewWithInlineComments, fg('confluence-frontend-comments-panel') && markStylesNewWithCommentsPanel, !isMobile() && accessibilityStylesNew, fg('inline_comment_shadow_update') && markStylesWithUpdatedShadow],
206
214
  style: {
207
215
  '--ak-renderer-annotation-startmarker': intl.formatMessage(inlineCommentMessages.contentRendererInlineCommentMarkerStart),
208
216
  '--ak-renderer-annotation-endmarker': intl.formatMessage(inlineCommentMessages.contentRendererInlineCommentMarkerEnd)
package/package.json CHANGED
@@ -1,6 +1,6 @@
1
1
  {
2
2
  "name": "@atlaskit/renderer",
3
- "version": "114.6.3",
3
+ "version": "114.7.0",
4
4
  "description": "Renderer component",
5
5
  "publishConfig": {
6
6
  "registry": "https://registry.npmjs.org/"
@@ -31,14 +31,14 @@
31
31
  "@atlaskit/analytics-next": "^11.0.0",
32
32
  "@atlaskit/button": "^22.0.0",
33
33
  "@atlaskit/code": "^16.1.0",
34
- "@atlaskit/editor-common": "^102.15.0",
34
+ "@atlaskit/editor-common": "^102.16.0",
35
35
  "@atlaskit/editor-json-transformer": "^8.24.0",
36
36
  "@atlaskit/editor-palette": "^2.1.0",
37
37
  "@atlaskit/editor-prosemirror": "7.0.0",
38
38
  "@atlaskit/editor-shared-styles": "^3.4.0",
39
39
  "@atlaskit/emoji": "^69.0.0",
40
40
  "@atlaskit/feature-gate-js-client": "^5.0.0",
41
- "@atlaskit/icon": "^25.3.0",
41
+ "@atlaskit/icon": "^25.4.0",
42
42
  "@atlaskit/link-datasource": "^4.1.0",
43
43
  "@atlaskit/media-card": "^79.0.0",
44
44
  "@atlaskit/media-client": "^32.0.0",
@@ -54,7 +54,7 @@
54
54
  "@atlaskit/status": "^3.0.0",
55
55
  "@atlaskit/task-decision": "^19.1.0",
56
56
  "@atlaskit/theme": "^18.0.0",
57
- "@atlaskit/tmp-editor-statsig": "^4.5.0",
57
+ "@atlaskit/tmp-editor-statsig": "^4.6.0",
58
58
  "@atlaskit/tokens": "^4.5.0",
59
59
  "@atlaskit/tooltip": "^20.0.0",
60
60
  "@atlaskit/visually-hidden": "^3.0.0",
@@ -201,6 +201,9 @@
201
201
  "platform_editor_tables_numbered_column_correction": {
202
202
  "type": "boolean"
203
203
  },
204
+ "inline_comment_shadow_update": {
205
+ "type": "boolean"
206
+ },
204
207
  "platform_renderer_isPresentational": {
205
208
  "type": "boolean"
206
209
  }