@atlaskit/renderer 112.1.0 → 112.2.0

package/CHANGELOG.md

@@ -1,5 +1,18 @@
 # @atlaskit/renderer
 
+## 112.2.0
+
+### Minor Changes
+
+- [#152319](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/pull-requests/152319)
+  [`bfa9c49e1928b`](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/commits/bfa9c49e1928b) -
+  [ux] Added a check to handle the case where a single non-breaking space is selected and the user
+  attempts to leave a comment on it.
+
+### Patch Changes
+
+- Updated dependencies
+
 ## 112.1.0
 
 ### Minor Changes

package/dist/cjs/actions/index.js

@@ -12,6 +12,7 @@ var _defineProperty2 = _interopRequireDefault(require("@babel/runtime/helpers/de
 var _editorJsonTransformer = require("@atlaskit/editor-json-transformer");
 var _utils = require("@atlaskit/editor-common/utils");
 var _adfSchema = require("@atlaskit/adf-schema");
+var _state = require("@atlaskit/editor-prosemirror/state");
 var _transform = require("@atlaskit/editor-prosemirror/transform");
 var _steps = require("../steps");
 var _analytics = require("@atlaskit/editor-common/analytics");
@@ -66,6 +67,12 @@ var RendererActions = exports.default = /*#__PURE__*/function () {
       if (!this.doc || !this.schema) {
         return false;
       }
+      if ((0, _platformFeatureFlags.fg)('forbid_comments_on_empty_newlines')) {
+        var currentSelection = _state.TextSelection.create(this.doc, from, to);
+        if ((0, _utils.isEmptyTextSelection)(currentSelection, this.schema)) {
+          return false;
+        }
+      }
       return (0, _utils.canApplyAnnotationOnRange)({
         from: from,
         to: to

package/dist/cjs/ui/Renderer/index.js

@@ -65,7 +65,7 @@ function _isNativeReflectConstruct() { try { var t = !Boolean.prototype.valueOf.
 var NORMAL_SEVERITY_THRESHOLD = exports.NORMAL_SEVERITY_THRESHOLD = 2000;
 var DEGRADED_SEVERITY_THRESHOLD = exports.DEGRADED_SEVERITY_THRESHOLD = 3000;
 var packageName = "@atlaskit/renderer";
-var packageVersion = "112.1.0";
+var packageVersion = "112.2.0";
 var setAsQueryContainerStyles = (0, _react2.css)({
   containerName: 'ak-renderer-wrapper',
   containerType: 'inline-size',

package/dist/es2019/actions/index.js

@@ -1,7 +1,8 @@
 import _defineProperty from "@babel/runtime/helpers/defineProperty";
 import { JSONTransformer } from '@atlaskit/editor-json-transformer';
-import { canApplyAnnotationOnRange, getAnnotationIdsFromRange, getAnnotationInlineNodeTypes } from '@atlaskit/editor-common/utils';
+import { canApplyAnnotationOnRange, getAnnotationIdsFromRange, getAnnotationInlineNodeTypes, isEmptyTextSelection } from '@atlaskit/editor-common/utils';
 import { AnnotationTypes } from '@atlaskit/adf-schema';
+import { TextSelection } from '@atlaskit/editor-prosemirror/state';
 import { AddNodeMarkStep, RemoveMarkStep, RemoveNodeMarkStep } from '@atlaskit/editor-prosemirror/transform';
 import { createAnnotationStep, getPosFromRange } from '../steps';
 import { ACTION, ACTION_SUBJECT, EVENT_TYPE, ACTION_SUBJECT_ID } from '@atlaskit/editor-common/analytics';
@@ -46,6 +47,12 @@ export default class RendererActions {
     if (!this.doc || !this.schema) {
       return false;
     }
+    if (fg('forbid_comments_on_empty_newlines')) {
+      const currentSelection = TextSelection.create(this.doc, from, to);
+      if (isEmptyTextSelection(currentSelection, this.schema)) {
+        return false;
+      }
+    }
     return canApplyAnnotationOnRange({
       from,
       to

package/dist/es2019/ui/Renderer/index.js

@@ -45,7 +45,7 @@ import { countNodes } from './count-nodes';
 export const NORMAL_SEVERITY_THRESHOLD = 2000;
 export const DEGRADED_SEVERITY_THRESHOLD = 3000;
 const packageName = "@atlaskit/renderer";
-const packageVersion = "112.1.0";
+const packageVersion = "112.2.0";
 const setAsQueryContainerStyles = css({
   containerName: 'ak-renderer-wrapper',
   containerType: 'inline-size',

package/dist/esm/actions/index.js

@@ -5,8 +5,9 @@ import _defineProperty from "@babel/runtime/helpers/defineProperty";
 function ownKeys(e, r) { var t = Object.keys(e); if (Object.getOwnPropertySymbols) { var o = Object.getOwnPropertySymbols(e); r && (o = o.filter(function (r) { return Object.getOwnPropertyDescriptor(e, r).enumerable; })), t.push.apply(t, o); } return t; }
 function _objectSpread(e) { for (var r = 1; r < arguments.length; r++) { var t = null != arguments[r] ? arguments[r] : {}; r % 2 ? ownKeys(Object(t), !0).forEach(function (r) { _defineProperty(e, r, t[r]); }) : Object.getOwnPropertyDescriptors ? Object.defineProperties(e, Object.getOwnPropertyDescriptors(t)) : ownKeys(Object(t)).forEach(function (r) { Object.defineProperty(e, r, Object.getOwnPropertyDescriptor(t, r)); }); } return e; }
 import { JSONTransformer } from '@atlaskit/editor-json-transformer';
-import { canApplyAnnotationOnRange, getAnnotationIdsFromRange, getAnnotationInlineNodeTypes } from '@atlaskit/editor-common/utils';
+import { canApplyAnnotationOnRange, getAnnotationIdsFromRange, getAnnotationInlineNodeTypes, isEmptyTextSelection } from '@atlaskit/editor-common/utils';
 import { AnnotationTypes } from '@atlaskit/adf-schema';
+import { TextSelection } from '@atlaskit/editor-prosemirror/state';
 import { AddNodeMarkStep, RemoveMarkStep, RemoveNodeMarkStep } from '@atlaskit/editor-prosemirror/transform';
 import { createAnnotationStep, getPosFromRange } from '../steps';
 import { ACTION, ACTION_SUBJECT, EVENT_TYPE, ACTION_SUBJECT_ID } from '@atlaskit/editor-common/analytics';
@@ -59,6 +60,12 @@ var RendererActions = /*#__PURE__*/function () {
       if (!this.doc || !this.schema) {
         return false;
       }
+      if (fg('forbid_comments_on_empty_newlines')) {
+        var currentSelection = TextSelection.create(this.doc, from, to);
+        if (isEmptyTextSelection(currentSelection, this.schema)) {
+          return false;
+        }
+      }
       return canApplyAnnotationOnRange({
         from: from,
         to: to

package/dist/esm/ui/Renderer/index.js

@@ -55,7 +55,7 @@ import { countNodes } from './count-nodes';
 export var NORMAL_SEVERITY_THRESHOLD = 2000;
 export var DEGRADED_SEVERITY_THRESHOLD = 3000;
 var packageName = "@atlaskit/renderer";
-var packageVersion = "112.1.0";
+var packageVersion = "112.2.0";
 var setAsQueryContainerStyles = css({
   containerName: 'ak-renderer-wrapper',
   containerType: 'inline-size',

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@atlaskit/renderer",
-	"version": "112.1.0",
+	"version": "112.2.0",
 	"description": "Renderer component",
 	"publishConfig": {
 		"registry": "https://registry.npmjs.org/"
@@ -29,7 +29,7 @@
 		"@atlaskit/analytics-next": "^10.1.0",
 		"@atlaskit/button": "^20.3.0",
 		"@atlaskit/code": "^15.6.0",
-		"@atlaskit/editor-common": "^94.7.0",
+		"@atlaskit/editor-common": "^94.9.0",
 		"@atlaskit/editor-json-transformer": "^8.20.0",
 		"@atlaskit/editor-palette": "1.6.3",
 		"@atlaskit/editor-prosemirror": "6.0.0",
@@ -120,6 +120,9 @@
 		"editor_inline_comments_on_inline_nodes": {
 			"type": "boolean"
 		},
+		"forbid_comments_on_empty_newlines": {
+			"type": "boolean"
+		},
 		"annotations_align_editor_and_renderer_styles": {
 			"type": "boolean"
 		},