@atlaskit/renderer 109.51.6 → 109.53.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
package/CHANGELOG.md CHANGED
@@ -1,5 +1,35 @@
1
1
  # @atlaskit/renderer
2
2
 
3
+ ## 109.53.0
4
+
5
+ ### Minor Changes
6
+
7
+ - [#137821](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/pull-requests/137821)
8
+ [`e26174c7d02a6`](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/commits/e26174c7d02a6) -
9
+ ED-24631 Refactor how ExternalImageBadge and CommentBadge are rendered
10
+
11
+ ### Patch Changes
12
+
13
+ - Updated dependencies
14
+
15
+ ## 109.52.0
16
+
17
+ ### Minor Changes
18
+
19
+ - [#137755](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/pull-requests/137755)
20
+ [`f3d004d4e3a3e`](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/commits/f3d004d4e3a3e) -
21
+ ED-24650 fix nested node jittering issue
22
+
23
+ ### Patch Changes
24
+
25
+ - [#137736](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/pull-requests/137736)
26
+ [`2a88fdd213838`](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/commits/2a88fdd213838) -
27
+ Introducing new smaller refined entry-points for editor-common to reduce bundle size.
28
+ - [#137404](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/pull-requests/137404)
29
+ [`adae1f3dc8fca`](https://stash.atlassian.com/projects/CONFCLOUD/repos/confluence-frontend/commits/adae1f3dc8fca) -
30
+ Switches Support Table in Comment features to use Statsig experiment instead of a Feature Gate.
31
+ - Updated dependencies
32
+
3
33
  ## 109.51.6
4
34
 
5
35
  ### Patch Changes
@@ -42,6 +42,7 @@ var _templateObject, _templateObject2;
42
42
  /**
43
43
  * @jsxRuntime classic
44
44
  * @jsx jsx
45
+ * @jsxFrag
45
46
  */
46
47
  // eslint-disable-next-line @atlaskit/ui-styling-standard/use-compiled -- Ignored via go/DSP-18766
47
48
  function _getRequireWildcardCache(e) { if ("function" != typeof WeakMap) return null; var r = new WeakMap(), t = new WeakMap(); return (_getRequireWildcardCache = function _getRequireWildcardCache(e) { return e ? t : r; })(e); }
@@ -207,16 +208,19 @@ var CommentBadgeWrapper = function CommentBadgeWrapper(_ref5) {
207
208
  }, rest));
208
209
  };
209
210
 
210
- // This is a copy of above component with adding forwardRef.
211
- // Clean this up when removing fg('platform_editor_insert_media_plugin_phase_one') flag.
212
- var CommentBadgeWrapperWithRef = /*#__PURE__*/_react.default.forwardRef(function (_ref6, ref) {
211
+ /**
212
+ * Remove CommentBadgeWrapper component above
213
+ * and rename CommentBadgeNextWrapper to CommentBadgeWrapper
214
+ * when clean up platform_editor_insert_media_plugin_phase_one feature flag
215
+ */
216
+
217
+ var CommentBadgeNextWrapper = function CommentBadgeNextWrapper(_ref6) {
213
218
  var _marks$map2;
214
219
  var marks = _ref6.marks,
215
220
  mediaSingleElement = _ref6.mediaSingleElement,
216
221
  _ref6$isDrafting = _ref6.isDrafting,
217
222
  isDrafting = _ref6$isDrafting === void 0 ? false : _ref6$isDrafting,
218
223
  rest = (0, _objectWithoutProperties2.default)(_ref6, _excluded2);
219
- var intl = (0, _reactIntlNext.useIntl)();
220
224
  var _useState5 = (0, _react.useState)('default'),
221
225
  _useState6 = (0, _slicedToArray2.default)(_useState5, 2),
222
226
  status = _useState6[0],
@@ -271,9 +275,7 @@ var CommentBadgeWrapperWithRef = /*#__PURE__*/_react.default.forwardRef(function
271
275
  });
272
276
  }
273
277
  };
274
- return (0, _react2.jsx)(_mediaSingle.CommentBadge, (0, _extends2.default)({
275
- ref: ref,
276
- intl: intl,
278
+ return (0, _react2.jsx)(_mediaSingle.CommentBadgeNext, (0, _extends2.default)({
277
279
  onMouseEnter: function onMouseEnter() {
278
280
  return setEntered(true);
279
281
  },
@@ -284,7 +286,7 @@ var CommentBadgeWrapperWithRef = /*#__PURE__*/_react.default.forwardRef(function
284
286
  onClick: onClick,
285
287
  mediaSingleElement: mediaSingleElement
286
288
  }, rest));
287
- });
289
+ };
288
290
  var Media = /*#__PURE__*/function (_PureComponent) {
289
291
  (0, _inherits2.default)(Media, _PureComponent);
290
292
  var _super = _createSuper(Media);
@@ -292,7 +294,6 @@ var Media = /*#__PURE__*/function (_PureComponent) {
292
294
  var _this;
293
295
  (0, _classCallCheck2.default)(this, Media);
294
296
  _this = _super.call(this, props);
295
- (0, _defineProperty2.default)((0, _assertThisInitialized2.default)(_this), "commentBadgeRef", /*#__PURE__*/_react.default.createRef());
296
297
  (0, _defineProperty2.default)((0, _assertThisInitialized2.default)(_this), "renderCard", function () {
297
298
  var providers = arguments.length > 0 && arguments[0] !== undefined ? arguments[0] : {};
298
299
  var contextIdentifierProvider = providers.contextIdentifierProvider;
@@ -317,14 +318,7 @@ var Media = /*#__PURE__*/function (_PureComponent) {
317
318
  var isInPageInclude = mediaSingleElement === null || mediaSingleElement === void 0 ? void 0 : mediaSingleElement.closest('[data-node-type="include"]');
318
319
  var isIncludeExcerpt = !!(mediaSingleElement !== null && mediaSingleElement !== void 0 && mediaSingleElement.closest('.ak-excerpt-include'));
319
320
  var showCommentBadge = !!annotationMarks && (featureFlags === null || featureFlags === void 0 ? void 0 : featureFlags.commentsOnMedia) && !isInPageInclude && (!(featureFlags !== null && featureFlags !== void 0 && featureFlags.commentsOnMediaInsertExcerpt) || !isIncludeExcerpt);
320
- var insertMediaPluginPhaseOneFlag = (0, _platformFeatureFlags.fg)('platform_editor_insert_media_plugin_phase_one');
321
- var shouldShowExternalMediaBadge = _this.props.type === 'external' && insertMediaPluginPhaseOneFlag;
322
- var commentBadgeOffset = function commentBadgeOffset() {
323
- if (_this.commentBadgeRef.current) {
324
- return _this.commentBadgeRef.current.offsetWidth + 2;
325
- }
326
- return 0;
327
- };
321
+ var shouldShowExternalMediaBadge = _this.props.type === 'external';
328
322
  return (0, _react2.jsx)(MediaLink, {
329
323
  mark: linkMark,
330
324
  onClick: _this.handleMediaLinkClickFn
@@ -336,25 +330,27 @@ var Media = /*#__PURE__*/function (_PureComponent) {
336
330
  data: (0, _defineProperty2.default)({}, _analyticsNamespacedContext.MEDIA_CONTEXT, {
337
331
  border: !!borderMark
338
332
  })
339
- }, shouldShowExternalMediaBadge && (0, _react2.jsx)(_mediaSingle.ExternalImageBadge, {
340
- commentBadgeRightOffset: commentBadgeOffset(),
333
+ }, (0, _platformFeatureFlags.fg)('platform_editor_insert_media_plugin_phase_one') && (0, _react2.jsx)(_mediaSingle.MediaBadges, {
341
334
  mediaElement: mediaSingleElement,
342
335
  mediaWidth: width,
343
336
  mediaHeight: height
344
- }), showCommentBadge && (insertMediaPluginPhaseOneFlag ? (0, _react2.jsx)(CommentBadgeWrapperWithRef, {
345
- ref: _this.commentBadgeRef,
346
- marks: annotationMarks,
347
- mediaSingleElement: mediaSingleElement,
348
- width: width,
349
- height: height,
350
- isDrafting: isDrafting
351
- }) : (0, _react2.jsx)(CommentBadgeWrapper, {
337
+ }, function (_ref8) {
338
+ var badgeSize = _ref8.badgeSize;
339
+ return (0, _react2.jsx)(_react.default.Fragment, null, shouldShowExternalMediaBadge && (0, _react2.jsx)(_mediaSingle.ExternalImageBadge, {
340
+ badgeSize: badgeSize
341
+ }), showCommentBadge && (0, _react2.jsx)(CommentBadgeNextWrapper, {
342
+ marks: annotationMarks,
343
+ mediaSingleElement: mediaSingleElement,
344
+ isDrafting: isDrafting,
345
+ badgeSize: badgeSize
346
+ }));
347
+ }), !(0, _platformFeatureFlags.fg)('platform_editor_insert_media_plugin_phase_one') && showCommentBadge && (0, _react2.jsx)(CommentBadgeWrapper, {
352
348
  marks: annotationMarks,
353
349
  mediaSingleElement: mediaSingleElement,
354
350
  width: width,
355
351
  height: height,
356
352
  isDrafting: isDrafting
357
- })), (0, _react2.jsx)(_MediaCard.MediaCard, (0, _extends2.default)({
353
+ }), (0, _react2.jsx)(_MediaCard.MediaCard, (0, _extends2.default)({
358
354
  contextIdentifierProvider: contextIdentifierProvider
359
355
  }, _this.props, {
360
356
  shouldOpenMediaViewer: shouldOpenMediaViewer,
@@ -20,7 +20,7 @@ var _utils = require("@atlaskit/editor-common/utils");
20
20
  var _types = require("@atlaskit/editor-common/types");
21
21
  var _editorSharedStyles = require("@atlaskit/editor-shared-styles");
22
22
  var _nodeWidth = require("@atlaskit/editor-common/node-width");
23
- var _platformFeatureFlags = require("@atlaskit/platform-feature-flags");
23
+ var _experiments = require("@atlaskit/tmp-editor-statsig/experiments");
24
24
  var _style = require("../../ui/Renderer/style");
25
25
  var _tableCell = require("./tableCell");
26
26
  var _SmartCardStorage = require("../../ui/SmartCardStorage");
@@ -33,7 +33,9 @@ function _arrayLikeToArray(arr, len) { if (len == null || len > arr.length) len
33
33
  function _createSuper(Derived) { var hasNativeReflectConstruct = _isNativeReflectConstruct(); return function _createSuperInternal() { var Super = (0, _getPrototypeOf2.default)(Derived), result; if (hasNativeReflectConstruct) { var NewTarget = (0, _getPrototypeOf2.default)(this).constructor; result = Reflect.construct(Super, arguments, NewTarget); } else { result = Super.apply(this, arguments); } return (0, _possibleConstructorReturn2.default)(this, result); }; }
34
34
  function _isNativeReflectConstruct() { try { var t = !Boolean.prototype.valueOf.call(Reflect.construct(Boolean, [], function () {})); } catch (t) {} return (_isNativeReflectConstruct = function _isNativeReflectConstruct() { return !!t; })(); }
35
35
  var isTableResizingEnabled = exports.isTableResizingEnabled = function isTableResizingEnabled(appearance) {
36
- return (0, _appearance.isFullWidthOrFullPageAppearance)(appearance) || (0, _appearance.isCommentAppearance)(appearance) && (0, _platformFeatureFlags.fg)('platform_editor_table_support_in_comment');
36
+ return (0, _appearance.isFullWidthOrFullPageAppearance)(appearance) || (0, _appearance.isCommentAppearance)(appearance) && (0, _experiments.editorExperiment)('support_table_in_comment', true, {
37
+ exposure: true
38
+ });
37
39
  };
38
40
  var orderChildren = function orderChildren(children, tableNode, smartCardStorage, tableOrderStatus) {
39
41
  if (!tableOrderStatus || tableOrderStatus.order === _types.SortOrder.NO_ORDER) {
@@ -22,6 +22,9 @@ var _providerFactory = require("@atlaskit/editor-common/provider-factory");
22
22
  var _ui = require("@atlaskit/editor-common/ui");
23
23
  var _performanceMeasures = require("@atlaskit/editor-common/performance-measures");
24
24
  var _utils = require("@atlaskit/editor-common/utils");
25
+ var _measureRender = require("@atlaskit/editor-common/performance/measure-render");
26
+ var _browser = require("@atlaskit/editor-common/browser");
27
+ var _navigation = require("@atlaskit/editor-common/performance/navigation");
25
28
  var _platformFeatureFlags = require("@atlaskit/platform-feature-flags");
26
29
  var _normalizeFeatureFlags = require("@atlaskit/editor-common/normalize-feature-flags");
27
30
  var _editorSharedStyles = require("@atlaskit/editor-shared-styles");
@@ -60,7 +63,7 @@ function _isNativeReflectConstruct() { try { var t = !Boolean.prototype.valueOf.
60
63
  var NORMAL_SEVERITY_THRESHOLD = exports.NORMAL_SEVERITY_THRESHOLD = 2000;
61
64
  var DEGRADED_SEVERITY_THRESHOLD = exports.DEGRADED_SEVERITY_THRESHOLD = 3000;
62
65
  var packageName = "@atlaskit/renderer";
63
- var packageVersion = "109.51.6";
66
+ var packageVersion = "109.53.0";
64
67
  var defaultNodeComponents = exports.defaultNodeComponents = _nodes.nodeToReact;
65
68
  var Renderer = exports.Renderer = /*#__PURE__*/function (_PureComponent) {
66
69
  (0, _inherits2.default)(Renderer, _PureComponent);
@@ -73,7 +76,7 @@ var Renderer = exports.Renderer = /*#__PURE__*/function (_PureComponent) {
73
76
  * This is used in measuring the Renderer Mount time and is then
74
77
  * deleted once that measurement occurs.
75
78
  */
76
- (0, _defineProperty2.default)((0, _assertThisInitialized2.default)(_this), "renderedMeasurementDistortedDurationMonitor", (0, _utils.getDistortedDurationMonitor)());
79
+ (0, _defineProperty2.default)((0, _assertThisInitialized2.default)(_this), "renderedMeasurementDistortedDurationMonitor", (0, _measureRender.getDistortedDurationMonitor)());
77
80
  (0, _defineProperty2.default)((0, _assertThisInitialized2.default)(_this), "featureFlags", (0, _memoizeOne.default)(function (featureFlags) {
78
81
  var normalizedFeatureFlags = (0, _normalizeFeatureFlags.normalizeFeatureFlags)(featureFlags, {
79
82
  objectFlagKeys: ['rendererRenderTracking']
@@ -105,10 +108,10 @@ var Renderer = exports.Renderer = /*#__PURE__*/function (_PureComponent) {
105
108
  });
106
109
  (0, _defineProperty2.default)((0, _assertThisInitialized2.default)(_this), "handleMouseTripleClickInTables", function (event) {
107
110
  var _parentElement, _parentElement2;
108
- if (_utils.browser.ios || _utils.browser.android) {
111
+ if (_browser.browser.ios || _browser.browser.android) {
109
112
  return;
110
113
  }
111
- var badBrowser = _utils.browser.chrome || _utils.browser.safari;
114
+ var badBrowser = _browser.browser.chrome || _browser.browser.safari;
112
115
  var tripleClick = event.detail >= 3;
113
116
  if (!(badBrowser && tripleClick)) {
114
117
  return;
@@ -221,7 +224,7 @@ var Renderer = exports.Renderer = /*#__PURE__*/function (_PureComponent) {
221
224
  platform: _events.PLATFORM.WEB,
222
225
  duration: duration,
223
226
  distortedDuration: _this2.renderedMeasurementDistortedDurationMonitor.distortedDuration,
224
- ttfb: (0, _utils.getResponseEndTime)(),
227
+ ttfb: (0, _navigation.getResponseEndTime)(),
225
228
  nodes: (0, _traverse.reduce)(_this2.props.document, function (acc, node) {
226
229
  acc[node.type] = (acc[node.type] || 0) + 1;
227
230
  return acc;
@@ -3,6 +3,7 @@ import _extends from "@babel/runtime/helpers/extends";
3
3
  /**
4
4
  * @jsxRuntime classic
5
5
  * @jsx jsx
6
+ * @jsxFrag
6
7
  */
7
8
 
8
9
  import React, { PureComponent, Fragment, useEffect, useState, useMemo, useContext } from 'react';
@@ -20,8 +21,8 @@ import { ACTION, ACTION_SUBJECT, ACTION_SUBJECT_ID, EVENT_TYPE, VIEW_METHOD } fr
20
21
  import { MODE, PLATFORM } from '../../../analytics/events';
21
22
  import AnnotationComponent from '../../marks/annotation';
22
23
  import { AnnotationsDraftContext, ProvidersContext } from '../../../ui/annotations/context';
23
- import { CommentBadge as CommentBadgeComponent, ExternalImageBadge } from '@atlaskit/editor-common/media-single';
24
- import { useIntl, injectIntl } from 'react-intl-next';
24
+ import { CommentBadge as CommentBadgeComponent, CommentBadgeNext, ExternalImageBadge, MediaBadges } from '@atlaskit/editor-common/media-single';
25
+ import { injectIntl } from 'react-intl-next';
25
26
  import { useInlineCommentSubscriberContext, useInlineCommentsFilter } from '../../../ui/annotations/hooks';
26
27
  import { AnnotationUpdateEvent } from '@atlaskit/editor-common/types';
27
28
  import { fg } from '@atlaskit/platform-feature-flags';
@@ -187,16 +188,19 @@ const CommentBadgeWrapper = ({
187
188
  }, rest));
188
189
  };
189
190
 
190
- // This is a copy of above component with adding forwardRef.
191
- // Clean this up when removing fg('platform_editor_insert_media_plugin_phase_one') flag.
192
- const CommentBadgeWrapperWithRef = /*#__PURE__*/React.forwardRef(({
191
+ /**
192
+ * Remove CommentBadgeWrapper component above
193
+ * and rename CommentBadgeNextWrapper to CommentBadgeWrapper
194
+ * when clean up platform_editor_insert_media_plugin_phase_one feature flag
195
+ */
196
+
197
+ const CommentBadgeNextWrapper = ({
193
198
  marks,
194
199
  mediaSingleElement,
195
200
  isDrafting = false,
196
201
  ...rest
197
- }, ref) => {
202
+ }) => {
198
203
  var _marks$map2;
199
- const intl = useIntl();
200
204
  const [status, setStatus] = useState('default');
201
205
  const [entered, setEntered] = useState(false);
202
206
  const updateSubscriber = useInlineCommentSubscriberContext();
@@ -243,20 +247,17 @@ const CommentBadgeWrapperWithRef = /*#__PURE__*/React.forwardRef(({
243
247
  });
244
248
  }
245
249
  };
246
- return jsx(CommentBadgeComponent, _extends({
247
- ref: ref,
248
- intl: intl,
250
+ return jsx(CommentBadgeNext, _extends({
249
251
  onMouseEnter: () => setEntered(true),
250
252
  onMouseLeave: () => setEntered(false),
251
253
  status: entered ? 'entered' : status,
252
254
  onClick: onClick,
253
255
  mediaSingleElement: mediaSingleElement
254
256
  }, rest));
255
- });
257
+ };
256
258
  class Media extends PureComponent {
257
259
  constructor(props) {
258
260
  super(props);
259
- _defineProperty(this, "commentBadgeRef", /*#__PURE__*/React.createRef());
260
261
  _defineProperty(this, "renderCard", (providers = {}) => {
261
262
  const {
262
263
  contextIdentifierProvider
@@ -282,14 +283,7 @@ class Media extends PureComponent {
282
283
  const isInPageInclude = mediaSingleElement === null || mediaSingleElement === void 0 ? void 0 : mediaSingleElement.closest('[data-node-type="include"]');
283
284
  const isIncludeExcerpt = !!(mediaSingleElement !== null && mediaSingleElement !== void 0 && mediaSingleElement.closest('.ak-excerpt-include'));
284
285
  const showCommentBadge = !!annotationMarks && (featureFlags === null || featureFlags === void 0 ? void 0 : featureFlags.commentsOnMedia) && !isInPageInclude && (!(featureFlags !== null && featureFlags !== void 0 && featureFlags.commentsOnMediaInsertExcerpt) || !isIncludeExcerpt);
285
- const insertMediaPluginPhaseOneFlag = fg('platform_editor_insert_media_plugin_phase_one');
286
- const shouldShowExternalMediaBadge = this.props.type === 'external' && insertMediaPluginPhaseOneFlag;
287
- const commentBadgeOffset = () => {
288
- if (this.commentBadgeRef.current) {
289
- return this.commentBadgeRef.current.offsetWidth + 2;
290
- }
291
- return 0;
292
- };
286
+ const shouldShowExternalMediaBadge = this.props.type === 'external';
293
287
  return jsx(MediaLink, {
294
288
  mark: linkMark,
295
289
  onClick: this.handleMediaLinkClickFn
@@ -303,25 +297,26 @@ class Media extends PureComponent {
303
297
  border: !!borderMark
304
298
  }
305
299
  }
306
- }, shouldShowExternalMediaBadge && jsx(ExternalImageBadge, {
307
- commentBadgeRightOffset: commentBadgeOffset(),
300
+ }, fg('platform_editor_insert_media_plugin_phase_one') && jsx(MediaBadges, {
308
301
  mediaElement: mediaSingleElement,
309
302
  mediaWidth: width,
310
303
  mediaHeight: height
311
- }), showCommentBadge && (insertMediaPluginPhaseOneFlag ? jsx(CommentBadgeWrapperWithRef, {
312
- ref: this.commentBadgeRef,
304
+ }, ({
305
+ badgeSize
306
+ }) => jsx(React.Fragment, null, shouldShowExternalMediaBadge && jsx(ExternalImageBadge, {
307
+ badgeSize: badgeSize
308
+ }), showCommentBadge && jsx(CommentBadgeNextWrapper, {
313
309
  marks: annotationMarks,
314
310
  mediaSingleElement: mediaSingleElement,
315
- width: width,
316
- height: height,
317
- isDrafting: isDrafting
318
- }) : jsx(CommentBadgeWrapper, {
311
+ isDrafting: isDrafting,
312
+ badgeSize: badgeSize
313
+ }))), !fg('platform_editor_insert_media_plugin_phase_one') && showCommentBadge && jsx(CommentBadgeWrapper, {
319
314
  marks: annotationMarks,
320
315
  mediaSingleElement: mediaSingleElement,
321
316
  width: width,
322
317
  height: height,
323
318
  isDrafting: isDrafting
324
- })), jsx(MediaCard, _extends({
319
+ }), jsx(MediaCard, _extends({
325
320
  contextIdentifierProvider: contextIdentifierProvider
326
321
  }, this.props, {
327
322
  shouldOpenMediaViewer: shouldOpenMediaViewer,
@@ -7,14 +7,16 @@ import { createCompareNodes, convertProsemirrorTableNodeToArrayOfRows, hasMerged
7
7
  import { SortOrder } from '@atlaskit/editor-common/types';
8
8
  import { akEditorDefaultLayoutWidth, akEditorFullWidthLayoutWidth } from '@atlaskit/editor-shared-styles';
9
9
  import { getTableContainerWidth } from '@atlaskit/editor-common/node-width';
10
- import { fg } from '@atlaskit/platform-feature-flags';
10
+ import { editorExperiment } from '@atlaskit/tmp-editor-statsig/experiments';
11
11
  import { FullPagePadding } from '../../ui/Renderer/style';
12
12
  import { TableHeader } from './tableCell';
13
13
  import { withSmartCardStorage } from '../../ui/SmartCardStorage';
14
14
  import { StickyTable, tableStickyPadding, OverflowParent } from './table/sticky';
15
15
  import { Table } from './table/table';
16
16
  import { isCommentAppearance, isFullPageAppearance, isFullWidthAppearance, isFullWidthOrFullPageAppearance } from '../utils/appearance';
17
- export const isTableResizingEnabled = appearance => isFullWidthOrFullPageAppearance(appearance) || isCommentAppearance(appearance) && fg('platform_editor_table_support_in_comment');
17
+ export const isTableResizingEnabled = appearance => isFullWidthOrFullPageAppearance(appearance) || isCommentAppearance(appearance) && editorExperiment('support_table_in_comment', true, {
18
+ exposure: true
19
+ });
18
20
  const orderChildren = (children, tableNode, smartCardStorage, tableOrderStatus) => {
19
21
  if (!tableOrderStatus || tableOrderStatus.order === SortOrder.NO_ORDER) {
20
22
  return children;
@@ -12,7 +12,10 @@ import { reduce } from '@atlaskit/adf-utils/traverse';
12
12
  import { ProviderFactory, ProviderFactoryProvider } from '@atlaskit/editor-common/provider-factory';
13
13
  import { UnsupportedBlock, BaseTheme, WidthProvider, WithCreateAnalyticsEvent, IntlErrorBoundary } from '@atlaskit/editor-common/ui';
14
14
  import { startMeasure, stopMeasure } from '@atlaskit/editor-common/performance-measures';
15
- import { getAnalyticsAppearance, getAnalyticsEventSeverity, getResponseEndTime, shouldForceTracking, measureTTI, getDistortedDurationMonitor, browser } from '@atlaskit/editor-common/utils';
15
+ import { getAnalyticsAppearance, getAnalyticsEventSeverity, shouldForceTracking, measureTTI } from '@atlaskit/editor-common/utils';
16
+ import { getDistortedDurationMonitor } from '@atlaskit/editor-common/performance/measure-render';
17
+ import { browser } from '@atlaskit/editor-common/browser';
18
+ import { getResponseEndTime } from '@atlaskit/editor-common/performance/navigation';
16
19
  import { fg } from '@atlaskit/platform-feature-flags';
17
20
  import { normalizeFeatureFlags } from '@atlaskit/editor-common/normalize-feature-flags';
18
21
  import { akEditorFullPageDefaultFontSize } from '@atlaskit/editor-shared-styles';
@@ -42,7 +45,7 @@ import { nodeToReact } from '../../react/nodes';
42
45
  export const NORMAL_SEVERITY_THRESHOLD = 2000;
43
46
  export const DEGRADED_SEVERITY_THRESHOLD = 3000;
44
47
  const packageName = "@atlaskit/renderer";
45
- const packageVersion = "109.51.6";
48
+ const packageVersion = "109.53.0";
46
49
  export const defaultNodeComponents = nodeToReact;
47
50
  export class Renderer extends PureComponent {
48
51
  constructor(props) {
@@ -19,6 +19,7 @@ function _isNativeReflectConstruct() { try { var t = !Boolean.prototype.valueOf.
19
19
  /**
20
20
  * @jsxRuntime classic
21
21
  * @jsx jsx
22
+ * @jsxFrag
22
23
  */
23
24
 
24
25
  import React, { PureComponent, Fragment, useEffect, useState, useMemo, useContext } from 'react';
@@ -36,8 +37,8 @@ import { ACTION, ACTION_SUBJECT, ACTION_SUBJECT_ID, EVENT_TYPE, VIEW_METHOD } fr
36
37
  import { MODE, PLATFORM } from '../../../analytics/events';
37
38
  import AnnotationComponent from '../../marks/annotation';
38
39
  import { AnnotationsDraftContext, ProvidersContext } from '../../../ui/annotations/context';
39
- import { CommentBadge as CommentBadgeComponent, ExternalImageBadge } from '@atlaskit/editor-common/media-single';
40
- import { useIntl, injectIntl } from 'react-intl-next';
40
+ import { CommentBadge as CommentBadgeComponent, CommentBadgeNext, ExternalImageBadge, MediaBadges } from '@atlaskit/editor-common/media-single';
41
+ import { injectIntl } from 'react-intl-next';
41
42
  import { useInlineCommentSubscriberContext, useInlineCommentsFilter } from '../../../ui/annotations/hooks';
42
43
  import { AnnotationUpdateEvent } from '@atlaskit/editor-common/types';
43
44
  import { fg } from '@atlaskit/platform-feature-flags';
@@ -198,16 +199,19 @@ var CommentBadgeWrapper = function CommentBadgeWrapper(_ref5) {
198
199
  }, rest));
199
200
  };
200
201
 
201
- // This is a copy of above component with adding forwardRef.
202
- // Clean this up when removing fg('platform_editor_insert_media_plugin_phase_one') flag.
203
- var CommentBadgeWrapperWithRef = /*#__PURE__*/React.forwardRef(function (_ref6, ref) {
202
+ /**
203
+ * Remove CommentBadgeWrapper component above
204
+ * and rename CommentBadgeNextWrapper to CommentBadgeWrapper
205
+ * when clean up platform_editor_insert_media_plugin_phase_one feature flag
206
+ */
207
+
208
+ var CommentBadgeNextWrapper = function CommentBadgeNextWrapper(_ref6) {
204
209
  var _marks$map2;
205
210
  var marks = _ref6.marks,
206
211
  mediaSingleElement = _ref6.mediaSingleElement,
207
212
  _ref6$isDrafting = _ref6.isDrafting,
208
213
  isDrafting = _ref6$isDrafting === void 0 ? false : _ref6$isDrafting,
209
214
  rest = _objectWithoutProperties(_ref6, _excluded2);
210
- var intl = useIntl();
211
215
  var _useState5 = useState('default'),
212
216
  _useState6 = _slicedToArray(_useState5, 2),
213
217
  status = _useState6[0],
@@ -262,9 +266,7 @@ var CommentBadgeWrapperWithRef = /*#__PURE__*/React.forwardRef(function (_ref6,
262
266
  });
263
267
  }
264
268
  };
265
- return jsx(CommentBadgeComponent, _extends({
266
- ref: ref,
267
- intl: intl,
269
+ return jsx(CommentBadgeNext, _extends({
268
270
  onMouseEnter: function onMouseEnter() {
269
271
  return setEntered(true);
270
272
  },
@@ -275,7 +277,7 @@ var CommentBadgeWrapperWithRef = /*#__PURE__*/React.forwardRef(function (_ref6,
275
277
  onClick: onClick,
276
278
  mediaSingleElement: mediaSingleElement
277
279
  }, rest));
278
- });
280
+ };
279
281
  var Media = /*#__PURE__*/function (_PureComponent) {
280
282
  _inherits(Media, _PureComponent);
281
283
  var _super = _createSuper(Media);
@@ -283,7 +285,6 @@ var Media = /*#__PURE__*/function (_PureComponent) {
283
285
  var _this;
284
286
  _classCallCheck(this, Media);
285
287
  _this = _super.call(this, props);
286
- _defineProperty(_assertThisInitialized(_this), "commentBadgeRef", /*#__PURE__*/React.createRef());
287
288
  _defineProperty(_assertThisInitialized(_this), "renderCard", function () {
288
289
  var providers = arguments.length > 0 && arguments[0] !== undefined ? arguments[0] : {};
289
290
  var contextIdentifierProvider = providers.contextIdentifierProvider;
@@ -308,14 +309,7 @@ var Media = /*#__PURE__*/function (_PureComponent) {
308
309
  var isInPageInclude = mediaSingleElement === null || mediaSingleElement === void 0 ? void 0 : mediaSingleElement.closest('[data-node-type="include"]');
309
310
  var isIncludeExcerpt = !!(mediaSingleElement !== null && mediaSingleElement !== void 0 && mediaSingleElement.closest('.ak-excerpt-include'));
310
311
  var showCommentBadge = !!annotationMarks && (featureFlags === null || featureFlags === void 0 ? void 0 : featureFlags.commentsOnMedia) && !isInPageInclude && (!(featureFlags !== null && featureFlags !== void 0 && featureFlags.commentsOnMediaInsertExcerpt) || !isIncludeExcerpt);
311
- var insertMediaPluginPhaseOneFlag = fg('platform_editor_insert_media_plugin_phase_one');
312
- var shouldShowExternalMediaBadge = _this.props.type === 'external' && insertMediaPluginPhaseOneFlag;
313
- var commentBadgeOffset = function commentBadgeOffset() {
314
- if (_this.commentBadgeRef.current) {
315
- return _this.commentBadgeRef.current.offsetWidth + 2;
316
- }
317
- return 0;
318
- };
312
+ var shouldShowExternalMediaBadge = _this.props.type === 'external';
319
313
  return jsx(MediaLink, {
320
314
  mark: linkMark,
321
315
  onClick: _this.handleMediaLinkClickFn
@@ -327,25 +321,27 @@ var Media = /*#__PURE__*/function (_PureComponent) {
327
321
  data: _defineProperty({}, MEDIA_CONTEXT, {
328
322
  border: !!borderMark
329
323
  })
330
- }, shouldShowExternalMediaBadge && jsx(ExternalImageBadge, {
331
- commentBadgeRightOffset: commentBadgeOffset(),
324
+ }, fg('platform_editor_insert_media_plugin_phase_one') && jsx(MediaBadges, {
332
325
  mediaElement: mediaSingleElement,
333
326
  mediaWidth: width,
334
327
  mediaHeight: height
335
- }), showCommentBadge && (insertMediaPluginPhaseOneFlag ? jsx(CommentBadgeWrapperWithRef, {
336
- ref: _this.commentBadgeRef,
337
- marks: annotationMarks,
338
- mediaSingleElement: mediaSingleElement,
339
- width: width,
340
- height: height,
341
- isDrafting: isDrafting
342
- }) : jsx(CommentBadgeWrapper, {
328
+ }, function (_ref8) {
329
+ var badgeSize = _ref8.badgeSize;
330
+ return jsx(React.Fragment, null, shouldShowExternalMediaBadge && jsx(ExternalImageBadge, {
331
+ badgeSize: badgeSize
332
+ }), showCommentBadge && jsx(CommentBadgeNextWrapper, {
333
+ marks: annotationMarks,
334
+ mediaSingleElement: mediaSingleElement,
335
+ isDrafting: isDrafting,
336
+ badgeSize: badgeSize
337
+ }));
338
+ }), !fg('platform_editor_insert_media_plugin_phase_one') && showCommentBadge && jsx(CommentBadgeWrapper, {
343
339
  marks: annotationMarks,
344
340
  mediaSingleElement: mediaSingleElement,
345
341
  width: width,
346
342
  height: height,
347
343
  isDrafting: isDrafting
348
- })), jsx(MediaCard, _extends({
344
+ }), jsx(MediaCard, _extends({
349
345
  contextIdentifierProvider: contextIdentifierProvider
350
346
  }, _this.props, {
351
347
  shouldOpenMediaViewer: shouldOpenMediaViewer,
@@ -18,7 +18,7 @@ import { createCompareNodes, convertProsemirrorTableNodeToArrayOfRows, hasMerged
18
18
  import { SortOrder } from '@atlaskit/editor-common/types';
19
19
  import { akEditorDefaultLayoutWidth, akEditorFullWidthLayoutWidth } from '@atlaskit/editor-shared-styles';
20
20
  import { getTableContainerWidth } from '@atlaskit/editor-common/node-width';
21
- import { fg } from '@atlaskit/platform-feature-flags';
21
+ import { editorExperiment } from '@atlaskit/tmp-editor-statsig/experiments';
22
22
  import { FullPagePadding } from '../../ui/Renderer/style';
23
23
  import { TableHeader } from './tableCell';
24
24
  import { withSmartCardStorage } from '../../ui/SmartCardStorage';
@@ -26,7 +26,9 @@ import { StickyTable, tableStickyPadding, OverflowParent } from './table/sticky'
26
26
  import { Table } from './table/table';
27
27
  import { isCommentAppearance, isFullPageAppearance, isFullWidthAppearance, isFullWidthOrFullPageAppearance } from '../utils/appearance';
28
28
  export var isTableResizingEnabled = function isTableResizingEnabled(appearance) {
29
- return isFullWidthOrFullPageAppearance(appearance) || isCommentAppearance(appearance) && fg('platform_editor_table_support_in_comment');
29
+ return isFullWidthOrFullPageAppearance(appearance) || isCommentAppearance(appearance) && editorExperiment('support_table_in_comment', true, {
30
+ exposure: true
31
+ });
30
32
  };
31
33
  var orderChildren = function orderChildren(children, tableNode, smartCardStorage, tableOrderStatus) {
32
34
  if (!tableOrderStatus || tableOrderStatus.order === SortOrder.NO_ORDER) {
@@ -22,7 +22,10 @@ import { reduce } from '@atlaskit/adf-utils/traverse';
22
22
  import { ProviderFactory, ProviderFactoryProvider } from '@atlaskit/editor-common/provider-factory';
23
23
  import { UnsupportedBlock, BaseTheme, WidthProvider, WithCreateAnalyticsEvent, IntlErrorBoundary } from '@atlaskit/editor-common/ui';
24
24
  import { startMeasure, stopMeasure } from '@atlaskit/editor-common/performance-measures';
25
- import { getAnalyticsAppearance, getAnalyticsEventSeverity, getResponseEndTime, shouldForceTracking, measureTTI, getDistortedDurationMonitor, browser } from '@atlaskit/editor-common/utils';
25
+ import { getAnalyticsAppearance, getAnalyticsEventSeverity, shouldForceTracking, measureTTI } from '@atlaskit/editor-common/utils';
26
+ import { getDistortedDurationMonitor } from '@atlaskit/editor-common/performance/measure-render';
27
+ import { browser } from '@atlaskit/editor-common/browser';
28
+ import { getResponseEndTime } from '@atlaskit/editor-common/performance/navigation';
26
29
  import { fg } from '@atlaskit/platform-feature-flags';
27
30
  import { normalizeFeatureFlags } from '@atlaskit/editor-common/normalize-feature-flags';
28
31
  import { akEditorFullPageDefaultFontSize } from '@atlaskit/editor-shared-styles';
@@ -52,7 +55,7 @@ import { nodeToReact } from '../../react/nodes';
52
55
  export var NORMAL_SEVERITY_THRESHOLD = 2000;
53
56
  export var DEGRADED_SEVERITY_THRESHOLD = 3000;
54
57
  var packageName = "@atlaskit/renderer";
55
- var packageVersion = "109.51.6";
58
+ var packageVersion = "109.53.0";
56
59
  export var defaultNodeComponents = nodeToReact;
57
60
  export var Renderer = /*#__PURE__*/function (_PureComponent) {
58
61
  _inherits(Renderer, _PureComponent);
@@ -1,6 +1,7 @@
1
1
  /**
2
2
  * @jsxRuntime classic
3
3
  * @jsx jsx
4
+ * @jsxFrag
4
5
  */
5
6
  import type { PropsWithChildren } from 'react';
6
7
  import React from 'react';
@@ -1,6 +1,7 @@
1
1
  /**
2
2
  * @jsxRuntime classic
3
3
  * @jsx jsx
4
+ * @jsxFrag
4
5
  */
5
6
  import type { PropsWithChildren } from 'react';
6
7
  import React from 'react';
package/package.json CHANGED
@@ -1,6 +1,6 @@
1
1
  {
2
2
  "name": "@atlaskit/renderer",
3
- "version": "109.51.6",
3
+ "version": "109.53.0",
4
4
  "description": "Renderer component",
5
5
  "publishConfig": {
6
6
  "registry": "https://registry.npmjs.org/"
@@ -29,14 +29,14 @@
29
29
  "@atlaskit/analytics-next": "^10.1.0",
30
30
  "@atlaskit/button": "^20.1.0",
31
31
  "@atlaskit/code": "^15.6.0",
32
- "@atlaskit/editor-common": "^88.8.0",
32
+ "@atlaskit/editor-common": "^88.12.0",
33
33
  "@atlaskit/editor-json-transformer": "^8.18.0",
34
34
  "@atlaskit/editor-palette": "1.6.0",
35
35
  "@atlaskit/editor-prosemirror": "5.0.1",
36
36
  "@atlaskit/editor-shared-styles": "^2.13.0",
37
37
  "@atlaskit/emoji": "^67.7.0",
38
38
  "@atlaskit/feature-gate-js-client": "^4.18.0",
39
- "@atlaskit/icon": "^22.15.0",
39
+ "@atlaskit/icon": "^22.16.0",
40
40
  "@atlaskit/link-datasource": "^2.12.0",
41
41
  "@atlaskit/media-card": "^78.2.0",
42
42
  "@atlaskit/media-client": "^27.6.0",
@@ -46,7 +46,7 @@
46
46
  "@atlaskit/media-ui": "^25.11.0",
47
47
  "@atlaskit/media-viewer": "^48.7.0",
48
48
  "@atlaskit/platform-feature-flags": "^0.3.0",
49
- "@atlaskit/smart-card": "^27.20.0",
49
+ "@atlaskit/smart-card": "^28.0.0",
50
50
  "@atlaskit/status": "^1.4.0",
51
51
  "@atlaskit/task-decision": "^17.10.0",
52
52
  "@atlaskit/theme": "^13.0.0",
@@ -73,7 +73,7 @@
73
73
  "@atlaskit/analytics-gas-types": "^5.1.0",
74
74
  "@atlaskit/css-reset": "^6.10.0",
75
75
  "@atlaskit/editor-test-helpers": "^18.33.0",
76
- "@atlaskit/link-provider": "^1.14.0",
76
+ "@atlaskit/link-provider": "^1.15.0",
77
77
  "@atlaskit/link-test-helpers": "^7.5.0",
78
78
  "@atlaskit/linking-common": "^5.11.0",
79
79
  "@atlaskit/media-core": "^34.3.0",
@@ -128,9 +128,6 @@
128
128
  "platform.editor.inline_extension.extended_lcqdn": {
129
129
  "type": "boolean"
130
130
  },
131
- "platform_editor_table_support_in_comment": {
132
- "type": "boolean"
133
- },
134
131
  "editor_inline_comments_on_inline_nodes": {
135
132
  "type": "boolean"
136
133
  },