@atlaskit/reactions 37.1.2 → 37.1.3

package/CHANGELOG.md

@@ -1,5 +1,14 @@
 # @atlaskit/reactions
 
+## 37.1.3
+
+### Patch Changes
+
+- [`8bea3ef71a661`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/8bea3ef71a661) -
+  Clean up `platform_a11y_fixes_reading_order` and make the accessible reading-order behavior
+  permanent.
+- Updated dependencies
+
 ## 37.1.2
 
 ### Patch Changes

package/dist/cjs/analytics/index.js

@@ -11,7 +11,7 @@ var _createAndFireEvents = _interopRequireDefault(require("@atlaskit/analytics-n
 function ownKeys(e, r) { var t = Object.keys(e); if (Object.getOwnPropertySymbols) { var o = Object.getOwnPropertySymbols(e); r && (o = o.filter(function (r) { return Object.getOwnPropertyDescriptor(e, r).enumerable; })), t.push.apply(t, o); } return t; }
 function _objectSpread(e) { for (var r = 1; r < arguments.length; r++) { var t = null != arguments[r] ? arguments[r] : {}; r % 2 ? ownKeys(Object(t), !0).forEach(function (r) { (0, _defineProperty2.default)(e, r, t[r]); }) : Object.getOwnPropertyDescriptors ? Object.defineProperties(e, Object.getOwnPropertyDescriptors(t)) : ownKeys(Object(t)).forEach(function (r) { Object.defineProperty(e, r, Object.getOwnPropertyDescriptor(t, r)); }); } return e; } // eslint-disable-next-line @typescript-eslint/consistent-type-imports
 var packageName = "@atlaskit/reactions";
-var packageVersion = "37.1.1";
+var packageVersion = "37.1.2";
 /**
  * TODO: move to utility package?
  * A random sampling function

package/dist/cjs/components/Reaction.js

@@ -18,7 +18,6 @@ var _reactIntl = require("react-intl");
 var _useAnalyticsEvents2 = require("@atlaskit/analytics-next/useAnalyticsEvents");
 var _css = require("@atlaskit/css");
 var _resourcedEmoji = _interopRequireDefault(require("@atlaskit/emoji/resourced-emoji"));
-var _fg = require("@atlaskit/platform-feature-flags/fg");
 var _box = require("@atlaskit/primitives/compiled/box");
 var _inline = require("@atlaskit/primitives/compiled/inline");
 var _analytics = require("../analytics");
@@ -164,7 +163,7 @@ var Reaction = exports.Reaction = function Reaction(_ref) {
     });
   }
   return /*#__PURE__*/React.createElement(_box.Box, {
-    xcss: (0, _css.cx)(styles.container, rootElement === 'li' ? styles.listItem : undefined, rootElement === 'li' && (0, _fg.fg)('platform_a11y_fixes_reading_order') ? styles.listItemNoMarker : undefined),
+    xcss: (0, _css.cx)(styles.container, rootElement === 'li' ? styles.listItem : undefined, rootElement === 'li' ? styles.listItemNoMarker : undefined),
     as: rootElement
   }, showParticleEffect && /*#__PURE__*/React.createElement(_ReactionParticleEffect.ReactionParticleEffect, {
     emojiId: emojiId,

package/dist/cjs/components/ReactionPicker.js

@@ -386,8 +386,6 @@ var PopperWrapper = exports.PopperWrapper = function PopperWrapper(props) {
     _useState12 = (0, _slicedToArray2.default)(_useState11, 2),
     popupRef = _useState12[0],
     setPopupRef = _useState12[1];
-  var _useIntl = (0, _reactIntl.useIntl)(),
-    formatMessage = _useIntl.formatMessage;
   /**
    * add focus lock to popup
    */
@@ -416,9 +414,8 @@ var PopperWrapper = exports.PopperWrapper = function PopperWrapper(props) {
       update = _ref3.update;
     return /*#__PURE__*/_react.default.createElement("div", {
       role: "dialog",
-      "aria-label": (0, _fg.fg)('platform_a11y_fixes_reading_order') ? undefined : formatMessage(_i18n.messages.popperWrapperLabel),
-      "aria-modal": (0, _fg.fg)('platform_a11y_fixes_reading_order') ? 'false' : undefined,
-      "aria-labelledby": (0, _fg.fg)('platform_a11y_fixes_reading_order') ? PICKER_LABEL_ID : undefined,
+      "aria-modal": "false",
+      "aria-labelledby": PICKER_LABEL_ID,
       id: PICKER_CONTROL_ID,
       "data-testid": RENDER_REACTIONPICKERPANEL_TESTID,
       style: _objectSpread({
@@ -437,13 +434,13 @@ var PopperWrapper = exports.PopperWrapper = function PopperWrapper(props) {
       // eslint-disable-next-line @atlassian/a11y/no-noninteractive-tabindex
       tabIndex: (0, _fg.fg)('platform_suppression_removal_fix_reactions') ? undefined : 0,
       className: (0, _runtime.ax)(["_nt751r31 _49pcglyw _1hvw1o36"])
-    }, (0, _fg.fg)('platform_a11y_fixes_reading_order') ? /*#__PURE__*/_react.default.createElement("div", {
+    }, /*#__PURE__*/_react.default.createElement("div", {
       className: (0, _runtime.ax)(["_1reo15vq _18m915vq _ogto7mnp _4t3it94y _kqswstnw _o5721q9c _1bsbt94y"])
     }, /*#__PURE__*/_react.default.createElement(_heading.default, {
       as: "h2",
       size: "small",
       id: PICKER_LABEL_ID
-    }, /*#__PURE__*/_react.default.createElement(_reactIntl.FormattedMessage, _i18n.messages.popperWrapperLabel))) : null, /*#__PURE__*/_react.default.createElement(_RepositionOnUpdate.RepositionOnUpdate, {
+    }, /*#__PURE__*/_react.default.createElement(_reactIntl.FormattedMessage, _i18n.messages.popperWrapperLabel))), /*#__PURE__*/_react.default.createElement(_RepositionOnUpdate.RepositionOnUpdate, {
       update: update,
       settings: settings
     }, /*#__PURE__*/_react.default.createElement("div", {

package/dist/cjs/components/ReactionSummaryView.js

@@ -14,7 +14,6 @@ var _runtime = require("@compiled/react/runtime");
 var _extends2 = _interopRequireDefault(require("@babel/runtime/helpers/extends"));
 var _slicedToArray2 = _interopRequireDefault(require("@babel/runtime/helpers/slicedToArray"));
 var _emojiPicker = _interopRequireDefault(require("@atlaskit/emoji/emoji-picker"));
-var _fg = require("@atlaskit/platform-feature-flags/fg");
 var _popup = require("@atlaskit/popup/popup");
 var _box = require("@atlaskit/primitives/compiled/box");
 var _flex = require("@atlaskit/primitives/compiled/flex");
@@ -243,8 +242,8 @@ var ReactionSummaryView = exports.ReactionSummaryView = function ReactionSummary
     },
     isOpen: isSummaryPopupOpen || isEmojiPickerOpen,
     onClose: handlePopupClose,
-    shouldRenderToParent: (0, _fg.fg)('platform_a11y_fixes_reading_order'),
-    strategy: (0, _fg.fg)('platform_a11y_fixes_reading_order') ? 'absolute' : undefined,
+    shouldRenderToParent: true,
+    strategy: "absolute",
     trigger: function trigger(triggerProps) {
       return /*#__PURE__*/React.createElement(_ReactionSummaryButton.ReactionSummaryButton, (0, _extends2.default)({}, triggerProps, {
         emojiProvider: emojiProvider,

package/dist/es2019/analytics/index.js

@@ -2,7 +2,7 @@ import { UI_EVENT_TYPE, OPERATIONAL_EVENT_TYPE } from '@atlaskit/analytics-gas-t
 // eslint-disable-next-line @typescript-eslint/consistent-type-imports
 import createAndFireEvent from '@atlaskit/analytics-next/createAndFireEvents';
 const packageName = "@atlaskit/reactions";
-const packageVersion = "37.1.1";
+const packageVersion = "37.1.2";
 /**
  * TODO: move to utility package?
  * A random sampling function

package/dist/es2019/components/Reaction.js

@@ -7,7 +7,6 @@ import { useIntl } from 'react-intl';
 import { useAnalyticsEvents } from '@atlaskit/analytics-next/useAnalyticsEvents';
 import { cx } from '@atlaskit/css';
 import ResourcedEmoji from '@atlaskit/emoji/resourced-emoji';
-import { fg } from '@atlaskit/platform-feature-flags/fg';
 import { Box } from '@atlaskit/primitives/compiled/box';
 import { Inline } from '@atlaskit/primitives/compiled/inline';
 import { createAndFireSafe, createReactionClickedEvent, createReactionFocusedEvent, createReactionHoveredEvent } from '../analytics';
@@ -131,7 +130,7 @@ export const Reaction = ({
     });
   }
   return /*#__PURE__*/React.createElement(Box, {
-    xcss: cx(styles.container, rootElement === 'li' ? styles.listItem : undefined, rootElement === 'li' && fg('platform_a11y_fixes_reading_order') ? styles.listItemNoMarker : undefined),
+    xcss: cx(styles.container, rootElement === 'li' ? styles.listItem : undefined, rootElement === 'li' ? styles.listItemNoMarker : undefined),
     as: rootElement
   }, showParticleEffect && /*#__PURE__*/React.createElement(ReactionParticleEffect, {
     emojiId: emojiId,

package/dist/es2019/components/ReactionPicker.js

@@ -2,7 +2,7 @@
 import "./ReactionPicker.compiled.css";
 import { ax, ix } from "@compiled/react/runtime";
 import React, { useCallback, useLayoutEffect, useRef, useState } from 'react';
-import { FormattedMessage, useIntl } from 'react-intl';
+import { FormattedMessage } from 'react-intl';
 import EmojiPicker from '@atlaskit/emoji/emoji-picker';
 import Heading from '@atlaskit/heading/heading';
 import { fg } from '@atlaskit/platform-feature-flags/fg';
@@ -342,9 +342,6 @@ export const PopperWrapper = props => {
     zIndex
   } = props;
   const [popupRef, setPopupRef] = useState(null);
-  const {
-    formatMessage
-  } = useIntl();
   /**
    * add focus lock to popup
    */
@@ -372,9 +369,8 @@ export const PopperWrapper = props => {
   }) => {
     return /*#__PURE__*/React.createElement("div", {
       role: "dialog",
-      "aria-label": fg('platform_a11y_fixes_reading_order') ? undefined : formatMessage(messages.popperWrapperLabel),
-      "aria-modal": fg('platform_a11y_fixes_reading_order') ? 'false' : undefined,
-      "aria-labelledby": fg('platform_a11y_fixes_reading_order') ? PICKER_LABEL_ID : undefined,
+      "aria-modal": "false",
+      "aria-labelledby": PICKER_LABEL_ID,
       id: PICKER_CONTROL_ID,
       "data-testid": RENDER_REACTIONPICKERPANEL_TESTID,
       style: {
@@ -395,13 +391,13 @@ export const PopperWrapper = props => {
       // eslint-disable-next-line @atlassian/a11y/no-noninteractive-tabindex
       tabIndex: fg('platform_suppression_removal_fix_reactions') ? undefined : 0,
       className: ax(["_nt751r31 _49pcglyw _1hvw1o36"])
-    }, fg('platform_a11y_fixes_reading_order') ? /*#__PURE__*/React.createElement("div", {
+    }, /*#__PURE__*/React.createElement("div", {
       className: ax(["_1reo15vq _18m915vq _ogto7mnp _4t3it94y _kqswstnw _o5721q9c _1bsbt94y"])
     }, /*#__PURE__*/React.createElement(Heading, {
       as: "h2",
       size: "small",
       id: PICKER_LABEL_ID
-    }, /*#__PURE__*/React.createElement(FormattedMessage, messages.popperWrapperLabel))) : null, /*#__PURE__*/React.createElement(RepositionOnUpdate, {
+    }, /*#__PURE__*/React.createElement(FormattedMessage, messages.popperWrapperLabel))), /*#__PURE__*/React.createElement(RepositionOnUpdate, {
       update: update,
       settings: settings
     }, /*#__PURE__*/React.createElement("div", {

package/dist/es2019/components/ReactionSummaryView.js

@@ -5,7 +5,6 @@ import * as React from 'react';
 import { ax, ix } from "@compiled/react/runtime";
 import { useCallback, useState } from 'react';
 import EmojiPicker from '@atlaskit/emoji/emoji-picker';
-import { fg } from '@atlaskit/platform-feature-flags/fg';
 import { Popup } from '@atlaskit/popup/popup';
 import { Box } from '@atlaskit/primitives/compiled/box';
 import { Flex } from '@atlaskit/primitives/compiled/flex';
@@ -209,8 +208,8 @@ export const ReactionSummaryView = ({
     }))),
     isOpen: isSummaryPopupOpen || isEmojiPickerOpen,
     onClose: handlePopupClose,
-    shouldRenderToParent: fg('platform_a11y_fixes_reading_order'),
-    strategy: fg('platform_a11y_fixes_reading_order') ? 'absolute' : undefined,
+    shouldRenderToParent: true,
+    strategy: "absolute",
     trigger: triggerProps => /*#__PURE__*/React.createElement(ReactionSummaryButton, _extends({}, triggerProps, {
       emojiProvider: emojiProvider,
       reactions: reactions,

package/dist/esm/analytics/index.js

@@ -5,7 +5,7 @@ import { UI_EVENT_TYPE, OPERATIONAL_EVENT_TYPE } from '@atlaskit/analytics-gas-t
 // eslint-disable-next-line @typescript-eslint/consistent-type-imports
 import createAndFireEvent from '@atlaskit/analytics-next/createAndFireEvents';
 var packageName = "@atlaskit/reactions";
-var packageVersion = "37.1.1";
+var packageVersion = "37.1.2";
 /**
  * TODO: move to utility package?
  * A random sampling function

package/dist/esm/components/Reaction.js

@@ -10,7 +10,6 @@ import { useIntl } from 'react-intl';
 import { useAnalyticsEvents } from '@atlaskit/analytics-next/useAnalyticsEvents';
 import { cx } from '@atlaskit/css';
 import ResourcedEmoji from '@atlaskit/emoji/resourced-emoji';
-import { fg } from '@atlaskit/platform-feature-flags/fg';
 import { Box } from '@atlaskit/primitives/compiled/box';
 import { Inline } from '@atlaskit/primitives/compiled/inline';
 import { createAndFireSafe, createReactionClickedEvent, createReactionFocusedEvent, createReactionHoveredEvent } from '../analytics';
@@ -155,7 +154,7 @@ export var Reaction = function Reaction(_ref) {
     });
   }
   return /*#__PURE__*/React.createElement(Box, {
-    xcss: cx(styles.container, rootElement === 'li' ? styles.listItem : undefined, rootElement === 'li' && fg('platform_a11y_fixes_reading_order') ? styles.listItemNoMarker : undefined),
+    xcss: cx(styles.container, rootElement === 'li' ? styles.listItem : undefined, rootElement === 'li' ? styles.listItemNoMarker : undefined),
     as: rootElement
   }, showParticleEffect && /*#__PURE__*/React.createElement(ReactionParticleEffect, {
     emojiId: emojiId,

package/dist/esm/components/ReactionPicker.js

@@ -6,7 +6,7 @@ import { ax, ix } from "@compiled/react/runtime";
 function ownKeys(e, r) { var t = Object.keys(e); if (Object.getOwnPropertySymbols) { var o = Object.getOwnPropertySymbols(e); r && (o = o.filter(function (r) { return Object.getOwnPropertyDescriptor(e, r).enumerable; })), t.push.apply(t, o); } return t; }
 function _objectSpread(e) { for (var r = 1; r < arguments.length; r++) { var t = null != arguments[r] ? arguments[r] : {}; r % 2 ? ownKeys(Object(t), !0).forEach(function (r) { _defineProperty(e, r, t[r]); }) : Object.getOwnPropertyDescriptors ? Object.defineProperties(e, Object.getOwnPropertyDescriptors(t)) : ownKeys(Object(t)).forEach(function (r) { Object.defineProperty(e, r, Object.getOwnPropertyDescriptor(t, r)); }); } return e; }
 import React, { useCallback, useLayoutEffect, useRef, useState } from 'react';
-import { FormattedMessage, useIntl } from 'react-intl';
+import { FormattedMessage } from 'react-intl';
 import EmojiPicker from '@atlaskit/emoji/emoji-picker';
 import Heading from '@atlaskit/heading/heading';
 import { fg } from '@atlaskit/platform-feature-flags/fg';
@@ -378,8 +378,6 @@ export var PopperWrapper = function PopperWrapper(props) {
     _useState12 = _slicedToArray(_useState11, 2),
     popupRef = _useState12[0],
     setPopupRef = _useState12[1];
-  var _useIntl = useIntl(),
-    formatMessage = _useIntl.formatMessage;
   /**
    * add focus lock to popup
    */
@@ -408,9 +406,8 @@ export var PopperWrapper = function PopperWrapper(props) {
       update = _ref3.update;
     return /*#__PURE__*/React.createElement("div", {
       role: "dialog",
-      "aria-label": fg('platform_a11y_fixes_reading_order') ? undefined : formatMessage(messages.popperWrapperLabel),
-      "aria-modal": fg('platform_a11y_fixes_reading_order') ? 'false' : undefined,
-      "aria-labelledby": fg('platform_a11y_fixes_reading_order') ? PICKER_LABEL_ID : undefined,
+      "aria-modal": "false",
+      "aria-labelledby": PICKER_LABEL_ID,
       id: PICKER_CONTROL_ID,
       "data-testid": RENDER_REACTIONPICKERPANEL_TESTID,
       style: _objectSpread({
@@ -429,13 +426,13 @@ export var PopperWrapper = function PopperWrapper(props) {
       // eslint-disable-next-line @atlassian/a11y/no-noninteractive-tabindex
       tabIndex: fg('platform_suppression_removal_fix_reactions') ? undefined : 0,
       className: ax(["_nt751r31 _49pcglyw _1hvw1o36"])
-    }, fg('platform_a11y_fixes_reading_order') ? /*#__PURE__*/React.createElement("div", {
+    }, /*#__PURE__*/React.createElement("div", {
       className: ax(["_1reo15vq _18m915vq _ogto7mnp _4t3it94y _kqswstnw _o5721q9c _1bsbt94y"])
     }, /*#__PURE__*/React.createElement(Heading, {
       as: "h2",
       size: "small",
       id: PICKER_LABEL_ID
-    }, /*#__PURE__*/React.createElement(FormattedMessage, messages.popperWrapperLabel))) : null, /*#__PURE__*/React.createElement(RepositionOnUpdate, {
+    }, /*#__PURE__*/React.createElement(FormattedMessage, messages.popperWrapperLabel))), /*#__PURE__*/React.createElement(RepositionOnUpdate, {
       update: update,
       settings: settings
     }, /*#__PURE__*/React.createElement("div", {

package/dist/esm/components/ReactionSummaryView.js

@@ -6,7 +6,6 @@ import * as React from 'react';
 import { ax, ix } from "@compiled/react/runtime";
 import { useCallback, useState } from 'react';
 import EmojiPicker from '@atlaskit/emoji/emoji-picker';
-import { fg } from '@atlaskit/platform-feature-flags/fg';
 import { Popup } from '@atlaskit/popup/popup';
 import { Box } from '@atlaskit/primitives/compiled/box';
 import { Flex } from '@atlaskit/primitives/compiled/flex';
@@ -234,8 +233,8 @@ export var ReactionSummaryView = function ReactionSummaryView(_ref) {
     },
     isOpen: isSummaryPopupOpen || isEmojiPickerOpen,
     onClose: handlePopupClose,
-    shouldRenderToParent: fg('platform_a11y_fixes_reading_order'),
-    strategy: fg('platform_a11y_fixes_reading_order') ? 'absolute' : undefined,
+    shouldRenderToParent: true,
+    strategy: "absolute",
     trigger: function trigger(triggerProps) {
       return /*#__PURE__*/React.createElement(ReactionSummaryButton, _extends({}, triggerProps, {
         emojiProvider: emojiProvider,

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@atlaskit/reactions",
-	"version": "37.1.2",
+	"version": "37.1.3",
 	"description": "Reactions component",
 	"publishConfig": {
 		"registry": "https://registry.npmjs.org/"
@@ -58,7 +58,7 @@
 		"@atlaskit/spinner": "^20.4.0",
 		"@atlaskit/tabs": "^21.3.0",
 		"@atlaskit/theme": "^28.2.0",
-		"@atlaskit/tmp-editor-statsig": "^246.1.0",
+		"@atlaskit/tmp-editor-statsig": "^247.0.0",
 		"@atlaskit/tokens": "^20.8.0",
 		"@atlaskit/tooltip": "^24.4.0",
 		"@atlaskit/ufo": "^2.0.0",
@@ -133,9 +133,6 @@
 		"a11y_reactions_reading_order": {
 			"type": "boolean"
 		},
-		"platform_a11y_fixes_reading_order": {
-			"type": "boolean"
-		},
 		"platform_reactions_a11y_group_added_reactions": {
 			"type": "boolean"
 		},