@atlaskit/reactions 36.7.5 → 36.7.7

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (8) hide show
  1. package/CHANGELOG.md +16 -0
  2. package/dist/cjs/analytics/index.js +1 -1
  3. package/dist/cjs/components/ReactionTooltip.js +7 -3
  4. package/dist/es2019/analytics/index.js +1 -1
  5. package/dist/es2019/components/ReactionTooltip.js +7 -3
  6. package/dist/esm/analytics/index.js +1 -1
  7. package/dist/esm/components/ReactionTooltip.js +7 -3
  8. package/package.json +6 -3
package/CHANGELOG.md CHANGED
@@ -1,5 +1,21 @@
1
1
  # @atlaskit/reactions
2
2
 
3
+ ## 36.7.7
4
+
5
+ ### Patch Changes
6
+
7
+ - Updated dependencies
8
+
9
+ ## 36.7.6
10
+
11
+ ### Patch Changes
12
+
13
+ - [`3e58b637efdde`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/3e58b637efdde) -
14
+ [ux] Remove the empty trailing list item from the reaction tooltip when the number of reacting
15
+ users is within the display limit. The empty item added unwanted vertical space at the bottom of
16
+ the tooltip. Behind the `platform_reactions_tooltip_hide_empty_footer` feature gate.
17
+ - Updated dependencies
18
+
3
19
  ## 36.7.5
4
20
 
5
21
  ### Patch Changes
package/dist/cjs/analytics/index.js CHANGED
@@ -11,7 +11,7 @@ var _createAndFireEvents = _interopRequireDefault(require("@atlaskit/analytics-n
11
11
  function ownKeys(e, r) { var t = Object.keys(e); if (Object.getOwnPropertySymbols) { var o = Object.getOwnPropertySymbols(e); r && (o = o.filter(function (r) { return Object.getOwnPropertyDescriptor(e, r).enumerable; })), t.push.apply(t, o); } return t; }
12
12
  function _objectSpread(e) { for (var r = 1; r < arguments.length; r++) { var t = null != arguments[r] ? arguments[r] : {}; r % 2 ? ownKeys(Object(t), !0).forEach(function (r) { (0, _defineProperty2.default)(e, r, t[r]); }) : Object.getOwnPropertyDescriptors ? Object.defineProperties(e, Object.getOwnPropertyDescriptors(t)) : ownKeys(Object(t)).forEach(function (r) { Object.defineProperty(e, r, Object.getOwnPropertyDescriptor(t, r)); }); } return e; } // eslint-disable-next-line @typescript-eslint/consistent-type-imports
13
13
  var packageName = "@atlaskit/reactions";
14
- var packageVersion = "36.7.4";
14
+ var packageVersion = "36.7.6";
15
15
  /**
16
16
  * TODO: move to utility package?
17
17
  * A random sampling function
package/dist/cjs/components/ReactionTooltip.js CHANGED
@@ -50,6 +50,10 @@ var ReactionTooltip = exports.ReactionTooltip = function ReactionTooltip(_ref) {
50
50
  handleOpenReactionsDialog();
51
51
  }
52
52
  };
53
+ var hasOverflow = users.length > maxReactions;
54
+ // Only render the footer <li> when there is overflow text to show; an empty <li> adds
55
+ // unwanted vertical space at the bottom of the tooltip.
56
+ var shouldRenderFooter = hasOverflow || !(0, _fg.fg)('platform_reactions_tooltip_hide_empty_footer');
53
57
  var content = !users || users.length === 0 || !isEnabled ? null : /*#__PURE__*/_react.default.createElement("div", {
54
58
  tabIndex: (0, _fg.fg)('platform_suppression_removal_fix_reactions') ? undefined : 0,
55
59
  className: (0, _runtime.ax)(["_1reo15vq _18m915vq _p12f1w81 _1bto1l2s _o5721q9c _otyr14y2 _d1n8glyw _102oidpf _1kvxidpf _1ysjidpf _17d4idpf _1hziidpf _3n4midpf _ltofidpf _k7zyidpf _1ywo1e5h _1pru15vq _u0h115vq _5qec1l2s _1eg614y2", wideTooltip && "_p12fnklw"])
@@ -64,9 +68,9 @@ var ReactionTooltip = exports.ReactionTooltip = function ReactionTooltip(_ref) {
64
68
  personName: user.displayName
65
69
  }
66
70
  })) : user.displayName);
67
- }), /*#__PURE__*/_react.default.createElement("li", {
71
+ }), shouldRenderFooter ? /*#__PURE__*/_react.default.createElement("li", {
68
72
  className: (0, _runtime.ax)(["_syaz15cr"])
69
- }, users.length > maxReactions && (allowUserDialog && handleOpenReactionsDialog ? /*#__PURE__*/_react.default.createElement("button", {
73
+ }, hasOverflow && (allowUserDialog && handleOpenReactionsDialog ? /*#__PURE__*/_react.default.createElement("button", {
70
74
  type: "button",
71
75
  onClick: handleClick,
72
76
  onMouseDown: function onMouseDown(e) {
@@ -81,7 +85,7 @@ var ReactionTooltip = exports.ReactionTooltip = function ReactionTooltip(_ref) {
81
85
  values: {
82
86
  count: users.length - maxReactions
83
87
  }
84
- }))))));
88
+ })))) : null));
85
89
  return /*#__PURE__*/_react.default.createElement(_Tooltip.default, {
86
90
  content: content,
87
91
  position: "bottom",
package/dist/es2019/analytics/index.js CHANGED
@@ -2,7 +2,7 @@ import { UI_EVENT_TYPE, OPERATIONAL_EVENT_TYPE } from '@atlaskit/analytics-gas-t
2
2
  // eslint-disable-next-line @typescript-eslint/consistent-type-imports
3
3
  import createAndFireEvent from '@atlaskit/analytics-next/createAndFireEvents';
4
4
  const packageName = "@atlaskit/reactions";
5
- const packageVersion = "36.7.4";
5
+ const packageVersion = "36.7.6";
6
6
  /**
7
7
  * TODO: move to utility package?
8
8
  * A random sampling function
package/dist/es2019/components/ReactionTooltip.js CHANGED
@@ -42,6 +42,10 @@ export const ReactionTooltip = ({
42
42
  handleOpenReactionsDialog();
43
43
  }
44
44
  };
45
+ const hasOverflow = users.length > maxReactions;
46
+ // Only render the footer <li> when there is overflow text to show; an empty <li> adds
47
+ // unwanted vertical space at the bottom of the tooltip.
48
+ const shouldRenderFooter = hasOverflow || !fg('platform_reactions_tooltip_hide_empty_footer');
45
49
  const content = !users || users.length === 0 || !isEnabled ? null : /*#__PURE__*/React.createElement("div", {
46
50
  tabIndex: fg('platform_suppression_removal_fix_reactions') ? undefined : 0,
47
51
  className: ax(["_1reo15vq _18m915vq _p12f1w81 _1bto1l2s _o5721q9c _otyr14y2 _d1n8glyw _102oidpf _1kvxidpf _1ysjidpf _17d4idpf _1hziidpf _3n4midpf _ltofidpf _k7zyidpf _1ywo1e5h _1pru15vq _u0h115vq _5qec1l2s _1eg614y2", wideTooltip && "_p12fnklw"])
@@ -54,9 +58,9 @@ export const ReactionTooltip = ({
54
58
  agentName: user.agent.name,
55
59
  personName: user.displayName
56
60
  }
57
- })) : user.displayName)), /*#__PURE__*/React.createElement("li", {
61
+ })) : user.displayName)), shouldRenderFooter ? /*#__PURE__*/React.createElement("li", {
58
62
  className: ax(["_syaz15cr"])
59
- }, users.length > maxReactions && (allowUserDialog && handleOpenReactionsDialog ? /*#__PURE__*/React.createElement("button", {
63
+ }, hasOverflow && (allowUserDialog && handleOpenReactionsDialog ? /*#__PURE__*/React.createElement("button", {
60
64
  type: "button",
61
65
  onClick: handleClick,
62
66
  onMouseDown: e => e.preventDefault(),
@@ -69,7 +73,7 @@ export const ReactionTooltip = ({
69
73
  values: {
70
74
  count: users.length - maxReactions
71
75
  }
72
- }))))));
76
+ })))) : null));
73
77
  return /*#__PURE__*/React.createElement(Tooltip, {
74
78
  content: content,
75
79
  position: "bottom",
package/dist/esm/analytics/index.js CHANGED
@@ -5,7 +5,7 @@ import { UI_EVENT_TYPE, OPERATIONAL_EVENT_TYPE } from '@atlaskit/analytics-gas-t
5
5
  // eslint-disable-next-line @typescript-eslint/consistent-type-imports
6
6
  import createAndFireEvent from '@atlaskit/analytics-next/createAndFireEvents';
7
7
  var packageName = "@atlaskit/reactions";
8
- var packageVersion = "36.7.4";
8
+ var packageVersion = "36.7.6";
9
9
  /**
10
10
  * TODO: move to utility package?
11
11
  * A random sampling function
package/dist/esm/components/ReactionTooltip.js CHANGED
@@ -43,6 +43,10 @@ export var ReactionTooltip = function ReactionTooltip(_ref) {
43
43
  handleOpenReactionsDialog();
44
44
  }
45
45
  };
46
+ var hasOverflow = users.length > maxReactions;
47
+ // Only render the footer <li> when there is overflow text to show; an empty <li> adds
48
+ // unwanted vertical space at the bottom of the tooltip.
49
+ var shouldRenderFooter = hasOverflow || !fg('platform_reactions_tooltip_hide_empty_footer');
46
50
  var content = !users || users.length === 0 || !isEnabled ? null : /*#__PURE__*/React.createElement("div", {
47
51
  tabIndex: fg('platform_suppression_removal_fix_reactions') ? undefined : 0,
48
52
  className: ax(["_1reo15vq _18m915vq _p12f1w81 _1bto1l2s _o5721q9c _otyr14y2 _d1n8glyw _102oidpf _1kvxidpf _1ysjidpf _17d4idpf _1hziidpf _3n4midpf _ltofidpf _k7zyidpf _1ywo1e5h _1pru15vq _u0h115vq _5qec1l2s _1eg614y2", wideTooltip && "_p12fnklw"])
@@ -57,9 +61,9 @@ export var ReactionTooltip = function ReactionTooltip(_ref) {
57
61
  personName: user.displayName
58
62
  }
59
63
  })) : user.displayName);
60
- }), /*#__PURE__*/React.createElement("li", {
64
+ }), shouldRenderFooter ? /*#__PURE__*/React.createElement("li", {
61
65
  className: ax(["_syaz15cr"])
62
- }, users.length > maxReactions && (allowUserDialog && handleOpenReactionsDialog ? /*#__PURE__*/React.createElement("button", {
66
+ }, hasOverflow && (allowUserDialog && handleOpenReactionsDialog ? /*#__PURE__*/React.createElement("button", {
63
67
  type: "button",
64
68
  onClick: handleClick,
65
69
  onMouseDown: function onMouseDown(e) {
@@ -74,7 +78,7 @@ export var ReactionTooltip = function ReactionTooltip(_ref) {
74
78
  values: {
75
79
  count: users.length - maxReactions
76
80
  }
77
- }))))));
81
+ })))) : null));
78
82
  return /*#__PURE__*/React.createElement(Tooltip, {
79
83
  content: content,
80
84
  position: "bottom",
package/package.json CHANGED
@@ -1,6 +1,6 @@
1
1
  {
2
2
  "name": "@atlaskit/reactions",
3
- "version": "36.7.5",
3
+ "version": "36.7.7",
4
4
  "description": "Reactions component",
5
5
  "publishConfig": {
6
6
  "registry": "https://registry.npmjs.org/"
@@ -58,8 +58,8 @@
58
58
  "@atlaskit/spinner": "^20.4.0",
59
59
  "@atlaskit/tabs": "^21.3.0",
60
60
  "@atlaskit/theme": "^28.2.0",
61
- "@atlaskit/tmp-editor-statsig": "^226.0.0",
62
- "@atlaskit/tokens": "^20.3.0",
61
+ "@atlaskit/tmp-editor-statsig": "^228.0.0",
62
+ "@atlaskit/tokens": "^20.4.0",
63
63
  "@atlaskit/tooltip": "^24.4.0",
64
64
  "@atlaskit/ufo": "^2.0.0",
65
65
  "@atlaskit/util-service-support": "^7.4.0",
@@ -129,6 +129,9 @@
129
129
  "platform_suppression_removal_fix_reactions": {
130
130
  "type": "boolean"
131
131
  },
132
+ "platform_reactions_tooltip_hide_empty_footer": {
133
+ "type": "boolean"
134
+ },
132
135
  "a11y_reactions_reading_order": {
133
136
  "type": "boolean"
134
137
  },