@atlaskit/reactions 36.7.10 → 36.7.12

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (8) hide show
  1. package/CHANGELOG.md +18 -0
  2. package/dist/cjs/analytics/index.js +1 -1
  3. package/dist/cjs/components/ReactionTooltip.js +2 -6
  4. package/dist/es2019/analytics/index.js +1 -1
  5. package/dist/es2019/components/ReactionTooltip.js +2 -6
  6. package/dist/esm/analytics/index.js +1 -1
  7. package/dist/esm/components/ReactionTooltip.js +2 -6
  8. package/package.json +2 -2
package/CHANGELOG.md CHANGED
@@ -1,5 +1,23 @@
1
1
  # @atlaskit/reactions
2
2
 
3
+ ## 36.7.12
4
+
5
+ ### Patch Changes
6
+
7
+ - [`f28df45e6c910`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/f28df45e6c910) -
8
+ Fix the reaction tooltip footer change so that it is fully contained behind the
9
+ `platform_reactions_tooltip_hide_empty_footer` feature gate. The overflow check was previously
10
+ evaluated before the existing guard on the reacting user list, so it ran on every render
11
+ regardless of the gate. With the gate off the rendered markup is now identical to the behaviour
12
+ prior to the gate being introduced.
13
+ - Updated dependencies
14
+
15
+ ## 36.7.11
16
+
17
+ ### Patch Changes
18
+
19
+ - Updated dependencies
20
+
3
21
  ## 36.7.10
4
22
 
5
23
  ### Patch Changes
package/dist/cjs/analytics/index.js CHANGED
@@ -11,7 +11,7 @@ var _createAndFireEvents = _interopRequireDefault(require("@atlaskit/analytics-n
11
11
  function ownKeys(e, r) { var t = Object.keys(e); if (Object.getOwnPropertySymbols) { var o = Object.getOwnPropertySymbols(e); r && (o = o.filter(function (r) { return Object.getOwnPropertyDescriptor(e, r).enumerable; })), t.push.apply(t, o); } return t; }
12
12
  function _objectSpread(e) { for (var r = 1; r < arguments.length; r++) { var t = null != arguments[r] ? arguments[r] : {}; r % 2 ? ownKeys(Object(t), !0).forEach(function (r) { (0, _defineProperty2.default)(e, r, t[r]); }) : Object.getOwnPropertyDescriptors ? Object.defineProperties(e, Object.getOwnPropertyDescriptors(t)) : ownKeys(Object(t)).forEach(function (r) { Object.defineProperty(e, r, Object.getOwnPropertyDescriptor(t, r)); }); } return e; } // eslint-disable-next-line @typescript-eslint/consistent-type-imports
13
13
  var packageName = "@atlaskit/reactions";
14
- var packageVersion = "36.7.9";
14
+ var packageVersion = "36.7.11";
15
15
  /**
16
16
  * TODO: move to utility package?
17
17
  * A random sampling function
package/dist/cjs/components/ReactionTooltip.js CHANGED
@@ -50,10 +50,6 @@ var ReactionTooltip = exports.ReactionTooltip = function ReactionTooltip(_ref) {
50
50
  handleOpenReactionsDialog();
51
51
  }
52
52
  };
53
- var hasOverflow = users.length > maxReactions;
54
- // Only render the footer <li> when there is overflow text to show; an empty <li> adds
55
- // unwanted vertical space at the bottom of the tooltip.
56
- var shouldRenderFooter = hasOverflow || !(0, _fg.fg)('platform_reactions_tooltip_hide_empty_footer');
57
53
  var content = !users || users.length === 0 || !isEnabled ? null : /*#__PURE__*/_react.default.createElement("div", {
58
54
  tabIndex: (0, _fg.fg)('platform_suppression_removal_fix_reactions') ? undefined : 0,
59
55
  className: (0, _runtime.ax)(["_1reo15vq _18m915vq _p12f1w81 _1bto1l2s _o5721q9c _otyr14y2 _d1n8glyw _102oidpf _1kvxidpf _1ysjidpf _17d4idpf _1hziidpf _3n4midpf _ltofidpf _k7zyidpf _1ywo1e5h _1pru15vq _u0h115vq _5qec1l2s _1eg614y2", wideTooltip && "_p12fnklw"])
@@ -68,9 +64,9 @@ var ReactionTooltip = exports.ReactionTooltip = function ReactionTooltip(_ref) {
68
64
  personName: user.displayName
69
65
  }
70
66
  })) : user.displayName);
71
- }), shouldRenderFooter ? /*#__PURE__*/_react.default.createElement("li", {
67
+ }), !(0, _fg.fg)('platform_reactions_tooltip_hide_empty_footer') || users.length > maxReactions ? /*#__PURE__*/_react.default.createElement("li", {
72
68
  className: (0, _runtime.ax)(["_syaz15cr"])
73
- }, hasOverflow && (allowUserDialog && handleOpenReactionsDialog ? /*#__PURE__*/_react.default.createElement("button", {
69
+ }, users.length > maxReactions && (allowUserDialog && handleOpenReactionsDialog ? /*#__PURE__*/_react.default.createElement("button", {
74
70
  type: "button",
75
71
  onClick: handleClick,
76
72
  onMouseDown: function onMouseDown(e) {
package/dist/es2019/analytics/index.js CHANGED
@@ -2,7 +2,7 @@ import { UI_EVENT_TYPE, OPERATIONAL_EVENT_TYPE } from '@atlaskit/analytics-gas-t
2
2
  // eslint-disable-next-line @typescript-eslint/consistent-type-imports
3
3
  import createAndFireEvent from '@atlaskit/analytics-next/createAndFireEvents';
4
4
  const packageName = "@atlaskit/reactions";
5
- const packageVersion = "36.7.9";
5
+ const packageVersion = "36.7.11";
6
6
  /**
7
7
  * TODO: move to utility package?
8
8
  * A random sampling function
package/dist/es2019/components/ReactionTooltip.js CHANGED
@@ -42,10 +42,6 @@ export const ReactionTooltip = ({
42
42
  handleOpenReactionsDialog();
43
43
  }
44
44
  };
45
- const hasOverflow = users.length > maxReactions;
46
- // Only render the footer <li> when there is overflow text to show; an empty <li> adds
47
- // unwanted vertical space at the bottom of the tooltip.
48
- const shouldRenderFooter = hasOverflow || !fg('platform_reactions_tooltip_hide_empty_footer');
49
45
  const content = !users || users.length === 0 || !isEnabled ? null : /*#__PURE__*/React.createElement("div", {
50
46
  tabIndex: fg('platform_suppression_removal_fix_reactions') ? undefined : 0,
51
47
  className: ax(["_1reo15vq _18m915vq _p12f1w81 _1bto1l2s _o5721q9c _otyr14y2 _d1n8glyw _102oidpf _1kvxidpf _1ysjidpf _17d4idpf _1hziidpf _3n4midpf _ltofidpf _k7zyidpf _1ywo1e5h _1pru15vq _u0h115vq _5qec1l2s _1eg614y2", wideTooltip && "_p12fnklw"])
@@ -58,9 +54,9 @@ export const ReactionTooltip = ({
58
54
  agentName: user.agent.name,
59
55
  personName: user.displayName
60
56
  }
61
- })) : user.displayName)), shouldRenderFooter ? /*#__PURE__*/React.createElement("li", {
57
+ })) : user.displayName)), !fg('platform_reactions_tooltip_hide_empty_footer') || users.length > maxReactions ? /*#__PURE__*/React.createElement("li", {
62
58
  className: ax(["_syaz15cr"])
63
- }, hasOverflow && (allowUserDialog && handleOpenReactionsDialog ? /*#__PURE__*/React.createElement("button", {
59
+ }, users.length > maxReactions && (allowUserDialog && handleOpenReactionsDialog ? /*#__PURE__*/React.createElement("button", {
64
60
  type: "button",
65
61
  onClick: handleClick,
66
62
  onMouseDown: e => e.preventDefault(),
package/dist/esm/analytics/index.js CHANGED
@@ -5,7 +5,7 @@ import { UI_EVENT_TYPE, OPERATIONAL_EVENT_TYPE } from '@atlaskit/analytics-gas-t
5
5
  // eslint-disable-next-line @typescript-eslint/consistent-type-imports
6
6
  import createAndFireEvent from '@atlaskit/analytics-next/createAndFireEvents';
7
7
  var packageName = "@atlaskit/reactions";
8
- var packageVersion = "36.7.9";
8
+ var packageVersion = "36.7.11";
9
9
  /**
10
10
  * TODO: move to utility package?
11
11
  * A random sampling function
package/dist/esm/components/ReactionTooltip.js CHANGED
@@ -43,10 +43,6 @@ export var ReactionTooltip = function ReactionTooltip(_ref) {
43
43
  handleOpenReactionsDialog();
44
44
  }
45
45
  };
46
- var hasOverflow = users.length > maxReactions;
47
- // Only render the footer <li> when there is overflow text to show; an empty <li> adds
48
- // unwanted vertical space at the bottom of the tooltip.
49
- var shouldRenderFooter = hasOverflow || !fg('platform_reactions_tooltip_hide_empty_footer');
50
46
  var content = !users || users.length === 0 || !isEnabled ? null : /*#__PURE__*/React.createElement("div", {
51
47
  tabIndex: fg('platform_suppression_removal_fix_reactions') ? undefined : 0,
52
48
  className: ax(["_1reo15vq _18m915vq _p12f1w81 _1bto1l2s _o5721q9c _otyr14y2 _d1n8glyw _102oidpf _1kvxidpf _1ysjidpf _17d4idpf _1hziidpf _3n4midpf _ltofidpf _k7zyidpf _1ywo1e5h _1pru15vq _u0h115vq _5qec1l2s _1eg614y2", wideTooltip && "_p12fnklw"])
@@ -61,9 +57,9 @@ export var ReactionTooltip = function ReactionTooltip(_ref) {
61
57
  personName: user.displayName
62
58
  }
63
59
  })) : user.displayName);
64
- }), shouldRenderFooter ? /*#__PURE__*/React.createElement("li", {
60
+ }), !fg('platform_reactions_tooltip_hide_empty_footer') || users.length > maxReactions ? /*#__PURE__*/React.createElement("li", {
65
61
  className: ax(["_syaz15cr"])
66
- }, hasOverflow && (allowUserDialog && handleOpenReactionsDialog ? /*#__PURE__*/React.createElement("button", {
62
+ }, users.length > maxReactions && (allowUserDialog && handleOpenReactionsDialog ? /*#__PURE__*/React.createElement("button", {
67
63
  type: "button",
68
64
  onClick: handleClick,
69
65
  onMouseDown: function onMouseDown(e) {
package/package.json CHANGED
@@ -1,6 +1,6 @@
1
1
  {
2
2
  "name": "@atlaskit/reactions",
3
- "version": "36.7.10",
3
+ "version": "36.7.12",
4
4
  "description": "Reactions component",
5
5
  "publishConfig": {
6
6
  "registry": "https://registry.npmjs.org/"
@@ -58,7 +58,7 @@
58
58
  "@atlaskit/spinner": "^20.4.0",
59
59
  "@atlaskit/tabs": "^21.3.0",
60
60
  "@atlaskit/theme": "^28.2.0",
61
- "@atlaskit/tmp-editor-statsig": "^230.0.0",
61
+ "@atlaskit/tmp-editor-statsig": "^232.0.0",
62
62
  "@atlaskit/tokens": "^20.4.0",
63
63
  "@atlaskit/tooltip": "^24.4.0",
64
64
  "@atlaskit/ufo": "^2.0.0",