@atlaskit/reactions 36.2.8 → 36.2.10

package/CHANGELOG.md

@@ -1,5 +1,20 @@
 # @atlaskit/reactions
 
+## 36.2.10
+
+### Patch Changes
+
+- [`ab8b090b9c640`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/ab8b090b9c640) -
+  Cleanup experiment `platform_a11y_reactions_hover_selector_list`. Hoverable reaction selectors and
+  summary reactions now always render with list markup.
+- Updated dependencies
+
+## 36.2.9
+
+### Patch Changes
+
+- Updated dependencies
+
 ## 36.2.8
 
 ### Patch Changes

package/dist/cjs/analytics/index.js

@@ -11,7 +11,7 @@ var _analyticsGasTypes = require("@atlaskit/analytics-gas-types");
 function ownKeys(e, r) { var t = Object.keys(e); if (Object.getOwnPropertySymbols) { var o = Object.getOwnPropertySymbols(e); r && (o = o.filter(function (r) { return Object.getOwnPropertyDescriptor(e, r).enumerable; })), t.push.apply(t, o); } return t; }
 function _objectSpread(e) { for (var r = 1; r < arguments.length; r++) { var t = null != arguments[r] ? arguments[r] : {}; r % 2 ? ownKeys(Object(t), !0).forEach(function (r) { (0, _defineProperty2.default)(e, r, t[r]); }) : Object.getOwnPropertyDescriptors ? Object.defineProperties(e, Object.getOwnPropertyDescriptors(t)) : ownKeys(Object(t)).forEach(function (r) { Object.defineProperty(e, r, Object.getOwnPropertyDescriptor(t, r)); }); } return e; } // eslint-disable-next-line @typescript-eslint/consistent-type-imports
 var packageName = "@atlaskit/reactions";
-var packageVersion = "36.2.7";
+var packageVersion = "36.2.9";
 /**
  * TODO: move to utility package?
  * A random sampling function

package/dist/cjs/components/ReactionSummaryView.js

@@ -15,7 +15,6 @@ var _extends2 = _interopRequireDefault(require("@babel/runtime/helpers/extends")
 var _slicedToArray2 = _interopRequireDefault(require("@babel/runtime/helpers/slicedToArray"));
 var _popup = require("@atlaskit/popup/popup");
 var _picker = require("@atlaskit/emoji/picker");
-var _isExperimentEnabled = require("@atlaskit/platform-feature-experiments/is-experiment-enabled");
 var _fg = require("@atlaskit/platform-feature-flags/fg");
 var _useDelayedState3 = require("../hooks/useDelayedState");
 var _Reaction = require("./Reaction");
@@ -25,7 +24,6 @@ var _ufo = require("../ufo");
 var _compiled = require("@atlaskit/primitives/compiled");
 function _interopRequireWildcard(e, t) { if ("function" == typeof WeakMap) var r = new WeakMap(), n = new WeakMap(); return (_interopRequireWildcard = function _interopRequireWildcard(e, t) { if (!t && e && e.__esModule) return e; var o, i, f = { __proto__: null, default: e }; if (null === e || "object" != _typeof(e) && "function" != typeof e) return f; if (o = t ? n : r) { if (o.has(e)) return o.get(e); o.set(e, f); } for (var _t in e) "default" !== _t && {}.hasOwnProperty.call(e, _t) && ((i = (o = Object.defineProperty) && Object.getOwnPropertyDescriptor(e, _t)) && (i.get || i.set) ? o(f, _t, i) : f[_t] = e[_t]); return f; })(e, t); }
 var styles = {
-  summaryPopup: "_ca0q1b66 _u5f3u2gc _n3tdu2gc _19bvu2gc _p12foiq5",
   summaryList: "_ca0q1b66 _u5f3u2gc _n3tdu2gc _19bvu2gc _19pkze3t _2hwxze3t _otyrze3t _18u0ze3t _p12foiq5 _2mzuglyw"
 };
 
@@ -189,7 +187,6 @@ var ReactionSummaryView = exports.ReactionSummaryView = function ReactionSummary
       setSummaryPopupOpen(false);
     }
   }, [hoverableSummaryView, isSummaryViewButtonHovered, setIsHoveringSummaryView, setSummaryPopupOpen, isSummaryViewButtonClicked]);
-  var shouldRenderReactionSummaryList = (0, _isExperimentEnabled.isExperimentEnabled)('platform_a11y_reactions_hover_selector_list');
   return /*#__PURE__*/React.createElement(_popup.Popup, {
     placement: placement,
     content: function content(_ref2) {
@@ -218,15 +215,15 @@ var ReactionSummaryView = exports.ReactionSummaryView = function ReactionSummary
         reactionPickerTriggerText: reactionPickerTriggerText,
         fullWidthSummaryViewReactionPickerTrigger: true
       })), /*#__PURE__*/React.createElement(_compiled.Inline, {
-        as: shouldRenderReactionSummaryList ? 'ul' : undefined,
-        xcss: shouldRenderReactionSummaryList ? styles.summaryList : styles.summaryPopup,
+        as: "ul",
+        xcss: styles.summaryList,
         space: "space.025",
         shouldWrap: true,
         alignBlock: "center"
       }, reactions.map(function (reaction) {
         return /*#__PURE__*/React.createElement(_Reaction.Reaction, {
           key: reaction.emojiId,
-          rootElement: shouldRenderReactionSummaryList ? 'li' : undefined,
+          rootElement: "li",
           reaction: reaction,
           emojiProvider: emojiProvider,
           onClick: onReactionClick,

package/dist/cjs/components/Selector.js

@@ -13,7 +13,6 @@ var React = _react;
 var _runtime = require("@compiled/react/runtime");
 var _slicedToArray2 = _interopRequireDefault(require("@babel/runtime/helpers/slicedToArray"));
 var _expValEquals = require("@atlaskit/tmp-editor-statsig/exp-val-equals");
-var _isExperimentEnabled = require("@atlaskit/platform-feature-experiments/is-experiment-enabled");
 var _fg = require("@atlaskit/platform-feature-flags/fg");
 var _compiled = require("@atlaskit/primitives/compiled");
 var _Tooltip = _interopRequireDefault(require("@atlaskit/tooltip/Tooltip"));
@@ -68,7 +67,6 @@ var Selector = exports.Selector = function Selector(_ref2) {
     setIsTeamojiPickerRefreshEnabled((0, _expValEquals.expValEquals)('platform_teamoji_26_refresh_emoji_picker', 'isEnabled', true) || (0, _fg.fg)('platform_teamoji_26_refresh_emoji_picker_user_id'));
   }, []);
   var quickReactionEmojiIds = pickerQuickReactionEmojiIds !== null && pickerQuickReactionEmojiIds !== void 0 ? pickerQuickReactionEmojiIds : (0, _constants.getDefaultReactions)(isTeamojiPickerRefreshEnabled);
-  var shouldRenderHoverableReactionPickerSelectorList = hoverableReactionPickerSelector && (0, _isExperimentEnabled.isExperimentEnabled)('platform_a11y_reactions_hover_selector_list');
 
   /**
    * Render the default emoji icon
@@ -86,11 +84,11 @@ var Selector = exports.Selector = function Selector(_ref2) {
       onClick: onSelection,
       hoverableReactionPickerSelectorEmoji: hoverableReactionPickerSelector
     }));
-    return hoverableReactionPickerSelector ? shouldRenderHoverableReactionPickerSelectorList ? /*#__PURE__*/React.createElement(_compiled.Box, {
+    return hoverableReactionPickerSelector ? /*#__PURE__*/React.createElement(_compiled.Box, {
       as: "li",
       key: (_emoji$id2 = emoji.id) !== null && _emoji$id2 !== void 0 ? _emoji$id2 : emoji.shortName,
       xcss: styles.emojiContainer
-    }, emojiButtonAndTooltip) : emojiButtonAndTooltip : /*#__PURE__*/React.createElement(Reveal, {
+    }, emojiButtonAndTooltip) : /*#__PURE__*/React.createElement(Reveal, {
       key: (_emoji$id3 = emoji.id) !== null && _emoji$id3 !== void 0 ? _emoji$id3 : emoji.shortName,
       testId: RENDER_SELECTOR_TESTID
     }, emojiButtonAndTooltip);
@@ -105,9 +103,9 @@ var Selector = exports.Selector = function Selector(_ref2) {
       reactionPickerTriggerText: _i18n.messages.addNewReaction.defaultMessage,
       fullWidthSelectorTrayReactionPickerTrigger: true
     }), /*#__PURE__*/React.createElement(_compiled.Inline, {
-      as: shouldRenderHoverableReactionPickerSelectorList ? 'ul' : undefined,
+      as: "ul",
       alignBlock: "center",
-      xcss: shouldRenderHoverableReactionPickerSelectorList ? styles.hoverableReactionPickerSelectorList : styles.hoverableReactionPickerSelectorContainer
+      xcss: styles.hoverableReactionPickerSelectorList
     }, quickReactionEmojiIds.map(renderEmoji)));
   }
   var isSelectorListMarkupFixEnabled = (0, _expValEquals.expValEquals)('platform_a11y_fixes_reactions_selector_list', 'isEnabled', true);

package/dist/es2019/analytics/index.js

@@ -2,7 +2,7 @@
 import createAndFireEvent from '@atlaskit/analytics-next/createAndFireEvents';
 import { UI_EVENT_TYPE, OPERATIONAL_EVENT_TYPE } from '@atlaskit/analytics-gas-types';
 const packageName = "@atlaskit/reactions";
-const packageVersion = "36.2.7";
+const packageVersion = "36.2.9";
 /**
  * TODO: move to utility package?
  * A random sampling function

package/dist/es2019/components/ReactionSummaryView.js

@@ -6,7 +6,6 @@ import { ax, ix } from "@compiled/react/runtime";
 import { useCallback, useState } from 'react';
 import { Popup } from '@atlaskit/popup/popup';
 import { EmojiPicker } from '@atlaskit/emoji/picker';
-import { isExperimentEnabled } from '@atlaskit/platform-feature-experiments/is-experiment-enabled';
 import { fg } from '@atlaskit/platform-feature-flags/fg';
 import { useDelayedState } from '../hooks/useDelayedState';
 import { Reaction } from './Reaction';
@@ -15,7 +14,6 @@ import { ReactionSummaryButton } from './ReactionSummaryButton';
 import { PickerRender } from '../ufo';
 import { Box, Flex, Inline } from '@atlaskit/primitives/compiled';
 const styles = {
-  summaryPopup: "_ca0q1b66 _u5f3u2gc _n3tdu2gc _19bvu2gc _p12foiq5",
   summaryList: "_ca0q1b66 _u5f3u2gc _n3tdu2gc _19bvu2gc _19pkze3t _2hwxze3t _otyrze3t _18u0ze3t _p12foiq5 _2mzuglyw"
 };
 
@@ -156,7 +154,6 @@ export const ReactionSummaryView = ({
       setSummaryPopupOpen(false);
     }
   }, [hoverableSummaryView, isSummaryViewButtonHovered, setIsHoveringSummaryView, setSummaryPopupOpen, isSummaryViewButtonClicked]);
-  const shouldRenderReactionSummaryList = isExperimentEnabled('platform_a11y_reactions_hover_selector_list');
   return /*#__PURE__*/React.createElement(Popup, {
     placement: placement,
     content: ({
@@ -185,15 +182,15 @@ export const ReactionSummaryView = ({
       reactionPickerTriggerText: reactionPickerTriggerText,
       fullWidthSummaryViewReactionPickerTrigger: true
     })), /*#__PURE__*/React.createElement(Inline, {
-      as: shouldRenderReactionSummaryList ? 'ul' : undefined,
-      xcss: shouldRenderReactionSummaryList ? styles.summaryList : styles.summaryPopup,
+      as: "ul",
+      xcss: styles.summaryList,
       space: "space.025",
       shouldWrap: true,
       alignBlock: "center"
     }, reactions.map(reaction => {
       return /*#__PURE__*/React.createElement(Reaction, {
         key: reaction.emojiId,
-        rootElement: shouldRenderReactionSummaryList ? 'li' : undefined,
+        rootElement: "li",
         reaction: reaction,
         emojiProvider: emojiProvider,
         onClick: onReactionClick,

package/dist/es2019/components/Selector.js

@@ -4,7 +4,6 @@ import * as React from 'react';
 import { ax, ix } from "@compiled/react/runtime";
 import { Fragment, useEffect, useState } from 'react';
 import { expValEquals } from '@atlaskit/tmp-editor-statsig/exp-val-equals';
-import { isExperimentEnabled } from '@atlaskit/platform-feature-experiments/is-experiment-enabled';
 import { fg } from '@atlaskit/platform-feature-flags/fg';
 import { Box, Inline } from '@atlaskit/primitives/compiled';
 import Tooltip from '@atlaskit/tooltip/Tooltip';
@@ -56,7 +55,6 @@ export const Selector = ({
     setIsTeamojiPickerRefreshEnabled(expValEquals('platform_teamoji_26_refresh_emoji_picker', 'isEnabled', true) || fg('platform_teamoji_26_refresh_emoji_picker_user_id'));
   }, []);
   const quickReactionEmojiIds = pickerQuickReactionEmojiIds !== null && pickerQuickReactionEmojiIds !== void 0 ? pickerQuickReactionEmojiIds : getDefaultReactions(isTeamojiPickerRefreshEnabled);
-  const shouldRenderHoverableReactionPickerSelectorList = hoverableReactionPickerSelector && isExperimentEnabled('platform_a11y_reactions_hover_selector_list');
 
   /**
    * Render the default emoji icon
@@ -74,11 +72,11 @@ export const Selector = ({
       onClick: onSelection,
       hoverableReactionPickerSelectorEmoji: hoverableReactionPickerSelector
     }));
-    return hoverableReactionPickerSelector ? shouldRenderHoverableReactionPickerSelectorList ? /*#__PURE__*/React.createElement(Box, {
+    return hoverableReactionPickerSelector ? /*#__PURE__*/React.createElement(Box, {
       as: "li",
       key: (_emoji$id2 = emoji.id) !== null && _emoji$id2 !== void 0 ? _emoji$id2 : emoji.shortName,
       xcss: styles.emojiContainer
-    }, emojiButtonAndTooltip) : emojiButtonAndTooltip : /*#__PURE__*/React.createElement(Reveal, {
+    }, emojiButtonAndTooltip) : /*#__PURE__*/React.createElement(Reveal, {
       key: (_emoji$id3 = emoji.id) !== null && _emoji$id3 !== void 0 ? _emoji$id3 : emoji.shortName,
       testId: RENDER_SELECTOR_TESTID
     }, emojiButtonAndTooltip);
@@ -93,9 +91,9 @@ export const Selector = ({
       reactionPickerTriggerText: messages.addNewReaction.defaultMessage,
       fullWidthSelectorTrayReactionPickerTrigger: true
     }), /*#__PURE__*/React.createElement(Inline, {
-      as: shouldRenderHoverableReactionPickerSelectorList ? 'ul' : undefined,
+      as: "ul",
       alignBlock: "center",
-      xcss: shouldRenderHoverableReactionPickerSelectorList ? styles.hoverableReactionPickerSelectorList : styles.hoverableReactionPickerSelectorContainer
+      xcss: styles.hoverableReactionPickerSelectorList
     }, quickReactionEmojiIds.map(renderEmoji)));
   }
   const isSelectorListMarkupFixEnabled = expValEquals('platform_a11y_fixes_reactions_selector_list', 'isEnabled', true);

package/dist/esm/analytics/index.js

@@ -5,7 +5,7 @@ function _objectSpread(e) { for (var r = 1; r < arguments.length; r++) { var t =
 import createAndFireEvent from '@atlaskit/analytics-next/createAndFireEvents';
 import { UI_EVENT_TYPE, OPERATIONAL_EVENT_TYPE } from '@atlaskit/analytics-gas-types';
 var packageName = "@atlaskit/reactions";
-var packageVersion = "36.2.7";
+var packageVersion = "36.2.9";
 /**
  * TODO: move to utility package?
  * A random sampling function

package/dist/esm/components/ReactionSummaryView.js

@@ -7,7 +7,6 @@ import { ax, ix } from "@compiled/react/runtime";
 import { useCallback, useState } from 'react';
 import { Popup } from '@atlaskit/popup/popup';
 import { EmojiPicker } from '@atlaskit/emoji/picker';
-import { isExperimentEnabled } from '@atlaskit/platform-feature-experiments/is-experiment-enabled';
 import { fg } from '@atlaskit/platform-feature-flags/fg';
 import { useDelayedState } from '../hooks/useDelayedState';
 import { Reaction } from './Reaction';
@@ -16,7 +15,6 @@ import { ReactionSummaryButton } from './ReactionSummaryButton';
 import { PickerRender } from '../ufo';
 import { Box, Flex, Inline } from '@atlaskit/primitives/compiled';
 var styles = {
-  summaryPopup: "_ca0q1b66 _u5f3u2gc _n3tdu2gc _19bvu2gc _p12foiq5",
   summaryList: "_ca0q1b66 _u5f3u2gc _n3tdu2gc _19bvu2gc _19pkze3t _2hwxze3t _otyrze3t _18u0ze3t _p12foiq5 _2mzuglyw"
 };
 
@@ -180,7 +178,6 @@ export var ReactionSummaryView = function ReactionSummaryView(_ref) {
       setSummaryPopupOpen(false);
     }
   }, [hoverableSummaryView, isSummaryViewButtonHovered, setIsHoveringSummaryView, setSummaryPopupOpen, isSummaryViewButtonClicked]);
-  var shouldRenderReactionSummaryList = isExperimentEnabled('platform_a11y_reactions_hover_selector_list');
   return /*#__PURE__*/React.createElement(Popup, {
     placement: placement,
     content: function content(_ref2) {
@@ -209,15 +206,15 @@ export var ReactionSummaryView = function ReactionSummaryView(_ref) {
         reactionPickerTriggerText: reactionPickerTriggerText,
         fullWidthSummaryViewReactionPickerTrigger: true
       })), /*#__PURE__*/React.createElement(Inline, {
-        as: shouldRenderReactionSummaryList ? 'ul' : undefined,
-        xcss: shouldRenderReactionSummaryList ? styles.summaryList : styles.summaryPopup,
+        as: "ul",
+        xcss: styles.summaryList,
         space: "space.025",
         shouldWrap: true,
         alignBlock: "center"
       }, reactions.map(function (reaction) {
         return /*#__PURE__*/React.createElement(Reaction, {
           key: reaction.emojiId,
-          rootElement: shouldRenderReactionSummaryList ? 'li' : undefined,
+          rootElement: "li",
           reaction: reaction,
           emojiProvider: emojiProvider,
           onClick: onReactionClick,

package/dist/esm/components/Selector.js

@@ -5,7 +5,6 @@ import * as React from 'react';
 import { ax, ix } from "@compiled/react/runtime";
 import { Fragment, useEffect, useState } from 'react';
 import { expValEquals } from '@atlaskit/tmp-editor-statsig/exp-val-equals';
-import { isExperimentEnabled } from '@atlaskit/platform-feature-experiments/is-experiment-enabled';
 import { fg } from '@atlaskit/platform-feature-flags/fg';
 import { Box, Inline } from '@atlaskit/primitives/compiled';
 import Tooltip from '@atlaskit/tooltip/Tooltip';
@@ -59,7 +58,6 @@ export var Selector = function Selector(_ref2) {
     setIsTeamojiPickerRefreshEnabled(expValEquals('platform_teamoji_26_refresh_emoji_picker', 'isEnabled', true) || fg('platform_teamoji_26_refresh_emoji_picker_user_id'));
   }, []);
   var quickReactionEmojiIds = pickerQuickReactionEmojiIds !== null && pickerQuickReactionEmojiIds !== void 0 ? pickerQuickReactionEmojiIds : getDefaultReactions(isTeamojiPickerRefreshEnabled);
-  var shouldRenderHoverableReactionPickerSelectorList = hoverableReactionPickerSelector && isExperimentEnabled('platform_a11y_reactions_hover_selector_list');
 
   /**
    * Render the default emoji icon
@@ -77,11 +75,11 @@ export var Selector = function Selector(_ref2) {
       onClick: onSelection,
       hoverableReactionPickerSelectorEmoji: hoverableReactionPickerSelector
     }));
-    return hoverableReactionPickerSelector ? shouldRenderHoverableReactionPickerSelectorList ? /*#__PURE__*/React.createElement(Box, {
+    return hoverableReactionPickerSelector ? /*#__PURE__*/React.createElement(Box, {
       as: "li",
       key: (_emoji$id2 = emoji.id) !== null && _emoji$id2 !== void 0 ? _emoji$id2 : emoji.shortName,
       xcss: styles.emojiContainer
-    }, emojiButtonAndTooltip) : emojiButtonAndTooltip : /*#__PURE__*/React.createElement(Reveal, {
+    }, emojiButtonAndTooltip) : /*#__PURE__*/React.createElement(Reveal, {
       key: (_emoji$id3 = emoji.id) !== null && _emoji$id3 !== void 0 ? _emoji$id3 : emoji.shortName,
       testId: RENDER_SELECTOR_TESTID
     }, emojiButtonAndTooltip);
@@ -96,9 +94,9 @@ export var Selector = function Selector(_ref2) {
       reactionPickerTriggerText: messages.addNewReaction.defaultMessage,
       fullWidthSelectorTrayReactionPickerTrigger: true
     }), /*#__PURE__*/React.createElement(Inline, {
-      as: shouldRenderHoverableReactionPickerSelectorList ? 'ul' : undefined,
+      as: "ul",
       alignBlock: "center",
-      xcss: shouldRenderHoverableReactionPickerSelectorList ? styles.hoverableReactionPickerSelectorList : styles.hoverableReactionPickerSelectorContainer
+      xcss: styles.hoverableReactionPickerSelectorList
     }, quickReactionEmojiIds.map(renderEmoji)));
   }
   var isSelectorListMarkupFixEnabled = expValEquals('platform_a11y_fixes_reactions_selector_list', 'isEnabled', true);

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@atlaskit/reactions",
-	"version": "36.2.8",
+	"version": "36.2.10",
 	"description": "Reactions component",
 	"publishConfig": {
 		"registry": "https://registry.npmjs.org/"
@@ -55,7 +55,7 @@
 		"@atlaskit/spinner": "^20.4.0",
 		"@atlaskit/tabs": "^21.2.0",
 		"@atlaskit/theme": "^28.2.0",
-		"@atlaskit/tmp-editor-statsig": "^178.0.0",
+		"@atlaskit/tmp-editor-statsig": "^179.0.0",
 		"@atlaskit/tokens": "^16.11.0",
 		"@atlaskit/tooltip": "^24.3.0",
 		"@atlaskit/ufo": "^1.2.0",
@@ -141,12 +141,6 @@
 			"type": "boolean"
 		}
 	},
-	"platform-experiments": {
-		"platform_a11y_reactions_hover_selector_list": {
-			"param": "isEnabled",
-			"defaultValue": false
-		}
-	},
 	"sideEffects": [
 		"*.compiled.css"
 	]