@atlaskit/reactions 33.8.12 → 33.8.14

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
package/CHANGELOG.md CHANGED
@@ -1,5 +1,18 @@
1
1
  # @atlaskit/reactions
2
2
 
3
+ ## 33.8.14
4
+
5
+ ### Patch Changes
6
+
7
+ - [`21867379c6c52`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/21867379c6c52) -
8
+ [ux] A11y changes
9
+
10
+ ## 33.8.13
11
+
12
+ ### Patch Changes
13
+
14
+ - Updated dependencies
15
+
3
16
  ## 33.8.12
4
17
 
5
18
  ### Patch Changes
@@ -11,7 +11,7 @@ var _analyticsGasTypes = require("@atlaskit/analytics-gas-types");
11
11
  function ownKeys(e, r) { var t = Object.keys(e); if (Object.getOwnPropertySymbols) { var o = Object.getOwnPropertySymbols(e); r && (o = o.filter(function (r) { return Object.getOwnPropertyDescriptor(e, r).enumerable; })), t.push.apply(t, o); } return t; }
12
12
  function _objectSpread(e) { for (var r = 1; r < arguments.length; r++) { var t = null != arguments[r] ? arguments[r] : {}; r % 2 ? ownKeys(Object(t), !0).forEach(function (r) { (0, _defineProperty2.default)(e, r, t[r]); }) : Object.getOwnPropertyDescriptors ? Object.defineProperties(e, Object.getOwnPropertyDescriptors(t)) : ownKeys(Object(t)).forEach(function (r) { Object.defineProperty(e, r, Object.getOwnPropertyDescriptor(t, r)); }); } return e; }
13
13
  var packageName = "@atlaskit/reactions";
14
- var packageVersion = "0.0.0-development";
14
+ var packageVersion = "33.8.13";
15
15
  /**
16
16
  * TODO: move to utility package?
17
17
  * A random sampling function
@@ -19,6 +19,7 @@ var _analyticsNext = require("@atlaskit/analytics-next");
19
19
  var _modalDialog = require("@atlaskit/modal-dialog");
20
20
  var _segment = _interopRequireDefault(require("@atlaskit/react-ufo/segment"));
21
21
  var _platformFeatureFlags = require("@atlaskit/platform-feature-flags");
22
+ var _compiled = require("@atlaskit/primitives/compiled");
22
23
  var _analytics = require("../analytics");
23
24
  var _constants = require("../shared/constants");
24
25
  var _i18n = require("../shared/i18n");
@@ -34,6 +35,9 @@ var noFlexWrapStyles = null;
34
35
  var noContainerPositionStyles = null;
35
36
  var reactionPickerStyle = null;
36
37
  var listContainerStyles = null;
38
+ var pickerListItemStyles = {
39
+ picker: "_1e0c1o8l _19pk1b66"
40
+ };
37
41
 
38
42
  /**
39
43
  * Set of all available UFO experiences relating to Reactions Dialog
@@ -302,6 +306,10 @@ var Reactions = exports.Reactions = /*#__PURE__*/_react.default.memo(function (_
302
306
  var hasEmojiWithFivePlusReactions = reactions.some(function (reaction) {
303
307
  return reaction.count >= 5;
304
308
  });
309
+ var shouldShowPicker = !isViewOnly && !(!onlyRenderPicker && shouldShowSummaryView && allowSelectFromSummaryView);
310
+ var semanticListEnabled = (0, _platformFeatureFlags.fg)('jfp_a11y_team_comment_actions_semantic');
311
+ var addReactionButtonAsListItem = (0, _platformFeatureFlags.fg)('platform-a11y-add-reactions-button-ul-item');
312
+ var pickerInsideList = semanticListEnabled && addReactionButtonAsListItem && shouldShowPicker;
305
313
  var sortedReactions = (0, _react.useMemo)(function () {
306
314
  return (0, _toConsumableArray2.default)(memorizedReactions).sort(function (a, b) {
307
315
  return (b === null || b === void 0 ? void 0 : b.count) - (a === null || a === void 0 ? void 0 : a.count);
@@ -389,7 +397,32 @@ var Reactions = exports.Reactions = /*#__PURE__*/_react.default.memo(function (_
389
397
  isViewOnly: isViewOnly,
390
398
  showSubtleStyle: showSubtleDefaultReactions && reactions.length === 0
391
399
  });
392
- })) : /*#__PURE__*/_react.default.createElement(_react.default.Fragment, null, memorizedReactions.map(function (reaction) {
400
+ }), pickerInsideList && /*#__PURE__*/_react.default.createElement(_compiled.Box, {
401
+ as: "li",
402
+ xcss: pickerListItemStyles.picker
403
+ }, /*#__PURE__*/_react.default.createElement(_ReactionPicker.ReactionPicker, {
404
+ emojiProvider: emojiProvider,
405
+ allowAllEmojis: allowAllEmojis,
406
+ pickerQuickReactionEmojiIds: pickerQuickReactionEmojiIds,
407
+ disabled: status !== _types.ReactionStatus.ready,
408
+ onSelection: handleOnSelection,
409
+ onOpen: handlePickerOpen,
410
+ onCancel: handleOnCancel,
411
+ onShowMore: handleOnMore,
412
+ tooltipContent: hoverableSummaryView ? null : getTooltip(status, errorMessage, reactionPickerTriggerTooltipContent),
413
+ emojiPickerSize: emojiPickerSize,
414
+ miniMode: miniMode,
415
+ showOpaqueBackground: showOpaqueBackground,
416
+ showAddReactionText: showAddReactionText,
417
+ subtleReactionsSummaryAndPicker: subtleReactionsSummaryAndPicker,
418
+ reactionPickerTriggerIcon: reactionPickerTriggerIcon,
419
+ reactionPickerTriggerText: reactionPickerTriggerText,
420
+ isListItem: isListItem,
421
+ hoverableReactionPicker: hoverableSummaryView,
422
+ hoverableReactionPickerDelay: hoverableSummaryView ? 300 : 0,
423
+ reactionPickerPlacement: reactionPickerPlacement,
424
+ reactionPickerPopperZIndex: reactionPickerPopperZIndex
425
+ }))) : /*#__PURE__*/_react.default.createElement(_react.default.Fragment, null, memorizedReactions.map(function (reaction) {
393
426
  return /*#__PURE__*/_react.default.createElement(_Reaction.Reaction, {
394
427
  key: reaction.emojiId,
395
428
  reaction: reaction,
@@ -405,7 +438,7 @@ var Reactions = exports.Reactions = /*#__PURE__*/_react.default.memo(function (_
405
438
  isViewOnly: isViewOnly,
406
439
  showSubtleStyle: showSubtleDefaultReactions && reactions.length === 0
407
440
  });
408
- }))), isViewOnly || !onlyRenderPicker && shouldShowSummaryView && allowSelectFromSummaryView ? null : /*#__PURE__*/_react.default.createElement(_ReactionPicker.ReactionPicker, {
441
+ }))), shouldShowPicker && !pickerInsideList && /*#__PURE__*/_react.default.createElement(_ReactionPicker.ReactionPicker, {
409
442
  emojiProvider: emojiProvider,
410
443
  allowAllEmojis: allowAllEmojis,
411
444
  pickerQuickReactionEmojiIds: pickerQuickReactionEmojiIds,
@@ -1,7 +1,7 @@
1
1
  import { createAndFireEvent } from '@atlaskit/analytics-next';
2
2
  import { UI_EVENT_TYPE, OPERATIONAL_EVENT_TYPE } from '@atlaskit/analytics-gas-types';
3
3
  const packageName = "@atlaskit/reactions";
4
- const packageVersion = "0.0.0-development";
4
+ const packageVersion = "33.8.13";
5
5
  /**
6
6
  * TODO: move to utility package?
7
7
  * A random sampling function
@@ -7,6 +7,7 @@ import { useAnalyticsEvents } from '@atlaskit/analytics-next';
7
7
  import { ModalTransition } from '@atlaskit/modal-dialog';
8
8
  import UFOSegment from '@atlaskit/react-ufo/segment';
9
9
  import { fg } from '@atlaskit/platform-feature-flags';
10
+ import { Box } from '@atlaskit/primitives/compiled';
10
11
  import { createAndFireSafe, createPickerButtonClickedEvent, createPickerCancelledEvent, createPickerMoreClickedEvent, createReactionsRenderedEvent, createReactionSelectionEvent, isSampled } from '../analytics';
11
12
  import { SAMPLING_RATE_REACTIONS_RENDERED_EXP } from '../shared/constants';
12
13
  import { messages } from '../shared/i18n';
@@ -21,6 +22,9 @@ const noFlexWrapStyles = null;
21
22
  const noContainerPositionStyles = null;
22
23
  const reactionPickerStyle = null;
23
24
  const listContainerStyles = null;
25
+ const pickerListItemStyles = {
26
+ picker: "_1e0c1o8l _19pk1b66"
27
+ };
24
28
 
25
29
  /**
26
30
  * Set of all available UFO experiences relating to Reactions Dialog
@@ -252,6 +256,10 @@ export const Reactions = /*#__PURE__*/React.memo(({
252
256
 
253
257
  // criteria to show Reactions Dialog
254
258
  const hasEmojiWithFivePlusReactions = reactions.some(reaction => reaction.count >= 5);
259
+ const shouldShowPicker = !isViewOnly && !(!onlyRenderPicker && shouldShowSummaryView && allowSelectFromSummaryView);
260
+ const semanticListEnabled = fg('jfp_a11y_team_comment_actions_semantic');
261
+ const addReactionButtonAsListItem = fg('platform-a11y-add-reactions-button-ul-item');
262
+ const pickerInsideList = semanticListEnabled && addReactionButtonAsListItem && shouldShowPicker;
255
263
  const sortedReactions = useMemo(() => {
256
264
  return [...memorizedReactions].sort((a, b) => (b === null || b === void 0 ? void 0 : b.count) - (a === null || a === void 0 ? void 0 : a.count));
257
265
  }, [memorizedReactions]);
@@ -331,6 +339,31 @@ export const Reactions = /*#__PURE__*/React.memo(({
331
339
  handleOpenReactionsDialog: handleOpenReactionsDialog,
332
340
  isViewOnly: isViewOnly,
333
341
  showSubtleStyle: showSubtleDefaultReactions && reactions.length === 0
342
+ })), pickerInsideList && /*#__PURE__*/React.createElement(Box, {
343
+ as: "li",
344
+ xcss: pickerListItemStyles.picker
345
+ }, /*#__PURE__*/React.createElement(ReactionPicker, {
346
+ emojiProvider: emojiProvider,
347
+ allowAllEmojis: allowAllEmojis,
348
+ pickerQuickReactionEmojiIds: pickerQuickReactionEmojiIds,
349
+ disabled: status !== ReactionStatus.ready,
350
+ onSelection: handleOnSelection,
351
+ onOpen: handlePickerOpen,
352
+ onCancel: handleOnCancel,
353
+ onShowMore: handleOnMore,
354
+ tooltipContent: hoverableSummaryView ? null : getTooltip(status, errorMessage, reactionPickerTriggerTooltipContent),
355
+ emojiPickerSize: emojiPickerSize,
356
+ miniMode: miniMode,
357
+ showOpaqueBackground: showOpaqueBackground,
358
+ showAddReactionText: showAddReactionText,
359
+ subtleReactionsSummaryAndPicker: subtleReactionsSummaryAndPicker,
360
+ reactionPickerTriggerIcon: reactionPickerTriggerIcon,
361
+ reactionPickerTriggerText: reactionPickerTriggerText,
362
+ isListItem: isListItem,
363
+ hoverableReactionPicker: hoverableSummaryView,
364
+ hoverableReactionPickerDelay: hoverableSummaryView ? 300 : 0,
365
+ reactionPickerPlacement: reactionPickerPlacement,
366
+ reactionPickerPopperZIndex: reactionPickerPopperZIndex
334
367
  }))) : /*#__PURE__*/React.createElement(React.Fragment, null, memorizedReactions.map(reaction => /*#__PURE__*/React.createElement(Reaction, {
335
368
  key: reaction.emojiId,
336
369
  reaction: reaction,
@@ -345,7 +378,7 @@ export const Reactions = /*#__PURE__*/React.memo(({
345
378
  handleOpenReactionsDialog: handleOpenReactionsDialog,
346
379
  isViewOnly: isViewOnly,
347
380
  showSubtleStyle: showSubtleDefaultReactions && reactions.length === 0
348
- })))), isViewOnly || !onlyRenderPicker && shouldShowSummaryView && allowSelectFromSummaryView ? null : /*#__PURE__*/React.createElement(ReactionPicker, {
381
+ })))), shouldShowPicker && !pickerInsideList && /*#__PURE__*/React.createElement(ReactionPicker, {
349
382
  emojiProvider: emojiProvider,
350
383
  allowAllEmojis: allowAllEmojis,
351
384
  pickerQuickReactionEmojiIds: pickerQuickReactionEmojiIds,
@@ -4,7 +4,7 @@ function _objectSpread(e) { for (var r = 1; r < arguments.length; r++) { var t =
4
4
  import { createAndFireEvent } from '@atlaskit/analytics-next';
5
5
  import { UI_EVENT_TYPE, OPERATIONAL_EVENT_TYPE } from '@atlaskit/analytics-gas-types';
6
6
  var packageName = "@atlaskit/reactions";
7
- var packageVersion = "0.0.0-development";
7
+ var packageVersion = "33.8.13";
8
8
  /**
9
9
  * TODO: move to utility package?
10
10
  * A random sampling function
@@ -9,6 +9,7 @@ import { useAnalyticsEvents } from '@atlaskit/analytics-next';
9
9
  import { ModalTransition } from '@atlaskit/modal-dialog';
10
10
  import UFOSegment from '@atlaskit/react-ufo/segment';
11
11
  import { fg } from '@atlaskit/platform-feature-flags';
12
+ import { Box } from '@atlaskit/primitives/compiled';
12
13
  import { createAndFireSafe, createPickerButtonClickedEvent, createPickerCancelledEvent, createPickerMoreClickedEvent, createReactionsRenderedEvent, createReactionSelectionEvent, isSampled } from '../analytics';
13
14
  import { SAMPLING_RATE_REACTIONS_RENDERED_EXP } from '../shared/constants';
14
15
  import { messages } from '../shared/i18n';
@@ -23,6 +24,9 @@ var noFlexWrapStyles = null;
23
24
  var noContainerPositionStyles = null;
24
25
  var reactionPickerStyle = null;
25
26
  var listContainerStyles = null;
27
+ var pickerListItemStyles = {
28
+ picker: "_1e0c1o8l _19pk1b66"
29
+ };
26
30
 
27
31
  /**
28
32
  * Set of all available UFO experiences relating to Reactions Dialog
@@ -291,6 +295,10 @@ export var Reactions = /*#__PURE__*/React.memo(function (_ref) {
291
295
  var hasEmojiWithFivePlusReactions = reactions.some(function (reaction) {
292
296
  return reaction.count >= 5;
293
297
  });
298
+ var shouldShowPicker = !isViewOnly && !(!onlyRenderPicker && shouldShowSummaryView && allowSelectFromSummaryView);
299
+ var semanticListEnabled = fg('jfp_a11y_team_comment_actions_semantic');
300
+ var addReactionButtonAsListItem = fg('platform-a11y-add-reactions-button-ul-item');
301
+ var pickerInsideList = semanticListEnabled && addReactionButtonAsListItem && shouldShowPicker;
294
302
  var sortedReactions = useMemo(function () {
295
303
  return _toConsumableArray(memorizedReactions).sort(function (a, b) {
296
304
  return (b === null || b === void 0 ? void 0 : b.count) - (a === null || a === void 0 ? void 0 : a.count);
@@ -378,7 +386,32 @@ export var Reactions = /*#__PURE__*/React.memo(function (_ref) {
378
386
  isViewOnly: isViewOnly,
379
387
  showSubtleStyle: showSubtleDefaultReactions && reactions.length === 0
380
388
  });
381
- })) : /*#__PURE__*/React.createElement(React.Fragment, null, memorizedReactions.map(function (reaction) {
389
+ }), pickerInsideList && /*#__PURE__*/React.createElement(Box, {
390
+ as: "li",
391
+ xcss: pickerListItemStyles.picker
392
+ }, /*#__PURE__*/React.createElement(ReactionPicker, {
393
+ emojiProvider: emojiProvider,
394
+ allowAllEmojis: allowAllEmojis,
395
+ pickerQuickReactionEmojiIds: pickerQuickReactionEmojiIds,
396
+ disabled: status !== ReactionStatus.ready,
397
+ onSelection: handleOnSelection,
398
+ onOpen: handlePickerOpen,
399
+ onCancel: handleOnCancel,
400
+ onShowMore: handleOnMore,
401
+ tooltipContent: hoverableSummaryView ? null : getTooltip(status, errorMessage, reactionPickerTriggerTooltipContent),
402
+ emojiPickerSize: emojiPickerSize,
403
+ miniMode: miniMode,
404
+ showOpaqueBackground: showOpaqueBackground,
405
+ showAddReactionText: showAddReactionText,
406
+ subtleReactionsSummaryAndPicker: subtleReactionsSummaryAndPicker,
407
+ reactionPickerTriggerIcon: reactionPickerTriggerIcon,
408
+ reactionPickerTriggerText: reactionPickerTriggerText,
409
+ isListItem: isListItem,
410
+ hoverableReactionPicker: hoverableSummaryView,
411
+ hoverableReactionPickerDelay: hoverableSummaryView ? 300 : 0,
412
+ reactionPickerPlacement: reactionPickerPlacement,
413
+ reactionPickerPopperZIndex: reactionPickerPopperZIndex
414
+ }))) : /*#__PURE__*/React.createElement(React.Fragment, null, memorizedReactions.map(function (reaction) {
382
415
  return /*#__PURE__*/React.createElement(Reaction, {
383
416
  key: reaction.emojiId,
384
417
  reaction: reaction,
@@ -394,7 +427,7 @@ export var Reactions = /*#__PURE__*/React.memo(function (_ref) {
394
427
  isViewOnly: isViewOnly,
395
428
  showSubtleStyle: showSubtleDefaultReactions && reactions.length === 0
396
429
  });
397
- }))), isViewOnly || !onlyRenderPicker && shouldShowSummaryView && allowSelectFromSummaryView ? null : /*#__PURE__*/React.createElement(ReactionPicker, {
430
+ }))), shouldShowPicker && !pickerInsideList && /*#__PURE__*/React.createElement(ReactionPicker, {
398
431
  emojiProvider: emojiProvider,
399
432
  allowAllEmojis: allowAllEmojis,
400
433
  pickerQuickReactionEmojiIds: pickerQuickReactionEmojiIds,
@@ -35,7 +35,7 @@ export declare const mapStateToPropsHelper: (containerAri: string, ari: string,
35
35
  flash?: undefined;
36
36
  particleEffectByEmoji?: undefined;
37
37
  } | {
38
- reactions: import("../../types").ReactionSummary[];
38
+ reactions: import("../..").ReactionSummary[];
39
39
  status: ReactionStatus.ready;
40
40
  flash: {
41
41
  [emojiId: string]: boolean;
@@ -35,7 +35,7 @@ export declare const mapStateToPropsHelper: (containerAri: string, ari: string,
35
35
  flash?: undefined;
36
36
  particleEffectByEmoji?: undefined;
37
37
  } | {
38
- reactions: import("../../types").ReactionSummary[];
38
+ reactions: import("../..").ReactionSummary[];
39
39
  status: ReactionStatus.ready;
40
40
  flash: {
41
41
  [emojiId: string]: boolean;
package/package.json CHANGED
@@ -1,6 +1,6 @@
1
1
  {
2
2
  "name": "@atlaskit/reactions",
3
- "version": "33.8.12",
3
+ "version": "33.8.14",
4
4
  "description": "Reactions component",
5
5
  "publishConfig": {
6
6
  "registry": "https://registry.npmjs.org/"
@@ -39,8 +39,8 @@
39
39
  "@atlaskit/button": "^23.9.0",
40
40
  "@atlaskit/css": "^0.19.0",
41
41
  "@atlaskit/emoji": "^69.10.0",
42
- "@atlaskit/heading": "^5.2.0",
43
- "@atlaskit/icon": "^30.0.0",
42
+ "@atlaskit/heading": "^5.3.0",
43
+ "@atlaskit/icon": "^31.0.0",
44
44
  "@atlaskit/link": "^3.3.0",
45
45
  "@atlaskit/modal-dialog": "^14.10.0",
46
46
  "@atlaskit/motion": "^5.3.0",
@@ -49,7 +49,7 @@
49
49
  "@atlaskit/popup": "^4.13.0",
50
50
  "@atlaskit/portal": "^5.2.0",
51
51
  "@atlaskit/primitives": "^18.0.0",
52
- "@atlaskit/react-ufo": "^5.0.0",
52
+ "@atlaskit/react-ufo": "^5.2.0",
53
53
  "@atlaskit/spinner": "^19.0.0",
54
54
  "@atlaskit/tabs": "^18.3.0",
55
55
  "@atlaskit/theme": "^21.0.0",
@@ -71,7 +71,7 @@
71
71
  "@atlaskit/editor-test-helpers": "workspace:^",
72
72
  "@atlaskit/elements-test-helpers": "workspace:^",
73
73
  "@atlaskit/util-data-test": "^18.5.0",
74
- "@atlassian/a11y-jest-testing": "^0.8.0",
74
+ "@atlassian/a11y-jest-testing": "^0.10.0",
75
75
  "@atlassian/feature-flags-test-utils": "^1.0.0",
76
76
  "@testing-library/dom": "^10.1.0",
77
77
  "@testing-library/jest-dom": "^6.4.5",
@@ -128,6 +128,9 @@
128
128
  },
129
129
  "jfp_a11y_team_comment_actions_semantic": {
130
130
  "type": "boolean"
131
+ },
132
+ "platform-a11y-add-reactions-button-ul-item": {
133
+ "type": "boolean"
131
134
  }
132
135
  },
133
136
  "sideEffects": [
package/tsconfig.json CHANGED
@@ -13,6 +13,5 @@
13
13
  "**/stories/*.tsx",
14
14
  "**/stories/**/*.ts",
15
15
  "**/stories/**/*.tsx"
16
- ],
17
- "compilerOptions": {}
16
+ ]
18
17
  }