@atlaskit/react-ufo 4.7.4 → 4.7.5

package/CHANGELOG.md

@@ -1,5 +1,12 @@
 # @atlaskit/ufo-interaction-ignore
 
+## 4.7.5
+
+### Patch Changes
+
+- [`1a2a53c0d8141`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/1a2a53c0d8141) -
+  Ignore style mutations from adding drag and drop anchor names
+
 ## 4.7.4
 
 ### Patch Changes

package/dist/cjs/vc/vc-observer/observers/non-visual-styles/is-dnd-style-mutation.js

@@ -0,0 +1,115 @@
+"use strict";
+
+var _interopRequireDefault = require("@babel/runtime/helpers/interopRequireDefault");
+Object.defineProperty(exports, "__esModule", {
+  value: true
+});
+exports.default = void 0;
+var _featureGateJsClient = _interopRequireDefault(require("@atlaskit/feature-gate-js-client"));
+var _platformFeatureFlags = require("@atlaskit/platform-feature-flags");
+var _featureFlagsAccessed = require("../../../../feature-flags-accessed");
+function _createForOfIteratorHelper(r, e) { var t = "undefined" != typeof Symbol && r[Symbol.iterator] || r["@@iterator"]; if (!t) { if (Array.isArray(r) || (t = _unsupportedIterableToArray(r)) || e && r && "number" == typeof r.length) { t && (r = t); var _n = 0, F = function F() {}; return { s: F, n: function n() { return _n >= r.length ? { done: !0 } : { done: !1, value: r[_n++] }; }, e: function e(r) { throw r; }, f: F }; } throw new TypeError("Invalid attempt to iterate non-iterable instance.\nIn order to be iterable, non-array objects must have a [Symbol.iterator]() method."); } var o, a = !0, u = !1; return { s: function s() { t = t.call(r); }, n: function n() { var r = t.next(); return a = r.done, r; }, e: function e(r) { u = !0, o = r; }, f: function f() { try { a || null == t.return || t.return(); } finally { if (u) throw o; } } }; }
+function _unsupportedIterableToArray(r, a) { if (r) { if ("string" == typeof r) return _arrayLikeToArray(r, a); var t = {}.toString.call(r).slice(8, -1); return "Object" === t && r.constructor && (t = r.constructor.name), "Map" === t || "Set" === t ? Array.from(r) : "Arguments" === t || /^(?:Ui|I)nt(?:8|16|32)(?:Clamped)?Array$/.test(t) ? _arrayLikeToArray(r, a) : void 0; } }
+function _arrayLikeToArray(r, a) { (null == a || a > r.length) && (a = r.length); for (var e = 0, n = Array(a); e < a; e++) n[e] = r[e]; return n; }
+// copied from '@atlaskit/tmp-editor-statsig/expVal' to avoid circular dependency
+var expVal = function expVal(experimentName, experimentParam, defaultValue) {
+  // If client is not initialized, we return the default value
+  if (!_featureGateJsClient.default.initializeCompleted()) {
+    return defaultValue;
+  }
+
+  // eslint-disable-next-line @atlaskit/platform/use-recommended-utils
+  var experimentValue = _featureGateJsClient.default.getExperimentValue(experimentName, experimentParam, defaultValue);
+  (0, _featureFlagsAccessed.addFeatureFlagAccessed)("".concat(experimentName, ":").concat(experimentParam), experimentValue);
+  return experimentValue;
+};
+var isDnDStyleChange = function isDnDStyleChange(style) {
+  return style.startsWith('anchor-name: --node-anchor');
+};
+var parseStyleSet = function parseStyleSet(style) {
+  if (!style) {
+    return null;
+  }
+  var set = new Set();
+  var _iterator = _createForOfIteratorHelper(style.split(';')),
+    _step;
+  try {
+    for (_iterator.s(); !(_step = _iterator.n()).done;) {
+      var part = _step.value;
+      var t = part.trim();
+      if (t) {
+        set.add(t);
+      }
+    }
+  } catch (err) {
+    _iterator.e(err);
+  } finally {
+    _iterator.f();
+  }
+  return set;
+};
+
+/**
+ * Checks if a mutation record represents a style change from Editor's
+ * drag and drop feature, which don't cause visual shifts.
+ * This should be removed once DnD has been fixed.
+ * @param mutation - The mutation record to check
+ * @returns boolean indicating if this is a DnD style mutation
+ */
+function isDnDStyleMutation(_ref) {
+  var target = _ref.target,
+    attributeName = _ref.attributeName,
+    oldValue = _ref.oldValue,
+    newValue = _ref.newValue;
+  if (!(0, _platformFeatureFlags.fg)('platform_editor_exclude_dnd_anchor_name_from_ttvc')) {
+    return false;
+  }
+  if (!expVal('platform_editor_tables_scaling_css', 'excludeDnD', false)) {
+    return false;
+  }
+  if (!(target instanceof Element)) {
+    return false;
+  }
+  if (attributeName !== 'style') {
+    return false;
+  }
+  var oldStyles = parseStyleSet(oldValue);
+  var newStyles = parseStyleSet(newValue);
+  var isDnDMutation = false;
+  var _iterator2 = _createForOfIteratorHelper(oldStyles !== null && oldStyles !== void 0 ? oldStyles : []),
+    _step2;
+  try {
+    for (_iterator2.s(); !(_step2 = _iterator2.n()).done;) {
+      var s = _step2.value;
+      if (!(newStyles !== null && newStyles !== void 0 && newStyles.has(s))) {
+        if (!isDnDStyleChange(s)) {
+          return false;
+        }
+        isDnDMutation = true;
+      }
+    }
+  } catch (err) {
+    _iterator2.e(err);
+  } finally {
+    _iterator2.f();
+  }
+  var _iterator3 = _createForOfIteratorHelper(newStyles !== null && newStyles !== void 0 ? newStyles : []),
+    _step3;
+  try {
+    for (_iterator3.s(); !(_step3 = _iterator3.n()).done;) {
+      var _s = _step3.value;
+      if (!(oldStyles !== null && oldStyles !== void 0 && oldStyles.has(_s))) {
+        if (!isDnDStyleChange(_s)) {
+          return false;
+        }
+        isDnDMutation = true;
+      }
+    }
+  } catch (err) {
+    _iterator3.e(err);
+  } finally {
+    _iterator3.f();
+  }
+  return isDnDMutation;
+}
+var _default = exports.default = isDnDStyleMutation;

package/dist/cjs/vc/vc-observer-new/viewport-observer/index.js

@@ -13,6 +13,7 @@ var _createClass2 = _interopRequireDefault(require("@babel/runtime/helpers/creat
 var _defineProperty2 = _interopRequireDefault(require("@babel/runtime/helpers/defineProperty"));
 var _platformFeatureFlags = require("@atlaskit/platform-feature-flags");
 var _vcUtils = require("../../vc-observer/media-wrapper/vc-utils");
+var _isDndStyleMutation = _interopRequireDefault(require("../../vc-observer/observers/non-visual-styles/is-dnd-style-mutation"));
 var _isNonVisualStyleMutation = _interopRequireDefault(require("../../vc-observer/observers/non-visual-styles/is-non-visual-style-mutation"));
 var _rllPlaceholders = require("../../vc-observer/observers/rll-placeholders");
 var _intersectionObserver = require("./intersection-observer");
@@ -320,6 +321,21 @@ var ViewportObserver = exports.default = /*#__PURE__*/function () {
             }
           };
         }
+        if ((0, _isDndStyleMutation.default)({
+          target: target,
+          attributeName: attributeName,
+          oldValue: oldValue,
+          newValue: newValue
+        })) {
+          return {
+            type: 'mutation:attribute:non-visual-style',
+            mutationData: {
+              attributeName: attributeName,
+              oldValue: oldValue,
+              newValue: newValue
+            }
+          };
+        }
         if ((0, _isNonVisualStyleMutation.default)({
           target: target,
           attributeName: attributeName,

package/dist/es2019/vc/vc-observer/observers/non-visual-styles/is-dnd-style-mutation.js

@@ -0,0 +1,80 @@
+import FeatureGates from '@atlaskit/feature-gate-js-client';
+import { fg } from '@atlaskit/platform-feature-flags';
+import { addFeatureFlagAccessed } from '../../../../feature-flags-accessed';
+
+// copied from '@atlaskit/tmp-editor-statsig/expVal' to avoid circular dependency
+const expVal = (experimentName, experimentParam, defaultValue) => {
+  // If client is not initialized, we return the default value
+  if (!FeatureGates.initializeCompleted()) {
+    return defaultValue;
+  }
+
+  // eslint-disable-next-line @atlaskit/platform/use-recommended-utils
+  const experimentValue = FeatureGates.getExperimentValue(experimentName, experimentParam, defaultValue);
+  addFeatureFlagAccessed(`${experimentName}:${experimentParam}`, experimentValue);
+  return experimentValue;
+};
+const isDnDStyleChange = style => {
+  return style.startsWith('anchor-name: --node-anchor');
+};
+const parseStyleSet = style => {
+  if (!style) {
+    return null;
+  }
+  const set = new Set();
+  for (const part of style.split(';')) {
+    const t = part.trim();
+    if (t) {
+      set.add(t);
+    }
+  }
+  return set;
+};
+
+/**
+ * Checks if a mutation record represents a style change from Editor's
+ * drag and drop feature, which don't cause visual shifts.
+ * This should be removed once DnD has been fixed.
+ * @param mutation - The mutation record to check
+ * @returns boolean indicating if this is a DnD style mutation
+ */
+function isDnDStyleMutation({
+  target,
+  attributeName,
+  oldValue,
+  newValue
+}) {
+  if (!fg('platform_editor_exclude_dnd_anchor_name_from_ttvc')) {
+    return false;
+  }
+  if (!expVal('platform_editor_tables_scaling_css', 'excludeDnD', false)) {
+    return false;
+  }
+  if (!(target instanceof Element)) {
+    return false;
+  }
+  if (attributeName !== 'style') {
+    return false;
+  }
+  const oldStyles = parseStyleSet(oldValue);
+  const newStyles = parseStyleSet(newValue);
+  let isDnDMutation = false;
+  for (const s of oldStyles !== null && oldStyles !== void 0 ? oldStyles : []) {
+    if (!(newStyles !== null && newStyles !== void 0 && newStyles.has(s))) {
+      if (!isDnDStyleChange(s)) {
+        return false;
+      }
+      isDnDMutation = true;
+    }
+  }
+  for (const s of newStyles !== null && newStyles !== void 0 ? newStyles : []) {
+    if (!(oldStyles !== null && oldStyles !== void 0 && oldStyles.has(s))) {
+      if (!isDnDStyleChange(s)) {
+        return false;
+      }
+      isDnDMutation = true;
+    }
+  }
+  return isDnDMutation;
+}
+export default isDnDStyleMutation;

package/dist/es2019/vc/vc-observer-new/viewport-observer/index.js

@@ -1,6 +1,7 @@
 import _defineProperty from "@babel/runtime/helpers/defineProperty";
 import { fg } from '@atlaskit/platform-feature-flags';
 import { isContainedWithinMediaWrapper } from '../../vc-observer/media-wrapper/vc-utils';
+import isDnDStyleMutation from '../../vc-observer/observers/non-visual-styles/is-dnd-style-mutation';
 import isNonVisualStyleMutation from '../../vc-observer/observers/non-visual-styles/is-non-visual-style-mutation';
 import { RLLPlaceholderHandlers } from '../../vc-observer/observers/rll-placeholders';
 import { createIntersectionObserver } from './intersection-observer';
@@ -223,6 +224,21 @@ export default class ViewportObserver {
             }
           };
         }
+        if (isDnDStyleMutation({
+          target,
+          attributeName,
+          oldValue,
+          newValue
+        })) {
+          return {
+            type: 'mutation:attribute:non-visual-style',
+            mutationData: {
+              attributeName,
+              oldValue,
+              newValue
+            }
+          };
+        }
         if (isNonVisualStyleMutation({
           target,
           attributeName,

package/dist/esm/vc/vc-observer/observers/non-visual-styles/is-dnd-style-mutation.js

@@ -0,0 +1,109 @@
+function _createForOfIteratorHelper(r, e) { var t = "undefined" != typeof Symbol && r[Symbol.iterator] || r["@@iterator"]; if (!t) { if (Array.isArray(r) || (t = _unsupportedIterableToArray(r)) || e && r && "number" == typeof r.length) { t && (r = t); var _n = 0, F = function F() {}; return { s: F, n: function n() { return _n >= r.length ? { done: !0 } : { done: !1, value: r[_n++] }; }, e: function e(r) { throw r; }, f: F }; } throw new TypeError("Invalid attempt to iterate non-iterable instance.\nIn order to be iterable, non-array objects must have a [Symbol.iterator]() method."); } var o, a = !0, u = !1; return { s: function s() { t = t.call(r); }, n: function n() { var r = t.next(); return a = r.done, r; }, e: function e(r) { u = !0, o = r; }, f: function f() { try { a || null == t.return || t.return(); } finally { if (u) throw o; } } }; }
+function _unsupportedIterableToArray(r, a) { if (r) { if ("string" == typeof r) return _arrayLikeToArray(r, a); var t = {}.toString.call(r).slice(8, -1); return "Object" === t && r.constructor && (t = r.constructor.name), "Map" === t || "Set" === t ? Array.from(r) : "Arguments" === t || /^(?:Ui|I)nt(?:8|16|32)(?:Clamped)?Array$/.test(t) ? _arrayLikeToArray(r, a) : void 0; } }
+function _arrayLikeToArray(r, a) { (null == a || a > r.length) && (a = r.length); for (var e = 0, n = Array(a); e < a; e++) n[e] = r[e]; return n; }
+import FeatureGates from '@atlaskit/feature-gate-js-client';
+import { fg } from '@atlaskit/platform-feature-flags';
+import { addFeatureFlagAccessed } from '../../../../feature-flags-accessed';
+
+// copied from '@atlaskit/tmp-editor-statsig/expVal' to avoid circular dependency
+var expVal = function expVal(experimentName, experimentParam, defaultValue) {
+  // If client is not initialized, we return the default value
+  if (!FeatureGates.initializeCompleted()) {
+    return defaultValue;
+  }
+
+  // eslint-disable-next-line @atlaskit/platform/use-recommended-utils
+  var experimentValue = FeatureGates.getExperimentValue(experimentName, experimentParam, defaultValue);
+  addFeatureFlagAccessed("".concat(experimentName, ":").concat(experimentParam), experimentValue);
+  return experimentValue;
+};
+var isDnDStyleChange = function isDnDStyleChange(style) {
+  return style.startsWith('anchor-name: --node-anchor');
+};
+var parseStyleSet = function parseStyleSet(style) {
+  if (!style) {
+    return null;
+  }
+  var set = new Set();
+  var _iterator = _createForOfIteratorHelper(style.split(';')),
+    _step;
+  try {
+    for (_iterator.s(); !(_step = _iterator.n()).done;) {
+      var part = _step.value;
+      var t = part.trim();
+      if (t) {
+        set.add(t);
+      }
+    }
+  } catch (err) {
+    _iterator.e(err);
+  } finally {
+    _iterator.f();
+  }
+  return set;
+};
+
+/**
+ * Checks if a mutation record represents a style change from Editor's
+ * drag and drop feature, which don't cause visual shifts.
+ * This should be removed once DnD has been fixed.
+ * @param mutation - The mutation record to check
+ * @returns boolean indicating if this is a DnD style mutation
+ */
+function isDnDStyleMutation(_ref) {
+  var target = _ref.target,
+    attributeName = _ref.attributeName,
+    oldValue = _ref.oldValue,
+    newValue = _ref.newValue;
+  if (!fg('platform_editor_exclude_dnd_anchor_name_from_ttvc')) {
+    return false;
+  }
+  if (!expVal('platform_editor_tables_scaling_css', 'excludeDnD', false)) {
+    return false;
+  }
+  if (!(target instanceof Element)) {
+    return false;
+  }
+  if (attributeName !== 'style') {
+    return false;
+  }
+  var oldStyles = parseStyleSet(oldValue);
+  var newStyles = parseStyleSet(newValue);
+  var isDnDMutation = false;
+  var _iterator2 = _createForOfIteratorHelper(oldStyles !== null && oldStyles !== void 0 ? oldStyles : []),
+    _step2;
+  try {
+    for (_iterator2.s(); !(_step2 = _iterator2.n()).done;) {
+      var s = _step2.value;
+      if (!(newStyles !== null && newStyles !== void 0 && newStyles.has(s))) {
+        if (!isDnDStyleChange(s)) {
+          return false;
+        }
+        isDnDMutation = true;
+      }
+    }
+  } catch (err) {
+    _iterator2.e(err);
+  } finally {
+    _iterator2.f();
+  }
+  var _iterator3 = _createForOfIteratorHelper(newStyles !== null && newStyles !== void 0 ? newStyles : []),
+    _step3;
+  try {
+    for (_iterator3.s(); !(_step3 = _iterator3.n()).done;) {
+      var _s = _step3.value;
+      if (!(oldStyles !== null && oldStyles !== void 0 && oldStyles.has(_s))) {
+        if (!isDnDStyleChange(_s)) {
+          return false;
+        }
+        isDnDMutation = true;
+      }
+    }
+  } catch (err) {
+    _iterator3.e(err);
+  } finally {
+    _iterator3.f();
+  }
+  return isDnDMutation;
+}
+export default isDnDStyleMutation;

package/dist/esm/vc/vc-observer-new/viewport-observer/index.js

@@ -8,6 +8,7 @@ function _unsupportedIterableToArray(r, a) { if (r) { if ("string" == typeof r)
 function _arrayLikeToArray(r, a) { (null == a || a > r.length) && (a = r.length); for (var e = 0, n = Array(a); e < a; e++) n[e] = r[e]; return n; }
 import { fg } from '@atlaskit/platform-feature-flags';
 import { isContainedWithinMediaWrapper } from '../../vc-observer/media-wrapper/vc-utils';
+import isDnDStyleMutation from '../../vc-observer/observers/non-visual-styles/is-dnd-style-mutation';
 import isNonVisualStyleMutation from '../../vc-observer/observers/non-visual-styles/is-non-visual-style-mutation';
 import { RLLPlaceholderHandlers } from '../../vc-observer/observers/rll-placeholders';
 import { createIntersectionObserver } from './intersection-observer';
@@ -311,6 +312,21 @@ var ViewportObserver = /*#__PURE__*/function () {
             }
           };
         }
+        if (isDnDStyleMutation({
+          target: target,
+          attributeName: attributeName,
+          oldValue: oldValue,
+          newValue: newValue
+        })) {
+          return {
+            type: 'mutation:attribute:non-visual-style',
+            mutationData: {
+              attributeName: attributeName,
+              oldValue: oldValue,
+              newValue: newValue
+            }
+          };
+        }
         if (isNonVisualStyleMutation({
           target: target,
           attributeName: attributeName,

package/dist/types/vc/vc-observer/observers/non-visual-styles/is-dnd-style-mutation.d.ts

@@ -0,0 +1,14 @@
+/**
+ * Checks if a mutation record represents a style change from Editor's
+ * drag and drop feature, which don't cause visual shifts.
+ * This should be removed once DnD has been fixed.
+ * @param mutation - The mutation record to check
+ * @returns boolean indicating if this is a DnD style mutation
+ */
+declare function isDnDStyleMutation({ target, attributeName, oldValue, newValue, }: {
+    target?: Node | null;
+    attributeName?: string | null;
+    oldValue?: string | undefined | null;
+    newValue?: string | undefined | null;
+}): boolean;
+export default isDnDStyleMutation;

package/dist/types-ts4.5/vc/vc-observer/observers/non-visual-styles/is-dnd-style-mutation.d.ts

@@ -0,0 +1,14 @@
+/**
+ * Checks if a mutation record represents a style change from Editor's
+ * drag and drop feature, which don't cause visual shifts.
+ * This should be removed once DnD has been fixed.
+ * @param mutation - The mutation record to check
+ * @returns boolean indicating if this is a DnD style mutation
+ */
+declare function isDnDStyleMutation({ target, attributeName, oldValue, newValue, }: {
+    target?: Node | null;
+    attributeName?: string | null;
+    oldValue?: string | undefined | null;
+    newValue?: string | undefined | null;
+}): boolean;
+export default isDnDStyleMutation;

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@atlaskit/react-ufo",
-	"version": "4.7.4",
+	"version": "4.7.5",
 	"description": "Parts of React UFO that are publicly available",
 	"author": "Atlassian Pty Ltd",
 	"license": "Apache-2.0",
@@ -27,6 +27,7 @@
 	"atlaskit:src": "src/index.ts",
 	"dependencies": {
 		"@atlaskit/browser-apis": "^0.0.1",
+		"@atlaskit/feature-gate-js-client": "^5.5.0",
 		"@atlaskit/interaction-context": "^3.0.0",
 		"@atlaskit/platform-feature-flags": "^1.1.0",
 		"@babel/runtime": "^7.0.0",
@@ -149,6 +150,9 @@
 		"platform_ufo_enable_late_mutation_label_stacks": {
 			"type": "boolean"
 		},
+		"platform_editor_exclude_dnd_anchor_name_from_ttvc": {
+			"type": "boolean"
+		},
 		"platform_ufo_enable_finish_interaction_transition": {
 			"type": "boolean"
 		}