@atlaskit/react-ufo 4.6.1 → 4.7.0

package/CHANGELOG.md

@@ -1,5 +1,22 @@
 # @atlaskit/ufo-interaction-ignore
 
+## 4.7.0
+
+### Minor Changes
+
+- [`dbde6617644d6`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/dbde6617644d6) -
+  [NO-ISSUE] Exclude contenteditable, data-has-collab-initialised, and translate attributes from VC
+  calculation
+
+## 4.6.2
+
+### Patch Changes
+
+- [`4dd6789885500`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/4dd6789885500) -
+  Fix unhandled hidden timing error
+- [`25fbcd6f57e2f`](https://bitbucket.org/atlassian/atlassian-frontend-monorepo/commits/25fbcd6f57e2f) -
+  clean up fg
+
 ## 4.6.1
 
 ### Patch Changes

package/dist/cjs/hidden-timing/index.js

@@ -64,6 +64,11 @@ function setupHiddenTimingCapture() {
   }
 }
 function getPageVisibilityState(start, end) {
+  // Input validation - return default for invalid inputs
+  if (!Number.isFinite(start) || !Number.isFinite(end)) {
+    return 'visible';
+  }
+
   // Desirable default value is visible
   if (timings.length === 0) {
     return 'visible';
@@ -76,19 +81,18 @@ function getPageVisibilityState(start, end) {
   // currentSize is capped at SIZE.
   for (var i = 0; i < currentSize; i++) {
     var tmpIdx = (insertIndex + i) % currentSize;
-    if (timings[tmpIdx].time <= end) {
+    // Add bounds checking before accessing array element
+    if (timings[tmpIdx] && timings[tmpIdx].time <= end) {
       endIdx = tmpIdx;
       if (timings[tmpIdx].time <= start) {
         startIdx = tmpIdx;
       }
     }
   }
-  if (endIdx - startIdx === 0) {
-    if (timings[startIdx].hidden) {
-      hiddenState = 'hidden';
-    } else {
-      hiddenState = 'visible';
-    }
+
+  // Add bounds checking before accessing timings array
+  if (endIdx - startIdx === 0 && timings[startIdx]) {
+    hiddenState = timings[startIdx].hidden ? 'hidden' : 'visible';
   }
   return hiddenState;
 }

package/dist/cjs/vc/vc-observer-new/metric-calculator/abstract-base-vc-calculator.js

@@ -117,12 +117,9 @@ var AbstractVCCalculatorBase = exports.default = /*#__PURE__*/function () {
         return _regenerator.default.wrap(function _callee$(_context) {
           while (1) switch (_context.prev = _context.next) {
             case 0:
-              percentiles = [25, 50, 75, 80, 85, 90, 95, 98, 99];
-              if ((0, _platformFeatureFlags.fg)('platform_ufo_send_vc_100')) {
-                percentiles.push(100);
-              }
+              percentiles = [25, 50, 75, 80, 85, 90, 95, 98, 99, 100];
               viewportEntries = this.filterViewportEntries(filteredEntries);
-              _context.next = 5;
+              _context.next = 4;
               return (0, _percentileCalc.calculateTTVCPercentilesWithDebugInfo)({
                 viewport: {
                   width: (0, _getViewportWidth.default)(),
@@ -132,31 +129,31 @@ var AbstractVCCalculatorBase = exports.default = /*#__PURE__*/function () {
                 stopTime: stopTime,
                 orderedEntries: viewportEntries
               });
-            case 5:
+            case 4:
               vcLogs = _context.sent;
               vcDetails = {};
               percentileIndex = 0;
               entryDataBuffer = new Set();
               if (!vcLogs) {
-                _context.next = 29;
+                _context.next = 28;
                 break;
               }
               _iterator4 = _createForOfIteratorHelper(vcLogs);
-              _context.prev = 11;
+              _context.prev = 10;
               _iterator4.s();
-            case 13:
+            case 12:
               if ((_step4 = _iterator4.n()).done) {
-                _context.next = 21;
+                _context.next = 20;
                 break;
               }
               _entry3 = _step4.value;
               time = _entry3.time, viewportPercentage = _entry3.viewportPercentage, entries = _entry3.entries; // Only process entries if we haven't reached all percentiles
               if (!(percentileIndex >= percentiles.length)) {
-                _context.next = 18;
+                _context.next = 17;
                 break;
               }
-              return _context.abrupt("break", 21);
-            case 18:
+              return _context.abrupt("break", 20);
+            case 17:
               // Check if this entry matches any checkpoint percentiles
               if (viewportPercentage >= percentiles[percentileIndex]) {
                 elementNames = entries.map(function (e) {
@@ -178,21 +175,21 @@ var AbstractVCCalculatorBase = exports.default = /*#__PURE__*/function () {
                   return entryDataBuffer.add(e);
                 });
               }
-            case 19:
-              _context.next = 13;
+            case 18:
+              _context.next = 12;
               break;
-            case 21:
-              _context.next = 26;
+            case 20:
+              _context.next = 25;
               break;
-            case 23:
-              _context.prev = 23;
-              _context.t0 = _context["catch"](11);
+            case 22:
+              _context.prev = 22;
+              _context.t0 = _context["catch"](10);
               _iterator4.e(_context.t0);
-            case 26:
-              _context.prev = 26;
+            case 25:
+              _context.prev = 25;
               _iterator4.f();
-              return _context.finish(26);
-            case 29:
+              return _context.finish(25);
+            case 28:
               // Fill in any missing percentiles with the last known values
               previousResult = {
                 t: 0,
@@ -367,11 +364,11 @@ var AbstractVCCalculatorBase = exports.default = /*#__PURE__*/function () {
                 }
               }
               return _context.abrupt("return", vcDetails);
-            case 41:
+            case 40:
             case "end":
               return _context.stop();
           }
-        }, _callee, this, [[11, 23, 26, 29]]);
+        }, _callee, this, [[10, 22, 25, 28]]);
       }));
       function calculateWithDebugInfo(_x, _x2, _x3, _x4, _x5, _x6, _x7, _x8, _x9) {
         return _calculateWithDebugInfo.apply(this, arguments);

package/dist/cjs/vc/vc-observer-new/metric-calculator/fy25_03/index.js

@@ -64,7 +64,7 @@ var VCCalculator_FY25_03 = exports.default = /*#__PURE__*/function (_AbstractVCC
         if (!attributeName || KNOWN_ATTRIBUTES_THAT_DOES_NOT_CAUSE_LAYOUT_SHIFTS.includes(attributeName)) {
           return false;
         }
-        if (attributeName.startsWith('data-test') || attributeName === 'data-aui-version' || attributeName === 'data-testid' || attributeName === 'data-vc' || attributeName === 'data-ssr-placeholder' || attributeName === 'data-ssr-placeholder-replace' || attributeName === 'data-vc-nvs' || attributeName === 'data-media-vc-wrapper' || attributeName === 'data-renderer-start-pos' || attributeName === 'data-table-local-id' || attributeName === 'spellcheck' || attributeName === 'data-auto-scrollable' || attributeName === 'id' || attributeName === 'tabindex' || attributeName === 'data-is-ttvc-ready' || NON_VISUAL_ARIA_ATTRIBUTES.includes(attributeName) || THIRD_PARTY_BROWSER_EXTENSION_ATTRIBUTES.includes(attributeName) && (0, _platformFeatureFlags.fg)('platform_ufo_exclude_3p_extensions_from_ttvc')) {
+        if (attributeName.startsWith('data-test') || attributeName === 'data-aui-version' || attributeName === 'data-testid' || attributeName === 'data-vc' || attributeName === 'data-ssr-placeholder' || attributeName === 'data-ssr-placeholder-replace' || attributeName === 'data-vc-nvs' || attributeName === 'data-media-vc-wrapper' || attributeName === 'data-renderer-start-pos' || attributeName === 'data-table-local-id' || attributeName === 'spellcheck' || attributeName === 'data-auto-scrollable' || attributeName === 'id' || attributeName === 'tabindex' || attributeName === 'data-is-ttvc-ready' || attributeName === 'contenteditable' || attributeName === 'data-has-collab-initialised' || attributeName === 'translate' || NON_VISUAL_ARIA_ATTRIBUTES.includes(attributeName) || THIRD_PARTY_BROWSER_EXTENSION_ATTRIBUTES.includes(attributeName) && (0, _platformFeatureFlags.fg)('platform_ufo_exclude_3p_extensions_from_ttvc')) {
           return false;
         }
         return true;

package/dist/es2019/hidden-timing/index.js

@@ -57,6 +57,11 @@ export function setupHiddenTimingCapture() {
   }
 }
 export function getPageVisibilityState(start, end) {
+  // Input validation - return default for invalid inputs
+  if (!Number.isFinite(start) || !Number.isFinite(end)) {
+    return 'visible';
+  }
+
   // Desirable default value is visible
   if (timings.length === 0) {
     return 'visible';
@@ -69,19 +74,18 @@ export function getPageVisibilityState(start, end) {
   // currentSize is capped at SIZE.
   for (let i = 0; i < currentSize; i++) {
     const tmpIdx = (insertIndex + i) % currentSize;
-    if (timings[tmpIdx].time <= end) {
+    // Add bounds checking before accessing array element
+    if (timings[tmpIdx] && timings[tmpIdx].time <= end) {
       endIdx = tmpIdx;
       if (timings[tmpIdx].time <= start) {
         startIdx = tmpIdx;
       }
     }
   }
-  if (endIdx - startIdx === 0) {
-    if (timings[startIdx].hidden) {
-      hiddenState = 'hidden';
-    } else {
-      hiddenState = 'visible';
-    }
+
+  // Add bounds checking before accessing timings array
+  if (endIdx - startIdx === 0 && timings[startIdx]) {
+    hiddenState = timings[startIdx].hidden ? 'hidden' : 'visible';
   }
   return hiddenState;
 }

package/dist/es2019/vc/vc-observer-new/metric-calculator/abstract-base-vc-calculator.js

@@ -57,10 +57,7 @@ export default class AbstractVCCalculatorBase {
   }
   async calculateWithDebugInfo(filteredEntries, startTime, stopTime, isPostInteraction, isVCClean, interactionId, dirtyReason, allEntries, include3p) {
     var _window, _window2, _window3, _window5;
-    const percentiles = [25, 50, 75, 80, 85, 90, 95, 98, 99];
-    if (fg('platform_ufo_send_vc_100')) {
-      percentiles.push(100);
-    }
+    const percentiles = [25, 50, 75, 80, 85, 90, 95, 98, 99, 100];
     const viewportEntries = this.filterViewportEntries(filteredEntries);
     const vcLogs = await calculateTTVCPercentilesWithDebugInfo({
       viewport: {

package/dist/es2019/vc/vc-observer-new/metric-calculator/fy25_03/index.js

@@ -43,7 +43,7 @@ export default class VCCalculator_FY25_03 extends AbstractVCCalculatorBase {
       if (!attributeName || KNOWN_ATTRIBUTES_THAT_DOES_NOT_CAUSE_LAYOUT_SHIFTS.includes(attributeName)) {
         return false;
       }
-      if (attributeName.startsWith('data-test') || attributeName === 'data-aui-version' || attributeName === 'data-testid' || attributeName === 'data-vc' || attributeName === 'data-ssr-placeholder' || attributeName === 'data-ssr-placeholder-replace' || attributeName === 'data-vc-nvs' || attributeName === 'data-media-vc-wrapper' || attributeName === 'data-renderer-start-pos' || attributeName === 'data-table-local-id' || attributeName === 'spellcheck' || attributeName === 'data-auto-scrollable' || attributeName === 'id' || attributeName === 'tabindex' || attributeName === 'data-is-ttvc-ready' || NON_VISUAL_ARIA_ATTRIBUTES.includes(attributeName) || THIRD_PARTY_BROWSER_EXTENSION_ATTRIBUTES.includes(attributeName) && fg('platform_ufo_exclude_3p_extensions_from_ttvc')) {
+      if (attributeName.startsWith('data-test') || attributeName === 'data-aui-version' || attributeName === 'data-testid' || attributeName === 'data-vc' || attributeName === 'data-ssr-placeholder' || attributeName === 'data-ssr-placeholder-replace' || attributeName === 'data-vc-nvs' || attributeName === 'data-media-vc-wrapper' || attributeName === 'data-renderer-start-pos' || attributeName === 'data-table-local-id' || attributeName === 'spellcheck' || attributeName === 'data-auto-scrollable' || attributeName === 'id' || attributeName === 'tabindex' || attributeName === 'data-is-ttvc-ready' || attributeName === 'contenteditable' || attributeName === 'data-has-collab-initialised' || attributeName === 'translate' || NON_VISUAL_ARIA_ATTRIBUTES.includes(attributeName) || THIRD_PARTY_BROWSER_EXTENSION_ATTRIBUTES.includes(attributeName) && fg('platform_ufo_exclude_3p_extensions_from_ttvc')) {
         return false;
       }
       return true;

package/dist/esm/hidden-timing/index.js

@@ -57,6 +57,11 @@ export function setupHiddenTimingCapture() {
   }
 }
 export function getPageVisibilityState(start, end) {
+  // Input validation - return default for invalid inputs
+  if (!Number.isFinite(start) || !Number.isFinite(end)) {
+    return 'visible';
+  }
+
   // Desirable default value is visible
   if (timings.length === 0) {
     return 'visible';
@@ -69,19 +74,18 @@ export function getPageVisibilityState(start, end) {
   // currentSize is capped at SIZE.
   for (var i = 0; i < currentSize; i++) {
     var tmpIdx = (insertIndex + i) % currentSize;
-    if (timings[tmpIdx].time <= end) {
+    // Add bounds checking before accessing array element
+    if (timings[tmpIdx] && timings[tmpIdx].time <= end) {
       endIdx = tmpIdx;
       if (timings[tmpIdx].time <= start) {
         startIdx = tmpIdx;
       }
     }
   }
-  if (endIdx - startIdx === 0) {
-    if (timings[startIdx].hidden) {
-      hiddenState = 'hidden';
-    } else {
-      hiddenState = 'visible';
-    }
+
+  // Add bounds checking before accessing timings array
+  if (endIdx - startIdx === 0 && timings[startIdx]) {
+    hiddenState = timings[startIdx].hidden ? 'hidden' : 'visible';
   }
   return hiddenState;
 }

package/dist/esm/vc/vc-observer-new/metric-calculator/abstract-base-vc-calculator.js

@@ -111,12 +111,9 @@ var AbstractVCCalculatorBase = /*#__PURE__*/function () {
         return _regeneratorRuntime.wrap(function _callee$(_context) {
           while (1) switch (_context.prev = _context.next) {
             case 0:
-              percentiles = [25, 50, 75, 80, 85, 90, 95, 98, 99];
-              if (fg('platform_ufo_send_vc_100')) {
-                percentiles.push(100);
-              }
+              percentiles = [25, 50, 75, 80, 85, 90, 95, 98, 99, 100];
               viewportEntries = this.filterViewportEntries(filteredEntries);
-              _context.next = 5;
+              _context.next = 4;
               return calculateTTVCPercentilesWithDebugInfo({
                 viewport: {
                   width: getViewportWidth(),
@@ -126,31 +123,31 @@ var AbstractVCCalculatorBase = /*#__PURE__*/function () {
                 stopTime: stopTime,
                 orderedEntries: viewportEntries
               });
-            case 5:
+            case 4:
               vcLogs = _context.sent;
               vcDetails = {};
               percentileIndex = 0;
               entryDataBuffer = new Set();
               if (!vcLogs) {
-                _context.next = 29;
+                _context.next = 28;
                 break;
               }
               _iterator4 = _createForOfIteratorHelper(vcLogs);
-              _context.prev = 11;
+              _context.prev = 10;
               _iterator4.s();
-            case 13:
+            case 12:
               if ((_step4 = _iterator4.n()).done) {
-                _context.next = 21;
+                _context.next = 20;
                 break;
               }
               _entry3 = _step4.value;
               time = _entry3.time, viewportPercentage = _entry3.viewportPercentage, entries = _entry3.entries; // Only process entries if we haven't reached all percentiles
               if (!(percentileIndex >= percentiles.length)) {
-                _context.next = 18;
+                _context.next = 17;
                 break;
               }
-              return _context.abrupt("break", 21);
-            case 18:
+              return _context.abrupt("break", 20);
+            case 17:
               // Check if this entry matches any checkpoint percentiles
               if (viewportPercentage >= percentiles[percentileIndex]) {
                 elementNames = entries.map(function (e) {
@@ -172,21 +169,21 @@ var AbstractVCCalculatorBase = /*#__PURE__*/function () {
                   return entryDataBuffer.add(e);
                 });
               }
-            case 19:
-              _context.next = 13;
+            case 18:
+              _context.next = 12;
               break;
-            case 21:
-              _context.next = 26;
+            case 20:
+              _context.next = 25;
               break;
-            case 23:
-              _context.prev = 23;
-              _context.t0 = _context["catch"](11);
+            case 22:
+              _context.prev = 22;
+              _context.t0 = _context["catch"](10);
               _iterator4.e(_context.t0);
-            case 26:
-              _context.prev = 26;
+            case 25:
+              _context.prev = 25;
               _iterator4.f();
-              return _context.finish(26);
-            case 29:
+              return _context.finish(25);
+            case 28:
               // Fill in any missing percentiles with the last known values
               previousResult = {
                 t: 0,
@@ -361,11 +358,11 @@ var AbstractVCCalculatorBase = /*#__PURE__*/function () {
                 }
               }
               return _context.abrupt("return", vcDetails);
-            case 41:
+            case 40:
             case "end":
               return _context.stop();
           }
-        }, _callee, this, [[11, 23, 26, 29]]);
+        }, _callee, this, [[10, 22, 25, 28]]);
       }));
       function calculateWithDebugInfo(_x, _x2, _x3, _x4, _x5, _x6, _x7, _x8, _x9) {
         return _calculateWithDebugInfo.apply(this, arguments);

package/dist/esm/vc/vc-observer-new/metric-calculator/fy25_03/index.js

@@ -57,7 +57,7 @@ var VCCalculator_FY25_03 = /*#__PURE__*/function (_AbstractVCCalculator) {
         if (!attributeName || KNOWN_ATTRIBUTES_THAT_DOES_NOT_CAUSE_LAYOUT_SHIFTS.includes(attributeName)) {
           return false;
         }
-        if (attributeName.startsWith('data-test') || attributeName === 'data-aui-version' || attributeName === 'data-testid' || attributeName === 'data-vc' || attributeName === 'data-ssr-placeholder' || attributeName === 'data-ssr-placeholder-replace' || attributeName === 'data-vc-nvs' || attributeName === 'data-media-vc-wrapper' || attributeName === 'data-renderer-start-pos' || attributeName === 'data-table-local-id' || attributeName === 'spellcheck' || attributeName === 'data-auto-scrollable' || attributeName === 'id' || attributeName === 'tabindex' || attributeName === 'data-is-ttvc-ready' || NON_VISUAL_ARIA_ATTRIBUTES.includes(attributeName) || THIRD_PARTY_BROWSER_EXTENSION_ATTRIBUTES.includes(attributeName) && fg('platform_ufo_exclude_3p_extensions_from_ttvc')) {
+        if (attributeName.startsWith('data-test') || attributeName === 'data-aui-version' || attributeName === 'data-testid' || attributeName === 'data-vc' || attributeName === 'data-ssr-placeholder' || attributeName === 'data-ssr-placeholder-replace' || attributeName === 'data-vc-nvs' || attributeName === 'data-media-vc-wrapper' || attributeName === 'data-renderer-start-pos' || attributeName === 'data-table-local-id' || attributeName === 'spellcheck' || attributeName === 'data-auto-scrollable' || attributeName === 'id' || attributeName === 'tabindex' || attributeName === 'data-is-ttvc-ready' || attributeName === 'contenteditable' || attributeName === 'data-has-collab-initialised' || attributeName === 'translate' || NON_VISUAL_ARIA_ATTRIBUTES.includes(attributeName) || THIRD_PARTY_BROWSER_EXTENSION_ATTRIBUTES.includes(attributeName) && fg('platform_ufo_exclude_3p_extensions_from_ttvc')) {
           return false;
         }
         return true;

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@atlaskit/react-ufo",
-	"version": "4.6.1",
+	"version": "4.7.0",
 	"description": "Parts of React UFO that are publicly available",
 	"author": "Atlassian Pty Ltd",
 	"license": "Apache-2.0",
@@ -141,9 +141,6 @@
 		"platform_ufo_ssr_placeholder_resolution_ttvc_v3": {
 			"type": "boolean"
 		},
-		"platform_ufo_send_vc_100": {
-			"type": "boolean"
-		},
 		"platform_ufo_display_content_resolution_ttvc_v3": {
 			"type": "boolean"
 		},